Isaku Yamahata [Fri, 16 Dec 2016 23:06:18 +0000 (15:06 -0800)]
checkstyle: use our own checkstyle-suppressions.xml
The changeset of
f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a in odlparent
defines its own checktyle-suppressions.xml. so that neutron northbound
fails to build because unintented suppression rule is used.
Make it sure that intended supressions are used.
Change-Id: Ifb14d25e5b7b374515274ef9644e35fe64dde5a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
wangqianyu [Tue, 29 Nov 2016 01:32:06 +0000 (09:32 +0800)]
BUG-7259: pool-attributes have wrong description
n neutron-lbaasv2.yang, the description of healthmonitor-id in
pool-attributes is as follow:
leaf healthmonitor-id {
type yang:uuid;
description "List of healthmonitors
associated with this pool.";
}
here, healthmonitor-id is not a list, so the description need to be modified
Change-Id: I69709af3585bf66c8a4e25a239bc3e071e9bc809
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
wangqianyu [Tue, 15 Nov 2016 08:20:19 +0000 (16:20 +0800)]
BUG-7185 NeutronLoadBalancerListener has wrong xmlElement name
Fixes bug 7185
lb listener from openstack uses loadbalancers as xml key value,
so the XmlElement name of load_balancers in
NeutronLoadBalancerListener need to be changed to loadbalancers
Change-Id: Id05e4fedc9e516aca45f4c2fac4b3763ee9a1ed8
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
Isaku Yamahata [Sat, 12 Nov 2016 23:07:14 +0000 (15:07 -0800)]
NeutornLogger: print data when node is deleted
Log data of deleted node.
Change-Id: I84ae522cb49453f3d5d2b7812aecfe00628fa9dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 19 Oct 2016 23:10:38 +0000 (23:10 +0000)]
Merge "Bug 6938 - Handle unknown protocol name as bad request"
Ryan Goulding [Wed, 19 Oct 2016 17:38:43 +0000 (13:38 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: I36e42dac7ccc13f0f796bb95a28a6f30f141b05c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Ritu Sood [Tue, 18 Oct 2016 01:32:54 +0000 (18:32 -0700)]
Bug 6938 - Handle unknown protocol name as bad request
Fwaas, security group rule handled unknown protocol
name as internal server error. Changed that to respond
with bad request. lbaas ignored the wrong protocol field.
Also chaged that to respond with bad request.
Change-Id: I681d67b8704015b392ee811b0f4b1556a63b5809
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Anil Vishnoi [Thu, 6 Oct 2016 02:22:17 +0000 (19:22 -0700)]
Bug 6865 - Transcriber skips the uppercase protocol field
Networking-sfc sends protocol string in lowercase
(e.g tcp and not TCP), but neutron spi try to find
it using the uppercase and don't find it and
eventually ignore this field. To be consistent with
other API's, flow classifier will only accept lowercase
protocol name and return 400 (Bad Request) for any other
protocol string.
Change-Id: I204f58c9cf1cf13446122c8f818ce498866a2caf
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Ritu Sood [Thu, 22 Sep 2016 02:20:01 +0000 (19:20 -0700)]
Fix checkstyle issues related to exception handling
This is based on the Guidelines given here
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch
Change-Id: I70f9841f706c8d5c38b0834dba04b79ad8fbfa71
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 23:16:53 +0000 (23:16 +0000)]
Merge "sonar: Move this trailing comment on the previous empty line."
Isaku Yamahata [Thu, 6 Oct 2016 23:16:46 +0000 (23:16 +0000)]
Merge "sonar: use dedicated exception instead of RuntimeException"
pramod [Sat, 24 Sep 2016 08:39:23 +0000 (01:39 -0700)]
Bug 6796 - Fixes Priority bugs in integration-test
1.NeutronL2gatewayConnectionNorthbound.java:118,
EC_UNRELATED_TYPES, Priority: High
This method calls equals(Object) on two references of different class
types and analysis suggests they will be to objects of different
classes at runtime
2.NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE
This method calls equals(Object) on two references, one of which is a
class and the other an interface,where neither the class nor any of
its non-abstract subclasses implement the interface.
3.NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES - Same as 1st
Bug
Change-Id: I23cda778f807ba02179c7d9d4e682b9561a378d4
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 18:00:27 +0000 (11:00 -0700)]
sonar: Move this trailing comment on the previous empty line.
remove trailing comment by moving it on the previous empty line.
Change-Id: I72d7e93dd4d60c4773b437c36368d3297e8154d4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 6 Oct 2016 17:56:54 +0000 (10:56 -0700)]
sonar: use dedicated exception instead of RuntimeException
use IllegalArgumentException instead of RuntimeException
Change-Id: I32c17078499ff3cfd17f2d3b445a3e1bdac99574
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 02:30:48 +0000 (19:30 -0700)]
remove unused inUse method
Change-Id: I10053b258e899324c30fff836c9ebd88c2ef216c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 00:15:03 +0000 (17:15 -0700)]
transscriber: consolidate createInstanceIdentifier(T item)
Consolidate InstanceIdentifier<T> createInstanceIdentifier(T item)
into AbstractNeutronInterface.
Change-Id: If6aedc24d9cc4a15cefa7c21ce3d00c51610c0f0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 07:46:05 +0000 (00:46 -0700)]
transcriber: consolidate createInstanceIdentifier()
This patch consolidate createInstanceIdentifier() into parent class.
Change-Id: I6acf69e2ac328bf71cff3efbd846a72db02df6a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 06:17:28 +0000 (23:17 -0700)]
transcriber: refactor fromMd/toMd logic
Since there are several common fields like id, tenant_id, name,
admin_state_up status, factor out those common logic.
Change-Id: If5b11321769890d075eb6a331f1f013de4b5295a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 30 Sep 2016 06:10:59 +0000 (23:10 -0700)]
spi: consolidate common member
Since some fields are common to neutron resource, name, status, admin_state_up,
introduce common parent interfaces/classes to consolidate them.
Change-Id: Ie8b654010f0cf780eaa958b49d38b1ed72847961
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 4 Oct 2016 00:12:25 +0000 (17:12 -0700)]
AbstractNeutronNorthbound: make cast more accurate
Change-Id: I5cd28faedcbe037ae976e038f3f70ecae644f857
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 27 Sep 2016 04:37:26 +0000 (21:37 -0700)]
spi: consolidate extractFields logic
NeutronObject is common class to have id and tenant_id.
So consolidate extractFields logic to extract them into NeutronObject.
Change-Id: I1e79da6fca9824dbd0563fc09c2dd34843dd99ac
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 22 Sep 2016 18:52:10 +0000 (11:52 -0700)]
sonar: hide NeutronCRUDInterfaces construtor
The class is utility class to have only static method.
Hide public construct not to instantiate it.
Change-Id: Ib78e179c7ec540e0604f2be8c8be65400c1e6f82
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 22 Sep 2016 00:32:21 +0000 (00:32 +0000)]
Merge "Adds SFC Integration test cases"
pramod [Tue, 20 Sep 2016 03:00:06 +0000 (20:00 -0700)]
Adds SFC Integration test cases
Change-Id: Ie6844549f939123687226c3cbde0cd6239a85926
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Ritu Sood [Wed, 21 Sep 2016 02:03:38 +0000 (19:03 -0700)]
Checkstyle exception handling fix (Neutron-spi)
Fixing checkstyle violations in the neutron-spi
integration tests
Change-Id: Ic7a1ed9ea6b4c9362fa73df550825da9e34e00e8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Sat, 17 Sep 2016 04:43:39 +0000 (21:43 -0700)]
Bug 6736: Fix incorrect destination ip prefix value
Value of destination ip prefix read from mdsal
is not correct
Change-Id: I712097aed98bf1d5db581de8d3a8b254065adbef
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Thu, 15 Sep 2016 09:17:22 +0000 (02:17 -0700)]
spi: NeutronCRUDInterfaces remove unused mothos
remove unused methods in NeutronCRUDInterfaces
Change-Id: I236ad8e294dc40a0fb7055faf56379f00b800d76
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 13 Sep 2016 15:50:29 +0000 (08:50 -0700)]
northbound: simplify neutron interface loading
Now subnets/ports/routers northbound doesn't need dependent
interface. So getNeutronInterface() can be removed.
Change-Id: I7a78ec35a0b7f2efa79840672e257cc7e5724457
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 9 Sep 2016 22:27:21 +0000 (22:27 +0000)]
Merge "Bug 6641: Fix ip_address in allowed_address_pairs info"
Sridhar Gaddam [Tue, 6 Sep 2016 10:46:02 +0000 (16:16 +0530)]
Bug 6641: Fix ip_address in allowed_address_pairs info
Change-Id: Id612243cbdc6ab8db8d66ce46ca2973a0effc0ee
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Isaku Yamahata [Wed, 7 Sep 2016 15:10:52 +0000 (15:10 +0000)]
Merge "Neutron-Logger: add final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:48 +0000 (15:10 +0000)]
Merge "transcriber: sprinkle final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:43 +0000 (15:10 +0000)]
Merge "northbound: code clean up"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:35 +0000 (15:10 +0000)]
Merge "neutron-spi: sprinkle final to concrete class"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:52 +0000 (15:03 +0000)]
Merge "simplify NeutronTranscriberProvider"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:46 +0000 (15:03 +0000)]
Merge "Add NeutronSubnetJAXBTest unit test"
Isaku Yamahata [Wed, 7 Sep 2016 08:16:18 +0000 (01:16 -0700)]
Neutron-Logger: add final to public class
Change-Id: I44806c78dc34e8fe2575441f28a774889ac0beda
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 08:14:58 +0000 (01:14 -0700)]
transcriber: sprinkle final to public class
Change-Id: I48d6961a7e774957da1a4120c2ecb36045fee2d1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 08:04:06 +0000 (01:04 -0700)]
northbound: code clean up
- sprinkle final to public class
- remove unused variable, uriinfo
- misc improvements
Change-Id: Ied5692ef500a768949e7a010266953b097790d7f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 7 Sep 2016 07:43:10 +0000 (00:43 -0700)]
neutron-spi: sprinkle final to concrete class
Change-Id: I73453299f8ce890309fc7df7c1147f39742d2659
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 3 Sep 2016 00:19:31 +0000 (17:19 -0700)]
simplify NeutronTranscriberProvider
remove unused variables to simplify NeutronTranscriberProvider.
Change-Id: I1d8e7ac5e9506d752ed725920282662d0d73e8d2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Sat, 3 Sep 2016 00:02:55 +0000 (17:02 -0700)]
consolidate NeturonCRUDInterface.fetchNeturonCRUD logic
The logic are mostly same, consolidate them by generics.
Change-Id: I4a38de02b2a11f355581702a711fe9244d835701
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 2 Sep 2016 22:40:48 +0000 (15:40 -0700)]
northbound: make newNeutronRequest concrete method
By this change, about 120 lines are reduced.
Change-Id: Id4838b4e5109d92f01e18e611e869c27b56371e9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 2 Sep 2016 15:35:41 +0000 (15:35 +0000)]
Merge "sort out signature of extraceField method"
Isaku Yamahata [Thu, 1 Sep 2016 21:54:23 +0000 (14:54 -0700)]
Add NeutronSubnetJAXBTest unit test
Change-Id: I62ddd9e0e4ae83866e50e170695871e6891105f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 1 Sep 2016 16:21:33 +0000 (09:21 -0700)]
sort out signature of extraceField method
So far, the signature of extractField was not defined cleanly.
Define it clean and simplify convoluted code due to it.
Change-Id: I48387b8df50bd019a735e6272a3850adfd10b0d5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Thu, 1 Sep 2016 14:08:09 +0000 (07:08 -0700)]
remove unused variable/method
Change-Id: Ide5eaee4ddef280cc2737f2d196691a805ee01f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 26 Aug 2016 06:46:20 +0000 (23:46 -0700)]
northbound: simplify Neutron*Request
Consolidate Neutron*Request logic and make them consistent a bit.
Change-Id: I5b4a62ea14813b1656bc30de944f862e4e0ccec5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Ritu Sood [Tue, 16 Aug 2016 03:50:16 +0000 (20:50 -0700)]
Enable checkstyle enforcement for the project
This patch enables checkstyle enforcements.
Also some checkstyle issues are not yet addressed
and those are added to the suppress file for now.
As some of those issues are addressed those will
be removed for the suppress file. The checkstyle
issues suppressed show as warnings during
compile.
Change-Id: I1c64aa426de7d29002e66c50367bbe84f23d885c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Tue, 16 Aug 2016 03:20:07 +0000 (20:20 -0700)]
Checkstyle misc issues fix(Integration)
Patch fixes EmptyStatement, ModifierOrder, MethodName,
LineLength, RegexpSinglelineJava checkstyle issues for
integration tests files.
Change-Id: Ia81cb6ad86831b66d6e08ecfd37a68c3bf31a624
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Isaku Yamahata [Tue, 16 Aug 2016 19:18:26 +0000 (19:18 +0000)]
Merge "Checkstyle indentation issues fix(Logger)"
Ritu Sood [Mon, 15 Aug 2016 23:49:58 +0000 (16:49 -0700)]
Checkstyle indentation issues fix(Logger)
Patch fixes indentation checkstyle
issues for logger file
Change-Id: I8f81976cbea06c3275430f07f5b4e040ef6a4735
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Mon, 15 Aug 2016 23:27:12 +0000 (16:27 -0700)]
Checkstyle imisc issues fix(Transcriber)
Patch fixes OverloadMethodsDeclarationOrder, MemberName and
LineLength checkstyle issues for transcriber files
Change-Id: Id19b977735448a309c9c49c3674f62c4efb5ac4b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 04:54:04 +0000 (21:54 -0700)]
Checkstyle formatting issues fix (Integration)
Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
integration files.
Change-Id: Icd348dd86813c7682428361db90190b84a6958ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 05:15:11 +0000 (22:15 -0700)]
Checkstyle formatting issues fix (Logger)
Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
logger files.
Change-Id: I7e763dc1b097e70d4b2c5af231709d0861d33654
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 04:07:43 +0000 (21:07 -0700)]
Checkstyle formatting issues fix (Transcriber)
Patch fixes WhitespaceAround, OperatorWrap,
LineLength and other formatting checkstyle issues for
transcriber files.
Change-Id: I71fa7937648fb07dd8a8eb53c7683a47953c87ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 03:48:59 +0000 (20:48 -0700)]
Checkstyle misc issues fix(Northbound API)
Patch fixes VariableDeclarationUsageDistance, RedundantModifier,
OverloadMethodsDeclarationOrder checkstyle issues for
northbound api files.
Change-Id: If6f91851648e5a10094f0c6c03e07983ebca08f0
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 01:30:28 +0000 (18:30 -0700)]
Checkstyle formatting issues fix (Northbound API)
Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
northbound api files.
Change-Id: I11123566ee4d96f3310c74834e9d0977af80f8f8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Fri, 12 Aug 2016 01:03:57 +0000 (18:03 -0700)]
Checkstyle formatting issues fix (SPI)
Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
neutron-spi files.
Change-Id: Iafb65de2f544212e655d497d5e39a4bcb7f32b76
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Thu, 11 Aug 2016 22:40:16 +0000 (15:40 -0700)]
Checkstyle Import issues fix (Transcriber)
Patch fixes Import order issues and also removes
the unused imports. Patch is for transcriber.
Change-Id: Ib247eebb771ec66bd60f67cf457cf248f2dbf565
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Thu, 11 Aug 2016 22:32:47 +0000 (15:32 -0700)]
Checkstyle Import issues fix (SPI tests,Northbound API)
Patch fixes Import order issues and also removes
the unused imports. Patch is for spi tests,
northbound api.
Change-Id: I005975da29580140e28a4667b54729710857d362
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Thu, 11 Aug 2016 22:22:44 +0000 (15:22 -0700)]
Checkstyle Import issues fix (SPI, Model)
Patch fixes Import order issues and also removes
the unused imports. Patch is for Integration tests,
spi and model
Change-Id: I5565cf9f83ba9bc3092ebaa8c40c8d3056821e72
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Thanh Ha [Tue, 9 Aug 2016 14:03:08 +0000 (10:03 -0400)]
Bump ietf versions to ...10-SNAPSHOT
Bump versions according to:
https://lists.opendaylight.org/pipermail/release/2016-August/007731.html
Change-Id: Iced0c6aa67afea7022dcef70ab4dbb098dbf098a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 9 Aug 2016 04:58:51 +0000 (00:58 -0400)]
Fix ietf-yang-types version
The version bump script messed up the ietf-yang-types version. Fixing it
with this patch.
Change-Id: I09c85b68b79e98f129297250c5ed69d1f58a235c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Mon, 8 Aug 2016 21:50:17 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle
Change-Id: I5763bc1e3fe66570d0944ef515a7142608678cb9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Isaku Yamahata [Thu, 4 Aug 2016 18:58:57 +0000 (11:58 -0700)]
Remove unused controller's jersey dependency
Change-Id: I4e42c9bf9c82eb26404f0745f4c08fee92df0126
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 2 Aug 2016 17:23:08 +0000 (17:23 +0000)]
Merge "Adds Postman scripts to verify the API of QOS feature"
pramod [Thu, 28 Jul 2016 07:01:11 +0000 (00:01 -0700)]
Adds Postman scripts to verify the API of QOS feature
The postman scripts can be imported into postman to make the REST calls
for Creating, Updating and deleting the QOS policies.
Change-Id: Id9c452d3c80cf0c79f32f783c96e0f2ed7b044bf
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Isaku Yamahata [Tue, 2 Aug 2016 00:10:20 +0000 (17:10 -0700)]
Bug 6327 - transcriber port security group
SecurityGroup of Port includes only lists of uuids of security group.
Its contents aren't necessary on fromMd().
remove unnecessary logic to fulfill SecurityGroups.
Change-Id: I17bde352c842236b83d4c7b2bd1ffeebbf1c8211
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Pramod [Fri, 15 Jan 2016 19:35:25 +0000 (11:35 -0800)]
This Increases the test coverage of the Neutronbgpvpn
Modified the tests to improve the code coverage
Change-Id: I26e9f47c22d4d0199fcdec451382aa3ecc50fdd2
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>
Thanh Ha [Sat, 23 Jul 2016 02:53:59 +0000 (22:53 -0400)]
Add missing license headers
Change-Id: I9b8fa15d5b42585826e8b4b21fef0547d8e1a4db
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Ritu Sood [Sun, 17 Jul 2016 06:30:27 +0000 (23:30 -0700)]
Add Qos transcriber file and n/w and port extensions
Patches adds changes to implement transcriber
functionality for Qos feature. Also added code to support
network and port extensions for Qos.
Depends on the other Qos patches
https://git.opendaylight.org/gerrit/#/c/37165/
Change-Id: I29a539a5d980330b80ba3fe319e1ec823d0e2491
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
pramod [Tue, 5 Apr 2016 23:46:55 +0000 (16:46 -0700)]
Adds the "Quality of Service" to the OpenDayLight Neutron
This patch enables the Quality of Service feature in the OpenDayLight
Neutron.
The implementation is done as follows
1. Defining the YANG model
2. Implementing of API
3. Testing the developed API
The QOS is achieved using either limiting the bandwidth or through
DSCP marking
Data model -
https://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html
This link has the data model changes as suggested by the OpenStack
Neutron for the QOS feature
API -
http://developer.openstack.org/api-ref-networking-v2-ext.html#qos-ext
This link has the API for the Openstack for the QOS feature
Change-Id: I7074dbb6d494b1267b66a925742e9812ef8a9304
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
Isaku Yamahata [Tue, 19 Jul 2016 20:03:59 +0000 (20:03 +0000)]
Merge "Security rule: tests to exercise int as protocol"
Isaku Yamahata [Fri, 15 Jul 2016 19:48:12 +0000 (12:48 -0700)]
make neutron.yang consistent
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Change-Id: Iee560804c49fc3cc6f193e1d52576d11e84e8cd4
Isaku Yamahata [Sat, 18 Jun 2016 01:36:57 +0000 (18:36 -0700)]
yang model for neutron extensions api
This patch defines a yang model for neutron extension api [1].
Through this model, openstack service provider is able to tell networking-odl
which neutron extensions are supported.
[1] http://developer.openstack.org/api-ref-networking-v2-ext.html#neutron_extensions
Change-Id: I68fc840545d260486fb7ab2e9cab10b9628daf1a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 15 Jul 2016 19:17:21 +0000 (12:17 -0700)]
Security rule: tests to exercise int as protocol
Enhance tests to exercise more patterns in protocol of security group
rule. It accepts not only protocol name and also integer.
This patch is follow up patch for Bug 6112.
Change-Id: Ic3a944f1612dd67a0366b610ad77ad92c948eb07
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Thanh Ha [Wed, 13 Jul 2016 15:14:42 +0000 (15:14 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Isaku Yamahata [Mon, 11 Jul 2016 20:46:21 +0000 (20:46 +0000)]
Merge "drop unnecessary executable flag of .gitignore"
Isaku Yamahata [Mon, 11 Jul 2016 20:46:01 +0000 (20:46 +0000)]
Merge "Fix for multiple external fixedIPs under router-ext-gw-info"
Isaku Yamahata [Mon, 11 Jul 2016 19:17:07 +0000 (12:17 -0700)]
drop unnecessary executable flag of .gitignore
Change-Id: I9bc0049f01db2c7c7f4f0c4b6e34d2b94da10da6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Mon, 11 Jul 2016 18:19:26 +0000 (18:19 +0000)]
Merge "remove dummyprovider"
Isaku Yamahata [Mon, 11 Jul 2016 18:01:40 +0000 (18:01 +0000)]
Merge "remove unused methods"
Abhinav Gupta [Fri, 8 Jul 2016 07:43:05 +0000 (13:13 +0530)]
Fix for multiple external fixedIPs under router-ext-gw-info
Updated the key to use both subnetID and fixedIP to allow multiple
fixedIPs per subnet to be configured.
Bug ID: https://bugs.opendaylight.org/show_bug.cgi?id=5723
Change-Id: Ib0bd24229ed3891275eb5dc5d02c0afd52065d41
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Isaku Yamahata [Sat, 9 Jul 2016 01:27:34 +0000 (18:27 -0700)]
remove unused methods
Change-Id: Ib7259505f4e289a7a356879a8fa2f87f224c460a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 8 Jul 2016 23:49:31 +0000 (16:49 -0700)]
Bug 6015 - Null Pointer Exception AbstractNeutronNorthbound#create
When invalid body is passed to northbound API, request has
singleton = null and bluk=null. which causes null pointer exception.
This patch adds null pointer check to return bad request.
> 2016-07-08 16:41:03,049 | ERROR | qtp907264148-112 | ContainerResponse | 84 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at org.opendaylight.neutron.northbound.api.AbstractNeutronNorthbound.create(AbstractNeutronNorthbound.java:70)[247:org.opendaylight.neutron.northbound-api:0.7.0.SNAPSHOT]
> at org.opendaylight.neutron.northbound.api.NeutronSecurityGroupsNorthbound.createSecurityGroups(NeutronSecurityGroupsNorthbound.java:155)[247:org.opendaylight.neutron.northbound-api:0.7.0.SNAPSHOT]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.8.0_91]
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)[:1.8.0_91]
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_91]
> at java.lang.reflect.Method.invoke(Method.java:498)[:1.8.0_91]
> at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[84:com.sun.jersey.jersey-server:1.17.0]
> at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[215:com.sun.jersey.servlet:1.17.0]
> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[215:com.sun.jersey.servlet:1.17.0]
> at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[215:com.sun.jersey.servlet:1.17.0]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[184:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:61)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.AdviceFilter.executeChain(AdviceFilter.java:108)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.AdviceFilter.doFilterInternal(AdviceFilter.java:137)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.ProxiedFilterChain.doFilter(ProxiedFilterChain.java:66)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.AbstractShiroFilter.executeChain(AbstractShiroFilter.java:449)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.AbstractShiroFilter$1.call(AbstractShiroFilter.java:365)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.subject.support.SubjectCallable.doCall(SubjectCallable.java:90)[225:org.apache.shiro.core:1.2.5]
> at org.apache.shiro.subject.support.SubjectCallable.call(SubjectCallable.java:83)[225:org.apache.shiro.core:1.2.5]
> at org.apache.shiro.subject.support.DelegatingSubject.execute(DelegatingSubject.java:383)[225:org.apache.shiro.core:1.2.5]
> at org.apache.shiro.web.servlet.AbstractShiroFilter.doFilterInternal(AbstractShiroFilter.java:362)[226:org.apache.shiro.web:1.2.5]
> at org.apache.shiro.web.servlet.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:125)[226:org.apache.shiro.web:1.2.5]
> at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[198:org.ops4j.pax.web.pax-web-jetty:3.2.6]
> at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[198:org.ops4j.pax.web.pax-web-jetty:3.2.6]
> at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[198:org.ops4j.pax.web.pax-web-jetty:3.2.6]
> at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.Server.handle(Server.java:370)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1033)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:651)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[189:org.eclipse.jetty.aggregate.jetty-all-server:8.1.17.v20150415]
> at java.lang.Thread.run(Thread.java:745)[:1.8.0_91]
Change-Id: Id099c6e08dc4193e9991aab8605e24c7eb01f19b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 6 Jul 2016 06:02:47 +0000 (23:02 -0700)]
add -Xlint:unchecked and -Xlint:deprecation to compiler argument
This patch adds compiler option -Xlint:unchecked and -Xlint:deprecation
and remove their warnings.
Change-Id: I3f1c4b8411da480cfb86671819cb88f78ae32ccf
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Wed, 6 Jul 2016 04:50:40 +0000 (21:50 -0700)]
parent/pom.xml: don't user java 1.7, but the one odlparent uses
Now odl migrated to java 1.8. There is no point to fix
compiler version to 1.7.
Change-Id: I59f7131d9a81ee0dee0e36c31818084505f404b8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Lorand Jakab [Thu, 23 Jun 2016 21:21:59 +0000 (16:21 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: Iea916536d5d33486db29c4f8bad122a22c9b903f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
Isaku Yamahata [Tue, 28 Jun 2016 21:22:46 +0000 (14:22 -0700)]
remove dummyprovider
Now dummyprovider does nothing but provider feature name.
This patch removes dummyprovider
Change-Id: I523fc69552053b54f8c7a780fcc7bd3bd8bf8fce
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Fri, 1 Jul 2016 17:53:06 +0000 (17:53 +0000)]
Merge "Logger on neutron model"
Hideyuki Tai [Fri, 1 Jul 2016 11:52:42 +0000 (04:52 -0700)]
Removed repository and snapshotRepository sections
Some POM files defined the repository and snapshotRepository information
in their distributionManagement section. However, they inherits these
information from their ancestor POM, odlparent-lite, so they do not need
to have those sections. This patch removed those unnecessary sections.
Change-Id: I0038028917f570f2fa3a6aaf570a77798a3d3563
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
Isaku Yamahata [Sat, 27 Feb 2016 09:28:04 +0000 (01:28 -0800)]
Logger on neutron model
This patch implements logger on neutron model change for debug.
Change-Id: Ifd079de8cded725d79ec2fe638415ab7be640318
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Anil Vishnoi [Fri, 1 Jul 2016 01:19:01 +0000 (18:19 -0700)]
OpenDaylight Networking SFC Port Chain REST APIs
This patch defines REST API's in Neutron Northbound project
for the networking sfc port chain APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc port chain Yang models. These Neutron
Northbound REST API's are defined based on the OpenStack
Networking-SFC Port Chain APIs available at following URL.
http://docs.openstack.org/developer/networking-sfc/api.html#rest-api
Change-Id: Icb9f581157ce150d846dad6d6321c40a9e642e1b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Sun, 26 Jun 2016 23:10:56 +0000 (16:10 -0700)]
OpenDaylight Networking SFC Port Pair Group REST APIs
This patch defines REST API's in Neutron Northbound project
for the networking sfc port pair group APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc port pair group Yang models. These Neutron
Northbound REST API's are defined based on the OpenStack
Networking-SFC Port Pair Group APIs available at following URL.
http://docs.openstack.org/developer/networking-sfc/api.html#rest-api
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Ib25544b711873983be7733ec552328220fd8a85d
Anil Vishnoi [Sun, 26 Jun 2016 21:48:43 +0000 (14:48 -0700)]
OpenDaylight Networking SFC Port Pair REST APIs
This patch defines REST API's in Neutron Northbound project
for the networking sfc port pair APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc Yang models. These Neutron Northbound REST
API's are defined based on the OpenStack Networking-SFC Flow
Classifier APIs available at following URL.
http://docs.openstack.org/developer/networking-sfc/api.html#rest-api
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Ie8b3bf725e492443ac4b0056c255a71e16b1635a
Anil Vishnoi [Sat, 25 Jun 2016 03:10:14 +0000 (20:10 -0700)]
OpenDaylight Networking SFC Flow Classifier REST APIs
This patch defines REST API's for the networking sfc flow
classifier API and implementation the translation code
to convert these REST API data to the networking-sfc
Yang models. These Neutron Northbound REST API's are defined
based on the OpenStack Networking-SFC Flow Classifier APIs
available at following URL.
http://docs.openstack.org/developer/networking-sfc/api.html#rest-api
Change-Id: Ifcdec7025715c1e9fa5f90aa9cbc475e7a1e9427
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Mon, 27 Jun 2016 21:18:26 +0000 (14:18 -0700)]
Mapping Exception caused by Overloaded NeutronObject#setTenantId()
Overloaded method for json property is causing Mapping Exception
com.fasterxml.jackson.databind.JsonMappingException:
Conflicting setter definitions for property tenantID:
org.opendaylight.neutron.spi.NeutronObject#setTenantID(1 params)
vs org.opendaylight.neutron.spi.NeutronObject#setTenantID(1 params)
Change-Id: I6278268203e5a3c593b260df02fb4a6143213d26
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Isaku Yamahata [Tue, 28 Jun 2016 05:07:55 +0000 (22:07 -0700)]
add blueprint wiring for neutron/transcriber
Change-Id: I502d78e17ec956f1bdf0c12907e6fdbb2dfcf35d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Isaku Yamahata [Tue, 21 Jun 2016 17:49:07 +0000 (17:49 +0000)]
Merge "AbstractNorthbound: remove unused variables"