Adopt yangtools-9.0.5

yangtools-9.0.4 contains a regression, pick up the fix for it.

Change-Id: If5470573a6203a6be08ac1d2ecc56def1226b2ad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I7a790248dc1747bfb87e3669044256833230e322
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix AbstractDOMRoutingTable.{add,remove}All()

Our naive implementation breaks down if we are registering multiple
items, as we end up adding unmodified entries each and every time.

Fix this up by decomposing identifiers in the caller, keeping them in a
table and then have addAll()/removeAll() work on the table, with careful
checks.

JIRA: MDSAL-796
Change-Id: I0a52763e047026c1a641d9a25d82ee1d193fd573
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6de97609d101ed52828c7e7dd1b30a4acd4b7411)

Make invertImplementationsMap() static

This method is not touching staste, make it static to make that clear.

Change-Id: I1c6366c3f36bae4a8b77c84edeea9e8770eae968
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 81acc2178413137f7dbbbc5405d45b893d426984)

Bump upstreams

Adopt:
- odlparent-11.0.3
- yangtools-9.0.4

Change-Id: I9d1945f0617f0e18637d3c20d65d2f340e4b9f56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BindingReflections.isSubstitutionFor()

This method is used only in mdsal-binding-dom-codec, deprecate it for
removal.

Change-Id: I188f0d14b10f72bce2561c6e80e087a230eb5b4b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b6464dda4b14403bc8a3aababaf68979e9826026)

Deprecate BindingReflections.isNotification()

This methods is only used internally and in tests, deprecate it for
removal.

Change-Id: I1c4b5b863c20caa5056a5db505921ff512cdeba8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 8002a60cc4e66c947b33086e01edd663a367649f)

Qualify FIXME

Attach issue reference to the pre-existing FIXME.

JIRA: MDSAL-785
Change-Id: Ic09ae54a8b8219703ccefc038df5d295e27b22c5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6ddb2bfd9baa05be8045e10ad1faf0990a2b6fe9)

Deprecate BindingReflections.getChildrenClass*

These methods are only used by mdsal-binding-dom-codec, deprecate them.

Change-Id: I9ba5a82bfab437640c76625a316e60c4902099fc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 6b60710011afa258f0cd901f5c526e86dbcc8ef2)

Deprecate BindingReflections.resolveRpc{In,Out}putClass()

These methods are not used anywhere, deprecate them.

Change-Id: I10cd81e4a52f52edcbcb1cb0be5621270633e9a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 62422256a713c5fa228ce629fb3438528d347877)

Bump yangtools to 9.0.3

Pick up latest fixes from upstream.

Change-Id: Icc1fc2759d211a0945ffab755160613ae0335afd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RpcProviderService documentation

We have largely-undocumented methods. Add documentation.

Change-Id: I7b12ba2d412d6de276e4c62277ff3c852e72a996
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit eac3d7d52b8be1a3c3d92de0f01eeddb3933ff46)

Require union field to be set

Do not allow an union type object to be costructed without supplying one
of its alternatives.

JIRA: MDSAL-792
Change-Id: I69a9dc3f0094cc9ff03d0846d5f9dcc746417628
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 3830f29ff52775324072a30e8cc3bc9b9a41233f)

Bump versions to 10.0.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I05e2cdf01a12ba0eb2dc7db820f3c24d36aec73a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename ModuleInfoSnapshotResolver

We are masquerading as the binding-dom-codec, but that is not accurate.
Use our name instead.

Change-Id: I930976e96b22bbb070d1a02ccd28bfa86a59cf1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit be0712cdd256eba813db3e3a712e06ee72a7f115)

Modernize ModuleInfoSnapshotResolver a bit

Use local variable type inference and streams to transform things.
This reduces the verboseness a bit.

Change-Id: I9ec9bf70c7f90b4cd264e9f239b96ddff60bc0cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d1c5088020b0b0d8693d2252ff2c4248a2cbccba)

Simplify YangModuleInfoScanner

We will be tracking YangFeatureProviders, so
List<ObjectRegistration<YangModuleInfo>> is not quite accurate. Track
only a simple Registration and make sure we wrap the return from
ModuleInfoSnapshotResolver.

Also improve the tracking logic a bit: do not track bundles which do not
contain YangModuleInfos, but make a special exception for the system
bundle.

JIRA: MDSAL-791
Change-Id: I245f25c72152f7e49817c316f63ace557b4c56c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 221a5985063800dc59fb5d3af354f7dd6291b775)

Remove unneeded suppression

We are catching only checked exceptions, no need for the suppression.

Change-Id: Ib19174db68934d058d3ec9352653e2d19762a164
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9baca019ed754a2a3150dcca0dae776388f20dd5)

SimpleDOMQueryResult should be a record

This is a simple reference holder with some accessors, turn it into a
record.

Change-Id: I76f66684f805f1938b621229a35e2efe91ab502e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 32d5a74bd0893ad62e37d8764e863b8a59959bcd)

Deprecate BindingReflections.isAugmentationChild()

This method is used only in test, deprecate it for removal.

Change-Id: I894429041302163288036085a1af4718d5e28a83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit ba23d6f0530dbabb99868158b6a3ffbad978dc3d)

Deprecate BindingReflections.findHierarchicalParent()

These methods are not used, deprecate them for removal.

Change-Id: Idee358f004fb36fb01a3c5222430a808dd68bbfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c422bbd24a03f0f335151d0544a13f31b9467f50)

Bump upstreams

Adopt the following:
- odlparent-11.0.2
- yangtools-9.0.2

Change-Id: I2032cb89f0fa1868afb7c3017ea6820c4d2bbe09
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate BindingMapping.NOTIFICATION_LISTENER_SUFFIX

This is part of the NotificationListener specification, it needs to be
deprecated just as the rest of it is.

Change-Id: I61996af51b9f8bc67b986cefdc8abf98bdc2ac7c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I2434badf754ee6f6845ee7f090f78e597f0d5af0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for TypeObjects

Fix warnings about missing javadoc in TypeObject classes.

Add setting of YangSourceDefinition when building GeneratedType
for TypeObject so JavaFileTemplate.appendSnippet() generate javadoc
for this class.

Generation of javadoc was added for all TypeObjects not only
ScalarTypes as described in corresponding task.

JIRA: MDSAL-762
Change-Id: Iec3ab9e36bcea0807892bd024b7f04c451ff9000
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up AbstractEnumerationBuilder

We can use Java 17, fluent StringBuilder and streams to make the code
denser.

Change-Id: Id0b8bc176076469120fddbb993e9a59215aa660a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate status in feature classes

When we have a deprecated or obsolete identity, the resulting interface
should be marked as deprecated, perhaps for removal.

JIRA: MDSAL-770
Change-Id: I2b1204b2afcd4b2786c0c76695c1d58304349f57
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Propagate status in identity classes

When we have a deprecated or obsolete identity, the resulting interface
should be marked as deprecated, perhaps for removal.

JIRA: MDSAL-769
Change-Id: I5aefc70d5cde269217143e092ba208589b55d12f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.28.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2022/05/30/version-2-27-0
https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2022/08/29/version-2-28-0

Change-Id: I9ce1d9fddabff9df48de9fc69637492d30c39635
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate features with @NonNullByDefault

We get quite a few warnings around nulls, use @NonNullByDefault, as that
is what we need.

Change-Id: Ia6b7c572ece161cc4e9cac1e9530a91b621cd93e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I353e51fd685690023e24fdad452d53ced4d44eee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools

Adopt:
- odlparent-11.0.1
- yangtools-9.0.1

Change-Id: I3b1ba2d5345bbf26d471296f850e3b9836ffb2a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use @Serial tag

With Java 17 we can make serialization-related components explicitly
tagged so their shape is enforced. Sprinkle java.io.Serial around.

Change-Id: Ibf0ce6e19f8433b3274e05ad3f56d86616146e78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use contructor injection in OSGiModelRuntime

Remove unneeded indirection through fields, so that the lifecycle is a
tad more crisp.

Change-Id: I55794015a41340e38f77c7cca7caf047116ae18c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern in Identity's equals()

We can use an implicit cast here, let's just do that to make things a
tad simpler.

Change-Id: Ic2f48c2b8f3fc0e4b5aec0b699cad8edf4c434b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup a nullness warning

Add an annotation to fix a potential problem.

Change-Id: I8676cb25ee5f7c8c132b894f47c4383825d9ff5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix raw type warnings in OSGiBindingRuntime

Component/ComponentFactory take a type specification, make sure we
take advantage of that.

Change-Id: I11cd64811b683fdfa8dfd62980cf9e1979ed1c0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add YangFeatureProvider

YangFeatureProvider is a counterpart to YangModuleInfoProvider,
providing the runtime with the ability to introspect what features
should be supported in an EffectiveModelContext.

JIRA: MDSAL-767
Change-Id: I6d08772c96eead79b4c88ae9ac27c57901dc70a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate classes for 'feature' statements

We need to cross-reference 'feature' statements before we assemble an
EffectiveModelContext. In order to do that cleanly and in a type-safe
manner, we need to generate Binding representation of each feature.

JIRA: MDSAL-766
Change-Id: I67e2a1dd42bd1b364fbcbbf88a83d96c947621ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern checks

We can clean up some code with instanceof patterns, use them.

Change-Id: I0c3022b44d824b4677b1286a9c3b99cf18a01193
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Narrow @SuppressModernizer

We are only suppressing the use of Guava's Objects in != operator, narrow
covered places.

Change-Id: I6b3ec8f78996227bae27558f9c04b22ed866595b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use an instanceof pattern

We can remove a cast here, saving a few characters.

Change-Id: Ie2c03a062cffce58ba15a253e81957b6cc5d1b6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch Collections.{singleton,empty}List()

Use List.of() instead.

Change-Id: I728826dba2b4790ef75606da918c5968b3c8ee48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Share AbstractExplicitGenerator.runtimeJavaType()

Most implementations do the same thing, pull the implementation down
into the abstract class.

Change-Id: Iaf0b6cee34e62c89ea3d34b8c83fa4f02bce913e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Seal CollisionMember.Member

This is an implementation detail, seal the class hierarchy.

Change-Id: Ifb9497a172d16a2e2560b46df47631934351afe0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Dispatch statements with instanceof pattern

Remove a bit of casting by using an instanceof match.

Change-Id: I2d22f4a3bd6151c4193d3dec95efc7f69c09013d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern

Remove a cast to make the expression simpler.

Change-Id: I7a0d1abf1e80cafb9352bfbb1f05ae56b9117bf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump byte-buddy to 2.12.13

https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.11
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.12
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.12.13

Change-Id: I08268857938cf7f732662c0e41c4fb7e8a5ba996
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve javadoc for generated keys

Fix warnings about missing javadoc in Key classes
generated by ListKeyTemplate.xtend.

Add generation of javadoc for all values constructor,
getter methods and for the class.

JIRA: MDSAL-759
Change-Id: I1cef9d4b4415e0f786eca414937b1958d31acd38
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for augments

Fix warnings about missing javadoc in augment interfaces.

Add setting of YangSourceDefinition when building GeneratedType
corresponding to augments so JavaFileTemplate.appendSnippet()
generate javadoc for this class.

JIRA: MDSAL-761
Change-Id: I243ce2e5198dca2b9c6e6c009c6ddb2a248d44a5
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate javadoc for unions

Fix warnings about missing javadoc in union classes.

Add setting of YangSourceDefinition when building GeneratedType
corresponding to union so JavaFileTemplate.appendSnippet()
generate javadoc for this class.

JIRA: MDSAL-760
Change-Id: I42ac82ab099785b1318a5e3615e37ebeee653b02
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use FrameworkUtil.asDictionary()

We do not need a Hashtable, use FrameworkUtil to give us what we need.

Change-Id: If6a590a2651e92b89e349b41a6ab4e10b0f73db8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix raw type warnings

CompoentFactory should use a proper type, fix that.

Change-Id: Ibf0c072d49c1ce9047eb01101f94d9b589448452
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up YangSourceDefinition a bit

Capture the shared predicate in a method and use method references
to route to it. Also use instanceof pattern match.

Change-Id: I530274532db9a4942dcc54725c211785badd5d42
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern match

We can be more expressive now that we have Java 17, let's do that.

Change-Id: I669fe4bd871c9cc269ead6b3b376af21295efc4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add generation of javadoc for Builder.withKey()

Fix warnings about missing javadoc for method withKey() in Builder
classes generated by BuilderTemplate.xtend.

JIRA: MDSAL-758
Change-Id: Ia871623b608a9dcdfb4fec284622843a7365e839
Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use FrameworkUtil.asDictionary()

We do not need a dedicated Dictionary implementation as OSGi R8 provides
a conversion utility.

Change-Id: I308c3d5dc23e0c06f176cda089daf4597b5028d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 10.0.1-SNAPSHOT

This starts the next development iteration.

Change-Id: Iee036e6c5815752768d86f701fc44b3ce1e6c808
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve TypeObject.toString()

Fixed:
 - Use "value" instead of "_value".

JIRA: MDSAL-693
Change-Id: I7243cf935f5988a563e4d5748ab364e2921c4853
Signed-off-by: ivan.martiniak <ivan.martiniak@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add support for composite notification listeners

This is a replacement for FooListener notifications, allowing
an atomic subscription.

JIRA: MDSAL-702
Change-Id: I8ebf57f1a479d178aecb8d465d85d690124a587c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BindingDOMNotificationServiceAdapter.getDomService()

This method is not used anywhere, remove it.

Change-Id: I9b501de0cab4b6f96c09f8a825907adeccbd1ea3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add registerNotificationListeners()

We have a use case where we really want to perform a bulk registration
of multiple listeners. Add the corresponding method and implement it in
DOMNotificationRouter.

JIRA: MDSAL-701
Change-Id: I57e16f4f1044a96ee06dafb003436d84ca47c829
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup DOMNotificationRouter

Use a dedicated subclass for internal registrations. This cuts a bit
of verbosity and makes things a bit more clear.

Change-Id: Ibd22dda7346e0152213d021d536e93714d1f881a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Annotate DOMNotificationService returns

We guarantee a non-null return, annotate that.

Change-Id: Id5eaeeed165b86007766d50e23a964f1a76fab5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate NotificationListener

NotificationListener is a top-level generated class with a tight binding
to invocation patterns (in mdsal-binding-api). We already provide an
alternative API via functional interfaces, which deal with the
equivalent problem.

Deprecate NotificationListener and related services, guiding users to
their replacements.

JIRA: MDSAL-496
Change-Id: I4ac52493f253040f0055011122dd41c4c367d84b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup mdsal-binding-dom-codec-spi dependencies

We are using a number of upstream artifacts, make sure we spell
them out.

Change-Id: I7ae2ae61aa0ce6ea8e1e595d1da3facb734db464
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn Restrictions into a final class

We have a number of distinct implementations, make sure we concatenate
them into a single one. Also mark future evolution of this contract.

JIRA: MDSAL-85
Change-Id: I620d7e52ea0faf1add13ceeae660062c3dbfa278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize BindingGeneratorUtil

Use instanceof pattern and use ImmutableList consistently.

Change-Id: If324ba0440df122d37acce485822ce5e463aac87
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Types.getDefaultRestrictions()

This method is not used anywhere, remove it.

Change-Id: I704f95e98d67aed7e2a322532695d3889af4668a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use yangtools release instead of snapshots

We have a release out there, use that in preparation for our release.

Change-Id: Ia1211f11db9421d9c8e957de4393aeb57d840781
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove an empty line

We have a superfluous empty line, remove it.

Change-Id: Icd599065ce41edb6e2f9be071a24b11064d360eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a typo

We have an unused parameter, but it should have the right name.

Change-Id: I8a9c023d4799c4d9899754c4aef4c0051118d8d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Generate fields for all Identityrefs in an Union binding class

Changed property name in generator for identityrefs so it will
generate variable names based on type of identityref and not
identityref_ like was before. With that it will generate fields
for all identityrefs that we have in union and methods for them.

Updated related test and added another one to cover the change.

JIRA: MDSAL-740
Change-Id: I11735655ab407f37774cb1b5ffa61955abaee37c
Signed-off-by: OleksandrZharov <Oleksandr.Zharov@pantheon.tech>
Signed-off-by: Tibor Král <tibor.kral@pantheon.tech>

Fixup dependency

We are missing annotation-api for docs, fix that up.

Change-Id: Id838000fd380805b16e5ca17f2585d4bf18d9751
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused dependencies

We no longer access maven APIs directly, remove now-unused dependencies.

Change-Id: I14fbc398899e6ceae868a24ee5163c4e16e5dd82
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate use of the IllegalArgumentCodec

Add DomLocalCodec replacement with exactly the semantics we need,
and use that instead of IllegalArgumentCodec.

JIRA: MDSAL-704
Change-Id: I31da50435c8b2a270c1b3cf4210eed59e7e4376f
Signed-off-by: Kostiantyn Nosach <kostiantyn.nosach@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize mdsal-dom-{api,spi}

Use various constructs available in JDK11/17.

Change-Id: I5c80b841c25ee5e695c8c643fe9fa43a2cede86b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkState() argument

Use %s instead of {}.

Change-Id: I008a1531dc53420247765a07f2b2cd798ef2d3a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize EntityOwnershipChangeState

Bring this class to modern world:
- Use Boolean.hashCode(boolean)
- Use 'var'
- Use instanceof pattern

Change-Id: I5d902e35f6581a0df4d114f9884438c402d5dae0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use ListenerRegistration in DOMSchemaService

Expose only Registration.

Change-Id: Ia5ddf7e97760b9d5a7bfb8c28f0aa21989b7f5e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof patterns

Remove redundant casts to make things a tad simpler.

Change-Id: Iadefb90681431da9e716e4b7050b8e9da39044cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not generate java.beans.ConstructorProperties

We are generating ConstructorParameters, there is no need for
java.desktop dependency here.

JIRA: MDSAL-757
Change-Id: Ibaa0c20194052b7b85a0ba37f59f5c86c99534a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup docs links

We have a more modern Guava and do not use old commons-lang.

Change-Id: I1716c399b3235bff7f4f12acef3433d9984a8f6a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Freeze odlparent at 11.0.0

Do not use snapshots.

Change-Id: If8a4b6128de80a5f74917b7327d73dff1938aa92
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to jakarta.annotation-api

Since odlparent has switched to jakarta we have to move from
javax.annotation-api to jakarta.annotation-api.

Change-Id: If6fcded7168674d454033f8b7602a0afb0f64221
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Modernize LazyDataObjectModification

Use switch expressions to eliminate unneeded default cases.

Change-Id: Iaf8124fc86cf71e7b7a1d589a21b3c7b85b90767
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize BindingStructuralType

Use switch expressions to remove an unused default case.

Change-Id: I5bbbcafebfb24af79c0ecb4d16b5dc6d9425c3d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern in RpcServiceAdapter

Remove an superfluous cast.

Change-Id: Icd1d576b13ff740fbfdf677b05848a0214fcf6fb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof patterin ActionAdapter

Ditch a superfluous cast.

Change-Id: I17719c5f16da445c2d39eef1e4948f4efd9fc433
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractCompositeRuntimeType

Use a switch expression to make initialization more explicit.

Change-Id: I349adb2626b13b55a6d122bcfb480acc6c380adc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize Generator

Use switch expressions and instanceof patterns to make the code more
expressive and ditch a few default cases.

Change-Id: I72e3abd0edc68c923500e006a17152bdadfd3fc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize AbstractTypeObjectGenerator

Use switch expressions and instanceof pattern matches.

Change-Id: Icf302df71d019db527fd1472d68b55a9100c536f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize SchemaRootCodecContext

Use switch expressions and instanceof patterns to improve
expressiveness.

Change-Id: I08f8806dca5cc1936b2d39ff7c3e2b7b5efc0e60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use switch expression in IdentifiableItemCodec

An expression is more appropriate here, as we always return a result.

Change-Id: I6cb1d5ef2f04aa1156ef23d789ff52eb3b5600bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize DataContainerCodecPrototype

Use pattern matching on instanceof and arrow cases. Also split off
ChoiceSchemaNode addressability computation to speed things up just
a bit.

Change-Id: I9deaab2a97becabbe63b3aa5602301239847358e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Specialize AbstractDOMForwardedCompositeTransaction

This is an internal class, which is always specialized to
LogicalDatastoreType. Bake that into the class design rather
having it as a generic argument.

Change-Id: Iec65a658fa29932cdb3a9370927ef1e99b4f6a68
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use switch expressions in mdsal-binding-model-ri

We can improve code layout a bit by using a switch expression.

Change-Id: I0784fa87890d81849e08f531b84b081033166c32
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use arrow case in BindingMapping

This makes the switch expression a bit denser.

Change-Id: I168148a8c6d46a51cd5619cd52e314b9fd3e5453
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use instanceof pattern in BindingReflections

Reduce the number of casts.

Change-Id: I220b063f9ce81d7487fdf35ef2648193cb7c4cb6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a switch expression in IMDS

We are switching on enum, use exhaustiveness.

Change-Id: I87c805961628a201c540cd045705e3c589055fbf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>