Bug-2848: BGP-LS EPE extension: Peer Sid

Parsering/serializing for Peer-SID, Peer-Set-SID
Added parsering/serializing of type and length of (Lan)AdjacencySegmentIdentifier

Change-Id: I56b4c2c131c205fa727f4261fc9cd06d4b39dd63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-2848: BGP-LS EPE extension: EPE Descriptors

Parsering and serialization for Local and Remote node descriptors expanted by:
- BGP router id
- member As number

Change-Id: I1c25f76aa1a7947f7ff459bf4f9019116e055f49
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3879 : Fixed NPE in OspfPseudonodes case.

OspfPseudonodes weren't properly extracted from BI to BA.

Change-Id: I30a6b163806af69c9c8efa77a5d9f208228d54fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 044b654e168135e1a272b7a5f4fcf0f44ed469aa)

BUG-3892 : added ordered-by user statement to clusterIds

Without this statement, LeafSet does not guarantee the order
of clusterIds. We need to maintain the order as our clusterId
needs to be first when advertising routes.

Change-Id: Ic5d7ca2fb514a31cffc958a8a69ee3f57e3d2636
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3839 : fixed various minor bugs related to AS Path BPS

- fixed classcast from Long to String
- fixed wrong NodeIdentifier
- fixed wrong algorithm in BPS

Change-Id: I7d87534d4e027d62a13fca7da13af81cb5f89caa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3860 : fixed config through RESTCONF

Not closing loc-rib caused many loc-ribs to be created
through config-pusher causing NodeModificationExceptions.

Change-Id: I9b168615875f02a40b120b13cc92e9d5bdcd42be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix Sonar warnings: bgp-bmp-impl

Change-Id: I50a3d1c10204cd421246a0d5f838bcfd83e3ff9d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

bgp-bmp-spi sonar warnings

Change-Id: I167e53a743aaae073107addc86214d60e4f15302
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP dependency management

-use project's dependency management
-clean dependecies in BMP poms

Change-Id: I4bbeae6d164d882ad33336b34dfc6a8712eeb9cd
Signed-off-by: Milos Fabian <milfabia@cisco.com>

bgp-bmp-spi cycle issue fix

Moved BmpTlvRegistry to spi.parser package

Change-Id: I55a39113617bf844503936ad93e7c7a438ff7840
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-2848: BGP-LS EPE extension yang model correction

Added epe descriptors to local descriptors
Removed from link descriptors

Change-Id: I434d5db602b599b50f8517ecd4b1b05c9f027048
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

nagasena lib: group id change

Change-Id: I1a93d8ebf081649b9918790f47a868400313c17d
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3714: Generalize RIBSupport

Changed instance idetifier for writing/deleting routes operations in RIBSupport.
Now identifier has to point to table's routes choice data node.
The change allows to properly use write/delete routes DOM operations out of "rib-api" module namespace.

Change-Id: I4b877683fdb5232179da05eab78120187a2fcf4f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP server dispatcher configuration

-integrates BMP dispatcher with config subsystem

Change-Id: If2b953361ae53ca8d3093bc19a0de2e892cb42cc
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP server dispatcher

-based on netty protocol framework
-dispatcher is able to create BMP servers
-BMP server is binded to particular IP address and port
-listening for incomimg connections
-initializes channel pipeline - message and session handler

Change-Id: Ibe15ef3fbde8369cdac320db82ba18f3f1e46d5f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP session implementation

-basic channel reading/message handling
-delegating messages to application layer
-error handling, end of input detection
-simple session factory

Change-Id: I827c44413a4cc7cfa6066ceb2c63b8d9c85c49bc
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Use {{VERSION}} where possible

Using properties is not something what we want to do, so switch where
supported.

Change-Id: I298167354857b832aebf48346238d22ac1b6c929
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug-2848: BGP-LS EPE extension yang model

Two new Node Descriptors Sub-TLVs:
-BGP-ROUTER-ID
-Confederation Member
A new Protocol-ID for Link-Type NLRI.
Two new BGP-LS Attribute Sub-TLVs:
-Peer-SID
-Peer-Set-SID
-ref.: https://tools.ietf.org/html/draft-ietf-idr-bgpls-segment-routing-epe-00

Change-Id: I78a32e4961ad73181b61750f681a496a91c8f9c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Get rid of BestPathState FIXMEs.

Created method to parse AsPath segments
from BI to BA.

Change-Id: Ibc49da3ddfb0ba5e1bb0a8da562c00e069df3923
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 8640c8d02873b9ce26b8ac9150804cd7a873edb2)

BUG-3075: BMP Session and dispatcher API

-BMP sesssion provides basic message handling as a part of pipeline
and decouples connection layer and application layer - delegated to
session listener
-BMP dispatcher is capable of creating BMP servers

Change-Id: I8cc5c6e71c8f6a592efe06f58152dd96640579af
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP Messages parser/serializer junit tests

Change-Id: Id2c67171f4d05f935fd9bfe3efe7dfe0c95a83cd
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: netty encoder/decored for BMP messages

-integrate message registry with netty pipeline handlers

Change-Id: I8207b57ba7d859ff0a877c8eb6d5e4d7ddbc93ef
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP activator

-registers all message and TLV parsers/serializers
-integrate BMP activator with config subystem
-create instance of activator, consume BGP extensions

Change-Id: I745fac383ff6c7e9d275ce94ed426b2751aacec6
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP TLV parsers/serializers implementation

Change-Id: Id3e9759e86f2054482d08e86fd5e8632a5db59ee
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP message parsers/serializers implementation

Change-Id: Ie0b8ee9c0086ffcebff9d5d767d87c198673f9fd
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fix SrNodeAttributesParser + test

expanded tests by parsering serialized outputs
fixed seralization, parsering

Change-Id: I8382ab97d1b19791ba5395a69d1a9873be6cf8e5
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP extension provider configuration

-configuration service for BMP extension provider and extension consumer

Change-Id: I53829a09a973b4da8ebda62d897e9958ce4fb317
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP parsers/serializers and registry abstraction

-implemented common functionality for BMP parsers/serializers
-implemented simple registr, extension provider and consumer

Change-Id: Ie3b042d8b20b2f25d15c40bea529a45a4f9db1e4
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP parser/serializer and registry APIs

-Java API for BMP message and TLV parsers/serializers
-Java API for BMP registry and extension consumer/provider

Change-Id: I4ea6fe6418b964bcf8976d85724d120efb128a5f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-3075: BMP application yang model

-representing data model for BMP application

Change-Id: I81c78516850829746df08a5d68ce9a2992d8d022
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2802: BGP Update message serialization bug

The next-hop value from MP reach attribute is not stored in AdjRibIn,
thus next-hop is missing in output Update message.
Copy next-hop value from MP reach to next hop attribute to keep it in DS.

Change-Id: I866af30ecc2cd0baa0ca1ca2f763dc03176ac009
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 7505f0031b58a178994ed90e12d0a7bb111ae8e1)

Removed duplicate logging from message parsers.

Message hex dumps are already printed out via Encoder/Decoder
classes, no need to print them in here as well.

Unified log messages and renamed some variables to make
code more readable.

Change-Id: I9bdcfed891ee1175d28ba1b993f1f22c9774da3e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BGPCEP Tests

PCEPExtensionProviderContextTest
LinkstateRIBSupportTest
FlowspecModuleTest

Change-Id: Ieec83b4dec1b010355a1001cf0f5adda4094c524
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit bfb96610200e708c010048c4ffde17c98e97000e)

Added a bit more tests for correctness and code coverage.

Change-Id: I21f1497279d4b297b533b5dc0872b545e594b11a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3362 : improved tests for application peer

Change-Id: I7fd771d534b1950ff08b47e7126009d8d3afe768
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 9fee7709aee0234aa264f8d38bd3127957872cc0)

RibSupportUtils Unit Test

Change-Id: I520fea6782847f3c29ffbfb520f133944613aa99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test: PCCEndPointIpv4ObjectParser

Test coverage from 5.6% to 100%

Change-Id: I33855fba9d89d30cfaef9cec325020833d4a41e7
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test: MultiProtocolCapabilityHandler

from 19.5% to 100% test coverage

Change-Id: I3b7ff5e31ef2c2bd33561366902f3d87fc40e531
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Unit test for Ipv4NlriParser

created Ipv4NlriParserTest
correction of:
- check of nlri instance type
- serialize nlri in <length, prefix> order

Change-Id: I00c06b352aabe4eb94a492c737377ec1efefec99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Test - PCEPDispatcherImpl : customizeBootstrap method

Change-Id: Ifc2dab2ca522f53de81c31ffe0c3464ab065cef1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3768 : fixed AdjRibsOutWriter

Added peerId to list of arguments for this writer
and limited listening to AdjRibsOut only for that
particular peer.

Fixed switched arguments for creating Mp_Reach and Mp_Unreach.

Change-Id: If1f3c576395d68aa3c26d2e4fabd696a4bf14457
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 8bf877875bc2038063008ffd2d99e67591db73ba)

BUG-3664: make sure the transaction is committed

Even in face of error, do not leave a transaction hanging, but rather
commit it with an error-level message logged beforehand.

Change-Id: I211caa7cae954d76e9a47021afcb466f8e7e6004
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 410d7ba6265f74c8180bf63ede523c30093e20e9)

Removed the rest of old BGP-RIB classes.

Change-Id: Ia849ec2ee2332b957f816b4691d5fd45dd1a2942
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 3044 - Conversion from Flowspec BI -> BA

Added support to convert flowspec type in BI to the BA.

Change-Id: I780cab9e3a2fb6c8acc4fdab6572057d76f63432
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-3664 Fix NPE caused by null AbstractRouteEntry

When we tried to get effectiveAttributes from an AbstractRouteEntry
which is null will cause a NPE, since it doesnt contain any attribute.
Fix by check this case.

Change-Id: I311743a165373ee2da4bd4f73e2d468023e445ad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 902ea39154b62c25659967493a0130f1bed9a5bc)

Bug-3204: If no LSP Identifiers TLV is present in PCRpt message updateLsp in DS throws exception

-handle report message including non-RSVP-TE payload and no LSP Identifier TLV
-in this case use PLSP-ID value as a path identifier in PCEP topology

Change-Id: If1f5716ce0dfaa635028bb4e956ea8595d7b3e34
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BgpTableType: toString()

added toString method into BGPTableTypeImplModule $ AutoCloseableBgpTableType
changed toString in BgpTableTypeImpl

Change-Id: Idf122147522718ec98080d9e81d38bd7c17d9e93
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Fix delete case in EffRibIn.

Delete case was pushed with wrong InstanceIdentifier.

Change-Id: I3e57f5f0b7915bcd290d4b2e851bbb388a092eb4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit 34ccd897e1384038c9e8a5cf8e270cd12b4c3199)

BUG-3347 : fix receiving updates only on first route

This was due to calling clear before each write into AdjRibsOut.
Create tables in AdjRibsOut beforehand, so we don't have to take
care about it when a route comes.

Change-Id: I442f9cb2bda715e57fc1c453a81caf13265980cd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit dc9c5f40dea1243dc044acc73904d3944809c10b)

BUG-3300 : Fixed BGP transitive attribute filtering

Namespace in AttributeOperation were hardcode therefore any transitive
attribute with different namespace(inet..) were not valid, reason why
FromExternalImportPolicy did not return any attribute, causing a NPE.
Fixed them by matching extension QName to corresponding Attribute.

Change-Id: Ic3ccf5eb0b1d181baaf8ea5b6dea6f84828b92a4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 1114255dc1be6586cef529178e1b1b3078f15b71)

Revert "BUG-3347 : fix receiving updates only on first route"

This reverts commit 0025391f847840fc6e89bcb6193695bc34f44d5f.

Change-Id: I6f690cddb114a3832301f855b281769e66f79b96
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3347 : fix receiving updates only on first route

This was due to calling clear before each write into AdjRibsOut.
Create tables in AdjRibsOut beforehand, so we don't have to take
care about it when a route comes.

Change-Id: I8679399a50b54d83d5432c7b75aadd9e1c7ea928
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry-picked from dc9c5f40dea1243dc044acc73904d3944809c10b)

Cache UnrecognizedAttributes

UnrecognizedAttributes is typically empty, so we can reuse it widely.

Change-Id: Ifff9a45335e6a0ffaf07db789e9d36394ff61301
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 0efe3c646ac46ed0855754ec627ead7b061ed297)

Cache IPv4/IPv6 nexthops

Next hop values are readily reused, so cache them to share instances.

Change-Id: Ib946a82d950c51644bea3cbc394d536e76663c6e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix EffectiveRibInWriter overwriting the entire route table

The fall-through in SUBTREE_MODIFIED case means that for any new write we
replace the entire route table, which has the effect of LocRib having to
run route selection even on routes which have not changed.

Fix this by removing the fall-through and deal with individual routes as appropriate.

Change-Id: I1297afc878d3d8bf9d0c0f461244cc4414f1caa1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit 1d6e02186ac85eff5734db59d3cbf5017214ddce)

Fix confusing peer AS message

We printed the expected number in place of what the peer sent and vice
versa, confusing users. Fix that.

Change-Id: I874a25598818e58f4a05a10a977724b0cc853140
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit bcaeb7773976be48a2a8f52dd9fdf33e66d333a6)

Lower tracing overhead

Arrays.toString() and ByteBufUtil.hexDump() are expensive relative to an
disabled trace call. Guard the corresponding trace() calls with
LOG.isTraceEnabled(). Discovered in BGP performance traces to have some
4% overhead.

Change-Id: I94ce9b57b86bae9be35e5839447a19b268064469
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove LocRibWriter registration on close()

Retain the DataTreeChangeListenerRegistration we get when we subscribe
and cancel it when we are being shut down. Also place two FIXMEs for
future work.

Change-Id: I74364473736e863e63557e8ebf652424ea312a59
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit c1206aa82aaf35f93a2b74f83dea8fd2dd5eb048)

Fix duplicate NodeIdentifier instances

Memory dump has shown we have multitude of NodeIdentifiers pointing to
the prefix QName. This turns out to be the automatic completion of
missing key leaves. Fix the caller to set the leaf up correctly, thus
sharing the NodeIdentifier instance.

Change-Id: I5fb563a9048f4d48c2a2c5b96b8b9bfd08b867f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 390fbfa3f810ad278d3c55a256bd1deea2ac1bb0)

BGP.parser.impl.messages: minor changes

KeepaliveMsgParser - made final
NotifyMsgParser:
- Log just-built ByteBuf
- Reordered line - getData()
OpenMsgParser - log just-built ByteBuf
UpdateMsgParser - made final

Change-Id: I09283ee4505dfa5f8c747d7bfc12fc6a701efa96
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BGPServerSessionNegotiator: Use the correct AS number

Before: toLong() on 2-octet value could result in AS_TRANS.
After: AsNumberUtil.advertizedAsNumber gives the correct 4-octet value.

Change-Id: I46b2a4baa25029b872e9b52c98823ee2b7f956bf
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit f4c914b9aaac0fea02a98ff4c67725686b0f2097)

BUG-3348 : fixed Export Policy

Export policy located in LocRib was not informed
about peer change, therefore it didn't create any
groups. As a result, none of the routes could be
propagated to other peers. Change the LocRib to
listen to the same path as Effective RIB to obtain
also peer role changes.

Change-Id: Ic55cbba03952fbdcf7f63b76d159502c9af733b0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit d9a3fe3f83d3ca7bccdb543e02249a0c88a3fa95)

BUG-3348 : fixed application peer

By moving ipv4routes to inet, the namespaces in BestPathState
are no longer valid. Fixed them by matching extension QName
to BestPathState.

Change-Id: I9f09e92645fafc0d722109f10e06eb5bbaf17e37
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 695fae9adf96b34c6b94d41b9fb90e8bada91869)

Make OffsetMap enforce access limit

getValue()/setValue() should ensure that the offset used is covered by
associated routerIds. Also fixes wrong format strings.

Change-Id: I4fafea959bc550e0bf9a2ec048c35ae63c255235
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 314664ba879180383f7b70d9b51906cdfa194aa3)

Make methods static

Some methods do not touch object state and can be made static. Turn them
into statics for better performance.

Change-Id: Ib561b6f5d0845261370ea28d6428262df887943f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit fc38e78649a09a058450dfcfd02ee48a39aa35f3)

Bug 3577 - Message decoder fails to decode "all IP addresses match this update"

Added support to parse and serialize "default route" prefix in Ipv4Util and Ipv6Util.

Change-Id: Ibd84cad5864beb71112f72ac727ff7a65079efcf
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Make deeper comparison for best path selection.

Superficial equals caused best path states to never equal,
even if they should. This resulted in more writes to LocRib,
as all paths were new.

Change-Id: Ie1b694acdddac2bd617bc1086dc63c8c8eef049d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 0b08aa6f69c334f3c3e51bbb71e2605678316c1a)

BUG-3593 : fixed error installing odl-bgpcep-bgp-all

Renamed dependencies feature to be unique in features list.

Change-Id: I217bb6a5ddf976e59900e62c3ce091a9e44aaca6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BGPMock fix

List iterator fix in isMessageListSame()

Change-Id: I1a792107f05c7091e8b4ab7534c911c5404e4278
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Reuse child NodeIdentifier

We effectively create two YangInstanceIdentifiers for the same thing,
except for routes we end up creating a different instance of
NodeIdentifier, which forces a slower comparison. Reuse the same
identifier, lowring memory pressure and increasing performance slightly.

Change-Id: I80e8ffa89737476040727f45a8b90bd157527955
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 6416127e56a0fc0f2645823e082a4eaa39142a28)

Add performance fixmes

We could do with a cache in two strategic places, mark them.

Change-Id: I20a9e98d85740107413afad54b391d1bda990672
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 6ae16a4a9f737151a4209f1d13ee57e2b9babb49)

Cache QNames obtained from binding classes

Traces indicate we have a rogue QNameModule coming from this path, make
sure to squash it to a cached one.

Change-Id: I80f72ae0d4b80f35edc97060734fcc8df9c028c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 9d9038bca661edf88e1aae971b4c6883983cfb47)

Unit test bgp-rib-impl

Expanded existing test. Added tests for session preferences

Change-Id: I1326d5d34c768ddb063dc4a2324acb07849a0681
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3419 : fix calling get() on Absent value

When BGP shuts down, LocRIB receives and uptodate
change with no data attached causing an Exception.
Fix this by checking existence of the data.

Change-Id: Ibe1aeb8e7f02136be2c83be516e47833c1d8146a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

pcep.impl.messages fix

Fix of last merged commit faults in this package.
PCEPErrorMessageParser - reordered switch cases in order to return original functionality.
PCEPReplyMessageParser - BANDWIDTH_IN return value fix; extraction of one more switch

Change-Id: I7165fc1810abb1c79fab8f30a36130e4a44c740f
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Complexity issue: pcep.ietf.stateful07

Switch extractions into private methods named insertObject

Change-Id: If9a04556097447d049c94054921afafcb3b66f47
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Bug-3075: BMP messages yang model

-created yang model reprsenting BMP v3 messages
-ref.: https://tools.ietf.org/html/draft-ietf-grow-bmp-07

Change-Id: I2ef8b52d12f397c95bb69781c7bb4af0f4477bb2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Complexity issue: pcep.impl.messages

Switch extractions into private methods named insertObject

Change-Id: I1ad50fed7370290b4a2c3ec15cefac3bb156d797
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3419 : fix shutdown of modules

Turns out each extension when it's closed calls
stop() on their Activators. This nulls registration
list. But when the Activator itself is shut down,
it also calls its stop() method invoking an
IllegalStateException.

Change-Id: I3887cc687489e9e441224265f0e85baf6928aaee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2453 Replace enums in initial configs with proper value

Proper value means value defined in yang, not in generated binding classes.

Change-Id: I1f9175a4d472b92c4795d8200e60e9ca6c0ad447
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit ac987bdab12b1ed1657179570542c0d6aa15eb33)

Sonar method complexity issue

Method: checkDependencies
Extracted two for cycles into another private methods.

Change-Id: Ie9e5e9cfce85a2280c09d7fd3cb7a70bb4751b90
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar method complexity issue

Method: validateMonitoringMetrics
Extracted switch into private method insertObject

Change-Id: I3d129957dc245e4e3a117f10c0177cb1a1be8f99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar issue fix

Simplified methods in:
- Stateful07TopologySessionListener.java
-- onMessage method. Code extraction into private methods. Complexity decreased
-- ensureLspOperational method. Extracted last-return's code. Complexity decreased

Change-Id: I34e9826f95ec0e095e63b426c6aa8a4e07dc0068
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Update of Unit test

Added tests for updating values of different classes.
(note: MultiRegistry.java from 85% to 96.7% coverage)

Change-Id: I4316ec15d8dc3551e200c204aa1e52741136cec8
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3186 : fixed MPReachCodec not found

Turns out, one import problem can cause the whole
codec hierarchy to fail. Also make sure we can
troubleshoot such bugs easier in the future by
catching Exceptions from codec creation per RIB.

Change-Id: I675b70f6b8079d2a5a2eb7ded64be76d16f9e468
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Sonar issue fix

Extracted parts of code into another private methods in order to
decrease complexity.

Change-Id: I53363643ceecd70579f82dc2a829e043fcaf8d41
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

fixed sonar issue

Extracted parts of serializeCapability method into private
methods to decrease method complexity.

Change-Id: I6b0810e48b525f7fa8b6f00ec2be2aee2aab6a25
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3225 : fix NPE

Import policy requested by Effective RIB has yet to be put in policy database,
therefore the NPE occurred. Switched off listening for peer-role changes itself,
the change is now checked in Effective RIB. Since we are listening to a different
subtree, the handling in Effective RIB needed to be changed accordingly.

Change-Id: I0df6cf2234a27d99445af07dd47c9039a0418cb4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 40aa438dc57d452f866fcf6c32b59a8a2d9f14e1)

BUG-3252 : added a check for augmented transitive attributes.

Change-Id: I6e8636cec435da937ddabd78f7f5bcaa5edb2a89
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3043 : fix for transaction closed exception

When the peer got session down, transaction chain
was closed. This caused problems, when the peer
reconnected.
Moved closing of transaction chaining to when the
peer closes.

Change-Id: I7da35d7e0a2238f38b5a549e9848b418d467d27a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 3198 - Extract BGP messages content into groupings

- updated notification messages to be reusable

Change-Id: I0045ba18b618e7b3c4b441ae6ef6074acc25f1c5
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 3117 - Capability Parameter Parse Issue

Change-Id: Iaa4e142b3387dc89778aba80fe8af34d72338bb7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-3074 : set initial uptodate state in LocRib to true

Uptodate state was missing entirely from tables that
were not advertised by peer. This commit inserts the field
and sets it to true to inform the user, that there won't
be any more routes added to the table.

Change-Id: I539d3a9df388c476748c5009d945f7ad2eef792e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed some sonar issues:

- magic numbers

Change-Id: I12ab7953d671a63807716940c2e54462fca82a7a
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Refactored anonymous classes that were too long.

Extracted parts of long methods to separate private
method.

Change-Id: I29db5e2e940385f735a037434564b0069da9a2d6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Deprecate stateful02 topology provider.

In addition to deprecating stateful02 module.

Change-Id: I184876dd8eb0cae01765c6c1adb0b70425ae579a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed minor sonar warnings.

Change-Id: Ib22579656e688a81011fc6b5761a20743ca44446
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG 3094, Check AS number

Change-Id: I345a3c5c2cb4a496b45e87aa11d1c752c39bc75c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Make sure we close read-only transactions

Transactions are resources, so they should be closed when no longer in
use.

Change-Id: I45a8a89f56b61cb12addbdb3349ab408c8aa14ed
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded MERGE modification type

This modification type is never generated, so eliminate the todos and
warnings stemming from the use of deprecated value. Default statement
will still catch/warn about it.

Change-Id: I3eb26a14d50e3428b5c10c34f39d3d1e3ebb12d5
Signed-off-by: Robert Varga <rovarga@cisco.com>