neutron.git
7 years agoMerge "Logger on neutron model"
Isaku Yamahata [Fri, 1 Jul 2016 17:53:06 +0000 (17:53 +0000)]
Merge "Logger on neutron model"

7 years agoLogger on neutron model 92/40392/6
Isaku Yamahata [Sat, 27 Feb 2016 09:28:04 +0000 (01:28 -0800)]
Logger on neutron model

This patch implements logger on neutron model change for debug.

Change-Id: Ifd079de8cded725d79ec2fe638415ab7be640318
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoOpenDaylight Networking SFC Port Chain REST APIs 48/40848/8
Anil Vishnoi [Fri, 1 Jul 2016 01:19:01 +0000 (18:19 -0700)]
OpenDaylight Networking SFC Port Chain REST APIs

This patch defines REST API's in Neutron Northbound project
for the networking sfc port chain APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc port chain Yang models. These Neutron
Northbound REST API's are defined based on the OpenStack
Networking-SFC Port Chain APIs available at following URL.
http://docs.openstack.org/developer/networking-sfc/api.html#rest-api

Change-Id: Icb9f581157ce150d846dad6d6321c40a9e642e1b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoOpenDaylight Networking SFC Port Pair Group REST APIs 47/40847/9
Anil Vishnoi [Sun, 26 Jun 2016 23:10:56 +0000 (16:10 -0700)]
OpenDaylight Networking SFC Port Pair Group REST APIs

This patch defines REST API's in Neutron Northbound project
for the networking sfc port pair group APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc port pair group Yang models. These Neutron
Northbound REST API's are defined based on the OpenStack
Networking-SFC Port Pair Group APIs available at following URL.

http://docs.openstack.org/developer/networking-sfc/api.html#rest-api

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Ib25544b711873983be7733ec552328220fd8a85d

7 years agoOpenDaylight Networking SFC Port Pair REST APIs 46/40846/7
Anil Vishnoi [Sun, 26 Jun 2016 21:48:43 +0000 (14:48 -0700)]
OpenDaylight Networking SFC Port Pair REST APIs

This patch defines REST API's in Neutron Northbound project
for the networking sfc port pair APIs and implementation of
the translation code to convert these REST API data to the
networking-sfc Yang models. These Neutron Northbound REST
API's are defined based on the OpenStack Networking-SFC Flow
Classifier APIs available at following URL.

http://docs.openstack.org/developer/networking-sfc/api.html#rest-api

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Ie8b3bf725e492443ac4b0056c255a71e16b1635a

7 years agoOpenDaylight Networking SFC Flow Classifier REST APIs 43/40843/7
Anil Vishnoi [Sat, 25 Jun 2016 03:10:14 +0000 (20:10 -0700)]
OpenDaylight Networking SFC Flow Classifier REST APIs

This patch defines REST API's for the networking sfc flow
classifier API and implementation the translation code
to convert these REST API data to the networking-sfc
Yang models. These Neutron Northbound REST API's are defined
based on the OpenStack Networking-SFC Flow Classifier APIs
available at following URL.

http://docs.openstack.org/developer/networking-sfc/api.html#rest-api

Change-Id: Ifcdec7025715c1e9fa5f90aa9cbc475e7a1e9427
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoMapping Exception caused by Overloaded NeutronObject#setTenantId() 97/40897/4
Anil Vishnoi [Mon, 27 Jun 2016 21:18:26 +0000 (14:18 -0700)]
Mapping Exception caused by Overloaded NeutronObject#setTenantId()

Overloaded method for json property is causing Mapping Exception
com.fasterxml.jackson.databind.JsonMappingException:
Conflicting setter definitions for property tenantID:
org.opendaylight.neutron.spi.NeutronObject#setTenantID(1 params)
vs org.opendaylight.neutron.spi.NeutronObject#setTenantID(1 params)

Change-Id: I6278268203e5a3c593b260df02fb4a6143213d26
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoadd blueprint wiring for neutron/transcriber 11/40911/5
Isaku Yamahata [Tue, 28 Jun 2016 05:07:55 +0000 (22:07 -0700)]
add blueprint wiring for neutron/transcriber

Change-Id: I502d78e17ec956f1bdf0c12907e6fdbb2dfcf35d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "AbstractNorthbound: remove unused variables"
Isaku Yamahata [Tue, 21 Jun 2016 17:49:07 +0000 (17:49 +0000)]
Merge "AbstractNorthbound: remove unused variables"

7 years agoMerge "remove redundant methods for compatibility"
Isaku Yamahata [Tue, 21 Jun 2016 17:48:31 +0000 (17:48 +0000)]
Merge "remove redundant methods for compatibility"

7 years agoAbstractNorthbound: remove unused variables 28/40628/1
Isaku Yamahata [Tue, 21 Jun 2016 16:21:11 +0000 (09:21 -0700)]
AbstractNorthbound: remove unused variables

update and delete has unused variables.
This patch removes them.

Change-Id: I96825160e67f66ee1f7ec17e27b5ba8a6b6cd639
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoremove redundant methods for compatibility 80/40580/1
Isaku Yamahata [Tue, 21 Jun 2016 05:16:56 +0000 (22:16 -0700)]
remove redundant methods for compatibility

Now neutron spi doesn't have any dependency by other project. Redundant
methods for compatibility can be removed safely.

Change-Id: Ie1325605862917a16364f519746ad8e448dc2573
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoclean up: remove unused import 70/40570/1
Isaku Yamahata [Mon, 20 Jun 2016 19:48:36 +0000 (12:48 -0700)]
clean up: remove unused import

This patch removes unused import.
This is done by eclipse source code clean up over whole neutron
northbound project.

Change-Id: Ibf5136e3ce75bf153ad22fada76b5ebf063375a8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years ago[Boron] remove I*Aware interface 05/35505/6
Isaku Yamahata [Sat, 27 Feb 2016 09:38:21 +0000 (01:38 -0800)]
[Boron] remove I*Aware interface

don't backport to Beryllium or before.
remove I*Aware interface. This patch removes deprecated I*Aware interface.
This may break dependent projects so that the merge of this patch requires
coordination with them.

Change-Id: I2ddcb14f314dae7981bf030cdf5c54d74bb800a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoyang model revise: neutron.yang 07/40507/1
Isaku Yamahata [Sat, 18 Jun 2016 01:28:16 +0000 (18:28 -0700)]
yang model revise: neutron.yang

neutron.yang should have its prefix as neutron, not neutron-L3.
This seems copy-and-paste bug from neutron-L3.yang

Change-Id: I02a7bd0692cd646a93ad750ad37b5891df480983
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: neutron-secgroups.yang 37/35837/8
Isaku Yamahata [Fri, 4 Mar 2016 02:03:55 +0000 (18:03 -0800)]
yang model revise: neutron-secgroups.yang

This patch revises yang model for security group and related codes.
- drop description for consistency which isn't very useful
- rename id to uuid for consistency
- drop backpointer. list of security rules in security group
  If openstack provider wants a list of rules associated to a given
  security group, walk through rules whose group is the uuid of the group
- eliminated the deprecated methods in neutron-spi

Change-Id: I7a3c79eae446858d6f0f4b8cd8757c85c1dab370
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-binding.yang 30/39330/4
Isaku Yamahata [Wed, 18 May 2016 19:44:12 +0000 (12:44 -0700)]
yang model revise: neutron-binding.yang

This patch revises yang model for neutron-binding and the related code.
- fix vif details. it's a dictionary

Change-Id: Ie1f7e4a63638f143c9396a5d6f1a81aad0628595
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: neutron-l2gateways.yang 38/39238/5
Isaku Yamahata [Wed, 18 May 2016 19:46:44 +0000 (12:46 -0700)]
yang model revise: neutron-l2gateways.yang

This patch revises yang model for l2gateways and the related code
- missing uuid for devices
- pyang warning. unused import, missing key for list
- code indentation

Change-Id: Id20201bc09ea904476d428c4a411d27c1d7bbcf3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: neutron-vpnaas.yang 37/39237/5
Isaku Yamahata [Wed, 18 May 2016 19:44:51 +0000 (12:44 -0700)]
yang model revise: neutron-vpnaas.yang

This patch revises yang model for neutron vpnaas and the related codes.
- remove descr for consistency, which isn't very useful
- pyang warning. unused import
- eliminate deprecated methods in neutron-spi

Change-Id: I04d055d4f3ee4b2232cabfb34722312447880a72
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: neutron-lbaasv2.yang 36/39236/5
Isaku Yamahata [Fri, 4 Mar 2016 07:46:48 +0000 (23:46 -0800)]
yang model revise: neutron-lbaasv2.yang

This patch revises yang model for neutron lbaasv2 and the related codes.
- drops decr for consistency, which isn't very useful
- fixes range of port/weight to match neutron lbaasv2 api
- eliminates deprecated methods in neutron-spi

Change-Id: Ic50d1c420dc22d19e6e2878f44d5624dc7d6bc88
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-metering.yang 38/35838/8
Isaku Yamahata [Fri, 4 Mar 2016 06:34:01 +0000 (22:34 -0800)]
yang model revise: neutron-metering.yang

This patch revises yang model for metering and related codes.
- drop description for consistency, which isn't very useful
- rename id to uuid for consistency
- add missing attributes. shared, tenant-id
- eliminates the deprecated methods in neutron-spi

Change-Id: I1c91fc2bb2712c3301b9690b714a21ff0bf5cef4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-fwaas.yang 36/35836/5
Isaku Yamahata [Fri, 4 Mar 2016 01:41:58 +0000 (17:41 -0800)]
yang model revise: neutron-fwaas.yang

This patch revises yang model of neutron fwaas and related codes.
- fix tcp/udp port
- introduce identity and identityref for protocol/action
- drop descr for consistency
- drop backpointers. firewall-rules
  If openstack provider wants a list of rules associated with
  a given firewall policy, walk through rules and find rules whose
  policy is the uuid of the policy.
- drop status in firewall policy which isn't defined in neutron API
- eliminated deprecated methods in neutron-spi

Change-Id: Ie6fac4202fadcff718d0d4960230eefe06852bc6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-L3.yang 35/35835/8
Isaku Yamahata [Fri, 4 Mar 2016 01:02:57 +0000 (17:02 -0800)]
yang model revise: neutron-L3.yang

This patch revises yang model for neutron-L3 and related codes.
- remove backpointer as interface-attributes
- pyang warning. missing key in leaf list
- remove deprecated methods in neutron spi
  If openstack provider needs to find a list of interfaces attached
  to a given neutron router, it walk through a list of ports to
  find a port whose device owner is router and device id is uuid
  of the router.

Change-Id: I245a880437369448933e9a41feb078a8baecc4d9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-portsecurity.yang 35/39235/4
Isaku Yamahata [Wed, 18 May 2016 19:44:36 +0000 (12:44 -0700)]
yang model revise: neutron-portsecurity.yang

This patch eliminates pyyang warning. unused import.

Change-Id: I9629a7ac5c97d8239b6cbfcea134f6e1b84ecd3b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: neutron-ports.yang 39/35839/9
Isaku Yamahata [Fri, 4 Mar 2016 06:34:16 +0000 (22:34 -0800)]
yang model revise: neutron-ports.yang

This patch revises yang model for neutron ports
- type string -> yang:mac-address
- type string -> ip-prefix-or-address
- drop binding-profile which is part of neutron-portbinding.yang
- key for fixed-ips (should be both subnet-id and ip-address)
- eliminate deprecated methods in spi

Change-Id: Idcefd0ab82a9b39ab8b1cdfb7fed92100f65001a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-subnets.yang 40/35840/8
Isaku Yamahata [Fri, 4 Mar 2016 06:34:26 +0000 (22:34 -0800)]
yang model revise: neutron-subnets.yang

This patch revises neutron-subnet yang model and related codes.
- updates type. string -> inet:ip-address
- removes deprecated SPI methods
- removes backpointers in subnets. ports in subnet

Change-Id: Ie85dcd526db72b308c24b345fd6c1036e04b2d82
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoyang model revise: neutron-network.yang 34/39234/4
Isaku Yamahata [Mon, 9 May 2016 21:19:30 +0000 (14:19 -0700)]
yang model revise: neutron-network.yang

This patch revises neutron network model.
This patch drops deprecated methods in neutron spi.

Change-Id: Ib8a6ba9928f504dc4567ec2e08a8aac4387f38dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoyang model revise: adds util methods and common types 33/39233/4
Isaku Yamahata [Wed, 18 May 2016 06:28:42 +0000 (23:28 -0700)]
yang model revise: adds util methods and common types

This patch is a preparation for yang model clean up to introduce
to utility methods and common type, ip-prefix-or-address.

Change-Id: Idb566523a2f66899c558fb12c7a8e76d7d330be0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoBug 3902 : Local variables to be declared final. 19/39819/3
Abbas Pareedkunju [Fri, 3 Jun 2016 06:31:52 +0000 (12:01 +0530)]
Bug 3902 : Local variables to be declared final.

This patch is to declare the local variables to final in transcriber module.
The bug 3902 reported for 4 local variables which are not declared final.
Running eclipse source Clean Up utility against the rule for Variable Declaration
listed the chunk of variables can be declared final.

Change-Id: Ied71645f2434d9827be370dadf1b4400d773b595
Signed-off-by: Abbas Pareedkunju <abbas.pareedkunju@tcs.com>
8 years agoFix for Bug 3902 : Removal of the Unused imports from neutron. 32/39632/6
Abbas Pareedkunju [Tue, 31 May 2016 08:35:59 +0000 (14:05 +0530)]
Fix for Bug 3902 : Removal of the Unused imports from neutron.

This patch is specific to the removal of the Unused imports.

Change-Id: I336751e75103f0ed28f9f0e36014a43c1ba66db8
Signed-off-by: Abbas Pareedkunju <abbas.pareedkunju@tcs.com>
8 years agoYang models for OpenStack Neutron SFC APIs. 48/38748/4
Anil Vishnoi [Thu, 12 May 2016 02:34:54 +0000 (19:34 -0700)]
Yang models for OpenStack Neutron SFC APIs.

Patch has the yang models for OpenStack Neutron Service Function
Chaining API. These models are based on the OpenStack SFC flow
classifier and port grouping APIs. Following URL contains the list
of OpenStack SFC APIs exposed by networking-sfc project:

References:
http://docs.openstack.org/developer/networking-sfc/api.html
https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py
https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/flowclassifier.py

Change-Id: I5c1a20d18b34df5850af7ad13529da4a3f1ba767
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoBug 5842 - enable neutron northbound Maven site 96/38396/3
Isaku Yamahata [Thu, 5 May 2016 00:52:24 +0000 (17:52 -0700)]
Bug 5842 - enable neutron northbound Maven site

This patch enables neutron northbound maven site to catch up the trends.
https://nexus.opendaylight.org/content/sites/site/org.opendaylight.odlparent/boron/maven-site.html
https://meetings.opendaylight.org/opendaylight-meeting/2016/tws/opendaylight-meeting-tws.2016-04-18-17.04.html

Change-Id: Ibc15272641e7eec368726e4d5ac57b9ec3315b3b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoBug 5831 - build: check style error 63/38363/1
Isaku Yamahata [Tue, 3 May 2016 22:06:06 +0000 (15:06 -0700)]
Bug 5831 - build: check style error

This patch catches up for changes of odlparent checkstyle.
The checkset of 3b8a0b31dbe283fe37218dae2b997dd293283752 in odlparent
changed headerLocation of checkstyle from LISENCE.txt to
EPL-LICENSE.regexp.txt
https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#headerLocation
It causes the following error.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.16:check (default) on project project-neutron-parent: Failed during checkstyle execution: Failed during checkstyle configuration: unable to read /home/yamahata/openstack/odl/odl/upstream/neutron-maven-upload/parent/target/checkstyle-checker.xml - unable to parse configuration stream - Property ${checkstyle.header.file} has not been set -> [Help 1]

This patch removes the special configuration for neutron northbound so that
it uses odlparent config.

Change-Id: Ib499f2ce0b25a11c2dc73b716a69c78f057f70cf
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoMerge "Use AAAShiroFilter as TokenAuthFilter was deprecated in Be"
Isaku Yamahata [Thu, 21 Apr 2016 19:43:09 +0000 (19:43 +0000)]
Merge "Use AAAShiroFilter as TokenAuthFilter was deprecated in Be"

8 years agoUse AAAShiroFilter as TokenAuthFilter was deprecated in Be 35/37935/2
Ryan Goulding [Wed, 20 Apr 2016 19:40:19 +0000 (15:40 -0400)]
Use AAAShiroFilter as TokenAuthFilter was deprecated in Be

Use the correct shiro filter for neutron endpoints.  TokenAuthFilter was
deprecated from the AAA in Beryllium with this commit:

https://git.opendaylight.org/gerrit/#/c/30677/

AAAShiroFilter is the javax.servlet.Filter that replaces TokenAuthFilter,
and provides additional Realm plugins for the AAA framework.

Change-Id: I7daae17a784037f90b9e814f1bc42fee9a596e00
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoAdding Yang Model for Openstack Host Configuration 67/36767/3
Ritu Sood [Thu, 24 Mar 2016 21:49:02 +0000 (14:49 -0700)]
Adding Yang Model for Openstack Host Configuration

Adding YANG module to define host configurations that is used
in specifying the physical host type and configuration
for host system. Examples of host type are network node,
compute node, etc. Example for configuration is a Json string
like {'supported_vnic_types': 'VNIC_NORMAL', 'vif_type':
'VIF_TYPE_VHOST_USER', â€¦.} etc. This information is read
and populated by networking-odl in agent_db in Neutron and
is used by Openstack Neutron scheduler. Supports features
like Port binding and Router scheduling.

Change-Id: I630e6d88f1b1beb6d5e442ccddf6a5d7137a5a51
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoMerge "Bug 4815 - Server error with transaction chain failed"
Isaku Yamahata [Tue, 19 Apr 2016 07:42:08 +0000 (07:42 +0000)]
Merge "Bug 4815 - Server error with transaction chain failed"

8 years agoBug 4815 - Server error with transaction chain failed 77/31577/7
Isaku Yamahata [Thu, 17 Dec 2015 23:34:41 +0000 (15:34 -0800)]
Bug 4815 - Server error with transaction chain failed

Depending on condition, neutron northbound returns Server Error 500
with the following exception. This is because the retry logic
in AbstractNeutronInterface is not correct.
Transaction chain can't be used after transaction aborted. So this patch
moves up the retry logic and re-create transaction on transaction abort.

> 2015-12-16 15:15:16,429 | ERROR | neutron/networks | ContainerResponse                | 47 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.IllegalStateException: Transaction chain has failed
>         at org.opendaylight.controller.sal.core.spi.data.AbstractSnapshotBackedTransactionChain$Shutdown.getSnapshot(AbstractSnapshotBackedTransactionChain.java:93)
>         at org.opendaylight.controller.sal.core.spi.data.AbstractSnapshotBackedTransactionChain.getSnapshot(AbstractSnapshotBackedTransactionChain.java:113)
>         at org.opendaylight.controller.sal.core.spi.data.AbstractSnapshotBackedTransactionChain.newWriteOnlyTransaction(AbstractSnapshotBackedTransactionChain.java:158)
>         at org.opendaylight.controller.cluster.datastore.LocalTransactionChain.newWriteOnlyTransaction(LocalTransactionChain.java:76)
>         at org.opendaylight.controller.cluster.datastore.AbstractTransactionContextFactory.createLocalTransactionContext(AbstractTransactionContextFactory.java:209)
>         at org.opendaylight.controller.cluster.datastore.AbstractTransactionContextFactory.maybeCreateLocalTransactionContext(AbstractTransactionContextFactory.java:58)
>         at org.opendaylight.controller.cluster.datastore.AbstractTransactionContextFactory.onFindPrimaryShardSuccess(AbstractTransactionContextFactory.java:73)
>         at org.opendaylight.controller.cluster.datastore.AbstractTransactionContextFactory.newTransactionContextWrapper(AbstractTransactionContextFactory.java:99)
>         at org.opendaylight.controller.cluster.datastore.TransactionProxy.getContextWrapper(TransactionProxy.java:317)
>         at org.opendaylight.controller.cluster.datastore.TransactionProxy.getContextWrapper(TransactionProxy.java:308)
>         at org.opendaylight.controller.cluster.datastore.TransactionProxy.merge(TransactionProxy.java:159)
>         at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.merge(AbstractDOMBrokerWriteTransaction.java:95)
>         at org.opendaylight.controller.md.sal.binding.impl.BindingDOMWriteTransactionAdapter.ensureParentsByMerge(BindingDOMWriteTransactionAdapter.java:67)
>         at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:41)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.updateMd(AbstractNeutronInterface.java:177)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.addMd(AbstractNeutronInterface.java:151)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:360)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:370)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:367)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.chainWrapper1(AbstractNeutronInterface.java:94)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:366)
>         at org.opendaylight.neutron.northbound.api.AbstractNeutronNorthboundIAware.create(AbstractNeutronNorthboundIAware.java:94)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at org.opendaylight.neutron.northbound.api.NeutronNetworksNorthbound.createNetworks(NeutronNetworksNorthbound.java:239)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.8.0_72-internal]
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)[:1.8.0_72-internal]
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_72-internal]
>         at java.lang.reflect.Method.invoke(Method.java:498)[:1.8.0_72-internal]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[174:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[142:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:366)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_72-internal]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:366)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_72-internal]

Change-Id: I3b6127bc9c395360a5bf408402734279015def0d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoAdd dependency on javax.validation validation-api 56/37556/2
Ryan Goulding [Wed, 13 Apr 2016 15:35:36 +0000 (11:35 -0400)]
Add dependency on javax.validation validation-api

In order to upgrade to org.eclipse.persistence to 2.6.0+ in odlparent,
downstream consumers must include the dependency on javax.validation
validation-api version 1.1.0.Final as described here:

http://stackoverflow.com/questions/28568154/
how-to-get-eclipselink-2-6-0-m3-working-with-jersey-1-18-3

The work to upgrade odlparent's moxy version is included in this patch:
https://git.opendaylight.org/gerrit/#/c/37541/

Change-Id: I808f90066189852300e38df6b50daf55d5c3aab2
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoMerge "Bug 5478 - northbound: improve 404 check on update/delete"
Isaku Yamahata [Tue, 22 Mar 2016 22:37:17 +0000 (22:37 +0000)]
Merge "Bug 5478 - northbound: improve 404 check on update/delete"

8 years agoMerge "ITNeutronE2E: refactor test_fetch"
Isaku Yamahata [Tue, 22 Mar 2016 13:59:32 +0000 (13:59 +0000)]
Merge "ITNeutronE2E: refactor test_fetch"

8 years agoITNeutronE2E: refactor test_fetch 09/36509/2
Isaku Yamahata [Mon, 21 Mar 2016 17:32:25 +0000 (10:32 -0700)]
ITNeutronE2E: refactor test_fetch

refactor test_fetch method.

Change-Id: I009968c1342a94cf6bd0ed40fe0c9b006b97c5cd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoMerge "NeutronSecurityRuleInterface: remove nonsense code"
Isaku Yamahata [Mon, 21 Mar 2016 21:21:43 +0000 (21:21 +0000)]
Merge "NeutronSecurityRuleInterface: remove nonsense code"

8 years agoMerge "NeutronSubnetInterface: remove non sense code"
Isaku Yamahata [Mon, 21 Mar 2016 21:21:12 +0000 (21:21 +0000)]
Merge "NeutronSubnetInterface: remove non sense code"

8 years agoMerge "NeutronLoadBalancerPoolInterface: remove unused static final variables"
Isaku Yamahata [Mon, 21 Mar 2016 21:20:53 +0000 (21:20 +0000)]
Merge "NeutronLoadBalancerPoolInterface: remove unused static final variables"

8 years agoBug 5478 - northbound: improve 404 check on update/delete 67/36467/3
Isaku Yamahata [Fri, 18 Mar 2016 19:22:48 +0000 (12:22 -0700)]
Bug 5478 - northbound: improve 404 check on update/delete

canDelete should not be called on deletion on non-exist resource. Instead,
it should return 404 immediately without calling I*Aware.
This patch improves 404 check by adds missing 404 check by checking
return value on update and delete with a bit clean up.

Change-Id: Ia4fe068540022f687d942204f3b243ccbcbac578
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoMerge "Do not deploy the karaf artifact"
Isaku Yamahata [Sat, 19 Mar 2016 16:24:56 +0000 (16:24 +0000)]
Merge "Do not deploy the karaf artifact"

8 years agoNeutronLoadBalancerPoolInterface: remove unused static final variables 65/36465/1
Isaku Yamahata [Fri, 18 Mar 2016 18:53:37 +0000 (11:53 -0700)]
NeutronLoadBalancerPoolInterface: remove unused static final variables

Change-Id: I31e4effccd59c0a6f9a08a452ce2411231d590df
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoNeutronSubnetInterface: remove non sense code 63/36463/1
Isaku Yamahata [Fri, 18 Mar 2016 18:47:45 +0000 (11:47 -0700)]
NeutronSubnetInterface: remove non sense code

addSubnet and removeSubnet methods carries legacy code
which doesn't have any effect.
This patch Removes them and simplifies the code

Change-Id: I30d7f71336f9b7a99690235a7474e2fda67b8315
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoNeutronSecurityRuleInterface: remove nonsense code 64/36464/1
Isaku Yamahata [Fri, 18 Mar 2016 18:34:15 +0000 (11:34 -0700)]
NeutronSecurityRuleInterface: remove nonsense code

updateSecGroupRuleInSecurityGroup and removeSecGroupRuleFromSecurityGroup
have no effect any more. They modifies variables no one else refers to.
There is no point to carry those methods.
So this patch removes those methods and simplify related code.

Change-Id: I378b8ce72b2d064940a5f345d1b55e60dd9981ae
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoDo not deploy the karaf artifact 57/36357/2
Thanh Ha [Wed, 16 Mar 2016 22:38:11 +0000 (18:38 -0400)]
Do not deploy the karaf artifact

The karaf artifact is only used for testing. It does not need to be
released to the world.

Change-Id: Ic1ff344fa606666c08ec6c75e89984c535454bf3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoUse controller.mdsal.version when appropriate 29/36229/1
Mike Kolesnik [Tue, 15 Mar 2016 06:33:21 +0000 (08:33 +0200)]
Use controller.mdsal.version when appropriate

Use the property controller.mdsal.version when looking for mdsal
artifacts from org.opendaylight.controller.

Otherwise, it's confusing since mdsal.version actually referrs to
artifacts from org.opendaylight.mdsal.

Change-Id: I9571969998a04a0fdae65eb61ffab414b45ee60d
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
8 years agoBug 4550 - always rebuild security group rule in security group 57/33957/5
Isaku Yamahata [Wed, 3 Feb 2016 10:02:33 +0000 (02:02 -0800)]
Bug 4550 - always rebuild security group rule in security group

The change set of 906836c289a7e4c3d33669d90515d77e75cfb6d,
the effort transparent neutron northbound api, caused not to update
security group rule in security group.
So always rebuild rules in NeutronSecurityGroup and keep
security group rule in security group of yang model empty list.

openstack service provider that uses MD-SAL should not use
security group rules in security rule. But it should listen to
data change notification on security group rules.

Change-Id: I7da2e23d9c45549d2f5d138dfea148e36bd8061b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoMerge "Bug 5431: Fixing bug & adding new tests for code coverage"
Isaku Yamahata [Thu, 10 Mar 2016 23:37:25 +0000 (23:37 +0000)]
Merge "Bug 5431: Fixing bug & adding new tests for code coverage"

8 years agoMerge "Added PortSecurity attribute support"
Isaku Yamahata [Wed, 9 Mar 2016 10:10:51 +0000 (10:10 +0000)]
Merge "Added PortSecurity attribute support"

8 years agoMerge "Bug 4354 -fromMd() doesn't convert tenant_id to neutron object"
Isaku Yamahata [Wed, 9 Mar 2016 10:02:04 +0000 (10:02 +0000)]
Merge "Bug 4354 -fromMd() doesn't convert tenant_id to neutron object"

8 years agoMerge "Bug 5431 - Fixing bug & adding new tests for VPN files"
Isaku Yamahata [Wed, 9 Mar 2016 10:00:59 +0000 (10:00 +0000)]
Merge "Bug 5431 - Fixing bug & adding new tests for VPN files"

8 years agoMerge "Bug 5431 - Fixing bug & adding new tests for LB files"
Isaku Yamahata [Wed, 9 Mar 2016 10:00:19 +0000 (10:00 +0000)]
Merge "Bug 5431 - Fixing bug & adding new tests for LB files"

8 years agoAdded PortSecurity attribute support 68/34868/5
Dileep [Wed, 17 Feb 2016 14:12:39 +0000 (06:12 -0800)]
Added PortSecurity attribute support

Added portsecurity extension as augmentation for backward compatibility
Refer - http://developer.openstack.org/api-ref-networking-v2-ext.html

Change-Id: I75523702f6b1e83f192587396e3d103e507872d3
Signed-off-by: Dileep <dileep.ranganathan@intel.com>
8 years agoBug 4354 -fromMd() doesn't convert tenant_id to neutron object 17/35517/2
Ritu Sood [Sat, 27 Feb 2016 06:03:27 +0000 (22:03 -0800)]
Bug 4354 -fromMd() doesn't convert tenant_id to neutron object

L2 Gateway and L2 Gateway connection doesn't convert
tenant_id to neutron object properly. Adding a test case
to improve coverage. Fixed a test case to use proper
UUID format.

Change-Id: I92518fbffe5ee01c68c2bea79cb7299330737f4a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 5431: Fixing bug & adding new tests for code coverage 16/35516/2
Ritu Sood [Sat, 27 Feb 2016 04:43:08 +0000 (20:43 -0800)]
Bug 5431: Fixing bug & adding new tests for code coverage

Fixing parameter type in @GET function in
some NN API and adding new tests for NN API
files. Increased code coverage ~ 20% for these files

Change-Id: I63a871b7fc0270e325da0d03ef991c5aaa6f8843
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 5431 - Fixing bug & adding new tests for VPN files 10/35510/2
Ritu Sood [Sat, 27 Feb 2016 02:05:59 +0000 (18:05 -0800)]
Bug 5431 - Fixing bug & adding new tests for VPN files

Fixing parameter type in @GET function in IPSEC
Site Connection and VPN NN API adding new tests
VPN files.
Increases code coverage ~20% for these files

Change-Id: I7061735fec84bedc1bae210dcfa4bc7b5df464c0
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 5431 - Fixing bug & adding new tests for LB files 97/35497/2
Ritu Sood [Fri, 26 Feb 2016 03:20:46 +0000 (19:20 -0800)]
Bug 5431 - Fixing bug & adding new tests for LB files

Fixing wrong parameter type in @GET function in
LB NN API and adding new tests for LB
files. Increased code coverage ~ 20% for these files

Change-Id: I4a5c373fc199c868655f6fef6be581cef761d24a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 5431 - Fixing bug & adding new tests for firewall file 91/35491/2
Ritu Sood [Fri, 26 Feb 2016 01:55:46 +0000 (17:55 -0800)]
Bug 5431 - Fixing bug & adding new tests for firewall file

Fixing parameter type in @GET function in
firewall_policy NN API adding new tests for firewall
files. Increased code coverage ~ 20% for these files

Change-Id: Ic73601e99d91d6e67b7db7852c5e1f07974b300b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoAdding new test cases for Security Group and rules API 31/35431/2
Ritu Sood [Thu, 25 Feb 2016 04:03:26 +0000 (20:03 -0800)]
Adding new test cases for Security Group and rules API

Adding a helper function to iterate over the JSON
string used during create to extract key values
pairs and then invoke GET with query with that
key value pair. Updated security group and security
rule tests to call this new tests. ~15% Code coverage
improvement with these new tests for the two files.

Change-Id: Ib9a8878a49feb0d897f8d67b50ca2f2429dc8341
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoMerge "Bug 5210 - GET/DELETE L2GatewayConnection with optional portId"
Isaku Yamahata [Fri, 4 Mar 2016 23:14:43 +0000 (23:14 +0000)]
Merge "Bug 5210 - GET/DELETE L2GatewayConnection with optional portId"

8 years agoMerge "maven version requirement is 3.1.1"
Isaku Yamahata [Fri, 4 Mar 2016 23:14:33 +0000 (23:14 +0000)]
Merge "maven version requirement is 3.1.1"

8 years agoBug 4944 - Fixing a QueryParam name typo 29/32429/7
Ritu Sood [Mon, 11 Jan 2016 20:39:11 +0000 (12:39 -0800)]
Bug 4944 - Fixing a QueryParam name typo

QueryParam  string is wrongly called shared when it
should be admin_state_up. Added test for checking
response of a query in a collection and added
testcase for reproducing the bug. Changeset
445690e94dd990ad6d117b4d7c86e95b8bf9392b
in stable/beryllium fixes the same issue.

Change-Id: I2e5a40ed392d57d9f1d61696910ad3613cdb206e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 5210 - GET/DELETE L2GatewayConnection with optional portId 84/34284/5
Dileep [Fri, 5 Feb 2016 15:22:07 +0000 (07:22 -0800)]
Bug 5210 - GET/DELETE L2GatewayConnection with optional portId

Removed getNeutronInterface method, using getNeutronCRUD instead.
Changed PortId null check to avoid NPE.
Added test cases with optional PortId.

Change-Id: I68c118fbcdde8b24cc4210bb54d7cee7c8fc9139
Signed-off-by: Dileep <dileep.ranganathan@intel.com>
(cherry picked from commit 82bc8d9b594e17a904c4a72dd251b886e4698fc7)

8 years agoMerge "Bug 5037 - Adding tests for L2 Gateway Connection API"
Isaku Yamahata [Sat, 13 Feb 2016 00:20:43 +0000 (00:20 +0000)]
Merge "Bug 5037 - Adding tests for L2 Gateway Connection API"

8 years agoBug 5037 - Adding tests for L2 Gateway Connection API 18/34518/3
Ritu Sood [Mon, 1 Feb 2016 03:44:19 +0000 (19:44 -0800)]
Bug 5037 - Adding tests for L2 Gateway Connection API

Adding tests for L2 Gateway Connection Northbound API.
Patch also contains fix for a typo
in the NeutronL2gatewayConnectionNorthbound file.

Change-Id: I257008bfe0a897eb778cc6916a15261b8bca0612
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
(cherry picked from commit 3d9691433d3e4f25f1168802d57b96471129e407)

8 years agomaven version requirement is 3.1.1 80/34580/1
Isaku Yamahata [Fri, 12 Feb 2016 21:51:18 +0000 (13:51 -0800)]
maven version requirement is 3.1.1

As maven version is 3.1.1 or newer, set to it.
Although this doesn't harm much, this patch is for consistency.

Change-Id: Iae7cd197bb6c18e7a308d8acfce9574653dfa6b9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoMerge "Adding tests for L2 Gateway Northbound API"
Isaku Yamahata [Fri, 12 Feb 2016 19:48:26 +0000 (19:48 +0000)]
Merge "Adding tests for L2 Gateway Northbound API"

8 years agoMerge "Bug 5278 [BORON] Remove checks that require neutron providers for L3 and others"
Isaku Yamahata [Fri, 12 Feb 2016 19:33:22 +0000 (19:33 +0000)]
Merge "Bug 5278 [BORON] Remove checks that require neutron providers for L3 and others"

8 years agoAdding tests for L2 Gateway Northbound API 73/34573/1
Ritu Sood [Tue, 19 Jan 2016 08:08:08 +0000 (00:08 -0800)]
Adding tests for L2 Gateway Northbound API

Adding tests for post, put, get and Delete API's

Change-Id: Iaa8412a48f03a90cee715b65d49c6e17dd4cb77c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
(cherry picked from commit b4f14c65faa90889dfbb4274d7a40e6b7468eb27)

8 years agoBug 5278 [BORON] Remove checks that require neutron providers for L3 and others 26/33826/4
Isaku Yamahata [Sun, 31 Jan 2016 13:51:18 +0000 (13:51 +0000)]
Bug 5278 [BORON] Remove checks that require neutron providers for L3 and others

DO NOT MERGE in Beryllium.
This patch is follow up of 49479f5244ac3c7a9a2fc06f7bbb0fed9ca3b203
It missed L3, lbaaspools, and Metering Label.
This patch includes also related code clean up to use this.getInstances().

Change-Id: I82c3330dd16309fe9d6bf90e96b371ddafa9a12a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoAdding more test cases to increase the code coverage of Neutron tests 33/34033/4
Pramod [Wed, 3 Feb 2016 21:46:44 +0000 (13:46 -0800)]
Adding more test cases to increase the code coverage of Neutron tests

Refactoring the code for collection tests to remove the wait from the test
Fixed the required changes

Change-Id: If6ff2851e26836cde25161ba43aade0d10448a91
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>
8 years agoBUG-5137: extraroutes in router not working 62/34062/1
Vishal Thapar [Mon, 1 Feb 2016 08:51:15 +0000 (14:21 +0530)]
BUG-5137: extraroutes in router not working

Neutron API defines extraroutes as list of destination and nexthop but in
neutron-l3.yang they're defined as list of strings. So, when these routes
are present in a router object sent by openstack we are unable to store
them in MDSAL. Fix is to change the type of routes in l3-attributes to
match with what Neutron API sends us.

Change-Id: I83519edcbdf6f4fcae34ae9650cf8ede40256296
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit 59f3919dd01797fb056fa5dcdebda2076a936954)

8 years agoAdd more tests to improve Code Coverage for Neutron Load balancer related files 12/33512/9
Pramod [Mon, 25 Jan 2016 22:11:05 +0000 (14:11 -0800)]
Add more tests to improve Code Coverage for Neutron Load balancer related files

Change-Id: If940948c993930f47840c935f14bcd039d7f5ba8
Signed-off-by: Pramod <pramod.raghavendra.jayathirth@intel.com>
(cherry picked from commit 492923ba34786b212e263cb84f452e26659be15d)

8 years agoBump yangtools to 1.0.0-SNAPSHOT 73/33273/3
Thanh Ha [Thu, 21 Jan 2016 20:56:52 +0000 (15:56 -0500)]
Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: I74de7043fe75c081f6d5a8b8b686fb3e9516aacd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years ago[BORON] Remove checks that require neutron providers 91/27291/6
Flavio Fernandes [Tue, 22 Sep 2015 14:51:09 +0000 (10:51 -0400)]
[BORON] Remove checks that require neutron providers

DO NOT MERGE in Beryllium.

- Remove exceptions caused when there are no I*Aware providers registered

Patch set 2: Make I*Aware interfaces deprecated in a separate gerrit [1]
Patch set 6: Rebase and use AbstractNeutronNorthboundIAware

With this change, we take one step closer to the desired goal of making
neutron northbound md-sal based. By Boron, ODL applications will be expected
to access all neutron northbound related data via the API provided by
the corresponding yang data models.

[1]: https://git.opendaylight.org/gerrit/#/c/27297/

Change-Id: I15ae07ff85620b3ceaf9e13b6aa386ec0aa669b0
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoBump versions by 0.1.0 for next dev cycle 14/32714/1
Thanh Ha [Fri, 15 Jan 2016 04:40:30 +0000 (23:40 -0500)]
Bump versions by 0.1.0 for next dev cycle

Change-Id: Ia84b1a7e2860e4af71b119b7f0f9e98cf40d51e6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoMerge "Add more tests to improve Code Coverage for VPN related files"
Isaku Yamahata [Thu, 14 Jan 2016 19:57:56 +0000 (19:57 +0000)]
Merge "Add more tests to improve Code Coverage for VPN related files"

8 years agoMerge "Add more tests to improve Code Coverage for Load Balancer related files"
Isaku Yamahata [Thu, 14 Jan 2016 19:57:53 +0000 (19:57 +0000)]
Merge "Add more tests to improve Code Coverage for Load Balancer related files"

8 years agoMerge "Add more tests to improve code coverage"
Isaku Yamahata [Thu, 14 Jan 2016 19:57:49 +0000 (19:57 +0000)]
Merge "Add more tests to improve code coverage"

8 years agoMerge "Add more tests to improve Code Coverage for Metering files"
Isaku Yamahata [Thu, 14 Jan 2016 19:57:46 +0000 (19:57 +0000)]
Merge "Add more tests to improve Code Coverage for Metering files"

8 years agoMerge "Add more tests to improve Code Coverage"
Isaku Yamahata [Thu, 14 Jan 2016 19:57:43 +0000 (19:57 +0000)]
Merge "Add more tests to improve Code Coverage"

8 years agoEnhance Neutron Firewall tests to get better code coverage 81/31981/4
Ritu Sood [Thu, 31 Dec 2015 04:15:27 +0000 (20:15 -0800)]
Enhance Neutron Firewall tests to get better code coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in the files covered.
Also reverted the changes made to existing tests.

Change-Id: I8da4c7b7058915bb1c23a857b5f85d4281c3700e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoAdd more tests to improve Code Coverage 75/32375/1
Ritu Sood [Mon, 11 Jan 2016 05:38:42 +0000 (21:38 -0800)]
Add more tests to improve Code Coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by 12% for these files

Change-Id: Ib80bd954ce2373fc13d36191d27e2bdb06f74a39
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoAdd more tests to improve Code Coverage for Metering files 65/32365/1
Ritu Sood [Mon, 11 Jan 2016 01:50:46 +0000 (17:50 -0800)]
Add more tests to improve Code Coverage for Metering files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~13% in these files

Change-Id: I2c55ee615e432280c73e3ee643e476a7528fef8e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoAdd more tests to improve Code Coverage for Load Balancer related files 63/32363/1
Ritu Sood [Mon, 11 Jan 2016 01:03:07 +0000 (17:03 -0800)]
Add more tests to improve Code Coverage for Load Balancer related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in these files

Change-Id: I7fff8a65b3a33bab5f97a9480fee177982add169
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoMerge "Bug 4845 - prefix neutron stuff to model bundle name"
Flavio Fernandes [Fri, 8 Jan 2016 17:37:26 +0000 (17:37 +0000)]
Merge "Bug 4845 - prefix neutron stuff to model bundle name"

8 years agoAdd more tests to improve Code Coverage for VPN related files 99/32299/1
Ritu Sood [Fri, 8 Jan 2016 04:19:05 +0000 (20:19 -0800)]
Add more tests to improve Code Coverage for VPN related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~17% in these files

Change-Id: Ia256aa2df4f0be138e6683c3dd0b42c8f42a724b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoAdd more tests to improve code coverage 39/32239/3
Ritu Sood [Thu, 7 Jan 2016 03:43:23 +0000 (19:43 -0800)]
Add more tests to improve code coverage

Adding new tests 1)update and 2)get with query achieved more
functional coverage. Moving the collection_get_test later after the
nodes were created helped getting more condition coverage in
listGroups and listRules functions. Improved code coverage from
66% to 80% for NeutronSecurityGroupsNorthbound and
42% to 70% NeutronSecurityRulesNorthbound.

Change-Id: I56708a0c1c66158dd29784a9a2edd99e5749077e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
8 years agoBug 4848 - Remove provider attributes from top neutron container 46/31946/1
gong yong sheng [Wed, 30 Dec 2015 01:52:52 +0000 (09:52 +0800)]
Bug 4848 - Remove provider attributes from top neutron container

Provider attributes should not be under top neutron container.

Change-Id: I0369d651f9791d3077cf65fed2b6509a598dc7aa
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>
8 years agoBug 4845 - prefix neutron stuff to model bundle name 05/31905/1
gong yong sheng [Mon, 28 Dec 2015 10:34:59 +0000 (18:34 +0800)]
Bug 4845 - prefix neutron stuff to model bundle name

Add maven-bundle-plugin build plugin in POM to generate proper
bundle name.

Change-Id: I95821608ffe3acc63ced3c153bd880d404f4ff3d
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>
8 years agoMerge "Bug 4818 dnsNameservers not stored in subnet MDSAL"
Flavio Fernandes [Thu, 24 Dec 2015 02:29:24 +0000 (02:29 +0000)]
Merge "Bug 4818 dnsNameservers not stored in subnet MDSAL"

8 years agoBug 4838 - add missing LICENSE file 53/31853/1
Isaku Yamahata [Wed, 23 Dec 2015 22:31:48 +0000 (14:31 -0800)]
Bug 4838 - add missing LICENSE file

This patch adds a LICENSE file to show the terms of license explicitly.

Change-Id: Ie1732ea1b523220bb5a582e858a6dec6d279464e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoBug 4818 dnsNameservers not stored in subnet MDSAL 80/31580/3
Vishal Thapar [Fri, 18 Dec 2015 08:37:30 +0000 (14:07 +0530)]
Bug 4818 dnsNameservers not stored in subnet MDSAL

NeutronSubnet.initDefaults() wrongly initializes dnsNameservers even if
user passed a value. There should be a null check and initialization should
be done only if user didn't pass anything.

This adds check for dnsNameservers and improves the test cases in NeutronSubnetTests

Change-Id: Ibade65f18a65b9c8e6c0a26de02bbbbbe5cac0b7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
8 years agoMerge "Bug 4805 add host_routes info to MDSAL"
Isaku Yamahata [Tue, 22 Dec 2015 17:10:19 +0000 (17:10 +0000)]
Merge "Bug 4805 add host_routes info to MDSAL"