Thanh Ha [Sat, 19 Mar 2016 15:42:54 +0000 (11:42 -0400)]
Remove skip install for library karaf
Missed the library-it in my last patch to fix this.
Change-Id: I2a32cda2644331df592416b0770383b9edd584fb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Fri, 18 Mar 2016 20:15:01 +0000 (16:15 -0400)]
Remove skip install for hwvtepsouthbound and southbound karaf
Not sure why the ovsdb-verify job didn't catch this but we do need to
at least install the karaf distro after all for integrationtests that
need them. Deploy is still unnecessary.
Change-Id: If9fe6346c351a1bd4d875848240129da253535cc
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Sam Hague [Thu, 17 Mar 2016 19:20:27 +0000 (19:20 +0000)]
Merge "Bug 5542 - Southbound plugin doesn't allow controller initiated re-connection"
Sam Hague [Thu, 17 Mar 2016 19:20:05 +0000 (19:20 +0000)]
Merge "Changes for netvirt neutron renderer yang model."
Sam Hague [Thu, 17 Mar 2016 19:19:50 +0000 (19:19 +0000)]
Merge "Do not install or deploy the karaf artifact"
Victor Pickard [Tue, 15 Mar 2016 17:14:33 +0000 (13:14 -0400)]
Changes for netvirt neutron renderer yang model.
Change-Id: I92a4bba37a4c5b63a5ce1311654d27a82bff7210
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Thanh Ha [Wed, 16 Mar 2016 22:32:11 +0000 (18:32 -0400)]
Do not install or deploy the karaf artifact
The karaf artifact is only used for testing. It does not need to be
released to the world.
Change-Id: Ic7034bd79f7b2ddace82f7f114070f83f9b5a66f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Vishal Thapar [Thu, 17 Mar 2016 05:12:21 +0000 (10:42 +0530)]
Bug 5542 - Southbound plugin doesn't allow controller initiated
re-connection
HWVTEP fix based off similar fix in Southbound plugin
SB fix: https://git.opendaylight.org/gerrit/#/c/36278/
Change-Id: Iffab3b9d883bd0f4fd973d398b4e3b8c9dafd52d
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Mon, 14 Mar 2016 15:57:36 +0000 (21:27 +0530)]
BUG 5514: McastMac entries not added correctly
1. Use uuid as match criteria when updating mac table entries.
2. Add logical-switch-ref as key to mac entries in yang
Change-Id: I4357f1362648b6ce72e5825ad398d0eb166f91e0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Thu, 17 Mar 2016 14:35:43 +0000 (15:35 +0100)]
Add a commons-net bundle
net-virt depends on commons-net, so bundle it explicitly in the
relevant features instead of relying on neutron to provide it for
us. (This avoids errors when ovsdb builds with a newer version than
neutron.)
Change-Id: Ifd4b7909b44a824f7ebb0347753502c9e509c96e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Wed, 16 Mar 2016 12:58:25 +0000 (12:58 +0000)]
Merge "Use controller.mdsal.version when appropriate"
Anil Vishnoi [Wed, 16 Mar 2016 08:19:02 +0000 (01:19 -0700)]
Bug 5542 - Southbound plugin doesn't allow controller initiated re-connection
Change-Id: I90992a3132a5b85ff5bb115f562c9bc5989f277a
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Mike Kolesnik [Tue, 15 Mar 2016 12:00:42 +0000 (14:00 +0200)]
Use controller.mdsal.version when appropriate
Use the property controller.mdsal.version when looking for mdsal
artifacts from org.opendaylight.controller.
Otherwise, it's confusing since mdsal.version actually referrs to
artifacts from org.opendaylight.mdsal.
Change-Id: If95f835e491bd6f1cb0a21f1f7cc72bb06ef2cb2
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 15 Mar 2016 20:34:11 +0000 (20:34 +0000)]
Merge "Bug 5435 - Arp flows are not getting installed properly in compute nodes"
Sam Hague [Tue, 15 Mar 2016 14:20:47 +0000 (14:20 +0000)]
Merge "Re-enable SingleFeatureTest"
Stephen Kitt [Tue, 15 Mar 2016 09:39:16 +0000 (10:39 +0100)]
Re-enable SingleFeatureTest
For SingleFeatureTest to run, features modules need to specify
"<packaging>jar</packaging>" (even though they don't produce a JAR we
care about).
Change-Id: I9b1b73aff4a6e30e2fa2389b6da0525c5e8d87d6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
oshvartz [Tue, 15 Mar 2016 09:02:30 +0000 (11:02 +0200)]
Bug 5435 - Arp flows are not getting installed properly in compute nodes
Do not clean router interface ARP flows even if the
network segmentation does not exists in the given node.
Change-Id: I6de68c6b2e2d34d7f982eca74dfc73d42d26a5df
Signed-off-by: oshvartz <oshvartz@redhat.com>
Josh [Tue, 15 Mar 2016 07:22:43 +0000 (09:22 +0200)]
Scripts to pretty print ovs flows and odl logs
Change-Id: If002fef89ed257057b9832227203c2d9e6dd3655
Signed-off-by: Josh <jhershbe@redhat.com>
Josh [Mon, 14 Mar 2016 18:24:53 +0000 (20:24 +0200)]
Undo key in Trunks to fix IT test
Change-Id: Ida7177ecb2b72c21e555e182db016d83ed79307e
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Mon, 14 Mar 2016 15:48:18 +0000 (15:48 +0000)]
Merge "Fix vagrant up by adding libssl-dev package to mininet puppet manifest"
Stephen Kitt [Mon, 14 Mar 2016 14:47:54 +0000 (15:47 +0100)]
BUG-5507: ignore schema-related AutoAttach errors
When initialising OvsdbAutoAttachedRemovedCommand and
OvsdbAutoAttachUpdateCommand, schemas without support for autoattach
cause IllegalArgumentException to be thrown. This is in all likelihood
the only scenario which can lead to this, so for now ignore the
exceptions.
A proper fix would involve checking the schema as done in TyperUtils.
Once this is done these constructors will be updated to use that
instead of ignoring IllegalArgumentException.
Change-Id: Idd284ab8acdc0886ef11dae6ecfb410e487ca312
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Hsin-Yi Shen [Thu, 25 Feb 2016 23:54:41 +0000 (15:54 -0800)]
OVSDB library: Close conneciton when peer is down
In current implementation connection is not closed when peer is down
before it has chance to send TCP FIN packet. We have seen this issue
when peer is power off or crashed. With this fix, OVSDB server will
get IdleState.READER_IDLE event and send echo message to peer when
no channel read is performed for 60 seconds. OVSDB server will also
receive ReadTimeoutException and close the connection after 600 seconds.
Bug: 5506
Change-Id: I602b2ba3d34bc5e09546fe4e0584d8d0db42867e
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Frederick F. Kautz IV [Sun, 13 Mar 2016 20:35:23 +0000 (13:35 -0700)]
Fix vagrant up by adding libssl-dev package to mininet puppet manifest
Bug: 5505
Change-Id: I0409b33e27546515027eec7c883e309a8a09fb27
Signed-off-by: Frederick F. Kautz IV <fkautz@redhat.com>
Sam Hague [Sun, 13 Mar 2016 19:21:10 +0000 (19:21 +0000)]
Merge "BUG-4417 Program tunnel flows on new Neutron nodes"
Josh [Thu, 10 Mar 2016 18:13:17 +0000 (20:13 +0200)]
BUG-4417 Program tunnel flows on new Neutron nodes
Here's how the fix works.
1) In handleInterfaceUpdate, when a bridge comes in
that does not have any tap ports on it, we remember
that as a "new node"
2) When a tap port comes in for that new node we
trigger interfaceUpdates to fill in the missing
tunnel flows from *other* ports to this new node -
ingress and egress.
Change-Id: I872e875f7a1f254f0bd14b7da4ed572ee7e40b9b
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Fri, 11 Mar 2016 21:09:33 +0000 (21:09 +0000)]
Merge "Integration tests for AutoAttach Table"
Sam Hague [Fri, 11 Mar 2016 20:56:27 +0000 (20:56 +0000)]
Merge "Bug 5174: Support for AutoAttach Table in OVSDB"
Rashmi Pujar [Tue, 8 Mar 2016 19:53:35 +0000 (14:53 -0500)]
Integration tests for AutoAttach Table
- IT test for library/schema
- IT for southbound
Change-Id: I5e6d665aba7bc2c20fcf264d1f06ed62070630e0
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Rashmi Pujar [Mon, 1 Feb 2016 17:23:41 +0000 (12:23 -0500)]
Bug 5174: Support for AutoAttach Table in OVSDB
Change-Id: I325f58517caa66079de26c70d2818770968ef3bf
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Vishal Thapar [Wed, 9 Mar 2016 18:00:06 +0000 (23:30 +0530)]
Bug 5480 - bfd not supported by SB plugin
Schema definition for it is present in library but definition in
ovsdb.yang and relevant code is missing.
This fix adds yang model and related code for bfd cofiguration and status.
Change-Id: I171478949079a4c39d8de9f0f7fb2bfcfb53e8b5
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Sat, 5 Mar 2016 11:09:59 +0000 (16:39 +0530)]
Add uuid for mac-entries, improved logging
1. Store and use uuid for entries in mac-tables
2. Fix and improve logging for easier troubleshooting
3. A workaround in PhysicalSwitchUpdate
Change-Id: I6da68e59bcacdeef43a3e353f934bd8097a44253
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Anil Vishnoi [Mon, 7 Mar 2016 19:00:22 +0000 (11:00 -0800)]
Net-virt is not checking if the master of the net-virt-application is
elected at the clustering level or not. Because of this it can end up in a situation
where candidates are registered but owner is not elected and all the instances
gets false when they check for the owner. This patch fixes the issue, where
it waits till owner is selected
Change-Id: I2c720aeac44e4252091952383fe3bb4ed9bed97b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vishal Thapar [Thu, 10 Mar 2016 12:26:21 +0000 (12:26 +0000)]
Merge "Fix namespace mismatch between hwgw.yang and default-config.xml."
Vishal Thapar [Thu, 10 Mar 2016 12:26:13 +0000 (12:26 +0000)]
Merge "Initial NetVirt Neutron renderer."
Stephen Kitt [Thu, 10 Mar 2016 12:00:17 +0000 (12:00 +0000)]
Merge "BUG 5477: CandidateAlreadyRegisteredException in hwvtep cluster setup"
Vishal Thapar [Thu, 10 Mar 2016 09:00:47 +0000 (09:00 +0000)]
Merge "Use a utility function for key-value to map conversions"
Vishal Thapar [Wed, 9 Mar 2016 12:53:37 +0000 (18:23 +0530)]
BUG 5477: CandidateAlreadyRegisteredException in hwvtep cluster setup
Hwvtep uses DTCN and gets the updated object instead of just delta. So any
updates include connectionInfo which trigger connection manager on
non-owner nodes to wrongly attempt candidate registration.
Change-Id: Id7cf4a0ba7c3f52201381994bad01cb73cda3123
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Andre Fredette [Wed, 9 Mar 2016 15:26:11 +0000 (10:26 -0500)]
Fix namespace mismatch between hwgw.yang and default-config.xml.
Change-Id: I29ed6ce9a25b60ace4b48502a0558094a2b53743
Signed-off-by: Andre Fredette <afredette@redhat.com>
Andre Fredette [Tue, 8 Mar 2016 21:03:21 +0000 (16:03 -0500)]
Initial NetVirt Neutron renderer.
Change-Id: Iba4827b733d68d8c15148a61583a75d3ed9cb3a1
Signed-off-by: Andre Fredette <afredette@redhat.com>
Stephen Kitt [Thu, 25 Feb 2016 15:57:26 +0000 (16:57 +0100)]
Use a utility function for key-value to map conversions
YangUtils::convertKeyValueListToMap() reproduces the behaviour
expected when converting a list of YANG key values to a map: it checks
that all the keys and values are non-null, and converts them to
strings using the appropriate methods in each YANG type.
This patch can't be back-ported to Beryllium since it uses Java 8
constructs.
Change-Id: Iaeb751ca552caf6b8f5a6d5a6e506e5d2aa4e63f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Eric Multanen [Fri, 29 Jan 2016 16:35:02 +0000 (08:35 -0800)]
IT:SouthboundIT - add tests for Qos and Queue
Add a set of tests for Qos and Queue table support.
v2 - addressed comments:
- Modified builder usage in TestQos and TestQueue
- Enhanced NotifyingDataChangeListener to handle
any instanceidentifier, updated Qos and Queue
tests to use to wait for configuraiton and
operational changes instead of doing timeouts.
(prior usages in other tests were not modified.
Other tests which utilize timeouts were not
updated to use waits for changes.)
Change-Id: Id965c402032470b114178539c2690491eabe0171
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
(cherry picked from commit
ccc09694a98686163433e26fb2ef7db93a00a00b)
Andre Fredette [Sun, 6 Mar 2016 23:06:17 +0000 (18:06 -0500)]
Bug 5466 - GatewayMacResolver Broken
"nIP.getIpAddress().getBytes()" returns a byte representation of the
IP address string (including periods). What we really want is a byte
representation of the IP address represented by the string.
The solution is to use the InetAddress.getByName method that takes an
IP address string directly.
Change-Id: I39dcc1b8e97ab175e23d5aa2c9310581b87214ee
Signed-off-by: Andre Fredette <afredette@redhat.com>
Josh [Sun, 6 Mar 2016 12:14:41 +0000 (14:14 +0200)]
Minor cleanups on ovsdb.yang
1. Replaced non-ascii character with ascii equivalents
2. Added a key to a list which is used as config per
RFC 6020, section 7.8.2
Change-Id: I77cb7fbf91752b24044ceb06ec6ce0cffbcbac65
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Fri, 4 Mar 2016 15:48:33 +0000 (15:48 +0000)]
Merge "Bug 5174: Added AutoAttach attributes"
Vishal Thapar [Fri, 26 Feb 2016 16:49:45 +0000 (22:19 +0530)]
BUG 5366: SB and hwvtep don't work together
This is a follow up patch for
https://git.opendaylight.org/gerrit/#/c/34913/
That patch didn't seem to fully fix the issue. Refer bugzilla for more
details.
Change-Id: Ia746fb2a15207d386978d6c6515cc34e336328cc
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Robert Varga [Fri, 26 Feb 2016 21:10:13 +0000 (22:10 +0100)]
Use InetAddresses to instantiate IPv4 addresses
Unlike .getByName(), these do not trigger resolver. The IPv6 version
unmasks mapped addresses, hence it is not used here.
Change-Id: I5164f28cab29a4fec624d906fa198ffa21dd0e87
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 26 Feb 2016 20:59:45 +0000 (21:59 +0100)]
Use IetfInetUtil for IPv4 address creation
Optimized version for instantiating a IpAddress from InetAddress. There
is also a IPv6 version of this, but that produces differently-formatted
addresses and break strict backwards compatibility.
Change-Id: I40d2204b5709e5fa6fe2b98af86a893a07b36862
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 26 Feb 2016 20:48:53 +0000 (21:48 +0100)]
Do not duplicate MacAddress objects
MacAddress is an immutable object, hence it does not make sense to
duplicate it. Same is true for IpvXPrefix.
Change-Id: Ic3e4ec8cc66e90ba13e93d47630d104d2188f738
Signed-off-by: Robert Varga <rovarga@cisco.com>
Sam Hague [Sat, 27 Feb 2016 16:07:04 +0000 (16:07 +0000)]
Merge "Initial Draft of NetVirt Yang"
Sam Hague [Thu, 25 Feb 2016 15:20:53 +0000 (15:20 +0000)]
Merge "BUG 5399: HWVTEP Tunnels not added to OperDS"
Vishal Thapar [Wed, 24 Feb 2016 09:38:14 +0000 (15:08 +0530)]
Bug 5392: BFD Params not pushed to switch
Configuring HwVTEP Tunnel Table BFD Parameters from northbound is not
persisted on the switch. BFD params were added to yang but code to push DS
changes to switch was still TODO. This change adds the code for it.
Change-Id: I3837966d5b3385b0c16feec9fc40a7cc221fa380
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Thu, 25 Feb 2016 08:43:27 +0000 (14:13 +0530)]
BUG 5399: HWVTEP Tunnels not added to OperDS
Populating tunnels list in physical switch table is not updating topology
operational DS. PhysicalSwitchUpdate.setTunnels() is making a wrong check for
isEmpty() to determine if data needs to be added to data store or not. It should be !isEmpty()
Change-Id: Iec4f773210fb07d019299558fb63f949b05788a7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Wed, 24 Feb 2016 21:04:26 +0000 (21:04 +0000)]
Merge "BUG-5404 Dangling Distributed ARP flows for DHCP"
Josh [Wed, 24 Feb 2016 14:33:23 +0000 (16:33 +0200)]
BUG-5404 Dangling Distributed ARP flows for DHCP
Neutron modifies the port before deleting it,
removing the IP address. As such, when it is
deleted the flow can't be deleted since the IP
address is part of the flow's match. To fix
this we cache port->IP mappings for DHCP ports.
Change-Id: I6caa75887de0193256b14d88ef1fd5540f861e34
Signed-off-by: Josh <jhershbe@redhat.com>
oshvartz [Sun, 21 Feb 2016 10:44:21 +0000 (12:44 +0200)]
Bug 5353: Missing Floating IP rules after VM restart
A SouthboundEvent is generated when the VM goes down
which triggers the flows in table:30 to be removed.
New code was added to NeutronL3Adapter to update the floating IP
rules when handleNeutronPortEvent is triggered with update action.
Change-Id: Ic2a5620b1e4c65f1d0d31c666730da46101c5e87
Signed-off-by: oshvartz <oshvartz@redhat.com>
Andre Fredette [Sun, 24 Jan 2016 23:51:12 +0000 (18:51 -0500)]
Initial Draft of NetVirt Yang
This model is based on the following documents:
https://goo.gl/dpch7X
https://goo.gl/ygd7aN
This is intended to be a starting point for the L2 portions
of the NetVirt design.
Change-Id: I5eabccb4a38fa7988886217b0ef507a2e29d2e3c
Signed-off-by: Andre Fredette <afredette@redhat.com>
Stephen Kitt [Tue, 23 Feb 2016 16:54:24 +0000 (17:54 +0100)]
Pull in PowerMock from odlparent
odlparent now manages dependencies for PowerMock, in sync with
Mockito. Rely on that instead of defining our own versions; this also
upgrades all our uses to 1.6.4.
Change-Id: Ie049cff9d963dfe51d715b17da3c63f9cd26d570
Signed-off-by: Stephen Kitt <skitt@redhat.com>
karthik_j [Tue, 2 Feb 2016 20:41:25 +0000 (02:11 +0530)]
Unit test file for DistributedArpService.
Change-Id: I4df82921793f58faa2edd0ac0a2dad43fdfc146e
Signed-off-by: karthik_j <karthik_j@hcl.com>
(cherry picked from commit
9f8d03d35c01fbba8d59134714aa5439e1a3ba91)
Change-Id: I4df82921793f58faa2edd0ac0a2dad43fdfc146e
Signed-off-by: karthik_j <karthik_j@hcl.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 19 Feb 2016 17:16:22 +0000 (17:16 +0000)]
Merge "BUG-5006: rework SouthboundProviderTest, clean up"
Sam Hague [Fri, 19 Feb 2016 17:15:45 +0000 (17:15 +0000)]
Merge "Use registerAbstractHandlerService consistently"
Sam Hague [Fri, 19 Feb 2016 17:13:40 +0000 (17:13 +0000)]
Merge "Bug 5368 - NeutronL3Adapter ipv6 work around for mac address resolver"
Sam Hague [Fri, 19 Feb 2016 17:12:42 +0000 (17:12 +0000)]
Merge "Cleanup exception logging"
Stephen Kitt [Fri, 19 Feb 2016 10:03:26 +0000 (11:03 +0100)]
Cleanup exception logging
Change-Id: Icc711755baad9f377efb00da0ec8b57e5b89f7e3
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 19 Feb 2016 08:12:33 +0000 (08:12 +0000)]
Merge "Bug 5261 - Missing dependency on sal-binding-broker-impl in Boron build"
Vishal Thapar [Thu, 18 Feb 2016 15:11:36 +0000 (20:41 +0530)]
BUG 5366: SB and hwvtep exceptions when both inuse
When hwvtep and ovsdbSB both are enabled their respective
connectionManagers don't check if relevant DB is present or not.
Change-Id: I213ff3495d13a2bb2377ae3146290599280d4489
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Thu, 18 Feb 2016 23:14:40 +0000 (18:14 -0500)]
Bug 5261 - Missing dependency on sal-binding-broker-impl in Boron build
The sal-binding-broker-impl was set at 1.3.0. Boron is at 1.4.0. Removed
the version tag since config-parent will eventually bring in the
mdsal artifacts and the right version.
Change-Id: I2b6cfea13b5bd3eefcd1886855ac315ad1b640a4
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 18 Feb 2016 17:30:59 +0000 (12:30 -0500)]
Update directory descriptions for Beryllium
Change-Id: If49b424e494cb0040bd90a0ef2d518fda024827d
Signed-off-by: Sam Hague <shague@redhat.com>
Conflicts:
README
Change-Id: If49b424e494cb0040bd90a0ef2d518fda024827d
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Thu, 18 Feb 2016 14:38:03 +0000 (15:38 +0100)]
Use registerAbstractHandlerService consistently
NeutronL3Adapter is an AbstractHandler service yet was registered
"manually"; this patch converts it to use
registerAbstractHandlerService.
DistributedArpService is registered following the same pattern but
isn't an AbstractHandler service...
Change-Id: I06cf3c9167d1b2bcb1c08d5ec462beb4d3ac1a38
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Wed, 17 Feb 2016 21:56:48 +0000 (21:56 +0000)]
Merge "Bug 5351 Connection state tracking bit values are changed to match the Ovs2.5 implementiaon."
Sam Hague [Wed, 17 Feb 2016 21:56:12 +0000 (21:56 +0000)]
Merge "removing ovsdb-all feature"
Sam Hague [Wed, 17 Feb 2016 21:55:53 +0000 (21:55 +0000)]
Merge "Remove references to odl-ovsdb-all"
Stephen Kitt [Wed, 17 Feb 2016 08:47:15 +0000 (09:47 +0100)]
Remove references to odl-ovsdb-all
Now that the feature has been removed, update the documentation to
avoid listing it in the examples.
Change-Id: Ibd40e2088df955b8ab46cfcde354f364b1419cb6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Jamo Luhrsen [Tue, 16 Feb 2016 21:48:45 +0000 (13:48 -0800)]
removing ovsdb-all feature
- from the looks of the featuretree graph [0] it seems that
ovsdb-all is not providing any benefit and probably would
confuse an end-user, since all it would install is the
ovsdb-library, which is pulled in by other features as
needed.
[0] https://wiki.opendaylight.org/view/OVSDB_Integration/FeatureTree
Change-Id: I968f33f64f8683d00d9a49904e2aa74795267308
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Isaku Yamahata [Wed, 17 Feb 2016 03:06:03 +0000 (19:06 -0800)]
Bug 5368 - NeutronL3Adapter ipv6 work around for mac address resolver
Right now mac address resolver only supports IPv4 arp, not IPv6
neighbor discovery. So if fixed ip is IPv6, it is ignored for now
to avoid exception as follows.
> 2016-01-21 19:10:01,192 | ERROR | ntDispatcherImpl | EventDispatcher | 279 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event NorthboundEvent [handler=NEUTRON_PORT, action=UPDATE, port=NeutronPort [portUUID=
dc49dbb5-24eb-4126-9112-
6e8a6b117e7a, networkUUID=
43e6202f-5ca4-48d7-99ec-
1c88b3403efd, name=, adminStateUp=true, status=null, macAddress=FA:16:3E:BB:B6:5E, fixedIPs=[Neutron_IPs{ipAddress='2001:db8::1', subnetUUID='
938d6b11-3a12-4d15-ac59-
fa00f8ca68d6'}, Neutron_IPs{ipAddress='172.24.4.2', subnetUUID='
4bdaf41a-37ce-4efe-bfbd-
ef5aa804bee2'}], deviceID=
b93bd54f-5eb9-47a0-9767-
a486b2ff688a, deviceOwner=network:router_gateway, tenantID=
76b28f13a97842299499a47bcbf498f3, securityGroups=[], bindinghostID=, bindingvnicType=normal, bindingvnicType=normal], subnet=null, router=null, routerInterface=null, floatingIP=null, network=null, loadBalancer=null, loadBalancerPool=null, loadBalancerPoolMember=null, neutronsecurityRule=null]
> java.lang.IllegalArgumentException: Supplied value "2001:db8::1" does not match required pattern "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(%[\p{N}\p{L}]+)?$"
> at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[38:com.google.guava:18.0.0]
> at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Address.<init>(Ipv4Address.java:51)[70:org.opendaylight.mdsal.model.ietf-inet-types:2010.9.24.8-SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.triggerGatewayMacResolver(NeutronL3Adapter.java:1529)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:443)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.doNeutronPortUpdated(PortHandler.java:96)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.processEvent(PortHandler.java:167)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:95)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:27)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:56)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_72-internal]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_72-internal]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_72-internal]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_72-internal]
> at java.lang.Thread.run(Thread.java:745)[:1.8.0_72-internal]
Change-Id: Ice966c994c2565c17da2f7953f6febc6bf370e57
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Aswin Suryanarayanan [Mon, 15 Feb 2016 17:05:40 +0000 (22:35 +0530)]
Bug 5351 Connection state tracking bit values are changed to match the
Ovs2.5 implementiaon.
Change-Id: Ia163223a7a25de3b7bca4360c3f6dbadd87851f5
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Stephen Kitt [Tue, 16 Feb 2016 11:12:47 +0000 (12:12 +0100)]
BUG-5006: rework SouthboundProviderTest, clean up
SouthboundProviderTest doesn't need PowerMock, rework it to drive
everything through public methods and verify data-store side-effects
instead of method invocations.
Clean up a few unneeded exception declarations on close() methods.
Remove the last traces of PowerMock from SouthboundMapperTest.
Change-Id: I9b634680211fa528780b6a8b9edc4153744aba08
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Aswin Suryanarayanan [Fri, 12 Feb 2016 22:29:54 +0000 (03:59 +0530)]
Bug 4550
Changed the comparater to .equals.
Change-Id: Ie16cc681fc8e387cd2d85d097a3c380fd60f0e86
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Josh [Tue, 9 Feb 2016 09:31:48 +0000 (11:31 +0200)]
BUG-4917 Ensure all OVS flows are deleted
This commit is basically a revert of this change:
https://git.opendaylight.org/gerrit/#/c/27521/
With that change the cache cleanup in fact never ran because the
port is removed before the code is actually run.
The bug for which that commit was a fix is resolved
with this code new commit as well.
In addition, updateL3ForNeutronPort() now allows
deleting flows even when networkId is not found
in networkIdToRouterMacCache. This takes care of
some of the DHCP issues.
Change-Id: Idc3c1ff4b57f5471615ccc6c627ca8f411c37db2
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit
5824899205c6eb36b45064a3a3f54668e1117a40)
Stephen Kitt [Thu, 11 Feb 2016 17:09:34 +0000 (18:09 +0100)]
BUG-5006: rework SouthboundMapperTest without PowerMock
A number of tests were meaningless, these have all been fixed to
verify SouthboundMapper's behaviour.
Conflicts:
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/SouthboundMapperTest.java
Change-Id: Ia349e545bde9706d2b1840530abd46c09ac55e45
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 12 Feb 2016 00:37:05 +0000 (00:37 +0000)]
Merge "Clean up SouthboundMapper (and fix createQosType())"
Sam Hague [Fri, 12 Feb 2016 00:36:28 +0000 (00:36 +0000)]
Merge "Bug 4550 - always rebuild security group rule in security group"
Sam Hague [Fri, 12 Feb 2016 00:01:22 +0000 (00:01 +0000)]
Merge "Bug 4917 For fixing SG dangling flows. Extended port cache logic to TenantNetworkManagerImpl and SouthboundHandler."
Isaku Yamahata [Wed, 3 Feb 2016 16:02:52 +0000 (08:02 -0800)]
Bug 4550 - always rebuild security group rule in security group
The change set of
906836c289a7e4c3d33669d90515d77e75cfb6d in
neutron northbound repository, the effort transparent neutron
northbound api, caused not to update security group rule in
security group.
So always rebuild rules in NeutronSecurityGroup and keep
security group rule in security group of yang model empty list.
openstack service provider that uses MD-SAL should not use
security group rules in security rule. But it should listen to
data change notification on security group rules.
Change-Id: Ic975e028c01462a2c7267f65c16b3bd857496c73
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit
a18e3f5a3744392c4475c82e4937af2a27d729fa)
Aswin Suryanarayanan [Thu, 11 Feb 2016 01:22:42 +0000 (06:52 +0530)]
Bug 4917 For fixing SG dangling flows. Extended port cache logic to
TenantNetworkManagerImpl and SouthboundHandler.
Added cache for NeutronNetwork. Changed the portcLeanUpCache from set to
map as the entries were not getting cleaned up from the cache.
Change-Id: Id02f2ff85d3d67845d8b618fbcdfded1f7958553
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
(cherry picked from commit
c619afb3a9f8d93b05225daf0b257c28079d4216)
Victor Pickard [Wed, 10 Feb 2016 13:55:40 +0000 (08:55 -0500)]
BUG 5164 Cleanup Floating IP Rules when VM is deleted.
Patch set 3: Address review comments.
Patch set 2: Fixed unit test.
When a VM is deleted, Neutron does not send a notification
to update/delete any floatingip that may have been associated
with a port. As a result, openflow rules for the floating ip
are left installed.
Neutron team says this is expected behavior for floating ip.
So, to cleanup, use neutron port delete event, and find
any associated floating ip, and cleanup installed OF
rules.
Change-Id: If9e2ffc5b16f0da636b3e9b6b1c4fbfd46fd6aff
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Stephen Kitt [Thu, 11 Feb 2016 17:01:34 +0000 (18:01 +0100)]
Clean up SouthboundMapper (and fix createQosType())
SouthboundMapper has a few unused imports and one unused method; this
patch removes them.
It also fixes the default QoS type returned by createQosType().
Change-Id: Ic664ee98b9c4f99d8c28b1b1071837c352e63f81
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Wed, 10 Feb 2016 22:15:40 +0000 (14:15 -0800)]
Bug-5040 : LLDP Spoofing attack warning when using Openstack with ODL Cluster
Change-Id: Ife9fa1bd8fcd02ca4af67c71d2d3429f6477310f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Eric Multanen [Thu, 4 Feb 2016 01:00:56 +0000 (17:00 -0800)]
OVSDB Qos and Queue - Postman examples
Adds a Postman collection of RESTCONF commands for doing
CRUD operations with Qos and Queue entries.
v2 - remove tabs
v3 - remove tabs in right file
Change-Id: I8e98b2f9b5c6e517a5a60516fe21fce063e169e2
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Sam Hague [Thu, 4 Feb 2016 23:17:28 +0000 (18:17 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
e0bf1166f4ad2515859ab43080a28115975a2cf5)
Change-Id: I0874c752f8777d8a3f6a7f8f60db22c605c986a3
Signed-off-by: Sam Hague <shague@redhat.com>
Icaro Camelo [Mon, 1 Feb 2016 17:04:48 +0000 (12:04 -0500)]
Bug 5174: Added AutoAttach attributes
Change-Id: Ia8e06c206c2f869a34d148d78d5f549dfedf9ac5
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>
Sam Hague [Thu, 4 Feb 2016 02:26:56 +0000 (21:26 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
498fe4df2997839fdf12555eb5961008ce9eab1a)
Change-Id: Ibf950ae9b56317441014497ffd4260580326d802
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 4 Feb 2016 14:13:12 +0000 (14:13 +0000)]
Merge "Fix for changes to neutron-l3.yang"
Sam Hague [Thu, 4 Feb 2016 02:42:46 +0000 (02:42 +0000)]
Merge "BUG-5006: rework tests using AbstractDataBrokerTest"
Sam Hague [Thu, 4 Feb 2016 02:42:27 +0000 (02:42 +0000)]
Merge "Use constants for NeutronSecurityRule"
Vishal Thapar [Tue, 2 Feb 2016 18:53:25 +0000 (00:23 +0530)]
Fix for changes to neutron-l3.yang
Fix for BUG5137 in neutron breaks any code using routes option of
NeutronRouter. This fix is to change type of routes from String to Routes
as per yang changes.
Change-Id: I89866b31003a8b384c45ef9b451c5d189961df60
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit
61b1b633dfcd9fc1080286ef32d5683e41dff5a5)
Aswin Suryanarayanan [Tue, 2 Feb 2016 21:36:44 +0000 (03:06 +0530)]
Fixes Bug 5187
remote security group will continue the addition/deletion of rules after
logging if not found in cache.
Change-Id: Ic6129b0e8884a185e0907789de66a5df3eee39c0
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Stephen Kitt [Tue, 2 Feb 2016 13:33:23 +0000 (14:33 +0100)]
BUG-5006: rework tests using AbstractDataBrokerTest
Change-Id: I5d7acd00cfc71291e622bd79dc850a24be63f084
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Rashmi Pujar [Mon, 1 Feb 2016 18:05:41 +0000 (13:05 -0500)]
BUG 5172: Handle SchemaVersionMismatchException for lldp column
Change-Id: I3014048642b298bdb347660c3ac0704c23996e22
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Stephen Kitt [Mon, 1 Feb 2016 16:39:43 +0000 (17:39 +0100)]
Use constants for NeutronSecurityRule
This patch introduces constants for the directions, protocols and
ethertypes in NeutronSecurityRule.
There's also a bunch of small clean-ups in the affected classes.
Change-Id: Ia07efa48eb431f560d9f1f947170e1fb68e24ddb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
hari.pr [Tue, 26 Jan 2016 05:56:45 +0000 (11:26 +0530)]
BUG-4892:fixed Not getting Arp flows if there is no Router
*Moved the ARP handling part to a new file, This way the
ARP Entries are not restricted to l3 operations only.
*Tested L2 and L3 operations.
From our understanding
In router scenario whenever router created using openstack, netvirt
south bound handler will receive interface update event. ARP responder
will program the arp rules for the router interface event through
distributed arp service class.
(openstack àrouter create àsouthbound handleràprocess event àprocess interface updateàARP handleinterface eventàprogram ARP)
In normal L2 scenario whenever tenant network created using openstack,
netvirt will receive neutron port add event distributed arp service
class use this neutron port details to program arp rules for the DHCP IP.
Whenever VM instance created using openstack, netvirt will receive
neutron port event distributed arp service class use this neutron port
details to program arp rules for particular VM IP.
(openstackàVM instance à port handleràprocess eventà do neutronport(ADD/UPDATE/DELETE) à handle port àprogram ARP)
Change-Id: Ie56bd5d407f501b8a82f9fe3ad0672e57448eeef
Signed-off-by: hari.pr <hari.pr@hcl.com>