Milos Fabian [Tue, 8 Jul 2014 10:15:36 +0000 (12:15 +0200)]
Bug-194: Moved topology configuration artifacts
-moved yang files
-renamed yang module
-added required dependencies
-left configuration artifact with minimal pom.xml
Change-Id: I4483544800c942b072aad833769bfb52ae2ea64b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 8 Jul 2014 08:21:23 +0000 (10:21 +0200)]
Bug-194: Moved programming configuration artifacts
-moved yang modules and java files
-uniformed config yang modules name
-left configuration artifacts with minimal pom.xml
Change-Id: I1cc2734dc3e9ff320f614e31bd1b14c97ba2130d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sun, 13 Jul 2014 13:29:25 +0000 (13:29 +0000)]
Merge "BUG-731 : extracted parts of long methods to separate methods - added test"
Robert Varga [Sun, 13 Jul 2014 13:27:58 +0000 (13:27 +0000)]
Merge "Fixed incorrect parsing of Linklocal/remote link identifier."
Dana Kutenicsova [Fri, 11 Jul 2014 21:55:22 +0000 (23:55 +0200)]
BUG-730 : added tests for pcep-spi.
Change-Id: I52b8b15cf8d2105f870213be1fe7c4b406a73524
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 10 Jul 2014 12:35:08 +0000 (14:35 +0200)]
BUG-731 : extracted parts of long methods to separate methods
- added test
Change-Id: I3e8eaf642d9dd9f9f14501455cc69d1f87a4801b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 10 Jul 2014 12:27:22 +0000 (14:27 +0200)]
Fixed incorrect parsing of Linklocal/remote link identifier.
Change-Id: I28da0b76b991b619da98f4772469dd5db18d9f02
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Maros Marsalek [Fri, 4 Jul 2014 13:05:06 +0000 (15:05 +0200)]
BUG-338 Allow incomming BGP connections.
Added BGPPeerRegistry that holds all configured BGP peers.
Client/Server SessionNegotiators retrieve BGPPeers(SessionListeners) from the BGPPeerRegistry.
Added StrictBGPPeerRegistry (default implementation of BGPPeerRegistry) that allows only 1 session with BGP peer. If second session is being established, the registry drops either already established or new BGP session (depending on higher source BGP ID).
Added 2 config attributes to BGPPeer:
- initiate connection: true to start BGP connection from ODL. False if just configure BGP peer to accept session from remote device.
- peer registry: dependency on BGPPeerRegistry. Peer registers itself into this registry.
* new attributes are optional to preserve backwards compatibility.
Change-Id: I2f7a606db5196fed49094d49efbb570c4d0fbecb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Dana Kutenicsova [Tue, 8 Jul 2014 13:00:00 +0000 (13:00 +0000)]
Merge "BUG-1287: migrate tests to new APIs"
Dana Kutenicsova [Tue, 8 Jul 2014 12:51:22 +0000 (12:51 +0000)]
Merge "Bug-731: pcep Tlv serializers - fixed sonar issues"
Dana Kutenicsova [Tue, 8 Jul 2014 12:50:57 +0000 (12:50 +0000)]
Merge "Bug-731: fixed segment-routing sonar issues."
Milos Fabian [Tue, 8 Jul 2014 08:52:13 +0000 (10:52 +0200)]
Bug-731: pcep Tlv serializers - fixed sonar issues
-no need to check for null before an insteadof
-fixed precondition checks in Tlv serializers
Change-Id: I8727f83beb713c427c0337b9058c00490631b1e8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 7 Jul 2014 10:59:23 +0000 (12:59 +0200)]
Bug-731: fixed segment-routing sonar issues.
Change-Id: Ie6e120f38ebf036fc09cb601d9c46a572cdffe7e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 15:43:56 +0000 (17:43 +0200)]
BUG-730 : cleaned up bgp-parser-impl
Change-Id: I478cc65158c58a7e92adce3de17dc265de779034
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 13:52:30 +0000 (15:52 +0200)]
BUG-730 : added tests to bgp-parser-api
Change-Id: I4b90b646610262cb4ff51b9cf68177eb8113c12c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 6 Jul 2014 07:14:08 +0000 (09:14 +0200)]
BUG-730 : refactor bgp-linkstate
Change-Id: I8a3bac4cb3c3aeaf7b310fbfb4a00a4eb332524b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 7 Jul 2014 18:53:18 +0000 (18:53 +0000)]
Merge "BUG-730 : added test for bgp/concepts"
Dana Kutenicsova [Mon, 7 Jul 2014 09:48:22 +0000 (09:48 +0000)]
Merge "Fixed segment-routing formating."
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:26 +0000 (09:47 +0000)]
Merge "Bug-612: fix segment-routing serializers"
Dana Kutenicsova [Mon, 7 Jul 2014 09:47:12 +0000 (09:47 +0000)]
Merge "Bug-612: ietf-stateful07 serializers - improved code defense."
Dana Kutenicsova [Mon, 7 Jul 2014 09:46:34 +0000 (09:46 +0000)]
Merge "Bug-612: ietf-stateful02 serializers - improved code defense"
Dana Kutenicsova [Mon, 7 Jul 2014 09:43:43 +0000 (09:43 +0000)]
Merge "Bug-612: Base PCEP serializers - more defensive code"
Dana Kutenicsova [Mon, 7 Jul 2014 09:42:16 +0000 (09:42 +0000)]
Merge "Bug-612: Added ByteBufWriteUtil class"
Milos Fabian [Mon, 7 Jul 2014 09:07:02 +0000 (11:07 +0200)]
Fixed segment-routing formating.
-replaced deprecated method call in configuration test
Change-Id: I6f5359e2850a81909c5e519666322463ec00db60
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 7 Jul 2014 09:06:14 +0000 (11:06 +0200)]
Bug-612: fix segment-routing serializers
Change-Id: I1013c09e62c48a4276d6dadd9cd7029e10c9d7a2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 4 Jul 2014 09:00:22 +0000 (11:00 +0200)]
Bug-612: ietf-stateful07 serializers - improved code defense.
-check mandatory arguments
-set zeros for missing arguments
Change-Id: Iad53dba351aaa7080b660644562782d95bf6bb16
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 2 Jul 2014 18:09:05 +0000 (20:09 +0200)]
Bug-612: ietf-stateful02 serializers - improved code defense
-check mandatory arguments
-set zeros for missing arguments
Change-Id: I073064da0e3528407b57de5080fbc8a7ed9bd745
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 2 Jul 2014 13:15:51 +0000 (15:15 +0200)]
Bug-612: Base PCEP serializers - more defensive code
-check mandatory arguments
-set zeros for missing arguments
Change-Id: I02cf0b4c220846f2c8a9cfe3e9d4bd82bad72fa5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 30 Jun 2014 09:02:49 +0000 (11:02 +0200)]
Bug-612: Added ByteBufWriteUtil class
-ByteBuf's write methods utility - writes value if not null, otherwise zeros.
Change-Id: Ie3609df888e83dffb69bf9a5da78a3a1ca4ce91d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sat, 5 Jul 2014 14:48:18 +0000 (16:48 +0200)]
BUG-730 : added test for bgp/concepts
Change-Id: Iab4ed56bf829b2ddfbcf1a675bdec44de9fc2020
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Sat, 5 Jul 2014 12:26:12 +0000 (14:26 +0200)]
BUG-1287: migrate tests to new APIs
Removes the use of deprecated config/yang APIs.
Change-Id: I16714c9721be3da4b41855143ea6df1e7966c2bd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 7 Jul 2014 08:07:53 +0000 (08:07 +0000)]
Merge "BUG-611 : cleaned up advertized/withdrawn routes."
Robert Varga [Mon, 7 Jul 2014 08:00:16 +0000 (08:00 +0000)]
Merge "BUG-731 : clean up BGP parsing/serializing"
Dana Kutenicsova [Mon, 7 Jul 2014 07:55:36 +0000 (07:55 +0000)]
Merge "integration tests - fixed unresolved bundle"
Milos Fabian [Mon, 7 Jul 2014 05:58:01 +0000 (07:58 +0200)]
integration tests - fixed unresolved bundle
-"util" bundle requires "concepts"
Change-Id: I627f43133693d2443566517dd60c652e00805894
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sat, 5 Jul 2014 11:40:24 +0000 (13:40 +0200)]
BUG-611 : cleaned up advertized/withdrawn routes.
Change-Id: I2757f36a5c53d1a1eaac54b43d64dced5c38e69a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 5 Jul 2014 11:34:36 +0000 (13:34 +0200)]
BUG-731 : clean up BGP parsing/serializing
Change-Id: I3da91b14a582c4c5af79e99ac4a6c0cfe95c67ac
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 5 Jul 2014 11:23:17 +0000 (13:23 +0200)]
BUG-611 : cleaned up NextHop parsing/serializing.
Change-Id: I6d162d6665721a6574a00f6125b679dbf43d902d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 4 Jul 2014 16:50:20 +0000 (18:50 +0200)]
BUG-611 : updated tests for serialization
- fixed few minor bugs
Change-Id: I92ac52865fa1b4c26884e73871244ea16697a834
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 4 Jul 2014 16:45:40 +0000 (18:45 +0200)]
BUG-611 : clusterId and originatorId moved to groupings
- to register their serializers in order to Activator
Change-Id: I87c32eec43fb2e983eb3c33394a4358d6ae7d295
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 4 Jul 2014 14:47:45 +0000 (16:47 +0200)]
Fix for failing build (added export to pcep-impl-config).
Change-Id: I4a8315a874b1f64186973d6327170c4c25e93b69
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 3 Jul 2014 13:51:15 +0000 (15:51 +0200)]
Fixed stateful02 breakage.
Change-Id: Ifa1cc416dde2581c11b0c063ae03c57b3e6f1f63
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 4 Jul 2014 07:37:18 +0000 (07:37 +0000)]
Merge "BGPCEP/concepts - get rid of util dependency"
Robert Varga [Fri, 4 Jul 2014 07:35:55 +0000 (07:35 +0000)]
Merge "Repair bgp-rib-impl-config to work with MD5 wiring"
Milos Fabian [Wed, 2 Jul 2014 10:31:59 +0000 (12:31 +0200)]
BGPCEP/concepts - get rid of util dependency
Change-Id: I7fa5d0c426200d0947e6a689f8f9f4986d6722f9
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Wed, 2 Jul 2014 12:34:33 +0000 (14:34 +0200)]
BUG-611 : refactor serializers
Change-Id: I37fac0c7226ef47cda7c96cd5e3163193103d2ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 2 Jul 2014 07:08:34 +0000 (09:08 +0200)]
BUG-611 : cleaned up parser-spi.
- introduced AttributeUtil class
Change-Id: I98a0a77a8e195306dd168a2fa4f1dcf6034d0351
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 3 Jul 2014 14:16:54 +0000 (14:16 +0000)]
Merge "BUG-1279: keep an insertion-sorted iterable of serializers"
Robert Varga [Thu, 3 Jul 2014 14:00:55 +0000 (14:00 +0000)]
Merge "bug1273 - POM restructuring changes for weekly automated releases - introduced odlparent"
Robert Varga [Thu, 3 Jul 2014 13:57:56 +0000 (13:57 +0000)]
Merge "Repair pcep-topology-provider-config to work with MD5 wiring"
Tomas Olvecky [Thu, 3 Jul 2014 10:34:04 +0000 (12:34 +0200)]
Repair bgp-rib-impl-config to work with MD5 wiring
Fix scope of test dependencies, use correct API to
lookup dependent bean attributes - dependencyResolver.getAttribute
instead of platform mbean server.
Extend test to instantiate md5 infrastructure to test custom validation.
Change-Id: I5515f81c0c97494869890eb5d9b41f347f423014
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tomas Olvecky [Wed, 2 Jul 2014 08:38:18 +0000 (10:38 +0200)]
Repair pcep-topology-provider-config to work with MD5 wiring
Fix scope of test dependencies, use correct API to
lookup dependent bean attributes - dependencyResolver.getAttribute
instead of platform mbean server.
Extend test to instantiate md5 infrastructure to test custom validation.
Change-Id: I856ee8f529415866c0747b9a4a6dbf5a102b9e54
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Robert Varga [Wed, 2 Jul 2014 17:18:50 +0000 (19:18 +0200)]
BUG-1279: keep an insertion-sorted iterable of serializers
This will retain the order in which the AttributeSerializers have been
registered, so we can iterate over them in that order.
Change-Id: I0adbec38e79febd2c3084d1f6db65c524c2465c2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Surekha Bejgam [Mon, 30 Jun 2014 21:35:44 +0000 (14:35 -0700)]
bug1273 - POM restructuring changes for weekly automated releases - introduced odlparent
Change-Id: I2965411434265b302d83e9450172fab8da5803a7
Signed-off-by: Surekha Bejgam <sbejgam@cisco.com>
Dana Kutenicsova [Wed, 2 Jul 2014 12:54:05 +0000 (14:54 +0200)]
BUG-1199 : fixed max message length.
Change-Id: I5d38c27d688bd8e78a8d25396ff562fa308c5ef0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Tomas Olvecky [Thu, 3 Jul 2014 09:36:23 +0000 (11:36 +0200)]
Fix tests after md-sal's bundlecontext refactoring
Explicitly invoke GlobalBundleScanningSchemaServiceImpl's
createInstance and destroyInstance in tests that need it.
Change-Id: I3297265ed2191d2a8ecdaa92c9fb318b0a36f180
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Dana Kutenicsova [Mon, 30 Jun 2014 19:22:34 +0000 (21:22 +0200)]
BUG-1199 : fixed NPE, when no LSPA attributes are advertised in Pcrpt.
Change-Id: I0cdf6f17b3aca95b6dfac482ba0c6c031e844696
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 24 Jun 2014 08:10:29 +0000 (10:10 +0200)]
Bug-1180: Segment routing extension configuration
-parsers extension configuration and session proposal factory configuration
-added configuration yang file
-junit tests
-sample initial configuration xml file
Change-Id: I1535fd9d6a5eebf95e0a94abc42fd8931c03f702
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 30 Jun 2014 09:26:51 +0000 (11:26 +0200)]
Fixed failing integration tests.
-removed removed rollback capability
Change-Id: If7836296fa25d24ef3f6a630ff4463fe7bd745f0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Sun, 29 Jun 2014 10:43:55 +0000 (10:43 +0000)]
Merge "Fixed NPE when serializing Bandwidth object."
Dana Kutenicsova [Sat, 28 Jun 2014 21:36:14 +0000 (23:36 +0200)]
Fixed NPE when serializing Bandwidth object.
Change-Id: I54a94bce8f0227ee9c3e437457b5a430a75ad748
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Sat, 28 Jun 2014 15:39:33 +0000 (15:39 +0000)]
Merge "Bug-1180: Segment routing message parsers/serilizers"
Robert Varga [Sat, 28 Jun 2014 15:31:49 +0000 (15:31 +0000)]
Merge "Bug-1180: Segment Routing parsers/serializers"
Dana Kutenicsova [Fri, 27 Jun 2014 08:55:26 +0000 (08:55 +0000)]
Merge "Fixed vendor specific tlv's payload parser/serializer"
Robert Varga [Thu, 26 Jun 2014 14:20:49 +0000 (14:20 +0000)]
Merge "BUG-1202 : PCEP:implemented make-before-break"
Robert Varga [Thu, 26 Jun 2014 14:17:18 +0000 (14:17 +0000)]
Merge "BUG-612 : defensive parser for LSPA"
Dana Kutenicsova [Thu, 26 Jun 2014 12:06:20 +0000 (14:06 +0200)]
BUG-1202 : PCEP:implemented make-before-break
Change-Id: Id60370b13feeec2fd95118978f0c42b7aa4a781b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 24 Jun 2014 08:02:27 +0000 (10:02 +0200)]
Bug-1180: Segment routing message parsers/serilizers
-added Segment Routing messages parsers/serializers
-extends stateful07 message parsers and PcRepMessage parser
-junit tests
-added parsers/serializers activator
Change-Id: I531b36cd0fc48a30fbfbe8b596a1faa0f1945fb0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 24 Jun 2014 07:31:32 +0000 (09:31 +0200)]
Bug-1180: Segment Routing parsers/serializers
-modified segment-routing yang model:
-message's ero subobject type is augmented with sr-ero subobject
-added parser/serializer for sr-ero subobject + junit tests
-added object, subobject parsers/serializers to the SegmentRoutingActivator
-fixed extended Srp and RP object serializers to handle all PST Tlv augmentations
Change-Id: Ie0241331572b5cd6a1ee6e4cd9ca1778ee445baa
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Thu, 26 Jun 2014 12:32:29 +0000 (12:32 +0000)]
Merge "PCEPReplyMessageParser fix - separate reply's serialization"
Robert Varga [Thu, 26 Jun 2014 12:30:53 +0000 (12:30 +0000)]
Merge "Fixed stateful07 message parsers/serializers"
Dana Kutenicsova [Thu, 26 Jun 2014 12:07:41 +0000 (14:07 +0200)]
BUG-612 : defensive parser for LSPA
Change-Id: If6cec792bb995c4a6d44709b3755616c27316b2c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Thu, 26 Jun 2014 11:35:48 +0000 (13:35 +0200)]
Fixed vendor specific tlv's payload parser/serializer
-uses ByteBuf instead of byte array
Change-Id: I2542b1b8bb665628bb0b1d06528eae76d45915d7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Wed, 25 Jun 2014 16:28:24 +0000 (18:28 +0200)]
Added missing dependency to integration tests.
Change-Id: Idd703ff2b10afbb8e9c26954d0224d2a0a3a4034
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Wed, 25 Jun 2014 16:00:59 +0000 (16:00 +0000)]
Merge "CapabilitySerializer and ParameterSerializer use ByteBuf instead of byte[]"
Robert Varga [Wed, 25 Jun 2014 15:59:17 +0000 (15:59 +0000)]
Merge "Parameter registry uses ByteBuf instead of byte[] - ParameterSerializer uses ByteBuf instead of byte[] - ParameterUtil uses ByteBuf instead of byte[]"
Robert Varga [Wed, 25 Jun 2014 15:55:31 +0000 (15:55 +0000)]
Merge "Bug 611 - MessageUtil uses ByteBuf instead of byte[]"
Robert Varga [Wed, 25 Jun 2014 15:54:22 +0000 (15:54 +0000)]
Merge "BUG 611 - MPReach/Unreach uses serializers from NlriRegistry for linkstate originated attributes"
Milos Fabian [Wed, 25 Jun 2014 11:02:06 +0000 (13:02 +0200)]
Bug 1244: Fixed BasePCEPSessionProposalFactory
-keepalive is set to Open Message, if it's value is configured to zero
-if keepalive is 0, deadtimer should also be set to 0
Change-Id: Ib1ae89d8b0726b91cbd33d483c5fb6373f787d64
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 23 Jun 2014 05:36:12 +0000 (07:36 +0200)]
PCEPReplyMessageParser fix - separate reply's serialization
Change-Id: Ie6a8968943f8e6708c58e1359bc34a7650b8c861
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Martin Bobak [Thu, 12 Jun 2014 14:21:40 +0000 (16:21 +0200)]
CapabilitySerializer and ParameterSerializer use ByteBuf instead of byte[]
Change-Id: I5a8889e1234399ded307528d5b763714251b0994
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 12 Jun 2014 13:30:30 +0000 (15:30 +0200)]
Parameter registry uses ByteBuf instead of byte[]
- ParameterSerializer uses ByteBuf instead of byte[]
- ParameterUtil uses ByteBuf instead of byte[]
Change-Id: Ie8dfe69a7ba80249c5fe733103432ca5af63c9c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Thu, 12 Jun 2014 12:06:33 +0000 (14:06 +0200)]
Bug 611 - MessageUtil uses ByteBuf instead of byte[]
Change-Id: I73fbc68ec899d362fe9a74fa2e1db97be535f17c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Wed, 4 Jun 2014 14:12:24 +0000 (16:12 +0200)]
BUG 611 - MPReach/Unreach uses serializers from NlriRegistry for linkstate originated attributes
Change-Id: I97035a640d0f757411080d1b00f586d2e04cc94c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Milos Fabian [Tue, 24 Jun 2014 11:37:13 +0000 (13:37 +0200)]
Bug-1146: Stateful02TopologyProvider#updateLsp - check ERO in input arguments
Change-Id: Idb36f2a895636f65fc6e770563bd2047fa3ede13
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 24 Jun 2014 11:12:32 +0000 (13:12 +0200)]
Bug-1144: Stateful02TopologySessionListener#updateLsp - Changed preconditions check
Change-Id: I92fffecf2318656aaa69cff7d7aad7f1b29b92ea
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 23 Jun 2014 05:33:21 +0000 (07:33 +0200)]
Fixed stateful07 message parsers/serializers
-fixed error handling of mandatory objects in message parser:
-i.e. if PCRpt Message's report lacks mandatory object,
the report is not parsed - error message is created and
continues parising of remaining reports.
-ERO object is mandatory
-removed final modifiers and changed access modifiers:
-parser classes could be easier extended
Change-Id: Ibb09d1301128d34ef22fbe736998a70bbbfcc01e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 23 Jun 2014 05:34:17 +0000 (07:34 +0200)]
Bug-1180: Added segment-routing errors.
-"Non-identical ERO subobject" and "Bad label value"
ref.:https://tools.ietf.org/html/draft-sivabalan-pce-segment-routing-02#section-9.2
Change-Id: I64c6a79de1367e34d826834bfc7a0fe623413754
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 24 Jun 2014 05:07:33 +0000 (07:07 +0200)]
BUG-1233: fix thread safety
Writing the shared buffer is subject to races, as concurrent
serializeMessage() invocation may see the indices shifted. Correct this
by acquiding a slice() of the buffer. Also renames the static fields to
eliminate sonar warnings.
Change-Id: Ia42668e1645f6179ef122c0ffe3b831be16b42f4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 23 Jun 2014 19:49:39 +0000 (19:49 +0000)]
Merge "BUG-1233 : KAs not encoded properly - fix: reset reader index after each reading"
Dana Kutenicsova [Mon, 23 Jun 2014 19:12:42 +0000 (21:12 +0200)]
BUG-1233 : KAs not encoded properly
- fix: reset reader index after each reading
Change-Id: Ibf51d1b06ea176fb57c95d83f8c881e14d34cc42
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Tue, 10 Jun 2014 06:18:45 +0000 (08:18 +0200)]
Moved Ipv4Util and Ipv6Util from concepts to util
-added new functionality to the Ipv4Util/Ipv6Util
-read from ByteBuf buffer and convert bytes to Ipv4/Ipv6 address
Change-Id: I30ca7ab5d2dcaba7f4ccaa12dd94382c77f738da
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 20:51:31 +0000 (20:51 +0000)]
Merge "Bug 611 - NlriReg supports serialization"
Martin Bobak [Wed, 4 Jun 2014 14:11:17 +0000 (16:11 +0200)]
Bug 611 - NlriReg supports serialization
Change-Id: Iba038fcf2d139cb32e1ad2192bb7a1f885604f4c
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 11:40:04 +0000 (13:40 +0200)]
BUG-612 : switched PCEP label serializers to ByteBuf
Change-Id: I9d017439eecd6f7b52ef273ac04aca2ee4a5a22c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Martin Bobak [Thu, 22 May 2014 07:46:18 +0000 (09:46 +0200)]
Bug 611 - linkstate path attribute serializer added
Change-Id: I6bf9ee966b1171935ab7ecc1401641bb9d238bd5
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 18:12:40 +0000 (20:12 +0200)]
Fixed incorrect parsinf og IGP bits.
Change-Id: Ibafda976fe07ba6fdabd0a124f3febf2a7f13098
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 22 Jun 2014 17:00:51 +0000 (19:00 +0200)]
Fixed length of LINK_PROTECTION_TYPE.
BGP parses incorrectly parsed one-byte value of this field.
Correct length of this field is 2B.
Change-Id: I272aad323dc7e7d26cfa89d368028a4bbce9dcae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 10:21:08 +0000 (12:21 +0200)]
BUG-612 : switched PCEP XRO subobject serializers to ByteBuf
Change-Id: Ibc07ffa75cb7c38f870f40d92e45b35a9700d59a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 17 Jun 2014 09:42:52 +0000 (11:42 +0200)]
BUG-612 : switched PCEP RRO subobject serializers to ByteBuf
Change-Id: Ic4cdb21ea5f4bbaf7e98bf13c10984b1b6690809
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>