git.opendaylight Code Review

Updated git submodules

Project: releng/builder master 682fb66058b5e99f91d545d836f83389d55337eb

Auto Update CSIT Jobs to run

Change-Id: Ic30882992e6b420053f5d50d1dd04388502d994f
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Updated git submodules

Project: releng/builder master df3dfefde6380e704e818a95ba9275faaad5d5bb

Merge "Nitrogen branch cutting update"

Nitrogen branch cutting update

Change-Id: Ie6a57233db9797b0e9d80845037bf32ecbb2adc0
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 802e95903a5c27ac1905f881f266fe35e7f0b966

Nitrogen branch cutting update

Change-Id: I892f6163e161cbdd79b1f11ea10c984a3755c16f
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: ovsdb stable/boron c23fdccdaa7e95a57cc6072bf0ca4d2df4a6c274

Bug 7779: Adding try-catch in hwvtep transactions.

Adding Try-Catch in TransactCommandAggregator
and HwvtepOperationalCommandAggregator , so no single failure
will cause us to stop processing other commands.

Catching specific exceptions instead of a generic Exception.

Change-Id: I8e552119e402de93a1c37cf87397451583f02294
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Updated git submodules

Project: integration/test master 5efff13569fb8af72a5fa15d9296213e53a97fa7

VTN - Additional Debug Dumps

The VTN 3node jobs have been failing for a shile now. These additional
debug dumps should help identify the root cause.

Change-Id: I8851462449aa75bb554eef226cdc65823cf55990
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Updated git submodules

Project: integration/test master 8ef79caa1152766500398b18adbbe74e6db8662a

Implementation of HTTP IoTDM client python lib

New python lib uses abstract classes representing
communication channels and transfered data. This way
it is allowed to re-use the same keywords or suites for
testing of IoTDM communication using multiple protocols

Change-Id: I4582daac256c25d3860dd99d30fcdaa4f43d2f20
Signed-off-by: Tomas Janciga <tjanciga@cisco.com>

Updated git submodules

Project: integration/test master 5de590f771af08eef27f3cf60cabdfc59f297c41

Use 8181 for restconf port in aaa csit

Change-Id: I725294d9132bbe3c6e0bc7e94bbc0b5fa111a83e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master 67a1e272f9034acffdc283707b72b6af7cf3dd4f

Merge "Branch cut scripts for ODL"

Branch cut scripts for ODL

This script can be used for branch cutting tasks needed to be
performed during various milestones.

Usage:

./branch_cutter.sh -n Nitrogen -c Carbon -p Boron

Jira: https://jira.linuxfoundation.org/browse/RELENG-4
Change-Id: I05ba4f52de4d717cba5d46d428f1e9686709e359
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master fdfdf9a3820b1599b777ed675adb09cb46cd77b3

Merge "Handle bundle-vars directly in dist-compare script"

Handle bundle-vars directly in dist-compare script

instead of using the get-bundle-vars script as a build step
which can fail when there is really no "last" build (like
when cutting a new branch) we can figure out those variables
directly in the compare-distribution script which is using
set +e. If there is any trouble with the compare-distribution
script, we don't abort the build.

Change-Id: I8442149ae4c0f3ddb3f69b73dbac5df3c948a4b8
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master e5ce689a9c081707253f634d61489cd8b41b3134

Merge "Add Sandbox usage doc to multipatch job"

Add Sandbox usage doc to multipatch job

Change-Id: I6f963efb8ae3b6c71def62faa20329b8f4429304
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master dcec5286229e7f314b752e222a98d72c9fa0d297

Merge "Remove IT trigger since tests are no longer valid"

Remove IT trigger since tests are no longer valid

Change-Id: I6b0d5e54af9f25586a352a95eb801fae0e72acf0
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: releng/builder master 3bd9ebb49a35331d940bb837bae8fd9d5c8040b8

Merge "Fix hypervisor count for all-in-one devstack"

Fix hypervisor count for all-in-one devstack

Change-Id: If1bf653c2a2981a5395e52660d83c19948781990
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master b5be33b878d75af8df189ee55974405b9a08dff1

Merge "Replace `` cmd substitution with $()"

Replace `` cmd substitution with $()

Change-Id: If95c628f524b25adcc6260951bd93c794eb0fae3
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: integration/test master 6d23c41037ccc753ccf2cb21528cec1509364e11

Add basic Yangman robot test

- add Yangman basic test
- add Dlux testing keywords
- add Yangman testing keywords
- add Yangman gui variables
- add Yangman testplan
- browser chrome

Change-Id: Ide1e593a972887df942a30dfbca115989961c9ee
Signed-off-by: Daša Šimková <dasa.simkova@pantheon.tech>
Signed-off-by: Daša Šimková <dasa.simkova@pantheon.sk>
Signed-off-by: Dasa Simkova -X (dsimkova - PANTHEON TECHNOLOGIES at Cisco) <dsimkova@cisco.com>

Updated git submodules

Project: releng/builder master 08c409cd288c13f6796d88e537c76a2b529a764b

Merge "Mention OS_CLOUD as a variable is significant"

Mention OS_CLOUD as a variable is significant

This variable matters in the context of the openstack client cli
command as it takes it as input.

Change-Id: I1f3805825dbbef82f3c7d3eb619d3b8763725c8d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: releng/builder master b44aaa0cfbb05c8250c06d9dac16085f1e9ac732

Merge "Add boolean parameter to run test after build"

Add boolean parameter to run test after build

By default multiplatch builds all patches but does not
run test unless new parameter RUNTEST is set to true.

Also fix variable name in multipatch script.

Change-Id: I75407b0508395db76387dd44b5c4cff73ed8648d
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Updated git submodules

Project: releng/builder master 8ea99dd210066427b9d1faa55cac7378aaeb3051

Auto Update CSIT Jobs to run

Change-Id: I0122f4e9979adb51575282f15741828441494853
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Updated git submodules

Project: ovsdb stable/boron 2d7190af186557ab6d8bd03338497fcdfa056674

Fix Checkstyle "Redundant Modifier: Redundant 'final' modifier."

Change-Id: I07c5ac0c61594fc9b2e4faa1d0d028d75348df53
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit c877d44ffa2815892907329c740095df46c56929)

Updated git submodules

Project: ovsdb stable/boron 6726074e646b7a102007544ade6a565a3b1303f4

Fix NPE in OvsdbConnectionService updateConfigParameter

seen in SingleFeatureTest (SFT) running under Karaf 4

maybe under Karaf 3 this was never called with null, but under 4 it is

Change-Id: I886ccf99ef4be85b6e103d69fa457ec4a0dab4d9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 13b999eb5bc1e65442c7ef3d22a1f90a58d98e62)

Updated git submodules

Project: ovsdb stable/boron 8c8e2512d1c74de91894b5d7323126ee7382cbb4

Bug 8055: remove unnecessary type parameters

Change-Id: I8baabd6823a1876c84db323e56c120c8e2474629
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 8055: remove all unused imports

Change-Id: I6eef86c1c20b75c3584c702d16c8a01c22358b7a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: ovsdb stable/boron 8b259dccc319ba3b0be1f708e90ce971ef809faf

Bug 8055: various performance issues

* Use Collections.singletonList() instead of Arrays.asList() with a
single argument.
* Avoid calling toString() on String objects.
* Avoid constructing new Strings with String constants.
* Avoid String concatenation in StringBuffer.append() calls.

Change-Id: I9e1c338b89bc7e914092a388ccb6b3022c9992ff
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: ovsdb stable/boron 7520449b84e80e2708d366b841932c5fdd2c96ae

Bug 8055: remove unnecessary type arguments

Change-Id: Ifa4d36624aeea12de43744460ba0bf43b2094f1c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: ovsdb stable/boron a2dc83e2f71270a0e4751ca8f5d587cd352cb22b

Bug 8055: remove redundant array creation

Change-Id: I876410c5ac9fecaab94cecd2fb37f44bd115762b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: ovsdb stable/boron cf13e304e501347cd635a70cec39f0ff62ae0e2d

Bug 8055: remove unnecessary type casts

Change-Id: I02000e8afff1f7748a959368742d9eb8f7fd518e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: ovsdb stable/boron 45e38dad23239a319e837d4c8c8eac3d44c71984

Bug 8055: simplify a couple of streams

Change-Id: I3cd16e6a2f2c907b96856d91c12997d98cbe9831
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 8055: use method references instead of lambdas

Change-Id: I34e0108612abe51bbf9fe19e4cf5cdbe41592cef
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 8055: use Java 8 predicates instead of Guava

Change-Id: I724a807f78c4041964e614f332cc811ebd20e60f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 8055: use lambdas instead of anonymous classes

Change-Id: I72b437b9e225f022fa3c55492f6b0f9751450dea
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 3439e07cad0286bdbc88737db2fbd2269e79329d)

Updated git submodules

Project: releng/builder master e8a56411730412990a7ad3ef97bcee5643d981a9

Nitrogen branch cutting

Change-Id: I1cb71b4eda04fcfd1751b65464f695497ad540e5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 12a5312feaeaba3a65c3dcbcfd9a3adc285d474b

Merge "Fix csit-update job for nitrogen"

Fix csit-update job for nitrogen

Change-Id: I15753159ab0a234cbe4bd9ffcd4fbe2276fc0821
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 14764502cbb964eb0cbd2d36ba80b11654374bd1

Merge "Remove aaa features that do not exist anymore"

Remove aaa features that do not exist anymore

Change-Id: I3401c0e52dc0919e5db70bf8f53da3c5d648ad14
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master fc218e629fa473012b47c0c80a8707724d810caa

Add Nitrogen to csit-list update

Change-Id: Ib9e34db2631b5f2cf4d195b3fc7f8130dc0832d7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: integration/test master 10e2795ff58e2b9765c6dd07258a3d2c78c18534

Jolokia request with TLS/HTTPS

This adds a new case to ensure TLS with client authentication works
with Jolokia requests.

Change-Id: Id73d1e108c8557ee16f69209e3725163fb187b67
Signed-off-by: Miguel Angel Munoz Gonzalez <miguel.angel.munoz.gonzalez@ericsson.com>

Merge "Adding Boron-SR3 Release Notes" into stable/boron

Updated git submodules

Project: releng/builder master ab12dc93943081aa364584ba259abfad00b18d92

Merge "Add a job for netvirt SFC CSIT"

Add a job for netvirt SFC CSIT

Change-Id: Ib7d74aca432a56afac898461c1adbdecf8fd9164
Signed-off-by: Alon Kochba <alonko@hpe.com>

Updated git submodules

Project: integration/test master fe30c71d4c1c824b4939e9b05d378228c7a1e76b

Add CSIT for openstack-sfc

releng/builder patch: https://git.opendaylight.org/gerrit/#/c/54312

Change-Id: I048b77d9ab5c841f027dcba30995ce83bf2b2615
Signed-off-by: Alon Kochba <alonko@hpe.com>

Adding Boron-SR3 Release Notes

Change-Id: I914bc20b7236490465c4de149002f403f6674b3f
Signed-off-by: A H <an.ho@huawei.com>

Updated git submodules

Project: integration/test master f0c5a462413522561eacfcad3cf1384676853bce

Modify the csit job failure

Change-Id: I8404c4deca6d0e85c932700fb97f191b6b8458d7
Signed-off-by: Quan Xiong <xiong.quan@zte.com.cn>

Updated git submodules

Project: integration/test master 59147dee8135554ea5d847b7432fa6cd38f778a6

Add csit tests for hairpinning.

Test that pings from VM1 with floating IP to VM2 floating IP.
The test make sure there are no router hops in the way (ttl=1).

Change-Id: I8254c4ebd3fdd1ceb052b667896f3622c3f3e235
Signed-off-by: yair <yair.zinger@hpe.com>

Updated git submodules

Project: releng/builder master 06598bcca853a550e17804692f02abdda741f8e2

Merge "Use PUBLIC_BRIDGE instead of hardcoded br-physnet1"

Use PUBLIC_BRIDGE instead of hardcoded br-physnet1

Change-Id: Ic3bb67d1f4dc7b77e0cd79c95cebaa9aacbb9244
Signed-off-by: Alon Kochba <alonko@hpe.com>

Updated git submodules

Project: releng/builder master 69fa4e5a9a0d4bd1b581ad16d49a3f0817354a5d

Sort environment variables

This makes it easier for humans to locate a particular variable,
but it messes up multi-line values.

Change-Id: I2cdf6b507e5f6829e11cebab7f7e402571464d41
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Updated git submodules

Project: integration/test master f5c738101079d8061d7beaee1a4e4fc08e7a86c5

Bug 8149: Increase timeout for netconf restperf

The previous increase was too tight.

Change-Id: Ie46bb3589342bb501375658803fccc934441f9bd
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Updated git submodules

Project: releng/builder master 99e11609e3fdbcdeebcff293b3b8e8788c2af6b8

Merge "Update Ubuntu mininet image and labels"

Update Ubuntu mininet image and labels

We are currently supporting the following:
- Ubuntu1404 with mininet default
- Ubuntu1604 with mininet-ovs-2.5

Change-Id: I550cbf436755ac2a9a2c1e104c6169383b5a6354
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 300fc94c842e75af11a85e7be4cc23b7209811e6

Merge "Use multi-threaded xz compression"

Use multi-threaded xz compression

Compressing memory dumps can take a long time, hence it is best
to allow xz to select the number of workers based on number of
available cores.

Change-Id: I8ef96b72c28316b3b84a8784d4ab4c4d48dd0f15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Updated git submodules

Project: releng/builder master c2d89f86cd3b9d9fbe5516c27e8fa20a17561b2e

Update YAML with 6wind guagga images

Ubuntu 16.04 and Centos 7 images with 6Wind
quagga have been created and tested on sandbox.
Adding these images in the yaml so that they can
be used for testing router functionality anytime.

Change-Id: I4b6706bf80da99c34c85ccc1866034b4725d7ecc
Signed-off-by: rahul.agarwal <rahul.agarwal3@tcs.com>

Updated git submodules

Project: odlparent stable/boron 195c5be2b917364ae4b33ff2e70ec55a73a7eb37

Bump netty to 4.0.45

http://netty.io/news/2017/03/10/4-0-45-Final-4-1-9-Final.html

Change-Id: I590b5aa96b8b6271186a6506493ef23e23166dab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Updated git submodules

Project: netconf stable/boron 578f8958c8a9a0a65b4289105c4507aeb27d2749

Merge "Bug: 8037 YANG Patch using "replace" instead of "merge"" into stable/boron

Bug: 8037 YANG Patch using "replace" instead of "merge"

Change-Id: Ic53b0649b52529e9bf244b82d85582d343aa95e9
Signed-off-by: Wenbo Hu <huwenbo1988@gmail.com>
(cherry picked from commit c82fa3134d0f582f7e49f5b6cfe8e50a02d77f19)

Updated git submodules

Project: odlparent stable/boron 0bb105904f2f882e1a739aa1240732ec96186788

Add cli property to un-skip git-commit-id skip flag

Change-Id: I88340ab60e3e922fd3c79fe01f6b60471eec55e7
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit e0bd848808daca0a76c49eff2b096ef7a1e14a68)

Updated git submodules

Project: netvirt stable/boron 1e3242f767b5631c531ca1eea5b709081594ae5f

Bug 8023 Handling ELAN remote DMAC programming correctly

* Fixing the issue related to synchronization key for programming remote
dmac entry
* code cleanup while handling tunnel add DCN
* added required info logs to collect the logs to know about possible
races. Will get it removed once this issue is completely solved.

Change-Id: I82d3cc1a44696d9dfae531fac818295ba75d28a9
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>

Updated git submodules

Project: netconf stable/boron 73f8a8f2ac2d2602d9a0e9422bc61705ff6c216f

Merge "Bug 5581: Optimize subtree filtering" into stable/boron

Bug 5581: Optimize subtree filtering

If single list entry with key is specified in filter,
only that specific entry is read from datastore, thus
filtering has smaller input to process.

Change-Id: Iae46e3c25067d35f6bcacc40d0997d008da8fb29
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>

Updated git submodules

Project: netconf stable/boron 6bd875a5a1afdea809bb7847aca4aa839e60daec

Merge "Bug 7812: NPE when NetconfDeviceSalProvider.close" into stable/boron

Bug 7812: NPE when NetconfDeviceSalProvider.close

Clustered connector close logic could be called twice on master.
Add boolean guard field to prevent this.

Add null check to netconf device sal provider close method
to prevent NPE.

Change-Id: Ib84be162826726169fb254a933781bb39dce604a
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>

Updated git submodules

Project: netconf stable/boron 6143889e3ac88c0b19e4da61a2ddf41b42389268

Bug 8072: Fix decoding of URLs with external identityref

Mount point schema (rather than global) should be used
to decode identitirefs defined in external modules.

Change-Id: I51f135fe0cd5ceee39d5a2e6f0fc62631cf4437b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>

Updated git submodules

Project: netconf stable/boron 751b3f739cb75bef573f0c9390a84800f5e4dcce

Fix LibraryModulesSchemasTest failure

LibraryModulesSchemasTest#testCreateInvalidModulesEntries() tests
filtering invalid modules entries during resolving
ietf-netconf-yang-library/modules-state/modules node.

Resolution goes as follows. We parse xml document containing
ietf-netconf-yang-library/modules-state retrieved from the device with
help of DomToNormalizedNodeParserFactory. Then we filter invalid modules
entries from the parsed modules list node. Module entry is considered
invalid if its revision or schema url are invalid.

However, change in yangtools
https://git.opendaylight.org/gerrit/#/c/53553 causes that parsing
invalid revision will fail whole parsing xml process with unchecked
exception.

For now, do not test modules with bad revision. This is intended just as
a temporary solution. We will also need to slightly change our
ietf-netconf-yang-library/modules-state/modules node resolution logic.
Opened BUG 8071 to track that.

Change-Id: If12ae8d7bf94528088aac81e78b24058c5152283
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
(cherry picked from commit 95452d33026b37907b541dc47006426e3b3e35ad)

Updated git submodules

Project: releng/builder master dda3174f7cc487b4c2e41582c74db9556226c452

Merge "Bump Boron release tag for next release"

Bump Boron release tag for next release

Change-Id: Ic2af08da4f4a368b769e38cb3f74af0af821c3eb
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 33fe59301f834db5d8ffbb39fdb342008e5a873f

Merge "Add 6Wind quagga to ubuntu16.04 and centos7 images"

Add 6Wind quagga to ubuntu16.04 and centos7 images

6Wind Quagga router is Open Sourced and can be compiled in two modes
(namely 'l3vpn mode' and 'evpn mode) resulting in separate binaries
required to be installed on minion images. Both binaries are required
for Boron & Carbon DC-Gateway testing. L3VPN Quagga binary is needed
for Boron and EVPN Quagga binary is required for Carbon testing.

- https://lists.opendaylight.org/pipermail/integration-dev/
2017-March/009376.html

Change-Id: Ibfe5b941ea2f31731ad10fbafa54daeb66f18878
Signed-off-by: rahul.agarwal <rahul.agarwal3@tcs.com>
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: netvirt stable/boron a6d99b0a698e79e59cb5faeda6f721088f5cce12

Bug 7606: Fix for missing table 110 flow in OVS 2.4 after VM live migration

Problem:
After live-migration of VM is completed, table 110 flow for migrated
instance missing in all nodes.

Fix:
* Skipped UPDATE event of Source OVS when VM is migrated.
* Skipped the cache update from UPDATE event.

Change-Id: Iddc15a38fc8c96e998a14622217957dcabdff438
Signed-off-by: arthi.b <arthi.b@hcl.com>

Updated git submodules

Project: netvirt stable/boron 8e23ffcb123b95252893444faac2ab7b11050852

Bug 7778: VM's FIP are not able communicate to each other
in external network provider

Problem: NORMAL instruction support need to be removed
from legacy netvirt

Soultion: Added a separate flow for broadcast, multicast, unicast of
internal to external communication

Change-Id: Ifc7dec023511395b6a7d2f671b8350886ff11297
Signed-off-by: vinoth <m.vinoth@hcl.com>

Updated git submodules

Project: netvirt stable/boron a3a54f227737f1b542bce6811faea7d9487cd1a7

Bug 8165 - Learnt IP route does not reappear on DC-GW after OVSRestart

On OVS Restart, a learnt IP will have to be deleted by Liveness
Monitor, and then re-learnt once the OVS comes up.
But this IP was not learned again.

Cyclic events were getting spawned while processing removal of
Learnt IPs. This was causing deletion of re-learnt IPs.

Change-Id: I17b87fef05de8d3eb51f2a4720df98ff647e8937
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>

Updated git submodules

Project: netvirt stable/boron 31f21ba76b7223acaca57b9d5acb09de2c4fb306

Bug 7922 - Use counter to keep track of duplicate flow entries

Problem: Single flow entry associated with two more security rules
incorrectly deleted when one of the security rule is deleted.

Fix: Use counter to keeps track of duplicate security rules
in a particular VM. The counter is maintained in the flow cookie.
When writing a security flow, the flow counter is incremented
if the flow already exists, otherwise the flow cookie is set to '1'.
When removing a security flow, if the counter value is '1',
the flow is removed from the node, otherwise the flow counter is
decremented.

This changeset also:
- reversed some previous partial fixes for the same problem.
- refactor common Acl Service to AbstractAclService
- reformat/clean up code

Change-Id: Idfec36fa47c88db76a8382f8fcbc65c4100e9e6e
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>

Updated git submodules

Project: netvirt stable/boron 99a36e584168ac8bbf9e2b05925a16809a6bd82e

Bug 7939 - Remote flows missing in Table 21

Due to racing between createRemoteFibEntry() invocations
from multiple DJCs of different keys within VRFEntryListener,
when two threads try to create the same remote flow, it lands
up as OptimisticLockFailedException and that results in none
of these threads write showing up in the flow-inventory.

With this patch we donot eliminate the race, but rather attempt
to reduce the invocations to createRemoteFibEntry there reducing
the occurrence of the problem.

Changing Keys in VRFEntryListener requires more careful thought
as these keys not only protect DS writes but also bring in
batching at scale. And so that part has to be addressed in a
different review.

Change-Id: I7bf80742980002b471520fc3e50ed1c28baa1945
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Updated git submodules

Project: netvirt stable/boron 4ed33ac63f597a999af34b95f20ce483a40ae0b6

Bug 7939, 7938, 7968, 7997: Potential fix for the four L3VPN bugs

While creating LocalFibEntry, localDpnId list is being returned empty
leading to local FIB entry not getting installed. The fix ensures we log
an error statement in case it happens

Change-Id: I95589523079f9d990b5e61d96b71b2c6d1c133e1
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>

Updated git submodules

Project: netvirt stable/boron 770c08d6d48e59d9a2a4da3fc2b2407d36f4fbab

Bug 7939: VpnService Suite and Tempest failures

This fix is an add-on patch for the below review

https://git.opendaylight.org/gerrit/#/c/53772/

and is in a direction to solve the OperTxn gets
failing when configTxn changes are triggered.

Also we fix here the routerInterface VrfEntry
management such that when we clearly know its a
router-interface VRFEntry, we donot do any further
processing than what is required for the same.

Change-Id: I8efc5c41f26e9e6dd04c8638b2cfaa94a2050384
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Updated git submodules

Project: netvirt stable/boron 9521be701bab521e742e1d26d5ebed194b0639f5

Bug 8019: when the neutron port acting as gateway is deleted, invisible ip
is not removed from FIB

When VpnInterface has a secondary adjacency like invisible ip,
if tunnel EP is deleted , VpnInterface Op DS is updated with
empty nexthoplist. During this time , invisible ip goes missing from
VpnInterface Op DS due to MDSAL.syncwrite() being done in
updateVpnInterfaceOnTepDelete.

Another fix being done here is , invisible ip FIB entry is
updated with empty nexthop and route is withdrawn/advertized to BGP.

Change-Id: If98991940976defe16a7a988aa3071d87693f8e9
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>

Updated git submodules

Project: netvirt stable/boron b7d79b3650489979d0fc75726efa453b3c2f212a

Bug 7816: NullPointerException while create a router in external network provider

* Problem:  Patch port for br-ex is not updated with port name = "patch-ex" into
             localcache during stack up for follower node, thus NullpointerException.
* Solution: Patch port name is constructed by passing external bridge name and
             as it was constructed on fly in getPatchPortName() in VLANProvider.java,
             patch port name entry was not stored in 'patchPortNames' map.
             However, 'patchPortNames' map will have default value as "patch-ext" for
             patch port name.Default value will be used
             when 'ovsdb.l3.fwd.enabled=yes' in custom properties file.

Change-Id: I9e446529c1962b41c9e97644d59a35dea4606740
Signed-off-by: hari.pr <hari.pr@hcl.com>

Updated git submodules

Project: netvirt stable/boron d6b89205460ee9bf2c7bad9e6fbc80a05708e615

Fix ACL IPv6 flows to match on ipv6_src/ipv6_dst for remote SG

Conflicts:
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java

Change-Id: Ia8573eef9c6fa27556b3c1446914e4f6f4e8d4c7
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit cc356ab31fb8bf9d2857491ee897b1c2b63ac773)

Updated git submodules

Project: netvirt stable/boron 72359b80a0c2010872f80779691f20744cba8c65

Bug 7952: ACLService to treat Ethertype=IPv6 and Protocol=icmp as a request for ICMPv6

In Neutron, "Protocol=icmp" is allowed to be configured with "Ethertype=IPv6"
for backward compatibility reasons. When such a rule is configured, Neutron
IPTables Firewall Driver (i.e., reference implementation) treats this as a
request for ICMPv6 and configures a rule accordingly. This patch implements
the same thing in ACLService. Please refer to the bug report for more details.

Conflicts:
vpnservice/aclservice/impl/src/main/java/org/opendaylight/netvirt/aclservice/utils/AclServiceOFFlowBuilder.java

Change-Id: Id87c0eda599da4bc3669327bd36659b83d9e108b
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit 73af65fcca5b699fc5c6e859c49eb386363fe4ea)

Updated git submodules

Project: netvirt stable/boron 96117b5185cac34c166afed2383c264dfcc20a2c

Bug 7979: Fix issue where VM is unable to acquire address during IPv6 tests

Tempest IPv6 Scenario tests validate usecases like IPAM, multi_prefix,
dualnetworks etc. While running IPv6 tempest scenario tests, we have
noticed some exceptions, because of which the test-cases are failing.
This patch fixes those exceptions in the file ExternalRoutersListener,
by skipping the IPv6 subnets. The necessary implementation in
ExternalRoutersListener will be added as part of IPv6 external
connectivity blueprint.

Conflicts:
natservice/natservice-impl/src/main/java/org/opendaylight/netvirt/natservice/internal/ExternalRoutersListener.java

Change-Id: Idea66303e1855d6ffaf2e7a73f0d04af5d66be89
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
(cherry picked from commit d2d874a79f1b8893f607fc143fe9ee47b41fba7b)

Updated git submodules

Project: netvirt stable/boron 261ad33a4c51e9e6f371db878173b45341b863f2

Bug 7913: QosInterfaceStateChangeListener IllegalArgumentException

Fixed it by avoiding IllegalArgumentException through regexp check.

Cherry picked from commit 3b317e85ff698818e8fba1863d69fe2651685f0e
from master's c/53118, but significantly reworked, because the code
has moved.

Change-Id: I8c474eae6629a7219a524a5de3cd92e087c6e746
Signed-off-by: A Vamsikrishna <a.vamsikrishna@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
(cherry picked from commit 3b317e85ff698818e8fba1863d69fe2651685f0e)

Updated git submodules

Project: netvirt stable/boron c74e6c4e411f4274d406003216a53482788e8e20

Migrate l3vpn service docs to netvirt

Change-Id: I8686a9b127ea746ecb5bb9031bed70e9fec287d0
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit c18bf0c265f77329a958b39b8e7b6510f031236e)

Updated git submodules

Project: netvirt stable/boron 4c26089391036631cd7ecdbd7282e2636851beb5

Bug 8023: Making ELAN to use StateTunnelList listener

* Currently ELAN uses Interface state DCN for tunnel events to program
remote DMAC and BC group when VxLAN tunnel is created later. So making it
to use listen StateTunnelList
* This change would be useful when ITM supports multiple VxLAN tunnels and
avoid race conditions

Change-Id: Idce3dd3a548b95feadf43fbe2c1311c3fafdb70a
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>

Updated git submodules

Project: netvirt stable/boron d0c2e142a2082eafc85c263c0a80ec4c02b0a969

Correct several equals() bugs

Change-Id: I8f008515dc79cdd0c38e957a3917db1ce8d9ab86
Signed-off-by: Alon Kochba <alonko@hpe.com>

Updated git submodules

Project: integration/test master 9814651b8b318c1da676f3559559ec99d797024f

Add port-op-data to odl models dump

odl-l3vpn:port-op-data is useful when debugging the subnet-route
feature.

Change-Id: I225a4ef2db81a0c945747dc4f9de347d184743e9
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Updated git submodules

Project: netvirt stable/boron 7a2e0ea14f4349686501c67b049e2bbf4fb41512

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: I620b44d97c0513c38c1ca22c3be76ef31bbabeaa
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: integration/test master a69dbb8b38f972b9170ef0002d405ce2415d088a

refactor vm ip discovery to use new keyword [0]

[0] "Collect VM IP Addresses"

Change-Id: Ie75c6f84b7a2c2d6cc4976bd706b776bdbbd372c
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master 188af498c5ef575b8a067cd7c534027f8abf256f

Merge "To enable odl_l3 and l2gw feature work together"

To enable odl_l3 and l2gw feature work together

This patch will revert the temporary change done
in Gerrit Review #51460 which was when odl_l3 and
l2gw were not working together.

Change-Id: I0dfcc5adec1b516807f56e92ce5a400f200c6689
Signed-off-by: abbas <abbas.pareedkunju@tcs.com>

Updated git submodules

Project: ovsdb stable/boron 149ca8d6409175d0cdf98b7dffa3626a83d612a6

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: I14fe2c8f60ebd3c736577b3713a1e9266b302e5d
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: integration/test master fa4ecaa5bf6b3faf452b1f6ebfa8aa585e47a7b9

Add subnet-op-data to odl models dump

odl-l3vpn:subnet-op-data is useful when debugging the subnet-route
feature.

Change-Id: Ia3b28dd72aae0aca21a9328b1b7d6476f50234f9
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Updated git submodules

Project: integration/test master 3eff2e6f7b2845f08f23552d62ad6d96c4fa4218

Fix RSTcheckBear failures

not sure how these changes made it past the tox check in
the verify job, but hopefully this gets them fixed.

Change-Id: I0a4011f1f1f9823104d3f74566fb35345ebda013
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: integration/test master 1a40245159dae53192714b81e9d17fd5fe28f571

Modification due to reuse http client change

Change-Id: Ifd68584d1e9f289c6cc40b74834963cbf4738781
Signed-off-by: Ursicio Martin <Ursicio.Javier.Martin@ericsson.com>

Updated git submodules

Project: releng/builder master 97d50eefae540f210177c4da0acb38b9a73a61e3

Merge "Remove RPM changelog_date param"

Remove RPM changelog_date param

Build logic now finds automatically when not passed.

Change-Id: Iac273bbada810c21fa8323a57cf277abed4d9d44
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master b60001fddbfd16c822f9eb92672e52433ebf8337

Merge "Find RPM repo file name automatically, rm param"

Find RPM repo file name automatically, rm param

Change-Id: I5c8fdafa6cf1b084413d8b9a812a8d877bc2ab6f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master 4cf0e067fd3b4e625c357fe068a68f5e9bd7b099

Merge "Update default RPM/deb download_url params"

Update default RPM/deb download_url params

Change-Id: Ibbd2e44691b120ba13914856d4a94cde615d9ba7
Signed-off-by: Akshita Jha <zenith158@gmail.com>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master c3cdd0b6e49a76474ce1fb633d5a6eff90822342

Merge "Add controller's rpc partition and heal 24h job"

Add controller's rpc partition and heal 24h job

Change-Id: Ib29f99ce54bb2dad362d36729bf8411232e457a2
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: releng/builder master 248e184d3092301920932afe1534cad6c42a7a4d

Merge "Add controller's rpc precedence longevity job"

Add controller's rpc precedence longevity job

Change-Id: Id924923c650b79f36184afa2d405ab8417469568
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: integration/test master 3c2d6f18daea0019962ae562720e16d7caab3020

Add rpc longevity suites

Change-Id: I16302649df4f4f5e13a3e66843a9ea1069d5d215
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: netconf stable/boron 7b7e857029e1bd2eaab3bcc38fde7a4e70cb090e

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: Ic71e33faab853911061c97cde8ada0cc5f3efeee
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: aaa stable/boron e67adff929497b26d22278c55c069f3323d9ff2f

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: Ic4563f94d563bc24ca0f3065e666e8d89083314c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: odlparent stable/boron a19831be55a9ac92fc1091853d5bf66aaf4c86d7

Bumping versions by x.y.(z+1) for next dev cycle

Change-Id: I437069a8f8201f6522f5a8b01b7146fccc5face8
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: integration/test master 39731b4612d9bb04edc5e23af10252ef73e2dddb

Add system test guide to docs

Change-Id: I31d3750dc36d29e5eec8204978c51e681adcfcf8
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Updated git submodules

Project: releng/builder master 79b1d49c231c00a1e836c86ab2dba471052e31e7

Fix multiline config character for merge jobs

| is for multiline (which maven-target accepts)
> is for spaces (which is what maven job type accepts)

Change-Id: Ia47ca32146383be7a4ec9f2ac04f5f167d63a03a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: integration/test master 6b14113e016dc7e0b584024832ca2b2bf7d6eaa8

Add External Network PNF Tests

Two changes in this commit:
1. Add external network PNF test - this uses ttl=1
    to make sure PNF connectivity is not traversing any routers
    (in our case, the external gateway)

2. Change current external connectivity tests to use "internet address"
    this change is required because since the PNF commit support, pings
    originating form external gateway IP are not traversing the default
    gw rules, so this change is required in order to maintain the
    original coverage of these tests.

Depends On: https://git.opendaylight.org/gerrit/54405

Change-Id: I021c3a13b73283d844d614e06a3edb2b9d867f88
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Updated git submodules

Project: releng/builder master 84600bca134eda33e65017fe4c55b3ad3c682253

Merge "simulate extnet PNF & internet addr in br-physnet"

simulate extnet PNF & internet addr in br-physnet

Changes required to support external network PNF tests [1]

Two changes in this commit:
    1. Add external network PNF simulation to br-physnet1.
       This was done inside ip netns, to make sure packets destined to
       external gw mac with PNF IP *will not* be handled.

    2. Add external internet address simulation to br-physnet1
       This change is required to simulate traffic from external
       internet addresses (see additional explanation in [1])

This will be used in netvirt CSIT in order to test external network
PNF support, and internet address connectivity.

[1] https://git.opendaylight.org/gerrit/#/c/54317/

Change-Id: I42b148c8e3588fdedc5eb0e01c121a0a31d3c71b
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>

Updated git submodules

Project: releng/builder master a017050153c3b4c37a356968158c85dc9ac10ba5

Auto Update CSIT Jobs to run

Change-Id: I1a3ee3d1a6439cfe7dddc07eef9178d76d6a39f7
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Updated git submodules

Project: releng/builder master a9bf91949aba6d12eaea5908b2008c8a355740e2

Merge "Remove carbon from netvirt legacy csit"

Remove carbon from netvirt legacy csit

Change-Id: I8f166ded1323b3a97ce8588bb302f845912cdb0b
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master 4bf5cc13938dac12ca973b1a55c3af0209ec9223

Merge "TcpDump File addition"

TcpDump File addition

Change-Id: Ia6927362ad2386ca20184000d582a21ef4536a5b
Signed-off-by: Suvitha.balu <suvitha.balu@tcs.com>

Updated git submodules

Project: integration/test master 95bc2fd98ac1f2b204ab72b049c0bbee17d1f74f

TcpDump keyword

Change-Id: Ifb884d78081e4ec9ba9e60e2b13c15a9a5228af0
Signed-off-by: Suvitha.balu <suvitha.balu@tcs.com>

Updated git submodules

Project: integration/test master 57c7a9f1f1836106b181fe93d2cfc41c6553e50b

TLS activation methods made independent

This commit ensures that TLS activation methods, including client
authentication, can be called independently in any order.
Before this commit, they had to be called on a certain order, as they
were dependent on each other

Change-Id: Ib045f8891743969066d28144bb5684c9c5a2629f
Signed-off-by: Miguel Angel Munoz Gonzalez <miguel.angel.munoz.gonzalez@ericsson.com>

Updated git submodules

Project: integration/test master 2cb5241ce737adb194ff44807edf816bae203b66

TLS Case for Client Auth with CA Signed Certs

Change-Id: I2292fe9f3187860c544572ffacf91f03a2a23e78
Signed-off-by: Miguel Angel Munoz Gonzalez <miguel.angel.munoz.gonzalez@ericsson.com>

Updated git submodules

Project: integration/test master 16f48e64669b46c4174de1554e612a8bdce7e64a

Bug 8086: Add an analogue of netconf cluster CRUD

Change-Id: Ib2317fcd44b0bad104211f38c2672ece02a7724a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Updated git submodules

Project: integration/test master d604d2b55c1e1f54f1648b2d6c08d0582d07e502

Refactor DomRpcBroker suites

Create common resource

Change-Id: I6e806e2c3b60d334eca81318504061a813ed9bbe
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: releng/builder master 4ac0b2f1be605e3927a5a920e67059eeb9dfc65e

Override csit verify stream for bier

Change-Id: I686f2071b60dff30a97c743e92aabe7911c3ec9f
Signed-off-by: Quan Xiong <xiong.quan@zte.com.cn>

Updated git submodules

Project: integration/test master e92c92b2456ffcae67eca31eee08650834aba881

Use --router:external net-create for tempest tests

Change-Id: I3810aa29e382fdd3745bba98ab7f301ec0311ab7
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>