netconf.git
7 years agoBug 6664 - upgrade draft15 to draft16 - renaming 67/45367/4
Jakub Toth [Thu, 8 Sep 2016 08:35:25 +0000 (10:35 +0200)]
Bug 6664 - upgrade draft15 to draft16 - renaming

Change-Id: Iaaefc58f8615f8ef16ba538d23576ea852be1064
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoWrap throwable in NetconfDocumentedException for AbstractWriteTx 48/45548/2
Alexis de Talhouët [Tue, 13 Sep 2016 19:29:37 +0000 (15:29 -0400)]
Wrap throwable in NetconfDocumentedException for AbstractWriteTx

Change-Id: Ie7e70224d7505a243a428eb9cc4561a604175f5e
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMerge "Unit test for RestconfDataServiceImpl class"
Tomas Cere [Tue, 13 Sep 2016 10:15:35 +0000 (10:15 +0000)]
Merge "Unit test for RestconfDataServiceImpl class"

7 years agoMerge "Unit test for RestconfInvokeOperationsServiceImpl class"
Tomas Cere [Tue, 13 Sep 2016 10:13:42 +0000 (10:13 +0000)]
Merge "Unit test for RestconfInvokeOperationsServiceImpl class"

7 years agoMerge "Unit test for RestconfStreamsSubscriptionServiceImpl class"
Tomas Cere [Thu, 8 Sep 2016 08:40:10 +0000 (08:40 +0000)]
Merge "Unit test for RestconfStreamsSubscriptionServiceImpl class"

7 years agoUnit test for RestconfStreamsSubscriptionServiceImpl class 47/45247/4
miroslav.kovac [Tue, 6 Sep 2016 10:27:52 +0000 (12:27 +0200)]
Unit test for RestconfStreamsSubscriptionServiceImpl class

Remove redundant check of empty or null String. This will never
happen since it would fail while getting LogicalDatastoreType
or DataChangeScope.

Change-Id: I99455ddcc7c15d5c3268ed5ea92eb747b5b49f17
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoUnit test for RestconfInvokeOperationsServiceImpl class 29/45229/2
miroslav.kovac [Tue, 6 Sep 2016 13:59:00 +0000 (15:59 +0200)]
Unit test for RestconfInvokeOperationsServiceImpl class

Change-Id: I4da0bcfa6ce210412a199769e83e104be99b7e07
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoUnit test for RestconfDataServiceImpl class 67/45167/4
miroslav.kovac [Mon, 5 Sep 2016 15:06:48 +0000 (17:06 +0200)]
Unit test for RestconfDataServiceImpl class

Change-Id: I9eac7cb5316465d3d7cc4b38f6d450bdb08015d7
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoMerge "BUG-5488: Decrease buffer size to prevent memory exhaustion"
Tomas Cere [Tue, 6 Sep 2016 09:55:41 +0000 (09:55 +0000)]
Merge "BUG-5488: Decrease buffer size to prevent memory exhaustion"

7 years agoBUG-5488: Decrease buffer size to prevent memory exhaustion 56/45156/2
Andrej Mak [Mon, 5 Sep 2016 12:06:15 +0000 (14:06 +0200)]
BUG-5488: Decrease buffer size to prevent memory exhaustion

When netconf device is connected using ssh, AsyncSshHandlerReader
allocates buffer for each received notification. Under high load,
it is possible, that notifications are received faster than consumed.
In this case, pending notifications tasks are queued
in netty executors queues. It could cause memory exhaustion.

Preallocated buffer size was 8192 B. This patch decreases it to
2048 B, as Apache Mina resizes buffer if it is needed.

Bellow are test results of receiving 100000 notifications as described by
https://wiki.opendaylight.org/view/NETCONF:Testing#NETCONF_southbound_performance_test
using the largest notification - i2rs-notifs-perf100k10prefixes.xml.

Time needed to handle notifications is same regardless of BUFFER_SIZE value,
but max memory needed is lower, if BUFFER_SIZE value is lower.

BUFFER_SIZE = 128,  max heap memory = 1.1 GB  avg = 59640 ms
BUFFER_SIZE = 2048, max heap memory = 1.3 GB  avg = 58450 ms
BUFFER_SIZE = 8192, max heap memory = 2   GB  avg = 59207 ms

Change-Id: I7be5e50aa72e04f5df6fd96988bd588d3c369b01
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoUnit test for PostDataTransactionUtil class 71/44871/7
miroslav.kovac [Tue, 30 Aug 2016 10:59:10 +0000 (12:59 +0200)]
Unit test for PostDataTransactionUtil class

Change-Id: I38e1d29daa1598609e1a706b16d1bb2f24012f0f
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoUnit test for PutDataTransatcionUtil class 16/44716/13
miroslav.kovac [Fri, 26 Aug 2016 09:36:37 +0000 (11:36 +0200)]
Unit test for PutDataTransatcionUtil class

Change-Id: Iccdfc3423acb52b6efdb3981985cbe7713a8fae6
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoAdd test for CreateStreamUtil class 90/44390/9
miroslav.kovac [Fri, 19 Aug 2016 11:30:51 +0000 (13:30 +0200)]
Add test for CreateStreamUtil class

Redundant condition removed from CreateStreamUtil class

Change-Id: I6ed7c88b05c895bcf21c70eb533f742bca30ee49
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.sk>
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoUnit test for RestconfInvokeOperationsUtil class 61/44661/8
miroslav.kovac [Wed, 24 Aug 2016 13:34:43 +0000 (15:34 +0200)]
Unit test for RestconfInvokeOperationsUtil class

Fixed so it add rpcError to the result when there is one.

Change-Id: I5e3e924a0e80970f2f754e2ec39d58e4b0a06984
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoUnit test for ReadDataTransactionUtil class 03/44603/7
miroslav.kovac [Wed, 24 Aug 2016 12:44:20 +0000 (14:44 +0200)]
Unit test for ReadDataTransactionUtil class

Fixed bug with merging list data. Also delete and change some
redundant data and function calling.

Change-Id: I842e4d0678fb4285dd50ea776368f4a784021299
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 6429 - Fix notification xml output according to RFC 56/45056/3
miroslav.kovac [Fri, 2 Sep 2016 07:58:27 +0000 (09:58 +0200)]
Bug 6429 - Fix notification xml output according to RFC

Change-Id: If0802ee4a3bb3a2d0938977a3420298156833286
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoMerge "Bug 6343 - Incorrect handling of configuration failures in SAL netconf connector"
Tomas Cere [Thu, 1 Sep 2016 22:06:11 +0000 (22:06 +0000)]
Merge "Bug 6343 - Incorrect handling of configuration failures in SAL netconf connector"

7 years agoBug 6343 - Incorrect handling of configuration failures in SAL netconf connector 29/43229/15
Jakub Morvay [Wed, 31 Aug 2016 14:41:56 +0000 (16:41 +0200)]
Bug 6343 - Incorrect handling of configuration failures in SAL netconf connector

Change-Id: I4fbf06038b4a14c0efecfa6564e69671a3d23bcc
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6594 - Unsupported leaf in identityref in leafref 19/44919/2
Jakub Toth [Wed, 31 Aug 2016 11:36:37 +0000 (13:36 +0200)]
Bug 6594 - Unsupported leaf in identityref in leafref

  * fixed incorrect checking of variable

Change-Id: I01c631d7bbc22857e1c454a860ac636305301e38
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoUse a methodhandle to extract EnumPair name 79/44879/1
Robert Varga [Tue, 30 Aug 2016 17:25:30 +0000 (19:25 +0200)]
Use a methodhandle to extract EnumPair name

This a more efficient replacement for a anonymous filter.

Change-Id: Ic7941bb5341080a12a614239ffa1973dd9acc464
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBug 6485 - unstable mount point 05/44605/4
Jakub Toth [Wed, 24 Aug 2016 12:41:47 +0000 (14:41 +0200)]
Bug 6485 - unstable mount point

  * swap result of operation with CountDownLatch.countDown()

Change-Id: Ib042de4ee5d6399a15d7877fef0c9260339380f0
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 5615 - Netconf connector update overwriting existing topology data"
Tomas Cere [Fri, 26 Aug 2016 09:31:13 +0000 (09:31 +0000)]
Merge "Bug 5615 - Netconf connector update overwriting existing topology data"

7 years agoMerge "Remove jersey-server artifact"
Tomas Cere [Fri, 26 Aug 2016 09:21:21 +0000 (09:21 +0000)]
Merge "Remove jersey-server artifact"

7 years agoRemove jersey-server artifact 60/44660/1
miroslav.kovac [Thu, 25 Aug 2016 12:03:39 +0000 (14:03 +0200)]
Remove jersey-server artifact

This artifact prevents correct debuging in Idea or Eclipse

Change-Id: I9d2122410441485bd64053c09d2c71afd2d8744e
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 6457 - Delete Cars configuration from Follower produces HTTP 500 Error 63/44563/4
Jakub Toth [Tue, 23 Aug 2016 15:09:53 +0000 (17:09 +0200)]
Bug 6457 - Delete Cars configuration from Follower produces HTTP 500 Error

  * change InterruptedException with Exception
  * Ignore unstable tests in RestPutOperationTest + TODO

Change-Id: I93f66dc713781f4dacd7c9f804d8bf71ffc798e3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoAdd Gson bundle to odl-netconf-connector feature 13/44613/1
Jakub Morvay [Wed, 24 Aug 2016 14:18:26 +0000 (16:18 +0200)]
Add Gson bundle to odl-netconf-connector feature

This explicitly adds Gson bundle to odl-netconf-connector feature. Gson
bundle needs to be resolved and installed, because sal-netconf-connector
bundle depeneds on it.

Change-Id: Iefd5578cb3ca809f28c504ac5a3686175683fe7e
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 5615 - Netconf connector update overwriting existing topology data 32/43632/8
rbrisuda [Wed, 10 Aug 2016 12:50:35 +0000 (14:50 +0200)]
Bug 5615 - Netconf connector update overwriting existing topology data

- putting only augmented node 'NetconfNode' to operational datastore
- updated tests

Change-Id: I3153613c9041c36f558e73128d40dd75dece0293
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoMerge changes I20578f97,I629c909b,I54f04c99,I9c1e3a28,Ie681c8c5
Tomas Cere [Tue, 16 Aug 2016 16:06:07 +0000 (16:06 +0000)]
Merge changes I20578f97,I629c909b,I54f04c99,I9c1e3a28,Ie681c8c5

* changes:
  Bug 6325 - Fix for draft15 update
  Bug 6325 - upgrade draft11 to draft15 - added timestamp & etag
  Bug 6325 - upgrade draft11 to draft15 - change get modules
  Bug 6325 - upgrade draft11 to draft15 - change media types
  Bug 6325 - upgrade draft11 to draft15 - renaming

7 years agoMerge "Bug 6278: Switch to use odlparent's karaf-parent"
Tomas Cere [Tue, 16 Aug 2016 08:48:49 +0000 (08:48 +0000)]
Merge "Bug 6278: Switch to use odlparent's karaf-parent"

7 years agoBug 6325 - Fix for draft15 update 21/43121/14
Jakub Toth [Thu, 4 Aug 2016 14:32:19 +0000 (16:32 +0200)]
Bug 6325 - Fix for draft15 update

- transaction chain must be updated
in transaction handler

- adapt utility methods to reset
transaction chain

Change-Id: I20578f97c9a8d002c0ebcc6b8a89a152c1e1c47a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - added timestamp & etag 15/43115/9
Jakub Toth [Thu, 4 Aug 2016 13:26:41 +0000 (09:26 -0400)]
Bug 6325 - upgrade draft11 to draft15 - added timestamp & etag

  *fixed read of data from datastore

Change-Id: I629c909ba05f93f4d662199a86637e966cb6d8e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - change get modules 97/42997/10
Jakub Toth [Tue, 2 Aug 2016 18:23:58 +0000 (14:23 -0400)]
Bug 6325 - upgrade draft11 to draft15 - change get modules

  *change modules to modules-state
  *chagne modules/module to modules-state/module

Change-Id: I54f04c99484941e1ff59af67f822c2ef73c411b5
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - change media types 94/42994/10
Jakub Toth [Tue, 2 Aug 2016 17:58:38 +0000 (13:58 -0400)]
Bug 6325 - upgrade draft11 to draft15 - change media types

  * remove media types(for +json and +xml in all cases):
    * yang.api
    * yang.datastore
    * yang.data
    * yang.operation
    * yang.errors
  * add new media type:
    * for xml - yang-data
    * for json - yang-data+json

Change-Id: I9c1e3a28872c47f691d342a4982eaa3f8bbae16c
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6325 - upgrade draft11 to draft15 - renaming 83/42983/9
Jakub Toth [Tue, 2 Aug 2016 14:19:48 +0000 (10:19 -0400)]
Bug 6325 - upgrade draft11 to draft15 - renaming

  *renaming of all occurencies of "draft11" to "draft15"

Change-Id: Ie681c8c511fda87f6d3c862f64667827a9bff1f6
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBUG-865: remove String-based getDataChildByName() 82/43982/3
Jakub Morvay [Mon, 15 Aug 2016 13:25:13 +0000 (15:25 +0200)]
BUG-865: remove String-based getDataChildByName()

Some classes still implement String-based getDataChildByName method.
Get rid of this method implementations.

Change-Id: Ib8c458ec380262957b4bdc4e3b4f3e500f31d8f4
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 5553 - Impl get operations 91/41391/13
Jakub Toth [Mon, 4 Jul 2016 10:47:24 +0000 (12:47 +0200)]
Bug 5553 - Impl get operations

  *package protected impl of container, leaf and module
  *fix for new restconf part too

Change-Id: I1e3e1eb1a52158278992df871ba6690dd3b7c640
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 6251 - Exclude flawed models from mount point"
Tomas Cere [Fri, 12 Aug 2016 08:45:11 +0000 (08:45 +0000)]
Merge "Bug 6251 - Exclude flawed models from mount point"

7 years agoBug 6278: Switch to use odlparent's karaf-parent 71/43071/2
Ryan Goulding [Wed, 3 Aug 2016 16:39:31 +0000 (12:39 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I13739711964cd58cb0ef148bcb04532883fea19f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBump OpenExi to 2.62.0 99/42999/5
Robert Varga [Tue, 2 Aug 2016 18:58:16 +0000 (20:58 +0200)]
Bump OpenExi to 2.62.0

This bumps the version to the latest released one.

Change-Id: I10dff28446bb7bdcde86c06fe03075f6a67a2bd3
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "BUG-865: remove String-based getDataChildByName()"
Tomas Cere [Thu, 11 Aug 2016 11:36:38 +0000 (11:36 +0000)]
Merge "BUG-865: remove String-based getDataChildByName()"

7 years agoBug 6251 - Exclude flawed models from mount point 82/43682/4
Jakub Morvay [Wed, 10 Aug 2016 20:02:51 +0000 (22:02 +0200)]
Bug 6251 - Exclude flawed models from mount point

Flawed models that cannot be parsed by Yangtools are ignored when
building schema context for mountpoint.

Change-Id: I32585bcf34ae9df153c7147566828ba887f466de
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time"
Tomas Cere [Thu, 11 Aug 2016 08:32:17 +0000 (08:32 +0000)]
Merge "Bug 6198 - Use sal-netconf-connector to connet device costs too much time"

7 years agoBUG-865: remove String-based getDataChildByName() 68/43668/1
Jakub Morvay [Wed, 10 Aug 2016 22:00:53 +0000 (00:00 +0200)]
BUG-865: remove String-based getDataChildByName()

Replace usage of deprecated String-based getDataChildByName() method
with QName-based one.

Change-Id: I0108a98bb35082f1fe1b0a3c728fef2e4f43f9b9
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBump versions by 0.1.0 for next dev cycle 27/43427/1
Thanh Ha [Mon, 8 Aug 2016 21:50:17 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle

Change-Id: I6e4f55e341ebd255ace39f5fd4f1eabc9c29d44b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBug 6358 - Fix merge parents 16/43316/2
Jakub Toth [Mon, 8 Aug 2016 13:50:27 +0000 (15:50 +0200)]
Bug 6358 - Fix merge parents

Change-Id: I965f1ebe2e2bcc06f9af93e613351f28778448ff
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 6037 - Check if delete request was successful"
Tomas Cere [Fri, 5 Aug 2016 09:55:46 +0000 (09:55 +0000)]
Merge "Bug 6037 - Check if delete request was successful"

7 years agoMerge "Yang HTTP PATCH for Restconf11"
Tomas Cere [Fri, 5 Aug 2016 09:55:40 +0000 (09:55 +0000)]
Merge "Yang HTTP PATCH for Restconf11"

7 years agoBug 6037 - Check if delete request was successful 12/42712/25
Ivan Hrasko [Thu, 28 Jul 2016 13:16:01 +0000 (15:16 +0200)]
Bug 6037 - Check if delete request was successful

- adaptation for Restconf draft 11+
- checking if data to delete exists, if not return error 404
- remove not needed method from POST utils
and use method from common transaction utils
- added unit tests

Change-Id: I133c628a2e41f12d1db58fd06ff6c073ebfc6ece
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoYang HTTP PATCH for Restconf11 33/41833/53
Ivan Hrasko [Thu, 14 Jul 2016 13:57:09 +0000 (15:57 +0200)]
Yang HTTP PATCH for Restconf11

- support for restconf draft11-15 changes
- support for xml and json media types
- applied fixes for:
- Bug 5897 - PATCH merge operation does nothing
- Bug 5909 - PATCH does not report 409 on
OptimisticLockFailedException
- Bug 5730 - Delete subset of list items using PATCH?
- Bug 5898 - PATCH success "ok" field has wrong JSON value
- Bug 5915 - PATCH with "target":"/" error
- Bug 5509 - HTTP Patch in Restconf doesn't support general
absolute or relative target xpath
- contains unit tests
- Draft02 classes marked as deprecated
- adapt PATCH writers to support error path

Change-Id: I981dc8cbead3c5a7dc06b7b807c17a40a9cfe7b3
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 6037 - Check if delete request was successful 05/42705/11
Ivan Hrasko [Thu, 28 Jul 2016 12:45:09 +0000 (14:45 +0200)]
Bug 6037 - Check if delete request was successful

- solution for old restconf
- checking if data to delete exists, if not return error 404
- use callbacks for transactions

Change-Id: I0f4c11cb3dd9c7fc560a4fee06df0d398c0c4f61
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 2594 - PUT method returns wrong status for create resource 35/40235/14
Jakub Toth [Mon, 13 Jun 2016 12:49:47 +0000 (14:49 +0200)]
Bug 2594 - PUT method returns wrong status for create resource

  *remove get() and checkedGet() on future objects, add callback
  *fix tests

Change-Id: I48f8f825da2427357c3f8948cbea52d2f9c235ce
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge changes I426a2bc1,I5440b866
Tomas Cere [Tue, 2 Aug 2016 13:57:34 +0000 (13:57 +0000)]
Merge changes I426a2bc1,I5440b866

* changes:
  Bug 6291 - Fix bugs of new Restconf 11 implementation
  Bug 5909 - PATCH does not report 409 on OptimisticLockFailedException

7 years agoBug 6322 - Boron: odl-netconf-clustered-topology still depends on distributed-entity... 43/42943/1
Jakub Morvay [Tue, 2 Aug 2016 07:06:28 +0000 (09:06 +0200)]
Bug 6322 - Boron: odl-netconf-clustered-topology still depends on distributed-entity-ownership-service

Change-Id: I47c234ff6b927c770d89974907a7291067ab1af1
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6291 - Fix bugs of new Restconf 11 implementation 65/42565/17
Ivan Hrasko [Tue, 26 Jul 2016 12:46:04 +0000 (14:46 +0200)]
Bug 6291 - Fix bugs of new Restconf 11 implementation

- first identifier does not start with slash
when deserialization is invoked
- adapted unit tests
- return error 404 when data missing with GET
operation
- return config data when state data does
not exists with GET operation
- return state data when config data does
not exists with GET operation
- identifier can be null and it is deserialized to
YangInstanceIdentifier.EMPTY

Change-Id: I426a2bc1cb0e908dc189553e464f405ef4ce1457
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5909 - PATCH does not report 409 on OptimisticLockFailedException 62/42462/18
Ivan Hrasko [Tue, 26 Jul 2016 14:17:46 +0000 (16:17 +0200)]
Bug 5909 - PATCH does not report 409 on OptimisticLockFailedException

- wait for transaction to be finished using callback

Change-Id: I5440b866eada07ee6540c6b93d2e9174e62a37ce
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5897 - PATCH merge operation does nothing 61/42461/11
Ivan Hrasko [Mon, 25 Jul 2016 10:43:38 +0000 (12:43 +0200)]
Bug 5897 - PATCH merge operation does nothing

- added merge patch operation processing

Change-Id: Ic3f5908c5f016a0680779ed12b4bc26b7b840d9a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5915 - PATCH with "target":"/" error 60/42460/10
Ivan Hrasko [Mon, 25 Jul 2016 10:43:06 +0000 (12:43 +0200)]
Bug 5915 - PATCH with "target":"/" error

- fixed bug + added unit test (example of usage)
for json and xml
- improved solution of bug5730

Change-Id: I0d8042ffdced97918ff936817513fc30163be577
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 59/42459/12
Ivan Hrasko [Mon, 25 Jul 2016 10:42:30 +0000 (12:42 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- yang patch for xml media now supports relative or absolute xpaths
- only create, merge, replace and insert operations require value to be present
- if value is not present with create, merge, replace or insert operation
then error 400 is returned
- if value is used with other operations then error 400 is returned
- deleting sublist values instead of full parent
- support for multiple values
- added unit tests

Change-Id: I9828ceb7368760642b22b3a336884b949f0edfcc
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target... 57/42457/9
Ivan Hrasko [Mon, 25 Jul 2016 10:12:07 +0000 (12:12 +0200)]
Bug 5509 - HTTP Patch in Restconf doesn't support general absolute or relative target xpath

- dependencies shared between XML and JSON PATCH implementations

Change-Id: Ia649763379fab03019ddfd16eac564da576cb35b
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5898 - PATCH success "ok" field has wrong JSON value 56/42456/9
Ivan Hrasko [Mon, 25 Jul 2016 10:08:33 +0000 (12:08 +0200)]
Bug 5898 - PATCH success "ok" field has wrong JSON value

- empty value is represented as an array with value null

Change-Id: Ie8315d5a18756fd12d3b7a7de693dfd1c569945a
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5730 - Delete subset of list items using PATCH? 49/42449/9
Ivan Hrasko [Mon, 25 Jul 2016 10:35:53 +0000 (12:35 +0200)]
Bug 5730 - Delete subset of list items using PATCH?

- fix: edit is not ignored when end of input is reached
- fix: only create, merge, replace and insert operations require value to be present
- fix: if value is not present with create, merge, replace or insert operation then error 400 is returned
- fix: if value is used with other operations error 400 is returned
- fix: deleting sublist values instead of full parent
- fix: order of patch edit fields is not important anymore (target, value)
- move class StringModuleInstanceIdentifierCodec to own file

Change-Id: I4c3f407858034b49795034da6c93b41f9d891b62
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target... 58/42458/6
Ivan Hrasko [Mon, 25 Jul 2016 10:27:57 +0000 (12:27 +0200)]
Bug 5509: HTTP Patch in Restconf doesn't support general absolute or relative target xpath

Absolute or relative input URI and PATCH target JSON support

Change-Id: I86821e59581968cef5f11ec34ce98757909f7c36
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoRevert "Bump apache mina to 1.2.0" 27/42627/1
Tomas Cere [Wed, 27 Jul 2016 11:12:03 +0000 (13:12 +0200)]
Revert "Bump apache mina to 1.2.0"

This reverts commit 3911a32461cf5817787c807cad676d4164f0cbd4.

Change-Id: Ia4cdf9a281706157933326f7e8de1ef95bcbb6a6
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBug 6198 - Use sal-netconf-connector to connet device costs too much time 97/42297/3
Xu Rong [Tue, 19 Jul 2016 13:16:44 +0000 (21:16 +0800)]
Bug 6198 - Use sal-netconf-connector to connet device costs too much time

Filter missing sources Identifiers before createSchemaContext in class RecursiveSchemaSetup.

Change-Id: Ic41d4803df0807d799a1e80ceb6639877f006e42
Signed-off-by: Xu Rong <xu.rong4@zte.com.cn>
7 years agoBug 3959 - support netconf notification 39/41639/18
Jakub Toth [Fri, 8 Jul 2016 13:44:52 +0000 (15:44 +0200)]
Bug 3959 - support netconf notification

  *added dependency for converting JSON to XML
  *created new notification listener adapter extended
   by DOMNotificationListener
  *added augment for sal-remote to add new param
   for input of create-notification-stream rpc to
   make a choice between JSON or XML output of
   notification (not mandatory - default is XML)
  *added unit tests

Change-Id: I7f5909208dce71e2280fd1bc6dbe49cb7533523a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bump apache mina to 1.2.0"
Tomas Cere [Mon, 25 Jul 2016 12:11:49 +0000 (12:11 +0000)]
Merge "Bump apache mina to 1.2.0"

7 years agoAdd missing license headers 78/42378/1
Thanh Ha [Sat, 23 Jul 2016 03:12:52 +0000 (23:12 -0400)]
Add missing license headers

Change-Id: Ic4bb7ae58d821c8c00849db4b934c5eeb3bf5b68
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBump apache mina to 1.2.0 24/41824/9
Robert Varga [Thu, 14 Jul 2016 12:19:18 +0000 (14:19 +0200)]
Bump apache mina to 1.2.0

Bumps the dependency from pre-release to the current
release. Also adjusts implementation to match changed APIs.

Change-Id: Ia5d7479e32cbd25c9f9f67a5866a5d2830f146d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "Switch to using StandardCharsets"
Tomas Cere [Tue, 19 Jul 2016 07:57:28 +0000 (07:57 +0000)]
Merge "Switch to using StandardCharsets"

7 years agoSwitch to using StandardCharsets 83/41983/3
Robert Varga [Mon, 18 Jul 2016 14:52:02 +0000 (16:52 +0200)]
Switch to using StandardCharsets

Guava's Charsets should not be used in recent Java
environments.

Change-Id: I24d14cd2410ba3d249037e802b7863a6141c89db
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoUse upgraded ietf-{inet,yang}-types in test-tool 75/41975/1
Jakub Morvay [Mon, 18 Jul 2016 14:18:58 +0000 (16:18 +0200)]
Use upgraded ietf-{inet,yang}-types in test-tool

Change-Id: I5c99b7bb815f723bbc7640b4c118f5ee395fe6cf
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Organize Import to conform to Checkstyle guidelines."
Tomas Cere [Mon, 18 Jul 2016 07:58:42 +0000 (07:58 +0000)]
Merge "Organize Import to conform to Checkstyle guidelines."

7 years agoMerge "Bug 5682 - MDSAL netconf northbound yang library"
Tomas Cere [Mon, 18 Jul 2016 07:53:16 +0000 (07:53 +0000)]
Merge "Bug 5682 - MDSAL netconf northbound yang library"

7 years agoBug 5682 - MDSAL netconf northbound yang library 40/40540/7
Jakub Morvay [Sun, 19 Jun 2016 19:07:28 +0000 (21:07 +0200)]
Bug 5682 - MDSAL netconf northbound yang library

This adds support for ietf-yang-library for MDSAL netconf northbound
server

Change-Id: Iab6178d2fc975860f7c5c835517fc3c120faebb7
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6154 - Connection to config subsystem netconf endpoint refused 16/41816/3
Jakub Morvay [Thu, 14 Jul 2016 08:37:30 +0000 (10:37 +0200)]
Bug 6154 - Connection to config subsystem netconf endpoint refused

Makes config subsystem SSH server listen on address 0.0.0.0 instead of
127.0.0.1.

Change-Id: I7577629763b7d5a0d86d92ea0e997a80e841f360
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoAdjust tests to new ietf-inet-types 22/41922/1
Robert Varga [Sun, 17 Jul 2016 08:25:10 +0000 (10:25 +0200)]
Adjust tests to new ietf-inet-types

Change-Id: I39d6bebfb178950f828bce912a8b3e533b0e1abc
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoOrganize Import to conform to Checkstyle guidelines. 18/39618/3
Michael Vorburger [Mon, 30 May 2016 17:20:02 +0000 (19:20 +0200)]
Organize Import to conform to Checkstyle guidelines.

Change-Id: Ia766cb2af1c13808a7a0b28761fdd241c781319b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 93/40793/4
Lorand Jakab [Wed, 6 Jul 2016 13:56:38 +0000 (08:56 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I632370c6e9b078817c69a19b3f7c1c17846ce249
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 5526 - Testing - RestconfModulesService 01/38501/33
Jakub Toth [Fri, 6 May 2016 09:42:27 +0000 (11:42 +0200)]
Bug 5526 - Testing - RestconfModulesService

Unit tests for RestconfModulesServiceImpl + repackaging of tests

Change-Id: I0cb9c7b753d5c4c54d4d4d393d86787294a0903e
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5526 - Testing - Utils - Mapping 76/38576/34
Ivan Hrasko [Mon, 9 May 2016 13:42:24 +0000 (15:42 +0200)]
Bug 5526 - Testing - Utils - Mapping

Unit test for RestconfMappingNodeUtil

Change-Id: I8c2be08791b1e87a59b198c5f145ef3fe0961376
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5528 - Connecting RESTful part to restconf + fix bugs 46/40246/10
Jakub Toth [Mon, 13 Jun 2016 16:05:13 +0000 (18:05 +0200)]
Bug 5528 - Connecting RESTful part to restconf + fix bugs

  *new wrapper for transaction services
  *wrapper for transaction and base services
  *fix bugs
    *fix serializer of YII for create right prefix of namespace

Change-Id: I847eb536d94ff0e1b0c1e34cbb8d7c110b744ac4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Subscribing to stream impl 00/40100/12
Jakub Toth [Thu, 9 Jun 2016 09:48:48 +0000 (11:48 +0200)]
Bug 5528 - Subscribing to stream impl

  *preparing dom data broker handler

Change-Id: Id90c13e8ebba1b60237a45808c973ccdf3a8dcda
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Create stream for DS 55/40055/14
Jakub Toth [Wed, 8 Jun 2016 16:37:16 +0000 (18:37 +0200)]
Bug 5528 - Create stream for DS

Change-Id: I2bdd16302aebd70c8929bbedfa99672358a96c91
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Streams service impl - prepare impl by interface 28/39928/13
Jakub Toth [Tue, 7 Jun 2016 09:18:05 +0000 (11:18 +0200)]
Bug 5528 - Streams service impl - prepare impl by interface

Change-Id: Ib3d2a755159ee90b2fdafde2aa203f1f5dacbcbd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Invoke RPC impl 88/39888/18
Jakub Toth [Mon, 6 Jun 2016 14:00:49 +0000 (16:00 +0200)]
Bug 5528 - Invoke RPC impl

  *create RpcServiceHandler for handling service of rpc
  *create factory of rpc result

Change-Id: I2b2fff5558887e8c6f5e370b36d197dbde271955
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - RPC invoke impl - prepare impl of interface 49/39749/20
Jakub Toth [Thu, 2 Jun 2016 08:26:19 +0000 (10:26 +0200)]
Bug 5528 - RPC invoke impl - prepare impl of interface

Change-Id: I571166124fbe7588f187091976af6b8d6deb6e22
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Delete data impl 34/39634/23
Jakub Toth [Tue, 31 May 2016 08:41:25 +0000 (10:41 +0200)]
Bug 5528 - Delete data impl

Change-Id: I47955a4f6563c3ae5ab5d5db38823530bf013cba
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Impl Post data 66/39566/30
Jakub Toth [Sun, 29 May 2016 08:55:37 +0000 (10:55 +0200)]
Bug 5528 - Impl Post data

  *added new constant for post data
  *added location to response factory
  *moved ensureParentsByMerge to common util class of Put and Post

Change-Id: I2d525a1e602170ef41fd332bb8db9dfabd59e188
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Put data impl 85/39485/29
Jakub Toth [Thu, 26 May 2016 13:50:31 +0000 (15:50 +0200)]
Bug 5528 - Put data impl

  *make FutureCallbackTx more generaly
  *factory for NormalizedNode(READ) and Response(PUT) from Future
  *fix ReadDataTransactionUtil after remake of FutureCallbackTx

Change-Id: Iec2d35271881c7ffe630cdd832510a3f0df7616a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Read data impl 64/39464/32
Jakub Toth [Thu, 26 May 2016 08:32:29 +0000 (10:32 +0200)]
Bug 5528 - Read data impl

  *impl RestconfDataService
    *util class for constants
  *wrapper for transaction vars

Change-Id: I61f4662b61ac9cf15535492f31bc896a863ce986
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Handlers 63/39463/27
Jakub Toth [Thu, 26 May 2016 08:25:57 +0000 (10:25 +0200)]
Bug 5528 - Handlers

  *make handlers immutable
    *DOMMountPointServiceHandler
    *SchemaContextHandler
    *TransactionChainHandler
  *common interface for all handlers
  *fix dependencies of these changes

Change-Id: I4f3a78103036d88a5129f084bd088cd51c5b549c
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5528 - Preparing enviroment for impl of restful services 47/38747/23
Jakub Toth [Thu, 12 May 2016 08:58:35 +0000 (10:58 +0200)]
Bug 5528 - Preparing enviroment for impl of restful services

  * repackeging
  * fixing changes

Change-Id: I2ece0416ed09c3fc3517957427e18673406013de
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 5403 - Support yang-library schema resolution 06/40606/3
Jakub Morvay [Tue, 21 Jun 2016 11:23:03 +0000 (13:23 +0200)]
Bug 5403 - Support yang-library schema resolution

Change-Id: I3599d3cf857cbb7b40c17aafadc9db7c83c4b09d
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoMerge "Bug 5526 - Unit testing"
Tomas Cere [Tue, 28 Jun 2016 08:26:12 +0000 (08:26 +0000)]
Merge "Bug 5526 - Unit testing"

7 years agoMerge ".gitignore .factorypath created by m2e-apt"
Tomas Cere [Tue, 28 Jun 2016 08:07:41 +0000 (08:07 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"

7 years agoBug 5526 - Unit testing 14/40914/2
Ivan Hrasko [Tue, 28 Jun 2016 07:42:02 +0000 (09:42 +0200)]
Bug 5526 - Unit testing

Fix for streams service unit testing. Prepare test streams
before tests are run and clean test streams after tests completed.

Change-Id: Ic61b7adcdc8aa48ee54d2f164143152729c6a899
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
7 years agoBug 5528 - API for RESTful - transaction part of CRUD 99/38499/27
Jakub Toth [Fri, 6 May 2016 08:38:32 +0000 (10:38 +0200)]
Bug 5528 - API for RESTful - transaction part of CRUD

Change-Id: I2e8fad15f1ee2f9fbef1dfabdd36258c59c9d86e
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Add simulated discard-changes to testtool default datastore"
Tomas Cere [Tue, 21 Jun 2016 11:02:11 +0000 (11:02 +0000)]
Merge "Add simulated discard-changes to testtool default datastore"

7 years agoMerge "Stop using blocking invoke for lock and editConfig."
Tomas Cere [Tue, 21 Jun 2016 10:31:17 +0000 (10:31 +0000)]
Merge "Stop using blocking invoke for lock and editConfig."

7 years agoAdd simulated discard-changes to testtool default datastore 01/40601/1
Tomas Cere [Tue, 21 Jun 2016 10:24:33 +0000 (12:24 +0200)]
Add simulated discard-changes to testtool default datastore

Change-Id: Id07a30610399ba498fd35cff3086134aaf20bcb7
Signed-off-by: Tomas Cere <tcere@cisco.com>