Tali [Sun, 26 Mar 2017 19:53:50 +0000 (22:53 +0300)]
Add getChildInterfaces to IInterfaceManager
Change-Id: Id87aaabe7932d5c95e4f5986846abd85c104deae
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Guy Regev [Tue, 7 Feb 2017 14:24:50 +0000 (16:24 +0200)]
Added consts for counter service
Change-Id: Ifa12f3353c4fe4b8917bc36c99e37a3f823c0ce5
Signed-off-by: Guy Regev <guy.regev@hpe.com>
Sam Hague [Sat, 25 Mar 2017 13:29:04 +0000 (13:29 +0000)]
Merge "Changes for policy-based path selection"
Sam Hague [Sat, 25 Mar 2017 12:40:44 +0000 (12:40 +0000)]
Merge "AbstractTestableListener timeout increased from 3s to 30s"
Faseela K [Fri, 24 Mar 2017 21:22:38 +0000 (02:52 +0530)]
Fixing InterfacestateListener after BP migration
Change-Id: I7ee5576c83d17fe995511495167a503889fa435b
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Sat, 25 Mar 2017 02:24:19 +0000 (03:24 +0100)]
AbstractTestableListener timeout increased from 3s to 30s
including new "in progress" LOG
dito for TestableJobCoordinatorEventsWaiter (recently added)
Change-Id: Id1d37675b0df9533b2faff571d52961ca988ba99
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 23 Mar 2017 22:55:18 +0000 (23:55 +0100)]
Fix bug in MatchInPort equals() method
Calling super() is wrong in this particular case, see MatchInPortTest
(which fails without this fix, but passes with it).
BTW: We need to just completelystop hand writing equals() and hashCode()
methods, anywhere... I'll put in a separate new change some time, to
replace all of this with immutables.org gen. code.
Change-Id: Iec1f3c9cd3588bf77b7d86e218c5dd586712690e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edwin Anthony [Fri, 24 Mar 2017 06:49:17 +0000 (12:19 +0530)]
ITM checkstyle enforcement
Change-Id: I3b06cd1d2361ccbe9c0c03ad14591d111415095e
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Faseela K [Fri, 24 Mar 2017 10:27:37 +0000 (10:27 +0000)]
Merge "interface-manager - Minor logging enhancement"
Vivek Srivastava [Fri, 24 Mar 2017 09:25:36 +0000 (09:25 +0000)]
Merge "Revert "Spec for Counter Framework bundle""
Faseela K [Fri, 24 Mar 2017 08:59:11 +0000 (14:29 +0530)]
interface-manager - Minor logging enhancement
Adding bfd-state in the update log information
Change-Id: Id8b4a6a38c1fc71d64c39783544f9f9d64be38f9
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Fri, 24 Mar 2017 08:25:18 +0000 (13:55 +0530)]
Revert "Spec for Counter Framework bundle"
This reverts commit
5b27499fd1f7ca7635b50955d194b2d37104b1a7.
Change-Id: I42128c022d8f6f99a312329736a51feecc7f40a1
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David [Wed, 22 Mar 2017 15:31:27 +0000 (16:31 +0100)]
Fix issues related to checkstyle enforcement for module
interfacemanager-impl
- Dates
- Line lengths
- Formatting
- Exception catching
- Order imports
- Change variable names
- JavaDoc
- Move variables closer to their declaration
- Shorten type declarations
- Remove redundant modifiers
Note: more patches needed, checkstyle not enforced yet.
Change-Id: I252a1a2a120c92065b12cc714c01550dcbefa091
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Michael Vorburger [Thu, 23 Mar 2017 23:47:42 +0000 (00:47 +0100)]
Revert "ITM Tep Auto Config Unit test using Guice."
This reverts commit
381310f948d04ca1c1b830b366c81dada39bcb55.
Change-Id: Id07f7820f609db45c9c0f477f0d839f09d4a5297
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Thu, 23 Mar 2017 19:47:12 +0000 (19:47 +0000)]
Merge "Fix overlapping bits in metadata between lport tag mask and elan subnet route mask."
Vivek Srivastava [Thu, 23 Mar 2017 15:15:38 +0000 (15:15 +0000)]
Merge "Change externalId tep param dpn-br-name to br-name"
Vivek Srivastava [Thu, 23 Mar 2017 15:15:03 +0000 (15:15 +0000)]
Merge "ITM Tep Auto Config Unit test using Guice."
Brady Johnson [Thu, 23 Mar 2017 09:38:35 +0000 (10:38 +0100)]
Minor changes for Netvirt Egress Classifier tables
- renamed EGRESS_SFC_CLASSIFIER_ACL_TABLE to EGRESS_SFC_CLASSIFIER_NEXTHOP_TABLE
- Added EGRESS_SFC_CLASSIFIER_EGRESS_TABLE
Change-Id: Ia2b6ca3824e9196ad8954c078f7ce5f0baa71737
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Michael Vorburger [Thu, 23 Mar 2017 10:46:01 +0000 (10:46 +0000)]
Merge "TestIMdsalApiManager with naturally sorted flows"
Faseela K [Tue, 14 Feb 2017 19:16:37 +0000 (00:46 +0530)]
Removing Deprecated Listener Base Classes
Refer the weather item for more details:
https://wiki.opendaylight.org/view/Weather#Genius_AbstractDataChangeListener_clean-up
Change-Id: Ibb5e04c02fb94bca64c7c6d7c34210469aa913eb
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tali [Tue, 7 Mar 2017 10:28:07 +0000 (12:28 +0200)]
Changes for policy-based path selection
* Constants definition
* Add classifier methods to MetadataUtil
Change-Id: I1df95db1db1f197085efff0766f8ac96009e5c89
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Brady Johnson [Fri, 17 Mar 2017 10:05:45 +0000 (11:05 +0100)]
Changes for New Netvirt SFC Classifier
- Adjusted service priorities
- Added SFC Classifier service, ingress and egress
- Added SFC Classifier table offsets
- More detail in Netvirt blueprint:
https://git.opendaylight.org/gerrit/#/c/52063
Change-Id: I6d738979aaf4358bb429b538c8ee935e36fccd5a
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
David [Mon, 20 Mar 2017 17:03:52 +0000 (18:03 +0100)]
Fix issues related to checkstyle enforcement for module
interfacemanager-impl
- Dates
- Line lengths
- Formatting
- Exception catching
- Order imports
- Change variable names
- JavaDoc
Note: more patches needed, checkstyle not enforced yet.
Change-Id: Ifdc1c291f1be21e14b7f7bd0a95286f356acd00f
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Tue, 14 Mar 2017 11:17:54 +0000 (16:47 +0530)]
Support For Egress Service Binding On tunnels
- Adding provision for binding egress services on tunnels
- GetEgressActionsForInterface will return new set of actions for tunnel
interface
- Whenever a tunnel interface is created, a default service will be bound
on the interface to take packets out on the tunnel port
Change-Id: Idf59949085876520c74548e269df0cc6927e3d7f
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 20 Mar 2017 17:58:51 +0000 (17:58 +0000)]
Merge "runOnlyInLeaderNode() - out of order event processing"
Faseela K [Mon, 20 Mar 2017 17:56:49 +0000 (17:56 +0000)]
Merge "Ensure unique ids are allocate across cluster"
Michael Vorburger [Mon, 20 Mar 2017 14:14:19 +0000 (14:14 +0000)]
Merge "Cleanup: avoid immediate Optional.get()"
Yakir Dorani [Mon, 20 Mar 2017 09:24:38 +0000 (11:24 +0200)]
Fix overlapping bits in metadata between lport tag mask and elan subnet route mask.
When creating a VrfEntry with SubnetRoute augmentation, VrfEntryListener installs a
flow with vpn-id and elan-tag, but this overrides part of the lport-tag bits.
It looks like vpn-id is allocated in the range of 70,000 to 100,000,
but METADATA_MASK_VRFID has 31 bits (
00000000FFFFFFFE).
This change shortens the VRFID to 23 bits which is enough for the vpn-id,
and shifts the elan subnet route mask which solves the overlapping.
Change-Id: Iaf23a15f41229782908dc56146e3dfae0cc78c58
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Tarun Thakur [Thu, 12 Jan 2017 15:07:35 +0000 (20:37 +0530)]
ITM Tep Auto Config Unit test using Guice.
Added cases for:
- Change for def-tz-enabled and def-tz-tunnel-type config paramters
- Default-TZ creation and deletion based on def-tz-enabled flag
- TEP addition and deletion into/from default-TZ
- TZ creation and TEP addition into TZ
- TZ deletion and TEP deletion from TZ
- TEP addition and deletion into/from default-TZ via southbound
- TEP addition and deletion into/from northbound configured TZ via southbound
- TEP addition and deletion into/from NotHostedList via southbound
- Move TEP from one TZ to other TZ by changing tzname parameter in
ExternalsIds list in Ovsdb node from southbound
- Update TEP for its bridge by changing dpn-br-name parameter in
ExternalsIds list in Ovsdb node from southbound
Change-Id: Ie5300632009c174d571903cda137e829b995fb55
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tarun Thakur [Tue, 7 Mar 2017 07:30:02 +0000 (13:00 +0530)]
Change externalId tep param dpn-br-name to br-name
ExternalIds TEP parameter 'dpn-br-name' is changed to 'br-name'
to keep it in sync with Openstack.
Change-Id: I0a5bfacfb7ee50aac69696be09697cf930f77b19
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Faseela K [Fri, 17 Mar 2017 08:00:35 +0000 (13:30 +0530)]
runOnlyInLeaderNode() - out of order event processing
While using runOnlyInLeaderNode() check in a scaled setup,
noticing that we are processing back to back toggling events
out of order, since the check is executed in a separate
thread
Change-Id: I0c7dcaba5a75d9676d31c3f3ada1d4243c941845
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Kency Kurian [Fri, 17 Mar 2017 07:41:40 +0000 (13:11 +0530)]
Ensure unique ids are allocate across cluster
When allocateId and releaseId is invoked, we can lock on the uniqueIdKey
using lockManager in order to ensure that unique ids are allocated.
Change-Id: If9b897b5323b8e74a5cb09f85c7e151c50119e16
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
David [Fri, 17 Mar 2017 15:11:25 +0000 (16:11 +0100)]
Fix issues related to checkstyle enforcement for module
interfacemanager-impl
- Copyright sections
- Line lengths
- Formatting
- Exception catching
- Private constructor for Utility classes
- Final modifier for Utility classes
- Move variable declaration closer to its use
- Move overloaded methods closer to each other
- Remove redundant modifiers
- Order imports
- Change variable names
- JavaDoc
Note: more patches will come on this module until final enforcement.
Change-Id: I3a2f2244a60947f9b43060b55a6b6ad90ff05c1b
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Stephen Kitt [Fri, 17 Mar 2017 17:15:59 +0000 (18:15 +0100)]
Cleanup: use correct format strings with String.format()
String.format() expects C-style format strings, not SLF4J-style.
Change-Id: Ie10a9983a5bff0c8bd46ae0e55c8c872030e5992
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 17 Mar 2017 17:13:41 +0000 (18:13 +0100)]
Cleanup: use equals() to compare object instances
... instead of ==.
Change-Id: I0207e611c237f8dff749fc58cefd324cae174f4f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 17 Mar 2017 17:17:42 +0000 (18:17 +0100)]
Cleanup: avoid immediate Optional.get()
This reworks allocateId() to store the id directly, and wrap it in an
Optional when needed, instead of wrapping it and unwrapping it
immediately. The performance gain isn't significant, but this helps
static analysers which check for get()-without-isPresent().
Change-Id: I5155660e6240a8c9d01de0bce78528b80d755e10
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Fri, 17 Mar 2017 17:41:38 +0000 (17:41 +0000)]
Merge "NxMatchInfo redesign"
Faseela K [Fri, 17 Mar 2017 17:24:51 +0000 (17:24 +0000)]
Merge "Harden BFD configuration parameters"
Stephen Kitt [Fri, 17 Mar 2017 09:19:03 +0000 (10:19 +0100)]
Un-uglify AbstractInstructionInfoImpl
Abstract classes can override concrete methods with abstract
declarations to force their own sub-classes to re-implement them,
there's no need to use ...2() variants.
Make the equals/hashCode implementations consistent with the rest of
the InstructionInfo implementations.
Change-Id: I948dd27bc57934ad34493244ddb3a26cd30d1393
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 16 Mar 2017 12:33:47 +0000 (13:33 +0100)]
TestIMdsalApiManager with naturally sorted flows
This leads to much clearer failure messages in assertFlowsInAnyOrder()
Change-Id: Ic7c07d7eb29a8937b88d3b094c2fcdcdad755ee4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 17 Mar 2017 10:17:26 +0000 (10:17 +0000)]
Merge "Updated TestIMdsalApiManager.java to support installFlow() with CheckedFuture return value"
Faseela K [Fri, 17 Mar 2017 09:26:27 +0000 (09:26 +0000)]
Merge "Fix status-and-diag after BP migration"
Michael Vorburger [Thu, 16 Mar 2017 10:47:02 +0000 (11:47 +0100)]
TestIMdsalApiManager methods must all be synchronized
Change-Id: Ic01effdf66a27dde6ed773267372000924119961
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 17 Mar 2017 05:36:11 +0000 (05:36 +0000)]
Merge "Bug 7864: Specified Id key does not exist in id pool vpnservices"
Faseela K [Fri, 17 Mar 2017 01:55:04 +0000 (01:55 +0000)]
Merge "Cleanup and correct two small equals bugs"
Faseela K [Fri, 10 Mar 2017 07:57:12 +0000 (13:27 +0530)]
Harden BFD configuration parameters
When tunnels are configured with BFD enabled,
enabling forwarding_if_rx=true, so that tunnel monitoring can be
optimized. OVS uses existing traffic for tunnel monitoring, instead
of BFD, when tunnel carries traffic, if this config is enabled.
This way datapath can be optimized
Change-Id: Ia0205eb0ce3fc9c51726c56b684956b2e18dc312
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Sam Hague [Thu, 16 Mar 2017 17:11:25 +0000 (17:11 +0000)]
Merge "Yang model changes for multiple VxLAN tunnel support"
David Suarez [Thu, 16 Mar 2017 16:19:55 +0000 (16:19 +0000)]
Merge "Fix broken hashCode & equals in FlowEntity related classes"
Shashidhar Raja [Wed, 15 Mar 2017 13:54:26 +0000 (19:24 +0530)]
AsyncEventsWaiter support for DataStoreJobCoordinator
Change-Id: I6397b805685cb423b3fefd466c489051de9e62cb
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Faseela K [Thu, 16 Mar 2017 14:49:16 +0000 (14:49 +0000)]
Merge "To move Tep's from not hosted transport zone to transport zone."
Faseela K [Thu, 16 Mar 2017 14:42:48 +0000 (14:42 +0000)]
Merge "ITM performance improvements in a scale setup"
Tali [Sun, 12 Feb 2017 15:54:10 +0000 (17:54 +0200)]
Yang model changes for multiple VxLAN tunnel support
NB: This code must be submitted together with netvirt patch
https://git.opendaylight.org/gerrit/52506
Change-Id: I5d2d36013ee74488189bd9270b6f0b0a9c9a2e14
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Thu, 16 Mar 2017 11:13:11 +0000 (12:13 +0100)]
Fix broken hashCode & equals in FlowEntity related classes
This in turn then fixes TestIMdsalApiManager assertFlowsInAnyOrder bug.
Change includes new TestIMdsalApiManagerTest non-regression test.
Also includes missing toString() - not directly related, but useful.
Change-Id: I92ec5948a91ecd41eaa75777d44545fc7adc142a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
eswanit [Fri, 10 Mar 2017 04:04:04 +0000 (09:34 +0530)]
Bug 7864: Specified Id key does not exist in id pool vpnservices
Id entry was not getting updated after allocation. This is fixed by
increasing latch wait time.
If the releaseId is called twice, then IdManagerException was thrown
since Id was not present. This is fixed by ignoring throwing an exception
if Id doesn't exist when releaseId is called the second time.
Change-Id: I8d8da8963f4509c9771795630662596ad2c528f9
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Faseela K [Thu, 16 Mar 2017 10:40:10 +0000 (10:40 +0000)]
Merge "Clean-up of unwanted ERROR logs"
Faseela K [Thu, 16 Mar 2017 09:49:36 +0000 (09:49 +0000)]
Merge "Remove deprecated yang models and rpcs"
Faseela K [Thu, 16 Mar 2017 09:11:18 +0000 (09:11 +0000)]
Merge "Adding API to support bucket addition/deletion"
Hema Gopalakrishnan [Mon, 20 Feb 2017 07:37:55 +0000 (13:07 +0530)]
ITM performance improvements in a scale setup
Introducing DJC for InterfaceStateListener
Introducing DJC for ItmTunnelEventListener
Changed the ItmTunnelEventListener to listen on StateTunnelList
Moved the DS read in ItmEventListener to read from cache
Introduced Batching for few ITM operations
Addressed review comments
Fixed UT failure
Change-Id: I5d60d8c2250a699436a0abd4770fff12465ac2ac
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Michael Vorburger [Wed, 15 Mar 2017 09:38:32 +0000 (10:38 +0100)]
InstructionInfo implementations made valid beans (XtendBeanGenerator)
This is required to unblock the (now) failing *AclServiceImplTest/s in
c/53002. The IllegalStateException seen there were due to the
InstructionInfo implementations not having been valid beans; this caused
XtendBeanGenerator to be unable to get their fields values.
Change-Id: I0549a7faa306afdf8f95908efa3eb561185f81a4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 15 Mar 2017 15:38:23 +0000 (15:38 +0000)]
Merge "Spec for Counter Framework bundle"
Alon Kochba [Tue, 14 Mar 2017 14:10:02 +0000 (16:10 +0200)]
Cleanup and correct two small equals bugs
Change-Id: I06f9f943294de081390bbcb4ad3ea7cf2b8ae3ea
Signed-off-by: Alon Kochba <alonko@hpe.com>
Faseela K [Wed, 15 Mar 2017 10:57:26 +0000 (16:27 +0530)]
Remove deprecated yang models and rpcs
interface-manager has some yang models which have been
deprecated from Beryllium time-frame, but still not removed
from the yangs.
Change-Id: I6fc72c5fdba62bcdccf5b9c5609e9c2516e9b79d
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 8 Mar 2017 05:18:43 +0000 (10:48 +0530)]
Fix status-and-diag after BP migration
The code for registering service-status through MBean was broken after
BP migration of interface-manager and ITM, since the code got removed.
Change-Id: Ie268473e41fcdfa6fd565ae392738c63f82f0f6a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 14 Mar 2017 18:41:25 +0000 (00:11 +0530)]
Clean-up of unwanted ERROR logs
Some of the ERROR logs are coming in the standard call flow, and is
expected to fail, hence making them debugs
Change-Id: I34582bd41a733309eeeb6c442c6671aec77d7151
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Nishchya Gupta [Mon, 19 Sep 2016 09:22:51 +0000 (14:52 +0530)]
To move Tep's from not hosted transport zone to transport zone.
-If teps are present under some transport zone in Not hosted transport zone and similar transport
zone is created by NBI, then move the tep from not hosted list to transport
zone list
Testcases:-
1.Add some teps to not hosted transport zone with some transport
zone(which is not yet present in Transport zone)
2.Create the same name transport zone from NBI.
3.Validate that teps should move from not hosted list to Transport zone
list.
Change-Id: I7d17d1c1608b025efaa36ede007825fa657073d5
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Michael Vorburger [Wed, 15 Feb 2017 22:47:30 +0000 (23:47 +0100)]
Fix exception & null handling in AbstractAlivenessProtocolHandler
Change-Id: Iea86daecda9a38d855c76a425d8dbc3675076c68
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Kency Kurian [Tue, 7 Mar 2017 07:33:38 +0000 (13:03 +0530)]
Adding API to support bucket addition/deletion
Introduced new API in mdsal using which we can add or remove a backet from
the group.
With this application need not construct the entire group if it knows the
bucketId.
Have tested and made sure that the groups are getting updated properly
when this API is used.
Change-Id: I5b07da503bb33d39adf7bc4d7cdc53122ce36f03
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Vishal Thapar [Mon, 13 Mar 2017 12:38:49 +0000 (12:38 +0000)]
Merge "Modify ACL table numbers for remote acl indirection"
Stephen Kitt [Wed, 22 Feb 2017 16:48:55 +0000 (17:48 +0100)]
NxMatchInfo redesign
Change-Id: Iae27c287dae8d9fe400e07d1429cd20bc94a14c6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
David [Sun, 12 Mar 2017 18:23:17 +0000 (19:23 +0100)]
Remove unnecessary casts
Remove unnecessary casts in the call to newReleaseId.
Change-Id: If611f52d403c26d4a145edccced3b6d1aff89ded
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Sat, 11 Mar 2017 09:45:19 +0000 (09:45 +0000)]
Merge "Handling RACE conditions in bind/unbind service"
Shashidhar Raja [Fri, 10 Mar 2017 13:37:55 +0000 (19:07 +0530)]
Updated TestIMdsalApiManager.java to support installFlow() with
CheckedFuture return value
Change-Id: I8c15af6607f83a08354520872e4a5ff0ea16d2bf
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Michael Vorburger [Wed, 1 Mar 2017 02:11:55 +0000 (03:11 +0100)]
Improve exception message in NWUtil.isIpv4Address(String)
Change-Id: I590ee8c2e23685d7955ad31275d7ff04fb1aa2d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 7 Mar 2017 08:24:29 +0000 (13:54 +0530)]
Handling RACE conditions in bind/unbind service
There are race conditions seen while binding/unbinding services,
due to the configlistener and statelistener being executed parallelly.
Avoiding this by adding a new service_binding_entity, and processing
service binding only on the entity owner.
Removing batching of interface-child-info as it is causing issues in
clustered tests
Change-Id: I35ed95fe99878fcbde757cd61880400832b30220
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vivek Srivastava [Thu, 9 Mar 2017 15:59:39 +0000 (15:59 +0000)]
Merge "Spec to support load balancing and high availability of multiple VxLAN tunnels"
Alon Kochba [Thu, 23 Feb 2017 14:02:32 +0000 (16:02 +0200)]
Modify ACL table numbers for remote acl indirection
Change table numbers of ingress ACL, add another table
to each ACL service and add a metadata match for the
ACL service, in preparation for remote_acl_indirection
changes.
This patch must be merged combined with
https://git.opendaylight.org/gerrit/#/c/52215/
due to changes in ACL tables naming.
Change-Id: I597f705c68f898a2efa03b85182ab28618ffb0f7
Signed-off-by: Alon Kochba <alonko@hpe.com>
Vishal Thapar [Thu, 9 Mar 2017 12:21:03 +0000 (12:21 +0000)]
Merge "Improve scale of AsyncXListenerBase"
Michael Vorburger [Wed, 8 Mar 2017 01:13:46 +0000 (01:13 +0000)]
Merge "Fix (some) unlogged Thread death uncaught exceptions, now logged"
Michael Vorburger [Fri, 17 Feb 2017 20:57:06 +0000 (21:57 +0100)]
Fix (some) unlogged Thread death uncaught exceptions, now logged
see also email list thread "Re: [netvirt-dev] [genius-dev] Exceptions
that don't even reach the log"
This doesn't actually fix any such exceptions, but it makes them get
properly logged, to the logging subsystem, instead of only appear on the
console.
Change-Id: If08408c103dd7a0520fc95ce2da632d67ee9c6a1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 8 Mar 2017 00:09:06 +0000 (00:09 +0000)]
Merge "Add missing <name> fields for pom.xml files"
Michael Vorburger [Fri, 17 Feb 2017 19:32:33 +0000 (20:32 +0100)]
AlivenessMonitor final clean-up, remove unneeded dep & service setters
and use constructor for initializing more fields (some already are),
instead of start() method, which prevents use of final fields.
Change-Id: I7a62629ec4c78d00987b03bbd176ac148f676af4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David [Thu, 2 Mar 2017 23:33:46 +0000 (00:33 +0100)]
Fix issues related to checkstyle compliance in module mdsalutil-impl
Fix issues related to checkstyle compliance in module
mdsalutil-impl:
- Copyright sections
- Line lengths
- Order imports
- Formatting
- Declaration of constants: name, modifiers
- Rename variables
- Exception catching
- Move declaration of variables closer to their use
- Remove unused variables
- Enforcement in pom.xml
There is more cleanup to be done, apart from checkstyle, I'll rise a
separate commit.
Change-Id: I91848d2ca07e404787489c15040dfa8983594692
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Faseela K [Mon, 6 Mar 2017 18:04:26 +0000 (18:04 +0000)]
Merge "Bind/Unbind Service should work irrespective of Port Status"
Guy Sela [Wed, 15 Feb 2017 15:35:24 +0000 (17:35 +0200)]
Improve scale of AsyncXListenerBase
Convert single static thread pool for all listeners to thread pool per
listener.
Deprecate the base classes.
Change-Id: I0d86b2c017ed443db3093dc81f124677e1cf0449
Signed-off-by: Guy Sela <guy.sela@hpe.com>
Faseela K [Mon, 6 Mar 2017 07:34:23 +0000 (13:04 +0530)]
Bind/Unbind Service should work irrespective of Port Status
- Removing port status check during bind-service
- Clean up of bind/unbind code path
Change-Id: I7f4cb9749a40325826ce3c8f29b43635f5202151
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Thu, 2 Mar 2017 12:24:51 +0000 (13:24 +0100)]
Fix missing alivenessmonitor-impl-protocols in features.xml
Somehow forgot to uncomment this in c/52020
(
a202894405787214fd9271902af55525b1324f09) - and nobody noticed?! (Not
in code review, and no failing CSIT - our processes are broken...)
Change-Id: Ic47c721c3468619e55cc888c29abcafd259486d8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vivek Srivastava [Mon, 6 Mar 2017 05:20:44 +0000 (05:20 +0000)]
Merge "Add support for IPv6 VXLAN tunnels"
Faseela K [Sun, 5 Mar 2017 17:27:09 +0000 (17:27 +0000)]
Merge "Enhancing interface-manager logging"
Faseela K [Fri, 3 Mar 2017 19:35:13 +0000 (01:05 +0530)]
Enhancing interface-manager logging
Change-Id: I47fc2341a3a1ba2513de9272b40840433f221e88
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Aswin Suryanarayanan [Thu, 2 Mar 2017 13:34:39 +0000 (19:04 +0530)]
Added set_field action for meta data.
Change-Id: I5e50bf74504c731420a9d762081f644e2d488f79
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Vivek Srivastava [Fri, 3 Mar 2017 11:41:12 +0000 (11:41 +0000)]
Merge "Minor: Clean up fcapsmanager/countermanager POM"
Viji J [Mon, 23 Jan 2017 15:34:47 +0000 (21:04 +0530)]
Spec for Counter Framework bundle
Change-Id: I923908bc901c2aa931294b8748118948b187123f
Signed-off-by: Viji J <viji.j@ericsson.com>
Thanh Ha [Fri, 3 Mar 2017 01:33:53 +0000 (20:33 -0500)]
Add missing <name> fields for pom.xml files
This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:
ODL :: <groupId> :: <artifactId>
This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522
Change-Id: I8874717d4c30d835ef1233344148a558401aed88
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Thu, 2 Mar 2017 15:26:52 +0000 (15:26 +0000)]
Merge "TestIMdsalApiManager assertFlowsInAnyOrder LOG.warn"
Edwin Anthony [Thu, 23 Feb 2017 11:11:21 +0000 (16:41 +0530)]
Interfacemanager blueprint migration
Change-Id: I4b3f7ea54ef290546a4e7e031a0f3b5b3023c7aa
Signed-off-by: Edwin Anthony <n.edwin.anthony@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
David [Wed, 22 Feb 2017 17:39:59 +0000 (18:39 +0100)]
Migrate mdsalutil-impl module to blueprint
Second approach (first one was [1]) to migrate the module
mdsalutil-impl to blueprint after the patch [2] that breaks some cyclic
dependencies.
[1] https://git.opendaylight.org/gerrit/#/c/48317/
[2] https://git.opendaylight.org/gerrit/#/c/52020/
I couldn't manage to get it pass the SFT locally, but I want you to
review it so that I can get a clue on how to progress it. I tried to
make as few as possible changes (it is not checkstyle compliant, etc.)
to keep it focused.
Change-Id: Ib83ce98bde9d113f6be02ae72e0ea55d17740f3c
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Faseela K [Wed, 1 Mar 2017 16:43:23 +0000 (16:43 +0000)]
Merge "Adding job retries for DJC bind/unbind service jobs"
Tali [Sun, 22 Jan 2017 17:38:36 +0000 (19:38 +0200)]
Spec to support load balancing and high availability of multiple VxLAN tunnels
Change-Id: Id608d4007a7be8419380314f27c40f8f8ff06ecb
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Wed, 1 Mar 2017 11:56:08 +0000 (12:56 +0100)]
TestIMdsalApiManager assertFlowsInAnyOrder LOG.warn
based on the discussion in
https://git.opendaylight.org/gerrit/#/c/50467/
Change-Id: Iefe24270d1861e2eddc12bdec577cb14591f429f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Wed, 1 Mar 2017 07:41:32 +0000 (13:11 +0530)]
Adding job retries for DJC bind/unbind service jobs
Change-Id: Id581cd6b1186287a380ce4432f3326c51475527b
Signed-off-by: Faseela K <faseela.k@ericsson.com>