l2switch.git
2 weeks agoMigrate addresstracker notification integration 03/112003/3 master
Robert Varga [Wed, 5 Jun 2024 10:52:48 +0000 (12:52 +0200)]
Migrate addresstracker notification integration

Do not use generated interface and use NotificationService.Listener
instead.

Change-Id: Iccac559d0fa4b342c976cf9790eb55a94e318af0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to 2023.03 Argon SR3 01/112001/3
Robert Varga [Wed, 5 Jun 2024 10:18:45 +0000 (12:18 +0200)]
Update upstreams to 2023.03 Argon SR3

Bump upstreams to:
- odlparent-12.0.10
- mdsal-11.0.15
- controller-7.0.11
- netconf-5.0.9
- openflowplugin-0.16.3

Change-Id: I33d111ccf18dd0469d9aea9a3330ac508cbba835
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to 2023.03 Argon GA 00/112000/1
Robert Varga [Wed, 5 Jun 2024 10:04:18 +0000 (12:04 +0200)]
Update upstreams to 2023.03 Argon GA

Bump upstreams to:
- odlparent-12.0.3
- mdsal-11.0.7
- controller-7.0.4
- netconf-5.0.4
- openflowplugin-0.16.0

Change-Id: I6d57276761c76e72365e874c119801fade6fe2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoDo not use odl:type=default 99/111999/1
Robert Varga [Wed, 5 Jun 2024 10:13:38 +0000 (12:13 +0200)]
Do not use odl:type=default

We have a single source of DataBroker, hence we should not be specifying
the odl:type property -- it is going away anyway.

Change-Id: Ideccc19b82c4d80eafdd0800f9fb808ce5fed415
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to 2022.09 Chlorine SR3 96/111996/4
Robert Varga [Wed, 5 Jun 2024 08:52:47 +0000 (10:52 +0200)]
Update upstreams to 2022.09 Chlorine SR3

Bump upstreams to:
- odlparent-11.0.6
- mdsal-10.0.8
- controller-6.0.9
- netconf-4.0.8
- openflowplugin-0.15.3

Change-Id: Iae7b64ed9935d5f4948152cfab95e2b4153e6418
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to 2022.09 Chlorine GA 95/111995/5
Robert Varga [Wed, 5 Jun 2024 08:45:12 +0000 (10:45 +0200)]
Update upstreams to 2022.09 Chlorine GA

Bump upstreams to:
- odlparent-11.0.1
- mdsal-10.0.2
- controller-6.0.2
- netconf-4.0.2
- openflowplugin-0.15.0

Also declares jung2 artifacts and lets them be pulled in into
loopremover feature.

Also use IetfInetUtil.ipAddressFor() instead instead of
IpAddressBuilder.getDefaultInstance().

Change-Id: Ic004529ffc3fa88db2e87dcb6366e671a67d2141
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoBump upstreams to Sulfur SR3 94/111994/1
Robert Varga [Wed, 5 Jun 2024 08:31:12 +0000 (10:31 +0200)]
Bump upstreams to Sulfur SR3

Bump upstreams to:
- odlparent-10.0.5
- mdsal-9.0.7
- controller-5.0.8
- netconf-3.0.8
- openflowplugin-0.14.3

Change-Id: Idf9bd58f0846e4de50abf78118fa49bc3c435289
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to Sulfur GA 91/111991/2
Robert Varga [Wed, 5 Jun 2024 08:06:38 +0000 (10:06 +0200)]
Update upstreams to Sulfur GA

Bump upstreams to:
- odlparent-10.0.0
- mdsal-9.0.2
- controller-5.0.3
- netconf-3.0.2
- openflowplugin-0.14.0

Also fixes up invalid InstanceIdentifier instantiations.

Change-Id: I2e7e8ababc5252c0799dd4246059bc954beedacf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoMigrate Matchers.any() 93/111993/1
Robert Varga [Wed, 5 Jun 2024 08:27:01 +0000 (10:27 +0200)]
Migrate Matchers.any()

Mockito is moving this method to ArgumentMatchers, adjust accordingly.

Change-Id: Iaece150813df7901c35c51d85e494e4a5c465be0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to Phosphorus SR3 90/111990/2
Robert Varga [Wed, 5 Jun 2024 08:02:24 +0000 (10:02 +0200)]
Update upstreams to Phosphorus SR3

Bump upstreams to:
- odlparent-9.0.15
- mdsal-8.0.15
- controller-4.0.12
- netconf-2.0.16
- openflowplugin-0.13.3

Change-Id: I76afd7ceb79995c4a8b13a8d8241019c05986ddb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoUpdate upstreams to Phosphorus GA 36/110236/15
Robert Varga [Wed, 14 Feb 2024 19:14:10 +0000 (20:14 +0100)]
Update upstreams to Phosphorus GA

Bump upstreams to:
- odlparent-9.0.6
- mdsal-8.0.5
- controller-4.0.3
- netconf-2.0.5
- openflowplugin-0.13.0

Change-Id: I096db882c9e94b9cdcd4bcdd5ddfa72f8ff4ba47
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoSuppress SpotBugs warnings 92/111992/1
Robert Varga [Wed, 5 Jun 2024 08:12:11 +0000 (10:12 +0200)]
Suppress SpotBugs warnings

Upgraded SpotBugs is catching a few violations, this fixes them up.

Change-Id: Ia73e2d68eef1a1983963b20b2aa0e880fa341b70
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 weeks agoMigrate InventoryReaderTest 89/111989/1
Robert Varga [Wed, 5 Jun 2024 08:00:20 +0000 (10:00 +0200)]
Migrate InventoryReaderTest

Use BindingMap.of() instead of a List.

Change-Id: I1752a9cb52b4a19ea3960a07d30ecea6f24fa04b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 weeks agoReconcile packet.yang definition of fields 44/111544/3
David Arjona [Sat, 27 Apr 2024 00:58:36 +0000 (20:58 -0400)]
Reconcile packet.yang definition of fields

The payload-offset and payload-length leafs at the packet-fields
group has been set to the uint32 type.

Methods that use this definition have been modified to support
this type.

Change-Id: I86d1d5c4462db2d6418b521c23dc9c567e810cd7
Signed-off-by: David Arjona <darjona@yahoo.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
2 months agoRemove compatibility methods at BitBufferHelper 98/111298/1
David Arjona [Fri, 5 Apr 2024 23:59:47 +0000 (19:59 -0400)]
Remove compatibility methods at BitBufferHelper

The BitBufferHelper methods getShort, getInt and getLong return a
short, int and long respectively. They have been replaced with
equivalent methods that return a Uint8, Uint16 or Uint32 types.
The following sections explain these replacements:

1. getShort
Code that required a Uint8 type instead of a short, started using
a new method "getUint8(byte[])". However a method that required to
collect the first N bits, where N is 16>N>8, started using a new
method "getUint16(byte[], int)".

2. getInt
Code that required a Uint16 type instead of an int, started using
a new method "getUint16(byte[])". However methods that required to
test data in 2 bytes, started using the "getUint16(byte[], int)"
method.

3. getLong
Code that required a Uint32 type instead of a long, started using
a new method "getUint32(byte[])".

Signed-off-by: David Arjona <darjona@yahoo.com>
Change-Id: I5b04e8f06b8c23fdd2c3294fc9f5386f6b8b7928

3 months agoClean up InitialFlowWriter 12/110812/2
Robert Varga [Sun, 17 Mar 2024 14:21:20 +0000 (15:21 +0100)]
Clean up InitialFlowWriter

We have verbose indentation here, reduce it. While we are at it:
- use proper Builder flow to build DTOs, eliminating a ton of intermediate
  local variables
- make method arguments final
- use local variable type inference
- guard the InitialFlowWriterProcessor.nodeIds != null invariant

Change-Id: I140fb0ac63d4a20c5ea5a3ad4213f3ebd83240d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoRemove compatibility methods at main-impl 84/110784/2
David Arjona [Sun, 17 Mar 2024 04:40:15 +0000 (00:40 -0400)]
Remove compatibility methods at main-impl

Two "ImmutableList" have been switched to "BindingMap". One short,
three int and one BigInteger type variables have been converted to
Uint8, Uint16 and Uint64 respectively at InitialFlowWriter.java.

Similarly, two "ImmutableList" have been switched to "BindingMap".
One short, three int and one BigInteger type variables have been
converted to Uint8, Uint16 and Uint64 respectively at
FlowWriterServiceImpl.java.

Java conversions have been removed from L2SwitchMainProvider.java.

Signed-off-by: David Arjona <darjona@yahoo.com>
Change-Id: I220d3dd9ced480d835c56b3b8166039fa0535310
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 months agoRemove compatibility methods at hosttracker-impl 45/110345/3
David Arjona [Sun, 25 Feb 2024 19:12:39 +0000 (14:12 -0500)]
Remove compatibility methods at hosttracker-impl

Three List type variables have been converted to Map type at file
Host.java.

One BigInteger type variable has been converted to Uint64 type at
file SimpleAddressObserver.java. Mathematical operations using a
BigInteger variable are still used because there are no equivalent
methods for Uint64.

Change-Id: I4f6e704be94f744f9d00d476f2628212fb02bf79
Signed-off-by: David Arjona <darjona@yahoo.com>
4 months agoAdd feature-parent 51/110251/1
Robert Varga [Thu, 15 Feb 2024 08:18:42 +0000 (09:18 +0100)]
Add feature-parent

We have a number of features which duplicate their definitions.
Introduce a parent pom to host them.

Change-Id: I4c27b3f8b77d77465803245398d50df637fe845b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoDo not override version 50/110250/1
Robert Varga [Thu, 15 Feb 2024 08:12:27 +0000 (09:12 +0100)]
Do not override version

addresstracker-model's version is set in artifacts, hence we do not need
to specify it again.

Change-Id: If0695c652f67a8330b3bd104604741aa730b4664
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoClean up InitialFlowWriterTest 49/110249/1
Robert Varga [Thu, 15 Feb 2024 08:00:03 +0000 (09:00 +0100)]
Clean up InitialFlowWriterTest

Clean up mockito usage and use List.of() instead of
Collections.singletonList().

Change-Id: Ibf90a88fae66b2ec277760604e7321d976e361e0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMigrate ProactiveFloodFlowWriterTest 48/110248/1
Robert Varga [Thu, 15 Feb 2024 07:59:21 +0000 (08:59 +0100)]
Migrate ProactiveFloodFlowWriterTest

Clean up mockito usage and use BindingMap.of().

Change-Id: I1189897bc1d01c52097deb74418052192c5a24bb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoImprove InitialFlowWriter 47/110247/1
Robert Varga [Thu, 15 Feb 2024 07:56:24 +0000 (08:56 +0100)]
Improve InitialFlowWriter

Pick up the path only after checking the modification path.

Change-Id: Ibe17460e2b3620503cf04805495ffdc6fa67c86e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMerge "add comment of ipAddress in addAddress function"
Robert Varga [Wed, 14 Feb 2024 22:54:16 +0000 (22:54 +0000)]
Merge "add comment of ipAddress in addAddress function"

4 months agoMerge "add the comment for ipAddress addAddress function"
Robert Varga [Wed, 14 Feb 2024 22:53:16 +0000 (22:53 +0000)]
Merge "add the comment for ipAddress addAddress function"

4 months agoMigrate flow writers 46/110246/1
Robert Varga [Wed, 14 Feb 2024 22:34:53 +0000 (23:34 +0100)]
Migrate flow writers

Use Uint types and BindingMap instead of widened types and lists. Also
fix hybrid mode, which would not work due to 'order' being set to zero
for both actions.

Change-Id: Iea887c5080da233d5692ec3d89870148529b8946
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMigrate InventoryReaderTest 45/110245/3
Robert Varga [Wed, 14 Feb 2024 21:49:28 +0000 (22:49 +0100)]
Migrate InventoryReaderTest

- use MockitoJUnitRunner
- use BindingMap.of() instead of lists
- use ArgumentMatchers.any()
- improve test assertions

Change-Id: I0d8b0494cccb3b5c6f5e5a9b20f4ed417b0a7f4b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMerge "Do not use JdkFutureAdapters"
Robert Varga [Wed, 14 Feb 2024 21:38:09 +0000 (21:38 +0000)]
Merge "Do not use JdkFutureAdapters"

4 months agoadd comment of ipAddress in addAddress function 52/39052/2
wenjie yan [Wed, 18 May 2016 15:27:55 +0000 (23:27 +0800)]
add comment of ipAddress in addAddress function

Change-Id: Ieb49f4a1c2d7e51ff2ca01394443652cf3ae4bb8
Signed-off-by: wenjie yan <yanwenjie911@126.com>
4 months agoadd the comment for ipAddress addAddress function 77/38977/2
wenjie yan [Mon, 16 May 2016 15:07:38 +0000 (23:07 +0800)]
add the comment for ipAddress addAddress function

Change-Id: I3102b3f8f58f86693697bd49576c3c8456da6e98
Signed-off-by: wenjie yan <yanwenjie911@126.com>
4 months agoDo not use JdkFutureAdapters 44/110244/2
Robert Varga [Wed, 14 Feb 2024 21:23:00 +0000 (22:23 +0100)]
Do not use JdkFutureAdapters

RPCs are already returning ListenableFuture, there is no point in
bringing JdkFutureAdapters to the party.

Change-Id: I21f94ead5a6b4bd144a164206b25f1a9112637d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMigrate loopremover to use maps 42/110242/3
Robert Varga [Wed, 14 Feb 2024 20:48:01 +0000 (21:48 +0100)]
Migrate loopremover to use maps

Loopremover is only using single-element lists where it should be using
a map. Switch to using BindingMap.of(element), which does the right
thing.

Change-Id: Ib5ff55d61f0587047e4eb2b15b209b6a6e214685
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUse Uint types in loopremover 40/110240/4
Robert Varga [Wed, 14 Feb 2024 20:44:11 +0000 (21:44 +0100)]
Use Uint types in loopremover

We have unnecessary round-trip through widened types, eliminate it in
favor of using Uint8/Uint16.

Change-Id: Ieac36c87921b93900cf8bceeca8dd7b6c4b4463d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoRemove trailing comments 43/110243/1
Robert Varga [Wed, 14 Feb 2024 21:14:47 +0000 (22:14 +0100)]
Remove trailing comments

The // at the end of the line was an attempt to get Eclipse auto-format
to behave with fluent builders. SonarCloud does not like them for
obvious reasons. Remove this clutter.

Change-Id: I0e099790ffe1228da2036e073a4dc3cc39f23bba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoModernize TopologyLinkDataChangeHandlerTest a bit 41/110241/1
Robert Varga [Wed, 14 Feb 2024 20:51:45 +0000 (21:51 +0100)]
Modernize TopologyLinkDataChangeHandlerTest a bit

Use List.of() instead of Collections.singletonList(). Also use
ArgumentMatchers.anyList() to fix a warning.

Change-Id: Id86b0c7193244761edf487dfea99f0edd560bfd7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoFix warnings in NetworkGraphImplTest 39/110239/1
Robert Varga [Wed, 14 Feb 2024 20:43:16 +0000 (21:43 +0100)]
Fix warnings in NetworkGraphImplTest

Use diamond notation to eliminate a warnings about rendundant type
specification.

Change-Id: I7c82cb8bde3dd8cff0cdb2caccf5ec40e082d739
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoMigrate use of boolean getters 38/110238/1
Robert Varga [Wed, 14 Feb 2024 20:29:39 +0000 (21:29 +0100)]
Migrate use of boolean getters

isFoo() is a legacy construct, superseded by the regular getFoo()
pattern. Migrate callers.

Change-Id: I686524b5b7886865d2b987098cca59b81c1cef6c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUpdate upstreams to Silicon SR4 35/110235/2
Robert Varga [Wed, 14 Feb 2024 19:10:09 +0000 (20:10 +0100)]
Update upstreams to Silicon SR4

Bump upstreams to:
- odlparent-8.1.9
- mdsal-7.0.14
- controller-3.0.16
- netconf-1.13.8
- openflowplugin-0.12.4

Change-Id: Ib265779b5f7266f1fbc120424d7fbf5b0bb45fa4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoRemove unneeded dependencies 37/110237/1
Robert Varga [Wed, 14 Feb 2024 19:32:22 +0000 (20:32 +0100)]
Remove unneeded dependencies

- org.osgi.core is not used anywhere
- slf4j-api is already declared in odlparent
- slf4j-simple is already declared in odlparent for tests
- junit/mockito are already declared iin odlparent for tests

Change-Id: I5e2879b04229ca588b4c2967d7bfdabc056636c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUpdate upstreams to Silicon GA 51/110151/5
David Arjona [Mon, 5 Feb 2024 18:05:10 +0000 (13:05 -0500)]
Update upstreams to Silicon GA

Bump upstreams to:
- odlparent-8.1.1
- mdsal-7.0.6
- controller-3.0.7
- netconf-1.13.1
- openflowplugin-0.12.0

Also fix a javadoc warning and update tests to correctly set
connector/node ID, so that the corresponding key can be formed.

Change-Id: Ic1da101145ca844e3f63c3b787bf845ab379ce50
Signed-off-by: David Arjona <darjona@yahoo.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoFix InventoryReaderTest 34/110234/1
Robert Varga [Wed, 14 Feb 2024 19:04:38 +0000 (20:04 +0100)]
Fix InventoryReaderTest

The Aluminium patch slipped past a raw type and removed the second
address. Fix that up.

Change-Id: I27290436cf9403da39244f2a00a9fce85678d1b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoBump upstreams to Aluminium SR4 33/110233/1
Robert Varga [Wed, 14 Feb 2024 18:04:02 +0000 (19:04 +0100)]
Bump upstreams to Aluminium SR4

Dump upstreams to:
- odlparent-7.0.10
- mdsal-6.0.10
- controller-2.0.8
- netconf-1.12.4
- openflowplugin-0.11.4

Change-Id: I62e5e0ee925245a2acc7986919856ae6fdb9825b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 months agoUpdate to work with Aluminium GA 97/90197/40
Matt McCormack [Tue, 2 Jun 2020 01:59:49 +0000 (20:59 -0500)]
Update to work with Aluminium GA

This updates pointers to Aluminum versions, adding porting changes.

We disable the odl-l2switch-ui feature, as we do not have dlux
available. It should be pretty easy to add back.

Places where we need to change logic due to Binding mapping having been
changed receive a bit more substantial changes in that:
- we use try-with-resources blocks for read transactions
- dispatch logic is updated to reduce unnecessary nesting
- a few places are also updated to use Uint types

Change-Id: Id93b64a0b14de61ca1b0a455d386ce70c49f5a5f
Signed-off-by: Matt McCormack <mmccorm1@andrew.cmu.edu>
Signed-off-by: David Arjona <darjona@yahoo.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoBump versions to Sodium SR4 30/95730/3
Robert Varga [Fri, 9 Apr 2021 12:27:40 +0000 (14:27 +0200)]
Bump versions to Sodium SR4

Update upstream version to Sodium SR4. This requires solving the
long-standing modeling problem where we have overlapping fields
between two cases.

Change-Id: Ia67289b16531976d7fed81d90abd26c866593f89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoUpdate to work on Sodium SR1 09/85209/5
Robert Varga [Fri, 18 Oct 2019 14:42:31 +0000 (16:42 +0200)]
Update to work on Sodium SR1

This updates pointers to Sodium SR1 versions, adding porting
changes.

We disable the odl-l2switch-ui feature, as we do not have dlux
available. It should be pretty easy to add back.

Change-Id: I170395794b26ead35a2d26f457ecae776de2cb4e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBump to odlparent 3.1.0 and yangtools 2.0.3 78/69878/1
Stephen Kitt [Thu, 22 Mar 2018 17:24:28 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: Ia006d67867ccd242efba6bd811bd21e258e7df9f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoBump versions by x.(y+1).z for next dev cycle 38/68738/1
Anil Belur [Mon, 26 Feb 2018 07:41:43 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: I0104cace9d517072f90ae14ce43f77f4188d1447
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoMerge "Fix FindBugs violations and enable enforcement"
Evan Zeller [Tue, 13 Feb 2018 17:32:53 +0000 (17:32 +0000)]
Merge "Fix FindBugs violations and enable enforcement"

6 years agoL2SWITCH-97: export packages that are not exported in the jung jars 07/67307/3
Evan Zeller [Thu, 18 Jan 2018 22:01:56 +0000 (14:01 -0800)]
L2SWITCH-97: export packages that are not exported in the jung jars

Change-Id: I77d72bb326b9a49251c536e8bf77997aa96565ee
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
6 years agoFix FindBugs violations and enable enforcement 39/67639/3
Tom Pantelis [Sat, 27 Jan 2018 16:30:09 +0000 (11:30 -0500)]
Fix FindBugs violations and enable enforcement

- Method call passes null for non-null parameter
- Method ignores exceptional return value
- Boxing/unboxing to parse a primitive
- Redundant nullcheck of value known to be non-null
- Constructor invokes Thread.start()
- Load of known null value

Change-Id: I3cf3c48306c1ade906fe51b5c0492f5a669a2d43
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoFix checkstyle violations 38/67638/1
Tom Pantelis [Sat, 27 Jan 2018 14:11:10 +0000 (09:11 -0500)]
Fix checkstyle violations

Change-Id: I07087441e114e802d932ab71261719139efd125f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoPOM cleanup 23/67623/2
Tom Pantelis [Fri, 26 Jan 2018 18:16:28 +0000 (13:16 -0500)]
POM cleanup

- derived l2switch-parent from binding-parent to paick up yangtools
  definitions.

- removed yangtools.version and other properties no longer needed in
  l2switch-parent pom.

- removed unnecesrary yang-maven-plugin definitions.

Change-Id: I0a0b07f72e5a53fc09f411d32af8af6ceeade6a4
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoBump yangtools to 2.0.1 14/67314/1
Luis Gomez [Thu, 18 Jan 2018 23:31:07 +0000 (15:31 -0800)]
Bump yangtools to 2.0.1

Change-Id: Ifb6a4988ae2aeed2c4ee1bb53272b61d12dbf814
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
6 years agoBump to yangtools-2.0.0 and odlparent-3.0.2 17/66517/2
Tom Pantelis [Fri, 15 Dec 2017 17:26:43 +0000 (12:26 -0500)]
Bump to yangtools-2.0.0 and odlparent-3.0.2

Change-Id: I558e42e33dee324570789b70d196dcb032331766
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoBump net.sf.jung version 11/61611/4
Robert Varga [Mon, 14 Aug 2017 13:34:35 +0000 (15:34 +0200)]
Bump net.sf.jung version

Use the version from upstream, not the old, repackaged one.

Change-Id: Icff8c3da0552cdd6ede5a54277047da56a30c759
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBump l2switch to use yangtools 1.2.0 20/63820/3
Anil Belur [Fri, 29 Sep 2017 02:22:03 +0000 (12:22 +1000)]
Bump l2switch to use yangtools 1.2.0

Jira: releng-485

Change-Id: I03bd30535d330a3236d91da165c1115ad0f5da3e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoBump odlparent 2.0.4 to 2.0.5 36/63636/1
Stephen Kitt [Wed, 27 Sep 2017 13:35:17 +0000 (15:35 +0200)]
Bump odlparent 2.0.4 to 2.0.5

Change-Id: Ifca4b21143336fb91f91ea2b0d800749101eea17
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoConvert DataChangeListeners to DataTreeChangeListeners 43/62343/2
Tom Pantelis [Sun, 27 Aug 2017 18:08:31 +0000 (14:08 -0400)]
Convert DataChangeListeners to DataTreeChangeListeners

The DataChangeListener API has been deprecated for a couple releases
with possible removal in Oxygen.

Change-Id: Ide7e2b975dedccc4afefb40e421b92bf33f69272
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoBump versions by x.(y+1).z for next dev cycle 88/61688/1
Thanh Ha [Mon, 14 Aug 2017 17:28:43 +0000 (13:28 -0400)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: I3496637ee771662e2f0b109d649c9917277d3c5b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBump odlparent 2.0.2 to 2.0.4 50/61350/2
Stephen Kitt [Tue, 8 Aug 2017 16:14:09 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4

Change-Id: Iec13f2a58b023fe4faa7173a6133a6db14bd40ea
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoBump all Odlparent dependencies to 2.0.2 90/60990/1
Vratko Polak [Tue, 1 Aug 2017 13:11:09 +0000 (15:11 +0200)]
Bump all Odlparent dependencies to 2.0.2

Change-Id: Ia0094f59379ffd3612cfff06aa80f7c8c35d5e28
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
6 years agoFix features4 -> features 49/60949/1
Thanh Ha [Mon, 31 Jul 2017 17:24:30 +0000 (13:24 -0400)]
Fix features4 -> features

Part of Karaf 4 Migration is a recommendation to rename features4
artifacts to features.

Change-Id: I01b52d826df46b52422372b579ff6ff0c7b6230e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoRemove JMXGenerator from poms 64/60664/2
Tom Pantelis [Sat, 22 Jul 2017 21:34:08 +0000 (17:34 -0400)]
Remove JMXGenerator from poms

l2switch no longer uses the config subsystem so doesn't need to
reference the JMXGenerator. Also cleaned up other unused CSS references.

Change-Id: I117643536c747342a4f5f364c8e9db9e83f32e91
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
6 years agoFix karaf pom to use features4-l2switch 29/60129/1
Donald Hunter [Mon, 10 Jul 2017 11:00:08 +0000 (12:00 +0100)]
Fix karaf pom to use features4-l2switch

Change-Id: I9dcda99017d3e78b414f038fc0d33c50fae55b3e
Signed-off-by: Donald Hunter <donaldh@cisco.com>
7 years agoMove to odlparent 2.0.0 82/59482/1
Colin Dixon [Fri, 23 Jun 2017 18:40:23 +0000 (14:40 -0400)]
Move to odlparent 2.0.0

Change-Id: I3e26e79bf535e46787360248b3bd871473656526
Signed-off-by: Colin Dixon <colin@colindixon.com>
7 years agoMigrate to odlparent 1.9.0 63/58863/1
Thanh Ha [Tue, 13 Jun 2017 20:19:41 +0000 (16:19 -0400)]
Migrate to odlparent 1.9.0

Change-Id: I267c493e256dad7965b5ed62a735c0f8676eb9fe
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoMigrate to odlparent 1.8.0-Carbon 48/58648/1
Thanh Ha [Sat, 10 Jun 2017 02:41:53 +0000 (22:41 -0400)]
Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Change-Id: Ic69a19d5ee7077f0e9d3c8d666759a79398796ad
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBUG-8568: remove reference to DataBrokerService 15/58215/1
Robert Varga [Sun, 4 Jun 2017 07:53:49 +0000 (09:53 +0200)]
BUG-8568: remove reference to DataBrokerService

This class was removed, update javadoc.

Change-Id: I5fb07762abf98973b083692c12f265f77251e277
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBump versions by x.(y+1).z for next dev cycle 02/54702/1
Anil Belur [Tue, 11 Apr 2017 01:45:40 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Icd80338cdf8a4a85bcb88bfadac06da1e77f0e04
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoBug 7624: add Karaf 4 features 63/52663/2
Stephen Kitt [Thu, 2 Mar 2017 14:49:13 +0000 (15:49 +0100)]
Bug 7624: add Karaf 4 features

Change-Id: I78d34fd067f6a829baf3a75c1a0080a76716ced2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
7 years agoBUG-6859 - Binding generator v1 refactoring 27/52927/1
Martin Ciglan [Tue, 7 Mar 2017 08:30:23 +0000 (09:30 +0100)]
BUG-6859 - Binding generator v1 refactoring

Fix compilation failure after binding generator move

Change-Id: Idc1ffceba0604a6130d2dad3abfe701a9fc1fce0
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoReplace mockito-all by mockito-core (see Bug 7662) 67/50867/2
Michael Vorburger [Mon, 23 Jan 2017 18:58:42 +0000 (19:58 +0100)]
Replace mockito-all by mockito-core (see Bug 7662)

Change-Id: Id06918021f39a64401e1ae51390877d7126fbc5c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "BUG-5222: do not pull in odl-mdsal-xsql"
Sai MarapaReddy [Tue, 31 Jan 2017 20:03:09 +0000 (20:03 +0000)]
Merge "BUG-5222: do not pull in odl-mdsal-xsql"

7 years agoRemove bad manifestLocation from maven-bundle-plugin 42/51242/1
Michael Vorburger [Tue, 31 Jan 2017 13:28:30 +0000 (14:28 +0100)]
Remove bad manifestLocation from maven-bundle-plugin

Change-Id: I0184e8a03781f40f59e2b3cfc70adb7afe9e186f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBUG-5222: do not pull in odl-mdsal-xsql 96/50396/2
Robert Varga [Fri, 13 Jan 2017 09:04:51 +0000 (10:04 +0100)]
BUG-5222: do not pull in odl-mdsal-xsql

xsql is deprecated, buggy and never was meant for production
use. Do not pull it in.

Change-Id: I138ff0cbd9541a490ea4954c5e4d49a96fa0cacc
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoReplace odl-dlux-core with odl-dluxapps-topology 97/50197/1
Daniel Malachovsky [Tue, 10 Jan 2017 14:53:52 +0000 (15:53 +0100)]
Replace odl-dlux-core with odl-dluxapps-topology

Due DLUX split, we removed odl-dlux-topology feature from odl-dlux-core.
Because your project have dependency on odl-dlux-core, i assume, you used
Topology app.

More info:
https://wiki.opendaylight.org/view/Weather#Rename_some_odl-dlux-.2A_features_to_odl-dluxapps-.2A

Change-Id: Idc542d3eacad5c18cc5ff749a2926cb415546ef4
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>
7 years agoBug 5452 - Adding comments that details the configuration. 91/49991/4
Sai MarapaReddy [Tue, 4 Oct 2016 01:52:24 +0000 (18:52 -0700)]
Bug 5452 - Adding comments that details the configuration.

Using this patch meaningful comments are added that explains
true / false setting for proactive mode configurations.

Change-Id: I0ffccb61038b8e36b94639fc6089887f21be2f93
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>

7 years agoUsing incremental numbers for initial flow can easily conflict with the flows install... 72/49672/1
Anil Vishnoi [Tue, 4 Oct 2016 01:52:24 +0000 (18:52 -0700)]
Using incremental numbers for initial flow can easily conflict with the flows installed through config data store.
To make a simple fix, this patch adds L2switch prefix with the incremental flow-id

Change-Id: Ia753387e23a8b8e3f4cd1e07fbedec374ad382a7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit 0aea1fc4d1df3b0343e080af8ec71ae94cf1ff3a)

7 years agoBug 6655 - arphandler unable to flood arp packet 01/46701/1
Ye xu [Sun, 9 Oct 2016 09:22:03 +0000 (17:22 +0800)]
Bug 6655 - arphandler unable to flood arp packet

Change-Id: I637edb6c9b5a975f8e7c041ae5beb8c1a794046d
Signed-off-by: Ye xu <ye.xu1@zte.com.cn>
7 years agoBug 6278: Switch to use odlparent's karaf-parent 12/46112/1
Geng Xingyuan [Fri, 23 Sep 2016 08:38:17 +0000 (16:38 +0800)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I3bd6a301d628fc63b1f2e768cbcaf83f67869e95
Signed-off-by: Geng Xingyuan <geng.xingyuan@zte.com.cn>
7 years agoBump versions by 0.1.0 for next dev cycle 21/43421/1
Thanh Ha [Mon, 8 Aug 2016 21:50:15 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle

Change-Id: I1c1db748f54d545c2c57eba24612d743e9fc171c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBug 6199 - Add icmp decoder to packethandler 61/40661/5
Yakir Dorani [Sun, 17 Apr 2016 07:39:45 +0000 (10:39 +0300)]
Bug 6199 - Add icmp decoder to packethandler

Change-Id: I71f7c32c6cc4b2a357e9d264656a6e102c54e6d2
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 52/41052/2
Lorand Jakab [Wed, 29 Jun 2016 20:29:37 +0000 (15:29 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: Idaacfe3c173e3cd1a43a34aedaf72aa901cd8ab6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd .checkstyle to gitignore 03/40703/3
Alexis de Talhouët [Wed, 22 Jun 2016 01:15:02 +0000 (21:15 -0400)]
Add .checkstyle to gitignore

Change-Id: Ia6ace14aabe8f4c61bfdac167d1386d41b5a3df5
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for packet handler 30/40730/9
Alexis de Talhouët [Wed, 22 Jun 2016 13:57:52 +0000 (09:57 -0400)]
Add blueprint wiring for packet handler

Change-Id: Ie19e31858533d892098152d86ff75c4d40c6a9d7
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for l2switch-main 28/40728/10
Alexis de Talhouët [Wed, 22 Jun 2016 13:48:30 +0000 (09:48 -0400)]
Add blueprint wiring for l2switch-main

Change-Id: I98069ed77d697b51592458e999549a4f22a59c7f
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for loop remover 27/40727/6
Alexis de Talhouët [Wed, 22 Jun 2016 13:47:38 +0000 (09:47 -0400)]
Add blueprint wiring for loop remover

Change-Id: Id6cd32afccdabbab7ad6790a9f1f541fc4b1db33
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for host tracker 08/40708/7
Alexis de Talhouët [Wed, 22 Jun 2016 02:06:15 +0000 (22:06 -0400)]
Add blueprint wiring for host tracker

Change-Id: Ia4543ca5d2bdd36c347499b1798cac2baab4ce44
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for arp handler 07/40707/3
Alexis de Talhouët [Wed, 22 Jun 2016 01:39:11 +0000 (21:39 -0400)]
Add blueprint wiring for arp handler

Change-Id: I9db51c05cb0992f449ba3a79907bf872a8568c40
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for address tracker 06/40706/3
Alexis de Talhouët [Wed, 22 Jun 2016 01:15:51 +0000 (21:15 -0400)]
Add blueprint wiring for address tracker

Change-Id: I97f48556b3649def457e527b36b1596d2fab56ff
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoUse nexusproxy from odlparent 48/38448/2
Thanh Ha [Thu, 5 May 2016 19:34:55 +0000 (15:34 -0400)]
Use nexusproxy from odlparent

Change-Id: Iac6a3cdd0075c7807dce72fb41bd411b907e94ee
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
8 years agoBUG 5816 - Expired hosts never comeback after timing out 76/38676/1
Sai MarapaReddy [Wed, 11 May 2016 18:23:39 +0000 (11:23 -0700)]
BUG 5816 - Expired hosts never comeback after timing out

Appropriate configurations in l2switch needs to be made for expired hosts
to be seen back in the network. This patch adds comments where to modify
the configurable parameters for expire hosts to be seen when they are
back in network.

Change-Id: I7df9695e0125adb47aadbe2fdd8536d0147e6353
Author:    Sai MarapaReddy <sai.marapareddy@gmail.com>
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
8 years agoMerge "BUG 5012 - adding configurable support for timing out hosts ( in interval...
Evan Zeller [Mon, 9 May 2016 18:17:53 +0000 (18:17 +0000)]
Merge "BUG 5012 - adding configurable support for timing out hosts ( in interval of seconds )"

8 years agoMerge "Bug 5768 - Changing L2switch to depend on openflow-li features This way l2swit...
Evan Zeller [Mon, 9 May 2016 07:03:34 +0000 (07:03 +0000)]
Merge "Bug 5768 - Changing L2switch to depend on openflow-li features This way l2switch can be added to final integration distribution as final distribution can run only one version of open flow."

8 years agoMerge "Bug 5452 - stable / beryllium - Adding comments that details the xml configura...
Evan Zeller [Wed, 4 May 2016 22:47:55 +0000 (22:47 +0000)]
Merge "Bug 5452 - stable / beryllium - Adding comments that details the xml configuration proactive mode setting."

8 years agoMerge "Bug 2501 Reactive mode -default L2Switch timeout values"
Evan Zeller [Wed, 4 May 2016 20:03:35 +0000 (20:03 +0000)]
Merge "Bug 2501 Reactive mode -default L2Switch timeout values"

8 years agoBUG 5012 - adding configurable support for timing out hosts ( in interval of seconds ) 05/38205/1
Sai MarapaReddy [Tue, 2 Feb 2016 19:53:54 +0000 (14:53 -0500)]
BUG 5012 - adding configurable support for timing out hosts ( in interval of seconds )

This adds two new configuration parameters (host-purge-age and
host-purge-interval) in the host tracker config yang and initial config
xml file as well as the backing logic for them.

This allows for hosts and associated links to be removed from the
operational store after a specified time since the last observations.

Author:    Sai MarapaReddy <sai.marapareddy@gmail.com>
Author:    Colin Dixon <colin@colindixon.com>

Change-Id: I34b4c794c28cc46ec60432eeb0d1b81b98b8e433
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
8 years agoBug 5452 - stable / beryllium - Adding comments that details the xml 68/38168/1
Sai MarapaReddy [Thu, 3 Mar 2016 05:16:34 +0000 (21:16 -0800)]
Bug 5452 - stable / beryllium - Adding comments that details the xml
configuration proactive mode setting.

Change-Id: If416090afde56a9bf3ecf922915c7b04eb10c8bf
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
8 years agoBug 5629 - Cleaning up Yang files 67/38167/1
Sai MarapaReddy [Wed, 30 Mar 2016 18:38:21 +0000 (11:38 -0700)]
Bug 5629 - Cleaning up Yang files
Unused imports are being removed from yang files.

Change-Id: Id1fd39e8c30050f9a4804d82a7c571e504f9771a
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
8 years agoBug 2501 Reactive mode -default L2Switch timeout values 61/38161/2
Sai MarapaReddy [Fri, 1 Apr 2016 00:12:44 +0000 (17:12 -0700)]
Bug 2501 Reactive mode -default L2Switch timeout values

The current Default L2Switch Idle (1800secs) and hard (3600seconds) timeouts
are unrealistic for a real network. As a result of this unwanted
flows are stuck are for an unimaginable amount of time. With this
commit default values will be 300 / 600 secs respectively.

Change-Id: I43c976bfb462abe9d53d18dd110cfaf1ccee8d3c
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>