openflowplugin.git
7 years agoMerge "Add PortMessage serializer"
Jozef Bacigal [Mon, 9 Jan 2017 14:49:09 +0000 (14:49 +0000)]
Merge "Add PortMessage serializer"

7 years agoMerge "Add MeterMessage serializer"
Jozef Bacigal [Mon, 9 Jan 2017 14:49:05 +0000 (14:49 +0000)]
Merge "Add MeterMessage serializer"

7 years agoMerge "Add FlowMessage serializer"
Jozef Bacigal [Mon, 9 Jan 2017 14:49:01 +0000 (14:49 +0000)]
Merge "Add FlowMessage serializer"

7 years agoMerge "Add Instruction serializers"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:58 +0000 (14:48 +0000)]
Merge "Add Instruction serializers"

7 years agoMerge "Add InstructionSerializerInjector"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:54 +0000 (14:48 +0000)]
Merge "Add InstructionSerializerInjector"

7 years agoMerge "Add Action serializers"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:50 +0000 (14:48 +0000)]
Merge "Add Action serializers"

7 years agoMerge "Add ActionSerializerInjector"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:46 +0000 (14:48 +0000)]
Merge "Add ActionSerializerInjector"

7 years agoMerge "Add Match entry serializers"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:42 +0000 (14:48 +0000)]
Merge "Add Match entry serializers"

7 years agoMerge "Add MatchSerializerInjector"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:37 +0000 (14:48 +0000)]
Merge "Add MatchSerializerInjector"

7 years agoMerge "Add MessageSerializerInjector"
Jozef Bacigal [Mon, 9 Jan 2017 14:48:31 +0000 (14:48 +0000)]
Merge "Add MessageSerializerInjector"

7 years agoAdd PortMessage serializer 59/48259/13
Tomas Slusny [Fri, 11 Nov 2016 13:38:09 +0000 (14:38 +0100)]
Add PortMessage serializer

Inject PortMessageSerializer into OFJ. This serializer will
serialize PortMod message to raw bytes.

See also: bug 7138

Change-Id: Iea3c90111cfc83b297e54559c4846a7949cc15df
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd MeterMessage serializer 20/48520/18
Tomas Slusny [Mon, 21 Nov 2016 09:18:07 +0000 (10:18 +0100)]
Add MeterMessage serializer

Inject MeterMessageSerializer into OFJ. This serializer will
serialize MeterMod message to raw bytes.
Added unit tests for ExperimentedIdMeterBandTypeSerializerKey

See also: bug 7138

Change-Id: I6b46f6f9e7e960055692c0a33932be373a783b47
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoBug 7415 Reducing the severity of the log message 73/49673/2
Sai Marapareddy [Tue, 20 Dec 2016 23:42:51 +0000 (15:42 -0800)]
Bug 7415 Reducing the severity of the log message

Whenever there is a change in configuration of l2switch,
bundle refresh happens. When bundles refresh, openflowplugin
pushes the same flow. Changing the severity of of the exception
to warning since it is expected to have a flow with same id.

Change-Id: I69874d14b83053edc97b6d299c8fdb05d7ccdd8c
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>

7 years agoMerge "Create YANG builders for all relevant model types"
Jozef Bacigal [Tue, 20 Dec 2016 08:05:44 +0000 (08:05 +0000)]
Merge "Create YANG builders for all relevant model types"

7 years agoMerge "Add Serialization and Deserialization injectors"
Jozef Bacigal [Tue, 20 Dec 2016 08:05:38 +0000 (08:05 +0000)]
Merge "Add Serialization and Deserialization injectors"

7 years agoAdd FlowMessage serializer 90/48790/11
Tomas Slusny [Fri, 9 Dec 2016 13:58:41 +0000 (14:58 +0100)]
Add FlowMessage serializer

Inject FlowMessageSerializer into OFJ.
This serializer will serialize FlowMod message to raw bytes.

See also: bug 7138
Change-Id: I83038bdaab160a757dda78c4356af5a1e976d402
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd Instruction serializers 73/48773/13
Tomas Slusny [Tue, 29 Nov 2016 09:49:45 +0000 (10:49 +0100)]
Add Instruction serializers

Inject instruction serializers into InstructionSerializerInjector.
These serializers will serialize these intrusctions to raw bytes:

  - ApplyActions
  - ClearActions
  - GoToTable
  - Meter
  - WriteActions
  - WriteMetadata

Change-Id: I72a254b897234b3e7f29c0ea2d1496f0bc517e43
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd InstructionSerializerInjector 68/48768/13
Tomas Slusny [Tue, 29 Nov 2016 09:33:51 +0000 (10:33 +0100)]
Add InstructionSerializerInjector

Add injector where all instruction serializers will be registered and call
it from general SerializerInjector
Add AbstractInstructionSerializer and
AbstractActionInstructionSerializer
to unify all instruction serializers
Add unit tests

Change-Id: Id2c2462c950b127636f040b452226b2216e097ec
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd Action serializers 40/48540/21
Tomas Slusny [Mon, 21 Nov 2016 12:59:54 +0000 (13:59 +0100)]
Add Action serializers

Inject action serializers into OFJ. These serializers will serialize
these actions to raw bytes:

  - CopyTtlIn
  - CopyTtlOut
  - DecMplsTtl
  - DecNwTtl
  - GroupAction
  - OutputAction
  - PopMplsAction
  - PopPbbAction
  - PopVlanAction
  - PushMplsAction
  - PushPbbAction
  - PushVlanAction
  - SetMplsTtlAction
  - SetNwTtlAction
  - SetQueueAction
  - SetFieldAction
  - DropAction
  - SetVlanIdAction
  - SetVlanPcpAction
  - StripVlanAction
  - SetDlSrcAction
  - SetDlDstAction
  - SetNwSrcAction
  - SetNwDstAction
  - SetTpSrcAction
  - SetTpDstAction
  - SetNwTosAction

See also: bug 7138

Change-Id: I5b42b0b2d2afd3468768e28bd11bfdcfcbbbc142
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd ActionSerializerInjector 63/48563/15
Tomas Slusny [Tue, 22 Nov 2016 10:35:34 +0000 (11:35 +0100)]
Add ActionSerializerInjector

Add injector where all action serializers will be registered and
call it from general SerializerInjector.
Add AbstractActionSerializer and AbstractSetFieldActionSerializer to be able
to actually create action serializers.
Add unit tests for ActionSerializerInjector
Add ActionUtil#writeAction that tries to determine what type of
action we are serializing, and serializes it.

See also: bug 7138

Change-Id: I25549b453a0a36d38f9b42de7b8087a41d438f7b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd Match entry serializers 29/48629/21
Tomas Slusny [Mon, 5 Dec 2016 14:41:03 +0000 (15:41 +0100)]
Add Match entry serializers

Inject match entry serializers into MatchSerializer.
These serializers will serialize these entries to raw bytes:

  - EthernetDestination
  - EthernetSource
  - EthernetType
  - InPhyPort
  - InPort
  - Metadata
  - VlanPcp
  - VlanVid
  - IpDscp
  - IpEcn
  - IpProto
  - TcpSource
  - TcpDestination
  - UdpSource
  - UdpDestination
  - SctpSource
  - SctpDestination
  - Icmpv4Type
  - Icmpv4Code
  - Icmpv6Type
  - Icmpv6Code
  - Ipv4ArbitraryBitMaskSource
  - Ipv4ArbitraryBitMaskDestination
  - Ipv4Source
  - Ipv4Destination
  - TunnelIpv4Source
  - TunnelIpv4Destination
  - ArpOp
  - ArpSourceTransportAddress
  - ArpTargetTransportAddress
  - ArpSourceHardwareAddress
  - ArpTargetHardwareAddress
  - Ipv6ArbitraryBitMaskSource
  - Ipv6ArbitraryBitMaskDestination
  - Ipv6Source
  - Ipv6Destination
  - Ipv6Label
  - Ipv6NdTarget
  - Ipv6NdSll
  - Ipv6NdTll
  - Ipv6ExtHeader
  - MplsLabel
  - MplsBos
  - MplsTc
  - Pbb
  - TunnelId
  - TcpFlags

Change-Id: I886e990aebc4ce02e5c7b571d06078aaf8033e07
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd MatchSerializerInjector 22/48622/15
Tomas Slusny [Wed, 23 Nov 2016 12:16:03 +0000 (13:16 +0100)]
Add MatchSerializerInjector

Add injector where all match and match entry serializers will be
registered and call it from general SerializerInjector.
Add AbstractMatchEntrySerializer and MatchSerializer to be able to
actually create match entry serializers and serialize match body.
Add AbstractExperimenterMatchEntrySerializer to serialize match
entries with experimenter id.
Add match extension serialization to MatchSerializer, using match
extension converters. This needs to be changed later, to also remove
use of match extension converters.

See also: bug 7138

Change-Id: Ifa3f0d52b384b173cf639f7d00fd5a4a3e0d30f4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoRevert the functional behavior change introduced through 59/49159/2
Anil Vishnoi [Wed, 7 Dec 2016 20:14:43 +0000 (12:14 -0800)]
Revert the functional behavior change introduced through

https://git.opendaylight.org/gerrit/#/c/47138/3

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: I0b8fc5b1e0763bb2b91302647037e1153fd41dc1
(cherry picked from commit 43b49485d25ebdf0dca58d46c14100a4aa7c6324)

7 years agoAdd MessageSerializerInjector 62/48562/10
Tomas Slusny [Tue, 22 Nov 2016 10:02:50 +0000 (11:02 +0100)]
Add MessageSerializerInjector

Add injector where all message serializers will be registered
and call it from general SerializerInjector
Add AbstractMessageSerializer to unify all message serializers
Add unit tests for MessageSerializerInjector

See also: bug 7138

Change-Id: Ie5f0652e31316ca33b6b6fb10d84bf9972a1fed5
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoCreate YANG builders for all relevant model types 54/48254/16
Tomas Slusny [Fri, 11 Nov 2016 11:25:27 +0000 (12:25 +0100)]
Create YANG builders for all relevant model types

Add new *message builders to flow, group, meter and port
YANG models to allow us to serialize and deserialize them
properly.
Add dependency on openflowjava for model-flow-base
Update set-tp-src and set-tp-dst yang with ip-protocol

See also: bug 7137

Change-Id: Ie552e5b06778ec0d0d803e34b9628fb1c627d1ab
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoAdd Serialization and Deserialization injectors 57/48257/13
Tomas Slusny [Fri, 11 Nov 2016 11:51:51 +0000 (12:51 +0100)]
Add Serialization and Deserialization injectors

Add SerializerInjector and DeserializerInjector that will
allow us to register new serializers and deserializers in
OpenflowPlugin easily.
Add abstract classes for unit tests to speed up unit test
development.

See also: bug 7136

Change-Id: I3135dd3d0ca49585f274f5c63f4ab6b35b525b6d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoBug 7335 - Flow update rejected by switch generates 09/49209/1
Anil Vishnoi [Sat, 10 Dec 2016 08:53:11 +0000 (00:53 -0800)]
Bug 7335 - Flow update rejected by switch generates
faulty flow entry in operational DS

When flow update request comes to plugin, it cleans up
the flow hashmap for the updated flow, but it does not
clean up the flow with the assumption that in the next
statistics cycle, this stale flow in operational data
store will be overwritten by the new modified flow,
but as reported in the issue, if installation of modified
flow fails, it will leave the stale flow in the data store.

Change-Id: I47905f980aabc83134c6eccfbf0655d48e71484b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoMerge "BUG-6890:Flow-Removed Notification configuration"
Jozef Bacigal [Mon, 5 Dec 2016 11:05:01 +0000 (11:05 +0000)]
Merge "BUG-6890:Flow-Removed Notification configuration"

7 years agoMerge "Add new API's for LLDP"
Jozef Bacigal [Mon, 5 Dec 2016 09:51:10 +0000 (09:51 +0000)]
Merge "Add new API's for LLDP"

7 years agoBug 7209 - Null Pointer Exception in LearnCodecUtil when add learn flow for ipv6 22/48722/1
Vinh Nguyen [Fri, 18 Nov 2016 23:03:39 +0000 (15:03 -0800)]
Bug 7209 - Null Pointer Exception in LearnCodecUtil when add learn flow for ipv6

The exception caused by using ByteBuf::readShort
(valid range: -32,768 32,767) for ipv6 etherType '0x86dd'
The fix is to use ByteBuf::readUnsignedShort

Change-Id: I238535565a66692b5d4dbe39b8cb7809867f3cde
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
(cherry picked from commit e9deca32b7e455ba805adc35aa49d635b2a2537e)

7 years agoAdd new API's for LLDP 05/48005/4
senthil [Fri, 4 Nov 2016 17:26:49 +0000 (22:56 +0530)]
Add new API's for LLDP

  *Right now LLDP time period is hard coded
  *This patch enables to set the time period dynamically,
   which increases the performance of the CPU
  *Increase in CPU performance is observed clearly when we do scaling

Change-Id: I959e151c1e0f11799617bc3ae679cfb7539e764a
Signed-off-by: senthil <senthil.b@tataelxsi.co.in>
7 years agoBUG:6997 supporting OXM_OF_MPLS_LABEL in nicira extensiona 62/47662/8
epgoraj [Thu, 27 Oct 2016 11:22:18 +0000 (16:52 +0530)]
BUG:6997 supporting OXM_OF_MPLS_LABEL in nicira extensiona

        Description : currently under nicira-extension, MPLS support is not
        present in nicira Move action. Mainly in ECMP use-case we need to use
        mpls_label under nicira_move_action type. The mpls_label will be using as
        example ( move:NXM_NX_REG1[0..19]->OXM_OF_MPLS_LABEL[] )

Change-Id: Ia497b963f30bf9ffcd09430db8ed85661a64859f
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
7 years agoMerge "Bug 6820 - Implement SalExperimenterMpMessageService"
Jozef Bacigal [Mon, 21 Nov 2016 14:42:20 +0000 (14:42 +0000)]
Merge "Bug 6820 - Implement SalExperimenterMpMessageService"

7 years agolower log level when stats come before flow is written to deviceflowregistry 90/48190/1
Jamo Luhrsen [Wed, 9 Nov 2016 18:55:13 +0000 (10:55 -0800)]
lower log level when stats come before flow is written to deviceflowregistry

Change-Id: Ib24b9e97c86b2d1a24610204b61fcf9237871f0e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
(cherry picked from commit ac114ea16d60aff29106fdf687e2f35a33f7e0d6)

7 years agoBUG-6890:Flow-Removed Notification configuration 88/48188/1
Shuva Kar [Thu, 10 Nov 2016 05:47:23 +0000 (11:17 +0530)]
BUG-6890:Flow-Removed Notification configuration

Changing the flag to enable/disable flow removed
notification.

Currently the flow-removed notification is controlled by the flag
notification-flow-removed-off which is on by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to enable-flow-removed-notification
and setting it to true by default.

The associated logic involved at oyther places have been modified as
well as a part of this commit.

Change-Id: I1452de6e3e72030608c89168f19328d9c6aa8f1c
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoMerge "Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect...
Shuva Jyoti Kar [Wed, 9 Nov 2016 10:16:26 +0000 (10:16 +0000)]
Merge "Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device"

7 years agoMerge "BUG-6890: Statistics-polling configuration"
Jozef Bacigal [Thu, 3 Nov 2016 11:40:04 +0000 (11:40 +0000)]
Merge "BUG-6890: Statistics-polling configuration"

7 years agoBug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device 43/47843/1
Anil Vishnoi [Fri, 28 Oct 2016 15:58:06 +0000 (17:58 +0200)]
Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device

Change-Id: I50164bf9c3f09097d211b9f40a3f2325dee38d45
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoBug 6820 - Implement SalExperimenterMpMessageService 93/47793/1
yunyunhan [Tue, 1 Nov 2016 18:40:15 +0000 (02:40 +0800)]
Bug 6820 - Implement SalExperimenterMpMessageService

Change-Id: Ibfbdea25957b8259a6b5070fb0598172d44108bc
Signed-off-by: yunyunhan <han.yunyun@zte.com.cn>
7 years agoBUG-6890: Statistics-polling configuration 76/47476/7
Shuva Kar [Mon, 24 Oct 2016 16:21:06 +0000 (21:51 +0530)]
BUG-6890: Statistics-polling configuration

Changing the current flag to enable/disable statistics
polling.

Currently the statistics polling is controlled by the flag
is-statistics-polling-off which is off by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to is-statistics-polling-on and setting
it to true by default.

The associated logic involved at oyther places have been modified as
well as a part of this commit.

Change-Id: Ia9a027433611912c11ff0f3166aa6f68efdc6913
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoBug 7011 - Race condition in statistics collection related transaction chain handling 80/47380/4
Anil Vishnoi [Sat, 22 Oct 2016 12:22:14 +0000 (05:22 -0700)]
Bug 7011 - Race condition in statistics collection related transaction chain handling

Change-Id: Iabc18b2814bf2f49bb6159f0bb8f9f55eda2e07d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoMerge "Implement SalExperimenterMpMessageService"
Jozef Bacigal [Fri, 28 Oct 2016 07:43:47 +0000 (07:43 +0000)]
Merge "Implement SalExperimenterMpMessageService"

7 years agoOptimize port number lookups 57/47657/4
Tomas Slusny [Thu, 27 Oct 2016 08:33:32 +0000 (10:33 +0200)]
Optimize port number lookups

- Remove unnecessary OpenflowPortsUtil#init() and
  OpenflowPortsUtil#close() methods and add static constructors
  instead, so BiMaps will be initialized only when really needed,
  and we do not need to call OpenflowPortsUtil#init() method
  everywhere
- Cache inverse port BiMaps in OpenflowPortsUtil to greatly reduce
  lookup time in these BiMaps in some methods
- Try to use more short version instead of deprecated
  OpenflowVersion to reduce deprecation and to reduce
  memory use (less conversions from OpenflowVersion to short)
- Use proper MAX port constant when finding max port number
- Simplify some conditions in OpenflowPortsUtil
- Use proper OF_URI_PREFIX contant in InventoryDataServiceUtil

Resolves: bug 7046

Change-Id: I1ea033963fb48416d004398e2ee72909231aaea6
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoImplement SalExperimenterMpMessageService 68/47668/1
Tomas Slusny [Thu, 27 Oct 2016 12:35:19 +0000 (14:35 +0200)]
Implement SalExperimenterMpMessageService

Add missing implementation for experimenter multipart message
RPC service and register it as routed RPC implementation

Resolves: bug 6820

Change-Id: I5646f93dd6375b729e995a9e60e6d688f1508559
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoImprove cleanup after device disconnected event 90/46390/24
Tomas Slusny [Mon, 3 Oct 2016 15:43:08 +0000 (17:43 +0200)]
Improve cleanup after device disconnected event

- Ensure that all contexts are removed from managers at once
  at end of disconnect chain right before unregistration from
  cluster singleton service
- Prevent closing some services multiple times during device
  disconnect chain
- Prevent some NPEs in DeviceInitializationUtils what was caused
  by connecting and disconnecting device with no time in between
- Unify all openflow managers to implement OFPManager interface
- Ensure that when we will fail to set device to SLAVE we will wait
  until device is removed from operational DS and then continue

Resolves: bug 6672
See also: bug 6710, bug 5271

Change-Id: I3845c7d2a9147125b185d3abcc3fc8dd63ba5da8
Depends-On: I15f89cbd43310b0a8e4b7ac78595eeaaa82a65ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoMerge "BUG-6890:"
Jozef Bacigal [Mon, 24 Oct 2016 11:14:53 +0000 (11:14 +0000)]
Merge "BUG-6890:"

7 years agoFix direct statistics 14/47414/1
miroslav.macko [Mon, 24 Oct 2016 09:14:37 +0000 (11:14 +0200)]
Fix direct statistics

- Initialize statistics gathering

Resolves: bug 7007

Change-Id: I0970b3c690f0771dbd1637405e3064a984b1ef4c
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug: 6930 Notiifcation-suppliers was broken 66/46866/10
GauravBhagwani [Thu, 13 Oct 2016 08:09:34 +0000 (13:39 +0530)]
Bug: 6930 Notiifcation-suppliers was broken

Review contains changes required for making notification-supplier as per
Blueprint Injection method
- Removed Config Subsystem parts - Yang, Config XML, Modules/ModuleFactory
- Added Blueprint XML for notification-supplier
- Removed Config Dependency from features Pom
- Removed references to Config XML

Change-Id: Ifbdcb21140903a668ad0b8dd6e2df666b7e3e37f
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
7 years agoBUG-6890: 02/47002/8
Shuva Kar [Mon, 17 Oct 2016 08:57:59 +0000 (14:27 +0530)]
BUG-6890:

Fix to provide default values for configurable parameters by
handling the NumberFormatException in case the configurable
parameters are either null or absent

Change-Id: Idb37565167778a900732df2dfef428847b0efd3b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoFix flow matching function 38/47138/3
miroslav.macko [Tue, 18 Oct 2016 17:06:30 +0000 (19:06 +0200)]
Fix flow matching function

- If flow is not present in DeviceFlowRegistry,
  don't write to operational DS.
- Update SalFlowService "update" method
- Update Unit tests

Resolves: bug 6917

Change-Id: If07e94be2d2e8564a2d39d88aec0ea5ea6ac7d19
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoMerge "BUG-6890: Edit to cfg file reflecting that statistics collection is turned...
Jozef Bacigal [Thu, 20 Oct 2016 13:06:08 +0000 (13:06 +0000)]
Merge "BUG-6890: Edit to cfg file reflecting that statistics collection is turned on by default"

7 years agoRevert "Revert "Move the Openflow connections blueprint to OpenflowJava project"" 17/47117/8
Michal Polkorab [Wed, 19 Oct 2016 13:04:51 +0000 (15:04 +0200)]
Revert "Revert "Move the Openflow connections blueprint to OpenflowJava project""

This reverts commit e84b8d9e2c0e38a950db4295a61b24dd77538e01.

Change-Id: I1c79ddcb0041d4599e82fa5f6ed227d530dfab97
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
7 years agoMerge "Remove RoleManager and RoleContext"
Shuva Jyoti Kar [Thu, 20 Oct 2016 07:05:20 +0000 (07:05 +0000)]
Merge "Remove RoleManager and RoleContext"

7 years agoBUG-6890: Edit to cfg file reflecting that statistics 67/47067/1
Shuva Kar [Tue, 18 Oct 2016 11:31:06 +0000 (17:01 +0530)]
BUG-6890: Edit to cfg file reflecting that statistics
collection is turned on by default

Change-Id: I8a97cb11b1b98189a04daed50961b4a912113749
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoRemove RoleManager and RoleContext 03/47003/2
Jozef Bacigal [Mon, 17 Oct 2016 10:25:32 +0000 (12:25 +0200)]
Remove RoleManager and RoleContext

- no more functionality for role manager (after Singleton changes)
- all remain functionality from role-mng and ctx were moved to device-mgn and ctx

Change-Id: I1cc1ef23c45da7b9a4288194caa7f88f7534e409
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
7 years agoBUG-6890: Updated the cfg file with detailed description 93/46993/2
Shuva Kar [Mon, 17 Oct 2016 05:55:36 +0000 (11:25 +0530)]
BUG-6890: Updated the cfg file with detailed description
of usage

Change-Id: Ibe772a29107296cb96cf4aa48c1d3cb2dee4f3b2
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoBUG-6890: Enabling statistics collection through a config 18/46718/4
Shuva Kar [Mon, 10 Oct 2016 08:40:27 +0000 (14:10 +0530)]
BUG-6890: Enabling statistics collection through a config
parameter in openflowplugin.cfg

Change-Id: If7dbedd50d7f23a075c53279654e36d33b212867
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoBUG-6890: Enabling echo timout configurable through 17/46717/3
Shuva Kar [Mon, 10 Oct 2016 08:27:43 +0000 (13:57 +0530)]
BUG-6890: Enabling echo timout configurable through
config file

Change-Id: I3ff729b418809e8342a491ac6ab2a102f5a1ffe5
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoBUG-6890: Enabling barrier configurability through 14/46714/3
Shuva Kar [Mon, 10 Oct 2016 07:11:03 +0000 (12:41 +0530)]
BUG-6890: Enabling barrier configurability through
cfg file

Change-Id: Iaada857a439c7774c6e31c27cc7be1b26c68ad1b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoRevert "Move the Openflow connections blueprint to OpenflowJava project" 52/46952/1
Jozef Bacigal [Fri, 14 Oct 2016 13:20:40 +0000 (15:20 +0200)]
Revert "Move the Openflow connections blueprint to OpenflowJava project"

This reverts commit f44ebeb5ca3e25ff4c863f374ed8b9b33466e991.

Change-Id: Ib95293482546888bbe678bf60c29c14fe4f972b3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
7 years agoMerge "Optimize LLDP packet check"
Jozef Bacigal [Fri, 14 Oct 2016 06:23:25 +0000 (06:23 +0000)]
Merge "Optimize LLDP packet check"

7 years agoMerge "BUG-6890: Enabling statistics rpc config through openflowplugin.cfg"
Jozef Bacigal [Fri, 14 Oct 2016 06:10:51 +0000 (06:10 +0000)]
Merge "BUG-6890: Enabling statistics rpc config through openflowplugin.cfg"

7 years agoBUG-6890: Enabling statistics rpc config through 10/46710/6
Shuva Kar [Mon, 10 Oct 2016 04:39:42 +0000 (10:09 +0530)]
BUG-6890: Enabling statistics rpc config through
openflowplugin.cfg

Change-Id: I54d1de2eac18b5cde38150cbdc21174d7111f740
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
7 years agoMove the Openflow connections blueprint to OpenflowJava project 19/46519/2
Mohamed El-Serngawy [Tue, 4 Oct 2016 20:50:37 +0000 (16:50 -0400)]
Move the Openflow connections blueprint to OpenflowJava project

This patch is related to https://git.opendaylight.org/gerrit/#/c/46518/
Moving the Openflow connections (defaultSwitchConnProvider and legacySwitchConnProvider)
blueprint to OpenflowJava project as its config data model "openflow-switch-connection-provider-impl"
exist in OpenflowJava project

Change-Id: Ic6db83e98d57cf17ef5883d64755118214815731
Signed-off-by: Mohamed El-Serngawy <melserngawy@inocybe.com>
7 years agoOptimize LLDP packet check 28/46728/3
miroslav.macko [Fri, 7 Oct 2016 09:19:57 +0000 (11:19 +0200)]
Optimize LLDP packet check

Deserialize only LLDP packets.

See also: bug 1462

Change-Id: Ibdd2f3eb0dfe784fd235e51a591da64971c2afd3
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoBug 6745 SimplifiedOperationalListener optimation 94/46394/6
miroslav.macko [Mon, 3 Oct 2016 16:07:15 +0000 (18:07 +0200)]
Bug 6745 SimplifiedOperationalListener optimation

- optimize processNodeModification method
- update test

Change-Id: I941a84bff4322c2b2b64f8404791ec6d00a9d200
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
7 years agoMerge "Bug 6745 Do not skip first data for reconciliation"
Jozef Bacigal [Mon, 3 Oct 2016 07:33:05 +0000 (07:33 +0000)]
Merge "Bug 6745 Do not skip first data for reconciliation"

7 years agoBug 6745 Do not skip first data for reconciliation 54/46254/2
Andrej Leitner [Wed, 28 Sep 2016 12:45:46 +0000 (14:45 +0200)]
Bug 6745 Do not skip first data for reconciliation

 - we can accept first modification since all statistics
   are intentionally collected in one step on startup
 - added test
 - updated comments

Change-Id: I94590fb268accb0237260a09d184c2cecd1fb324
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoFix unregistering of cluster services 21/46321/2
Tomas Slusny [Fri, 30 Sep 2016 11:16:17 +0000 (13:16 +0200)]
Fix unregistering of cluster services

When unregistering cluster singleton services, check if we are not
already in unregistering phase, and if yes, skip this process. Also,
chain stopClusterServices futures properly, so Singleton will know, when
to finish unregistering.

See also: bug 6672

Change-Id: I07e077eb7dd655b6af9e4e3ee61e46163b8538b0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoCreate SemaphoreKeeper inside decorators 44/46244/1
Andrej Leitner [Wed, 28 Sep 2016 07:17:40 +0000 (09:17 +0200)]
Create SemaphoreKeeper inside decorators

Change-Id: I29fb2da53d32b331459a4492ca15a4081ea79195
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoMerge "Bug 6745 Improve compression queue locking and handle InterruptedException"
Jozef Bacigal [Wed, 28 Sep 2016 07:57:51 +0000 (07:57 +0000)]
Merge "Bug 6745 Improve compression queue locking and handle InterruptedException"

7 years agoMerge "Revert "Bug 6745 Do not ignore syncup return value""
Jozef Bacigal [Tue, 27 Sep 2016 13:39:08 +0000 (13:39 +0000)]
Merge "Revert "Bug 6745 Do not ignore syncup return value""

7 years agoBug 6745 Improve compression queue locking and handle InterruptedException 22/46222/1
Andrej Leitner [Tue, 27 Sep 2016 12:13:29 +0000 (14:13 +0200)]
Bug 6745 Improve compression queue locking and handle InterruptedException

 - compression queue could be locked per device and not for every change
   since there is only one entry per device in it
 - IE handled in one place

Change-Id: Ic28b448d619c663757f391e7a443b28c8f6a871d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoAdd finals and move thread name constant to provider 95/46195/3
Andrej Leitner [Mon, 26 Sep 2016 14:24:18 +0000 (16:24 +0200)]
Add finals and move thread name constant to provider

 - add onDTC annotations
 - code cleanup

Change-Id: I585d08e67138805672d19293892358205650c998
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoRevert "Bug 6745 Do not ignore syncup return value" 10/46210/1
Andrej Leitner [Tue, 27 Sep 2016 06:59:17 +0000 (08:59 +0200)]
Revert "Bug 6745 Do not ignore syncup return value"

This reverts commit df561a83c33b7af9818d8d0d0e8e6b00f7a37a93.

Change-Id: I9133264ba297bf4293a50e26e1d2e1051df1f093
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoMerge "Bug 6745 Set compression semaphore to fair"
Jozef Bacigal [Mon, 26 Sep 2016 15:32:46 +0000 (15:32 +0000)]
Merge "Bug 6745 Set compression semaphore to fair"

7 years agoMerge "Bug 6745 Do not ignore syncup return value"
Jozef Bacigal [Mon, 26 Sep 2016 15:32:41 +0000 (15:32 +0000)]
Merge "Bug 6745 Do not ignore syncup return value"

7 years agoMerge "Bug 6745 Remove thread renaming and unnecessary logging"
Jozef Bacigal [Mon, 26 Sep 2016 15:32:34 +0000 (15:32 +0000)]
Merge "Bug 6745 Remove thread renaming and unnecessary logging"

7 years agoMerge "Bug 6745 Fix replacing in compression queue"
Jozef Bacigal [Mon, 26 Sep 2016 14:53:55 +0000 (14:53 +0000)]
Merge "Bug 6745 Fix replacing in compression queue"

7 years agoBug 6745 Set compression semaphore to fair 82/46182/2
Andrej Leitner [Mon, 26 Sep 2016 10:55:43 +0000 (12:55 +0200)]
Bug 6745 Set compression semaphore to fair

 - prevent changing the order of incoming changes

Change-Id: If7df69334b2ff8217986cd933e25463cb6e90171
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoBug 6745 Do not ignore syncup return value 81/46181/2
Andrej Leitner [Mon, 26 Sep 2016 09:40:18 +0000 (11:40 +0200)]
Bug 6745 Do not ignore syncup return value

Change-Id: Ide811a0db0d684dc3b37ea3f6707d779162cb87f
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoBug 6745 Remove thread renaming and unnecessary logging 80/46180/2
Andrej Leitner [Mon, 26 Sep 2016 08:05:36 +0000 (10:05 +0200)]
Bug 6745 Remove thread renaming and unnecessary logging

 - change name format for thread pool
 - remove thread renaming and useless logging
 - remove duplicit time logging
 - update return values

Change-Id: I78abca1870d278c162a7f717ff800dd37c1d4234
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoBug 6745 Fix replacing in compression queue 68/46168/3
Andrej Leitner [Mon, 26 Sep 2016 08:29:26 +0000 (10:29 +0200)]
Bug 6745 Fix replacing in compression queue

 When there were more changes in a row on startup it could happend
 that the first syncup entry (config-operational) was not updated
 but replaced with following config-config changes. Therefore we need
 to update syncup entry in compression queue everytime when new config
 diff is comming (not only if config-config entry resides there).

Change-Id: I9d73fb348f5e1ace1b138052bcd2a5614946efa9
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoWrite SwitchFeatures to operational datastore 67/46167/1
Tomas Slusny [Mon, 26 Sep 2016 08:34:02 +0000 (10:34 +0200)]
Write SwitchFeatures to operational datastore

Ensures that SwitchFeatures are written to operational
datastore during device initialization in Lithium design.

Fixes: bug 6764
Change-Id: Ib32f15b73febe4d9115884d418bfe87b8e716635
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoRemove reference to sal-inmemory-datastore config system file 27/44627/3
Alexis de Talhouët [Wed, 24 Aug 2016 20:42:20 +0000 (16:42 -0400)]
Remove reference to sal-inmemory-datastore config system file

As it was removed from the controller

Change-Id: Ied428beee2f46cfd000afcf9ca56e0f25c8c5594
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove excessive (trace) logging in FRS 72/45972/7
Andrej Leitner [Wed, 21 Sep 2016 12:34:38 +0000 (14:34 +0200)]
Remove excessive (trace) logging in FRS

 - removed not so necessary logging + some updates
 - added some finals
 - simplify statements

Change-Id: I0db57a38a45efd6bb8334a9f05cdba991bff556d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoMerge "BUG-6118: making the OFentityListener aware of the InJeopardy() flag"
Anil Vishnoi [Wed, 21 Sep 2016 07:09:23 +0000 (07:09 +0000)]
Merge "BUG-6118: making the OFentityListener aware of the InJeopardy() flag"

7 years agoMerge "ClusterSingletonService cleaning FRM/FRS"
Jozef Bacigal [Wed, 21 Sep 2016 06:52:28 +0000 (06:52 +0000)]
Merge "ClusterSingletonService cleaning FRM/FRS"

7 years agoMerge "Create DeviceMasterShipManager before forwarders"
Jozef Bacigal [Wed, 21 Sep 2016 06:38:47 +0000 (06:38 +0000)]
Merge "Create DeviceMasterShipManager before forwarders"

7 years agoFix translation to *packet.received.MatchBuilder 69/45869/2
Tomas Slusny [Tue, 20 Sep 2016 07:22:45 +0000 (09:22 +0200)]
Fix translation to *packet.received.MatchBuilder

Fix incorrect cast of *flow.MatchBuilder to
*packet.received.MatchBuilder in Helium plugin, what
was causing PacketInTranslator to be broken.

Fixes: bug 6456
Change-Id: I9e42402a3599dd2e0a91381019c4ca86e8294aa2
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoCreate DeviceMasterShipManager before forwarders 77/45877/2
Tomas Slusny [Tue, 20 Sep 2016 09:11:16 +0000 (11:11 +0200)]
Create DeviceMasterShipManager before forwarders

This prevents NPE when forwarder receives DataTreeChange
event faster thatn DeviceMasterShipManager is created.

Fixes: bug 6459
Change-Id: Ifb9d4520b58d9f5fc265934968386641c60772ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
7 years agoMerge "Bug 6749: Set the openflow connection config at xml file"
Shuva Jyoti Kar [Tue, 20 Sep 2016 11:14:42 +0000 (11:14 +0000)]
Merge "Bug 6749: Set the openflow connection config at xml file"

7 years agoBug 6749: Set the openflow connection config at xml file 58/45758/2
melserngawy [Fri, 16 Sep 2016 21:15:51 +0000 (17:15 -0400)]
Bug 6749: Set the openflow connection config at xml file

Set the openflow connections (default and legacy) inital configuration
to xml file to be able to change it after starting the distribution

The openflow TLS configuration was missing in the blueprint,
add it with default values

Change-Id: Iad34bd3d7e237da52fe3193c4ad6d6ff2141358c
Signed-off-by: melserngawy <melserngawy@inocybe.com>
7 years agoUpdate comments and imports after DataChangeListener changes 37/45837/2
Andrej Leitner [Mon, 19 Sep 2016 16:40:43 +0000 (18:40 +0200)]
Update comments and imports after DataChangeListener changes

Change-Id: Ic8174cc2627deb12d48f6d41444f2e9b4dc60406
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
7 years agoMerge "Update comments around flat-batch service"
Jozef Bacigal [Mon, 19 Sep 2016 12:33:38 +0000 (12:33 +0000)]
Merge "Update comments around flat-batch service"

7 years agoMerge "Convert openflowplugin-it to use DTCL instead of DCL"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:48 +0000 (12:32 +0000)]
Merge "Convert openflowplugin-it to use DTCL instead of DCL"

7 years agoMerge "Update old links in code to deprecated DataChangeListener"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:42 +0000 (12:32 +0000)]
Merge "Update old links in code to deprecated DataChangeListener"

7 years agoMerge "Convert OF samples to use DTCL instead of DCL"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:36 +0000 (12:32 +0000)]
Merge "Convert OF samples to use DTCL instead of DCL"

7 years agoFix connection closing before initialization 26/45526/5
Tomas Slusny [Tue, 13 Sep 2016 06:26:15 +0000 (08:26 +0200)]
Fix connection closing before initialization

Check if connection is fully initialized when closing
objects created during initialization phase to prevent
NPEs, what can cause incorrect close of connection
and later program unstability.

Also, increase timeout to propagate role to 10 seconds
in case of slower machine.

Resolves: bug 5271
See also: bug 6672

Change-Id: I0f009edf5fe3b382e2bfee64f72036ba599ccc5d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
7 years agoMerge "Bug 6665 Clean code"
Jozef Bacigal [Mon, 19 Sep 2016 08:30:48 +0000 (08:30 +0000)]
Merge "Bug 6665 Clean code"