ovsdb.git
8 years agoMerge "Fix Javadoc error."
Flavio Fernandes [Mon, 13 Jul 2015 21:49:46 +0000 (21:49 +0000)]
Merge "Fix Javadoc error."

8 years agoFix Javadoc error. 70/24070/1
Alexis de Talhouët [Mon, 13 Jul 2015 19:45:36 +0000 (15:45 -0400)]
Fix Javadoc error.

[ERROR] /Users/adetalhouet/Documents/odl/Beryllium/ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/NeutronL3Adapter.java:288: error: @param name not found
[ERROR] * @param action the {@link org.opendaylight.ovsdb.openstack.netvirt.api.Action} action to be handled.

Java version "1.8.0_45"

Change-Id: I460cb898c3a02678ecd4f58281bd289d607673e3
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoAdd showOvsdbMdsal.py tool 83/23983/3
Flavio Fernandes [Fri, 10 Jul 2015 13:48:35 +0000 (09:48 -0400)]
Add showOvsdbMdsal.py tool

This tool can provide useful info in regards to ovsdb's mdsal structures.
It looks at the operational or config trees in mdsal, depending on the
parameter '--config':

Patch set 2: code review

$ ./showOvsdbMdsal.py -h
Usage: showOvsdbMdsal.py [options]

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -d, --debug           Verbosity. Can be provided multiple times for more
                        debug.
  -n, --noalias         Do not map nodeId of bridges to an alias
  -i ODLIP, --ip=ODLIP  opendaylights ip address
  -t ODLPORT, --port=ODLPORT
                        opendaylights listening tcp port on restconf
                        northbound
  -u ODLUSERNAME, --user=ODLUSERNAME
                        opendaylight restconf username
  -p ODLPASSWORD, --password=ODLPASSWORD
                        opendaylight restconf password
  -c, --config          parse mdsal restconf config tree instead of
                        operational tree
  -f, --hide-flows      hide flows

Examples of what to expect:

  https://gist.githubusercontent.com/anonymous/3a952cec49ef92461752/raw/7abfedcd7790acc5b5cef07a2c08da0405f303c6/gistify465337.txt

Change-Id: Ica94e00a14d17682acdedad3b495833de330afc4
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Update README to reflect LBaaS postman collection."
Flavio Fernandes [Mon, 13 Jul 2015 19:17:28 +0000 (19:17 +0000)]
Merge "Update README to reflect LBaaS postman collection."

8 years agoMerge "Change log level of raw json rpc message"
Flavio Fernandes [Mon, 13 Jul 2015 19:16:56 +0000 (19:16 +0000)]
Merge "Change log level of raw json rpc message"

8 years agoChange log level of raw json rpc message 96/23796/3
Hsin-Yi Shen [Mon, 6 Jul 2015 21:00:37 +0000 (14:00 -0700)]
Change log level of raw json rpc message

When hypervisor/hardware vtep are not implemented in the right way and sending jsonrpc message with wrong format, the log of raw json rpc message helps debugging.

Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Change-Id: I033abdb251065dd19c8ee198417f04bcd152e761

8 years agoAdding more documentation/comments to the code. 28/24028/1
Marcelo Amaral [Sat, 11 Jul 2015 16:16:42 +0000 (18:16 +0200)]
Adding more documentation/comments to the code.

Change-Id: Ieb9b84fd53b400b3c01c5b583337dd480b2207c1

Signed-off-by: Marcelo C. Amaral <marcelo.amaral@bsc.es>
8 years agoUpdate README to reflect LBaaS postman collection. 15/24015/1
Alexis de Talhouët [Fri, 10 Jul 2015 19:53:39 +0000 (15:53 -0400)]
Update README to reflect LBaaS postman collection.

Change-Id: I53057cd71fed174debbf1e6be579fb36e3d76b41
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoAdd postman collection to interact with LBass. 55/23955/1
Alexis de Talhouët [Thu, 9 Jul 2015 16:28:17 +0000 (12:28 -0400)]
Add postman collection to interact with LBass.

This postman contains queries to interact with:
- pool
- pool member
- loadbalancer

It also contains queries to create a network, a subnet and two ports, in order to have a proper network topology for testing purposes.

Change-Id: I9bc1fd6e7d59abea5b22bb8260d79b9fa11e9dc9
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoBug 3962: Event dispatcher found no handler for NorthboundEvent (part 1) 33/23933/1
Flavio Fernandes [Wed, 8 Jul 2015 16:12:05 +0000 (12:12 -0400)]
Bug 3962: Event dispatcher found no handler for NorthboundEvent (part 1)

We cannot reproduce this locally, so this commit adds some better logs
to inform what handlers have this issue.

Patch set 2: code review.
Patch set 3: remove redundant param on the non-error path: ref.

Change-Id: I394984cf41f7e310919efdb7c4bbf394ba1fa89d
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
(cherry picked from commit 0b6e3a67980f9e30ba9cf07ddd0fd2d1c6664e1f)

8 years agoMerge Sonar fixes from stable/lithium.. 59/23859/2
Andre Fredette [Mon, 6 Jul 2015 13:54:57 +0000 (09:54 -0400)]
Merge Sonar fixes from stable/lithium..

Change-Id: I03d18ba2dcaa76de565d53bc9dd68f9b28c2b240
Signed-off-by: Andre Fredette <afredette@redhat.com>
8 years agoMerge "bug 3909: Disable SSLv3 connection for ovsdb server"
Flavio Fernandes [Tue, 7 Jul 2015 20:07:52 +0000 (20:07 +0000)]
Merge "bug 3909: Disable SSLv3 connection for ovsdb server"

8 years agoBug 3954: NPE exception in isDistributedArpDisabled() 53/23853/1
Flavio Fernandes [Tue, 7 Jul 2015 19:26:28 +0000 (15:26 -0400)]
Bug 3954: NPE exception in isDistributedArpDisabled()

Change-Id: I8eb3fbef43c3a37b67c297596ec70165a7d98e09
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agobug 3909: Disable SSLv3 connection for ovsdb server 39/23539/6
Hsin-Yi Shen [Mon, 29 Jun 2015 20:42:01 +0000 (13:42 -0700)]
bug 3909: Disable SSLv3 connection for ovsdb server

SSLv3 has known vulnerability.
For security reason, we should disable sslv3 protocol for ovsdb server.

Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Change-Id: I1267711efe7cebcd3252d81f184aab8782b6d72d

8 years agoMerge "Add ODL controller ready check before running robot tests"
Sam Hague [Mon, 6 Jul 2015 21:33:41 +0000 (21:33 +0000)]
Merge "Add ODL controller ready check before running robot tests"

8 years agoAdd ODL controller ready check before running robot tests 06/23606/7
Ben Eze [Tue, 30 Jun 2015 19:14:08 +0000 (15:14 -0400)]
Add ODL controller ready check before running robot tests

Change-Id: I8ee340873ee47af89373afe5ed81bcff787a524a
Signed-off-by: Ben Eze <beze@inocybe.ca>
8 years agoMerge "Update NeutronL3Adapter UT"
Sam Hague [Mon, 6 Jul 2015 18:40:04 +0000 (18:40 +0000)]
Merge "Update NeutronL3Adapter UT"

8 years agoMerge "Sonar bug fix: block of commented-out lines of code should be removed"
Sam Hague [Mon, 6 Jul 2015 16:49:26 +0000 (16:49 +0000)]
Merge "Sonar bug fix: block of commented-out lines of code should be removed"

8 years agoSonar bug fix: block of commented-out lines of code should be removed 84/23784/1
Raksha Madhava Bangera [Mon, 6 Jul 2015 16:24:05 +0000 (09:24 -0700)]
Sonar bug fix: block of commented-out lines of code should be removed

Signed-off-by: Raksha Madhava Bangera <raksha.madhava.bangera@intel.com>
8 years agoUpdate NeutronL3Adapter UT 35/23535/4
Alexis de Talhouët [Mon, 29 Jun 2015 21:04:33 +0000 (17:04 -0400)]
Update NeutronL3Adapter UT

Patch Set 1: initial commit
Patch Set 2: some more to go
Patch Set 3: some more tests - done with the class

Change-Id: I1081c7e70e7e437ac6260624c7f1b0cc4a5ceeae
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoUpdate OF13Provider UT 08/23708/2
Alexis de Talhouët [Thu, 2 Jul 2015 20:57:06 +0000 (16:57 -0400)]
Update OF13Provider UT

Change-Id: Idba5421b9a4f6e63e713f368c8dd3011c5c11819
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoBug 3893: provide well known url to know that net-virt topology is ready 14/23614/2
Flavio Fernandes [Tue, 30 Jun 2015 15:58:50 +0000 (11:58 -0400)]
Bug 3893: provide well known url to know that net-virt topology is ready

With this change, one can check the following url and know that ovsdb's netvirt
is up and functional:

   http://${ODL_IP}:8080/restconf/operational/network-topology:network-topology/topology/netvirt:1

Patch set 2: fix transaction
Patch set 3: code review, move new function to OvsdbInventoryServiceImpl
Patch set 4: typo (functional)

Change-Id: Ibe71d823b986fcdc9c12b6fa2a3994ae158fb696
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Added the robot framework to OVSDB VMs"
Flavio Fernandes [Mon, 29 Jun 2015 17:12:59 +0000 (17:12 +0000)]
Merge "Added the robot framework to OVSDB VMs"

8 years agoAdded the robot framework to OVSDB VMs 54/23454/9
Ben Eze [Fri, 26 Jun 2015 20:26:32 +0000 (16:26 -0400)]
Added the robot framework to OVSDB VMs

Change-Id: Ib57793b05661d5d5487788574ef65cfa990d3cb4
Signed-off-by: Ben Eze <beze@inocybe.ca>
8 years agoFix Javadoc errors. 29/23429/1
Alexis de Talhouët [Fri, 26 Jun 2015 14:21:16 +0000 (10:21 -0400)]
Fix Javadoc errors.

The build was failing due to those errors:
[ERROR] /ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/EgressAclProvider.java:13: error: @param name not found
 --> doesn't exist
[ERROR] /ovsdb/openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/IngressAclProvider.java:22: error: @param name not found
--> doesn't exist
[ERROR] /ovsdb/openstack/net-virt-providers/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/AbstractServiceInstance.java:205: error: @param name not found
--> Node instead of node

Java version "1.8.0_45"

Change-Id: I386bb5ba6be41c134c6f843f78ef06147528fd61
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoMerge "Sonar bug fix"
Flavio Fernandes [Fri, 26 Jun 2015 13:41:20 +0000 (13:41 +0000)]
Merge "Sonar bug fix"

8 years agoBug 3841 - wrong severity level: getTenantNetwork did not find network 78/23178/2
Flavio Fernandes [Tue, 23 Jun 2015 15:33:24 +0000 (11:33 -0400)]
Bug 3841 - wrong severity level: getTenantNetwork did not find network

when using normal ovsdb net-virt, I see benign logs like these:

WARN  | ntDispatcherImpl | TenantNetworkManagerImpl | 271 - org.opendaylight.ovsdb.openstack.net-virt - 1.1.0.SNAPSHOT | getTenantNetwork did not find network for patch-int

these should be debug at best; not warning.

Patch set 2: add changes from code review

Change-Id: I6f0b0aa6880c2b6892e5b9974ce5df6c0d217bf5
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoBug-2094 : less is more remove redundant code 70/23170/1
Flavio Fernandes [Tue, 23 Jun 2015 13:50:33 +0000 (09:50 -0400)]
Bug-2094 : less is more remove redundant code

In pipeline, there is no need to set register value to 0,
as that is the expected value upon classifier table.

Change-Id: Iea4c53c14be980713ff060c8c9df8869c60926df
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoBug 3831 - ignore unknown OVS interface and datapath types 53/23153/1
Eric Multanen [Mon, 22 Jun 2015 16:45:18 +0000 (09:45 -0700)]
Bug 3831 - ignore unknown OVS interface and datapath types

Ighore OVSDB interface or datapath types which are not
present in the MD-SAL southbound model (but are present
in the OVS nodes open_vswitch table iface-types or
datapath-types columns).

Tested by making a build of ODL which removed supported
types from the ODL code to varify the log warnings
were created.

Change-Id: I05e689fa2b2dc906e3083e4fc44ba60abdb1d352
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
(cherry picked from commit c525fd2b379171af656ffd060d9e520ab4e3854e)

8 years agoBug 3831 - add stt interface type to model 45/23145/1
Eric Multanen [Mon, 22 Jun 2015 15:47:17 +0000 (08:47 -0700)]
Bug 3831 - add stt interface type to model

On a build from openvswitch master branch, there was an
interface type 'stt' which was not included in the ovsdb.yang
model for the southbound MD-SAL.  When an OVSDB connection
was made to this OVS node, the operational md-sal failed
to populate.

Adding the 'stt' interface type to the model is a quick
fix.  A better fix would ignore types not present in the model.

Change-Id: Idf259998f73d43be587d19de73794a174d4d81d3
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
(cherry picked from commit 444b68f6f7637d9b4eb7e4f07c9ff6ced4e8ce76)

8 years agoSonar bug fix 42/23142/2
Raksha Madhava Bangera [Mon, 22 Jun 2015 20:26:36 +0000 (13:26 -0700)]
Sonar bug fix

Removing redundant 'public' keyword in interface in ConfigurationService.java

Signed-off-by: Raksha Madhava Bangera <raksha.madhava.bangera@intel.com>
8 years agoRemove frame size limit for scale OVS 56/20556/2
Sharon Aicler [Fri, 15 May 2015 19:04:03 +0000 (12:04 -0700)]
Remove frame size limit for scale OVS

Change-Id: I4f1c7e29c332964eea077fd6958453be34fa04a5
Signed-off-by: Sharon Aicler <saichler@cisco.com>
8 years agoBug 3647 :Operational not set correctly when other-config is removed from switch. 02/23102/3
Sharad Mishra [Mon, 22 Jun 2015 06:38:24 +0000 (23:38 -0700)]
Bug 3647 :Operational not set correctly when other-config is removed from switch.

similar to BZ 3647, but for other-config

Change-Id: I48f6636e5d3e67de024958a1e3b9e8efb7e6f8dc
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
8 years agoBug 3647 : Fix for bugzilla 3647 98/22998/4
Sharad Mishra [Thu, 18 Jun 2015 07:01:04 +0000 (00:01 -0700)]
Bug 3647 : Fix for bugzilla 3647

https://bugs.opendaylight.org/show_bug.cgi?id=3647

Change-Id: I504a7155050bb47e3eb768ab7420c8b5892af324
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
8 years agoBug-2094 : L3 North-South does not work -- fix outbound rewrite 66/22966/1
Flavio Fernandes [Fri, 19 Jun 2015 04:58:54 +0000 (00:58 -0400)]
Bug-2094 : L3 North-South does not work -- fix outbound rewrite

This set of changes will fix the outbound table (ie table 100) to
match on fixedIp associated with floatingIp, destined to neutron
router's mac. Packets that match the criteria will have rewrite
done, and be sent out of the patch-port in br-int.

Pat set 2: Fix copy and paste mistake in testProgramIpRewriteRule()

Change-Id: I2fc3f1f88b8cb9f26aaf0b69fda6836a1cebd264
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Added Vagrant images to run CSIT."
Flavio Fernandes [Fri, 19 Jun 2015 00:56:28 +0000 (00:56 +0000)]
Merge "Added Vagrant images to run CSIT."

8 years agoAdded Vagrant images to run CSIT. 46/22946/1
Ben Eze [Thu, 18 Jun 2015 14:20:55 +0000 (10:20 -0400)]
Added Vagrant images to run CSIT.

Change-Id: I147cb90878f8f8af6d535b2b15988e9221777a4c
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
Signed-off-by: Ben Eze <beze@inocybe.ca>
8 years agoBug-2094 : L3 North-South does not work -- fix inbound rewrite 45/22945/1
Flavio Fernandes [Wed, 17 Jun 2015 12:37:12 +0000 (08:37 -0400)]
Bug-2094 : L3 North-South does not work -- fix inbound rewrite

This set of changes will fix the inbound table (ie table 30) to use reg3
to track the ip rewrite. Also, changes added to routing table (talbe 60)
so that reg3 match can route packet into tenant segmentation.

Patch set 2: code review.
Patch set 3: fix test to account for removal of inboundIpRewriteExclusionCache.

Change-Id: I53b327da1631ac35aa7aaa519e0e9945d017fb3e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoBug-2094 : L3 North-South does not work -- fix ARP table 44/22944/1
Flavio Fernandes [Tue, 16 Jun 2015 00:42:36 +0000 (20:42 -0400)]
Bug-2094 : L3 North-South does not work -- fix ARP table

This set of changes will fix the ARP responder table (ie table 20) to properly
handle the responding of ARP queries made on br-ex for the associated floating
ip addresses.

Change-Id: I72c5f24d00a42fb011441849adfdb244ba01937b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Skeleton for the ovsdb-ui feature"
Flavio Fernandes [Tue, 16 Jun 2015 20:28:16 +0000 (20:28 +0000)]
Merge "Skeleton for the ovsdb-ui feature"

8 years agoSkeleton for the ovsdb-ui feature 88/20288/5
Maxime Millette-Coulombe [Wed, 10 Jun 2015 20:27:26 +0000 (16:27 -0400)]
Skeleton for the ovsdb-ui feature

Folders structure and basic files to create and add a external
module on DLUX. It also include a CRUD implementation of
the southbounds REST API.

Change-Id: If48eb4d055db3b91529e76e75503aa4c68b0c6a3
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
8 years agoBug 3752 : NPE at SouthboundMapper.java -- createControllerEntries 06/22706/1
Flavio Fernandes [Tue, 16 Jun 2015 14:51:25 +0000 (10:51 -0400)]
Bug 3752 : NPE at SouthboundMapper.java -- createControllerEntries

Check that ovsdbBridgeAugmentation.getControllerEntry() is not
returning null

Change-Id: I2b91710e6d388309f524797a2a2584e37e1cc4de
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoBug 3379:java.lang.IllegalArgumentException: ControllerEntryKey 31/22531/1
Sam Hague [Sat, 13 Jun 2015 16:26:08 +0000 (12:26 -0400)]
Bug 3379:java.lang.IllegalArgumentException: ControllerEntryKey

Change-Id: I60ff0485707445ac119d76a5046a708a63f302fa
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBug 3379:java.lang.IllegalArgumentException: ControllerEntryKey 29/22529/1
Sam Hague [Tue, 9 Jun 2015 19:50:00 +0000 (15:50 -0400)]
Bug 3379:java.lang.IllegalArgumentException: ControllerEntryKey

Problem: OVSDB Controller updates are indpendent of Bridge updates but the ovsdb.yang model includes the controller data in the OVsdbBridgeAugmentation. This existing code assumed that the Controller and Bridge updates would be together and thus would always have the OvsdbBridgeAugmentation to update. That is not the case since the Controller updates can be received without a Bridge update.

Solution: Add the ControllerEntry to the OvsdbBridgeAugmentation using the Bridge if it was included with the Controller update. Otherwise, find all the OvsdbBridgeAugmentations for the connection and update them if they are using the updated Controller.

Patch also includes updates to SouthboundIT and NetvirtIT. NetvirtIT was needed so that the isConnected=true case would be tested. Southbound does not include the openflowplugin but Netvirt does. The openflowplugin is needed to test when the switch connects to the openflow controller.

Other fixes were made to the existing testOvsdbBridgeControllerInfo(). That test was using the ovsdb node ip:port as the controller target but it should have been the controller's ip:port.

Change-Id: I30785dbdf955614ad6fc675507da048434c2485e
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit fd1b45b2100fb2bfe7a7b58295cebdc949833680)

8 years agoMerge "Bug 3681 - Uncaught ConnectException leaves library in bad state"
Sam Hague [Sat, 13 Jun 2015 13:45:08 +0000 (13:45 +0000)]
Merge "Bug 3681 - Uncaught ConnectException leaves library in bad state"

8 years agoMerge "Bug 3681 - Uncaught ConnectException leaves library in bad state"
Sam Hague [Sat, 13 Jun 2015 13:44:55 +0000 (13:44 +0000)]
Merge "Bug 3681 - Uncaught ConnectException leaves library in bad state"

8 years agoMerge "Separation of ARP Responder from config.ini. Amended to use ConfigurationServi...
Flavio Fernandes [Fri, 12 Jun 2015 21:05:08 +0000 (21:05 +0000)]
Merge "Separation of ARP Responder from config.ini. Amended to use ConfigurationService & fix comments"

8 years agoSeparation of ARP Responder from config.ini. Amended to use ConfigurationService... 55/22055/4
evvy [Fri, 12 Jun 2015 20:05:15 +0000 (01:35 +0530)]
Separation of ARP Responder from config.ini. Amended to use ConfigurationService & fix comments

Change-Id: I2dac1bec77bdc9818489dc7773a8804464a7bad5
Signed-off-by: evvy <dhiraviam.natarajan@gmail.com>
8 years agoFix Bug 3663: Wrong assert statement causing test failure. 67/22467/2
Alexis de Talhouët [Fri, 12 Jun 2015 13:14:07 +0000 (09:14 -0400)]
Fix Bug 3663: Wrong assert statement causing test failure.

Also remove a System.out than shouldn't have been there in a first place.

Change-Id: Iad4a3968451d57ff7fe4d37ea380f583ffc9d3c7
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoAdding test case to set-target controller for a bridge and verify if it is set in... 26/22426/2
Praveen Mala [Fri, 12 Jun 2015 01:06:27 +0000 (21:06 -0400)]
Adding test case to set-target controller for a bridge and verify if it is set in the bridge as expected

Change-Id: I85b29409178716920c6e0859580f035055a0901c
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
8 years agoMerge "Fix Bug 3663: Update netvirt.provider UT"
Sam Hague [Fri, 12 Jun 2015 00:40:42 +0000 (00:40 +0000)]
Merge "Fix Bug 3663: Update netvirt.provider UT"

8 years agoBug 3681 - Uncaught ConnectException leaves library in bad state 21/22421/3
Sam Hague [Fri, 12 Jun 2015 00:05:19 +0000 (20:05 -0400)]
Bug 3681 - Uncaught ConnectException leaves library in bad state

Change-Id: I282162be62d9b6d8deb94906dddac9df766255eb
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBug 3681 - Uncaught ConnectException leaves library in bad state 20/22420/2
Sam Hague [Fri, 12 Jun 2015 00:05:09 +0000 (20:05 -0400)]
Bug 3681 - Uncaught ConnectException leaves library in bad state

Change-Id: Iccf9be6e7e08b0fd77f0ee47a71b92640890a9df
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Bug 3141 - OVSDB southbound operational MDSAL stops getting populated after...
Sam Hague [Fri, 12 Jun 2015 00:18:11 +0000 (00:18 +0000)]
Merge "Bug 3141 - OVSDB southbound operational MDSAL stops getting populated after ovs-vsctl del-manager"

8 years agoMerge "Bug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation"
Sam Hague [Fri, 12 Jun 2015 00:17:41 +0000 (00:17 +0000)]
Merge "Bug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation"

8 years agoBug 3141 - OVSDB southbound operational MDSAL stops getting populated after ovs-vsctl... 04/22404/1
Sam Hague [Thu, 11 Jun 2015 20:46:22 +0000 (16:46 -0400)]
Bug 3141 - OVSDB southbound operational MDSAL stops getting populated after ovs-vsctl del-manager

The symptom looked like the OvsdbDataChangeListener#onDataChanged() was not being called when the node was added back to config (after it was deleted from operational followed by deleted from config)

This was because of a AbstractFuture.get() was not returning. This was a get() for the transaction responses for ovsdb transactions. In this particular path the node was deleted from oeprational. Then the node is deleted from config. During the processing of the config update there was an expectation that some ovsdb updates would happen but there aren't any because the node was already removed from operational and there is no active connection to the ovsdb node. This caused the invoker thread to block on the future result.get(). Later when the node was added to config, the onDataChanged() was not called since the thread was still blocked on the get().

Solution: check if there were any ovsdb transactions and not call get() if there aren't any.

Change-Id: Id183aed2ae9b4f1d156cf89d7899a1868a6451f6
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation 03/22403/1
Sam Hague [Thu, 11 Jun 2015 20:45:53 +0000 (16:45 -0400)]
Bug 3676 - OvsdbNodeRemoveCommand .. had no OvsdbNodeAugmentation

Change-Id: I40684762bdd9f4933afbe67a58540e1cfc4b8a35
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoFix Bug 3663: Update netvirt.provider UT 88/22388/1
Alexis de Talhouët [Thu, 11 Jun 2015 18:47:17 +0000 (14:47 -0400)]
Fix Bug 3663: Update netvirt.provider UT

This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt.provider package

Change-Id: I40b73ae5efe472449b2b3a11e91dbef6d5bf24cc
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoMerge "Fix Bug 3663: Update netvirt.impl UT"
Sam Hague [Thu, 11 Jun 2015 14:53:29 +0000 (14:53 +0000)]
Merge "Fix Bug 3663: Update netvirt.impl UT"

8 years agoMerge "Fix Bug 3663: Update netvirt UT"
Flavio Fernandes [Thu, 11 Jun 2015 14:43:42 +0000 (14:43 +0000)]
Merge "Fix Bug 3663: Update netvirt UT"

8 years agoFix Bug 3663: Update netvirt.impl UT 89/22289/4
Alexis de Talhouët [Wed, 10 Jun 2015 16:18:48 +0000 (12:18 -0400)]
Fix Bug 3663: Update netvirt.impl UT

This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt.impl package

Change-Id: If9864fc98385c602627b279653875875fdcf700c
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoFix Bug 3665: Call the nodeCache.remove() by passing the NodeId. 95/22295/1
Alexis de Talhouët [Wed, 10 Jun 2015 18:40:50 +0000 (14:40 -0400)]
Fix Bug 3665: Call the nodeCache.remove() by passing the NodeId.

Change-Id: I7b55ef7e86c76f473e9dc044f5441d989034a52b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoFix Bug 3663: Update netvirt UT 07/22207/3
Alexis de Talhouët [Tue, 9 Jun 2015 14:46:29 +0000 (10:46 -0400)]
Fix Bug 3663: Update netvirt UT

This patch update all the test classes within the
org.opendaylight.ovsdb.openstack.netvirt package

Change-Id: I8f747293f9283bc4f3c0823f4504a63dd59a03c0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoChange EventDispatcher field visibility of AbstractHandler to protected. 10/22210/1
Alexis de Talhouët [Tue, 9 Jun 2015 15:04:04 +0000 (11:04 -0400)]
Change EventDispatcher field visibility of AbstractHandler to protected.

Instead of having EventDisptacher private, we set it as protected thus
all the classes that extends AbstractHandler can use the variable.
This patch remove:
- the setDispatcher() method from AbstractHandler
- the declared EventDispactcher field of the classes extending AbstractHandler

Change-Id: Idbd000def09aa91cc4e40976ac4a37274bfce762
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoBug-2094 : L3 North-South does not work 17/21917/1
Flavio Fernandes [Wed, 3 Jun 2015 10:45:15 +0000 (06:45 -0400)]
Bug-2094 : L3 North-South does not work

Create br-ex and add patch port between br-int and br-ex when L3 fwd is enabled.

Patch set 2: Use consts for patch port names
Patch set 3: Use config to determine if l3 fwd is enabled
Patch set 4: Fix tests part 1 of 2
Patch set 5: Fix tests part 2 of 2
Patch set 6: Add changes from code review

Change-Id: I2425d83c68025617a50000f98c4e60b3a9a15ee8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Also-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 6940c8d516345a3e9b11e148830d881053edfde7)

9 years agoBug 3310 Bug 3316: Fix for iids for termination points 27/21827/1
Ed Warnicke [Sat, 30 May 2015 18:02:57 +0000 (11:02 -0700)]
Bug 3310 Bug 3316: Fix for iids for termination points

Change-Id: I9174fe480fc95570e52095474c3e9ae78b8efd8e
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit 5c5ed0bec9b9f908d97d024549cb754f3898d5eb)

9 years agoBug 3310 Bug 3316: Fix for iids for bridges 41/21141/2
Ed Warnicke [Thu, 21 May 2015 20:55:25 +0000 (13:55 -0700)]
Bug 3310 Bug 3316: Fix for iids for bridges

Change-Id: Ieabaa7040cbcdc8e72a2aae21a9181667c543880
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit 004394b0b3da86ddb506c757b8c5f110d916b02a)

9 years agoBug 3310 Bug 3316 Use iid stamp if we configured a connection, otherwise systemid 52/20652/6
Ed Warnicke [Fri, 15 May 2015 16:42:36 +0000 (09:42 -0700)]
Bug 3310 Bug 3316 Use iid stamp if we configured a connection, otherwise systemid

This has been tested, and passes  SB IT tests (all 21)
As well as manually tested beyond their coverage.

PatchSet3: Switch to using ovsdb://uuid/<uuid> for default
NodeKey for OPER nodes we discover that we did not configure.

Conflicts:
southbound/southbound-it/src/test/java/org/opendaylight/ovsdb/southbound/it/SouthboundIT.java

Change-Id: I270a64e13a6fca257b49d2e2ff34f754698c2df4
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Slight refactoring of the lifecycle of data"
Sam Hague [Wed, 3 Jun 2015 17:22:25 +0000 (17:22 +0000)]
Merge "Slight refactoring of the lifecycle of data"

9 years agoMerge "Bug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address"
Flavio Fernandes [Wed, 3 Jun 2015 17:11:27 +0000 (17:11 +0000)]
Merge "Bug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address"

9 years agoMerge "Add per test information"
Flavio Fernandes [Wed, 3 Jun 2015 17:10:21 +0000 (17:10 +0000)]
Merge "Add per test information"

9 years agoSlight refactoring of the lifecycle of data 04/20404/5
Ed Warnicke [Thu, 14 May 2015 15:13:56 +0000 (08:13 -0700)]
Slight refactoring of the lifecycle of data

With this patch, we change slightly the manner in which we handle
data change events (including connections)

Previously, when we got a DataChangeEvent we'd try the following

1)  connect(changes) - do all the work for connecting, including
     registeringCallbacks
2)  connectionUpdate - handle connection updates
3)  updateData - use transact to write any data changes to the ovsdb instance
4)  disconnect - disconnect anything if needed

Now we have changed this so that
a)  #1 (connect) - does *not* registerCallbacks
b)  Added a 5) registerCallbacks

The reason this was done is so that the normal pipeline for writing data
can handle flushing the externalId for the OpenVSwitch table down to ovsdb
*before* we registerCallbacks and have it come back to the operational data
store.

Conflicts:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java

Change-Id: I105dd01bf87b1be170e2c4082a7914fba2002249
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Write iid of ovsdb-node to OpenVSwitch.externalIds"
Sam Hague [Wed, 3 Jun 2015 16:39:50 +0000 (16:39 +0000)]
Merge "Write iid of ovsdb-node to OpenVSwitch.externalIds"

9 years agoWrite iid of ovsdb-node to OpenVSwitch.externalIds 27/20327/5
Ed Warnicke [Thu, 14 May 2015 04:31:54 +0000 (21:31 -0700)]
Write iid of ovsdb-node to OpenVSwitch.externalIds

Change-Id: I4fbdd5499b19d452f253a3600944aecced59dafc
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit 3747b449b15deccb33d152924c492647a92c8d25)

9 years agoSwitch from using OvsdbCreateCommand to using OpenVSwitchUpdateCommand 22/20322/4
Ed Warnicke [Thu, 14 May 2015 02:51:28 +0000 (19:51 -0700)]
Switch from using OvsdbCreateCommand to using OpenVSwitchUpdateCommand

Have the initial registration of the ovsdb-node come from getting
the OpenVswitch table data come to use from the monitor command in the
initial db dump.

This passes all SB-IT tests:

Tests run: 21, Failures: 0, Errors: 0, Skipped: 0

Change-Id: If098081bb89292f0bac320659b41fa05994e195e
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
9 years agoPass OvsdbConnectionInstance to Commands instead of ConnectionInfo 19/20319/6
Ed Warnicke [Thu, 14 May 2015 02:17:38 +0000 (19:17 -0700)]
Pass OvsdbConnectionInstance to Commands instead of ConnectionInfo

This is in preperation to have the adding of ovsdb-nodes handled
by the OpenVSwitchUpdateCommand, so it can write the iid to the
externalIds.

Change-Id: Ib478c776e0906e7424b5759422d0be986dccdc29
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
(cherry picked from commit 02c8562dfca6d7863ae6cdf34ef502d6a4ad370d)

9 years agoBug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address 93/21793/1
Anil Vishnoi [Wed, 3 Jun 2015 13:33:47 +0000 (19:03 +0530)]
Bug 3563 - Fix/clean methods that determine the OpenFlow Controller ip address

Change-Id: I420a10e769be016efa0a4e6c71d863fd39c12e23
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit 94dbb902c1f020c87407ba0fb87ff770dea01cbc)

9 years agoAdd per test information 13/21713/1
Sam Hague [Wed, 3 Jun 2015 02:12:12 +0000 (22:12 -0400)]
Add per test information

Change-Id: I4859e9977db5099485fe53c4bc663bd484a61ed5
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoFix for bug 3538 88/21688/1
shc411 [Tue, 2 Jun 2015 06:46:33 +0000 (15:46 +0900)]
Fix for bug 3538

in removeOutputPortFromInstructions function,
when reordering the actionList setKey should be used same key with order.

Change-Id: I3ab3b6c9bbf6bf0b3914dc0819501177f37dc31a
Signed-off-by: shc411 <jung33@gmail.com>
9 years agoRemove northbound and compat it tests 12/21512/1
Sam Hague [Sun, 31 May 2015 16:07:18 +0000 (12:07 -0400)]
Remove northbound and compat it tests

Change-Id: Ie2b3cd0342cc97f660949873b9d50fa1378071db
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoBug 3332: Fix connections made to an ODL instance 34/20934/2
Eric Multanen [Thu, 21 May 2015 20:04:02 +0000 (13:04 -0700)]
Bug 3332: Fix connections made to an ODL instance

If an OVSDB connection is made via OVSDB SB MD-SAL
to self (same ODL) or another ODL instacne, the
OVSDB SB provider would hang or otherwise stop working.
This fixes by returning a null list to the 'list_dbs'
command.

v2 - remove white space
     When an OVSDB connection is established,
     the first request that the OVSDB Southbound makes is a
     list_dbs command.  By returning an empty db list, two
     things occur:
     1 - the request gets a response
     2 - the empty db list signals an uninteresting connection

Change-Id: I295dd47b821f7ec4ead0eb489a1b124cc574e8cf
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
9 years agoMerge "Fixing sonar issues on ConfigurationServiceImpl.java"
Flavio Fernandes [Fri, 29 May 2015 20:46:17 +0000 (20:46 +0000)]
Merge "Fixing sonar issues on ConfigurationServiceImpl.java"

9 years agoBug-3425 : Cont. minor changes to incorporate the code review from Sam 52/21452/3
Flavio Fernandes [Fri, 29 May 2015 15:12:02 +0000 (11:12 -0400)]
Bug-3425 : Cont. minor changes to incorporate the code review from Sam

Change-Id: I859864631f2842af48ad044ff7305ceeec5bf9ff
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoBug-3425 : VM doesn't get the ip address from DHCP 66/21366/2
Anil Vishnoi [Thu, 28 May 2015 19:56:35 +0000 (01:26 +0530)]
Bug-3425 : VM doesn't get the ip address from DHCP
server, if network is not attached to the router

This failure happens when net-virt don't find tunnel port in
the Node update from operational data store.
It tries to extract termination point from node update which
doesn't have tunnel port termination point. And because
there are other termination point exist, it doesn't go and
read from data store. ProgrammeTunnelPort() method iterate
through these existing termination points and it doesn't find the
tunnel port and it returns without installing the Local Ingress
Bridge Rules. This patch first try to create a tunnel configuration
on integration bridge of both end node of the tunnel and then
installs the tunnel flows. Also while installing tunnel flows
It specifically look for tunnel port in the nodes update and  if
it doesn't find that it reads it from data store.

Change-Id: I61e70c230051908a12f6ea93b9b2d046b699eccb
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoFixing sonar issues on ConfigurationServiceImpl.java 97/18497/5
Leo Cavalcanti [Thu, 16 Apr 2015 22:48:50 +0000 (19:48 -0300)]
Fixing sonar issues on ConfigurationServiceImpl.java

Change-Id: Ic042ebc8605b23eea7d8a9db089f0cf6b1206e9b
Signed-off-by: Leo Cavalcanti <leozinho@gmail.com>
9 years agoRemove adsal-related modules from features 09/21409/3
Sam Hague [Fri, 29 May 2015 11:55:52 +0000 (07:55 -0400)]
Remove adsal-related modules from features

Change-Id: Id53932e243803e8d1cfc58b438cebaadb7fbcf1f
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoIncrementing versions by 0.1.0 for post-lithium master branch 59/21359/1
Flavio Fernandes [Thu, 28 May 2015 17:43:42 +0000 (13:43 -0400)]
Incrementing versions by 0.1.0 for post-lithium master branch

Change-Id: I57d093485b91eba70b43dfd02e6bda9868a6426c
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoMerge "Add sonar report to SouthboundIT"
Flavio Fernandes [Thu, 28 May 2015 17:32:40 +0000 (17:32 +0000)]
Merge "Add sonar report to SouthboundIT"

9 years agoMerge "Modify testGetOvsdbNodes to allow multiple connected nodes"
Flavio Fernandes [Thu, 28 May 2015 17:32:30 +0000 (17:32 +0000)]
Merge "Modify testGetOvsdbNodes to allow multiple connected nodes"

9 years agoMerge "Enable sonar for netvirt and southbound"
Flavio Fernandes [Thu, 28 May 2015 17:10:24 +0000 (17:10 +0000)]
Merge "Enable sonar for netvirt and southbound"

9 years agoAdd sonar report to SouthboundIT 53/21353/1
Sam Hague [Thu, 28 May 2015 17:03:07 +0000 (13:03 -0400)]
Add sonar report to SouthboundIT

Change-Id: Ia99e9d322ba21de85fe570926647398d8ada7806
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoModify testGetOvsdbNodes to allow multiple connected nodes 52/21352/1
Sam Hague [Thu, 28 May 2015 16:58:33 +0000 (12:58 -0400)]
Modify testGetOvsdbNodes to allow multiple connected nodes

Change-Id: Id5640716224e3d0803fcc26822c3d567e0c95f76
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoEnable sonar for netvirt and southbound 41/21341/2
Sam Hague [Thu, 28 May 2015 13:01:12 +0000 (09:01 -0400)]
Enable sonar for netvirt and southbound

Change-Id: I97177b841ab0cfac92fe705f0aa6a61a2ab5f1eb
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoBug 3404: Check dstNode together with src and dst to make sure tunnel can be created 23/21323/2
Flavio Fernandes [Thu, 28 May 2015 12:56:38 +0000 (08:56 -0400)]
Bug 3404: Check dstNode together with src and dst to make sure tunnel can be created

Patch 2: add code review request

Change-Id: Ia170452f4275fb665d0ecbd6da304af6d1233474
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoRemove unused files 81/21281/1
Sam Hague [Wed, 27 May 2015 22:55:01 +0000 (18:55 -0400)]
Remove unused files

Change-Id: I0ced05c1b65691de7d3cfb8d1971678dc7af5af1
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoRename MdsalUtils to be Southbound and remove statics 65/21265/1
Sam Hague [Wed, 27 May 2015 20:18:59 +0000 (16:18 -0400)]
Rename MdsalUtils to be Southbound and remove statics

Change-Id: I621d9c8a4d31bce707b64cc70de7c872963f9ba3
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoCreate node-iid in a connection-info agnostic way 42/21242/1
Anil Vishnoi [Wed, 27 May 2015 17:00:23 +0000 (22:30 +0530)]
Create node-iid in a connection-info agnostic way

Cleaned up MdsalHelper class as well, removed unused methods.

Change-Id: I521ff23be712ea2be16ce71d6921fe91f67f98d9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoBug 2991: Handle cases when neutron network has no segmentationId 30/21230/1
Flavio Fernandes [Wed, 27 May 2015 16:02:19 +0000 (12:02 -0400)]
Bug 2991: Handle cases when neutron network has no segmentationId

External networks have no tenant segmentation id. Because of that, code
must not assume that field is non-null.

Change-Id: Ifaebe02c76c1a769cee79f54e11233dae2dcce6d
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
9 years agoMerge "Reenable BridgeConfigurationManagerImplTest"
Flavio Fernandes [Wed, 27 May 2015 12:08:20 +0000 (12:08 +0000)]
Merge "Reenable BridgeConfigurationManagerImplTest"

9 years agoReenable BridgeConfigurationManagerImplTest 67/21167/1
Sam Hague [Wed, 27 May 2015 03:12:45 +0000 (23:12 -0400)]
Reenable BridgeConfigurationManagerImplTest

Change-Id: Iae4f40a899d7fed9013defcff51ee1d22b4794c4
Signed-off-by: Sam Hague <shague@redhat.com>