Removed checkstyle warnings.

Change-Id: I040d5f047235ca2807fae021d21df85079104604
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-602: Fixed PcepRpObjectWithPstTlvParser Tlvs augmentation class

Change-Id: Ic824b025139261e9d8c0348c26da7c6e860f24bb
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Bug-607: Segment Routing TLVs parsers/serializers"

BUG-1132: update netty dependency to 4.0.19

Follow-up patch, since controller has already moved.

Change-Id: I01ebfb185918f0ebc4802e394ffaa76dbba7a7f7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Checkstyle plugin check - bgpcep"

Ensured numbering in augmentations with same target name.

Change-Id: If3ba934595b0044678156f7ccd87c17fa82f1d9a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fixed remove-lsp (stateful07), added remove=true to SRP object.
- fixed typo

Change-Id: I01fcb728ec1138f4ea7b6df9332e0a8a2335f6ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Checkstyle plugin check - bgpcep

    -violations do not fail build
    -rules defined in yangtools/common/checkstyle-logging

Change-Id: Idd7cdb368979ce200325a9562342d02876e18f37
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "Fixed CInitiated00SrpObjectParser"

Merge "Bug 607 - PCEP Segment Routing - yang model"

Fixed wrong handling of LSP argument in stateful07.

Change-Id: Ibd9d2432631ffa302dc8fb8738fc7c242cd905c9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-607: Segment Routing TLVs parsers/serializers

-added parser/serializer for Path Setup Type Tlv + augmented RP and SRP object
-added parser/serializer for SR PCE Capability Tlv + augmented Open Object
-added parsers/serializers junit tests
-added activator

Change-Id: Ib800bdc12ed78f89e39b3df185e006707bd702b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fixed CInitiated00SrpObjectParser

-fixed parser/serializer to be able read/write TLVs
-removed "final" keyword from class declaration - to be extensible class

Change-Id: I127575163677aeda2813940180007059ea7edbe0
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 607 - PCEP Segment Routing - yang model

-created yang model odl-pcep-segment-routing02
-based on http://tools.ietf.org/html/draft-sivabalan-pce-segment-routing-02
-SR-ERO object and subobject
-SR-PCE-CAPABILITY TLV
-related augmentation

-created yang model odl-pcep-lsp-setup-type01
-based on http://tools.ietf.org/html/draft-sivabalan-pce-lsp-setup-type-01
-PATH-SETUP-TYPE TLV
-related augmentations

Change-Id: I9d0b0d1a1ad4adae843c04009d3259fd23f50f2a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Added missing augment.

Change-Id: Ia33695afab751e21396d5cd94f86e657ddb2be6a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed failing PCEP tests (wrong readerIndex handling).

Change-Id: I12f54f56b47c40ceed2b40b3981862bcf822fdd4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switched Labels to ByteBuf.

Change-Id: Ib3ff3cc49022af0193c55d7d0fef6f872ac4f250
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switch XRO to ByteBuf.

Change-Id: I2122ef661f5697a7e8cff8c293aa24b7c200cd0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switched ERO to ByteBuf.

Change-Id: Ifb376786285f8dc0abce2405dcdadb9f1f7d0883
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed unnecessary checks for SRP-ID value.

Change-Id: Ie01e1e47a6b956bfd3c5f15fac3a57fdcca20ef0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switched RRO subobjects to ByteBuf.

Change-Id: I0a353e9c0196be8b3524014a65ab387c8e09e541
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switched PCEP Tlvs to ByteBuf

Change-Id: I103e4bf0c5104993cded9c281795571786379889
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switch PCEP objects to ByteBuf.

Change-Id: I14a6f1877e0feeb08499807b51632630a79104e3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-612 : switched PCEP message parsing to ByteBuf.

Change-Id: I4f68539bd8b70097f62506ad655f1d899ef4204f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed additional check for SRP-ID value.

Change-Id: I63b1769899d80dcf94589ba0e62740e8d564ccae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed various small bugs when testing stateful07 version.
- srp & lsp serializers assumed all flags are present
- missing augmentation of lsp in add-lsp operation

Change-Id: I945fe7adf5f3352760dda8936c74642de91f7f94
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed test failing on windows because of missing resources.

Change-Id: Ic8218f4ce0f6c45995e3ae510377c73fecd901d2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix integration tests failing on yangtools.util

Yangtools has introduced a new package, which is now required by some of
our dependencies. List it in the pax-exam config.

Change-Id: I9a762339163698fb51e93a8833f8316c3c378b9f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-429 : fixed unstable tests when two verify jobs are running.

Change-Id: I176a9322b5f33d2349cc25be9d71d74112bb1cc1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed unused and deprecated message type class.

Change-Id: Ie9586811155b7f689c4446f858df8d2fa88605a4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-730 : added test for pcep-spi util classes.

Change-Id: I1c89c176a0a5567dd3e2b102e498c47330edced5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Adjusted SRP-ID range to include 0.

Change-Id: I5c5bcf160c727f018d15f0bc82f107442950a058
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Quick fix for failing PAX tests.

This test removes TestHelper that was copied from controller.
There are several drawbacks of current usage of PAX, that this commit
is not solving:
* several abstract classes, each defines its own configuration that is hard
to merge into TestHelper
* PAX in general is not helpful when dealing with resolvation and other errors
* these tests are not run with the actual distribution

Change-Id: Ib4304b3bf3d7e0f0dd33322f0f53de294e66f53f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>

Fixed Ipv4 topology appearing in ipv6 slot.

Change-Id: I4543e4fddba97444190b17b5c46cc334511be131
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Improved logging in PCEP.

Change-Id: I65fc9ff9ab7409317e2cb43033534ad643efb051
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Improved logging in BGP.

Change-Id: Id9d8f726a4ca255280be0ea31e1b217af64c72ee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Concepts cleanup.

Change-Id: I7ecc2989c14d26c47a8b0add293cd678871ef6fe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Refactoring util.

Change-Id: I9c26d821c8ebc9c959c966de3b347fc16413895c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-731: rename LSPID and SRPID"

Refactoring of linkstate module.

- removed ByteList
- refactor to use Multimap to allow for multiple keys in map
- simplified AdjRIBsIn class
- use UnsignedInteger for casting back longs

Change-Id: Iebdf4081bad909fd861d8a10b8b7286f70962038
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: rename LSPID and SRPID

This adds a bit of documentation and renames the offending generic
arguments to L (for LSP) and S (for SRP).

Change-Id: I2854f2cbc5df345b4febcebc229f7ec22ae5c7fc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Removing deprecated getType() method from serializers.

Change-Id: I502916e21f74f546f3e374fa5bdabdcf242731d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-730 : added tests for Encoders/Decoders in PCEP."

BUG-731: do not throw Exceptions

This patch updates the configuration bindings to declare concrete
exceptions as thrown.

Furthermore it removes the ability for a LocRIBListener to throw checked
exceptoins: implementations are expected to handle them from now on.

Change-Id: Iaf4785075ea901af5cd9d9a9ad5e9954526e9a93
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-730 : added tests for Encoders/Decoders in PCEP.

Change-Id: I07fca73a415f78c7f3e15f5522ea22efbccb44fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Move uptodate into its own container

This patch side-steps the need to read the entire table in order
to update a single leaf (uptodate) by moving it into its own container.

Change-Id: Ib9f31cd4d10e2c2808b374a215ee6f4325e95ef3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix nagasena artifact ID

Change-Id: Ic955d272d1007b18dabdd8093e8b6bbc9d220129
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-632: add missing module"

BUG-632: add missing module

This adds the missing controller-config module for TCPMD5.

Change-Id: Id61f93ab9e2c3aaf50ce4b37bd02bded37b4458c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: reduce field visibility

Sonar correctly reports these fields should be private. Let's add
accessors and hide them.

Change-Id: I97e4f6443d22a9b9ed90c3bdab8c3db251d5e4f3
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: limit protected field visibility

One field can become private, others get @VisibleForTesting

Change-Id: I2d5214620a83953dae080d4a1f67e1e6470944e9
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: hide visible fields

Fields in private class need to have non-private access, so squash the
associated warnings.

Change-Id: Ib285c8d17230452f8958a85e5c2cb0d0fb54df0f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: hide serverSessionManager

It should not be visible, so expose the only functionality required by
subclasses.

Change-Id: Ic90c71080ed14cfcb1afbc67f18f85ab9888ffa5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: simplify CommunitiesParser

We can unify some parts of into common codepaths, so let's do it.

Change-Id: I1e9acba475b5b35e5aba670937776ee9d5e9c236
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bug 187 - PCEP: object parser - report correctly unknown objects"

Bug 187 - PCEP: object parser - report correctly unknown objects

-differs between unknown object-class and object-type, returns proper error

Change-Id: I04c5f274294793776c84c4de8875e22d71b9a650
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-731: unnecessary final keywords

We don't need them, so reduce warnings a bit.

Change-Id: Iac20966ae2ef4a89a7dde6610341f5d549339c43
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: remove empty statements

These are not harmful, but let's keep the code clean;

Change-Id: Ifbf7ba2af61e8b5361bf8dba3c1447fb9bd4fc2f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-730: cleanup tests in pcep-impl"

Merge "Remove unnecessary try-catch. OF codes are no longer in an enum."

Merge "Added open object parser/serializer to basic activator."

BUG-731: do not declare Exception as thrown

In one place it's completely unneeded, on the other one we can refactor.

Change-Id: I6d84424c02430c33a964013c11e7130cd2f4ec0f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: move annotation

Moving the annotation renders the temporary variable unneeded, which in
turn fixes a warning. The method is simple enough so it does not matter.

Change-Id: I188870a6f5c0ab55f30803d2f944589ee6a74ad9
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: simplify boolean expression

This is less obvious, but still as good as the original. Plus it removes
a complaint.

Change-Id: I672a16c41687b319de3918822edc7a4073f5169e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-730: cleanup tests in pcep-impl

Change-Id: Ic478b45803faff29d63b01cc986a0dcb135af295
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731: do not assign to parameters

It is convenient to coerce the argument value, but this approach is a
bit more clean and avoids the sonar warning.

Change-Id: I8648e09c5c02bb082321c3a9a858142eaabdc9ea
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: do not throw RuntimeException

Let's turn this into an IllegalArgumentException, with a proper message.

Change-Id: I5bb149de83001ea6817c6f58fb1d5d9be41907e1
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: rework catch clausule

This eliminates warning about rethrowing exceptions.

Change-Id: I46a3531a7753c049d78919c0134d714a509b29a6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unnecessary try-catch.
OF codes are no longer in an enum.

Change-Id: I635565fb04d7439d2bf2bb761d8b39e02785ae48
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added open object parser/serializer to basic activator.

Change-Id: I4ebb828b67becd89a35880594914daca7e800b5d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731: move to new APIs

This fixes "Overriding method merely calls super".

Change-Id: I02794a2c2a118cafa847138ad22199a18df4a83c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: fix keyword ordering

Fixes abstract/protected keyword order.

Change-Id: I1d486b1113e0a5dc7f46a6220203e25c806ebd19
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove BGPCEP distribution

This distribution is now defunct, so let's remove it.

Change-Id: Ifdfe2d5f19f6f1988ac287f0772a55d794cc1b69
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add abstract method documentation

This just clarifies the API contract for identifierForKey.

Change-Id: Ia855cc69e36271e317ffc529d0963dc0a314e722
Signed-off-by: Robert Varga <rovarga@cisco.com>

Enabled replace action in PCEP Topology Provider

With legacy compatibility APIs default action of datastore
is merge, enabled replace operation, in order to
assume correct behaviour.

Change-Id: I9302a535e1ea4b4e001e45dae28015dcf45b3362
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-731: JMX attributes are static now

The JMX attribute fields are now public static so let's not use object
reference when accessing them.

Change-Id: I1613188a11d528f06ef30183f1eade1c4d60ab79
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: remove implied modifier

All methods in an interface are always public, no need to re-state that.

Change-Id: Ibb1c87ab2f2c0a81636607fbfa95dd109ccdc0d6
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: remove unused imports

These imports are only used in javadoc -- so let's not do that and
specify the name in full in the javadoc.

Change-Id: I90ebe8da4ff84ca7620d1713630899492a3b09fa
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: utility classes should be final

There's no reason to subclass these -- they cannot be instantiated,
anyway.

Change-Id: I6e07c8eba054fb9d6ad5a6c5ee1e12a6c83acd7d
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: Raw RuntimeExceptions should not be thrown

They really tell us very little -- so convert them to
IllegalStateExceptions where appropriate.

Change-Id: I885570a0a0ae7972b2227dcd08bf83dcb9f86c5a
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: do not use temporary variables

These are single-use and can be easily simplified, so get rid of them.

Change-Id: I50c074fa184f59cfe39df34af05c60b20f6b035a
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: do not declare Exception to be thrown

These 7 methods either throw only a subclass of RuntimeException,
or IOException. Declare them accordingly.

Change-Id: I253e659dde725df004f63f156448591ef5e85bbb
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-730 : added unit tests for stateful02

Change-Id: I0673520a53e5c2c46e0c76bf3a4da8f5a8ef6219
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed typo.

Change-Id: Ic346974d03a358a377f36acfbc14c2723222e4e9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-632: supress unneeded round-trips to JNI

This fixes Java logic to not update keys which match.

Change-Id: I7ff22f74cb82066367e4bb77c319ab11eb97eb99
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-632: Fix NIO package thinko

It turns out we cannot just proxy around the Selector and
SelectorProvider -- we have to have our own. This is okay, as we can
nicely drop this in.

Change-Id: Idcda5b263bc584fbd9157f0d0fc57d4af82d08d4
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-632: fix netty binding

It turns out netty is not really friendly to us subclassing its channel
implementations. Rework the implementation such that it subclasses the
netty generic substrate.

Change-Id: Ia25f23a5791fd43d617130f5b11d7cbde713e75f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-632: add initial configuration bits for TCP-MD5

This patch adds the controller-config bit for tcp-md5 and modifies both
BGP and PCEP configurations to take advantage of it. Since the runtime
support is not universally available, these options are left
deactivated.

Change-Id: I61d455966aada9e0cc68dadab724994ba8dcb794
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-632: fix configuration interactions

This commit fixes various problems in configuration module code, so it
actually works. Key problems addressed:
- netty integration was not returning proper instance
- BGP/PCEP modules need to look at actual implementation mbean, not the
  service reference

Change-Id: Iaaf03a5fd94f4a2953f671015bee8f635a4c69d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-636: fix PCEP MD5 keys not being propagated

This patch fixes the slight oversight of not passing MD5 keys not being
passed down to the dispatcher.

Change-Id: I54246a7a427c7de4d0e9cc9a4e574653bfe9a956
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-370: update Netty version to 4.0.17

Change-Id: I633489a6d90f5718cdc1bf6e325f0e3ef024d34b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-731: fix unused imports and pom.xml override

There are two unused mockito imports and an config artifact version
override -- fix all three of them.

Change-Id: Id6e5b9b2ed1b5e0427fb10f56b065540f728fe0d
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-635: implement MD5 auth option for BGP peers

This adds the wiring for the BGP dispatcher to make use of client/server
channels. It also adds validation support.

Change-Id: Ieb2dc4c60dfcd92d8e7a3f732198ad07a734853e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-636: Add configuration option to PCEP

This patch adds the ability to configure a RFC2385 key on a PCEP server
session. The configuration is accepted only if the runtime supports it,
e.g. PCEPTopologyProviderModule checks for presence before ever
attempting to use it.

Change-Id: I349cdef08655ec56ba2ed413f67ab187b0a9fc0c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-634: add tcpmd5 configuration binding

Change-Id: I64d400fb7083a5e9de8a88d067d4d16358fabfff
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Remove bgp-update-api-config"

Remove bgp-update-api-config

This bundle has been evacuated before Hydrogen release, but retained for
compatibility purposes. It can be safely removed now.

Change-Id: Ic870a7fd255ed42f0f4aba1ef7a0b9327f9e4504
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 187 - PCEP's  message parser should ignore unknow objects with flag P=0

-Fixed: ObjectRegistry#parseObject returns null, so such objects are ignored in message parser.

Change-Id: I14251257e55b0495e592ff213c0aa48cffc15640
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-634: improve netty interface

This introduces dedicated ChannelFactory implementations, which allow
for non-default KeyAccessFactory use in the MD5-enabled sockets.

Change-Id: I7ae2e7400076123f6627fdd4b300130da1799539
Signed-off-by: Robert Varga <rovarga@cisco.com>

Resolve Bug:681 - Fix bgpcep after config-manager tests have been changed.

This must be merged after https://git.opendaylight.org/gerrit/#/c/5964/
is merged.

Change-Id: I2b56c5a5bd4f138b58c96a70fcb8296ba2eff261
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>