ovsdb.git
9 years agoMerge "Remove unused service interfaces"
Sam Hague [Tue, 14 Apr 2015 15:08:22 +0000 (15:08 +0000)]
Merge "Remove unused service interfaces"

9 years agoMerge "Do not send bridge name in update"
Sam Hague [Tue, 14 Apr 2015 15:05:02 +0000 (15:05 +0000)]
Merge "Do not send bridge name in update"

9 years agoMerge "Deprecated OvsdbClientKey and replaced with ConnectionInfo"
Sam Hague [Tue, 14 Apr 2015 15:04:56 +0000 (15:04 +0000)]
Merge "Deprecated OvsdbClientKey and replaced with ConnectionInfo"

9 years agoMerge "Hook southbound integration in normal build process"
Sam Hague [Tue, 14 Apr 2015 15:02:39 +0000 (15:02 +0000)]
Merge "Hook southbound integration in normal build process"

9 years agoDo not send bridge name in update 36/18236/1
Ed Warnicke [Tue, 14 Apr 2015 05:00:32 +0000 (22:00 -0700)]
Do not send bridge name in update

It turns out...bridge name is immutable and OVSDB really doesn't
like it when you send it.

Change-Id: I8d8b16fe728ea4a386ca481624643dc260d01f29
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoDeprecated OvsdbClientKey and replaced with ConnectionInfo 32/18232/2
Ed Warnicke [Tue, 14 Apr 2015 01:31:33 +0000 (18:31 -0700)]
Deprecated OvsdbClientKey and replaced with ConnectionInfo

Since ConnectionInfo is basically the same info only better.

Change-Id: Icbf8a8946f26ffd971b006595a6933e9ddf020ab
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoIntroducing ConnectionInfo 29/18229/1
Ed Warnicke [Mon, 13 Apr 2015 23:38:50 +0000 (16:38 -0700)]
Introducing ConnectionInfo

Added a ConnectionInfo with remote/local ip/port to
the model.

Change-Id: I77fc3d8f9efbce0a07fc8106ec0487eeca4e09e6
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoRemove unused service interfaces 22/18222/2
Sam Hague [Mon, 13 Apr 2015 22:16:35 +0000 (18:16 -0400)]
Remove unused service interfaces

There are various places where dependency injection is used to get service interfaces. The ones removed in this patch were unsused. This will make it easier to implement the southbound equivalent of the services since these removed ones can be ignored.

Patch set 2: Modify unit tests verify clauses to not expect certain methods to have been called.

Change-Id: I2fd815d92631039a7dc923bf35c3aa863d19e47a
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoHook southbound integration in normal build process 91/18191/2
Anil Vishnoi [Mon, 13 Apr 2015 12:57:47 +0000 (18:27 +0530)]
Hook southbound integration in normal build process

Integration test won't be triggered with normal verify build.
-Pintegrationtest option will be required to trigger the integration build.

Change-Id: I49b62f945f5707befa95b8470918b40841c729e6
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoMerge "Renamed BridgeCreateCommand to BridgeUpdateCommand"
Sam Hague [Mon, 13 Apr 2015 18:08:03 +0000 (18:08 +0000)]
Merge "Renamed BridgeCreateCommand to BridgeUpdateCommand"

9 years agoMerge "BridgeCreateCommand now correctly handles updates."
Sam Hague [Mon, 13 Apr 2015 18:07:56 +0000 (18:07 +0000)]
Merge "BridgeCreateCommand now correctly handles updates."

9 years agoMerge "Cleaned up BridgeCreateCommand"
Sam Hague [Mon, 13 Apr 2015 18:07:49 +0000 (18:07 +0000)]
Merge "Cleaned up BridgeCreateCommand"

9 years agoMerge "Fix latent NPE issues."
Sam Hague [Mon, 13 Apr 2015 18:07:43 +0000 (18:07 +0000)]
Merge "Fix latent NPE issues."

9 years agoMerge "Break out Protocol Update and Remove into seperate commands"
Sam Hague [Mon, 13 Apr 2015 18:07:35 +0000 (18:07 +0000)]
Merge "Break out Protocol Update and Remove into seperate commands"

9 years agoMerge "Fix so that operational store correctly removes bridge-other-configs"
Sam Hague [Mon, 13 Apr 2015 18:07:27 +0000 (18:07 +0000)]
Merge "Fix so that operational store correctly removes bridge-other-configs"

9 years agoMerge "Fix so that operational store correctly removes bridge-external-ids"
Sam Hague [Mon, 13 Apr 2015 18:07:21 +0000 (18:07 +0000)]
Merge "Fix so that operational store correctly removes bridge-external-ids"

9 years agoMerge "Fix so that operational store correctly removes protocol entries"
Sam Hague [Mon, 13 Apr 2015 18:07:13 +0000 (18:07 +0000)]
Merge "Fix so that operational store correctly removes protocol entries"

9 years agoMerge "Fix so that operational store correctly removes controller entries"
Sam Hague [Mon, 13 Apr 2015 18:06:48 +0000 (18:06 +0000)]
Merge "Fix so that operational store correctly removes controller entries"

9 years agoRenamed BridgeCreateCommand to BridgeUpdateCommand 71/18171/4
Ed Warnicke [Sun, 12 Apr 2015 19:44:52 +0000 (12:44 -0700)]
Renamed BridgeCreateCommand to BridgeUpdateCommand

As it now handles Update as well as simple create.

Change-Id: I6fb1db60cbce5553a7a5350e34cb8119d28de736
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBridgeCreateCommand now correctly handles updates. 70/18170/3
Ed Warnicke [Sun, 12 Apr 2015 19:42:45 +0000 (12:42 -0700)]
BridgeCreateCommand now correctly handles updates.

Change-Id: I7ee6907b81174d732aadc0fa1b10ea44f1544f9c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoCleaned up BridgeCreateCommand 60/18160/4
Ed Warnicke [Sun, 12 Apr 2015 03:18:52 +0000 (20:18 -0700)]
Cleaned up BridgeCreateCommand

Inspired by the good work of  Ryan Goulding in these patches:
https://git.opendaylight.org/gerrit/#/c/18135/
https://git.opendaylight.org/gerrit/#/c/18138/

I cleaned up BridgeCreateCommand... because I was getting lost
in there ;)

Change-Id: Ia4b4e95f99749e75a038cd8062ad74b790598179
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix latent NPE issues. 59/18159/3
Ed Warnicke [Sun, 12 Apr 2015 02:37:12 +0000 (19:37 -0700)]
Fix latent NPE issues.

I didn't trip on these, but I tripped on their analog with
protocols... so fixing them here.

Change-Id: I23bf647988bade95d66a8c9ecbf7bd32b7980ce1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoBreak out Protocol Update and Remove into seperate commands 58/18158/3
Ed Warnicke [Sun, 12 Apr 2015 02:29:32 +0000 (19:29 -0700)]
Break out Protocol Update and Remove into seperate commands

In addition, they now have the necessary logic to handle
Updates as well as Creates.

Change-Id: Id19e51a7e8951123d3b08c510a61cbef84328c9d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix so that operational store correctly removes bridge-other-configs 56/18156/4
Ed Warnicke [Sun, 12 Apr 2015 00:06:02 +0000 (17:06 -0700)]
Fix so that operational store correctly removes bridge-other-configs

Before, if a bridge-other-configs entry was removed on ovsdb, we didn't
remove it from the operational store.

This is an artifact of using *merge* rather than *put*.
Using merge is *still* a good idea for us, but what was happening
was basically this.

Say we got a report in the operational store of

[bridge-other-configs1, bridge-other-configs2]

which we dutifully merged.

Then we got a report of
[bridge-other-configs2]

when that is *merged*... the protocol1 entry is left dangling,
because its a *merge*.  To compensate, we have to be *very*
specific about wanting to remove bridge-other-configs1.

Change-Id: Ic94b67b341bf7233c881e324f494c6701b622131
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix so that operational store correctly removes bridge-external-ids 55/18155/5
Ed Warnicke [Sat, 11 Apr 2015 23:33:31 +0000 (16:33 -0700)]
Fix so that operational store correctly removes bridge-external-ids

Before, if a bridge-external-ids entry was removed on ovsdb, we didn't
remove it from the operational store.

This is an artifact of using *merge* rather than *put*.
Using merge is *still* a good idea for us, but what was happening
was basically this.

Say we got a report in the operational store of

[bridge-external-ids1, bridge-external-ids2]

which we dutifully merged.

Then we got a report of
[bridge-external-ids2]

when that is *merged*... the protocol1 entry is left dangling,
because its a *merge*.  To compensate, we have to be *very*
specific about wanting to remove bridge-external-ids1.

Change-Id: I7bb7e3264176604f3a01f90231cae99026148f2f
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix so that operational store correctly removes protocol entries 54/18154/5
Ed Warnicke [Sat, 11 Apr 2015 23:04:19 +0000 (16:04 -0700)]
Fix so that operational store correctly removes protocol entries

    Before, if a protocol entry was removed on ovsdb, we didn't
    remove it from the operational store.

    This is an artifact of using *merge* rather than *put*.
    Using merge is *still* a good idea for us, but what was happening
    was basically this.

    Say we got a report in the operational store of

    [protocol1, protocol1]

    which we dutifully merged.

    Then we got a report of
    [protocol2]

    when that is *merged*... the protocol1 entry is left dangling,
    because its a *merge*.  To compensate, we have to be *very*
    specific about wanting to remove protocol1.

Change-Id: I17f8b9b26cea4e894d74b534335dc55f0097d8c8
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoFix so that operational store correctly removes controller entries 52/18152/6
Ed Warnicke [Sat, 11 Apr 2015 22:13:25 +0000 (15:13 -0700)]
Fix so that operational store correctly removes controller entries

Before, if a controller entry was removed on ovsdb, we didn't
remove it from the operational store.

This is an artifact of using *merge* rather than *put*.
Using merge is *still* a good idea for us, but what was happening
was basically this.

Say we got a report in the operational store of

[controller1, controller2]

which we dutifully merged.

Then we got a report of
[controller2]

when that is *merged*... the controller1 entry is left dangling,
because its a *merge*.  To compensate, we have to be *very*
specific about wanting to remove controller1.

This is accomplished by factoring out an OvsdbControllerUpdateCommand
and OvsdbControllerRemoveCommand.

Change-Id: I2e38e0e175cef5f848f28501cfaeecc1cb162151
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoOvsdbPortUpdateCommand actually add entries to tplist 86/18186/1
Ryan Goulding [Mon, 13 Apr 2015 10:58:58 +0000 (06:58 -0400)]
OvsdbPortUpdateCommand actually add entries to tplist

Missed a step in refactoring;  adding here.

Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "Cleaned up OvsdbBridgeUpdateCommand"
Sam Hague [Mon, 13 Apr 2015 00:38:50 +0000 (00:38 +0000)]
Merge "Cleaned up OvsdbBridgeUpdateCommand"

9 years agoClean up TerminationPointCreateCommand.java 38/18138/3
Ryan Goulding [Fri, 10 Apr 2015 22:22:11 +0000 (18:22 -0400)]
Clean up TerminationPointCreateCommand.java

This change abstracts the different steps involved in the
TerminationPointCreateCommand.execute() method so that the code is more
readable. The individual steps have been put into appropriate private helper
methods.

Change-Id: I65f0c8bc5da3a2509f42479a57fd0392c14baa5f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoCleaned up OvsdbBridgeUpdateCommand 49/18149/3
Ed Warnicke [Sat, 11 Apr 2015 20:32:59 +0000 (13:32 -0700)]
Cleaned up OvsdbBridgeUpdateCommand

Inspired by the good work of  Ryan Goulding in these patches:
https://git.opendaylight.org/gerrit/#/c/18135/
https://git.opendaylight.org/gerrit/#/c/18138/

I cleaned up OvsdbBridgeUpdateCommand... because I was getting lost
in there ;)

Change-Id: Id7dafa333978031815dc5072fb2c02d1dd1cc75c
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoClean up OvsdbPortUpdateCommand.java 35/18135/4
Ryan Goulding [Fri, 10 Apr 2015 20:26:15 +0000 (16:26 -0400)]
Clean up OvsdbPortUpdateCommand.java

This change abstracts the different steps involved in the
OvsdbPortUpdateCommand.execute() method so that the code is more readable. The
individual steps have been put into the appropriate private helper methods.

Change-Id: Ifacdc0fe44f0555da690ca1c306b0462d34bc24e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "interface/port-other-config support"
Flavio Fernandes [Fri, 10 Apr 2015 20:17:10 +0000 (20:17 +0000)]
Merge "interface/port-other-config support"

9 years agoFix minor issues : 33/18133/1
Anil Vishnoi [Fri, 10 Apr 2015 20:04:16 +0000 (01:34 +0530)]
Fix minor issues :
Closing transaction
Removing null change on Optional, not required.

Change-Id: I728a924d4a259a4af6187ac2e3f24025e5b767c9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agointerface/port-other-config support 17/18117/2
Ryan Goulding [Fri, 10 Apr 2015 14:09:10 +0000 (10:09 -0400)]
interface/port-other-config support

Adds support for interface and port other_config column configuration and
operational persistence.

Change-Id: I4fa236b3df2bdc5ab580234a6c61b603ed4a581e
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "Workaround to fix southbound it"
Flavio Fernandes [Fri, 10 Apr 2015 15:40:01 +0000 (15:40 +0000)]
Merge "Workaround to fix southbound it"

9 years agoWorkaround to fix southbound it 20/18120/1
Sam Hague [Fri, 10 Apr 2015 15:22:48 +0000 (11:22 -0400)]
Workaround to fix southbound it

The problem was the dataBroker in the southbound-it was not right. Something from outside ovsdb changed and caused issues with the way the soutbound-it was getting the broker.

The workaround was to get the broker from the SouthboundProvider.

Also added basic NetworkTopology and Topology to read the OVSDBTopology from the datastores since those values have to exist for southbound-impl to work.

Change-Id: Ie24c2bed42976efc64c142c30f6b1a8935435209
Signed-off-by: Sam Hague <shague@redhat.com>
9 years agoMerge "Add JUnit testing for NodeConfiguration class."
Sam Hague [Fri, 10 Apr 2015 14:19:36 +0000 (14:19 +0000)]
Merge "Add JUnit testing for NodeConfiguration class."

9 years agoAdd JUnit testing for NodeConfiguration class. 08/18108/1
Alexis de Talhouët [Fri, 10 Apr 2015 13:10:22 +0000 (09:10 -0400)]
Add JUnit testing for NodeConfiguration class.

Change-Id: Iddf2dcfb3c6c24acf473a16ab055751182f66c00
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoBreak out ControllerUpdate and Remove into seperate commands 71/18071/2
Ed Warnicke [Thu, 9 Apr 2015 15:24:05 +0000 (08:24 -0700)]
Break out ControllerUpdate and Remove into seperate commands

In addition, they now have the necessary logic to handle
Updates as well as Creates.

Change-Id: I414c3a73e75ea89c2fb7f644a19ed429016391ca
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMake sure that getRandomUUID returns a valid ovsdb <id> 70/18070/2
Ed Warnicke [Fri, 10 Apr 2015 02:34:11 +0000 (19:34 -0700)]
Make sure that getRandomUUID returns a valid ovsdb <id>

Ovsdb <id>s must begin with an alpha character.
This change makes sure that getRandomUUID *always* returns a valid
ovsdb <id>.

Change-Id: I9e5560ea410e25f0fa17cc6a29589c15e8a4a5ec
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoAdded controller-uuid to the model and got it into operational store. 58/18058/2
Ed Warnicke [Thu, 9 Apr 2015 20:17:52 +0000 (13:17 -0700)]
Added controller-uuid to the model and got it into operational store.

Change-Id: I3fa2cc475362776bce096b0f2f4f7be1c2d8b455
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoSimplify with utility functions. 75/17975/4
Ed Warnicke [Thu, 9 Apr 2015 01:15:59 +0000 (18:15 -0700)]
Simplify with utility functions.

Change-Id: If9a86e4c18dc5723826054b1a3b50f7ebc0d5086
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoPulled out AbstractTransactCommand 71/17971/6
Ed Warnicke [Wed, 8 Apr 2015 23:49:08 +0000 (16:49 -0700)]
Pulled out AbstractTransactCommand

Change-Id: I1019d17e5536bd27b9c45283e9cf320012f9fd38
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoMerge "Start to tease apart things into smaller pieces to make merge logic easier."
Sam Hague [Fri, 10 Apr 2015 10:38:56 +0000 (10:38 +0000)]
Merge "Start to tease apart things into smaller pieces to make merge logic easier."

9 years agoMerge "Added support for bridge other-config."
Sam Hague [Fri, 10 Apr 2015 10:37:59 +0000 (10:37 +0000)]
Merge "Added support for bridge other-config."

9 years agoMerge "Added support for vlan mode."
Sam Hague [Fri, 10 Apr 2015 10:37:35 +0000 (10:37 +0000)]
Merge "Added support for vlan mode."

9 years agoAdding revision for ietf types. 69/18069/1
Amit Mandke [Fri, 10 Apr 2015 02:55:52 +0000 (19:55 -0700)]
Adding revision for ietf types.
It can conflict with if some other project uses a newer version of the ietf types.

Change-Id: Ia7b1ad8a0c51043d5a123052e3d907142570382f
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Adding revision for ietf types. It can conflict with if some other project...
Flavio Fernandes [Thu, 9 Apr 2015 23:35:48 +0000 (23:35 +0000)]
Merge "Adding revision for ietf types. It can conflict with if some other project uses a newer version of the ietf types."

9 years agoMerge "Introducing Bridge Operational State"
Flavio Fernandes [Thu, 9 Apr 2015 23:13:38 +0000 (23:13 +0000)]
Merge "Introducing Bridge Operational State"

9 years agoAdding revision for ietf types. 63/18063/1
Amit Mandke [Thu, 9 Apr 2015 22:59:37 +0000 (15:59 -0700)]
Adding revision for ietf types.
It can conflict with if some other project uses a newer version of the ietf types.

Change-Id: I38229f571dacd14c5a569e802e5eb8019fe322a9
Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoMerge "Add JUnit testing for PortSecurityHandler class."
Flavio Fernandes [Thu, 9 Apr 2015 23:00:50 +0000 (23:00 +0000)]
Merge "Add JUnit testing for PortSecurityHandler class."

9 years agoMerge "Add JUnit testing for RouterHandler class."
Flavio Fernandes [Thu, 9 Apr 2015 23:00:21 +0000 (23:00 +0000)]
Merge "Add JUnit testing for RouterHandler class."

9 years agoMerge "Add JUnit testing for SubnetHandler class."
Flavio Fernandes [Thu, 9 Apr 2015 22:59:20 +0000 (22:59 +0000)]
Merge "Add JUnit testing for SubnetHandler class."

9 years agoMerge "Add JUnit testing for NodeCacheManagerImpl class."
Flavio Fernandes [Thu, 9 Apr 2015 22:57:28 +0000 (22:57 +0000)]
Merge "Add JUnit testing for NodeCacheManagerImpl class."

9 years agoTurn down logging to appropriate debug level to reduce log pollution 60/18060/1
Ed Warnicke [Thu, 9 Apr 2015 21:31:44 +0000 (14:31 -0700)]
Turn down logging to appropriate debug level to reduce log pollution

Change-Id: I005e99fc8c9e4f703e7d5c599d7bf7a3b190aa71
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoAdd JUnit testing for NodeCacheManagerImpl class. 59/18059/3
Alexis de Talhouët [Thu, 9 Apr 2015 20:32:10 +0000 (16:32 -0400)]
Add JUnit testing for NodeCacheManagerImpl class.

Change-Id: I7e0174ea2db0045637ab7fe2ec465a1c3cfc2687
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for SubnetHandler class. 56/18056/1
Alexis de Talhouët [Thu, 9 Apr 2015 19:28:42 +0000 (15:28 -0400)]
Add JUnit testing for SubnetHandler class.

Change-Id: I164fbf62f1a119ec8582740c84b77a1775e149b0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for RouterHandler class. 55/18055/1
Alexis de Talhouët [Thu, 9 Apr 2015 18:55:36 +0000 (14:55 -0400)]
Add JUnit testing for RouterHandler class.

Change-Id: Ieee8ebd34e409dc2e4d1c854576dd8a9ddc78c0a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoStart to tease apart things into smaller pieces to make merge logic easier. 69/17969/4
Ed Warnicke [Wed, 8 Apr 2015 23:19:14 +0000 (16:19 -0700)]
Start to tease apart things into smaller pieces to make merge logic easier.

Change-Id: Idccbc510b07237b0e31a37aa204d8542670d6192
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoIntroducing Bridge Operational State 67/17967/4
Ed Warnicke [Wed, 8 Apr 2015 18:34:44 +0000 (11:34 -0700)]
Introducing Bridge Operational State

And using it for Bridge/TerminationPoint Delete Operations

In order to correctly handle 'merge' of data on update
we will need the BridgeOperationalState functionality,
so we can know what we *have* and thus whether to do
an insert/update/mutate.

Change-Id: I9e5200bf1b7f724e346b0855c32f6510773f5e5d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoAdd JUnit testing for PortSecurityHandler class. 53/18053/1
Alexis de Talhouët [Thu, 9 Apr 2015 18:31:18 +0000 (14:31 -0400)]
Add JUnit testing for PortSecurityHandler class.

Change-Id: I8fc2fb1fe32a3d2c0d73a4a2456379f03c0eaeb5
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoMerge "Add JUnit testing for NodeCacheManagerEvent class."
Flavio Fernandes [Thu, 9 Apr 2015 18:23:35 +0000 (18:23 +0000)]
Merge "Add JUnit testing for NodeCacheManagerEvent class."

9 years agoMerge "Add JUnit testing for NetworkHandler class."
Flavio Fernandes [Thu, 9 Apr 2015 18:22:40 +0000 (18:22 +0000)]
Merge "Add JUnit testing for NetworkHandler class."

9 years agoMerge "Add JUnit testing for PortHandler class."
Flavio Fernandes [Thu, 9 Apr 2015 18:22:20 +0000 (18:22 +0000)]
Merge "Add JUnit testing for PortHandler class."

9 years agoAdd JUnit testing for PortHandler class. 51/18051/1
Alexis de Talhouët [Thu, 9 Apr 2015 18:06:40 +0000 (14:06 -0400)]
Add JUnit testing for PortHandler class.

Change-Id: I3b061441a4402e8648fc082286f3596c601d5121
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for NodeCacheManagerEvent class. 46/18046/1
Alexis de Talhouët [Thu, 9 Apr 2015 15:51:28 +0000 (11:51 -0400)]
Add JUnit testing for NodeCacheManagerEvent class.

Change-Id: I1f360c2c997a72420566d75684e7ef81b18e14ac
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdded support for vlan mode. 35/17935/6
Gabriel Robitaille-Montpetit [Thu, 9 Apr 2015 15:36:50 +0000 (11:36 -0400)]
Added support for vlan mode.

Change-Id: Ie77dfe427dc799c728d15c0e424ba19a2df79fff
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
9 years agoAdd JUnit testing for NetworkHandler class. 42/18042/3
Alexis de Talhouët [Thu, 9 Apr 2015 15:16:13 +0000 (11:16 -0400)]
Add JUnit testing for NetworkHandler class.

Change-Id: Ib1091ee8bad8bd1151bdbf985435e23421357e34
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for LBaaSPoolHandlerTest class. 31/18031/1
Alexis de Talhouët [Thu, 9 Apr 2015 13:49:00 +0000 (09:49 -0400)]
Add JUnit testing for LBaaSPoolHandlerTest class.

Change-Id: I029dfd0319c48663a7b8134b046f45eb588433ca
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoSupport other_config for OVSDB Nodes 68/17968/3
Eric Multanen [Wed, 8 Apr 2015 15:20:22 +0000 (08:20 -0700)]
Support other_config for OVSDB Nodes

Add support to set other_config via MDSAL config and
update operational MDSAL from the Open_vSwitch table
on the OVS host.

v2 - add NPE to the LOG warning.
v3 - rebase
v4 - fix logging of exception
v5 - remove whitespace

Change-Id: If684e89185fe5660263c3e7ff8b1f5c7087764ee
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
9 years agoMerge "Add support for external-ids in the OVSDB node"
Sam Hague [Thu, 9 Apr 2015 11:14:18 +0000 (11:14 +0000)]
Merge "Add support for external-ids in the OVSDB node"

9 years agoMerge "port/interface-external-ids refactoring"
Sam Hague [Thu, 9 Apr 2015 11:11:41 +0000 (11:11 +0000)]
Merge "port/interface-external-ids refactoring"

9 years agoAdded support for bridge other-config. 47/18047/2
Sharad Mishra [Thu, 9 Apr 2015 07:37:23 +0000 (00:37 -0700)]
Added support for bridge other-config.

This patch will Create/update other-config to bridges.
To add other-config in bridge, run the following commands -

sudo ovs-vsctl -- set Bridge br0 other_config:enable-input=false

This assumes a bridge exists with name br0
other-config is a key/value pair, and AFAIK, it can be any random key/value.
To update/modify other config, just supply a new value like -

sudo ovs-vsctl -- set Bridge br0 other_config:enable-input=yes

Change-Id: I4cafe9b8c74f752d951ea073b0a9766721452b6d
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
9 years agoport/interface-external-ids refactoring 58/17958/3
Ryan Goulding [Wed, 8 Apr 2015 18:02:51 +0000 (14:02 -0400)]
port/interface-external-ids refactoring

This change aggregates separate, appropriately named, list to store port
and interface related external_ids.  ovsdb.yang model changes were made to
rename the list and eliminate the more generic ovsdb-external-ids-attributes
grouping.  Java files were modified to compensate for the model changes.

Change-Id: Ieaa0ac82c8e0efe930cd837dab26fff4b0a572fe
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
9 years agoMerge "changed getManagingNode(..) to expect augmented path. In OvsdbBridgeAttributes...
Flavio Fernandes [Wed, 8 Apr 2015 22:54:48 +0000 (22:54 +0000)]
Merge "changed getManagingNode(..) to expect augmented path. In OvsdbBridgeAttributes 'managedBy' can be path to 'OvsdbNodeAugmentation' as well. This can happen if the attribute is set via binding aware code."

9 years agoMerge "Move UuidUtilsTest to the right package (netvirt.api instead of netvirt)."
Flavio Fernandes [Wed, 8 Apr 2015 22:53:26 +0000 (22:53 +0000)]
Merge "Move UuidUtilsTest to the right package (netvirt.api instead of netvirt)."

9 years agoMerge "Add JUnit testing for LBaaSPoolMemberHandler class."
Flavio Fernandes [Wed, 8 Apr 2015 22:52:51 +0000 (22:52 +0000)]
Merge "Add JUnit testing for LBaaSPoolMemberHandler class."

9 years agoMerge "Add JUnit testing for NeutronCacheUtilsTest class."
Flavio Fernandes [Wed, 8 Apr 2015 22:52:24 +0000 (22:52 +0000)]
Merge "Add JUnit testing for NeutronCacheUtilsTest class."

9 years agoMerge "Fixed postman collection for create termination point restconf request"
Flavio Fernandes [Wed, 8 Apr 2015 22:51:58 +0000 (22:51 +0000)]
Merge "Fixed postman collection for create termination point restconf request"

9 years agoFixed postman collection for create termination point restconf request 66/17966/1
Anil Vishnoi [Wed, 8 Apr 2015 21:19:38 +0000 (02:49 +0530)]
Fixed postman collection for create termination point restconf request

Change-Id: I27268940f506b10b3e2d8f0e48e5f40ecf6e5709
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoAdd JUnit testing for NeutronCacheUtilsTest class. 65/17965/1
Alexis de Talhouët [Wed, 8 Apr 2015 21:06:10 +0000 (17:06 -0400)]
Add JUnit testing for NeutronCacheUtilsTest class.

Change-Id: I5041913f0809618d13f498ac24952452a67752fe
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for LBaaSPoolMemberHandler class. 64/17964/1
Alexis de Talhouët [Wed, 8 Apr 2015 20:37:00 +0000 (16:37 -0400)]
Add JUnit testing for LBaaSPoolMemberHandler class.

Change-Id: Ie0e2a7526297c0a3ccde438fce5d207d4ad13f50
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoMerge "Implemented port/interface delete command to delete interface from ovsdb bridg...
Sam Hague [Wed, 8 Apr 2015 19:46:44 +0000 (19:46 +0000)]
Merge "Implemented port/interface delete command to delete interface from ovsdb bridge *.*Fixed tp-ip : We should not append bridge id to the tp-id, as it's already augmented on bridge node. Also removed the utility method to avoid further uses. *.* removed attached-to from termination-point attributes *.* Fixed restconf *.* Rebased patch"

9 years agoImplemented port/interface delete command to delete interface from ovsdb bridge 69/17869/8
Anil Vishnoi [Tue, 7 Apr 2015 18:27:07 +0000 (23:57 +0530)]
Implemented port/interface delete command to delete interface from ovsdb bridge
*.*Fixed tp-ip : We should not append bridge id to the tp-id, as it's already
augmented on bridge node. Also removed the utility method to avoid further
uses.
*.* removed attached-to from termination-point attributes
*.* Fixed restconf
*.* Rebased patch

Change-Id: Iedd87b386a3b2c6acd2e33ab26d17fbeec6f35ff
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
9 years agoMerge "Close transaction so we don't leak them."
Sam Hague [Wed, 8 Apr 2015 19:10:58 +0000 (19:10 +0000)]
Merge "Close transaction so we don't leak them."

9 years agoMerge "Introducing the extractCreatedOrUpdated method"
Sam Hague [Wed, 8 Apr 2015 19:10:22 +0000 (19:10 +0000)]
Merge "Introducing the extractCreatedOrUpdated method"

9 years agoMerge "Update netvirt.impl unit tests."
Sam Hague [Wed, 8 Apr 2015 18:04:34 +0000 (18:04 +0000)]
Merge "Update netvirt.impl unit tests."

9 years agoMove UuidUtilsTest to the right package (netvirt.api instead of netvirt). 52/17952/1
Alexis de Talhouët [Wed, 8 Apr 2015 17:41:23 +0000 (13:41 -0400)]
Move UuidUtilsTest to the right package (netvirt.api instead of netvirt).

Change-Id: Ib7a86a7cb06836f3339b527071afe4421af03f17
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoUpdate netvirt.impl unit tests. 49/17949/2
Alexis de Talhouët [Wed, 8 Apr 2015 17:33:58 +0000 (13:33 -0400)]
Update netvirt.impl unit tests.

Basically I added tests, mainly Mockito.verify(). And I refactored, updated and cleaned up the classes.

Change-Id: I1d3f2c7966a7edb1ad7d41d53cdba1e37cb1082c
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoMerge "Add support for bridge external-ids."
Sam Hague [Wed, 8 Apr 2015 17:21:13 +0000 (17:21 +0000)]
Merge "Add support for bridge external-ids."

9 years agochanged getManagingNode(..) to expect augmented path. 53/17953/1
Amit Mandke [Wed, 8 Apr 2015 17:06:41 +0000 (10:06 -0700)]
changed getManagingNode(..) to expect augmented path.
In OvsdbBridgeAttributes 'managedBy' can be path to 'OvsdbNodeAugmentation' as well.
This can happen if the attribute is set via binding aware code.

Signed-off-by: Amit Mandke <ammandke@cisco.com>
9 years agoClose transaction so we don't leak them. 42/17942/1
Ed Warnicke [Wed, 8 Apr 2015 16:56:40 +0000 (09:56 -0700)]
Close transaction so we don't leak them.

Change-Id: I349f01268c2a345abcdba0c858acaea80ab065a0
Signed-off-by: Ed Warnicke <eaw@cisco.com>
9 years agoModified postman collection to test vlan-mode. 37/17937/3
Gabriel Robitaille-Montpetit [Wed, 8 Apr 2015 15:34:35 +0000 (11:34 -0400)]
Modified postman collection to test vlan-mode.

Change-Id: I8efe63a272e14cff270678c8dacec3011e2f3dc0
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
9 years agoMerge topic 'unification'
Sam Hague [Wed, 8 Apr 2015 15:07:03 +0000 (15:07 +0000)]
Merge topic 'unification'

* changes:
  Switch to generic extract methods in TransactUtils
  Use SouthboundMapper.getRandomUUID() in TerminationPoints

9 years agoMerge "Add JUnit testing for FWaasHandler class."
Flavio Fernandes [Wed, 8 Apr 2015 14:13:41 +0000 (14:13 +0000)]
Merge "Add JUnit testing for FWaasHandler class."

9 years agoMerge "Add JUnit testing for LBaaSHandler class."
Flavio Fernandes [Wed, 8 Apr 2015 14:12:12 +0000 (14:12 +0000)]
Merge "Add JUnit testing for LBaaSHandler class."

9 years agoModify test case testProcessEvent() for FloatingIPHandlerTest class. 25/17925/1
Alexis de Talhouët [Wed, 8 Apr 2015 13:53:52 +0000 (09:53 -0400)]
Modify test case testProcessEvent() for FloatingIPHandlerTest class.

Change-Id: I3cea00cabe74a3d893c848a654bc77278a1afdaf
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd JUnit testing for LBaaSHandler class. 23/17923/1
Alexis de Talhouët [Wed, 8 Apr 2015 13:47:38 +0000 (09:47 -0400)]
Add JUnit testing for LBaaSHandler class.

Change-Id: Ie0aba32878c1643920a8df9441fc1ebce311d6ce
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
9 years agoAdd support for external-ids in the OVSDB node 11/17811/6
Eric Multanen [Mon, 6 Apr 2015 09:42:43 +0000 (02:42 -0700)]
Add support for external-ids in the OVSDB node

Write external-ids supplied in an update to an OVSDB
node via the MDSAL.  Update the Open_vSwitch table
on the OVS host.

TODO - handle external-ids provided on OVSDB Node create

v2 - update the operational MDSAL with received external-ids
v3 - add NPE to LOG warning
v4 - rebase against new data change listener
v5 - remove unused methods in TransactUtils.java from earlier versions
v6 - more rebase
v7 - formatting fix

Change-Id: Ifcb6b433272e43ee9542521e4688b2d4fcd356e7
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>