Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Add travis builds

Signed-off-by: Sam Hague <shague@redhat.com>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Fix System.exit() handling

Directly invoking System.exit() from Main.close() causes two problems:
* FindBugs doesn’t like it ;-)
* MainTest fails because the JVM exits from under Surefire’s feet

This patch adds an override for FindBugs, and separates closing the
injector from exiting the JVM for test purposes.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

add TODO re. ClassPathScanner using ClassGraph

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

make ClassPathScanner log "declared multiple times" debug instead warn

This avoids seeing this, which is confusing and doesn't add much value:

2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.ServiceRecoveryInterface is declared multiple times, ignoring it
2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface java.lang.AutoCloseable is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.RecoverableListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.mdsal.eos.binding.api.EntityOwnershipListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.netvirt.fibmanager.IVrfEntryHandler is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.infrautils.diagstatus.ServiceStatusProvider is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.alivenessmonitor.rev160411.AlivenessMonitorListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.arputil.rev160406.OdlArputilListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface java.lang.Runnable is declared multiple times, ignoring it
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add TODO re. DataStoreAppConfigDefaultXMLReader

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Ctrl-D in Console now works

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

exclude controller:blueprint

This avoids:

2018-10-03T01:07:15,706 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata from any
class loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,717 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.container.BlueprintListener from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.container.BlueprintListener
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.container.BlueprintListener
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,850 | WARN  | main             | Reflections
| could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

optimize distribution build time via tar instead xz archive

While the poc-1.5.0-SNAPSHOT-simple.tar.xz was only 99M, it took about
1:30 min (!) to build (not total, just to XZ). That's a steep price to
pay, when a simple tar is just 122M (because the JAR are already
compressed) is quasi instant.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add (working, wow!) distribution assembly

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix broken build

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix Checkstyle problem in ClassPathScanner JavaDoc

and @SuppressWarnings for Class

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add .apt_generated_tests/ (from Eclipse) to .gitignore

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Implement a classpath scanner

The approach used here is to allow modules to request bindings for
interfaces to implementations found by scanning the class path, as
long as only one such implementation is found. This allows modules to
bind by requesting bindings for the main interface(s) they want to
provide, and re-use the annotation-based information contained in
their implementations and their dependencies.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

update TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Bump log4j-slf4j-impl from 2.11.0 to 2.11.1

Bumps log4j-slf4j-impl from 2.11.0 to 2.11.1.

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add link to https://jira.opendaylight.org/browse/OPNFLWPLUG-1037

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

also upgrade parent POM to Fluorine

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Encapsulate infrautils wiring

Using the same model as other project representations, encapsulate all
of infrautils’ wiring in a InfraUtilsWiring class.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade to Fluorine (#16)

This involves disabling the OpenFlowPlugin wiring for the time being
(it needs BundleContext).

Signed-off-by: Stephen Kitt <skitt@redhat.com>

update README with project goal clarification

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add link to CONTROLLER-1831 to TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

order TODO.md to prioritize next steps

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add console appender and print WARN & ERROR logs to it and file

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

change log file name from karaf.log to opendaylight.log

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add real log4j (V2) logging (to data/karaf.log)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix Error Prone's & FindBugs errors

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

commands now dynamically registered, instead of hard-coded TepShowState

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add ShellTestWiring to find missing @Service and broken @Reference

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

use slf4j-simple even for non-test initial demo, for now

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

working "tep:show-state" CLI command (but still hard-coded)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

adjust to RPC method signature update (TSC-99)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add ItmWiring (still missing ITM CLI commands like tep:show-state)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

prepare Karaf CLI shell command integration (just basis; no actual cmds)

see https://github.com/vorburger/ch.vorburger.karaf.simple

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix very minor typos in Main

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

install MdsalWiring in GeniusWiring instead of passing it to GuiceRule2

this fixes the currently broken GeniusMain

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add CachesWiring to get GeniusSimpleDistributionTest to pass again

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add README link to https://github.com/vorburger/ch.vorburger.karaf.simple

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

remove all of my Web API stuff here which is now upstream (in AAA)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

make GeniusSimpleDistributionTest pass!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix DiagStatusWiringTest, now requires ReadyWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

temporarily deactivate Neutron test and comment out to pass build

remove NeutronE2ETest, because that has now been
moved into Neutron next to the existing ITNeutronE2E!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deactivate AAA related test and comment out code to pass build

I've now lost interest in AAA.  We don't need it, for now, for this.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

bump ODL versions (still NOK)

Needs clean up, because a lot re. this has meanwhile gone in upstream!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

link to recent simple-dist_web

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add NeutronE2ETest {failing, WIP}

at the time of committing this, it requires a series of not yet merged
changes proposed to the Neutron project to extract the test logic from
its Karaf IT.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix minor issues found by error-prone

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add getBaseURL() to WebContextProvider

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add WebContextProviderOSGiImplTest {WIP}

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

split JettyLauncherTest extends WebContextTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

WebContextProviderOSGiImpl using WebContainer instead of HttpService

This will later have to tested with an IT ..

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

comment out WebContext getServletContext()

because it's probably never really needed, and it could not be
implemented when we delegate to OSGi HttpService / Pax Web Container.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add  TODO to WebContext re. re-writing it using Immutables.org Builder

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

minor tweak in WebWiringTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix registerListener(), with @Test testRegisterListener

similar to registerFilter() before

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

test addContextParam() - it was right, but made it consistent

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix registerFilter() and now use CrossOriginFilter in NeutronWiring

It turns out that handler.getServletContext().addFilter() throws an
IllegalStateException once that we have start()'ed once, so that's no
good - it's best NOT to use the Servlet API but directly Jetty's native
API.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fixed registerFilter() incl. testAddFilter()

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

duh... we need @Singleton on *ALL* @Provides to avoid double starts!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

using @Singleton @Provides avoids having to @Inject

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add NeutronSimpleDistributionTest

TODO: Get filter working (easy), get Neutron IT to pass this! (...)
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

made WebContext registerXYZ() methods return this for nice chaining

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

rename package simple.jetty.test to simple.web.test

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

JettyLauncher implements WebContextProvider

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

move JettyLauncher from simple.jetty to simple.web.impl

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

adapt HttpServiceWebContextImpl (not sure if this will be useful)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

move simple.osgi.HttpServiceImpl to web.osgi.impl.*WebContextImpl

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add WebContextProviderOSGiImpl (not sure if this will be useful)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

outline new WebContext API (without implementation, yet)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add working WebWiringTest illustrating ServletContextProvider in Guice

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix JettyLauncher single handler problem, with new test

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

ServletContextProvider and JettyLauncher now with OPTIONAL web.xml

the JettyLauncher can now EITHER scan for web.xml on classpath, OR it
can be programmatically configured via the new ServletContextProvider
service API (similar to OSGi's HttpService)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

{WIP} AAAWiring incl. Test

but it gets stuck (dead locked) in
org.opendaylight.aaa.shiro.web.env.KarafIniWebEnvironment.init()

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

OsgiServicesWiring for HttpService (with throws TODO)

used in currently still broken AAA; may remove this again later

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

WebWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

make JettyLauncher able to handle multiple web.xml and contexts

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

simplify Jetty related code by removing web fragment content support

the WEB_TAG_FILE thing for static web content in JARs which I
implemented many (many) moons ago is not required anymore for what I'm
after here, so remove that and simplify.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

minor first clean up of Jetty related code

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

working POC for embedding Jetty!!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

use SimpleDOMEntityOwnershipService (TX tpantelis)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix DiagStatusWiringTest; but DiagStatusWiring will likely evolve

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix MainTest now needs ReadyWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

@Ignore Netvirt; for now, let's focus on genius

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

suppress dumb FindBugs in ControllerWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

POM stuff to make it build on mvn CLI and not just in Eclipse

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

<duplicate-finder.skip>true, for now (until odlparent is sorted)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

for now, NoPacketProcessingService; figure out openflowplugin later..

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

wiring for EntityOwnershipService in MdsalWiring

also MdsalWiring now implicitly installs ControllerWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

AbstractCloseableModule does not implements AutoCloseable

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

ControllerWiringTest OK (with patched DataBrokerTestModule)

requires https://git.opendaylight.org/gerrit/#/c/67266/

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

ControllerWiring extends AbstractCloseableModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

intro. AbstractCloseableModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add ModuleWithPreDestroyTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

controller, mdsal, openflowplugin wiring tests (not yet passing)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

GeniusWiring 0.1; now we first have to sort dependant projects..

Signed-off-by: Michael Vorburger <mike@vorburger.ch>