Bump Commons Lang 3.8.1 → 3.9

Release notes: http://www.apache.org/dist/commons/lang/RELEASE-NOTES.txt

Change-Id: Ifb03a0c84a5852b134b78d8776c66e004a545fec
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a dependency-version-bumping script

Change-Id: I7659eb6a045a074039ee2f3a6985f4aec0afd3eb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Import the Jetty BOM

This is well-defined and only specifies Jetty artifacts.

Change-Id: I09d9dfa83a85c182f9d005ebe8c319af9586f70d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala-parser-combinators to 1.1.2

https://github.com/scala/scala-parser-combinators/releases/tag/v1.1.2

Change-Id: I8d90620c7de23ee308e7fb0d76199e6dc0da3fe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump reactive-streams to 1.0.2

https://www.lightbend.com/blog/update-reactive-streams-102-released

Change-Id: I9c515c487bead630cc8c55364f341b14a5aa9d27
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.22

https://akka.io/blog/news/2019/04/03/akka-2.5.22-released

Also align typesafe.config and ssl-config:
https://github.com/lightbend/config/releases/tag/v1.3.3
https://github.com/lightbend/ssl-config/releases/tag/v0.3.7

Change-Id: I4c119e9b928f05e4de90452ffd443eddee1babd3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.17.1

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2019/04/03/version-2-17-1

Change-Id: I930ad4010e3012ae04bbc4e443f39fde5f5d5151
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump XBean 4.12 → 4.13

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12344253&projectId=12310312

Change-Id: I8c2cac968b17fd88814051d12520237031c7a9ca
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Sevntu Checkstyle 1.32 → 1.33

Release notes:
http://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.33.0

In particular, this allows ForbidCertainMethodCheck to be used with
lambdas (see https://git.opendaylight.org/gerrit/73686 for an
example).

Change-Id: Ied43e31d6db228f2c70988047d20b8a63ee10f37
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Mockito 2.25.0 → 2.25.1

Release notes:
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2251

Change-Id: I1967cee18a8b6385cb410406c0fdc1f7f24bd7e6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump asciidoctorj-diagram to 1.5.16

No upstream changelog that I can find...

Change-Id: I7e33b72ad115f99674fb37ac18c6cb182765de76
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-plugin-plugin to 3.6.0

https://blogs.apache.org/maven/entry/apache-maven-plugin-tools-version1

Change-Id: I88fd468d38730bd5edcf1b3e22a3109d613c50b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a script to fix JSR-305 dependencies

This adds the jsr305 dependency in modules which need it but don’t yet
have it.

Change-Id: Iedc9d8350b4bea0ee9eae709c033ef35a5796658
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump versions to 5.0.1-SNAPSHOT

This starts the next release.

Change-Id: I1d2dfd00138445130c0683cd8abb3c57e17a88d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update release-notes

We have delivered the fix for ODLPARENT-130, reflect that in the
release notes.

Change-Id: Id9fc2b315db9d4358469d64244fa848ee3aaae58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove features-test's exclusions

opendaylight-karaf-empty has three additional dependencies, which
need to be present in local repository when we run SFT. This would
normally be achieved through transitive dependencies, but it does
not work due to features-test exclusion of these.

This was due to infrautils using features-test and also requiring
no classpath duplicates, hence single-feature-parent needed to
explicitly name them -- which broke when we added BouncyCastle
framework extensions and did not add them to single-feature-parent.

This has changed since then, though, and infrautils is using
bundles-test-lib, which does not bring the duplicates, and thus
features-test is used exclusively by SFT.

Therefore remove the exclusion and duplication single-feature-parent,
restoring sanity.

Change-Id: I167bae2965706406b5040a699929963c66e59e31
JIRA: ODLPARENT-130
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency on OSGi compendium

The artifact name changed and we are getting compendium populated
at 5.0.0. This changes to using osgi.cmpn instead.

Change-Id: If594ed56ad9cfa91b1e03b4778ea75c138bf1a64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

opendaylight-karaf-resources needs framework-ext

The build order is important, as we are running populate-local-repo,
which warns about them not being available during staging build.

Change-Id: I96c3a1aee601864d444b5d5ba894868c1d57dcee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate features-akka into features-odlparent

We do not need a separate feature repository for akka, just
integrate it into features-odlparent.

JIRA: ODLPARENT-195
Change-Id: If03312353506d8b83e4b9350ab83433bc8dadcaf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odlparent-5 release notes

This populates release notes for 5.0.0.

Change-Id: I49a26fe1f70e6a4f7a4a9e2b5d382e48f149d175
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-javadoc-plugin to 3.1.0

https://mail-archives.apache.org/mod_mbox/maven-announce/201903.mbox/%3C6064d830-474c-4b43-afef-99502c3a305a%40getmailbird.com%3E

Most important is the javadoc-links fix.

Change-Id: I5b9e270a39c67248b89b378476c870174c769a1a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Guava to 27.1

https://github.com/google/guava/releases/tag/v26.0
https://github.com/google/guava/releases/tag/v27.0
https://github.com/google/guava/releases/tag/v27.0.1
https://github.com/google/guava/releases/tag/v27.1

Change-Id: Ieb3ab9c1a94cb31a7c7d7d36ea7cf22c838547f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow multi-version builds

Since we are defining maven.compiler.* properties, there is no
point in hard-coding that in plugin configuration, as it will be
picked up automatically.

When we are running with JDK9+, also define maven.compiler.release
to pass --release flag to javac, which fixes cross-compilation
warnings about boot class path -- see JEP-247 for details

Since the version configuration is driven by properties, downstreams
now can easily override the defaults and use that to create JEP-238
jars.

Change-Id: I36e7aaa857b91f1d68eac800c275306325a96e0f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow javadoc links to be opted-in

Some artifacts need javadoc links to be activated irrespective
of the command-line. Property activation does not work, as it binds
to a system property, hence it cannot be activated from a downstream
pom.xml.

Switch activation to check for odl-javadoc-links-optin file being
present.

Change-Id: I9d9d73b8e264659bacd6377301f4a7751b92d170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove superfluous junit API link

junit.org link is the right one, drop the obsolete one.

Change-Id: Ieee17229caa1d26d69b19e9b62596dafb3b1b507
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded dependency

odlparent already pulls in junit, there's no point in bundle-parent
doing the same.

Change-Id: I67f43f49ed0792d8484ec878f8ee35029bd2a275
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs-maven-plugin to 3.1.11

No release notes around, only list of changes:
https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.8...spotbugs-maven-plugin-3.1.11

Change-Id: Iefab2b724e7969b9e7d075b7f970910b4abe62a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix log4j configuration

We are missing the strategy name, which means SFT is blowing up
downstream. Also max parameter specifies the maximum suffix, hence
we would end up with nine files.

JIRA: ODLPARENT-153
Change-Id: I8a12a2ded2d5ad306926016df98bc0b3e42a66f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make javadoc HTML5 support an opt-out feature

Our long-term goal is to support HTML5 javadoc, which is not supported
by our current JDK8 tool chain, but is available with JDK9+.

JDK9+ allow fallowing back to html4 with the appropriate option, but
this option causes JDK11+ to emit a warning.

The transition to HTML5 should not be too hard and we want migrate
seamlessly while still allowing downstreams to defer the migration.

This patch makes the -html4 profile conditional on the existence of
odl.javadoc.html5.optout file in maven project root directory, thus
achieving the goal of not emitting warnings on compliant projects
with newer toolchain.

Change-Id: Ida91e9ffbe74afaac2a2edd43e066e57f73991a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump ThreeTen to 1.5.0

Changelog:
https://www.threeten.org/threeten-extra/changes-report.html#a1.5.0

Change-Id: Ie99309c56e688daceddfbe074d60750997ffce80
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Xtend to 2.17.0

Changelog:
http://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2019/03/05/version-2-17-0

Change-Id: I8ea02c12b0097111bda27bb9b72c0bc80a94ea0d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Immutables to 2.7.5

Changelog: https://github.com/immutables/immutables/#changelog
(nothing for 2.7.5 though).

Change-Id: I3e67a710e036405a5256756954efd6a01d157047
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SpotBugs to 3.1.12

Changelog:
https://github.com/spotbugs/spotbugs/blob/3.1.12/CHANGELOG.md

Change-Id: Iadbfa71fd5665421e0bda574ae3110cd3185ca95
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump h2 to 1.4.199

No release notes, but this fixes a number of regressions in 1.4.198;
see https://github.com/h2database/h2database/issues/1778 for the
discussion leading to the release.

Change-Id: I39f1f0ac4c5f5ca98a3aef7a5597a483532b2877
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Error Prone to 2.3.3

No changelogs; they would normally be on
https://github.com/google/error-prone/releases/tag/v2.3.3

Change-Id: I5d1409e7011ba8c6fdad0171f00abdc3f5a8a225
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump asciidoctorj-diagram to 1.5.12

No upstream changelog that I can find...

Change-Id: I2dbdf1c72adbb916639113fe67b2e0f8a31784a1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.1.34

https://netty.io/news/2019/03/08/4-1-34-Final.html

Change-Id: I4ced054420ebca6897d7bf240c745684ab8935a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump karaf.log size to 64MiB

We can log quite a chunk of messages during startup, bump our log
size to 64MiB, so we do not have to reassemble logs.

JIRA: ODLPARENT-154
Change-Id: Icd2ffccc8d11f6c2399162442144eec936d3e7b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle to 8.18

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.17
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.18

Change-Id: Iddb56f43cc049f36b04a20c5c9ad668fa4fdaccb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BLACKLISTED_BROKEN_FEATURES

Since we are generating features and testing only individual ones,
there is no point in keeping the blacklist around, as features which
need to be disabled can just define sft.diag.skip or disable testing
completely.

JIRA: ODLPARENT-58
JIRA: ODLPARENT-80
Change-Id: I4ce7fbca7a190571ee650cdedd3fc9a955ffddcf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade hamcrest to 2.1

https://github.com/hamcrest/JavaHamcrest/blob/master/CHANGES.md#version-21-21st-december-2018

Change-Id: I6a1bfc069aeb7444cec0e24115ca8a6f4a9fbb18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mockito to 2.25.0

https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2240
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2250

Change-Id: I0f1cd702766b5a81d3c1dc4979a9705482cccf4c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump javassist to 3.24.1_GA

https://github.com/jboss-javassist/javassist/releases/tag/rel_3_24_1_ga

Change-Id: I1a7816e1e9a1f841e85a0bcc0c3e11e64455955e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump truth to 0.43

https://github.com/google/truth/releases/tag/release_0_43

Change-Id: I3556aa619b8042fbabcce5fdef024c0d28ecef58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not pull in JSR305 by default

The migration to findbugs:annotations is actively hurtful to us,
as JSR305 is clashing on javax.annotation package with JEE
annotations.

This patch removes findbugs:annotations, making them a banned
dependency, and instead defines spotbugs:annotations and
findbugs:jsr305.

spotbugs:annotations replaces findbugs:annotations as the default
dependency.

JIRA: ODLPARENT-198
Change-Id: I3e113fb3af3f2cdd6e4cd6b22ffc0dcac5efbcf9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump bug-pattern from 1.4.0 to 1.4.2

Bumps [bug-pattern](https://github.com/KengoTODA/findbugs-slf4j) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/KengoTODA/findbugs-slf4j/releases)
- [Changelog](https://github.com/KengoTODA/findbugs-slf4j/blob/master/CHANGELOG.md)
- [Commits](https://github.com/KengoTODA/findbugs-slf4j/compare/findbugs-slf4j-1.4.0...findbugs-slf4j-1.4.2)

Change-Id: I2ffdcb38e3afcc81539058db1d690a9ba4c5a936
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update rollover appender maximum files

For both logs we retain max of 8 files, giving us 64/128M backlog
of what was happening.

JIRA: ODLPARENT-153
Change-Id: If6885a6bf2785cc97b5a2d91117717eec04763df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Specify versions-maven-plugin 2.7

Our Maven configuration matches best practices: we no longer specify
prerequisite and use the enforcer to specify the version of Maven we
need. Unfortunately the default version of versions-maven-plugin
doesn’t recognise this and complains about our valid configuration
with a confusing message (see
https://github.com/mojohaus/versions-maven-plugin/issues/48 for
details). This patch enforces version 2.7 which works.

Change-Id: I9af5d7803132c1ee5735d0797f37d2434cf812cf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Trim down BLACKLISTED_BROKEN_FEATURES

unimgr, tsdr and gbp are not part of the project and would be
expected to fix their issues before re-joining. Remove them from
blacklist.

The controller features still need some work, which will be followed
up on.

Change-Id: Ic0c0e0e7f5fd21d28323fa0eae4b4a00d8cb19ac
JIRA: ODLPARENT-58
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Restrict the Blueprint Maven plugin's scan path

This ensures that by default, the plugin only scans the project's
artifacts, not everything available on the class path. This reduces
the build time and avoids extraneous bean declarations.

Change-Id: Ib5bb5e6fce59e9284a4264eafe7c121b6c08d819
JIRA: ODLPARENT-109
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump powermock to 2.0.0

https://github.com/powermock/powermock/releases/tag/powermock-2.0.0-beta.5
https://github.com/powermock/powermock/releases/tag/powermock-2.0.0-RC.1
https://github.com/powermock/powermock/releases/tag/powermock-2.0.0

Change-Id: Id0e271ac46161842894222564181d56d357cb1b2
JIRA: ODLPARENT-187
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove org.json declaration

org.json has a bad license, make sure we do not encourage its
proliferation. Downstream projects need to declare it themselves,
preferrably migrating away.

JIRA: ODLPARENT-36
Change-Id: Iea11eb093781e6f63301e70b2558e38e7d37f98a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odlparent-dependency-check order

Regenerate the file, so we get proper order of ssh artifacts.

Change-Id: I9f82bdc9cdf341933a62372d4397c0dc08d8ad2d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update OSGi infrastructure to 6.0.0

Karaf is providing OSGi version 6, there is no point for us to
stay on version 5.

Change-Id: I5cb7243db9c0d75c273d562475b843cb76bf1288
JIRA: ODLPARENT-188
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove org.jboss.resteasy/jaxrs-api

We provide this package through javax.ws.rs-api, remove this old
artifact.

Change-Id: I7c49e9ac55c8519e59732adaae7c73c3ba17f747
JIRA: ODLPARENT-196
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Cassandra driver version declaration

Declared version does not mix with our Guava version and it is not
used in OpenDaylight proper. Remove the declaration completely.

Change-Id: Id2f66fcaed87053b709c779a3bb483d8436cb6f8
JIRA: ODLPARENT-199
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Jersey-1 support

We have migrated to Jersey-2 and have provided a migration grace
period. We now remove support for Jersey-1.

JIRA: ODLPARENT-191
Change-Id: I85eac8a3df66640c15add56676952298112a8de1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove gmaven-plugin declaration

gmaven-plugin is obsolete and we are not using it anywhere. Any
downstreams are kindly asked to migrate to groovy-maven-plugin.

JIRA: ODLPARENT-192
Change-Id: Ifd7a637fb5191bd168e32e4b035eb5193143e49a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove old enunciate declarations

enunciate has moved to a new place, com.webcohesion.enunciate,
where it is supported through enunciate-maven-plugin. This patch
removes the old codehaus declarations.

JIRA: ODLPARENT-190
Change-Id: Ic2df9cbf8962212623d6a36710e948d1f9e7415c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove findbugs support

FindBugs is obsolete, does not work with JDK9+ and replaced by
SpotBugs. Remove it from all declarations.

JIRA: ODLPARENT-186
Change-Id: Id8237ac38f8291954d041b0d4ca3becb5aea89ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 5.0.0-SNAPSHOT

This bumps versions for Sodium development.

Change-Id: I280c718472237e47b381f617d68c0a247afc07f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a fix for KARAF-5086

This is manual upgrade of aries/proxy-impl to make it work with
Java 8 default methods.

Change-Id: I05ad26c2608bb76f4482e231cf5d07e0016f7082
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit fe6f26cbf3ced523b8251e7a9a8c48cd10441cb4)

Bump commons-codec 1.11 → 1.12

Release notes:
http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: I2fe5fcf57885b562a5d63859440aa15428ebbe90
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to h2 1.4.198

Changelog: http://www.h2database.com/html/changelog.html

This fixes at least one security issue (CVE-2018-14335).

Change-Id: I41c7157a85324dc1321f69f92eca491c1edefc8f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump to Bouncy Castle 1.61

Release notes: http://www.bouncycastle.org/releasenotes.html

Change-Id: I6852d79b546f822c992ed78ad6741dc3bf7b7311
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump apache-sshd to 2.2.0

https://github.com/apache/mina-sshd/compare/sshd-2.0.0...sshd-2.2.0

Fixes important to us are:
https://issues.apache.org/jira/browse/SSHD-840
https://issues.apache.org/jira/browse/SSHD-846

Change-Id: Ibceff00b84adce003595042fcfca001bbaecca47
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-197: META-INF services are not packaged

- We need to count META-INF services generated by annotations like
  @AutoService or @MetaInfServices.

Change-Id: Iebc421778f2894c6bef998ff371f06c1a5db24e1
Signed-off-by: Jie Han <han.jie@zte.com.cn>

Bump akka, aeron, agrona to 2.5.21, 1.15.3, 0.9.33

https://akka.io/blog/news/2019/01/29/akka-2.5.20-released
https://akka.io/blog/news/2019/02/13/akka-2.5.21-released

https://github.com/real-logic/aeron/releases/tag/1.13.0
https://github.com/real-logic/aeron/releases/tag/1.14.0
https://github.com/real-logic/aeron/releases/tag/1.15.0
https://github.com/real-logic/aeron/releases/tag/1.15.1
https://github.com/real-logic/aeron/releases/tag/1.15.2
https://github.com/real-logic/aeron/releases/tag/1.15.3

https://github.com/real-logic/agrona/releases/tag/0.9.28
https://github.com/real-logic/agrona/releases/tag/0.9.29
https://github.com/real-logic/agrona/releases/tag/0.9.30
https://github.com/real-logic/agrona/releases/tag/0.9.31
https://github.com/real-logic/agrona/releases/tag/0.9.32
https://github.com/real-logic/agrona/releases/tag/0.9.33

Change-Id: I8368a58a8c371e4c3e042399abcb41bca96901ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add osgi.cmpn declaration

The artifact name for OSGi Compendium has changed with release 6.0.0,
this patch provides the new definition so downstreams can seamlessly
migrate.

Change-Id: I1b1a23713bfa3670e422f2e6f97e8b2066804f0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update org.apache.logging.log4j dependencycheck

This declaration was not updated when we bumped, fix that up.

Change-Id: Ida641027c1f1f54ca012757bda67cecc085f2940
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump antlr to 4.7.2

https://github.com/antlr/antlr4/releases/tag/4.7.2, most significant
is the inclusion of automatic module names.

Change-Id: I1ea0fd53943b2332abdb33f8f7c88a8699bde237
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to log4j 2.11.2

Release notes:
https://github.com/apache/logging-log4j2/blob/log4j-2.11.2/RELEASE-NOTES.md

Change-Id: I1e6f18f0b1b8d21d449beca33743904bd2785b0c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-invoker-plugin from 3.1.0 to 3.2.0

Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/apache/maven-invoker-plugin/releases)
- [Commits](https://github.com/apache/maven-invoker-plugin/compare/maven-invoker-plugin-3.1.0...maven-invoker-plugin-3.2.0)

Change-Id: I785538c04acb726ff224d0f9178299e2b826a65a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump jacoco-maven-plugin from 0.8.2 to 0.8.3

Notable changes from the linked Release Notes include that
"JaCoCo now officially supports Java 11".

Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.2 to 0.8.3.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](https://github.com/jacoco/jacoco/compare/v0.8.2...v0.8.3)

Change-Id: I771424043515944bb2d367ceb225d75ddb888fd4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump netty to 4.1.33

https://netty.io/news/2018/11/29/4-1-32-Final.html
https://netty.io/news/2019/01/21/4-1-33-Final.html

Change-Id: I22d9459744a152f5c273bacaa32fcb938aa6bf1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix javadoc-links with plugin-3.0.1

maven-javadoc-plugin has a bug which prevents non-redirecting links
from working. This adds a workaround forcing redirects to happen.

Change-Id: Id9ace69f6fce4d645eeaebf636a9433aa779f397
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update junit javadoc link

Javadocs have moved, the old site does not exist anymore, update
the link accordingly.

Change-Id: I9344f25cb24bb8812cff9d52192ce7eb5d2f3528
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add javadoc-links property activation

There is a distinct case when we want to explicitly activate
the profile in certain poms. Add a property activation to allow
doing that.

Change-Id: If55913b1c94dd8d7b6298fdf4ff5d4f59727b641
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump h2 database to 1.4.197

This includes a ton of fixes, the changelog is at
http://www.h2database.com/html/changelog.html

Change-Id: I300ee7a57ea36bc0a0cfa839f6ddea26ea3f2dd9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version to 4.0.10-SNAPSHOT

This starts the next development cycle.

Change-Id: Iaf15eab2e3318de7e03fc97c4f2d7cb056d7f418
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Woodstox to the release notes

Change-Id: Ie5c6d644e464ac117a1cbd79b9039efeb486bad0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Update the 4.0.8 release notes"

This reverts commit 551259dbdaf1a86f22988b9f0f4787949b17126f.

Change-Id: Iedab8cc2c0690fe5cd85e983af481c0cfddaff48
JIRA: ODLPARENT-184
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Restore "Add SLF4J dependency for SpotBugs"

This reverts commit 08eb264e99cec9af128fcd87c732c40188b60a9c; the
SLF4J 1.8 dependency is carried by SpotBugs 3.1.9, so we do need
this.

Change-Id: Ia6789cc9be29f2ac5d83c73bbe893c34dc68216e
JIRA: ODLPARENT-184
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add odl-woodstox

This is a StAX implementation used by jackson, and forced on us
through Karaf. It contains useful utilities, hence make it available
as a separate feature.

Change-Id: I0df2faefe7522dbe7d02187d179334b44acfcef5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded javax.ws.rs-api dependency

jackson does not need to spell this out, it is provided by
odl-ws-rs-api feature, which we pull as dependency.

Change-Id: I333bce0f62fda6c7beb3b5ccfe8df724c32e2312
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove hibernate-validator-osgi-features hack

We have moved on to a karaf version which does not need this hack,
remove it.

Change-Id: Icb67a337cc739c2aba83777c70c850dfc26ac89d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency-check

This is a refresh after running update-dependencies.

Change-Id: I64cfbaeff5d95667e3129440e87d008ad563fd49
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update 4.0.9 release notes

This adds the news bits about karaf packaging.

Change-Id: I84a7e4526350f12e9c155aae0456b026161c6948
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add feature descriptions

<description/> stanzas are propagated to feature details,
override the default specified to odlparent-lite.

Change-Id: Idc2b700d2057914fd4e27177e877150720da7805
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneded artifact.toString()

Logger will call toString() if needed, remove the explicit call.

Change-Id: I169e98bc7a04390f56503666782ac1bdb7413b61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove local artifacts after merging features

features.cfg has references to some features, which we are probably
patching, hence we need to merge them before we perform removal
of artifacts from install request.

Change-Id: I42fad1a7eff17778dccdfdd8c0936c2aa35606b4
JIRA: ODLPARENT-194
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow karaf-plugin version to be overridden

Us hard-coding the version here prevents downstreams from
using dependencyManagement section to override the version.

Make sure we use dependencyManagement, which can easily be
overridden.

Change-Id: Ib644b5e0a56e13236730cfb07a8eb853886dfd14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove local artifacts from install request

Since we may have artifacts in the local repository which have
modifications, we do not want to include them in the install
request.

Make sure we exclude such artifacts.

Change-Id: Ib468cac841875e13124ead73c9f8911a29caa2ff
JIRA: ODLPARENT-194
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not read feature twice

We have already read the feature, there is no point in unmarshalling
it yet again.

Change-Id: Id34dc83165b0479e12abdb915ec8dc42cfa9853a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 4.0.9

Change-Id: Ic579cb62ca8159c603d506f26dee61ccdd1dd278
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update the 4.0.8 release notes

... with the SLF4J / SpotBugs revert.

Change-Id: I085c79e854dacd98c4ee3287ec1b6a78bfcb0748
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Add SLF4J dependency for SpotBugs"

This reverts commit 105806df6324df4d9f6db145f3631b44aeff0a0d which is
irrelevant now that the SpotBugs bump has been reverted.

Change-Id: Ie02967cd10908d994351f06532e89dbfe0dde7f5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.8

Change-Id: Iab9e444ceb3b397600081a62c22ac0c6f991841e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump SpotBugs 3.1.9 → 3.1.10"

This reverts commit 8119cd6455c1c4524671eb69c6274b0780f8cc4d. The
stricter NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION check causes build
failures in other ODL projects.

Change-Id: I333e5e9a9870e1756462520dcba86b89a4a77972
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-fileupload 1.3.3 → 1.4

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: If828c54b89dca8dcfb0a7cf51ab97e59c563fd24
Signed-off-by: Stephen Kitt <skitt@redhat.com>