Merge "Avoid exceptions with IPv6 subnets"

Avoid exceptions with IPv6 subnets

In a setup where ODL is used for L2 support and Neutron L3 agent
is used for Routing, we see some Java exceptions when IPv6 subnets
are created. Because of the Java exception, Layer2 connectivity
is lost and we are unable to work with IPv6 subnets. In this patch,
we log an error instead of exception.

Patch set 2: add other places in netvirt code where ipv6 (address and prefix)
             could be used and it would be improperly interpreted.

Patch set 3: minor code review changes.

Change-Id: I4e253f8f86a1a3f027e57861549e9a1f98ff5fbf
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: SridharG <sgaddam@redhat.com>

Merge "Use odlparent-lite as artifacts parent"

Merge "Create Physical Switch by listening on DS"

Merge changes from topic 'sonar-cleanup'

* changes:
  Remove unused code and imports
  General code cleanup
  Simplify AbstractNeutronInterface::readMd

Merge "Drop redundant ofPort check"

Merge "Inline return values"

Merge "Added Update and Remove commands code"

Merge "Changes to LogicalSwitchUpdateCommand in transact as per new yang"

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Iec5b15f027a64ad9498fcd9c874be1b4e57e682c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Create Physical Switch by listening on DS

PatchSet2:
1. fix update issue
2. update postman collection

PatchSet3:
1. change according to review comment

PatchSet4:
1. fix IP To String issue

Change-Id: I16357d027bdcd8b03e2f0a0d2bedf57bd4a4864f
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Avoid calling the String constructor explicitly"

Added Update and Remove commands code

McastMacsLocalUpdate/Remove done.
UcastMacsLocalUpdate/Remove done.
LogicalSwitchRemoveCommand updated as per new yang.
Some minor fixes done in PhysicalLocatorUpdateCommand.

Redundant Blanks and comments removed.
Some comments Updated.

Change-Id: I4e19fc42e0c935da99e3330e442067b2c62be694
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Changes to LogicalSwitchUpdateCommand in transact as per new yang

1. changes to LogicalSwitchUpdateCommand in transact
2. remove redundant code

PatchSet 2:
1. Get "extractCreated" back

PatchSet 3:
1. Change postman collection as per new yang

Patchset 4:
Fixed update issue in LogicalSwitchUpdate command

Change-Id: If2f34ed570bfa0f265c976178272dc07674766ec
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Remove unused code and imports

Change-Id: I9f9fe46abc4feba4a0795b8380b5c9bf4e894716
Signed-off-by: Stephen Kitt <skitt@redhat.com>

General code cleanup

Use <> where appropriate.

Remove a couple of unnecessary unboxing statements.

Reduce variable scope.

Simplify a couple of boolean expressions (Optional<T>.get() is
instanceof T if it's not null).

Fix up some documentation.

Change-Id: I6db39ad20e3245c03fff94cb96fbc8b09f4f57dc
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Simplify AbstractNeutronInterface::readMd

Use B for the parameter type to avoid masking the main T parameter
type.

Inline the optional handling.

Change-Id: I3f54589aec36b7fb378d7a0936743961946aa11b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop redundant ofPort check

Because of the break in the loop, ofPort is always 0 when the if
statement is reached, so it can safely be removed.

Change-Id: Ia700962e9d5a7d8a4dd0fa1af61811694ac366fe
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Inline return values

Change-Id: Iea346d6682801f11e69a22c0330aabcef2a0dd4c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Add option to use netdev datapath_type"

Add option to use netdev datapath_type

Change-Id: Ica37449612dc2465ddd71bfc19caa9a599354c34
Signed-off-by: Sam Hague <shague@redhat.com>

Avoid calling the String constructor explicitly

Change-Id: I3f57df03746acafe11def7cdced65822b31117a5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

yang changes, PhysicalLocator and UcastMacsRemote

1. Added PhysicalLocator and UCastMacsRemote Update code.
2. Yang: Modified logical-switch-ref to correct type based on recent
changes
3. Yang: Moved all mac attributes to Global node from PhysicalSwitch.

Change-Id: I1a51ea9a4423144892488d9de6d01e7b5271d18b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Changes to LogicalSwitchUpdate as per new yang"

Merge "Added UT and refactored code 1) Added UT for SecurityServicesImpl and SecurityGroupCacheManagerImpl. 2) Refactored a method in SecurityServicesManager."

Merge "UT for ProtocolRemovedCommand class"

Merge "Clean up L2ForwardingService"

Merge "Move NetvirtIT to use latest IT parent poms"

Move NetvirtIT to use latest IT parent poms

Change-Id: If59f183f08b0a98514ff1db4c6e0fb7cc1c2ed7c
Signed-off-by: Sam Hague <shague@redhat.com>

Changes to LogicalSwitchUpdate as per new yang

Patchset2: review comments

Change-Id: I0bff6c4a2dbcb63fde20da8c2595061af5e8bca2
Signed-off-by: karanrajsingh <karan.raj.s.singh@ericsson.com>

Added UT and refactored code
1) Added UT for SecurityServicesImpl and SecurityGroupCacheManagerImpl.
2) Refactored a method in SecurityServicesManager.

Change-Id: I039d34869d182bc19ad89733092e0a5f35f67295
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Merge "Change hwvtep.yang and fix related code"

Change hwvtep.yang and fix related code

1. Change hwvtep.yang based on https://git.opendaylight.org/gerrit/#/c/29797/.
2. Fix related code.

Change-Id: I314ddc23daebe59bd3ed241fa80803ce4845ef37
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "Test code for failing IT test 2"

Test code for failing IT test 2

Change-Id: Idf46604a17d5b96f3b62f29f17be1fbeb12d2b67
Signed-off-by: Sam Hague <shague@redhat.com>

Test code for failing IT test

Change-Id: I250408640b46e60d0ae67bfe75b898fb077ea2ff
Signed-off-by: Sam Hague <shague@redhat.com>

UT for ProtocolRemovedCommand class

Change-Id: Icd2b454b49b214735540c20281d6611071309947
Signed-off-by: Layth Al-Ani <lalani@inocybe.com>
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Clean up L2ForwardingService

Avoid multiple instanciations of MatchBuilders.

Factor common code involved in FlowBuilder setup and instruction
construction, adding appropriate methods in FlowUtils and
InstructionUtils.

Use fluent-style builders.

Drop appendResubmitLocalFlood() which isn't used.

Avoid multiple creations of the same Uri in loops.

Two of the FlowBuilders don't have a setStrict() call; is that
intentional?

Change-Id: I984a735229613bd013443ff16815a1566a74b2d5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "L3: Add eth to br-ex"

Handle new base type provided by MD-SAL

When deserialized, OvsdbBridgeAugmentation's datapathType is now
initialized as DatapathTypeBase instead of null. This is now handled
as an absent value in SouthboundMapper instead of producing an
IllegalArgumentException.

The exception's message is clarified to trace the unknown datapath
type class, instead of the value retrieved from the map (which is
always null in this case).

Change-Id: Ie10ff09878bf182d4747d63f1580a37dfd71ac88
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Remove a few obsolete dependencies"

Remove a few obsolete dependencies

A security upgrade for commons-collections was released, but it turns
out ovsdb no longer uses it; this patch removes that from dependency
management along with a couple of other obsolete dependencies.

Change-Id: I7d3ba0c908e5306475f35ce9e07b0099f9c8f4cf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use an Autoclosable to guarantee bridge clean-up

TestBridge encapsulates a bridge created in OVSDB; with
try-with-resources this means we know we always clean the bridges up.

Change-Id: Iac00febaa8525d985bd4ba2b71393dd1d086c314
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Share a single OVSDB connection among all tests

This helps SouthboundIT greatly, and the OVSDB is clean after the
tests finish.

Change-Id: I0ee431a269468b973cc01bd07bb766950f0b5a52
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Maven cleanup and features-parent migration"

Merge "Added code for PhysicalPort, LogicalSwitch"

Merge "Added support to update flows for induvidual security rule add/remove , after the SG is associated with a port."

Merge "Use MD-SAL events to react to OVSDB changes"

Merge "SouthboundIT: merge the CRUD tests methods"

Maven cleanup and features-parent migration

Use features-parent {{VERSION}} to allow dropping a number of Maven
properties.

Upgrade commons-collections (1.0 -> 3.2.1) and httpcomponents (4.2.1
-> 4.4.1).

Drop a number of obsolete components from dependency management
(controller:commons.northbound, controller:containermanager,
controller:forwardingrulesmanager, controller:sal,
controller:switchmanager.

Use odlparent-provided versions of commons-lang3, most netty
components, and the equinoxSDK381 components.

Drop obsolete io.netty:netty:3.8.0 dependency (replaced by
io.netty:netty-all in versions 4+).

Remove some duplicate dependency declarations.

Use "<relativePath/>" instead of "<relativePath></relativePath>" now
that it's safe to do so (the auto-release scripts handle it).

Change-Id: I62a385ba49d79e045934ec706f69313425553ae0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts

Change-Id: Ie9110ebcfb7412015c171e0add5faa89ecd5d293
Signed-off-by: Sam Hague <shague@redhat.com>

Added code for PhysicalPort, LogicalSwitch

1. Added PhysicalPortUpdate and PhysicalPortRemove
2. Added LogicalSwitchUpdate and LogicalSwitchRemove
With these changes physical-port and logical-switch changes on device are
reflected in OperationalDS.

Patchset2:
1. Rebase
2. Add VlanBindings to OperationalDataStore
3. Use env vars for IPs in postman collection
4. Fixed a bug in postman collection

Change-Id: Ic1b3d0e15088db6d81316ad88c2db5299a9c9be0
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Listen config DS then push configuration to switch"

Merge "Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts"

Bug 4641 - openstack.net-virt-sfc-features fail to find artifacts

Change-Id: Iccc0c5d817db0014842f5e7023b173c67af728e2
Signed-off-by: Sam Hague <shague@redhat.com>

Listen config DS then push configuration to switch

Patch Set 1:
1. Add skeletal code for command pattern to push configuration to switch, function TBD.
2. Implement LogicalSwitchUpdateCommand.

Patch Set 2:
1. Fix whiteapce issues.
2. Add 'logical-switch-managed-by' for logical-switch-attribute in hwvtep.yang.
3. Use hcm.getConnetionInstance(node) added in https://git.opendaylight.org/gerrit/#/c/29599.

Patch Set 3:
1. Fix LOG severities and delete some TODOes.
2. Use HwvtepSchemaConstats.databaseName for Hwvtep database name.

Change-Id: I0fe5dafdf9ecfa91ee8c757c4b694a50e6cbed35
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "rework sfc flows 2"

Merge "Patch Set 1: Add postman collection for HwvtepSouthbound"

rework sfc flows 2

Change-Id: I9cb93d19d54cd7bcf7d93ab82e17dbe7579cafb3
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Security Groups: Added support for ICMP, ALL ICMP and Others protocol Change-Id: Iedc3061ccaf03f21b9a39da8a4b8b27c4baea6f0 Signed-off-by: raveek <raveek@hp.com>"

Merge "Fixed possible null point exception in node manager entries update code"

Patch Set 1:
Add postman collection for HwvtepSouthbound

Patch Set 2:
Add brief introduction in README

Patch Set 3:
Change to multi-line version

Patch Set 4:
Fix whitespace issues

Patch Set 5:
Fix whitespace issues: a trailing space missed

Patch Set 6:
recheck

Change-Id: If7a764ca56ced4316aa04ff8538bf12849d60dd9
Signed-off-by: Peng Zhang <pzhang@ctbri.com.cn>

Merge "add rsp option"

Merge "added getConnectionInstance by Node"

add rsp option

Change-Id: Idd0410436861ccc13ad581e42e75ea793102e3ad
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "UT for remaining classes in ovsdb.southbound.ovsdb.transact"

Merge "Declare expected exceptions"

Merge "Avoid logging stacktraces for schema version mismatches"

Fixed possible null point exception in node manager entries update code

Change-Id: Iac231117e592f23c6e1362b71e76ae13d6c98a40
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Merge "Bug 4611: null pointer exception while processing interface event"

For controller initiated connection, there is race condition
while disconnecting the device from controller, that does
not allow one of the non-owner southbound instance to disconnect
the device from the plugin. Race condition was occuring because
OvsdbConnectionInstance was not stored in the internal cache
at correct point in control flow.It gets added when EntityOwnershipChange
event happens, so when data change event for disconnection occured,
it requires OvsdbConnectionInstance to be in cache to disconnect
from the device, but OvsdbConnectionInstance was not in the cache
becuse EntityOwnershipService event was not recieved by that non-owner instance.

Conflicts:
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java
southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/SouthboundProvider.java

Change-Id: I3861b5f2907d08709a3bd1aa4f4ecfbfd444351d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Merge "rework sfc flows"

rework sfc flows

Change-Id: I1789ce135a8b08de4c4321fdd69cec73bc4a638c
Signed-off-by: Sam Hague <shague@redhat.com>

added getConnectionInstance by Node

This is required for https://git.opendaylight.org/gerrit/#/c/29575/

Change-Id: Iceab17399b973dab7c1fbf47d21af6989aa2f49e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "workaround for sfc part 2"

workaround for sfc part 2

Change-Id: Ib733682492ede0985dae97bbe3add80b359add1f
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "add rest of sfc flows"

add rest of sfc flows

Change-Id: I44629e889705c4e7f6a21c3655addee9670bc8c5
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "workaround for sfc"

workaround for sfc

Change-Id: I46b22b084627f95c1e478b1cf004681d21d4595c
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 4611: null pointer exception while processing interface event

Acl service needs to handle cases when port security info is not available.

Patch set 2: add unit test

Change-Id: I788d31e4f0001fcf70caa59086d432b01178de1b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Avoid logging stacktraces for schema version mismatches

Change-Id: Ic3db3d3526491bb488d396be64adc9e41e09a3d6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Declare expected exceptions

@Test supports declaring (and verifying) expected exceptions, let's
use that instead of manually detecting the exceptions.

Change-Id: Iafe26c2c566ebdfe7616a864d5e6c60d3b2b7fe2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

UT for remaining classes in ovsdb.southbound.ovsdb.transact

Change-Id: I7dfd78209e770c28a7ced22cea9308c5c9fe7ee8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

Added support to update flows for induvidual security rule add/remove ,
after the SG is associated with a port.

Change-Id: I88d485bb0725909f00b1bc8d48ef17705a8fc695
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Use MD-SAL events to react to OVSDB changes

Instead of just waiting after creating or deleting the OVSDB MD-SAL
node, wait for the corresponding event in the operational database.
This actually saves time in most cases (since the round-trip takes
less time than the static wait), and avoids failing tests
unnecessarily when the round-trip takes longer than expected. There's
an overall timeout to make sure we don't hang the test completely.

For now this only handles connectOvsdbNode() and
disconnectOvsdbNode(), but the stage is set for other MD-SAL
manipulations to be processed in the same way.

This isn't multi-threadable as-is.

Change-Id: If1279054f38192bed007d83f9fda981dc0c466f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

SouthboundIT: merge the CRUD tests methods

We use two variants, one for plain bridges, the other for termination
points.

Change-Id: I986d93c65cc90a37eaf0036ff93a0e4148ba030c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Security Groups: Added support for ICMP, ALL ICMP and Others protocol
Change-Id: Iedc3061ccaf03f21b9a39da8a4b8b27c4baea6f0
Signed-off-by: raveek <raveek@hp.com>

Merge "Added command patterns to update OperDS"

initial framework for sfc workaround and IT tests

Change-Id: I94a4a40659fb4f0a1ecc815a7d132ffcadd991de
Signed-off-by: Sam Hague <shague@redhat.com>

update exports for ServiceHelper

Change-Id: I7d7e97b5860dbaca87877d95759fe550a62855e8
Signed-off-by: Sam Hague <shague@redhat.com>

Add config for selecting provider

Change-Id: I5597573fa2cafd2e7db4d444fc51030adf478f7c
Signed-off-by: Sam Hague <shague@redhat.com>

Rework provider interface to allow different providers

Change-Id: Iaa36bc040e82005c3a8d419e23ad9ac8696c1215
Signed-off-by: Sam Hague <shague@redhat.com>

Add SfcClassifier to pipeline

Change-Id: I7de504449435678020efc3aca290897adada42ab
Signed-off-by: Sam Hague <shague@redhat.com>

Merge changes I4a8650ae,Ie2e119fd,Ic2acced7,Ieeb5ae5b,I2f7b6f8f

* changes:
  Fixed wildcarded imports
  Fixed NPE in md-sal secutiry groups to neutron security group conversion.
  Removed Flow id caches that is being used to check
  Populate the Node Cache at the controller start/restart.
  Repopulate router, port and floating ip related caches These caches can create a problem in a cluster environment where node goes down and rejoin the cluster. All the caches will be clear on restart, and if newly join node become master instance, it can break the functionality. This patch is re-populating all the required caches

Fixed wildcarded imports

Change-Id: I4a8650aefddd0455e55d005a2ffd017a34d64293
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Fixed NPE in md-sal secutiry groups to neutron security group conversion.

Change-Id: Ie2e119fdc24168f2ab4df26332244586c644912f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Removed Flow id caches that is being used to check

if flow is already installed or deleted. Now it will
install flow irrespective of whether the flow already
installed or not. It won't really do installation of
flow again, because if you write same data again, it's
going to be no-op. These caches create issues if new node
with same ovsdb ip:port connects the controller, but the
openflow bridge is different.

Change-Id: Ic2acced7a9a006e6e04afba6fea22aaf0620f134
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Populate the Node Cache at the controller start/restart.

This cache can be removed fully, but if we do that, we need
to make read call to the data store, where we will have to
read the whole topology tree, that can put some load on the
md-sal data store, and it might not be negligible in case of
clustered data store.

Change-Id: Ieeb5ae5ba01839b34aefe7d3916c6bdd0fb14808
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Repopulate router, port and floating ip related caches
These caches can create a problem in a cluster environment
where node goes down and rejoin the cluster. All the caches
will be clear on restart, and if newly join node become master
instance, it can break the functionality. This patch is re-populating
all the required caches

Change-Id: I2f7b6f8f8871eb7c6fc7c96d9e4e121adbf5c950
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>