Ed Warnicke [Mon, 28 Apr 2014 12:18:40 +0000 (12:18 +0000)]
Merge "Bug 460 - Fix warning throughout netconf subsystem"
Tony Tkacik [Mon, 28 Apr 2014 12:01:53 +0000 (12:01 +0000)]
Merge "BUG-732 Fix sal-netconf-connector unable to download schemas"
Maros Marsalek [Thu, 24 Apr 2014 12:09:02 +0000 (14:09 +0200)]
BUG-732 Fix sal-netconf-connector unable to download schemas
BUG#1 NetconfDeviceListener used wrong method to parse rpc results
BUG#2 Parsing rpc result in NetconfMapping was looking for schema to response even if it was not needed
BUG#3 Netconf client sent base netconf capability in wrong format
Change-Id: I4798b29bb8cd7361d24188b6d5ac40a612a0c6c8
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Martin Bobak [Mon, 10 Mar 2014 16:11:35 +0000 (17:11 +0100)]
Bug 460 - Fix warning throughout netconf subsystem
Change-Id: I461a7bab47ef67c13c6fd5864d8938cdd47c3c8b
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Martin Bobak [Fri, 25 Apr 2014 14:05:48 +0000 (16:05 +0200)]
Fix Operation not permitted warning.
This fix removes warning
WARN o.o.c.n.c.m.c.ModuleElementDefinition - Operation not permitted on
current strategy while default strategy is merge. Element definition
strategy set to default
that occured on osgi startup.
Change-Id: Ic12ce37e9bfa08cfffd0cac0e591fc49ffe227c6
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Tony Tkacik [Fri, 25 Apr 2014 08:56:45 +0000 (08:56 +0000)]
Merge "Bug 451 - Fix netconf exception handling"
Tony Tkacik [Fri, 25 Apr 2014 08:02:04 +0000 (08:02 +0000)]
Merge "BUG-832 Add initial configuration for controller self mount"
Martin Bobak [Mon, 3 Mar 2014 10:17:50 +0000 (11:17 +0100)]
Bug 451 - Fix netconf exception handling
Change-Id: I815b34da996cf2660650577edb2e8ca623ae96df
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Maros Marsalek [Thu, 24 Apr 2014 07:56:48 +0000 (09:56 +0200)]
BUG-832 Add initial configuration for controller self mount
Netconf server for config subsystem is mounted to restconf under id "controller-config" by default
This illustrates the usage of sal-netconf-connector
Change-Id: I3f324b41995dc094bac0d316788dfdb05e18ef60
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Martin Bobak [Wed, 23 Apr 2014 12:43:32 +0000 (14:43 +0200)]
Bug 722 - nagasena version bumped to 0000.0002.0038
Change-Id: Ie755a9a613096aed6f134005d216716c59b90563
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Giovanni Meo [Fri, 18 Apr 2014 14:09:09 +0000 (16:09 +0200)]
Remove unnecessary variable in netconf-it
- Another roadblock to release of artifact mdsal.version is used as
variable in netconf-it, remove it
Change-Id: I955b7796c46a0852fd74d2ce2d77a033669f5922
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Alessandro Boch [Fri, 18 Apr 2014 23:07:49 +0000 (23:07 +0000)]
Merge " Remove version mismatch in config.version"
Giovanni Meo [Fri, 18 Apr 2014 13:32:50 +0000 (15:32 +0200)]
Remove version mismatch in config.version
- End goal was to remove several config.version present in the pom, in
the making i cleaned some of the repetition in config parent pom and
aligned with the commons.opendaylight
- Removed some more warning on the pom files
Change-Id: I6717ceb915fe90fa7313472eb03884de9d09235d
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
jameshall03885 [Wed, 16 Apr 2014 18:18:57 +0000 (14:18 -0400)]
Adding auto-sorting plugin to all Controller via parent/pom.xml
leveraging google's sortpom plugin, all controller poms are sorted
at build time as per the opendaylight/commons/parent/pom.xml configuration.
Sorted lists of properties, dependencies, and plugins will increase pom readability
and help prevent duplicate entry errors.
This first submission is huge as I changed one pom.xml and all are then sorted.
Only if the sortpom plugin is reconfigured will all pom's again be changed.
Note that if any pom.xml is pushed without having been through a build ... folks are
going to see pom.xml files showup as modified unintentionally.
Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a
Signed-off-by: jameshall03885 <ghall@brocade.com>
Tony Tkacik [Wed, 16 Apr 2014 17:07:18 +0000 (17:07 +0000)]
Merge "BUG-731: do not do String.toString()"
Tony Tkacik [Wed, 16 Apr 2014 17:07:00 +0000 (17:07 +0000)]
Merge "BUG-731: do not catch Throwable"
Maros Marsalek [Wed, 19 Mar 2014 14:58:03 +0000 (15:58 +0100)]
BUG-472 Initial EXI encoder/decoder implementation in Netconf
according to http://tools.ietf.org/html/draft-varga-netconf-exi-capability-02
Change-Id: I861c126a8df1b26f477aa354ed1f8dba59d651cd
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Sat, 8 Feb 2014 03:06:48 +0000 (04:06 +0100)]
BUG-472: Add EXI codecs without wiring them
This patch implements the EXI codecs to be used in the NETCONF pipeline.
No wiring into the protocol stack is done in this patch.
Change-Id: Ic708ef26d92e138f8269a49a2759f01d88085bf1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 1 Feb 2014 08:26:54 +0000 (09:26 +0100)]
BUG-472: Import OpenEXI nagasena-0000.0002.0035.0
This imports the OpenEXI nagasena library, on top of which the
implementation will be built.
Change-Id: I4ec0fc637f390fe14451c439870ec1846934ebbb
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 16 Apr 2014 09:17:18 +0000 (11:17 +0200)]
BUG-731: do not do String.toString()
Fixes a sonar warning. Also adds missing copyright headers.
Change-Id: If16eebc39e7f0d7e9787529995b666f04d239cdf
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 16 Apr 2014 09:07:46 +0000 (11:07 +0200)]
BUG-731: do not catch Throwable
This fixes the bad practice of catching Throwable, and uses logger
instead of e.printStackTrace().
Change-Id: I44541f7c71dda0bcf633d22d9a46b3959ed3001f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 16 Apr 2014 08:28:40 +0000 (08:28 +0000)]
Merge "Resolve Bug:745 - remove windows line endings from config and netconf."
Milos Fabian [Mon, 14 Apr 2014 09:22:59 +0000 (11:22 +0200)]
Bug 491 - Use XmlUnit for xml comparing in junit tests.
-comparing XMLs as DOM Documents with XmlUnit
-added XmlUnit util class - contains common assertion tests
Change-Id: I505c7896e7243873b45c93ea3bf59c941a68924e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tomas Olvecky [Tue, 15 Apr 2014 11:26:05 +0000 (13:26 +0200)]
Resolve Bug:745 - remove windows line endings from config and netconf.
Change-Id: Id60c44a5f3fd4979f4e13cb00e6537998718e94f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 15 Apr 2014 10:40:30 +0000 (10:40 +0000)]
Merge "Bug 714 - Fixed creating DOM Document's element with namespace"
Tony Tkacik [Tue, 15 Apr 2014 10:25:03 +0000 (10:25 +0000)]
Merge "BUG 718: changed codec for URI parsing"
Tony Tkacik [Tue, 15 Apr 2014 10:09:26 +0000 (10:09 +0000)]
Merge "Resolve Bug:713 - Open snapshot only once per session."
Tony Tkacik [Tue, 15 Apr 2014 08:49:27 +0000 (08:49 +0000)]
Merge "Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean."
Tomas Olvecky [Mon, 14 Apr 2014 08:22:26 +0000 (10:22 +0200)]
Resolve Bug:713 - Open snapshot only once per session.
Rework NetconfOperationServiceSnapshot lifecycle: Open it when
session negotiator is requested, thus at entry point where both
hello message and session listener is created. Close the snapshot
when NetconfSessionListener receives down/terminated event.
Change-Id: Id491110524ab635e552a49f48e4938dd7113d8bf
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tomas Olvecky [Thu, 10 Apr 2014 12:13:14 +0000 (14:13 +0200)]
Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean.
Fixes race condition that was observed in ITs, where config pusher started pushing
empty configuration and immediately registered itself as notification listener of
a JMX bean that was not yet present. Fix waits both for netconf-impl and
config-netconf-connector services so that both dependencies are activated before
pushing of configuration can occur.
Change-Id: Id328dc3bd7e41bad59bb84b03461d89f5faeeea4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 15 Apr 2014 07:45:31 +0000 (07:45 +0000)]
Merge "BUG-459 Remove deprecated NetconfClient class."
Tony Tkacik [Tue, 15 Apr 2014 07:45:11 +0000 (07:45 +0000)]
Merge "BUG-372: Rework sal-netconf-connector"
Maros Marsalek [Mon, 3 Mar 2014 12:35:48 +0000 (13:35 +0100)]
BUG-459 Remove deprecated NetconfClient class.
NetconfClient moved to test sources, now will be used only by tests.
Change-Id: Ia98abe3f6fa4f05566b71d57c519c2149726bcb6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
jameshall03885 [Wed, 9 Apr 2014 14:30:03 +0000 (10:30 -0400)]
Bug 651 - Added back IDE profile and changed target for yang sources
- The IDE maven profile was added back based on feedback from Giovanni Meo
- To avoid devs from having to run the IDE profile so eclipse can see the yang
generated source files, the yang source files are now generated under src/main/yang-gen-sals
or src/main/yang-gen-config instead of target/target-ide.
- The maven-clean-plugin was moved to the commons base pom and removed from
all child poms where it was specified. Thus, it will be automatically run for all
projects. The plugin's execution will clean all xtend and yang generated source dirs.
- The build-helper-maven-plugin was also moved to the commons base pom and removed from
all child poms. It will automatically run for all projects and no longer needs to be
specified in child poms. The plugin's execution will created eclipse source folders
for all xtend and yang generated source.
Tom P and Devin A really did all this work, Greg just gets credit unfairly.
Conflicts:
opendaylight/config/config-module-archetype/src/main/resources/archetype-resources/pom.xml
Change-Id: I8d9e403629cab2e48d03d5c7a417a02f1d878ca7
Signed-off-by: tpantelis <tpanteli@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
Signed-off-by: dbavery <devin.avery@brocade.com>
Signed-off-by: jameshall03885 <ghall@brocade.com>
Milos Fabian [Mon, 14 Apr 2014 08:05:15 +0000 (10:05 +0200)]
Bug 714 - Fixed creating DOM Document's element with namespace
Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 11 Feb 2014 07:44:46 +0000 (08:44 +0100)]
BUG-372: Rework sal-netconf-connector
This makes the connector truly asynchronous and able to work with
backing datastore going away. It will retry connecting infintely to the
backed device, too.
Change-Id: I843620bf63eeade231698c22592aaec0521a09ad
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Sunal [Fri, 11 Apr 2014 10:54:51 +0000 (12:54 +0200)]
BUG 718: changed codec for URI parsing
Change-Id: Ida06cb8d662ada99d67b994049228c7844d9d41e
Signed-off-by: Martin Sunal <msunal@cisco.com>
Tony Tkacik [Wed, 9 Apr 2014 08:19:07 +0000 (08:19 +0000)]
Merge "BUG-704 Fix failing integration test in netconf-it"
Maros Marsalek [Wed, 9 Apr 2014 06:49:35 +0000 (08:49 +0200)]
BUG-704 Fix failing integration test in netconf-it
Ignore for now, proper fix will follow
Change-Id: Iee9bfc3bedf6daca7afd5d57ae37f758c1acd871
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 8 Apr 2014 11:53:15 +0000 (11:53 +0000)]
Merge "Resolve Bug:522"
Tony Tkacik [Tue, 8 Apr 2014 09:59:15 +0000 (09:59 +0000)]
Merge "Resolve Bug:623 : Generate private key using bouncycastle."
Tony Tkacik [Tue, 8 Apr 2014 09:44:35 +0000 (09:44 +0000)]
Merge "524 bug - %2F slashes translation behind mount point (unit test)"
Tony Tkacik [Tue, 8 Apr 2014 09:39:15 +0000 (09:39 +0000)]
Merge changes I6029bd48,Ie8eb4152
* changes:
BUG-672 Add includeExtensions property to Xml directory persister adapter.
BUG-672 Remove deprecated plaintext/autodetect persister adapters.
Tony Tkacik [Tue, 8 Apr 2014 09:38:45 +0000 (09:38 +0000)]
Merge "bug - missing excaping of % character in String.format() method"
Maros Marsalek [Mon, 7 Apr 2014 11:04:39 +0000 (13:04 +0200)]
BUG-672 Remove deprecated plaintext/autodetect persister adapters.
Xml adapters are the default adapters now for configuration persister.
Change-Id: Ie8eb41520671bb00503a340f6b4b55ebe1ef7bf1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tomas Olvecky [Mon, 7 Apr 2014 07:44:31 +0000 (09:44 +0200)]
Resolve Bug:623 : Generate private key using bouncycastle.
Add dependency on bouncycastle and use it to generate private key in PEM
format when key file is not present on the filesystem.
Change-Id: I07290e0f361151743a50559c26255eab23cababb
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Jozef Gloncak [Mon, 7 Apr 2014 06:27:19 +0000 (08:27 +0200)]
bug - missing excaping of % character in String.format() method
Change-Id: Ic44ff0cf558efbba9c465ac760da13fcf3add2cb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Fri, 4 Apr 2014 16:41:22 +0000 (16:41 +0000)]
Merge "Resolve Bug:654 - Fix config-persister exception handling."
Tomas Olvecky [Fri, 4 Apr 2014 10:29:19 +0000 (12:29 +0200)]
Resolve Bug:654 - Fix config-persister exception handling.
Modify NetconfUtil to fail on any <rpc-error>, not detecting transaction conflicts. Move
exception handling to ConfigPusher.
Also fix bug when config-netconf-connector detects discrepancy between yang store and
config manager factories: persister will retry as if some capabilities were not found.
Change-Id: Ibd80fd3859031ae41301481dad9b50f74207e64c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Jozef Gloncak [Wed, 2 Apr 2014 09:43:31 +0000 (11:43 +0200)]
524 bug - %2F slashes translation behind mount point (unit test)
New test getDataWithSlashesBehindMountPoint() tests whether URI identifier
which contains slashes encoded as %2F (e.g. in key part of URI) is translated to identifier with simple slash
characters (/).
It is checked whether InstanceIdentifier instance is created with simple
slashes. The instance is then used as input parameter of method
BrokerFacade.readOperationalDataBehindMountPoint() to get data from
datastore.
If %2F are correctly replaced with / test is succesful.
Change-Id: I131bda42fb568af23d6a1b0bbb72c505db8748e3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 31 Mar 2014 07:20:57 +0000 (07:20 +0000)]
Merge "Bug 564 - add missing sal-remote dependency."
Tony Tkacik [Fri, 28 Mar 2014 19:13:21 +0000 (19:13 +0000)]
Merge "Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP."
Robert Varga [Sun, 9 Mar 2014 13:57:41 +0000 (14:57 +0100)]
Bump netty.io to 4.0.17.Final
Change-Id: I0f8c3d6ec41561c9c85cba5f36119a0f1b635347
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Olvecky [Wed, 26 Mar 2014 09:11:26 +0000 (10:11 +0100)]
Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP.
Config persister now pushes configuration to netconf service directly by
java calls instead of using TCP connection to localhost. This allows
removing netconf client dependency from config-netconf-connector and
removes confusion when running more than one ODL process with same
configuration.
Change-Id: I96426b0fd1fe7110a59111a2b563e7494ebb811b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Milos Fabian [Tue, 25 Mar 2014 08:44:40 +0000 (09:44 +0100)]
Bug 564 - add missing sal-remote dependency.
Change-Id: Ic6968699f0214226dd9881d08684febeaf031525
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Tue, 25 Mar 2014 05:11:38 +0000 (05:11 +0000)]
Merge "Do not catch Throwables, but rather Exceptions"
Robert Varga [Fri, 14 Feb 2014 23:08:05 +0000 (00:08 +0100)]
Do not catch Throwables, but rather Exceptions
This turns catch Throwable into catch Exception, as doing the former
catches Errors, which are documented to be pretty much irrecoverable
conditions. Looking at
http://docs.oracle.com/javase/7/docs/api/java/lang/Error.html non of
these call sites can recover from an Error happening, so they should
never catch them.
Change-Id: I85237594f307a5a8778fb5a63f9dad4d120fc9d7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 18 Mar 2014 10:45:26 +0000 (10:45 +0000)]
Merge "Resolve Bug:448 - Remove yang-store api and impl."
Tomas Olvecky [Fri, 14 Mar 2014 12:09:48 +0000 (13:09 +0100)]
Resolve Bug:522
Change-Id: I458568c455df451a4a6a50f0fe90317c482d73a6
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tomas Olvecky [Mon, 10 Mar 2014 08:56:13 +0000 (09:56 +0100)]
Resolve Bug:448 - Remove yang-store api and impl.
Depends on yangtools commit https://git.opendaylight.org/gerrit/#/c/5579/ .
Instead of having multiple bundle trackers for config and netconf, keep only
one. Each bundle containing yang files should use sal code generator, which
generates YangModuleInfo objects. Using this instead of speculatively having
to parse all current yang files for each adding bundle event allows not having
to deal with broken yang dependencies when bundle events come in wrong order.
Put SchemaContextProvider to OSGi SR in config-manager, so that any bundle
working with yang can use it. This replaces too specific YangStoreService which
was coupled with yang-jmx-generator. Users can listen for changes directly
on OSGi SR - they receive service changed event when yang module is added or
removed.
Change-Id: Iabcb35929a1eeef0df328f3f948d70e1bfcbba0d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Wed, 12 Mar 2014 10:16:42 +0000 (10:16 +0000)]
Merge "Bug 453 - sal-rest-connector doesn't provide stream discovery feature"
Tony Tkacik [Tue, 11 Mar 2014 11:21:44 +0000 (11:21 +0000)]
Merge "Cleanup warnings in restconf-broker NotificationService"
Tony Tkacik [Tue, 11 Mar 2014 11:17:54 +0000 (11:17 +0000)]
Merge "Prune long-deprecated APIs"
Robert Varga [Fri, 28 Feb 2014 13:27:51 +0000 (14:27 +0100)]
Cleanup warnings in restconf-broker NotificationService
The registration map is not needed and the executor is not used, so
remove them. Also reuse AbstractListenerRegistration in place of a
custom-coded class.
Change-Id: Ia4060370faa03fb85d9a90471938501a583072d3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Feb 2014 12:42:05 +0000 (13:42 +0100)]
Prune long-deprecated APIs
Prune APIs which have been deprecated well before the Hydrogen release.
No outside users should be relying on them at this point.
Change-Id: I5b966c98733912ece175ce8fa5a4a821c3b2c6d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 9 Mar 2014 13:44:46 +0000 (14:44 +0100)]
Remove unused import and raw type references
Fixes a couple of warnings just by removing imports and adding <?> to
Iterator.
Change-Id: I71f9a1e0176a1a72fb402e972b1e39ac6c1bba0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Bobak [Mon, 3 Mar 2014 15:46:11 +0000 (16:46 +0100)]
Bug 453 - sal-rest-connector doesn't provide stream discovery feature
Change-Id: I01f21b5b27512f9a8a4babac9148eacf6e6ac36a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Tony Tkacik [Wed, 5 Mar 2014 09:25:41 +0000 (09:25 +0000)]
Merge "Remove duplicate netconf namespace constant"
Tony Tkacik [Wed, 5 Mar 2014 09:25:17 +0000 (09:25 +0000)]
Merge "Get rid of netconf operation filters"
Maros Marsalek [Tue, 4 Mar 2014 14:30:10 +0000 (15:30 +0100)]
Remove duplicate netconf namespace constant
Change-Id: I7af2cb2631136fb4ae947f7150ad2e5d8f2df567
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Tue, 4 Mar 2014 10:20:26 +0000 (11:20 +0100)]
Get rid of netconf operation filters
Merge NetconfOperationFilter interface into NetconfOperation
Execute all operations that can handle a certain request in chained execution (ordered by priority)
Reimplement all current filters as chained operations
Remove NetconfOperationRouter parameter from NetconfOperation
NetconfOperations handling the same request must have different priorities
Change-Id: Iab9c680e6eceab4059feb77616a9d006fb613711
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 3 Mar 2014 10:41:25 +0000 (10:41 +0000)]
Merge "Bug 383 - exception raised if key part of URI is incorrect"
Tony Tkacik [Mon, 3 Mar 2014 09:39:47 +0000 (09:39 +0000)]
Merge "Eradicate exificient from the repository"
Tony Tkacik [Mon, 3 Mar 2014 09:30:03 +0000 (09:30 +0000)]
Merge "Do not use currently-deprecated APIs"
Tony Tkacik [Mon, 3 Mar 2014 09:29:24 +0000 (09:29 +0000)]
Merge "Deprecate NetconfMessageHeader test class"
Tony Tkacik [Fri, 28 Feb 2014 14:03:52 +0000 (14:03 +0000)]
Merge "Cleanup dependencyManagement overrides"
Robert Varga [Fri, 28 Feb 2014 12:56:28 +0000 (13:56 +0100)]
Do not use currently-deprecated APIs
SchemaServiceListener has been renamed to SchemaContextListener
upstream, with the usual migration strategy. Let's use the latter where
possible.
Change-Id: Ic24596a424322d3bfbc0bca27a94cf281cde85e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Feb 2014 12:45:26 +0000 (13:45 +0100)]
Deprecate NetconfMessageHeader test class
This gets rid of the deprecation warnings, as the entire test will go
when NetconfMessageHeader goes.
Change-Id: Icfc90299d2a9227125671ed1ce0ef56632572f4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 1 Feb 2014 08:01:20 +0000 (09:01 +0100)]
Eradicate exificient from the repository
Change-Id: I08e05f72818c22b6a46aee02a00c539006006905
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 27 Feb 2014 16:06:03 +0000 (16:06 +0000)]
Merge "Exception for URI /restconf/operations/module_name:rpc ended with slash"
Robert Varga [Thu, 27 Feb 2014 12:19:48 +0000 (13:19 +0100)]
Cleanup dependencyManagement overrides
This patch gets rid of a few warnings coming from overriding version
specified in parent dependencyManagement section.
Change-Id: Ida9662498bd152cc91954dc1843045c0553164ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Fri, 14 Feb 2014 10:14:12 +0000 (11:14 +0100)]
Bug 383 - exception raised if key part of URI is incorrect
Null pointer exception was caused for case when it wasn't possible to
decode key part of URI (null value was returned)
For case when key leaf type was identityref and wasn't specified as
module_name:identity_name NullPointerException was raised.
Change-Id: I6343d98e6549c02906628c78f61f97c18b244fe4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 18:40:06 +0000 (18:40 +0000)]
Merge "Refactor configuration for ConfigPersister."
Tony Tkacik [Tue, 25 Feb 2014 18:13:31 +0000 (18:13 +0000)]
Merge "Prune long-deprecated APIs"
Robert Varga [Wed, 19 Feb 2014 10:44:06 +0000 (11:44 +0100)]
Prune long-deprecated APIs
These APIs are from prototype days and have never properly worked. Prune
them to reduce the baggage we carry around.
Change-Id: I9ac89552edf76f0740c660c100ec0426627b413a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 14:58:10 +0000 (14:58 +0000)]
Merge "Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator."
Tomas Olvecky [Tue, 25 Feb 2014 13:44:26 +0000 (14:44 +0100)]
Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator.
Do not just log exception if it occurs while calling getModuleInfo, but add it as nested exception.
Fix confignetconfconnector activator: if activator fails to find ConfigRegistry, stop method should interrupt searching for it.
Change-Id: I0b97e5a044be0fd2304b35d34f46a1c540aac248
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Integration test added to netconf-it to test identity (de)serialization."
Milos Fabian [Tue, 18 Feb 2014 09:44:24 +0000 (10:44 +0100)]
SalRemoteClientDeployer - instantiate SalRemoteClient for given URL.
SalRemoteClient:
-Creates schema context.
-Initialize mapping service
-Creates restconf client
-Starts sal remote service broker
-Provides consumer registaration
Change-Id: Idc0d8be4c088bac8a4df24b98e482184a6e54665
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 11:24:49 +0000 (11:24 +0000)]
Merge "Reuse AbstractListenerRegistration"
Robert Varga [Wed, 19 Feb 2014 02:54:03 +0000 (03:54 +0100)]
Reuse AbstractListenerRegistration
No sense in defining a new class -- just reuse what's already there.
Also uncovers the fact that we're losing an underlying registration --
but let's deal with that once the ListenerRegistration API changes not
to throw exceptions on close().
Change-Id: I5a12b1d7ca89f1608bc54b3f1a520223e650d53f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 11 Feb 2014 16:40:39 +0000 (17:40 +0100)]
Refactor configuration for ConfigPersister.
Pulled Configuration class from ConfigPusher that contains all the delays, timeouts and attempts numbers.
Add tests for config perister.
Change-Id: I187e721e0120931d0cca519353db840905816a20
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 24 Feb 2014 17:22:10 +0000 (17:22 +0000)]
Merge "Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT."
Jozef Gloncak [Tue, 18 Feb 2014 13:05:44 +0000 (14:05 +0100)]
Exception for URI /restconf/operations/module_name:rpc ended with slash
If URI of type /restconf/operations/module_name:rpc ends with slash
character (/) then exception with HTTP return code 404 and text
"Identifier IDENTIFIER_NAME can't contain slash character (/). If slash is
part of identifier name then use %2F placeholder."
Change-Id: Idbed90515280b414c10d28dc608faeee24986a29
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ladislav Borak [Fri, 21 Feb 2014 12:19:50 +0000 (13:19 +0100)]
Added documentation into web socket in RestConf
Change-Id: I36fae4c8916c6d25a1b9619390467e48b64e8a3d
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Maros Marsalek [Tue, 11 Feb 2014 15:36:32 +0000 (16:36 +0100)]
Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT.
Change ConflictingVersionException and ValidationException to be checked instead of
runtime exceptions.
Fix ConfigPusher's ConflictVersionException handling that was introduced when IOException was
used to wrap RuntimeException.
Small fixes in netconf, more refactoring of exception handling will be needed there.
Maros Marsalek: Rebase commit + fix compliation issue in ShutdownTest
Change-Id: Iab89de6ef6ced0de0a267470f860912ae3c56892
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 21 Feb 2014 10:48:44 +0000 (11:48 +0100)]
Integration test added to netconf-it to test identity (de)serialization.
Change-Id: I637011107edea916aaab35e8d2298bbbbabed653
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 21 Feb 2014 10:44:16 +0000 (10:44 +0000)]
Merge "Fix message aggregator for chunked netconf messages."
Maros Marsalek [Thu, 20 Feb 2014 12:19:03 +0000 (13:19 +0100)]
Fix message aggregator for chunked netconf messages.
Aggregator did not work with 1 message in multiple chunks.
Change-Id: I03cc89c3fc56a52f077fd21f77bd98e47ea358a9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Tue, 18 Feb 2014 11:58:47 +0000 (12:58 +0100)]
Make use of new sendMessage method in AbstractNegotiator
Change-Id: Ieeb104aa34b8140936a1daf8011ba3b0effc79d5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>