Example of adding parameters with config subsystem.

Change-Id: Idae0fcb0960345444a55bbd2b5013439493f53e9
Signed-off-by: Ed Warnicke <hagbard@gmail.com>

Merge "Adding neutron-ovsdb."

Merge "Use StringBuilder instead of StringBuffer"

Adding neutron-ovsdb.

This adds a new listener for OVSDB southbound changes,
and uses that state to update state in the endpoint
registry, as well as create tunnel ports, if absent.

Change-Id: I0f5b09c684e10e77ab7845399f903f55e60ceba6
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Change Tunnel type in ChainAction

Change-Id: I2a61d4c7614f7fe1813a5f3ea94db09396de2000
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Use StringBuilder instead of StringBuffer

StringBuffer is overly synchronized, use a StringBuilder instead.

Change-Id: Ifb18d3ebb2ae464f5e634aaee8c7d969a98256de
Signed-off-by: Robert Varga <rovarga@cisco.com>

GBP UI initial commit

added GBP UI dlux module
added groupbasedpolicy-ui feature and bundle

Change-Id: I0ee3cb740d6a2164122a66eb6f4e04f61071e563
Signed-off-by: Juraj Sebin <jsebin@cisco.com>

Implement SFC integration

- Query based on Chainname
- Validate Chain before moving from CONF to OPER
- Added ChainAction
- Added things in SwitchManager/EndpointManager to modify READY state so we don't write flows to switches
  with no endpoints

Change-Id: I84d2549a444f10ddabed146f857af38d0e6369c0
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Getters and setters for boolean

Change-Id: Id5833518ca860f49de0243bc58c866cc1f6fcee5
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug fix for new mapping table.

The new mapping table needs to have the parent
nodes created.  This adds the true flag to cause
that to happen in the puts to the data store.

Change-Id: I2fe7477bc9c93d74a36c81213a1b3fac44636f6e
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Fix of NPEs and attempt to fix Neutron mapper.

- Added utilities to only put Switch in READY when Endpoints attached.

- Also removes switch from ready when last EP is removed.
  This means we don't write and handle all OF switches connected to
  controller unless an EP is present. It means we play better with others.

Change-Id: I3b3e66259e2e43a201d298dd8af523cc5a3cf426
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Implementation of INeutronFloatingIPAware introduced"

Merge "Fixed missing tunnel type"

Implementation of INeutronFloatingIPAware introduced

Tenant NPE temp fix - REMOVE BEFORE PUBLISH
identification of router-gateway

Change-Id: Ibc84fcee36f7604fc0794f456bf153f21e52c56e
Signed-off-by: Martin Sunal <msunal@cisco.com>

Added neutron port to endpoint mapping and vice versa

Signed-off-by: Martin Sunal <msunal@cisco.com>

Fixed missing tunnel type

Change-Id: I23d5b1cad48f132f632da4e5b038953f0b9e0d32
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Moved assignment of TunID to SourceMapper"

Fix javadoc JDK8 compatibility

JDK8 is more picky about javadoc format, so fix them up to pass
compilation with JDK8.

Change-Id: Ib79d332135f4a29f98a1461a17ab86118d1a2678
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Removed calling of NeutronRouterAware API from NeutronPortAware"

Merge changes I8490a721,I71941875

* changes:
  Bug 3166 ui-backend introduced
  Moved util methods from PolicyResolver

Removed calling of NeutronRouterAware API from NeutronPortAware

Devstack added support of sending notification about CUD of router interface.
So hack in NeutronPortAware is not needed anymore.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3166 ui-backend introduced

This is a backend based on RESTCONF.
Purpose of the backend is to provide data which has to be calculated by difficult processing
i.e. it reuses policy resolution process from groupbasedpolicy module.
UI can call RPCs on this backend.

Backend provides these RPCs:
 - get-endpoints-from-endpoint-group: Returns endpoints which are
        in the given endpoint group.
 - get-subjects-between-endpoint-groups: Returns subjects between
        endpoint group pairs where endpoint groups are from the given tenant.

Change-Id: I8490a7217c5725ccdfc6dda3467d3ba91c76eeb9
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Revert "Revert "Added feature dependency on odl-ovsdb-southbound-impl"""

Revert "Revert "Added feature dependency on odl-ovsdb-southbound-impl""

This reverts commit 8fd49cd72a4319e0cb4ceacbf6f77d2e820cfaa0.

Change-Id: Ica226425eeae14d952be136fb8eb6e2151bdc90b
Signed-off-by: Keith Burns <alagalah@gmail.com>

Moved util methods from PolicyResolver

Most of methods in PolicyResolver are util mehtods
so these methods are moved to new *ResolverUtils classes.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Moved assignment of TunID to SourceMapper

- TunID determined by SourceEP ordinals
- Removes need for matching on Source generated reg values in DestinationMapper
- Incredibly useful for SFC when EPs are both on same node.

Change-Id: I6598f7b10edbe4624694e884f760cfb894ca31ad
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Fixed main issues of SwitchManager"

Fixed main issues of SwitchManager

SwitchManager is feeded from listeners
    FlowCapableNodeListener - FlowCapableNode from OPER DS on BASE scope of OF augmentation
    OfOverlayNodeListener - OfOverlayNodeConfig from CONF DS on BASE scope of OF overlay augmentation
    FlowCapableNodeConnectorListener - FlowCapableNodeConnector from OPER DS on BASE scope of OF augmentation

SwitchState is composed based on listeners' data:
    FlowCapableNode, OfOverlayNodeConfig, and FlowCapableNodeConnector-s
SwitchManager keeps track of SwitcheState-s in Map.

SwitchState can have 3 types of status:
  DISCONNECTED - SwitchState does not contain FlowCapableNode.
  PREPARING - SwitchState contains FlowCapableNode but information about tunnel(tunnelPort, tunnelIp) is missing
  READY - SwitchState contains FlowCapableNode, tunnelPort and tunnelIp

Even status of SwitchState is DISCONNECTED the SwitchManager still keeps track
until SwitchState contains configuration. This is because FlowCapableNode can disappear from OPER DS but
additional OfOverlayNodeConfig data are still in CONF DS.
Without this tracking we would loose OfOverlayNodeConfig data when SwitchState had been removed.

Change-Id: I7781fdfb0e306568587a1c69c2ab9f90e205180d
Signed-off-by: Martin Sunal <msunal@cisco.com>

Removed "reverse" from policy resolution process

Reversed EPG roles(cons/prov) based on ID complicates debugging.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Revert "Added feature dependency on odl-ovsdb-southbound-impl"

This reverts commit aa03a46446c4f267fc8f88f109cae13b864b30bb.

Change-Id: I38200796d8f01ea18528f95e4b12f7f839eb983d
Signed-off-by: Keith Burns <alagalah@gmail.com>

Merge "Fixed EIC grouping"

Merge "Revert "Create the tunnel port in OVSDB, and connect.""

Revert "Create the tunnel port in OVSDB, and connect."

This reverts commit 967912af4cdcf89df665579708af27c51c808d9b.

Change-Id: I98ede9979ca8b0ce6eab26439ea9c649d975a714
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Fixed EIC grouping

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Removing legacy distribution."

Create the tunnel port in OVSDB, and connect.

This patch creates a tunnel port for ofoverlay, and
optionally connects it to the controller (set by member
in the class).

Change-Id: Iac2f099cbe3521c8b9d53bf55752264543e4e22d
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Added feature dependency on odl-ovsdb-southbound-impl

Change-Id: I955a6695d98432855fc008145ddc4bc822fd4d26
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Removing legacy distribution.

This removes the (legacy) distribution build from
the repo, as it is no longer used and/or needed.

Change-Id: Id1481e6c90b8eebbaef5022c4dac26be8614aa17
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Set odlparent, clean-up of pom.xml-s

Change-Id: I76ba8a551755ca30347fba59750ec0d7d02a1dad
Signed-off-by: Martin Sunal <msunal@cisco.com>

Backed out SFC Manager.

SFC Manager is removed -- will be replaced by
a subsequent patch.

Change-Id: Ifaba8e77eac8da7428ec959cf02b69fa4d5f9471
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Move JSON-RPC lib to OpFlex."

Move JSON-RPC lib to OpFlex.

The JSON-RPC library is only used by the OpFlex
renderer. This patch moves the library under that
renderer for now (can be moved to a more general
place if it's needed by more than one renderer).

Change-Id: Icbefa208b63b0a36967f0834d7e7fbcf14bd4ac2
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Fix order of base feature loading.

The order of the features in the features.xml file is
important -- this patch fixes the order so that the
ofoverlay feature comes up correctly.

Change-Id: Idf7c5e9ce7c026a67f7dd3c913f35abcea979119
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Fixes for FlowTable in OFOverlay

- Added tunnel ordinal, removed VNID->sEPG
- Fixed FDID tunnels
- Remapped DestMapper to set above VNID
- Fixed bug in SourceMapper (object identity vs equality test)
- Assured that only BD-BD communication allowed for L2 Flows
- Set foundation for fixing conditions and implementing distributed
policy enforcement.
- NeutronMapper: set DHCP EPG to IGP Deny

Change-Id: Ic66e56b25700cea6a68815b86175e7909482dab9
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Routing fix in preparation for routing table support."

Merge "Parameter of classifiers changed in POC"

Routing fix in preparation for routing table support.

Need to refactor to ensure that local routing occurs with source subnet gateway,
as well as final destination MAC.

Change-Id: I1dc25728b2750eb273bf31a08401759b931fa952
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Additional Enhancements to the Endpoint RPC Registration
1- Allowed RPC registration to have its own dedicated thread pool since
   its shared among multiple renderers.
2- Made renderers only return their augmentations to RPC registration
   without being involved in building endpoints (which only handled by
   the RPC registry itself).

Change-Id: I5075404f2137ee5cb6df5bd5479dd8138ee4bb5c
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Fixing concurrent access errors.

Change-Id: I3e7ba5760d396a646ab37e1e832f6ef2435779ba
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Distributed multi-virtual-router functionality.

- allows specification of gateway ports
- correct MAC rewrite based on src gw/dst gw
- multiple isolated router support
- multi-tenant support.

Change-Id: Ifad952a26cdf97eb13b60d2ea80ebae28fdecda5
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Enable neutron mapper

Change-Id: Idc06e58acc3cbeafa467c6a46edae495c2217448
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Added support of multiple routers from neutron

Limitation - you cannot create more than one router interface in the same subnet

Change-Id: I3ef30eb340a67ae3907669c05aa04c748dbe8fed
Signed-off-by: Martin Sunal <msunal@cisco.com>

Registration of NeutronRouterAware in neutron-mapper

Signed-off-by: Martin Sunal <msunal@cisco.com>

Updated references to latest  karaf versions.""

This reverts commit a49d6d0260c19292f525347d8f421b7738b5064a.

Change-Id: Iee5259a1a93cded3602ae2fc28c27bee5f6075b0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Revert "Updated references to latest  karaf versions."

This reverts commit c7e7ce1e5a1ee1112f44851aeb2da5262123e765.

Change-Id: I4d95b108f723127c3b3730b0fb6f0fa3f79b52c0
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Updated references to latest  karaf versions.

karaf.version is inherited from odlparent.

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Add SFC features to the GBP distribution.

This adds the SFC features to the GBP distribution build.

Change-Id: I7e0ab08dd288baf5bd01357419329b62500586e7
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Parameter of classifiers changed in POC

parameter 'type' of string value changed to parameter 'proto' of int
value.

Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Empty string checking for subnet name

Empty string is not valid value for subnet name.

Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Add ARP flow to Policy Enforcer.

This adds ARP flows to the policy enforcer, which
allows packets to EPs in the same Flood Domain.

Change-Id: Ie27b856b2e1ef61d6ff00d8b9029902e93d2e13a
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Introduced neutron-mapper

- dependecy on ODL neutron-northbound service
- Mapping between neutron and GBP entities:
  - neutron network to gbp l2-flood-domain mapping
    l2-bridge-domain is generated as a parent of l2-flood-domain
    l3-context is generated as a parent of l2-bridge-domain
  - neutron subnet to gbp subnet mapping
    l2-flood domain is set as a parent of subnet
  - neutron port to gbp endpoint mapping
    endpoint is registered
    endpoint-l3 is registered if a port contains fixed-ips
  - neutron security group with security group rules to endpoint group pairs with contract

Change-Id: I1fea5cb67ebd7d080cf244ecc2b1da5072efd181
Signed-off-by: Martin Sunal <msunal@cisco.com>

Added checking at DestinationMapper

createRouterArpFlow in DestinationMaper is checked for null value.

Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Add WARN messages when no tunnels configured.

This adds checks and warnings when the IP address
and/or tunnel port can't be found when constructing
flow-mods.

Change-Id: I6e137e43801169511babf0f1a42e595493bd8692
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Minimize flow-programming."

Minimize flow-programming.

This patch changes the flow programming to perform
deletions and additions to the flow table, rather
than doing a wholesale update of the flow table.

Change-Id: I81e584b4415900b9e1bd1b6a04fe3aecc9f12c49
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 2814 - logical OR behavior of classification within a rule.

Implemented matching against all the classifiers within a rule.

Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Publishing of ofoverlay augmentations, fixed port-name augmentation bug

Signed-off-by: Martin Sunal <msunal@cisco.com>

Fix for missing flow-mods for L3 context changes.

This is a workaround for making sure that all the
flow-mods are on the vSwitch.

Change-Id: I54b9303568ba766431f015fba8562919f4f772f5
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Bug#2977 EndpointManager maps are not threadsafe"

Merge "Added check for tunPort existance and made non-null precondition for adding a flow to FlowMap."

Added check for tunPort existance and made non-null precondition for adding a flow to FlowMap.

Change-Id: Id0c9de5195efab5687cef7e4ea7bdfca54c6021a
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug#2977 EndpointManager maps are not threadsafe

Change-Id: I0a05ff95e7fc2e51ad64fcd3ac425d9119a0fe29
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fixing mistake of having port-name in base and not augmentation.

In lieu of NB API consume augmentations

Change-Id: I9f3d390cdc413ccef8e2e28b46cb66bcc1af10a5
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Adding odl-groupbasedpolicy-base to feature dependency.

Change-Id: I5be694ba13735c52e08fd5db16ed13eae68a2a80
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Removing OpenContrail renderer from the build."

Adding multiple EPG capability to EPs and IntraEPG policy

Change-Id: I00ed21b0765912c689c57c72c1b4463544bf1a73
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Removing OpenContrail renderer from the build.

Refer following email:
https://lists.opendaylight.org/pipermail/groupbasedpolicy-dev/2015-April/001054.html

Change-Id: I8d308ec277d9531c148942c9c388d3fe5a533686
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Cleaned formatting (per ODL standards) and whitespace."

Exported package for classifier-definitions and action-definitions

This allows to use classes from this package in other bundles.
Added javadoc comments. Corrected visibility of class members on API.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Add <relativePath/> to ensure Maven pulls artifact from Nexus"

Make members immutable where possible.
Cleanup code slightly and make Sonar a little happier.

These changes are related to Bug 2196

Change-Id: I5c52831c23dfbe72f21a2e8b4a467386eb1a29e7
Signed-off-by: Tom Flynn <tom.flynn@gmail.com>

Merge "Classifiers - implementation changes. This commit solves bug 2883."

Classifiers - implementation changes.
This commit solves bug 2883.

Change-Id: I1b5b886734833bd30129c71be78eb3a5af4387a8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Cleaned formatting (per ODL standards) and whitespace.

See https://git.opendaylight.org/gerrit/#/c/17575/ for
eclipse-java-clean-code-style.xml.

Only did this for files associated with https://git.opendaylight.org/gerrit/#/c/17391/

Change-Id: I430c5ef0a409bc6dc8b59c966ffd9e6ca6e57873
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Modified model to support L3Prefix EP, GIC, EIC, ECC and EIG"

Modified model to support L3Prefix EP, GIC, EIC, ECC and EIG

policy.yang:
Added GroupIdentificationConstraints:
- added role "any" for matcher
- added case GroupNameConstraint
- added case for provider|consumer matcher
Added EndpointIdentificationConstraints
- added l3-prefix ip-prefix type constraint
Added ExternalImplicitGroup

endpoint.yang:
Added L3-prefix list.

Other files refactored.

Change-Id: I572d0208ca88f7182a33e41f4ddedcd46ec3015d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Add <relativePath/> to ensure Maven pulls artifact from Nexus

Needed by autorelease to be able to find and replace this value
prebuild.

Change-Id: I39ee4f08f607d4a9381f972501abbed9416015b4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Added java code formatter and formatting of opflex java files

Java formatter is added groupbasedpolicy/commons/cleanCode/eclipse-java-clean-code-style.xml
Contributors should use this java formatter. It ensures the same look and feel of a code over GBP project.
Java files in opflex renderer have been formatted by this formater.

How to set formatter in Eclipse:
Window -> Preferences
          -> Java
             -> Code Style
                -> Formmater: Import...(eclipse-java-clean-code-style.xml)

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Move utility function to common place."

remove printStackTrace calls from EndpointManager.java and OpenstackGbpEndpoint.java and replace with error logging.

Change-Id: Ieed6f892cd75b064610ba53bf6b00764fecdfe92
Signed-off-by: Tony Klink <tony.klink@intel.com>

Merge "Marked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready for TODO sprint."

Scope change for OfTable.

The OfTable class provides protected acces to OpenFlow Overlay
renderer classes for the Flow Tables (e.g. SourceMapper,
DestinationMapper, et. al.). This limits access to just
the Flow Table classes themselves. This patch moves that
to a separate class with private members and public getters
so that the state can be accessed by any class that has the
new object (e.g. Action classes will use this in future patches).

Change-Id: I21aefa959c97453cdfa8f7f5b668f468dfd7aa5d
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Move utility function to common place.

The utility function is helpful byeond just the flow
table use cases.

Change-Id: If1578fe6dd680b956d1be5bb6609987cdbaff2ad
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Implementing portrange in L4Classifier.

Renaming createUdpMatches and createTcpMatches arguments.

Change-Id: I386283e833a2b4986057563f8b7db6a9ed4f2347
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Revert "Implementation of IP address classifier. Functionality is blocked by bug 2866."

This reverts commit d62684b701f0a0e94861bb889680979705350c8c.

Change-Id: I1cf3e0654fc3520d129383de8e85a41934664f02
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Marked OpenstackGBP API Deprecated, cleaned up minor todos at same time, ready
for TODO sprint.

Change-Id: Ic87fc3d6146464cc4cfde3ba470a45f2cd83f5b3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Implementation of IP address classifier.
Functionality is blocked by bug 2866.

Change-Id: Iec272e5422c9f4002064c04446f2ec1cd99752e9
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Added support for multiple Actions."

Added support for multiple Actions.

This patch adds support for using multiple actions
in the OpenFlow Overlay renderer.

Change-Id: I07e8e80a9012db378e765478751d175cae29a82b
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Shared Endpoint RPC for multiple render

This patch allows multiple renderers to share Endpoints RPC registration.
This is needed to allow multiple renderers to run together, allowing them
to access Endpoints store concurrently. The solution idea is to have
endpoint RPC registration as singleton. Each renderer then needs to
supply this singleton object with its Endpoint specific augmentation.
Upon endpoint registration RPC call, the singleton then loops over all
renderers to build all augmentations.

Change-Id: I0fe8bee6d8e92ffd2c3268009336da587cb497fc
Co-Authored-By: Khal Al-Zoubi <khalalzoubi@gmail.com>
Co-Authored-By: Yapeng Wu <yapengwu@gmail.com>
Signed-off-by: Yapeng Wu <yapengwu@gmail.com>