Stephen Kitt [Thu, 14 Feb 2019 14:34:12 +0000 (15:34 +0100)]
Switch to JDT annotations for Nullable and NonNull
This reduces our dependency on JSR-305 which causes a number of issues
(e.g. with javax.annotation resolution in OSGi bundles).
Annotations on local variables are removed because they trigger a
Javac bug which crashes ASM and then FindBugs, SpotBugs and JaCoCo.
Change-Id: I8c7736fe57e1e953dfa8e7dcf46d89d2166c892e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 17 Sep 2018 13:24:11 +0000 (15:24 +0200)]
MdsalApiManager cleanup - neutronvpn
This removes all calls to deprecated methods in MdsalManager, so that
they can be removed in the near future.
Change-Id: Ifb524445efc0bc324e7ea42fb404acedae98f5da
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 20 Mar 2019 16:31:19 +0000 (17:31 +0100)]
fibmanager dead code removal
This patch removes unused methods, classes and fields.
Change-Id: I03e98891e0a0a5be6a88c2132c97935aeb31f4bc
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 20 Mar 2019 16:30:44 +0000 (17:30 +0100)]
dhcpservice dead code removal
This patch removes unused methods, classes and fields.
Change-Id: I732e7c93f760fb66006e60a0a50b08eabc4c9457
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 19 Mar 2019 08:35:57 +0000 (09:35 +0100)]
elanmanager dead code removal
This patch removes unused methods, classes and fields.
Change-Id: Ia14e3ff0a304ca9c9db16562c1c766f07f98b9f2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 21 Mar 2019 15:00:22 +0000 (16:00 +0100)]
Avoid comparing objects using ==
A number of BigInteger instances are compared using == or !=; this
patch uses .equals() or variants thereof instead.
Change-Id: I3ac654b0dd5d255304bca93d6fbc4cdbfec05514
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Loshmitha [Fri, 15 Feb 2019 11:19:32 +0000 (16:49 +0530)]
BGP function calls logging
The logs have been added for the bgp calls with timestamp
JIRA: NETVIRT-1564
Change-Id: I4f7c253c2df2e1e20a2a031b563ede37495ac094
Signed-off-by: Loshmitha <loshmitha@ericsson.com>
Faseela K [Mon, 18 Feb 2019 05:14:04 +0000 (10:44 +0530)]
Migrate to serviceutils upgrade
JIRA: GENIUS-190
Change-Id: If9057f7b57a175054cec7e4e83c2723b588c97ca
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Wed, 13 Feb 2019 15:36:38 +0000 (16:36 +0100)]
Upgrade to PowerMock 2
This fixes the build in Java 11. A number of ignored tests are removed
in the process.
Change-Id: If6b8f42aeb8d42631df16bd3d22953720e0cc05d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 30 Jan 2019 09:41:14 +0000 (10:41 +0100)]
Add missing annotation dependencies for Java 11
... and drop an extraneous CORBA import!
Change-Id: I9062d07f9b9af3eb35c99bb0c4697b8e6fac33eb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
shaik [Mon, 11 Feb 2019 10:37:26 +0000 (16:07 +0530)]
Master build failing - dependency missing in pom
Description: master build failing at natservice, looks like
dependecy is missing in natservice/impl pom.xml
JIRA: NETVIRT-1562
Solution : added the missing dependencies, build is passing
with this change
Change-Id: I7e98f3e230edc5cd47a0dec47b274f5468154b9e
Signed-off-by: shaik <shaik.b@altencalsoftlabs.com>
Faseela K [Fri, 1 Feb 2019 10:20:51 +0000 (15:50 +0530)]
L3 handling for COE services.
Current implementation of services is handled
via ELAN pipeline, which is not an efficient solution.
The proposal here makes each service IP an extraroute
on the service-gateway port.
Change-Id: I3f8d022124e118cf08eb13ccac19185f81a6736e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
jenkins-releng [Fri, 1 Feb 2019 13:06:30 +0000 (13:06 +0000)]
Bump versions by x.y.(z+1)
Change-Id: I05b0ce7157565941ee715e9f34ddc61d5a0edc5e
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Somashekar Byrappa [Mon, 14 Jan 2019 09:38:49 +0000 (15:08 +0530)]
Select groups without any buckets for remote MIPs
Issue-1:
--------
Inconsistency observed in table-21 flows. For remote IPv4/IPv6 MIPs,
traffic for fixed IPs are sent directly to table-220. But
traffic for remote learnt/MIPs are sent to groups.
Issue-2:
--------
Sporadic issue wherein when MIPs are learnt, perform delete and add
Transport zone (ITM). The corresponding groups referred in table-21
flows for remote MIPs have Select Groups without any buckets in one
of the DPN.
Solution for both 1 and 2:
--------------------------
+ Remote learnt/MIPs were treated as extra routes, hence were sent to
load-balancing groups (Select). With this fix now, even for remote
learnt/MIPs, traffic is directly sent to table-220 from table-21.
+ Refactored code to minimize datastore reads.
JIRA: NETVIRT-1553
Change-Id: Idb71cc6e5e2ce3eb812e36e51a0987a204d778dc
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Shashidhar Raja [Tue, 29 Jan 2019 07:48:55 +0000 (13:18 +0530)]
Update broadcast rules for subnet addtion/deletion
Change-Id: I2e2deb51683ca95446677ff9490ab1f605b400cb
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Stephen Kitt [Wed, 30 Jan 2019 14:17:53 +0000 (15:17 +0100)]
Mark BluePrint annotations optional
Change-Id: Ia1cccc840679b821163bceb995212786bc25056b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 30 Jan 2019 11:03:25 +0000 (12:03 +0100)]
Adjust to the ovsdb MdsalUtils change
ovsdb’s MdsalUtils switched to the mdsal DataBroker, to continue using
the controller DataBroker we need to switch to ControllerMdsalUtils.
Change-Id: If644b85d4bb1af8194b9143196050e1c194798c9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vyshakh Krishnan CH [Tue, 29 Jan 2019 06:24:14 +0000 (11:54 +0530)]
create vpninstance for kubernetes cluster bring up
JIRA: NETVIRT-1556
create vpn instance with auto allocated RD while cluster bring up
Change-Id: I5fce5abdfbca8dc07fb322a8c8ad97c71f415b9e
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Stephen Kitt [Tue, 29 Jan 2019 15:05:36 +0000 (16:05 +0100)]
Duplicate list in resolveAdjacency
BaseVrfEntryHandler::resolveAdjacency sorts the list of route paths,
so we need to ensure that the list is modifiable. This patch does so
by creating a new ArrayList with the list of route paths.
Change-Id: I8612d94e3061f4f3f18a07ebb8e18d954de1cb65
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:22 +0000 (09:53 +0100)]
elanmanager: drop nullToEmpty and reqNonNullOrElse
Change-Id: Ibef665d4f6701219282a4b30533b03a72b376d05
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:23 +0000 (09:53 +0100)]
fibmanager: drop nullToEmpty and reqNonNullOrElse
Change-Id: I00072529caa24f6a1c75507b5fdd2d71e6eb461e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:23 +0000 (09:53 +0100)]
natservice: drop nullToEmpty and reqNonNullOrElse
Change-Id: Ie2cce99b07dd4ad5ed5b25450838ae6e9d89bdb0
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:23 +0000 (09:53 +0100)]
ipv6service: drop nullToEmpty and reqNonNullOrElse
Change-Id: I7796fd461a13f76a62320586fcb194bcc314dbb6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
kiranvasudeva [Thu, 27 Dec 2018 15:01:31 +0000 (20:31 +0530)]
NETVIRT-1545: MDSAL transactions optimizations
MDSAL transactions optimizations for Aclservice.
1. Security-Group is created as part of first SG rule creation, which
might lead to tx.merge, could cause delayed transactions.
2. Aclservice uses syncWrite and syncUpdate in neutronvpn module, which
could cause delayed transactions.
fix:
1. Added SecurityGroup Listener, which would create SG/Access-lists,
hopefully before SG rule. There-by tx would not get delayed.
2. Replace sync calls with Async using JobCoordinator.
Change-Id: I01318ea3ae1edcd5e25ad7aaf2a80b532777a028
Signed-off-by: kiranvasudeva <kirankumar.v@altencalsoftlabs.com>
Karthikeyan Krishnan [Mon, 28 Jan 2019 06:24:51 +0000 (11:54 +0530)]
Dual Stack feature support for router interface
This is second patch to support dual stack
router interface
We create a dual-stack neutron port and attach this
port to the router.
This single neutron port is then responsible for
handling both IPv4 and IPv6 subnets in that network.
The advantage of this approach is that it reduces
the number of Neutron router ports.
Issue: NETVIRT-1543
Change-Id: Iabd96ec2ad60ee8e5a3078f25304c175117830d0
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Faseela K [Fri, 14 Dec 2018 09:37:01 +0000 (15:07 +0530)]
COE: elan-interface creation exception
JIRA: NETVIRT-1533
Change-Id: Ieb8e914a950c39b9e436ba2a6c744a9329c4bfb5
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:22 +0000 (09:53 +0100)]
dhcpservice: drop nullToEmpty and reqNonNullOrElse
Change-Id: I5c303e30f697ffeff0759a93c943bb5264114cf9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:24 +0000 (09:53 +0100)]
vpnmanager: drop nullToEmpty and reqNonNullOrElse
Change-Id: I411e862b386ed14d759a2ab7cff089ce8f16a64f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Shashidhar Raja [Fri, 25 Jan 2019 14:18:46 +0000 (19:48 +0530)]
Merge SubnetInfo in AclInterface
Change-Id: I8d2960605b84c3d53eed3d327730931a2995301a
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:24 +0000 (09:53 +0100)]
qosservice: drop nullToEmpty and reqNonNullOrElse
Change-Id: I65eb7a162a2d8cdcc16654945259e111bc4c7c1f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:23 +0000 (09:53 +0100)]
neutronvpn: drop nullToEmpty and reqNonNullOrElse
Change-Id: I99c05dfaca1012e87fcdd03e6c5db4e8c44b0674
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:53:24 +0000 (09:53 +0100)]
sfc: drop nullToEmpty and requireNonNullOrElse
Change-Id: I1256c7df73351d8d93f5ee73c20dd9c319859026
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 25 Jan 2019 08:49:12 +0000 (09:49 +0100)]
aclservice: drop nullToEmpty and reqNonNullOrElse
Change-Id: Ie843944d23f8ebb5b8be09852ac43a503afb97b3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Sun, 18 Nov 2018 19:26:29 +0000 (20:26 +0100)]
Use LabelRouteInfoKey for locking label list
Once concentrated into a single call site, it is obvious that
call callers are immediatelly creating LabelRouteInfoKey, hence
use that Identifiable to name our locks.
Change-Id: I638992b1f2b4d070c33021560064dcf4b2b0ccb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Kumar Gujele [Fri, 23 Nov 2018 03:50:11 +0000 (09:20 +0530)]
NETVIRT-1519: MIP entry duplicated in FIB
Issue:
VRRP is configured for MIP-IP on two VMs. After cluster reboot,
VRRP-standby VM becomes a master for fraction of second and triggers
many GARP request for MIP-IP to controller. In controller ARP
NotificationHandler , when GARP is received , still learntVpnIpToPort
is not populated.Hence new adjacency gets added onto secondary VM's
VpnInterface without deleting the adj on original master VM's
VpnInterface. When cluster reboot completes , Arp Responses are
received from original master VM. But LearntVpnIpToPort has MIP-IP
with secondary VM portname. Now MIP-IP is removed from secondary
VM's VpnInterface Adj and FIB is also updated. Route pointing to
nexthop as secondary VM is withdrawn from DC-GW. Finally traffic
starts dropping.
Fixes:
To know who held the MIP-IP before cluster reboot, its decided to
persist the MIP-IP info. Hence VpnIpToPort config datastore is chosen
to store the info. After cluster reboot, when flood of GARP is
received, it will be checked if already an entry is present in
VpnIpToPort. If present and GARP is from different VM Interface,
oldPort entry is removed.
During cluster reboot, due to an ELAN bug in its pipelines, both the
Master and Slave VRRP VNFs go into Split brain and both of them own
the same MIP and respond to ARP requests as though they are both
legitimate owners. In order for this to not cause any damage to
L3VPN MIP FIB entry, we have introduced a quiescent ("quiet period")
of 300 seconds i.e., 5 minutes
within the ARP NotificationHandler as soon as its Constructed.
During this quiescent period, we will not be permitting re-learning of
any existing MIPs. This quiescent period for each existing MIPs (ie.,
MIPs that were learnt before reboot) is to resolve their split brain
issues and thereby settle down between themselves to one Master.
After the quiescent period is over, we allow re-learning of all these
existing MIPs.
Please note that the quiescent period is applicable for
only existing MIPs (that were prior to cluster reboot/cluster upgrade)
and so the period is not applicable for learning new MIPs. New MIPs
can be learned instantly after the cluster reboot completes.
We have introduced boot-delay-arp-learning parameter in the VpnConfig
for use by the controller orchestrator. The boot-delay-arp-learning
parameter controls for how much time after bootup, should the
arp-learning be made quiescent in seconds.
Change-Id: I2985480050cb0b8ee8434cced0074abb7a05a5cd
Signed-off-by: Anil Kumar Gujele <anilkumar.g@altencalsoftlabs.com>
Karthikeyan Krishnan [Mon, 31 Dec 2018 08:19:34 +0000 (13:49 +0530)]
Dual Stack feature support for router interface
We create a dual-stack neutron port and attach this
port to the router.
This single neutron port is then responsible for
handling both IPv4 and IPv6 subnets in that network.
The advantage of this approach is that it reduces
the number of Neutron router ports.
Issue: NETVIRT-1543
Change-Id: I043cd7683a8dc434f5d61886101915dfc01727c7
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Robert Varga [Sun, 18 Nov 2018 19:15:14 +0000 (20:15 +0100)]
Use JvmGlobalLocks in fibmanager
JvmGlobalLocks is giving us all we need to replace String.intern(),
user that.
JIRA: NETVIRT-1510
Change-Id: I50df601bb6c50cbcca72d2741cbbe66938ef5551
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 18 Nov 2018 18:54:19 +0000 (19:54 +0100)]
Use JvmGlobalLocks in natservice
JvmGlobalLocks is giving us all we need to replace String.intern(),
user that.
JIRA: NETVIRT-1510
Change-Id: I3ff5813add320377ecccad75f6feae075c49055d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 18 Nov 2018 15:54:00 +0000 (16:54 +0100)]
Use JvmGlobalLocks in elanmanager
JvmGlobalLocks is giving us all we need to replace String.intern(),
user that.
JIRA: NETVIRT-1510
Change-Id: I72bc211512519e68f06394d28f539bf29f6cd16c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 18 Nov 2018 15:43:20 +0000 (16:43 +0100)]
Use JvmGlobalLocks in neutronmanager
JvmGlobalLocks is giving us all we need to replace String.intern(),
user that.
JIRA: NETVIRT-1510
Change-Id: Ib97d513902f69ab158423dd6cd28bd43ba1e5c8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
xcheara [Sat, 16 Jun 2018 16:16:35 +0000 (21:46 +0530)]
Stale 21->snat_group flow for external subnet
Description:
Its been observed that, even on clean-up on External-network Suite,
few of the stale flows 21->snat_group for external subnet where not
been deleted. As a result, Bundle Resync test-case getting failed
with rersync flag enabled due to these stale flows pointing to an
snat_group with corresponding group missing.
Changes are done to take care of clearing vpn-instance-op-data DS
for external-fixed-ip properly ersutling in triggering
ExternalSubnetVpnInstanceListener
and take care of clearing these stale-flows.
Issue : NETVIRT-1311
Change-Id: I773a2f9935a600b7710796d21d9ce39cf4b9a8c0
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: shaik <shaik.b@altencalsoftlabs.com>
xcheara [Wed, 6 Jun 2018 06:50:39 +0000 (12:20 +0530)]
fix unclosed ReadTransaction
JIRA : NETVIRT-1295
Change-Id: I5264c49226c8e964a6bcfe2b57b9b3765e5db1fd
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: Shaik <shaik.b@altencalsoftlabs.com>
Signed-off-by: shaik <shaik.b@altencalsoftlabs.com>
Anil Kumar Gujele [Fri, 23 Nov 2018 09:44:49 +0000 (15:14 +0530)]
NETVIRT-1520: AlivenessMonitor cache issue
Issue:
Say VM with MIP-IP is on DPN connected to Contorller-1, when MIP is
learnt , it populates the cache alivenessCache. When VM migrates to
another DPN, which is connected to say Controller-2, the same
alivenessCache will not have data w.r.t the monitoring session
created by Controller-1.
Hence incase of cleanup , it causes issues in stopping ArpMonitoring.
The cache is simple local cache which doesnt work incase of cluster.
Fix:
Better to read InterfaceMonitorMap directly from datastore so that
monitorId can be retrieved even if MIP moves across DPNs connected to
various controllers in cluster.
Change-Id: I1e4102a7c57bff8376d3d05be8975a6c1ad74233
Signed-off-by: Anil Kumar Gujele <anilkumar.g@altencalsoftlabs.com>
Somashekar Byrappa [Thu, 10 Jan 2019 07:04:26 +0000 (12:34 +0530)]
Learnt/MIP nexthop is of different address family
Issue:
------
Sporadic issue wherein learnt/MIP IPv4 address has IPv6 address as
nexthop and vice-versa in vpn-interfaces DS.
Solution:
---------
+ Added required check to make sure IPv4 MIP has IPv4 address as
nexthop. Similarly for IPv6 MIPs.
+ This will ensure both local fixed IP and local MIPs pointing to
same OF group in table-21.
+ Additionally simplified some part of the code in the same method by
refactoring.
Change-Id: Ia94d0662187ed752a88eaedd9482f0539020e636
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Sam Hague [Mon, 7 Jan 2019 13:45:51 +0000 (08:45 -0500)]
add NetworkPolicyListener
Depends-on: Id84841e106352bd4e7937b5493cb3b4cd0df2e8f
Change-Id: I5f801ec88cb75f3590c34a50402935ed74a25794
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Wed, 23 Jan 2019 13:52:14 +0000 (14:52 +0100)]
coe: use annotations for references
Change-Id: I8f0e3d157c9baa24c663c7a42fdfd74609d2957a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
xcheara [Fri, 31 Aug 2018 14:18:34 +0000 (19:48 +0530)]
Stale neutronrouterdpn Oper DS cleanup
Description:
On deletion of router, its been observed that there exists an invalid
empty entry for router in neutron-router-dpn DS. This DS will be
populated whenever an VM created/deleted on a DPN part of the router
by NAT. On deletion of all VM on a given router, the empty router
entry left over and even not clear on router deletion.
Changes done to clear the router entry on from this DS on
router deletion.
Issue : NETVIRT-1406
Change-Id: I0db96497f1da92e38268a966066d46b1bfee9e6c
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: shaik <shaik.b@altencalsoftlabs.com>
Vyshakh Krishnan CH [Mon, 21 Jan 2019 11:35:35 +0000 (17:05 +0530)]
changes for faster dcgw failure detection.
faster dcgw failure detection using bfd.
Change-Id: I619e95c56f18782a4dec47f81e1f31f2bea256d7
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
eswanit [Wed, 21 Nov 2018 10:53:36 +0000 (16:23 +0530)]
Fix For ECMP bucket missing on deleting l3vpn
Description:Adding refreshFib on submitting write
config transaction to avoid timing issues
Change-Id: Ief4d56ae0e18348ff16d29981a8bd28eeb0bbc34
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Robert Varga [Tue, 22 Jan 2019 23:18:15 +0000 (00:18 +0100)]
Add coverage aggregation
This recognizes sonar build and runs jacoco report aggregation,
so that test coverage across modules is accounted for.
Change-Id: I45b303b8e87adb3d43b2405b1df5cd14791148e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 21 Jan 2019 09:26:47 +0000 (10:26 +0100)]
Bump mdsal to 3.0.6
This aligns with odlparent-4.0.9 and yangtools-2.1.8.
Change-Id: I2bc91db8df30bc3abb6691b0c4533ce86678f6eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 18 Jan 2019 15:33:24 +0000 (16:33 +0100)]
Bump to odlparent 4.0.9
Change-Id: I655523be12593dbefa5cad0fcc5a527b3a178356
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Wed, 9 Jan 2019 22:34:19 +0000 (17:34 -0500)]
Remove jacoco listener
The listener is no longer needed. The listener was used to
bring in line information for integration tests but all
IT has been removed.
Change-Id: If3f258ed9eca78c38ec957fb912766f793cc7264
Signed-off-by: Sam Hague <shague@redhat.com>
shaik [Mon, 8 Oct 2018 11:21:25 +0000 (16:51 +0530)]
Remove DS operation part of Yang Consumer Thread
Description:
1. Changes are done to remove move the logic of
performing DS read/write and install
installation/removal to perform in the worker
thread instead of performing the same in yang
consumer thread.
2. In the private BGPVPN association case, if the
association is created first and the router-gateway-set
is done later, it is noticed that the default NAT
flow is instaled with external VPN metadata rather then
private BGPVPN metadat. Changes are done to correct it
JIRA : NETVIRT-1392
Change-Id: Ic296b2d3c1c22350518c5008ceb58df1ef17a76c
Signed-off-by: shaik <shaik.b@altencalsoftlabs.com>
Robert Varga [Thu, 10 Jan 2019 15:47:20 +0000 (16:47 +0100)]
Bump mdsal to 3.0.4
This realigns odlparent/yangtools/mdsal and brings in the latest
improvements.
Change-Id: I6640dd25e4af067969633b80cc73a558ccca2dbe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 2 Jan 2019 10:24:32 +0000 (11:24 +0100)]
Bump odlparent to 4.0.8
Change-Id: I7198663389d0eca12761be89eb3b57fb75eadbd1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 27 Dec 2018 14:59:49 +0000 (14:59 +0000)]
Revert "skip tests using xtend until odlparen..."
This reverts commit
5d8745a70ec5463e7753a484cec1bca53c078833.
Change-Id: I7929d968940f5132f56e584643bed2b19e6358fd
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sridhar Gaddam [Sun, 11 Nov 2018 14:38:59 +0000 (20:08 +0530)]
Support for advertising MTU in IPv6 RAs
This patch includes the MTU Option as part of
Solicited/Un-solicited Router Advts and also fixes
some issues in ipv6service unit tests.
Depends-On: https://git.opendaylight.org/gerrit/#/c/77668/
Depends-On: https://git.opendaylight.org/gerrit/#/c/77851/
Change-Id: Ibeae0634bbfdd8b438968e4918026e7109521c6d
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sridhar Gaddam [Mon, 18 Jun 2018 15:01:27 +0000 (20:31 +0530)]
IPv6 CVR North-South Support
This patch programs the pipeline flows on the NAPT and non-NAPT
switch to support North-South traffic. Traffic from non-NAPT
Switch would be forwarded to the NAPT Switch from where its
sent to the external network.
In order to support the IPv6 N/S end-to-end use-case, GWMACResolution
has to happen and the necessary support would be added via a
separate patch.
Change-Id: I2fa0f57af9b063d6bd87c385ab7b1b4d1add5186
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Vishal Thapar [Thu, 3 Jan 2019 15:22:27 +0000 (20:52 +0530)]
auto-config-transport-zones has incorrect default
Fix for NETVIRT-1009 modified the default in config
file for auto-config-transport-zones to false. But
it missed changing in yang file. When a param is
missing in config file, it picks off yang defaults.
This caused a discrepency in behavior due to conflicting
defaults between two.
This fixes yang default to reflect the config default
as per NETVIRT-1009.
This also fixes the log message for two listeners which
used this flag and were misleading.
Change-Id: Ic1b85b798eedd6a14a80eb6145b5a23f73923fdc
JIRA: NETVIRT-1546
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Aswin Suryanarayanan [Tue, 4 Dec 2018 10:08:52 +0000 (15:38 +0530)]
use the provider mappings for external group
The dpn list for populating the external network is now retrieved from
provider mapping
instead of dpn-vpn list for flat/vlan external network.
NETVIRT-1518
Missing FIB flows when subnet is created immediately after the network
create while using vlan external networks.
Change-Id: Ice1f18eb3e903ec4334815f50f88b2ec030be1d5
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
eupakir [Mon, 29 Oct 2018 13:24:18 +0000 (18:54 +0530)]
NETVIRT-1410 Vrf advertised after routes to DC-GW
On a Router/Network association, the vpn-op update to configure IpFamily
was being done after the creation of Vpn Interfaces. THis was leading to
the Networks being written to bgp before the vrf, causing failure in
advertisement of the route to DC-Gw.
This fix swaps the order of IpFamily update and VPN Interface creation.
Change-Id: I52ebf0b5abd9869dfe1c08b2f2511d0ec8468a02
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Shashidhar Raja [Mon, 10 Dec 2018 10:22:14 +0000 (15:52 +0530)]
NETVIRT-1536: Stale flows in ACL tables
Stale flows in ACL tables specific to security rules are observed when
delete events received by neutronvpn and ACL are as specified below:
(1) Neutron Port Event
(2) Neutron SG Event
(3) ACL Interface/State Event
(4) ACL Event (accesslist-acl)
In order to fix this issue, introduced 'deleted' in ACE yang
definition. When SG rule is deleted, ACE would not be deleted,
instead 'deleted' would be set. ACL Event listener after
processing add/delete ACE entries, deletes all the marked ACE
entries of the ACL being updated.
Change-Id: I47ef5328bf05bbed02c5492967005cd4c41f99d6
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Moshe Levi [Mon, 17 Dec 2018 11:26:51 +0000 (13:26 +0200)]
update extension_drivers to ml2 config file
Change-Id: Id2bea560081c527865f4fdaac7aefd5b97be9cd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
Robert Varga [Sun, 23 Dec 2018 23:01:44 +0000 (00:01 +0100)]
Bump mdsal to 3.0.3
This brings in latest fixes and alignes with odlparent-4.0.5.
Change-Id: I5f4da5da46889e5a8e9a6d8955eb57dd57737ebd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
kiranvasudeva [Wed, 28 Nov 2018 12:28:53 +0000 (17:58 +0530)]
NETVIRT-1522: Allowed address pair not updated
Port with SG enabled, when updated with Allowed address pair, newly
added address is not being added into Acl Tables.
Fixed the issue by changing the checks which was causing aap's to be
skipped during port update.
Change-Id: I14e12302483783f113d2244a6267f037d0282cf9
Signed-off-by: kiranvasudeva <kirankumar.v@altencalsoftlabs.com>
Robert Varga [Thu, 13 Dec 2018 08:44:26 +0000 (09:44 +0100)]
Fix netvirt sonar
netvirt-sonar has been failing for 10+ months due to a mismatch
between historical project definition and changes done in
https://git.opendaylight.org/gerrit/68332
Fix this up by specifying <name>netvirt</name>, re-connecting
sonar's history.
Change-Id: I98c21e33f741ebd087aa65367ebd28cec95e27c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Sam Hague [Fri, 21 Dec 2018 22:05:50 +0000 (17:05 -0500)]
Use serviceutils artifacts
Depends-on: I65406f709f45bea1a5a938932551abd99fb5ffe9
Change-Id: Iccc11bb58a6ca96ead452b0edfb44924ea0cd96f
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Fri, 21 Dec 2018 09:10:52 +0000 (10:10 +0100)]
Bump to odlparent 4.0.5
Change-Id: I6eef225e25e49e404a8e2b3fbbcd8ba4341c01d8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Ashik Alias [Wed, 10 Oct 2018 10:48:54 +0000 (16:18 +0530)]
Set feature capability for bgpvpn-vni
This review depends on the following reviews.
https://git.opendaylight.org/gerrit/#/c/63405/
https://git.opendaylight.org/gerrit/#/c/77242/
https://review.openstack.org/#/c/614428/
Change-Id: Ic5014ab4a98338532de8e5c0dfed7647b291bcb8
Signed-off-by: Ashik Alias <ashik.alias@ericsson.com>
Faseela K [Mon, 10 Dec 2018 10:57:40 +0000 (16:27 +0530)]
COE:Generate segmentation-id from vni pool
segmentation-id should be internally generated
using the common vni-pool, instead of being passed
down from COE. This will avoid vni collisions
in the datapath.
JIRA: NETVIRT-1514
Change-Id: I26b0c52bab6f15fe6f27c93d4087f8366ef9d8af
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Sam Hague [Thu, 20 Dec 2018 18:49:01 +0000 (13:49 -0500)]
skip tests using xtend until odlparent bump
Change-Id: I3125520e7c7bf876a0b19b1bae7b85258fa1f365
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Thu, 13 Dec 2018 17:01:46 +0000 (22:31 +0530)]
Default Tunnels deleted from config
When configuring integration bridge, we copy
bridge parameters from operational to configuration
to avoid overwriting them. If any tunnel ports were
added to config before we copyBridgeConfig, they
get overwritten and are lost.
Fix is to use a merge instead of put when copying
bridge to config. This operation is done only
during initial bringup, so overhead of using
merge is acceptable.
JIRA: NETVIRT-1541
Change-Id: I003032883ebae5e405b4d7b849fb2043179f63ff
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Aswin Suryanarayanan [Fri, 7 Dec 2018 09:19:00 +0000 (14:49 +0530)]
In port is set to zero after FIP translations.
In table 27 and table 28 in port is explicitly set to zero so that
packet will not be dropped when it has to be send back to the tunnel it
came from.
NETVIRT-1534 FIP to FIP traffic fails when the translation happens on a
remote switch
Change-Id: I10651762db43be4adc4c1584c51a954176fc63d3
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Faseela K [Mon, 10 Dec 2018 09:22:24 +0000 (14:52 +0530)]
Migrate NAT to genius/vniutils
JIRA: GENIUS-250
Netvirt currently has a vni carving logic which is
tightly coupled with NAT. There are more netvirt
services which are in need of this utility now, and
hence we need to move this to a centralized place.
Adding a new VniUtils in genius, to which now nat is getting migrated to.
Change-Id: Ia08ad6eba9a6b5000c59dd804c8e50f17907257a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Wed, 12 Dec 2018 09:59:58 +0000 (15:29 +0530)]
Fix COE L3 ping failure
COE has stopped using network namespace
for vpn identification, and currently cluster-id
is being used. The same should be used
while we create vpn-interfaces.
JIRA: NETVIRT-1533
Change-Id: I6d0cdbc2eeb6e581ce0dcb34e360297b7c9e5551
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 20 Nov 2018 12:17:17 +0000 (17:47 +0530)]
Update spec: Services with KubeProxy IpTables
Implementation sketch for the iptables based service implementation.
This was done as a quick prototype for the ONS Demo.
The architecture and design needs to the thoroughly reviewed,
before finalising on the solution.
JIRA: NETVIRT-1491
Change-Id: Ie449080d1d9a8e4d8106bfd8d41f029dd73404c9
Signed-off-by: Faseela K <faseela.k@ericsson.com>
nithi thomas [Thu, 6 Dec 2018 12:37:04 +0000 (18:07 +0530)]
neutron-vpn-portip-port-data d.s not cleared
Issue:
======
Stale entry not removed for neutron-vpn-portip-port-data in NAT
use-case.
neutron-vpn-portip-port-data d.s has ipv4 ip's which is
not getting cleared after all the configs are deleted.
Analysis:
=========
The root-cause is in case of NAT use-case when external gateway is
attached to router, while looping through the list of ip's addition
of ipv4 ip's to vpn(internetbgpvpn) was not restricted but while
dissasociating the vpn this restriction check is there.
So ipv4 ip's were retained in data-store.
Added check in updateVpnInterface() in NeutronvpnManager.java
to not add ipv4 entries in neutron-vpn-portip-port-data in case of
internetbgvpn (passed the flag isInternetVpn) where isInternetVpn
flag will be true in this case.
Issue: NETVIRT-1406
Change-Id: I9ae2b1da04988aac461ff50c4a9ac5a9d80a370d
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>
eswanit [Tue, 20 Nov 2018 15:24:00 +0000 (20:54 +0530)]
ECMP - MIP/learnt IPs pointing to groups
Issue:
MIP/learnt IPs (both local and remote) programmed in FIB
(table-21) were pointing to load balancing groups rather
than redirecting to table-220. Only extra routes
(in table 21) need to be pointed to the group.
Fix:
Adding a check to enter setupLoadBalancingNextHop if
it is a static route
Also, the logic for removeAdjacencyFromInternalVpn method
is changed for the deletion of extra-route and nexthop.
Change-Id: Ie2aa43fb3180c032a609cba4fa39ac20f3a5b003
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
Tom Pantelis [Fri, 30 Nov 2018 14:22:43 +0000 (09:22 -0500)]
Reduce info logging in VpnUtils.getRts
The JFR trace in ODLPARENT-176 shows VpnUtil.getRts is a heavy
hitter so reduce the info logging to debug.
Change-Id: Iefe9d7980cf6614dabca442bf786c8c843b65697
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Robert Varga [Mon, 26 Nov 2018 09:34:32 +0000 (10:34 +0100)]
Bump to mdsal-3.0.2
This bumps mdsal to 3.0.2.
Change-Id: I53577129dcca35524245fc2e5c0e6f4eb527418d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Tue, 20 Nov 2018 09:30:57 +0000 (15:00 +0530)]
Remove irrelevant sections from COE spec
Some of the initial design proposals were changed
during the implementation phase, making
respective edits to the spec to align to the
same.
Change-Id: Ib3d9d0f688b121a883558c3dca66e0b4c7191a43
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Tue, 27 Nov 2018 16:13:10 +0000 (17:13 +0100)]
Reduce liblldp usage
We can use Byte.SIZE instead of NetUtils.NUM_BITS_IN_A_BYTE.
Change-Id: Ieb3ab819d137c1a70087181f68dd4787fa0d1e2b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 22 Nov 2018 13:16:01 +0000 (18:46 +0530)]
COE : Use cluster-id instead of namespace
cluster-id is the unique id for a k8s cluster,
and all pods in a cluster should be able to communicate
to each other.
JIRA: COE-19
Change-Id: I13375049814d39a2e45503d99b5912ec404f0fee
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Robert Varga [Mon, 19 Nov 2018 12:41:55 +0000 (13:41 +0100)]
Do not unbox Boolean
This variable is a simple boolean returned, use simple true/false
to modify it.
Change-Id: I3c65b08484c61018973b983922b28e85d146d20d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 19 Nov 2018 12:40:54 +0000 (13:40 +0100)]
Make VpnUtil.getVpnListForVpnInterface() static
This method is not touching any state, make it static and adjust
the sole caller.
Change-Id: I44ab35b0a7b3419663d516d817a549e72a62e0c8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 19 Nov 2018 12:38:48 +0000 (13:38 +0100)]
Make VpnUtil.isDualRouterVpnUpdate() static
This method does not touch any state, make it static and update
its sole caller.
Change-Id: I52211fc3f3636ffe0d3cfac2ce024f39364b614e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 18 Nov 2018 21:46:38 +0000 (22:46 +0100)]
Do not use String.split() in VpnUtil
Rather than compiling regexes and allocating String[]s, use a simple
indexOf() and substring getter to implement almost equivalent
functionality. This breaks on malformed inputs, like 1.2.3.4//24, but
that should be fine.
Change-Id: I1cb294abb3f17c84d332f8075f84e62c1dea86a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Shashidhar Raja [Tue, 13 Nov 2018 13:46:48 +0000 (19:16 +0530)]
NETVIRT-1501: ACL: Used Batched transactions
Currently, each ACL flow is configured in a separate transaction.
With the updated changes, flows programmed are batched to fewer
transactions. This will reduce number of transactions used
significantly to program same set of flows.
Change-Id: I8b4192b3b2d362102a2b297da1a6098f9321424c
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Aswin Suryanarayanan [Thu, 11 Oct 2018 16:14:34 +0000 (21:44 +0530)]
Acl cache not updated
The ACL cache is not updated when AAP changes.
Changes are made to update the cache when an AAP is added or removed.
NETVIRT-1458 Security Group rules dropping IPv6 traffic for any new
subnets that are added to the network.
Fixed issues with IPv6 Unit tests.
Change-Id: Ic0a15ad0c68e5aff9d816442fc32e81abeaa4a83
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Robert Varga [Tue, 13 Nov 2018 14:40:01 +0000 (15:40 +0100)]
Use anyMatch to search routerIds
Full materialization is completely unnecessary and very wasteful,
just use anyMatch(), terminating search as soon as a match is
found. This should halve (on average) the memory overhead.
Change-Id: Ibc28ef9666360efa09707f6193178d16f49c8f74
JIRA: NETVIRT-1503
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 14 Nov 2018 21:34:43 +0000 (22:34 +0100)]
Cache DataTreeModification.getDataAfter()
Invoking this method is quite costly in case of
LazyDataTreeModification, so cache the returned value, preventing
a potentially-costly operation.
Change-Id: Ibb3169fe77b0d6d2f11dae244a1fe110c37b659e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Vishal Thapar [Wed, 14 Nov 2018 07:28:43 +0000 (12:58 +0530)]
Fix Infinite loop in addVpnInterface
add VPNInterface logic in VpnInterfaceManager
has a bug where if add VPN Interface fails, it keeps
retrying till it succeeds. There is no delay in retries.
IF there are any DS issues, this results in an infinite
loop which ties up a DJC thread and fills logs with same
msg repeatedly at a near instant rate.
Bug is in logic where onFailure() method adds the failed
interface back to retry. So while DJC does give up after
5 retries, since we've added it back to the queue
subsequent attempts start soon after.
This also fixes a copy-paste log msg which made it
difficult to troubleshoot where the error log
was repeating from.
Change-Id: I97c73dc879aaa4e1a4b3489e146d1a9337b62810
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
Jaime Caamaño Ruiz [Wed, 24 Oct 2018 14:34:26 +0000 (16:34 +0200)]
Fix race condition between SNAT group & flow
JIRA: NETVIRT-1474
Change-Id: I81add31b2f20edccda28d1f7516a655466b38ca2
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Sam Hague [Thu, 8 Nov 2018 13:40:54 +0000 (08:40 -0500)]
Fix NPE in NatUtil
Change-Id: I42fd678f5e13c6f2f392bf48eddcd65fca3c9c65
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Tue, 30 Oct 2018 14:25:21 +0000 (15:25 +0100)]
Clean up Xtend imports
Change-Id: I7886868ad187c7366db6987aba40f67c75f2b161
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 30 Oct 2018 13:39:54 +0000 (14:39 +0100)]
Add missing fields in expected Flow instances
Flow objects have barrier, installHw and strict fields which need to
be initialised.
Change-Id: Ie4d6d673c83a5861d2864b240ad7054da2198117
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Somashekar Byrappa [Tue, 23 Oct 2018 06:53:08 +0000 (12:23 +0530)]
Rate limit for IPv6 NS punt packets.
+ NS punt controller flow is updated with learn action which adds NS
drop flow per port for a specific ND target.
+ The drop flow will have higher priority (60) than the punt controller
flow (50) to make sure subsequent NS packets from the same port and
for same ND target is dropped till the hard_timeout value (10 secs).
+ The drop flow will match on LPORT tag metadata and ND target to make
sure it drops NS packets per port and for same ND target.
"cookie=0x4000000, duration=0.100s, table=45, n_packets=0, n_bytes=0,
hard_timeout=10, priority=60,icmp6,
metadata=0x60000000000/0xfffff0000000000,icmp_type=135,icmp_code=0,
nd_target=fe80::f816:3eff:fe45:ad28 actions=drop"
"cookie=0x4000000, duration=219.531s, table=45, n_packets=0, n_bytes=0,
priority=50,icmp6,metadata=0x138a000000/0xffff000000,icmp_type=135,
icmp_code=0,nd_target=2001:db8:0:2::1 actions=controller:65535,
learn(table=45,hard_timeout=10,priority=60,cookie=0x4000000,
eth_type=0x86dd,nw_proto=58,icmpv6_type=135,nxm_nx_icmpv6_code[],
oxm_of_metadata[40..59],nxm_nx_nd_target[])"
"cookie=0x4000000, duration=219.531s, table=45, n_packets=1,
n_bytes=86, priority=50,icmp6,metadata=0x138a000000/0xffff000000,
icmp_type=135,icmp_code=0,nd_target=fe80::f816:3eff:fe45:ad28
actions=controller:65535,learn(table=45,hard_timeout=10,priority=60,
cookie=0x4000000,eth_type=0x86dd,nw_proto=58,icmpv6_type=135,
nxm_nx_icmpv6_code[],oxm_of_metadata[40..59],nxm_nx_nd_target[])"
Change-Id: If410a56477e5dc4602e78a365faa5a32dc1d241d
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Sam Hague [Thu, 4 Oct 2018 14:26:55 +0000 (10:26 -0400)]
Upgrade to the Neon base platform
This also includes changes for OSGI-INF.
A few tests had to be disabled; see
elanmanager/impl/src/test/java/org/opendaylight/netvirt/elanmanager/tests/ElanServiceTest.java
and
sfc/classifier/impl/src/test/java/org/opendaylight/netvirt/sfc/classifier/providers/GeniusProviderTest.java
Change-Id: If44b957bac6a7cd352b84140bac0123ddb256704
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Somashekar Byrappa [Wed, 24 Oct 2018 07:13:35 +0000 (12:43 +0530)]
Stale flows in ACL tables 216/246
Issue:
------
Stale flows with VM IP's are observed in ACL tables 216/246 when a VM
is deleted which was having SG with --remote-group rules.
Solution:
---------
The issue is due to race-conditions.
Processing VM deletion is handled via DJC where-as deletion of
AclInterface from cache is not. This was resulting in stale flows.
Now, DJC with same key (ACL-ID) is used even for deletion of
AclInterface from cache which will sequence the operations.
JIRA: NETVIRT-1469
Change-Id: I315831b62a2ac5954fa4177a755c828a1f43d476
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>