Bump versions by 0.1.0 for next dev cycle

Change-Id: Ia84b1a7e2860e4af71b119b7f0f9e98cf40d51e6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Add more tests to improve Code Coverage for VPN related files"

Merge "Add more tests to improve Code Coverage for Load Balancer related files"

Merge "Add more tests to improve code coverage"

Merge "Add more tests to improve Code Coverage for Metering files"

Merge "Add more tests to improve Code Coverage"

Enhance Neutron Firewall tests to get better code coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in the files covered.
Also reverted the changes made to existing tests.

Change-Id: I8da4c7b7058915bb1c23a857b5f85d4281c3700e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by 12% for these files

Change-Id: Ib80bd954ce2373fc13d36191d27e2bdb06f74a39
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage for Metering files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~13% in these files

Change-Id: I2c55ee615e432280c73e3ee643e476a7528fef8e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve Code Coverage for Load Balancer related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~15% in these files

Change-Id: I7fff8a65b3a33bab5f97a9480fee177982add169
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "Bug 4845 - prefix neutron stuff to model bundle name"

Add more tests to improve Code Coverage for VPN related files

Adding new test get with query achieved more functional coverage.
Moving the collection_get_test later after the nodes were created
helped getting more condition coverage in list functions.
These changes improve code coverage by ~17% in these files

Change-Id: Ia256aa2df4f0be138e6683c3dd0b42c8f42a724b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Add more tests to improve code coverage

Adding new tests 1)update and 2)get with query achieved more
functional coverage. Moving the collection_get_test later after the
nodes were created helped getting more condition coverage in
listGroups and listRules functions. Improved code coverage from
66% to 80% for NeutronSecurityGroupsNorthbound and
42% to 70% NeutronSecurityRulesNorthbound.

Change-Id: I56708a0c1c66158dd29784a9a2edd99e5749077e
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 4848 - Remove provider attributes from top neutron container

Provider attributes should not be under top neutron container.

Change-Id: I0369d651f9791d3077cf65fed2b6509a598dc7aa
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4845 - prefix neutron stuff to model bundle name

Add maven-bundle-plugin build plugin in POM to generate proper
bundle name.

Change-Id: I95821608ffe3acc63ced3c153bd880d404f4ff3d
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Merge "Bug 4818 dnsNameservers not stored in subnet MDSAL"

Bug 4838 - add missing LICENSE file

This patch adds a LICENSE file to show the terms of license explicitly.

Change-Id: Ie1732ea1b523220bb5a582e858a6dec6d279464e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4818 dnsNameservers not stored in subnet MDSAL

NeutronSubnet.initDefaults() wrongly initializes dnsNameservers even if
user passed a value. There should be a null check and initialization should
be done only if user didn't pass anything.

This adds check for dnsNameservers and improves the test cases in NeutronSubnetTests

Change-Id: Ibade65f18a65b9c8e6c0a26de02bbbbbe5cac0b7
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Bug 4805 add host_routes info to MDSAL"

Merge "Bug 4829 - ITNeutronE2E.java: connect test cases for bgpvpn"

Bug 4805 add host_routes info to MDSAL

Transcriber is missing code to add hostRoute information to
MDSAL when Subnet is created/updated.

This change adds code to toMd() and fromMd() to handle hostRoutes.

Change-Id: I7b7b7dc5092971d86aec38e5365518712d84e8c2
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "Bug 4797 - prefix neutron stuff to model bundle name"

Bug 4829 - ITNeutronE2E.java: connect test cases for bgpvpn

Somehow testsets for bgpvpn isn't connected to ITNeutronE2E
so that it isn't run by CI.

Change-Id: Ib125ffcef2ea2d69f45b3166ff41028292618ce9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 4775 - handle cases when tenant-id is an empty string"

Merge "Bug 4816 - Change common attributes' descriptions into resource neutral"

Merge "Bug 4807 fix destination type in subnets yang"

Bug 4775 - handle cases when tenant-id is an empty string

Enhanced transcriber to check cases when tenantId is an empty
string. Previous check were only looking for cases when tenantId
was null.

When ODL is used with l3 agent and l3_ha, subnet/network created
for handling keep alive traffic contains tenant id set to "".

Patch set 2: code review: Simplify changes by adding logic for
checking on empty string at the base object (NeutronObject).

Patch set 3: code review: Remove check in toMd of NeutronPortInterface
because it is no longer needed.

Patch set 4: add UT

Change-Id: I05b61d74fff9c1d4fe373446f60cf0bd98a54e14
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4789 - model allowed address pairs"

Bug 4816 - Change common attributes' descriptions into resource neutral

status, admin-status-up and tenant-id attributes are used by
many object types. Their descriptions should not be network
type specific.

Change-Id: Iaa671329e48fbc690aaefcc6ee99215730cc9703
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4807 fix destination type in subnets yang

host-routes attribute of subnets has destination
field defined as type inet:ip-address. As per Neutron
APIv2 spec it should be of type CIDR

Fix is to change it to ip-prefix

Change-Id: I0c8653b2e24eac06d98c5afd679a0a70d6669e3b
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Bug 4797 - prefix neutron stuff to model bundle name

Add maven-bundle-plugin build plugin in POM to generate proper
bundle name.

Change-Id: I05948de9feaace567d099c4147dda884aedfbec4
Signed-off-by: yong sheng gong <gong.yongsheng@99cloud.net>

Bug 4789 - model allowed address pairs

Allowed address pairs doesn't include port id according to neutron spec.
actually ip_address is ip address or network address.
So for simplicity, networking-odl should pass always pass network address.
in case of ip address case, address/32 will be passed.
This patch should be merged after
https://git.opendaylight.org/gerrit/#/c/31402/
is merged

Change-Id: I40b0142cd9a1af8fd30d1fa987ae7b8a5fa49db2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Drop properties from features.xml"

Merge "Bug 4745 - extra dhcp opt: neutron API updated to include ip_version"

Drop properties from features.xml

features-parent allows properties to be replaced with {{VERSION}} in
many places in features.xml; this helps clean up odlparent.

Change-Id: I38ef9c8668c92f9e1aced7466db110bf7626a6f7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4745 - extra dhcp opt: neutron API updated to include ip_version

Exception occurs as follows with the context of extra_dhcp_opts.
Neutron API of extra_dhcp_opts added ip_version to distinguish ipv4 and ip6.
It needs to be handled, otherwise exception occurs.

create/update port with extra_dhcp_opts
    "extra_dhcp_opts": [
      {
        "opt_value": "pxelinux.0",
        "ip_version": 4,
        "opt_name": "bootfile-name"
      },
      {
        "opt_value": "123.123.123.45",
        "ip_version": 4,
        "opt_name": "server-ip-address"
      },
      {
        "opt_value": "123.123.123.123",
        "ip_version": 4,
        "opt_name": "tftp-server"
      }

> 2015-12-08 10:06:30,307 | ERROR | v2/neutron/ports | ContainerResponse                | 47 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.IllegalArgumentException: All keys must be specified for class org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.port.attributes.ExtraDhcpOptsKey. Missing key is getIpVersion. Supplied key is ExtraDhcpOptsKey [_optName=bootfile-na
> me]
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
>         at org.opendaylight.yangtools.binding.data.codec.impl.ValueContext.getAndSerialize(ValueContext.java:46)
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.serialize(IdentifiableItemCodec.java:124)
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentifiableItemCodec.serialize(IdentifiableItemCodec.java:31)
>         at org.opendaylight.yangtools.binding.data.codec.impl.KeyedListNodeCodecContext.serialize(KeyedListNodeCodecContext.java:80)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingToNormalizedStreamWriter.startMapEntryNode(BindingToNormalizedStreamWriter.java:156)
>         at org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.port.attributes.ExtraDhcpOpts$StreamWriter.serialize(DataObjectSerializerPrototype.java)
>         at org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.ports.attributes.ports.Port$StreamWriter.serialize(DataObjectSerializerPrototype.java)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DataObjectSerializerProxy.serialize(BindingNormalizedNodeCodecRegistry.java:295)
>         at org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNode(BindingNormalizedNodeCodecRegistry.java:106)
>         at org.opendaylight.controller.md.sal.binding.impl.BindingToNormalizedNodeCodec.toNormalizedNode(BindingToNormalizedNodeCodec.java:133)
>         at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:39)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.updateMd(AbstractNeutronInterface.java:177)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.addMd(AbstractNeutronInterface.java:151)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:360)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:370)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$8.action(AbstractNeutronInterface.java:367)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.chainWrapper1(AbstractNeutronInterface.java:94)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.add(AbstractNeutronInterface.java:366)
>         at org.opendaylight.neutron.northbound.api.AbstractNeutronNorthboundIAware.create(AbstractNeutronNorthboundIAware.java:64)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at org.opendaylight.neutron.northbound.api.NeutronPortsNorthbound.createPorts(NeutronPortsNorthbound.java:247)[235:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.GeneratedMethodAccessor99.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_45-internal]
>         at java.lang.reflect.Method.invoke(Method.java:497)[:1.8.0_45-internal]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[47:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[174:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[174:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[142:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[157:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:366)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[148:org.eclipse.jetty.aggregate.jetty-all-server:8.

Change-Id: I6f2713ad6baedd60be58dbd38ca420906157810a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "L2gateway: Added yang, APIs,Transcriber for L2gateway."

L2gateway: Added yang, APIs,Transcriber for L2gateway.

Patch Set 4: Removed I*Aware related code, Addressed review comments.

Patch Set 5: Aligned code with merged changes. Addressed review
comments.
Openstack Neutron API:
https://github.com/openstack/networking-l2gw/blob/master/specs/kilo/l2-gateway-api.rst
Patch Set 8: fixed the review comments

Patch Set 9: fixed the review comments

Change-Id: Icfc93bc39f56f6b103b13834359128f29df804b9
Signed-off-by: raveek <raveek@hp.com>

Bug 4188 - null pointer exception in NeutronSubnetInterface.addSubnet()

When subnet is updated, the following exception happends.
This is because the corresponding network isn't always created before
subnet creation depending on situation.
The order of creation/update of network and subnet can be reordered.

In fact subnets list of network in MD-SAL isn't already well-maintained,
and it can be calculated from list of subnets with its parent network uuid.
Actually Openstack Neutron db generates subnet list by foreign key
with ORM mapper. So it makes sense for ODL neutron northbound to
eliminate subnet list instead of maintaining subnet list correct.

> 2015-08-20 14:10:21,025 | ERROR | p492280269-15502 | ContainerResponse                | 195 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
>         at org.opendaylight.neutron.transcriber.NeutronSubnetInterface.addSubnet(NeutronSubnetInterface.java:118)
>         at org.opendaylight.neutron.northbound.api.NeutronSubnetsNorthbound.createSubnets(NeutronSubnetsNorthbound.java:218)[373:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)[:1.7.0_79]
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)[:1.7.0_79]
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.7.0_79]
>         at java.lang.reflect.Method.invoke(Method.java:606)[:1.7.0_79]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[195:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[196:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[196:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[159:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[174:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:370)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.content(AbstractHttpConnection.java:982)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.content(AbstractHttpConnection.java:1043)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:865)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:240)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[165:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.7.0_79]

Change-Id: Ie7861ae292ee7a1666505f0901cad99fb29a9ff3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge changes from topic 'bgpvpn-fixup'

* changes:
  use INeutronObject instead of NeutronObject where possible
  bgpvpn: simplify bgpvpn related code
  northbound: Split out AD-SAL logic from AbstractNeturonNorthbound

remove unused ConcurrentHashMap

The variable somehow was missed to be deleted.

Change-Id: I9784b64ee7b32154241d0efe183756e60404b251
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

use INeutronObject instead of NeutronObject where possible

Change-Id: Id5abdaa58af68985d4ec88ecfd4a1e0c9a60b653
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

bgpvpn: simplify bgpvpn related code

This patch simplifies bgpvpn related code.

Change-Id: I36fdb996d4b20dfb1319ec11fe815a882b1bed85
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: Split out AD-SAL logic from AbstractNeturonNorthbound

This is a follow up patch for
  changeset of 43f88bf737adcb2e5df9e106d8b491de1549c41d
  change id of I3de3f9461047363501f0e3a6428580f93402c65b
  Neutron*Northbound: consolidate crud logic
and
  changeset of aafe31458a9990f50023566aed7f7b296b95067c,
  change id of I2c36c104dbd6c891a36c10419ed28d8060958d29.
  BGPVPN: Added yang, api and transcriber for BGPVPN

bgpvpn which was newly introduced after AD-SAL deprection doesn't implement
AD-SAL. So the class of NeutronBgpvpnsNorthbound requires its super class,
AbstractNeutronNorthbound, not to use AD-SAL.
This patch factors out ad-sal logic from AbstractNeutronNorthbound
into new subclass, AbstractNeutronNorthboundIAware with minor compilation
adjustment.

Change-Id: I9ce990558f178f1571cfac9760dd333b5b40174f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Neutron_ID: check uuid string format

This patch adds check of uuid string format.
also it removes unnecessary String.valueof for consistency.

Change-Id: I340e2098a9f237b35c1072192adf37d265e56f65
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Align BGPVPN code with merged changes

Change-Id: I508a718ed2a9063d83ddff276dc8cb2848d583cd
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "BGPVPN: Added yang, api and transcriber for BGPVPN"

Merge changes from topic 'northbound-refactor'

* changes:
  Neutron*Northbound: consolidate crud logic
  NeutronObject: add initDefaults() method to NeutronObject

Merge "Changes to prepare for MOXy 2.6.x"

Merge "northgound: Make Neutron*Request implements INeutronRequest interface"

Reversion yang model

With the yang model cleanup, we really need to reversion it.
This patch will need notification of downstream projects

Change-Id: Iba70ab1a2ac66e9e0e880dd5384966ac2f77b7a9
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Bug 4365 - Null pointer exception at org.opendaylight.neutron.spi.NeutronNetwork.addSubnet"

Merge "Fixes Bug 4379"

Merge "Fixes Bug 4345"

Merge "Bug 4354 - neutron tenant_id doens't contain '-'(dash)"

Changes to prepare for MOXy 2.6.x

MOXy 2.6.x adds additional dependencies that need to be included.

Change-Id: I5ababbabef78f1eaf7a35d2fd0c2a76f5ae4c7de
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Bug 4365 - Null pointer exception at
org.opendaylight.neutron.spi.NeutronNetwork.addSubnet

Change-Id: Iff9b269aa99e6450e67edce718763e11ac4f4a9a
Signed-off-by: raveek <raveek@hp.com>

Fixes Bug 4379

Change-Id: Ia9ef5461bf44557e72c0a5932ed869d9a275cb52
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Neutron*Northbound: consolidate crud logic

This patch conslidates CRUD logic of Neutron*Northbound.
The refactor sorts out inconsistency between resources. As bonus,
all resources supports bulk creation now.

Change-Id: I3de3f9461047363501f0e3a6428580f93402c65b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronObject: add initDefaults() method to NeutronObject

Some of Neutron<Resrouce> classes defines initDefaults() method.
Define the method at the base class as preparation for code consolidation.

Change-Id: I4b3277c28aabd9bc94b2a5efeb3eb06ee749bf1c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northgound: Make Neutron*Request implements INeutronRequest interface

Some Neutron*Request class implements INeutronRequest and some doesn't.
Make all of them implements it.
This is preparation for code consolidation.

Change-Id: I3ceb4fc05b5e3e094be9854d6cd81bc05e6f00db
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge changes from topic 'bug/4143'

* changes:
  simplify NeutronNetworkInterface.networkExists()
  transcriber: make use transaction chain more

Merge "transcriber: consolidate getAll() logic"

Merge "Bug 4285 - NeutronSubnetInterface.fromMd() null pointer exception"

Fixes Bug 4345

Change-Id: I01a621f65ebe2afbc54dbc01a40d8b8c21335d78
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Fix -Dkaraf.debug

The debug setup needs to come after the main distribution
configuration. This patch moves it to the end, instead of the
commented code which used to enable remote debugging.

Change-Id: I7fbeecf8e1a2063fb1f75c3e2b07df7f73c2f1e1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4285 - NeutronSubnetInterface.fromMd() null pointer exception

null pointer exception as follows when deleting subnet.
gatewayip, ipv6 ra mode, and ipv6 address mode can be null as
neutron api defines. So fromMd() methods should null check for those.

> 2015-09-29 15:39:16,122 | ERROR | p371782331-48632 | ContainerResponse                | 126 - com.sun.jersey.jersey-server - 1.17.0 | The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
>         at org.opendaylight.neutron.transcriber.NeutronSubnetInterface.fromMd(NeutronSubnetInterface.java:140)
>         at org.opendaylight.neutron.transcriber.NeutronSubnetInterface.fromMd(NeutronSubnetInterface.java:50)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.get(AbstractNeutronInterface.java:314)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$6.action(AbstractNeutronInterface.java:323)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface$6.action(AbstractNeutronInterface.java:320)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.chainWrapper1(AbstractNeutronInterface.java:94)
>         at org.opendaylight.neutron.transcriber.AbstractNeutronInterface.get(AbstractNeutronInterface.java:319)
>         at org.opendaylight.neutron.transcriber.NeutronSubnetInterface.getSubnet(NeutronSubnetInterface.java:80)
>         at org.opendaylight.neutron.northbound.api.NeutronSubnetsNorthbound.deleteSubnet(NeutronSubnetsNorthbound.java:328)[364:org.opendaylight.neutron.northbound-api:0.6.0.SNAPSHOT]
>         at sun.reflect.GeneratedMethodAccessor258.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_60]
>         at java.lang.reflect.Method.invoke(Method.java:497)[:1.8.0_60]
>         at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1511)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1442)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1391)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1381)[126:com.sun.jersey.jersey-server:1.17.0]
>         at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)[127:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:538)[127:com.sun.jersey.servlet:1.17.0]
>         at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:716)[127:com.sun.jersey.servlet:1.17.0]
>         at javax.servlet.http.HttpServlet.service(HttpServlet.java:668)[38:org.apache.geronimo.specs.geronimo-servlet_3.0_spec:1.0.0]
>         at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:247)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:210)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1467)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceServletHandler.doHandle(HttpServiceServletHandler.java:69)[53:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.HttpServiceContext.doHandle(HttpServiceContext.java:240)[53:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.ops4j.pax.web.service.jetty.internal.JettyServerHandlerCollection.handle(JettyServerHandlerCollection.java:75)[53:org.ops4j.pax.web.pax-web-jetty:3.1.4]
>         at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.Server.handle(Server.java:370)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1033)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)[44:org.eclipse.jetty.aggregate.jetty-all-server:8.1.15.v20140411]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]

Change-Id: I454889cb21a98bdbcf5207f6676634b139648d87
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

BGPVPN: Added yang, api and transcriber for BGPVPN

Based off BGPVPN blueprint: https://review.openstack.org/#/c/177740/

PatchSet3: Added basic ITs.

PatchSet4: Addressed review comments

PatchSet5:
1. Fixed some typo induced bugs
2. Added code for some missing attributes

PatchSet6: Fill in defaults if missing in update

Patchset7:
Incorporates spi and transcriber changes as per following:
a. https://git.opendaylight.org/gerrit/#/c/26975/
b. https://git.opendaylight.org/gerrit/#/c/27003/

Patchset8:
Addresses review comments in Patchset7

Change-Id: I2c36c104dbd6c891a36c10419ed28d8060958d29
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

simplify NeutronNetworkInterface.networkExists()

Somehow I missed networkExists() when refactoring code.

Change-Id: I8508eafce724ca7dc01d373fe1f36bcb2b5d442b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: make use transaction chain more

This patch makes AbstractNeutronInterface use transaction chain more
with code simplification.

This is a follow up patch of Change-Id of
I2f79877259acf8f642ffa4877552112f7b0da7b5 and Change-Id of
I4fe57ad42867bbbfc38f4d0175ae417bc15afa0a

Related-Bug: 4143
Change-Id: Ifefcb6a3136d0714281a081167f4a2c494a9218b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: consolidate getAll() logic

This patch factors out the logic of getAll()

Change-Id: I4e529bf7a4b3dfd7a4442ae0f63b4e03f23cb79b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 4143 - Transation failed with OptimisticLockFailedException"

Merge "transcriber: use transaction chain for optimization"

Merge "Bug 4043 - remote ip prefix of security group is type of ietf ip-prefix"

Merge "Bug 4224 - remote_ip_prefix of metering rule should be type of ip-prefix"

Merge changes from topic 'bug/4218'

* changes:
  Bug 4218 - northbound: return 404 when deleting unexisting uuid
  northbound: introduce a base class for nortubhound classes

Bug 4354 - neutron tenant_id doens't contain '-'(dash)

Neutron tenant_id is uuid without '-'(dash).
Some of fromMd forgets to remove dash.
This patch consolidates the logic of setTenantID() and fixes it.

Change-Id: I5b33a78ff08af0e78a8185fc922a59fd403ce07c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "neutron-spi: Introduce base class for Neutron object"

Bug 4143 - Transation failed with OptimisticLockFailedException

transaction in AbstractNeutronInterface.updateMd() can abort with
OptimisticLockFailedException as follows when updating a same resource.
For example, when attaching an interface to a router,
neutron creates a port, then update it right after creation. It may
causes transaction abort.

o.o.controller.sal.restconf.impl.RestconfImpl#updateConfigurationData
has a similar issue and retries 2 times.
By following the precedence, add retry logic to updateMd() to mitigate
transaction abort.

> 2015-08-14 17:20:26,623 | WARN  | ult-dispatcher-4 | ConcurrentDOMDataBroker          | 157 - org.opendaylight.controller.sal-distributed-datastore - 1.3.0.SNAPSHOT | Tx: DOM-183 Error during phase CAN_COMMIT, starting Abort OptimisticLockFailedException{message=Optimistic lock failed., errorList=[RpcError [message=Optimistic lock failed., severity=ERROR, errorType=APPLICATION, tag=resource-denied, applicationTag=null, info=null, cause=org.opendaylight.yangtools.yang.data.api.schema.tree.ConflictingModificationAppliedException: Node was created by other transaction.]]}

Change-Id: I4fe57ad42867bbbfc38f4d0175ae417bc15afa0a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: use transaction chain for optimization

This patch makes transcriber use transaction chain.
The next step is to make subclasses use transaction
chain.

Related-Bug: 4143
Change-Id: I2f79877259acf8f642ffa4877552112f7b0da7b5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add support for karaf.debug

This is the basic version, a better approach would be to use either
AbstractMdsalTestBase or AbstractConfigTestBase (but the impact is
greater).

Original gerrit [1] caused a regression in that the
keepRuntimeFolder() was done conditionally. That broke things and
had to be reverted.

[1]: https://git.opendaylight.org/gerrit/#/c/26983/

Change-Id: I9fcbdb12fed154d3e2c16908b58bb99418fdc098
Also-By: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Revert "Add support for karaf.debug and karaf.keep.unpack""

Revert "Add support for karaf.debug and karaf.keep.unpack"

This breaks our IT test reporting in jenkins, so let's try this again.

This reverts commit d9c920c3a3e1fffcdd913e0a880ecbbef231d7fe.

Change-Id: I1592768f3d59d220f5fdad5a48070bf338c9787d
Signed-off-by: Ryan Moats <rmoats@us.ibm.com>

Merge "Make I*Aware interfaces deprecated"

Merge "transcriber: consolidate crud logic"

neutron-spi: Introduce base class for Neutron object

This patch introduce base class for Neutron object for code consolidation.
This is preparation for bug fixing 4157.

Change-Id: Ibc0fc28255c6fcfd022fd1feb2af079cff416a61
Related-Bug: 4157
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Make I*Aware interfaces deprecated

Change-Id: If5995a4e4d2f8e75250da7a99a586f4e96ec00fb
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 4043 - remote ip prefix of security group is type of ietf ip-prefix

remote ip prefix of security group rule should be type of ietf ip-prefix,
not ip-address.

Change-Id: Ibd6c74272e9e3ea9926f0992632bf02303870f0a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4224 - remote_ip_prefix of metering rule should be type of ip-prefix

remote_ip_prefix of metering rule is type of ietf ip-prefix,
not ietf ip-address.

Change-Id: If76c8790812e33f626c30cad6968900bbb59ebb3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4325: floating ip update is not working

Change-Id: I4e028f396defd11bcd477da0c8a817f45c8fca57
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 4324: neutron port for router must allow empty string as tenant id"

Bug 4324: neutron port for router must allow empty string as tenant id

Patch set 2: complement toMd() by adding corresponding check on from Md()

Change-Id: Ifae54f92f85cc73e744a3b348d03fd7ddd290311
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

transcriber: consolidate crud logic

This patch refactors transcriber by consolidating crud logic

Change-Id: I25b7ed350ca026abda633949441868483a044281
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add support for karaf.debug and karaf.keep.unpack

This is the basic version, a better approach would be to use either
AbstractMdsalTestBase or AbstractConfigTestBase (but the impact is
greater).

Patch set 2: use constants instead of bare strings

Change-Id: I8c54da0892c8e969c838edb20902ba123065782c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4218 - northbound: return 404 when deleting unexisting uuid

Deleting unexisting uuid results in internal server error right now.
It should return 404(not found) instead so that the neutron ODL driver
can behave gracefully.
This patch is paired with the following networking-odl patch.
https://review.openstack.org/#/c/217872/
https://bugs.launchpad.net/networking-odl/+bug/1489593

Change-Id: I9c4f56f5015148fa6c0cc7216c0917b79752f127
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

northbound: introduce a base class for nortubhound classes

This patch introduces a base class for nortubhound classes to consolidate
some codes.
Related-Bug: 4218

Change-Id: I6a82944cbab555114b294aef1aff4282e03b0d87
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 4265: NPE when sg.getSecurityRules is null

Patch set 2: add missing call to multiple_sr_create_test().

Change-Id: I532129d9cc370a0170ccfac63c8fcbe0604f1fe2
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Remove Metering ConcurrentHashMaps"

Merge "Remove security group and security rule ConcurrentHashMaps"

Merge "Remove ConcurrentHashMaps from LBaaS classes"