openflowplugin.git
3 years agoMerge "Add SwitchCertificate attributes in TLS failure notification"
Arunprakash D [Mon, 27 Jul 2020 16:28:47 +0000 (16:28 +0000)]
Merge "Add SwitchCertificate attributes in TLS failure notification"

3 years agoMerge "Add INFO.yaml for openflowplugin"
Arunprakash D [Mon, 27 Jul 2020 15:44:50 +0000 (15:44 +0000)]
Merge "Add INFO.yaml for openflowplugin"

3 years agoMerge "Added JSON and XML payloads tabs with RFC 8040 URL"
Arunprakash D [Mon, 27 Jul 2020 15:43:29 +0000 (15:43 +0000)]
Merge "Added JSON and XML payloads tabs with RFC 8040 URL"

3 years agoAdded JSON and XML payloads tabs with RFC 8040 URL 47/90547/10
Dhiraj Sharma [Mon, 22 Jun 2020 07:12:32 +0000 (12:42 +0530)]
Added JSON and XML payloads tabs with RFC 8040 URL

Signed-off-by: Dhiraj Sharma <dhiraj.8.sharma@gmail.com>
Change-Id: I4efd1b236dae9a93c02cad1c9e3a99600d45d3b4

3 years agoAdd SwitchCertificate attributes in TLS failure notification 13/91313/10
Harshini M [Mon, 13 Jul 2020 15:39:01 +0000 (21:09 +0530)]
Add SwitchCertificate attributes in TLS failure notification

JIRA : OPNFLWPLUG-1094

Change-Id: I00aa25b3dfc33d10333a43b8bc67a2515f8fc874
Signed-off-by: Harshini M <hm@luminanetworks.com>
3 years agoMerge "Fix ExperimenterActionSerializerKey initializer use"
Arunprakash D [Wed, 22 Jul 2020 08:51:02 +0000 (08:51 +0000)]
Merge "Fix ExperimenterActionSerializerKey initializer use"

3 years agoMerge "Make methods static"
Arunprakash D [Tue, 21 Jul 2020 05:46:49 +0000 (05:46 +0000)]
Merge "Make methods static"

3 years agoOPNFLWPLUG-1093 : Exceptions Multiple entries with same key seen in openflowplugin 90/90390/6
dheenadayalan b [Thu, 11 Jun 2020 10:59:58 +0000 (16:29 +0530)]
OPNFLWPLUG-1093 : Exceptions Multiple entries with same key seen in openflowplugin

description: Post aluminium mri changes node statistics rpc response was not successful,
             as flowstatisticsmaplist list contain duplicate flow-Id keys,removed flowstatisticskey from Flowstatistics
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I014e18630d1531df2f13e4d0c83defa183cadf0d
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
3 years agoFix ExperimenterActionSerializerKey initializer use 22/91422/4
Robert Varga [Sat, 18 Jul 2020 19:31:15 +0000 (21:31 +0200)]
Fix ExperimenterActionSerializerKey initializer use

Fix raw type use and convert tests to use Uint32 constants,
fixing migration warnings.

JIRA: OPNFLWPLUG-1099
Change-Id: I4c77735129403db278df2888e208ee2f11f20fab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMake methods static 19/91419/6
Robert Varga [Sat, 18 Jul 2020 14:20:35 +0000 (16:20 +0200)]
Make methods static

Eclipse points out these methods can be made static, clean up those
warnings. This very slightly improves performance as well as makes
it clear these methods are not touching object state.

Change-Id: Iecefe5ebc858d3173402568451578daeceb26192
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoMigrate IetfYangUtil.bytesFor() users 23/91423/3
Robert Varga [Sat, 18 Jul 2020 19:52:06 +0000 (21:52 +0200)]
Migrate IetfYangUtil.bytesFor() users

There are more types handled by IetfYangUtil, hence its naming is
evolving. Convert use of bytesFor() to to use macAddresBytes().

Change-Id: I57eadf74976079621c20a7765188a8beeaa0ba8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoRemove use of Byte(byte) constructor 20/91420/2
Robert Varga [Sat, 18 Jul 2020 14:22:05 +0000 (16:22 +0200)]
Remove use of Byte(byte) constructor

This constructor is deprecated for removal, do not use it.

Change-Id: Ibda3dc2c696289f9a903516f0e03063b2b9a9c62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoAdd INFO.yaml for openflowplugin 57/91257/1
Anil Belur [Sun, 12 Jul 2020 01:26:30 +0000 (11:26 +1000)]
Add INFO.yaml for openflowplugin

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I44797e0800afb83644247167083c2da6d23b329f

3 years agoOpenflow Event logging using log4j - addition/modification of few logs 40/90840/2
dheenadayalan b [Wed, 1 Jul 2020 14:41:16 +0000 (20:11 +0530)]
Openflow Event logging using log4j - addition/modification of few logs

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I9a4c0a74611eb2efcb359cac203959bdc4b8429e
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
3 years agoCorrect ampersand escapes 15/90615/8
Robert Varga [Thu, 2 Jul 2020 08:49:07 +0000 (10:49 +0200)]
Correct ampersand escapes

Ampersands need to be escaped in XML. Since we are using XML highlight,
the examples failed to lex, leading to a rtd job failure.

Change-Id: I233e018b706c65354fd7a68f78f66505e2f34e30
Signed-off-by: Dhiraj Sharma <dhiraj.8.sharma@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
3 years agoFix MRI feature references 76/90576/2
Robert Varga [Mon, 22 Jun 2020 19:04:24 +0000 (21:04 +0200)]
Fix MRI feature references

OFP features are referencing a number of MRI features without using
ranged imports. Fix this up, improving our ability to upgrade
seamlessly.

Change-Id: Ife2b804628dd9d7e0ca84f16e5e7a1e023bc072c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoIntegrate controller-2.0.2 10/90410/1
Robert Varga [Thu, 11 Jun 2020 21:46:11 +0000 (23:46 +0200)]
Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: Ib4b8904e6393e63301a238df1864a94fe9a04e67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMerge "All openflow nodes are not getting listed in the output of getallnodes in...
Arunprakash D [Mon, 1 Jun 2020 04:37:54 +0000 (04:37 +0000)]
Merge "All openflow nodes are not getting listed in the output of getallnodes  in controller nodes"

4 years agoIntegrate controller-2.0.1 58/90158/1
Robert Varga [Sun, 31 May 2020 09:20:36 +0000 (11:20 +0200)]
Integrate controller-2.0.1

This bumps versions to the following:
- odlparent-7.0.2
- yangtools-5.0.2
- mdsal-6.0.1
- controller-2.0.1

Change-Id: Ie8e42688731e038a771a7ae28131d11ba0b1fb86
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoAll openflow nodes are not getting listed in the output of getallnodes in controller... 03/87803/8
Dheenadayalan b [Mon, 17 Feb 2020 10:28:38 +0000 (15:58 +0530)]
All openflow nodes are not getting listed in the output of getallnodes  in controller nodes

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: If64f441b211489828867ad9f2091260992ca7a5e
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
4 years agoOPNFLWPLUG-1090: ConcurrentModificationException: null when connecting cbench switches 12/89612/3
Gobinath [Wed, 6 May 2020 09:59:47 +0000 (15:29 +0530)]
OPNFLWPLUG-1090: ConcurrentModificationException: null when connecting cbench switches

Issue:

CSIT job using cbench was frequently failing because some switches are
getting their initial connection rejected.

Observation and Fix:

On analyzing the logs it was found that the failure had been caused by
the sessionstats collection during initial handshake. "ConcurrentModification"
exception was thrown as multiple switch sessions were trying to modify
the SESSION_EVENTS map which reulted in the connection getting closed.

This has been fixed by making the SESSION_EVENTS threadsafe now.

Change-Id: I2d0ec7c00d7c893d6271942f5fdbe9815069d4d0
Signed-off-by: Gobinath <gobinath@ericsson.com>
(cherry picked from commit bd28cb92e0f6f3bca79a04a5e5a57c617b6cb552)

4 years agoSet version to Aluminium 34/88734/2
Thanh Ha [Thu, 26 Mar 2020 19:54:16 +0000 (15:54 -0400)]
Set version to Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I178492ba8affcb8eb74ee1e1e8ac5758a64b3727

4 years agoUpdate MRI projects for Aluminium 98/89498/40
Robert Varga [Tue, 28 Apr 2020 17:23:50 +0000 (19:23 +0200)]
Update MRI projects for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

Change-Id: I4f23c953622f39186f82ac1da487f00f3a9707ab
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
4 years agoMerge "OPNFLWPLUG-1080: Nodes not populated in operational/opendaylight-inventory...
Arunprakash D [Tue, 5 May 2020 05:40:36 +0000 (05:40 +0000)]
Merge "OPNFLWPLUG-1080: Nodes not populated in operational/opendaylight-inventory:nodes after Controller Isolation OPNFLWPLUG-1082: When switch changes owner, all cluster members delete switch inventory operational"

4 years agoFix checkstyle violations 97/89497/3
Robert Varga [Fri, 24 Apr 2020 16:31:48 +0000 (18:31 +0200)]
Fix checkstyle violations

Upgraded checkstyle is finding these, fix them up.

Change-Id: Iae143c99f220c6aec9c744dc8f8adbd5d392f62a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRemove invalid annotations 00/89500/4
Robert Varga [Tue, 28 Apr 2020 17:39:27 +0000 (19:39 +0200)]
Remove invalid annotations

@Nullable on primitive 'int' or 'byte' is invalid, remove it.

Change-Id: I4abf509b978b6004c8306dc944cacbc765a67c89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoOPNFLWPLUG-1080: Nodes not populated in operational/opendaylight-inventory:nodes... 72/89072/9
VenkataSatya Jonnadula [Thu, 16 Apr 2020 11:14:52 +0000 (16:44 +0530)]
OPNFLWPLUG-1080: Nodes not populated in operational/opendaylight-inventory:nodes after Controller Isolation
OPNFLWPLUG-1082: When switch changes owner, all cluster members delete switch inventory operational

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I6ceb3e71dcf86bd83fc9a3f03621502ac5144e95

4 years agoMerge "OPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliatio...
Arunprakash D [Thu, 16 Apr 2020 07:15:06 +0000 (07:15 +0000)]
Merge "OPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliation status"

4 years agoMDSAL API migration changes 03/88803/13
Somashekhar Javalagi [Tue, 31 Mar 2020 07:21:34 +0000 (12:51 +0530)]
MDSAL API migration changes

Desc: List of MdSAL API migration changes.

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I857c25b6bfcfe80160f735bac91746d113c844f3
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
4 years agoOPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliation status 21/88021/13
dheenadayalan b [Mon, 24 Feb 2020 10:02:56 +0000 (15:32 +0530)]
OPNFLWPLUG-1087: ODL controller to provide view of openflow node reconciliation status

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: Ibf3e02fe4352a2bd559b838f8788ca18bc2ab83d
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
4 years agoMerge "Reduce use of deprecated constructors"
Arunprakash D [Thu, 2 Apr 2020 04:46:43 +0000 (04:46 +0000)]
Merge "Reduce use of deprecated constructors"

4 years agoUse Magnesium controller 80/88680/2
Robert Varga [Wed, 25 Mar 2020 21:49:31 +0000 (22:49 +0100)]
Use Magnesium controller

As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.

Change-Id: Idffaea187f9913b7107c26c03410ea6033c21578
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoReduce use of deprecated constructors 40/88040/3
Robert Varga [Tue, 25 Feb 2020 11:19:27 +0000 (12:19 +0100)]
Reduce use of deprecated constructors

Integer-based constructors are deprecated, this adds a dent to
remove their usage.

Change-Id: I3125796dd8b2f12d43a7c491ea34bdc799fdf649
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoOPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel 52/88252/1
VenkataSatya Jonnadula [Thu, 5 Mar 2020 07:30:58 +0000 (13:00 +0530)]
OPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: Ie7fa92f2307ac5751f0c14133d582262f1c46f89

4 years agoOPNFLWPLUG-1085: Switch-idle events weren't consumed by inbound handler during read... 90/88090/4
dheenadayalan b [Thu, 27 Feb 2020 08:43:44 +0000 (14:13 +0530)]
OPNFLWPLUG-1085: Switch-idle events weren't consumed by inbound handler during read time-out,
                 hence moved idle handler above inbound handler from end of channel pipeline

desc: Reverting the changes provided for OPNFLWPLUG-1039, by moving idle handler above the inbound handler
within channel pipeline, as the switchidle event message are fired after channel messages are consumed.

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I1c1a2306eb298ba72aad2480a8f34fa6affa9a28
Signed-off-by: dheenadayalan b <dhinua@gmail.com>
4 years agoMerge "OPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool...
Arunprakash D [Fri, 28 Feb 2020 06:45:13 +0000 (06:45 +0000)]
Merge "OPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool for the first time"

4 years agoOPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool for the... 64/87964/1
Gobinath [Thu, 27 Feb 2020 05:54:41 +0000 (11:24 +0530)]
OPNFLWPLUG-1086: Reconciliation framework failure when starting cbench tool for the first time

Issue:

CSIT job using cbench had consistent failure with the error message
starting starting with a "closed connection ... exiting" message.
The karaf logs indicated the switches getting disconnected because of
"reconciliation framework" failure.

Observation and Fix:

On analyzing the logs it was found that the "flownodereconciliation"
service of the reconciliation framework was throwing an uncaught
exception (ConcurrentModificationException) which had resulted in
the reconciliation framework failure.

This has been fixed and logs have been enhanced to debug similar issues.

Change-Id: I3cbcea2da32c342c83846f2041d82e921d7acf08
Signed-off-by: Gobinath <gobinath@ericsson.com>
(cherry picked from commit 1fdc1a25f9703550c678b4cd83188de26ad9b19d)

4 years agoRework MatchEntrySerializer 21/80521/27
Robert Varga [Thu, 21 Feb 2019 10:46:00 +0000 (11:46 +0100)]
Rework MatchEntrySerializer

MatchEntrySerializer has a filter, which is being applied before
main serialization, and that is the only way it is being used --
we check if the match is present and if it is we run serialize().

This leads to quite a bit of code duplication as well as inefficient
execution, MatchSerializer performs two invocations and each of them
performs at least one traversal of the match.

Change matchTypeCheck() to serializeIfPresent(), which means
MatchSerializer does not invoke two method. This also allows us to
optimize the serialization process in AbstractMatchEntrySerializer
and its subclasses by traversing the match only once. This rework
makes it obvious that MatchEntrySerializer should not be an
OFSerializer, at all, as the inherited methods just confuse the
workflow.

Resulting code structure removes quite a bit of duplicated code
from the individual EntrySerializer classes and lends itself to
sharing functionality through common subclasses -- reducing the
number of possible method implementations at various places, thus
allowing better devirtualization and inlining.

The second part deals with the logic of serializing the header,
as all specific serializers have a constant header, which we can
easily precompute and emit with a single ByteBuf.writeInt() call.
Since external serializers have had the option to dynamically emit
a different header, this capability is retained via HeaderWriter
helper which is attached to each serializer. Since the number of
serializers is limited, this additional object poses little memory
overhead and is partially offset by the reduction of bytecode coming
from the elimination of oxmField/oxmClass/valueLength getters.

Because all our serializers have a constant length, we only provide
one concrete implementation of HeaderWriter, which is
ConstantHeaderWriter. Unless an additional implementation is provided
externally, this means that all header serialization calls are
readily devirtualized via CHA, thus the cost of this indirection
is zero.

JIRA: OPNFLWPLUG-1068
Change-Id: I49b7a3c5770e939d082db8479f6d70a689d4c944
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoOPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel 22/87522/7
VenkataSatya Jonnadula [Mon, 10 Feb 2020 08:56:03 +0000 (14:26 +0530)]
OPNFLWPLUG-1083: Stats frozen after applying 2 sec delay in OF channel

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I3a34ed327237ec2f765291cc45305683f561ae88

4 years agoBump versions by x.y.(z+1) 96/87996/1
jenkins-releng [Sat, 22 Feb 2020 04:30:16 +0000 (04:30 +0000)]
Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idcbd5dc14cae5925e588837bafb1abf1839b88ed

4 years agoOPNFLWPLUG-1074: table stats not available after a switch flap 24/87624/3
Somashekhar Javalagi [Wed, 12 Feb 2020 16:31:06 +0000 (22:01 +0530)]
OPNFLWPLUG-1074: table stats not available after a switch flap

Problem: csit test cases failing due to empty table stats

Root Casue: First time when table stats are collected, they
are written into operational inventory. But consequently at
the time of writing flow stats to datastore, table stats
transaction was still not complete. So when fow stats are
written with empty table stats which are read from
operational inventory

Fix: Collecting flow stats first followed by table stats,
which prevents overwrite of table stats.

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I39bf7ffe9b12a4d3a03efbec95f75dd1a0ef70f6

4 years agoMerge "OPNFLWPLUG-1084 Device operational is not getting created if device reconcilia...
Arunprakash D [Sun, 16 Feb 2020 16:18:18 +0000 (16:18 +0000)]
Merge "OPNFLWPLUG-1084 Device operational is not getting created if device reconciliation is not enabled"

4 years agoRevert "All-dpns are not getting listed in the" 02/87702/1
D Arunprakash [Fri, 14 Feb 2020 06:38:46 +0000 (12:08 +0530)]
Revert "All-dpns are not getting listed in the"

This reverts commit 566c4ac8fcd1feaa501955791790a247f3e69b07.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I6433cdb02d7cf875e9aa9c56bfa0f39ec3bdcc02

4 years agoRevert "Fix for DPNs not connecting to controller" 01/87701/1
D Arunprakash [Fri, 14 Feb 2020 05:56:30 +0000 (11:26 +0530)]
Revert "Fix for DPNs not connecting to controller"

This reverts commit 6b6281680872611d795261dbf232c0131235bd51.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: Id5ed63c59aeb4a3303f5f176d8ad82d6767a43ca

4 years agoRevert "CSC to provide a view of DPN re-sync" 00/87700/1
D Arunprakash [Fri, 14 Feb 2020 05:54:42 +0000 (11:24 +0530)]
Revert "CSC  to provide a view of DPN re-sync"

This reverts commit 674bb50091db4628a50c08606f8f8b9f3c8a5e55.

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I5d03f6175bd2ae9faeb5cdf248c5d15242ee4653

4 years agoCSC to provide a view of DPN re-sync 97/82297/29
Shweta Chaturvedi [Thu, 7 Feb 2019 09:38:45 +0000 (15:08 +0530)]
CSC  to provide a view of DPN re-sync
status from CLI

Change-Id: I6153f394803e43abf77e871f993d9ca7a1bedd45
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoFix for DPNs not connecting to controller 22/85322/6
Somashekhar Javalagi [Wed, 28 Nov 2018 11:12:14 +0000 (16:42 +0530)]
Fix for DPNs not connecting to controller

Change-Id: If708df53a0102bb85fe0040b260f821b4d35773c
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
4 years agoAll-dpns are not getting listed in the 05/85205/5
Shweta Chaturvedi [Fri, 18 Oct 2019 11:32:10 +0000 (17:02 +0530)]
All-dpns are not getting listed in the
output of display all-dpns in cics

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: Id4198d385fd636c5cedefbbf16a99b852ba36265

4 years agoOptimize ReconcileUtil.safe*() 99/84899/5
Robert Varga [Thu, 3 Oct 2019 13:28:31 +0000 (15:28 +0200)]
Optimize ReconcileUtil.safe*()

Node exposes nonnullTables() etc., which we can take advantage of
to simplify code.

Change-Id: Ifc53b8d9bc7898f23896ab0ca159fb4f4d1d73ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMerge "Code refractor and logging improvements"
Arunprakash D [Wed, 5 Feb 2020 06:29:47 +0000 (06:29 +0000)]
Merge "Code refractor and logging improvements"

4 years agoMerge "Code Refractor and logging improvements"
Arunprakash D [Wed, 5 Feb 2020 06:28:35 +0000 (06:28 +0000)]
Merge "Code Refractor and logging improvements"

4 years agoMerge "NETVIRT-1638 Modify yang modules such that it can be validated using pyang"
Arunprakash D [Tue, 4 Feb 2020 09:33:07 +0000 (09:33 +0000)]
Merge "NETVIRT-1638 Modify yang modules such that it can be validated using pyang"

4 years agoCode refractor and logging improvements 86/83386/6
Shweta Chaturvedi [Mon, 5 Aug 2019 10:07:09 +0000 (15:37 +0530)]
Code refractor and logging improvements

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I0b03ed4aae82f11c3d6dbe266120d00653b4ee1d

4 years agoCode Refractor and logging improvements 77/83377/10
Shweta Chaturvedi [Mon, 5 Aug 2019 07:12:12 +0000 (12:42 +0530)]
Code Refractor and logging improvements

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I85091cb808a35981c128d3f2194c15b17d92d85b

4 years agoOPNFLWPLUG-1084 Device operational is not getting created if 91/87091/2
Shweta Chaturvedi [Tue, 21 Jan 2020 08:38:35 +0000 (14:08 +0530)]
OPNFLWPLUG-1084 Device operational is not getting created if
device reconciliation is not enabled

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I7d72c004d71a9b7f47c2eedc8a399bfa8547dde9

4 years agoNETVIRT-1638 Modify yang modules such that it can be validated using pyang 75/86975/3
Nishchya Gupta [Thu, 16 Jan 2020 11:39:17 +0000 (17:09 +0530)]
NETVIRT-1638 Modify yang modules such that it can be validated using pyang

Fixing pyang warning and errors.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: Ic66aa4a4394b5b6132b4027e044da5b165e2912e

4 years agoMoving threadPool to a common place. 99/85199/9
Shweta Chaturvedi [Mon, 20 May 2019 11:15:29 +0000 (16:45 +0530)]
Moving threadPool to a common place.

It was creating one threadPool for each connection
and failed to close it, now using common thread pool
for all the incoming dpn connections on 6653.

Change-Id: I60372c32c9e32f65f83eb678d741a12202702d52
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoBump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9 01/87001/2
Robert Varga [Thu, 16 Jan 2020 21:13:28 +0000 (22:13 +0100)]
Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I04d1232d8bff69d15436257a2e56ff60a4e2ecf8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6 73/86373/2
Robert Varga [Thu, 12 Dec 2019 07:05:04 +0000 (08:05 +0100)]
Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I6633200cb4a9895889f8627b8fea4cd93f052974
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMerge "Failed to cancel service reconciliation, When controller become slave."
Arunprakash D [Fri, 6 Dec 2019 10:11:36 +0000 (10:11 +0000)]
Merge "Failed to cancel service reconciliation, When controller become slave."

4 years agoError log correction 02/82302/12
Shweta Chaturvedi [Tue, 26 Mar 2019 11:08:57 +0000 (16:38 +0530)]
Error log correction

Change-Id: Ie00ff4c3008aaf3fba2af4245f09c021195829c3
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoAvoid holding netty threads during resync callbacks 75/82475/7
Shweta Chaturvedi [Tue, 11 Jun 2019 03:45:45 +0000 (09:15 +0530)]
Avoid holding netty threads during resync callbacks

Change-Id: Ic6b78c053a9971b3be83ee1aa98f3ad822394c1b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoMerge "Grep not working for Karaf commands"
Arunprakash D [Mon, 2 Dec 2019 06:32:54 +0000 (06:32 +0000)]
Merge "Grep not working for Karaf commands"

4 years agoRead action throwing NPE 28/85428/2
Ning Zhang [Wed, 30 Oct 2019 10:01:57 +0000 (18:01 +0800)]
Read action throwing NPE

Issue Description:
When process alien action throwing NullPointerException:
java.lang.NullPointerException: null
        at org.opendaylight.openflowplugin.openflow.md.core.extension.ActionExtensionHelper.processAlienAction(ActionExtensionHelper.java:46)
        at org.opendaylight.openflowplugin.impl.protocol.deserialization.util.ActionUtil.readAction(ActionUtil.java:66)

Signed-off-by: Ning Zhang <zhangninglc@inspur.com>
Change-Id: I4008eef616bb08de9333442a4f21c3f21b12c65e

4 years agoMerge "OPNFLWPLUG-1078: Notify device TLS authentication failure messages"
Arunprakash D [Mon, 25 Nov 2019 12:25:12 +0000 (12:25 +0000)]
Merge "OPNFLWPLUG-1078: Notify device TLS authentication failure messages"

4 years agoMerge "OPNFLWPLUG-1075: Making Device Oper transactions atomic"
Arunprakash D [Mon, 25 Nov 2019 12:25:00 +0000 (12:25 +0000)]
Merge "OPNFLWPLUG-1075: Making Device Oper transactions atomic"

4 years agoOPNFLWPLUG-1075: Making Device Oper transactions atomic 32/85832/2
VenkataSatya Jonnadula [Mon, 18 Nov 2019 14:22:24 +0000 (19:52 +0530)]
OPNFLWPLUG-1075: Making Device Oper transactions atomic

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I7b2ed09633367e01229c7ea83063525c688821e8

4 years agoOPNFLWPLUG-1078: Notify device TLS authentication failure messages 92/85692/9
VenkataSatya Jonnadula [Thu, 7 Nov 2019 12:39:45 +0000 (18:09 +0530)]
OPNFLWPLUG-1078: Notify device TLS authentication failure messages

Signed-off-by: VenkataSatya Jonnadula <rsankar@luminanetworks.com>
Change-Id: I2d6acae15e94676b23764c62f4094123014e0093

4 years agoGrep not working for Karaf commands 85/85285/4
gobinath [Tue, 4 Sep 2018 06:45:45 +0000 (12:15 +0530)]
Grep not working for Karaf commands

SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out

This covers the changes for "southbound-cli" in openflowplugin

Change-Id: I3491068d5cb14cfac8afe42f648445fcd7f0cdc1
Signed-off-by: gobinath <gobinath@ericsson.com>
4 years agoRefactoring shownode cli 77/82477/5
Shweta Chaturvedi [Mon, 6 May 2019 10:26:41 +0000 (15:56 +0530)]
Refactoring shownode cli

Grep was not working for shownode command

SupressWarnings is used to suppress checkstyle warnings thrown upon
using System.out

Change-Id: I6b70f44f84241e71edbd13b72696f65f744f941b
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoRefactoring shownode and getallnodes cli 79/82479/5
Shweta Chaturvedi [Wed, 8 May 2019 08:01:20 +0000 (13:31 +0530)]
Refactoring shownode and getallnodes cli

Changing OFNODE to NodeId in shownode cli
and removing extra line from getallnodes cli

Change-Id: Ibe6a71047c99c41f327258d1478537c17ea8569e
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoMigrate MockitoJUnitRunner 60/84460/6
Robert Varga [Sat, 14 Sep 2019 19:04:49 +0000 (21:04 +0200)]
Migrate MockitoJUnitRunner

This migrates from org.mockito.runners.MockitoJUnitRunner to
org.mockito.junit.MockitoJUnitRunner.

Change-Id: If60b8b839393b87bd3ba4e44690a13d37dbd90d9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMerge "OPNFLWPLUG-1049 : Device connection hold time to maintain delay between consec...
Arunprakash D [Thu, 14 Nov 2019 09:48:39 +0000 (09:48 +0000)]
Merge "OPNFLWPLUG-1049 : Device connection hold time to maintain delay between consecutive connections to the controller"

4 years agoDefaults flows missing due to mastership not available 74/82474/9
D Arunprakash [Wed, 17 Apr 2019 02:59:18 +0000 (08:29 +0530)]
Defaults flows missing due to mastership not available

Change-Id: Icb53d1a504ad7f9a9129bc589a7df7e51e33fcac
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
4 years agoGetallnodes should read from cache instead of DS 42/82442/13
Gobinath [Thu, 4 Apr 2019 06:43:38 +0000 (12:13 +0530)]
Getallnodes should read from cache instead of DS

Problem
=======
 Get All DPNs query takes long time to respond, as it reads from database.

Solution
========
Fix is to provide cache based response instead of Data store read.

Change-Id: Ida535c986713b25440b86c057d94c7b6bf060ede
Signed-off-by: Gobinath <gobinath@ericsson.com>
4 years agoOPNFLWPLUG-1036 OFP deleting topology-netconf operational data 06/85106/6
Shweta Chaturvedi [Mon, 23 Sep 2019 11:37:42 +0000 (17:07 +0530)]
OPNFLWPLUG-1036 OFP deleting topology-netconf operational data

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I9b4952c4cda7d391d3d8b874b441f0c58d764e29
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
4 years agoOPNFLWPLUG-1049 : Device connection hold time to maintain delay between 18/81018/17
Somashekhar Javalagi [Wed, 20 Mar 2019 04:31:18 +0000 (10:01 +0530)]
OPNFLWPLUG-1049 : Device connection hold time to maintain delay between
consecutive connections to the controller

Device connection hold time is the least time delay a device has to
mantain between its consecutive connection attempts. If time delay
between the previous connection and the current connection is within
device connection hold time, the device will not be allowed to connect
to the controller. Default value of the device connection hold time is
0 second.

Change-Id: I15d3ca40c11d2ca20ad582bdddafb14dab449e4b
Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
4 years agoMerge "Use String(byte[], Charset)"
Arunprakash D [Wed, 13 Nov 2019 05:34:32 +0000 (05:34 +0000)]
Merge "Use String(byte[], Charset)"

4 years agoMerge "Apply some Objects.requireNonNull() modernization"
Arunprakash D [Wed, 13 Nov 2019 05:33:55 +0000 (05:33 +0000)]
Merge "Apply some Objects.requireNonNull() modernization"

4 years agoFailed to cancel service reconciliation, When controller become slave. 33/85533/2
Ning Zhang [Tue, 12 Nov 2019 09:46:27 +0000 (17:46 +0800)]
Failed to cancel service reconciliation, When controller become slave.

1.An exception may be thrown when the previous service reconciliation is cancelled,
causing the subsequent service to fail to cancel.
2.Do not use the toString() method when printing logs

Change-Id: I14f22a4b637890abb530140ba3666fda2181e24a
Signed-off-by: Ning Zhang <zhangninglc@inspur.com>
4 years agoMerge changes from topic "odlparent-6.0.1"
Robert Varga [Sun, 10 Nov 2019 11:16:21 +0000 (11:16 +0000)]
Merge changes from topic "odlparent-6.0.1"

* changes:
  Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4
  Fix meter-id overlap

4 years agoMerge "Optimize ArbitratorReconciliationManagerImpl"
Arunprakash D [Fri, 8 Nov 2019 09:55:48 +0000 (09:55 +0000)]
Merge "Optimize ArbitratorReconciliationManagerImpl"

4 years agoOptimize ArbitratorReconciliationManagerImpl 97/84897/4
Robert Varga [Thu, 3 Oct 2019 10:33:53 +0000 (12:33 +0200)]
Optimize ArbitratorReconciliationManagerImpl

Use constant objects more rather than building them over and over
again. Also use ListeningExecutorService to dispatch tasks, leading
to simpler code.

Change-Id: I9f6186336c3f244a5bcc10647b9206d716501ff8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoDo not use toString() in logging arguments 07/85407/2
Robert Varga [Mon, 28 Oct 2019 12:50:36 +0000 (13:50 +0100)]
Do not use toString() in logging arguments

Logging implementation will call toString() when it is needed,
doing it explicitly just wastes resources when logging is not
enabled -- which is typically the case for debugs.

Change-Id: I4298665ca7b8a5d65d23cfe184686cc38a4fbe55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoUse String(byte[], Charset) 45/84245/7
Robert Varga [Fri, 6 Sep 2019 07:11:08 +0000 (09:11 +0200)]
Use String(byte[], Charset)

This is pointed out by modernizer and is more efficient.

Change-Id: I8f585247f3e117f955ebb39acff205d1679bd062
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoBump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4 27/85627/5
Robert Varga [Thu, 7 Nov 2019 08:02:59 +0000 (09:02 +0100)]
Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoFix meter-id overlap 99/85599/2
Robert Varga [Sun, 20 Oct 2019 13:05:24 +0000 (15:05 +0200)]
Fix meter-id overlap

Adding meter-id leaf in two cases is not valid YANG, fix that up.

Change-Id: Icbdf91015d28061548bac3aa0f1f94e1668aaa91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d9f901335a6fd2ff660545d4e85497fd64f7d533)

4 years agoApply some Objects.requireNonNull() modernization 30/85430/3
Robert Varga [Wed, 30 Oct 2019 10:19:17 +0000 (11:19 +0100)]
Apply some Objects.requireNonNull() modernization

This cleans up moderinization warnings reported for
 openflow-protocol-{api,impl} and simple-client.

Change-Id: Iec311574b090fd79242ce00ad690ff79333b940a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMerge "OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch"
Arunprakash D [Thu, 7 Nov 2019 06:58:06 +0000 (06:58 +0000)]
Merge "OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch"

4 years agoMerge "Eliminate {infra,service}utils.version"
Arunprakash D [Thu, 7 Nov 2019 05:57:36 +0000 (05:57 +0000)]
Merge "Eliminate {infra,service}utils.version"

4 years agoOPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch 80/85380/3
Somashekhar Javalagi [Fri, 25 Oct 2019 06:01:46 +0000 (11:31 +0530)]
OPNFLWPLUG-1077 : Bundle resync is not able to push groups to switch

As buckets are put into the SingletonImmutableList, sort on
SingletonImmutableList is not supported. yangtools is converting
yang list into SingletonImmutableList. Copying same into
ArrayList and sorting same.

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I5d7714c6b58421e14c535e5c3f42d81d0503bb2c

4 years agoMerge "Remove nagasena dependency declaration"
Arunprakash D [Thu, 7 Nov 2019 05:48:56 +0000 (05:48 +0000)]
Merge "Remove nagasena dependency declaration"

4 years agoMerge "Make applications/pom.xml an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:48:23 +0000 (05:48 +0000)]
Merge "Make applications/pom.xml an aggregator"

4 years agoMerge "Turn libraries/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:47:13 +0000 (05:47 +0000)]
Merge "Turn libraries/pom.xml into an aggregator"

4 years agoMerge "Turn samples/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:46:52 +0000 (05:46 +0000)]
Merge "Turn samples/pom.xml into an aggregator"

4 years agoMerge "Turn extension/pom.xml into an aggregator"
Arunprakash D [Thu, 7 Nov 2019 05:45:49 +0000 (05:45 +0000)]
Merge "Turn extension/pom.xml into an aggregator"

4 years agoMerge "Make model/pom.xml inherit from odlparent-lite"
Arunprakash D [Thu, 7 Nov 2019 05:45:32 +0000 (05:45 +0000)]
Merge "Make model/pom.xml inherit from odlparent-lite"

4 years agoEliminate {infra,service}utils.version 90/85390/2
Robert Varga [Fri, 25 Oct 2019 12:31:59 +0000 (14:31 +0200)]
Eliminate {infra,service}utils.version

Rather than going through properties, use foo-artifacts to get
proper version declarations into dependencyManagement. This cleans
up version management a bit.

Change-Id: Ib2cf7bdd44235a9659c07bfd75ee29de29e3f863
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoRemove nagasena dependency declaration 89/85389/2
Robert Varga [Fri, 25 Oct 2019 12:23:15 +0000 (14:23 +0200)]
Remove nagasena dependency declaration

This dependency was used by netconf a long time ago, we no longer
use it (and properly declare libraries). Remove the declaration.

Change-Id: If35e53803fdf085d1db2ed8182694314ed24b6b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
4 years agoMake applications/pom.xml an aggregator 88/85388/2
Robert Varga [Fri, 25 Oct 2019 12:18:29 +0000 (14:18 +0200)]
Make applications/pom.xml an aggregator

This really is just an aggregator, make sure it inherits from
odlparent-lite and adjust its users to inherit from ofp-parent.
Shaves ~29 seconds from build time.

Change-Id: Id2cd32ed36a1bf40ff279cef1d9efced1649047b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>