Tomas Slusny [Mon, 19 Jun 2017 12:45:35 +0000 (14:45 +0200)]
Encapsulate OpenFlowPlugin configuration
- Stop sending configuration to OpenFlow managers in long constructors
and send just aggregated configuration in one class
- Add ability to register configuration listener to configuration
service
- Separate configuration service from OpenFlowPluginProviderImpl
- Fix FRM configuration breaking OpenFlowPlugin configuration by trying
to load configuration from openflowplugin.cfg directly, what is only
accesible to main OpenFlowPlugin project by creating configuration
service and passing it to FRM
- Add missing 'disable-reconciliation' flag to FRM yang config, and use
default values from YANG file for FRM configuration
Resolves: bug 8705
Change-Id: I791925bb1964c9eb5a9f1db77fcc25f6425f053f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 26 Jun 2017 07:23:37 +0000 (07:23 +0000)]
Merge "Report (TCP) port number for switches"
Tomas Slusny [Thu, 25 May 2017 13:26:44 +0000 (15:26 +0200)]
Fix context chain closing
- Close and create EOS registration correctly when closing context
chain holder and creating context chain holder.
- Cancel running scheduled task on context chain holder termination
- Always remove device from DS when we was not able to propagate roles,
not only when we have this device already in context chain map
- Add toleration for adding context chains to queue
- Wait for registration of RPC services before fully granting mastership
for context chain
- Close transaction chain manager on device context close
- Remove unnecessary auxiliary connection gathering in device context
(because this was moved to context chain)
- Fix closing of TxChain when DeviceContext is closed when activating tx
chain manager but not enabling submit transaction (do not try to submit
data)
- Unregister RPC registrations on RpcContext close
- Do not close ClusterSingletonServiceRegistration during
ClusterSingletonService initialization, to prevent freeze of
ClusterSingletonServiceGroup, send it to separate thread
- Prevent propagating of connection closed event twice (add checks for
RIP connection state)
- Fix ignored tests
- Remove getter for table statistics boolean from DeviceContext and just
send it to DeviceInitializer
- Close all RPC contexts when RPC manager is closed
- Do not reschedule statistics one more time when context chain is
closed
Resolves: bug 8668
Change-Id: Ifa8c492486c17a73eccd760fc610a435ef6a42ed
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Wed, 17 May 2017 05:23:39 +0000 (07:23 +0200)]
Fix "stale" state after controller disconnected.
See also: Bug 8411
Change-Id: If5bf24f34a87ef0a7d5514b1c655a42508889724
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 09:33:10 +0000 (11:33 +0200)]
Report (TCP) port number for switches
Write also port number to datastore for OpenFlow switches.
Resolves: bug 2188
Change-Id: I15054b55907b4f15b1567b21f5fa2d35ad416579
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 15:53:13 +0000 (17:53 +0200)]
Remove config subsystem remains
- Remove what was left from config subsystem from project, as everything
was moved to Blueprint already.
- Cleanup artifacts POM, remove references to config subsystem config
files
Resolves: bug 8728
Change-Id: Ic6adcbc333e816aa15b546e44536d23c8ef4125b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Thu, 22 Jun 2017 08:18:15 +0000 (10:18 +0200)]
Bump to odlparent 2.0.0
- removed feature with dlux dependency
Change-Id: I14db1f6d17624ba890bc1ed6491dfc91876d6a40
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 22 Jun 2017 07:04:32 +0000 (07:04 +0000)]
Merge "Fix checkstyle API."
Tomas Slusny [Tue, 20 Jun 2017 10:44:44 +0000 (12:44 +0200)]
Move Nicira extensions to blueprint
- Add blueprint xmls for OpenFlowPlugin nicira extensions
- Remove CSS-related files from nicira extensions projects
- Stop copying CSS-related xmls during feature installations
Resolves: bug 8718
Change-Id: I115e59b87620f9be60ea9d1d48c9dccbc9c03031
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Tue, 20 Jun 2017 12:55:06 +0000 (14:55 +0200)]
Fix checkstyle API.
Change-Id: Ia25e794c95722f9ff9bf60393bbd18d803296581
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 19 Jun 2017 08:35:02 +0000 (08:35 +0000)]
Merge "Bug 8647: remove odl-dlux-core as artifact POM"
Jozef Bacigal [Mon, 19 Jun 2017 07:23:30 +0000 (07:23 +0000)]
Merge "Ensure that statistics gathering is terminated"
Stephen Kitt [Fri, 9 Jun 2017 10:11:12 +0000 (12:11 +0200)]
Bug 8647: remove odl-dlux-core as artifact POM
odl-dlux-core is used in dependency management as an artifact POM, but
it isn’t. Removing the declaration is fine since the actual dlux
dependencies specify the version to use.
Change-Id: I83598feb8175d674616a3a3f25c0d52ca1739664
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Tomas Slusny [Thu, 15 Jun 2017 13:18:39 +0000 (13:18 +0000)]
Merge "Fix connection when slave role request is unsupported"
Tomas Slusny [Thu, 15 Jun 2017 13:15:53 +0000 (13:15 +0000)]
Merge "Fix port update"
Tomas Slusny [Thu, 15 Jun 2017 13:04:30 +0000 (13:04 +0000)]
Merge "Fix 'INPORT' keyword in port field"
miroslav.macko [Wed, 14 Jun 2017 12:06:30 +0000 (14:06 +0200)]
Fix port update
- Update yang models. Add grouping common port with mask.
- Use config mask in the PortConvertor and PortMessageSerializer.
- Update unit tests.
Resolves: bug 4747
Change-Id: If558fea34f86c026ca45ba2853107c2cd82c7f50
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Thu, 8 Jun 2017 13:29:56 +0000 (15:29 +0200)]
Fix connection when slave role request is unsupported
- Allow the switch connection when OFPRRFC_UNSUP is received
- Set feature exception for getGenerationIdFromDevice RPC error
- Add unit test
Resolves: bug 7664
Change-Id: If8d7d045fb516f55346333cc7e60d0ccb2135efd
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Tomas Slusny [Thu, 15 Jun 2017 12:16:22 +0000 (12:16 +0000)]
Merge "Fix SwitchIdleEvent echo request-reply xid"
Jozef Bacigal [Fri, 9 Jun 2017 10:30:27 +0000 (12:30 +0200)]
Fix 'INPORT' keyword in port field
- also fix NPE in serialization by using wrong port number
Enumeration from opeflow java yang files is correct used keyword 'IN_PORT'.
Openflowplugin with the wrong translation (getString instead of getName) used the
keyword 'INPORT'. This fix use the correct name from enumeration but allow use
the legacy 'INPORT' keyword for next release.
Also prevent to throw NPE by using wrong keyword in port field.
Change-Id: If8b3d301d73169fd158a546a233928ab0c65d1c3
Fix: Bug 2095
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 16 May 2017 08:12:18 +0000 (10:12 +0200)]
Ensure that statistics gathering is terminated
Store current statistics gathering future for cancellation instead of
settable future, so we can cancel it when we need to (there is no point
in cancelling settable future other than preventing more statistics
running, but current in-progress statistics gathering will still try
to finish).
Cancel statistics gathering also when become slave.
Resolves: bug 8635
Change-Id: If221a34901b08f8923ae5321a51abd00f4b047b1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 14 Jun 2017 14:15:09 +0000 (16:15 +0200)]
Add Karaf 4 distribution, fix initial config
- Add Karaf 4 distribution for testing to distribution/karaf4.
This distribution will replace current distribution/karaf
after support for Karaf 3 will be removed.
- Fix using Karaf 3 shell commands dependencies, and use
correct ones based on Karaf version specified in distribution
- Fix copying of initial configuration file (wrong path of config
.xml, was `src/main/features/features.xml` but corrected it to
`src/main/feature/feature.xml`)
Resolves: bug 8693
Change-Id: I9d65f9a369e1f7750724a432e37cef944f9dcfb4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Wed, 14 Jun 2017 14:24:33 +0000 (14:24 +0000)]
Merge "Migrate to odlparent 1.9.0"
Thanh Ha [Tue, 13 Jun 2017 20:26:51 +0000 (16:26 -0400)]
Migrate to odlparent 1.9.0
Change-Id: I9d504715f4d75d636ffb9fb1b338221cd836927b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
David Suarez [Fri, 2 Jun 2017 16:23:48 +0000 (18:23 +0200)]
BUG-8607: Replace logger and log by LOG
Replace logger and log by LOG to follow the
OpenDaylight recommendations [1].
[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices
Change-Id: I77ef621927ba05417736d24c18c6659c7f504917
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Jozef Bacigal [Tue, 13 Jun 2017 06:34:19 +0000 (08:34 +0200)]
Fix SwitchIdleEvent echo request-reply xid
- changed static Long to static Xid
Change-Id: Ib6540078c8143ce6fbe53a4cf379a0b285d53a1e
Solves: Bug-4422
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Mon, 12 Jun 2017 13:26:55 +0000 (13:26 +0000)]
Merge "Fix onSwitchIdleEvent echo request-reply xid"
Jozef Bacigal [Mon, 12 Jun 2017 07:43:41 +0000 (07:43 +0000)]
Merge "HeaderDeserializer and HeaderSerializer for codecs"
Jozef Bacigal [Mon, 5 Jun 2017 11:08:27 +0000 (13:08 +0200)]
Fix onSwitchIdleEvent echo request-reply xid
Solves: Bug-4422
Change-Id: I879e9e6aaf560da486767a68a7e2f015db5a7d95
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 1 Jun 2017 13:53:30 +0000 (15:53 +0200)]
HeaderDeserializer and HeaderSerializer for codecs
Implement HeaderDeserializer and HeaderSerializer for nicira
match codecs.
Resolves: bug 4862
Change-Id: Ia3dbbf622460ecfa3b6a2c48e94e432294a08c0e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 5 Jun 2017 15:47:51 +0000 (17:47 +0200)]
Close OpenFlowPluginProvider during shutdown
- Call close method on OpenFlowPluginProvider during shutdown
- Close all created managers, thread pool and timer during shutdown
- Remove unused notification service
- Remove warning when unknown property is loaded on start (because of
recent FRM changes)
Resolves: bug 8598
Change-Id: Ib5a4f84ea1fa0c957b90ef216346eb85aec81ad0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Thanh Ha [Fri, 9 Jun 2017 23:09:43 +0000 (19:09 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Change-Id: I7e90ac5f5e9cbe5e2304f3c8711101547a740b98
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Jozef Bacigal [Mon, 5 Jun 2017 14:50:47 +0000 (16:50 +0200)]
Stop reschedule stat. after device disconnected
Resolves: Bug-7940
Change-Id: Ida42676ec5bf6f06fb47837c0532878976eed442
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Fri, 2 Jun 2017 10:29:55 +0000 (12:29 +0200)]
Fix sample-consumer compilation error
Remove deprecated DataBrokerService that was probably removed from
sample-consumer code.
Change-Id: Ief90c7a5ddca7dd08de390ccf6dedc98c20078c1
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Thu, 1 Jun 2017 11:07:09 +0000 (13:07 +0200)]
Fix auxiliary connections
See also: Bug-6755
Change-Id: If4964c1a0f07bfdd8104c7254f4b4484fd42d81e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 1 Jun 2017 11:16:32 +0000 (11:16 +0000)]
Merge "Improve flow collection"
Tomas Slusny [Thu, 1 Jun 2017 08:10:28 +0000 (08:10 +0000)]
Merge "Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation"
Jozef Bacigal [Thu, 1 Jun 2017 08:08:31 +0000 (08:08 +0000)]
Merge "Make create-parents in bulk-o-matic not required"
Jozef Bacigal [Thu, 1 Jun 2017 08:05:50 +0000 (08:05 +0000)]
Merge "Add missing convertors for OF1.0 actions"
Anil Vishnoi [Wed, 17 May 2017 21:46:19 +0000 (14:46 -0700)]
Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation
Resolves: Bug 8497, Bug 7957
Change-Id: Ib798d9282f019e0c8dd520c15d8794678ee9af3d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Tomas Slusny [Tue, 30 May 2017 07:40:54 +0000 (09:40 +0200)]
Make create-parents in bulk-o-matic not required
To make bulk-o-matic input working like before, make create-parents
to default to true to use original functionality with same input
as it was before patch that introduced this new flag.
Change-Id: I89ee7d299f0ade62bd6859209c537528e5728aa7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 15 Mar 2017 17:23:22 +0000 (18:23 +0100)]
Improve flow collection
- Delete all known flows synchronously
- Add boolean isTransactionsEnabled to TxFacade to determine if it was
initialized and initial submit was called
- Improve deletion of flows during on the fly statistics gathering (now,
each gathering have 3 states, INITIALIZATION, WORKING and TERMINATION
and behaves according to that)
- Fix possibility of statistics collection freeze when error occurs
during OF Java to OF Plugin model translation while gathering
statistics on the fly
Resolves: bug 7501
Change-Id: I74843d4536215c192ac43964634502430da1aa9a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 26 May 2017 07:22:40 +0000 (07:22 +0000)]
Merge "Bug 8253: Set-Field can not accept vendor extension fields."
Li Guosheng [Mon, 8 May 2017 02:58:31 +0000 (10:58 +0800)]
Bug 8253: Set-Field can not accept vendor extension fields.
The various Set-Field actions are identified by their field type
which defined in OpenFlow Specification. It will be failed if we
pass a vendor extension field to Set-Field, that means Set-Field
can not accept those vendor extension fields. There are products
that hope Set-Field can accept those vendor extension fields, so
it will make sense to make Set-Field extensible.
Change-Id: Id25456d2b9008ec260ce81d3a459bdc471a69e49
Signed-off-by: Li guosheng <li.guosheng6@zte.com.cn>
Anil Vishnoi [Thu, 25 May 2017 18:17:25 +0000 (18:17 +0000)]
Merge "Bug 8535: Fix IPv6 OXMHeader Mask issue"
Anil Vishnoi [Thu, 25 May 2017 18:16:40 +0000 (18:16 +0000)]
Merge "Add Nicira extension support for matching IPv6 Src/Dst"
Tomas Slusny [Tue, 23 May 2017 12:05:43 +0000 (14:05 +0200)]
Add missing convertors for OF1.0 actions
- SetDlSrc
- SetDlDst
- SetNwSrc
- SetNwDst
- SetNwTos
- SetTpSrc
- SetTpDst
- SetVlanId
- SetVlanPcp
Resolves: bug 8527
Change-Id: I9c7c97804d077e1089fe92b3465c826a43da6a33
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Wed, 24 May 2017 01:04:26 +0000 (01:04 +0000)]
Merge "Adding Reason Attribute to FlowCapableNodeConnector"
Sridhar Gaddam [Tue, 23 May 2017 12:57:09 +0000 (18:27 +0530)]
Bug 8535: Fix IPv6 OXMHeader Mask issue
When programming an OVS flow to set an ipv6_src/dest as
an action field (i.e., set_field:2001::1->ipv6_src), the
current implementation is not checking the Mask and is
including the Mask (even for a full ipv6 address) in the
OXM header. Because of this, switch is rejecting the flow
with the following error.
"decode error: OFPBAC_BAD_SET_MASK. OXM header 0:32768:26:1:32
includes mask but masked OXMs are not allowed here"
This patch addresses this issue by checking the prefix and
including the prefix only if applicable.
Change-Id: Ieffdc7f0e74e9418156171d85a28c24dd336527c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Michael Vorburger [Tue, 23 May 2017 12:00:03 +0000 (14:00 +0200)]
Replace target/ by ${project.build.directory}/ for target-ide/
This makes openflowjava work e.g. in Eclipse IDE out-of-the-box (using
https://github.com/vorburger/opendaylight-eclipse-setup configuration),
without any red (after a "mvn -Pide clean generate-sources").
This is how all other projects do it; I just copy/pasted from elsewhere.
Change-Id: I908357974a930d249f3c37d3cb9591dbffb8f5bb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Wed, 10 May 2017 22:48:27 +0000 (00:48 +0200)]
Remove <prerequisites> from pom.xml to avoid WARNING
[WARNING] The project ... uses prerequisites which is only intended for
maven-plugin projects but not for non maven-plugin projects. For such
purposes you should use the maven-enforcer-plugin. See
https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
This is already done in odlparent.
Change-Id: Iaefcd3729d5600aef49f3c3c653676ad962d9838
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Jozef Bacigal [Thu, 18 May 2017 11:43:10 +0000 (11:43 +0000)]
Merge "Fix logging of exception in HandshakeListenerImpl"
GauravBhagwani [Tue, 7 Feb 2017 08:29:25 +0000 (13:59 +0530)]
Adding Reason Attribute to FlowCapableNodeConnector
-The reason attribute is added to the FlowCapableNodeConnector Yang
Modelling.
-The PortStatus contains reason when notification comes from Switch such
as ADD, UPDATE, DELETE.
-This reason flied will help in distinguishing between different
PortStatusMessages
-Also changed TestCase File to include Reason for test cases
Change-Id: If61fc1ba0afbe56cbf5382ab3997c67166989819
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
Jozef Bacigal [Wed, 17 May 2017 07:51:46 +0000 (09:51 +0200)]
Remove lifecycle service from tx chain manager
Change-Id: I6e9f1d7dbdfbdcca5cd52c368985ba7d37310a74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 16 May 2017 15:09:29 +0000 (17:09 +0200)]
Fix logging of exception in HandshakeListenerImpl
Exception was not logged, so in case initial processing failed and
thrown exception, there was no exception actually shown in log. To
properly log exception, it needs to be either passed as second parameter
or inserted into message via logger string interpolation ({}).
Change-Id: Ic76f6d20588e34837994b50509603d994009b705
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 24 Apr 2017 07:15:36 +0000 (09:15 +0200)]
Write port statistics when needed
When we receive port statistics reply, sometimes in OF 1.0 we do not
have parent node written to datastore, so now when OpenFlow version is
1.0 then write those port statistics with parents if needed.
Replace gathering missing port statuses with PORT_DESC with registry
that will collect missed port statuses when on MASTER.
Resolves: bug 8239, bug 6908
Change-Id: I47468cb37fa59a68cfa89efeb7e5c4191e07039d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Mon, 15 May 2017 22:56:51 +0000 (22:56 +0000)]
Merge "Remove device without master from DS."
Anil Vishnoi [Mon, 15 May 2017 22:52:59 +0000 (22:52 +0000)]
Merge "Add timeout for device initialization"
Tomas Slusny [Mon, 15 May 2017 13:22:57 +0000 (13:22 +0000)]
Merge "Bug 8408 - Deserialization exception in logs when NAT flows are added."
Aswin Suryanarayanan [Tue, 9 May 2017 14:41:42 +0000 (20:11 +0530)]
Bug 8408 - Deserialization exception in logs when NAT flows are added.
The code is modified to fix the issues with multiple CT actions.
The logic skip padded bit is added during Deserialization
Change-Id: Ic5574f0a877228d966ca92eacfa22c751fa14b3c
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Tomas Slusny [Thu, 11 May 2017 08:57:09 +0000 (10:57 +0200)]
Add timeout for device initialization
Sometimes during device initialization, switch starts ignoring all
messages from plugin, and so we ended up with Future that waited
indefinitely for switch response until Karaf was restarted.
Add timeout that will prevent happening of above issue.
See also: bug 8401
Change-Id: I90c6c8b53f6a6e879b6d9f93c259a2cbf09f71d3
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Sun, 14 May 2017 08:51:48 +0000 (08:51 +0000)]
Merge "Though shall not use org.eclipse.tycho's osgi.. you don't even need it!"
Michael Vorburger [Thu, 9 Feb 2017 00:24:41 +0000 (01:24 +0100)]
Though shall not use org.eclipse.tycho's osgi.. you don't even need it!
see https://git.opendaylight.org/gerrit/#/c/51592/
see https://git.opendaylight.org/gerrit/#/c/51520/
There are 2 remaining use of org.eclipse.tycho in openflowplugin's
drop-test and test-provider, something related to console commands...
could we ask you if you would mind to change that to use
the Karaf Console API instead? Or delete those? ;)
I'll like to block use of dependency tycho in odlparent ASAP.
Change-Id: Ifccbd7f6ec463487e83aa546701cdffd1c7accb4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sridhar Gaddam [Fri, 12 May 2017 15:29:07 +0000 (20:59 +0530)]
Add Nicira extension support for matching IPv6 Src/Dst
This patch implements the necessary support for programming a reg_move action
(i.e., move:NXM_NX_IPV6_SRC[]->NXM_NX_IPV6_DST[]) with IPv6 source/destination
headers. It will be used while constructing OVS flows that auto-respond to ping6
requests addressed to a router-interface.
Change-Id: I64757f55ed1d30a12217c4a5aadaa3f56572ab0e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Jozef Bacigal [Fri, 12 May 2017 08:41:37 +0000 (10:41 +0200)]
Fix queue and xid issue
Change-Id: Idef52a9243d9b2b9ac7028386422f0acc580c07d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 11 May 2017 11:10:25 +0000 (13:10 +0200)]
Fix no reserved xid
Change-Id: I153df3f1d3df895e2780a77dd6ed04e43bbc9599
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 11 May 2017 13:46:30 +0000 (13:46 +0000)]
Merge "Remove unused method"
Jozef Bacigal [Thu, 11 May 2017 11:32:19 +0000 (13:32 +0200)]
Remove unused method
Change-Id: I02e3d48f2ccca528995b18cb159700ab08449862
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Vishnoi [Wed, 10 May 2017 18:24:46 +0000 (18:24 +0000)]
Merge "Bug 8293: Add table writer to bulk-o-matic"
Tomas Slusny [Wed, 10 May 2017 14:12:48 +0000 (16:12 +0200)]
Handle missing converters for match extensions
Prevent throwing NullPointerException when converter for match
entry extension is missing, instead throw warning and allow process
to continue (like it was before single-layer-serialization).
See also: bug 8401
Change-Id: If006eef401da4b9bf61911c183e76876fac0dfcf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 5 May 2017 15:05:36 +0000 (15:05 +0000)]
Merge "Remove unnecessary method from abstract class."
Jozef Bacigal [Fri, 5 May 2017 12:55:39 +0000 (14:55 +0200)]
Remove unnecessary method from abstract class.
Change-Id: I23de0d1973418854c6fce039f6e694ed13c1d04b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Fri, 10 Feb 2017 13:23:43 +0000 (14:23 +0100)]
Change sal bundle yang model
- Put messages to message container
Change-Id: Ie86d70bf070ca16659f02ba536655c6e6f1682af
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Wed, 8 Feb 2017 17:01:20 +0000 (18:01 +0100)]
Update BundleAddMessageConverter
- Update serialization
- Set Xid and Node
Change-Id: Ie7f9a0d99dc348c71212a9cc0a53893f29ff971e
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 7 Feb 2017 08:21:20 +0000 (09:21 +0100)]
Change yang models due to errors
- Added container for cases where was duplicate declaration of fields.
- Renamed cases to not to have duplicate name of interfaces.
- Renamed wrong spelled "Convertor" to "Converter".
- Fixed tests. (Ignored, fixed in following patches)
- Added nbactions.xml to gitignore (netbeans help file)
Change-Id: Ie268f9d8a697097e3892196e26442c917026b993
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Faiz Ilahi Kothari [Thu, 9 Feb 2017 05:57:43 +0000 (11:27 +0530)]
Bug 8293: Add table writer to bulk-o-matic
* Table writer is introduced for Pre-Leader Role test in which
table is added first and flows next. We want the ability to
create tables separately and not to be created automatically
on addition of flows.
* Modify flow-test rpc to accomodate a boolean: create-parents.
This allows us to prevent addition of flows in case the tables
are missing.
* Fix import ordering
Change-Id: Ic3fe4764631d9cbc7550ad3d7d926debb3ca6977
Signed-off-by: Faiz Ilahi Kothari <faiz.ilahi.k.kothari@ericsson.com>
Jozef Bacigal [Tue, 24 Jan 2017 14:32:41 +0000 (15:32 +0100)]
Add BundleControl converter from OFJ
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I57709f7d089e651525ddc65a4a51a68f39f38772
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 14:09:45 +0000 (15:09 +0100)]
Update bundle extension tests
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If4b197b8ecf334286d4bb01748b8b622c2112182
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:47:09 +0000 (13:47 +0100)]
Add BundleAddMessageConvertor
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If6bc0a657c04e95454a3576a5707ddd00a16b38e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:42:10 +0000 (13:42 +0100)]
Add BundleControl converter
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I850e5119bd4ee7d73222dd90bf1e28e4a19916a8
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:45:36 +0000 (10:45 +0100)]
Add simple SalBundleService
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I1457d7988b68a8eb74928088e253fc5f523d29c4
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:35:46 +0000 (10:35 +0100)]
Add Bundle and Error (ONF-extension) deserializers
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I583e15333df3811adf47ba174b4f593946be7d39
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:56:34 +0000 (08:56 +0100)]
Add Bundle messages serialzers
- moved from openflowjava
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I36e7600f15d1a5d345e62cd4f42c0f0f999ae588
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:54:35 +0000 (08:54 +0100)]
Add model for ONF bundle extension
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I17e22dadb910ed76ba6ccfae711a81fd0856762f
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 23 Jan 2017 13:30:48 +0000 (14:30 +0100)]
Add ONF extension provider and wire via blueprint w/OFP
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I49d08c82d4b973b888939aff2a4cd110289c9fe3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 28 Apr 2017 07:42:15 +0000 (09:42 +0200)]
Remove device without master from DS.
See also: Bug-6459
Change-Id: I6d27681b60a75df173a49742885c75c16d691b26
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 11 Apr 2017 15:52:16 +0000 (17:52 +0200)]
Fix no match serialization
This patch ensures that even when match in flow is null, at least empty
match is sent to device.
Change-Id: If77c59b889e45698da4b96f098088cdbdf4698ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 25 Apr 2017 08:26:50 +0000 (08:26 +0000)]
Merge "Bug 8217: Set error information into direct statistics RPC result."
Tomas Slusny [Tue, 25 Apr 2017 07:47:20 +0000 (07:47 +0000)]
Merge "Bug 8223: Fixed incorrect enable-flow-removed-notification check."
Tomas Slusny [Mon, 24 Apr 2017 10:23:59 +0000 (12:23 +0200)]
Prevent changing single-layer-serialization on fly
Prevent changing use-single-layer-serialization config
parameter on the fly, allow it only during initialization.
Resolves: bug 8278
Change-Id: Idfd2f7aa99fdf330bc32615431b4378209c83fda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 24 Apr 2017 07:07:30 +0000 (07:07 +0000)]
Merge "Improve property-based configuration"
Tomas Slusny [Tue, 21 Mar 2017 18:17:22 +0000 (19:17 +0100)]
Improve property-based configuration
- Add OpenFlowPluginConfigurationService. This service can control
updating of OpenFlowPlugin configuration (skip-table-features etc.)
in initialization phase and also on the fly.
- Comment out default settings in org.opendaylight.openflowplugin.cfg
because with all default values set in that file, we are ignoring
values specified in openflow-provider-config.yang.
- Add support for missing configuration values from
openflow-provider-config.yang to OpenFlowPluginConfigurationService
- Remove changeable configuration values that was passed to some
OpenFlowPlugin class implementations to both constructors and setters
from constructors to prevent code duplicity and to simplify code a bit
Now, when feature is installed,
default values are taken from openflow-provider-config.yang, then we
check if we have org.opendaylight.openflowplugin.cfg file in karaf/etc/
(blueprint will do this for us) and try to read it as map. Then we will
pass this map to update method, that will iterate over this map and
parse it's keys and values and calls appropriate update methods in
OpenflowPluginProviderImpl based on key
(f.e skip-table-features will call
OpenflowPluginProviderImpl#updateSkipTableFeatures).
When org.opendaylight.openflowplugin.cfg file is changed, we receive
notification about it in form of
OpenFlowPluginConfigurationService#update method call, and we will
repeat same procedure as during initialization (parse map passed as
argument to this method and update configuration).
Resolves: bug 7218
Change-Id: Ida986f7dfffe55a90ddb6f354f0addf56c3c4b90
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Thu, 13 Apr 2017 11:12:19 +0000 (20:12 +0900)]
Bug 8223: Fixed incorrect enable-flow-removed-notification check.
flow-removed notification needs to be published if
DeviceManager.isFlowRemovedNotificationOn() returns true.
Change-Id: I10c025f11e14670303b70bf31d3a9cefa5a676ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit
644f1bbd99d4fd949800fb3167d11d4ce968c950)
Tomas Slusny [Mon, 27 Mar 2017 14:59:24 +0000 (16:59 +0200)]
Ignore early port status msg and process it later
When port status message arrives before we got MASTER role,
ignore it. Then, after receiving mastership collect PORT_DESC statistics
again to make sure we do not missed any port status messages in process
Resolves: bug 6908
Change-Id: I01285ed4880533f48bf90fa7c6a4ca2c7d3a210f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Wed, 12 Apr 2017 14:01:23 +0000 (23:01 +0900)]
Bug 8217: Set error information into direct statistics RPC result.
Change-Id: I3fdf51b94bf95afefa47dddea37a82b8f139af95
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Anil Belur [Tue, 11 Apr 2017 01:45:52 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I69b8fcbaf59487fae8564634aebfb52c6951101a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Tomas Slusny [Mon, 13 Mar 2017 13:27:55 +0000 (14:27 +0100)]
Update multipart request services for single layer
Update all single layer services that was sending OpenFlowJava
multipart requests to send OpenFlowPlugin multipart requests
instead to avoid translations.
Remove failing tests from NodeConnectorRefToPortTranslatorTest. These
tests are not needed anymore, since now JUnit auto-handles @NonNull
annotations.
See also: bug 6915
Change-Id: I427a6148e67d61080a85de5c304f478df0e26682
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 1 Mar 2017 15:38:29 +0000 (16:38 +0100)]
Add multipart request message serializers
- Add serializers for multipart request and it's subtypes
- Add YANG models for multipart request and it's subtypes
See also: bug 6915
Change-Id: I465c23a6fc3bea0cf944bbe8e6f75e17833d4449
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Tue, 4 Apr 2017 12:00:23 +0000 (14:00 +0200)]
Add timer and auxiliary connection
- added time to check if all devices are master or slave.
- auxiliary connection is no more dropped but stored.
Change-Id: I720f90f70631de0fddea8eaeaa39c2186c90db20
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 3 Apr 2017 09:56:43 +0000 (11:56 +0200)]
Fix startup.
Change-Id: Ia3488423f70b045c766692205c947e078af9a8f7
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>