BUG-3419 : fix shutdown of modules

Turns out each extension when it's closed calls
stop() on their Activators. This nulls registration
list. But when the Activator itself is shut down,
it also calls its stop() method invoking an
IllegalStateException.

Change-Id: I3887cc687489e9e441224265f0e85baf6928aaee
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2453 Replace enums in initial configs with proper value

Proper value means value defined in yang, not in generated binding classes.

Change-Id: I1f9175a4d472b92c4795d8200e60e9ca6c0ad447
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
(cherry picked from commit ac987bdab12b1ed1657179570542c0d6aa15eb33)

Sonar method complexity issue

Method: checkDependencies
Extracted two for cycles into another private methods.

Change-Id: Ie9e5e9cfce85a2280c09d7fd3cb7a70bb4751b90
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar method complexity issue

Method: validateMonitoringMetrics
Extracted switch into private method insertObject

Change-Id: I3d129957dc245e4e3a117f10c0177cb1a1be8f99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Sonar issue fix

Simplified methods in:
- Stateful07TopologySessionListener.java
-- onMessage method. Code extraction into private methods. Complexity decreased
-- ensureLspOperational method. Extracted last-return's code. Complexity decreased

Change-Id: I34e9826f95ec0e095e63b426c6aa8a4e07dc0068
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

Update of Unit test

Added tests for updating values of different classes.
(note: MultiRegistry.java from 85% to 96.7% coverage)

Change-Id: I4316ec15d8dc3551e200c204aa1e52741136cec8
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3186 : fixed MPReachCodec not found

Turns out, one import problem can cause the whole
codec hierarchy to fail. Also make sure we can
troubleshoot such bugs easier in the future by
catching Exceptions from codec creation per RIB.

Change-Id: I675b70f6b8079d2a5a2eb7ded64be76d16f9e468
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Sonar issue fix

Extracted parts of code into another private methods in order to
decrease complexity.

Change-Id: I53363643ceecd70579f82dc2a829e043fcaf8d41
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

fixed sonar issue

Extracted parts of serializeCapability method into private
methods to decrease method complexity.

Change-Id: I6b0810e48b525f7fa8b6f00ec2be2aee2aab6a25
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>

BUG-3225 : fix NPE

Import policy requested by Effective RIB has yet to be put in policy database,
therefore the NPE occurred. Switched off listening for peer-role changes itself,
the change is now checked in Effective RIB. Since we are listening to a different
subtree, the handling in Effective RIB needed to be changed accordingly.

Change-Id: I0df6cf2234a27d99445af07dd47c9039a0418cb4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 40aa438dc57d452f866fcf6c32b59a8a2d9f14e1)

BUG-3252 : added a check for augmented transitive attributes.

Change-Id: I6e8636cec435da937ddabd78f7f5bcaa5edb2a89
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-3043 : fix for transaction closed exception

When the peer got session down, transaction chain
was closed. This caused problems, when the peer
reconnected.
Moved closing of transaction chaining to when the
peer closes.

Change-Id: I7da35d7e0a2238f38b5a549e9848b418d467d27a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 3198 - Extract BGP messages content into groupings

- updated notification messages to be reusable

Change-Id: I0045ba18b618e7b3c4b441ae6ef6074acc25f1c5
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 3117 - Capability Parameter Parse Issue

Change-Id: Iaa4e142b3387dc89778aba80fe8af34d72338bb7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-3074 : set initial uptodate state in LocRib to true

Uptodate state was missing entirely from tables that
were not advertised by peer. This commit inserts the field
and sets it to true to inform the user, that there won't
be any more routes added to the table.

Change-Id: I539d3a9df388c476748c5009d945f7ad2eef792e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed some sonar issues:

- magic numbers

Change-Id: I12ab7953d671a63807716940c2e54462fca82a7a
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Refactored anonymous classes that were too long.

Extracted parts of long methods to separate private
method.

Change-Id: I29db5e2e940385f735a037434564b0069da9a2d6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Deprecate stateful02 topology provider.

In addition to deprecating stateful02 module.

Change-Id: I184876dd8eb0cae01765c6c1adb0b70425ae579a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed minor sonar warnings.

Change-Id: Ib22579656e688a81011fc6b5761a20743ca44446
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG 3094, Check AS number

Change-Id: I345a3c5c2cb4a496b45e87aa11d1c752c39bc75c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Make sure we close read-only transactions

Transactions are resources, so they should be closed when no longer in
use.

Change-Id: I45a8a89f56b61cb12addbdb3349ab408c8aa14ed
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded MERGE modification type

This modification type is never generated, so eliminate the todos and
warnings stemming from the use of deprecated value. Default statement
will still catch/warn about it.

Change-Id: I3eb26a14d50e3428b5c10c34f39d3d1e3ebb12d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: cache effective attributes in import

This patch introduces a simple identity cache decorator around
AbstractImportPolicy. It is then used by ImportPolicyPeerTracker and
EffectiveRibInWriter to make sure we do not needlessly explode
attribute objects. This would typically happen when we receive multiple
routes within a single message and the import policy modifies the
attributes -- leading to a per-route attribute object.

Change-Id: I8581df3e3a2aae07a16d44f2554026afbad264fd
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-3074 : propagate up-to-date attribute

Added a method to BGPPeer that will notify the
peer that the synchronization for a table is finished.
Peer than pushes this information to AdjRibsIn from
where it's propagated to other types of RIB.

Change-Id: Idb7ad21b136b03fb2ded1bf3fe720319298555a0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 3012 - Refactor linkstate serializeNlri methods

- refactoring serialization methods

Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Change-Id: I4ebb92104c487b93df8477c1acd2ca731d148caf

Fixed some sonar issues

- local variables should not shadow classfields

Change-Id: I10ce99bb4317f846fa3f1984a34a38a2f6b9b831
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 3106 - Untangle directories

- Util class was moved into new package to remove cycle dependecy

Change-Id: Ib49a6770b19e9a1aae31825c7505bfec406a11d5
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "Version bump."

Version bump.

Fixed indentations. Needed for version bump.

Change-Id: I9734661b525f01064690047f29741b29f41de7be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Do not override odlparent properties.

Change-Id: Ic784de869ba3bf7e1b756a1ddcfd449a12375378
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-3108 : deprecated PCEP stateful02 classes.

Change-Id: Icfcf38947ed5ce0f4a00e7cb63add8d610bf6d1d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Removed deprecated classes."

Merge "BUG-2227 : fix exporting transitive attributes"

Merge "BUG-2571 : created configuration for Flowspec"

Removed deprecated classes.

AdjRibIns are no longer used and needed.

Change-Id: Iaa1a2268aabc2f4404f72fb78349168885f69dfc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2227 : fix exporting transitive attributes

Change-Id: Ie4edcabd949f7c11d6904dcb9190981d82df970f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2231 - Secure transport for PCEP

http://tools.ietf.org/html/draft-ietf-pce-pceps-03

-configurable TLS parameters (location of keystore, truststore, etc.)
-example initial configuration
-if TLS is configured, PCEPS is enabled, session negotiation starts with StartTLS msg
-StartTLSWait timer set to 60 seconds
-extended PCEP FRM to handle StartTLS

Change-Id: I4ad4ebc52187eaa58654db3ccabe484758132761
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2571 : created configuration for Flowspec

Implemented configuration and registration for
parser and RIB for Flowspec support.

Change-Id: I46158998f4b7fb6de6c3fc018e02df2c150104dd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383 : cleanup RIBImpl"

BUG-2383 : cleanup RIBImpl

The creation by RIB itself and Loc-RIB was still done in
binding-aware form. This commit changes it to binding
independent and removes all the methods that are not needed
anymore.

Change-Id: I51ec54264747cff584f1ece24884d2732b39f0a2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Implementation for Path Binding Tlv.

As per: https://tools.ietf.org/html/draft-sivabalan-pce-binding-label-sid

Implemented PathBindingTlv, its parser and wired
the TLV to LSP object.

Change-Id: I1803d6adca1132c88ca009417af6738759a5f443
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed linkstate NLRI serializer registration.

The registered DataObject is not used in parsing, but
for creating correct MpReachNlri codec. Adding another
capability discovered this bug.

Change-Id: I626bccfee4974a5fe223b7588e77eda663d111b7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Reordered serialization of prefix attributes.

TLV types serialized must be in ascending order.

Change-Id: I02009ff56b857e58f2efbaa1846bf69fa1277a82
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed some sonar warnings.

Inlcuding order of modifiers, magic numbers, unused
variables etc.

Change-Id: I4b77c48d558bbf02a3e99bb520656f133132d4f4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Revived Peer test.

First test tests onDataTreeChanged method in Application peer, second tests
the advertisement of routes from one peer to another.

Change-Id: Iee684935e67a4a9e62b4634b74858106da1734c8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2963 : fixed config file

Change-Id: Ia7b19eb3af2afcc1cf01880c628cae455460ae2e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed missing break statements in switch.

Change-Id: Ib1d895aa40976a12dbe7f6f28660ffb62dd9954d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2571 : created method for serializing FS NLRI to string

We will use this string key as a list key in flowspec-routes.

Change-Id: I5707e9f1ef2b999ad240af4a8e7a4d5c555aca44
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2963 - Make BGP peer role configurable

- added support for BGP peer role configurable

Change-Id: I756c013538a3c10a509c48ab1b69cefac2c033da
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "Mark with FIXMEs places where manual conversion is made."

Merge "BUG-2571 : implemented (partially) conversion of Flowspec from BI to BA form"

Mark with FIXMEs places where manual conversion is made.

Rather than making the conversion ourselves, we should rely on
the codec.

Change-Id: I9fe5cfc6251b4dab718f498fce93a0a9ec1f6b00
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2571 : implemented (partially) conversion of Flowspec
from BI to BA form

We need this to advertise Flowspec back to peers. The
advertising is done in BA form.

Change-Id: Ifc5e0e1bffaaf756afdfd44944281e3b9a36250a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Migrate to DataTreeChangeListener

This eliminates the inefficient DataChangeListener interface in favor of
DataTreeChangeListener.

Change-Id: I18474d45ca8a08d6a9344e5c23e83a1ebe209816
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2383 : clean up transaction chains in Peers"

BUG-2383 : clean up transaction chains in Peers

Change-Id: Iaec5b3b8b1c910c32c08fa63aa9fba4e4374ae0c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : filled in MP(Un)reachNlri RIB support builders

Change-Id: I4c7fb8b1af56cfda7f28775b04fa93a1cc4f5c7b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : wire AdjRibOutListener to BGPPeer

With RIBSupport in place, we can start emitting routes to our peers.

Change-Id: Idcec38e59a2c4b60c291400b6baff6b67f38e0f3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-3013 : added method for creating Update message from DOM

On egress we are have routes in NormalizedNode format and we need to
create DataObjects to pass to serializer. Introduce a RIBSupport method
to provide the required support.

Change-Id: Ibbc6f9d8e3c7c90429dcd4f7bb6a80a0118c7fe2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2571 : initial cut on Flowspec RIB Support

Change-Id: I83697949e1b203f09a12584ead80bd5ed1b7638c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2571 : fixed flowspec model

Change-Id: Id38fcd8543a0a248a5cc0bb4058f6f7fa1f37784
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : Application peer rework.

Change-Id: I152c7d265d81c58018976dcbbef46fca735e6dd8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2982 : fixed forgotten PathAttribute container creation

- leftover javadoc bugs

Change-Id: Ia2bc4742f5801b0dd2aec6db44454f04e1a1e4d1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2982 : moved path-attributes container to grouping"

Fix NPE on route delete

Local testing has uncovered this:

2015-04-14 16:34:51,211 | INFO  | upCloseable-3-11 | BGPSessionImpl                   | 209 - org.opendaylight.bgpcep.bgp-rib-impl - 0.4.0.SNAPSHOT | Closing session: BGPSessionImpl{channel=[id: 0x0ff0457c, /127.0.0.2:36180 :> /127.0.0.1:179], state=IDLE}
2015-04-14 16:36:03,441 | ERROR | lt-dispatcher-16 | DataTreeChangeListenerActor      | 202 - org.opendaylight.controller.sal-distributed-datastore - 1.2.0.SNAPSHOT | Error notifying listener org.opendaylight.protocol.bgp.rib.impl.LocRibWriter@5917453f
java.lang.NullPointerException
        at org.opendaylight.protocol.bgp.rib.impl.LocRibWriter.onDataTreeChanged(LocRibWriter.java:183)[209:org.opendaylight.bgpcep.bgp-rib-impl:0.4.0.SNAPSHOT]
        at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:53)[202:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]

Which turns out to be a failure to check for deleted entry.

Change-Id: Ib4e0be69bbafdaf3e29698395a85224fdfa6c347
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fixed javadocs for java8."

BUG-2982 : moved path-attributes container to grouping

- this eliminates the Attributes class and unifies the
view of the attributes for routes and messages

Change-Id: Id1fa5ac8fa4f48acc7c19fd0e497880e148617d1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed javadocs for java8.

Change-Id: Id9e47d4d8af0113b2f03de91df9521c8d5b1bb34
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : make LocalRIB count on complexity of the routes

- by creating complex route we can ensure that no data
goes missing in LocalRIB

Change-Id: Ide263d4c277b8a2ab598f1a3ae2306b9ee031590
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2994 : added new method to RIBSupport to expose complexity of its route

Change-Id: Id781e5499b87e969b5d354eb804f3693cd17dcaa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Fixed parser-to-sal test."

Fixed parser-to-sal test.

- getModuleInfos() override
- use different context for Ipv4/Linkstate

Change-Id: I04564c695ecf568f59a2f84009b6f946c69bca9b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2978 : Linkstate path attribute extracted to grouping

Change-Id: I75f40ce8acabf8c41002f5f32d96de6fee2257be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : finish up LinkstateRIBSupport

Change-Id: I6a787866e99238412fd83b6267f7c915dbbb5680
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : DOM Linkstate NLRI serializer

- we need to serialize the NLRi to obtain route-key

Change-Id: Ibe228b72b6fde8e8156074449709d2bceeaf6f40
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : introduce LinkstateRIBSupport

Change-Id: I4a540076512f99dd704784cf5447b3aa86cc7adb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : fix creating AdjRibsOut tables in datastore

Change-Id: Idd8028be92a5d2fafa6a2bf314852c8d16924a44
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2975 : implemented missing augmentations

Change-Id: Ieaf2ce516b9039ca8fcff1f1319cbf19c62f993e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Bug 2959 - wrong result for selecting high local perf"

BUG-2383 : do not ignore ipv6 rib support

Change-Id: I2c8451cb5805d4f45a5f4ab742b032a3eef838ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2959 - wrong result for selecting high local perf

- corrected condition by selecting best path with higher local pref

Change-Id: Ic3fd84002fb068bf6848bc7f98c0aed681c5cd30
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-2383 : revive AdjRibsOut in datastore

- fixed small bugs along the path
- added logging

Change-Id: I2e1451c1d93e3a6363833d3eafcf69c114ccfa73
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383: optimize locRibTarget"

Fix pep8 violations in message/_message.py

Change-Id: I030e7a3e9971e135ee4762a09f5eb7c8e6f1b189
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/rsvp.py

Change-Id: Icb5d5b299136e5856b95702f5977995fcf58c07e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/code.py

Change-Id: I68a4b531e44c2f8ba9f1a8a1058254207884b059
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/tlv.py

Change-Id: Ib1e60db32a2aaa2e9da05fa2be4605bf16cc6033
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/object.py

Change-Id: I1e5644421c6b90f593405b23058af2d28a36d9af
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/data.py

Change-Id: Iad8f58570356074a0f170dae3c3414b1fceaef5f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in message/base.py

Adds missing spacing between classes and functions.

Change-Id: I697f34eea072862754b77befda0fb51be6c655fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Ignore pep8 violations in message/__init__.py

Change-Id: Ieb696453db1f7618393303772bbee23ffb6f46d0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in peer/pcc.py

Change-Id: I2b84a8ad5f17d647d299f872d8fefa67bec610bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in peer/pce.py

Change-Id: I79470c5ac5bacd022f82d7b444a9d563beb6cb45
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in peer/base.py

Change-Id: I34842eef64bd33dcf84aa97ddfe79e86474abc86
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix pep8 violations in peer/lsp.py

Change-Id: I671575613b7836b660f61a30978ad5868ea8884d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Fix pep8 violations in peer/context.py"

BUG-2383: optimize locRibTarget

Since we will be using this instance identifier extensively, make sure
it is compacted, speeding up operations on it. Also remove unneeded
method.

Change-Id: I2b92c1bed21b4c7b0a78eb1c7e2c363b429642ab
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2383 : put empty routes structure to Loc-RIB"

BUG-2383 : put empty routes structure to Loc-RIB

Change-Id: Ida7afd1f404e406000b431d8b9df91d39e353bf8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix pep8 violations in peer/context.py

Change-Id: I633895414cb9d7077a2fc42ca7110b200818f574
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>