odlmicro.git
4 years agoremove the now upstreamed GuiceRule2 & ReadyModule
Michael Vorburger [Sat, 22 Dec 2018 02:45:26 +0000 (03:45 +0100)]
remove the now upstreamed GuiceRule2 & ReadyModule

and replace all usages of GuiceRule2 with GuiceRule

see https://git.opendaylight.org/gerrit/#/c/78983/

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agobind missing Routed RPC PacketProcessingService (see OPNFLWPLUG-1059)
Michael Vorburger [Wed, 23 Jan 2019 21:40:42 +0000 (22:40 +0100)]
bind missing Routed RPC PacketProcessingService (see OPNFLWPLUG-1059)

https://jira.opendaylight.org/browse/OPNFLWPLUG-1059
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoremove DiagStatusServletTest which is meanwhile in upstream infrautils
Michael Vorburger [Wed, 23 Jan 2019 21:03:46 +0000 (22:03 +0100)]
remove DiagStatusServletTest which is meanwhile in upstream infrautils

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd small inline comment in MdsalModule
Michael Vorburger [Wed, 23 Jan 2019 17:31:39 +0000 (18:31 +0100)]
add small inline comment in MdsalModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix 2/3 problems in GeniusModule, but now blocked by OPNFLWPLUG-1059
Michael Vorburger [Fri, 11 Jan 2019 02:33:05 +0000 (03:33 +0100)]
fix 2/3 problems in GeniusModule, but now blocked by OPNFLWPLUG-1059

So now https://jira.opendaylight.org/browse/OPNFLWPLUG-1059 *REALLY*
needs to be sorted out... I'll try to get to that next week, or find
help.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoexclude bgpmanager-impl (due to Thrift usage; look more at this later)
Michael Vorburger [Sat, 22 Dec 2018 01:52:17 +0000 (02:52 +0100)]
exclude bgpmanager-impl (due to Thrift usage; look more at this later)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoClassPathScanner now also scans for @Singleton without interfaces
Michael Vorburger [Sat, 22 Dec 2018 01:48:21 +0000 (02:48 +0100)]
ClassPathScanner now also scans for @Singleton without interfaces

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoimprove ClassPathScannerTest to illustrate how it binds 2 interfaces
Michael Vorburger [Sat, 22 Dec 2018 01:20:58 +0000 (02:20 +0100)]
improve ClassPathScannerTest to illustrate how it binds 2 interfaces

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agominor: @SuppressWarnings re. Java Generics warning in ClassPathScanner
Michael Vorburger [Sat, 22 Dec 2018 01:18:50 +0000 (02:18 +0100)]
minor: @SuppressWarnings re. Java Generics warning in ClassPathScanner

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agominor: update ClassPathScanner JavaDoc (it was outdated)
Michael Vorburger [Sat, 22 Dec 2018 01:18:13 +0000 (02:18 +0100)]
minor: update ClassPathScanner JavaDoc (it was outdated)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agominor: add TODO re AutoCloseable in MdsalModule
Michael Vorburger [Sat, 22 Dec 2018 01:17:16 +0000 (02:17 +0100)]
minor: add TODO re AutoCloseable in MdsalModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agobind AAA Encrypt & Cert services (requires by upcoming OVSDB)
Michael Vorburger [Sat, 22 Dec 2018 00:46:23 +0000 (01:46 +0100)]
bind AAA Encrypt & Cert services (requires by upcoming OVSDB)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agobind mdsal @PingPong DataBroker
Michael Vorburger [Sat, 22 Dec 2018 00:17:30 +0000 (01:17 +0100)]
bind mdsal @PingPong DataBroker

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agobind mdsal.DataBroker
Michael Vorburger [Sat, 22 Dec 2018 00:09:06 +0000 (01:09 +0100)]
bind mdsal.DataBroker

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd binding for controller NotificationService
Michael Vorburger [Fri, 21 Dec 2018 14:10:16 +0000 (15:10 +0100)]
add binding for controller NotificationService

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix Error Prone problem in InMemoryControllerModuleTest
Michael Vorburger [Fri, 21 Dec 2018 14:03:20 +0000 (15:03 +0100)]
fix Error Prone problem in InMemoryControllerModuleTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoremove AutoWiringModule constructor without packagePrefix
Michael Vorburger [Fri, 21 Dec 2018 12:51:32 +0000 (13:51 +0100)]
remove AutoWiringModule constructor without packagePrefix

adapt NetvirtModule, note NetvirtSimpleDistributionTest is @Ignored

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoimprove AutoWiringModule so that you don't have to super.configure()
Michael Vorburger [Fri, 21 Dec 2018 12:48:45 +0000 (13:48 +0100)]
improve AutoWiringModule so that you don't have to super.configure()

also made it an AbstractCheckedModule while at it

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoprepare InMemoryMdsalModuleTest (but @Ignore TODO it)
Michael Vorburger [Fri, 21 Dec 2018 12:40:59 +0000 (13:40 +0100)]
prepare InMemoryMdsalModuleTest (but @Ignore TODO it)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomake InMemoryControllerModuleTest actually test DataBroker
Michael Vorburger [Fri, 21 Dec 2018 12:35:04 +0000 (13:35 +0100)]
make InMemoryControllerModuleTest actually test DataBroker

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agorename ControllerModule to InMemoryControllerModule
Michael Vorburger [Fri, 21 Dec 2018 12:33:30 +0000 (13:33 +0100)]
rename ControllerModule to InMemoryControllerModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agorename all *Wiring which are actually *Module accordingly
Michael Vorburger [Fri, 21 Dec 2018 12:25:21 +0000 (13:25 +0100)]
rename all *Wiring which are actually *Module accordingly

as per updated doc from the previous commit:

    *Wiring is pure Java

    *Module is Guice specific

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd doc re. Guice, *Wiring & *Module to README
Michael Vorburger [Fri, 21 Dec 2018 12:09:29 +0000 (13:09 +0100)]
add doc re. Guice, *Wiring & *Module to README

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomv infrautils.karaf -> infrautils.karaf.shell
Michael Vorburger [Fri, 21 Dec 2018 12:01:26 +0000 (13:01 +0100)]
mv infrautils.karaf -> infrautils.karaf.shell

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix OpenFlowPluginWiringTest to actually start OFP
Michael Vorburger [Thu, 20 Dec 2018 23:26:33 +0000 (00:26 +0100)]
fix OpenFlowPluginWiringTest to actually start OFP

by using only GuiceRule2 instead of GuiceRule, which makes the
OpenFlowPluginWiringTest actually run the SystemReadyListener's
onSystemBootReady() of OpenFlowPluginProviderImpl.

use GuiceRule2 *everywhere* just to reduce confusion which to use.

TODO upstream GuiceRule2 integrated into infrautils GuiceRule now!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoBump classgraph from 4.6.9 to 4.6.10
dependabot[bot] [Thu, 20 Dec 2018 04:31:43 +0000 (04:31 +0000)]
Bump classgraph from 4.6.9 to 4.6.10

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.6.9 to 4.6.10.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd 'How to use in Dev' to README
Michael Vorburger [Wed, 19 Dec 2018 16:24:23 +0000 (17:24 +0100)]
add 'How to use in Dev' to README

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomake <dependency> org.osgi.compendium <scope>compile (fixes #73)
Michael Vorburger [Wed, 19 Dec 2018 16:23:13 +0000 (17:23 +0100)]
make <dependency> org.osgi.compendium <scope>compile (fixes #73)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agominor change to README re. poc-1.0.0 instead of 1.5.0
Michael Vorburger [Wed, 19 Dec 2018 15:13:47 +0000 (16:13 +0100)]
minor change to README re. poc-1.0.0 instead of 1.5.0

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoremove ClassPathScanner explicit bindings
Michael Vorburger [Wed, 19 Dec 2018 00:09:47 +0000 (01:09 +0100)]
remove ClassPathScanner explicit bindings

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoBump classgraph from 4.6.8 to 4.6.9
dependabot[bot] [Wed, 19 Dec 2018 04:19:05 +0000 (04:19 +0000)]
Bump classgraph from 4.6.8 to 4.6.9

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.6.8 to 4.6.9.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix GeniusSimpleDistributionTest
Michael Vorburger [Wed, 19 Dec 2018 00:48:54 +0000 (01:48 +0100)]
fix GeniusSimpleDistributionTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoremove bind(PacketProcessingService)
Michael Vorburger [Wed, 19 Dec 2018 00:37:58 +0000 (01:37 +0100)]
remove bind(PacketProcessingService)

because OpenFlowPluginProviderImpl already creates this (now)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoreplace hard-coded ForwardingRulesManagerConfig with XML configuration
Michael Vorburger [Wed, 19 Dec 2018 00:27:57 +0000 (01:27 +0100)]
replace hard-coded ForwardingRulesManagerConfig with XML configuration

Note how the test proves that the default (5) from the YANG is used!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoreplace hard-coded OpenflowProviderConfig with XML configuration file
Michael Vorburger [Wed, 19 Dec 2018 00:23:14 +0000 (01:23 +0100)]
replace hard-coded OpenflowProviderConfig with XML configuration file

Note how the test proves that the default from the YANG is used!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agovery minor clean ups
Michael Vorburger [Wed, 19 Dec 2018 00:05:00 +0000 (01:05 +0100)]
very minor clean ups

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoinject OpenFlowPlugin via classpath scanning auto wiring
Michael Vorburger [Wed, 31 Oct 2018 18:37:09 +0000 (19:37 +0100)]
inject OpenFlowPlugin via classpath scanning auto wiring

incl. @PingPong

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoexclude odl-karaf-feat-jdbc so that we don't drag friggin' Hibernate in
Michael Vorburger [Tue, 18 Dec 2018 23:41:59 +0000 (00:41 +0100)]
exclude odl-karaf-feat-jdbc so that we don't drag friggin' Hibernate in

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoBump classgraph from 4.4.12 to 4.6.8
dependabot[bot] [Tue, 18 Dec 2018 19:31:14 +0000 (19:31 +0000)]
Bump classgraph from 4.4.12 to 4.6.8

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.4.12 to 4.6.8.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agohandle the impacts of netconf using the mdsal instead of controller APIs
Michael Vorburger [Tue, 18 Dec 2018 19:29:30 +0000 (20:29 +0100)]
handle the impacts of netconf using the mdsal instead of controller APIs

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agocomment out & disable DiagStatusCommand wiring
Michael Vorburger [Tue, 18 Dec 2018 19:27:00 +0000 (20:27 +0100)]
comment out & disable DiagStatusCommand wiring

because that was broken in
https://github.com/opendaylight/infrautils/commit/c88543dd8823585bbfd1d3cc72c56b922896df9c

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix broken OpenFlowPluginWiring, due to ongoing WIP work on OFP master
Michael Vorburger [Mon, 19 Nov 2018 12:56:42 +0000 (13:56 +0100)]
fix broken OpenFlowPluginWiring, due to ongoing WIP work on OFP master

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoBump classgraph from 4.4.3 to 4.4.12
dependabot[bot] [Fri, 9 Nov 2018 15:38:55 +0000 (15:38 +0000)]
Bump classgraph from 4.4.3 to 4.4.12

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.4.3 to 4.4.12.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agocomment out AAA cert & crypt services that are not needed
Michael Vorburger [Fri, 9 Nov 2018 15:37:13 +0000 (16:37 +0100)]
comment out AAA cert & crypt services that are not needed

because they are currently broken, following AAA changing from the
controller to the mdsal APIs.  That could (easily) be fixed, of course,
but may be we can just get rid of AAA here in simple all together...

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agointroduce an AutoWiringModule
Michael Vorburger [Wed, 31 Oct 2018 18:14:27 +0000 (19:14 +0100)]
introduce an AutoWiringModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agointro. new bindAllSingletons()
Michael Vorburger [Wed, 31 Oct 2018 17:25:51 +0000 (18:25 +0100)]
intro. new bindAllSingletons()

and use it in AlivenessMonitorWiring

This now also wires the HwVtepTunnelsStateHandler, which we forgot! ;)

That (to not forget to manually wire in any @Singleton) is the point.

PS: PacketProcessingListener didn't get wired, just like it should be.
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agocopy configuration files to etc/ directory on start up
Michael Vorburger [Wed, 31 Oct 2018 21:03:36 +0000 (22:03 +0100)]
copy configuration files to etc/ directory on start up

and (by documented convention) have that etc/ dir on the CP

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoread UpgradeConfig from XML configuration file
Michael Vorburger [Wed, 31 Oct 2018 20:16:58 +0000 (21:16 +0100)]
read UpgradeConfig from XML configuration file

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd UpgradeWiring & ServiceUtilsModuleTest
Michael Vorburger [Wed, 31 Oct 2018 19:54:57 +0000 (20:54 +0100)]
add UpgradeWiring & ServiceUtilsModuleTest

openflowplugin actually uses the UpgradeState service

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoremove long un-used test web.xml
Michael Vorburger [Wed, 31 Oct 2018 19:22:11 +0000 (20:22 +0100)]
remove long un-used test web.xml

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agointro RESTCONF Version DRAFT_02 vs DRAFT_18
Michael Vorburger [Sat, 20 Oct 2018 17:34:29 +0000 (19:34 +0200)]
intro RESTCONF Version DRAFT_02 vs DRAFT_18

use DRAFT_02 by default (instead of previous DRAFT_18)

un-comment the test which now passes!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd restconf
Michael Vorburger [Thu, 11 Oct 2018 00:35:27 +0000 (02:35 +0200)]
add restconf

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agouse Truth instead of JUnit assertion in ClassPathScannerTest
Michael Vorburger [Sat, 20 Oct 2018 17:51:30 +0000 (19:51 +0200)]
use Truth instead of JUnit assertion in ClassPathScannerTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agodeal with ODL Neon MRI base platform upgrade impacts
Michael Vorburger [Mon, 29 Oct 2018 18:25:14 +0000 (19:25 +0100)]
deal with ODL Neon MRI base platform upgrade impacts

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoBump classgraph from 4.2.12 to 4.4.3
dependabot[bot] [Sat, 20 Oct 2018 00:08:04 +0000 (00:08 +0000)]
Bump classgraph from 4.2.12 to 4.4.3

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.2.12 to 4.4.3.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd Neutron (fully working & tested)
Michael Vorburger [Fri, 12 Oct 2018 14:18:29 +0000 (16:18 +0200)]
add Neutron (fully working & tested)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoSimplify ClassPathScanner tests
Stephen Kitt [Fri, 12 Oct 2018 07:40:27 +0000 (09:40 +0200)]
Simplify ClassPathScanner tests

By isolating the Guice-specific aspects of ClassPathScanner, and
making the latter more generic, we can greatly simplify the
ClassPathScanner UT and isolate it from Guice dependencies.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
4 years agoTemporarily add -U to mvn to force fetch just merged infrautils change
Michael Vorburger [Thu, 11 Oct 2018 21:17:06 +0000 (23:17 +0200)]
Temporarily add -U to mvn to force fetch just merged infrautils change

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd "showSvcStatus" CLI command (#29)
Michael Vorburger [Tue, 9 Oct 2018 20:55:48 +0000 (22:55 +0200)]
add "showSvcStatus" CLI command (#29)

requires https://git.opendaylight.org/gerrit/#/c/76810/

which requires https://github.com/vorburger/opendaylight-simple/pull/19

TODO This is only a first cheap, and while it will provide "ready"
status, it does not yet register real ServiceStatusProvider
(but we don't have any real ones anyway).

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years ago"Gotta catch'em all - Pokémon!"
Michael Vorburger [Thu, 11 Oct 2018 21:27:55 +0000 (23:27 +0200)]
"Gotta catch'em all - Pokémon!"

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd more shit to <mirror> in settings.xml (#37)
Michael Vorburger [Thu, 11 Oct 2018 21:11:16 +0000 (23:11 +0200)]
add more shit to <mirror> in settings.xml (#37)

Like Pokémon, I'm gone "go get'em all" !

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoun-comment ConfigurationServiceFactoryImpl
Michael Vorburger [Wed, 3 Oct 2018 00:50:32 +0000 (02:50 +0200)]
un-comment ConfigurationServiceFactoryImpl

requires https://git.opendaylight.org/gerrit/#/c/76588/ for
https://jira.opendaylight.org/browse/OPNFLWPLUG-1037

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadapt to renamed package in infrautils
Michael Vorburger [Tue, 9 Oct 2018 21:08:46 +0000 (23:08 +0200)]
adapt to renamed package in infrautils

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoreplace our SystemReadyBaseImpl with infrautils' SystemReadyImpl
Michael Vorburger [Mon, 1 Oct 2018 12:33:47 +0000 (14:33 +0200)]
replace our SystemReadyBaseImpl with infrautils' SystemReadyImpl

see https://git.opendaylight.org/gerrit/#/c/76532/

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomore refining :( <mirror> in settings.xml (#37)
Michael Vorburger [Thu, 11 Oct 2018 17:01:12 +0000 (19:01 +0200)]
more refining :( <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agore-re-refine :( <mirror> in settings.xml (#37)
Michael Vorburger [Thu, 11 Oct 2018 16:49:42 +0000 (18:49 +0200)]
re-re-refine :( <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agore-refine ;) <mirror> in settings.xml (#37)
Michael Vorburger [Thu, 11 Oct 2018 16:40:17 +0000 (18:40 +0200)]
re-refine ;) <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agorefine <mirror> in settings.xml (#37)
Michael Vorburger [Thu, 11 Oct 2018 16:37:32 +0000 (18:37 +0200)]
refine <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agobump Classgraph from 4.2.7 to 4.2.12
Michael Vorburger [Thu, 11 Oct 2018 13:43:23 +0000 (15:43 +0200)]
bump Classgraph from 4.2.7 to 4.2.12

https://github.com/classgraph/classgraph/releases
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoSwitch to ClassGraph
Stephen Kitt [Wed, 10 Oct 2018 11:38:46 +0000 (13:38 +0200)]
Switch to ClassGraph

Closes: #38
Signed-off-by: Stephen Kitt <skitt@redhat.com>
4 years agointroduce TestHttpClient
Michael Vorburger [Thu, 11 Oct 2018 00:55:25 +0000 (02:55 +0200)]
introduce TestHttpClient

used in DiagStatusServletTest, also upcoming restconf support

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoAdd ClassPathScanner tests
Stephen Kitt [Wed, 10 Oct 2018 11:38:10 +0000 (13:38 +0200)]
Add ClassPathScanner tests

Signed-off-by: Stephen Kitt <skitt@redhat.com>
4 years agoadd <mirror> for ODL Nexus to settings.xml (#37)
Michael Vorburger [Wed, 10 Oct 2018 18:27:06 +0000 (20:27 +0200)]
add <mirror> for ODL Nexus to settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agocatch and log Exception from SystemReadyListener
Michael Vorburger [Wed, 10 Oct 2018 17:16:36 +0000 (19:16 +0200)]
catch and log Exception from SystemReadyListener

due to today's I4f16674ba65f499944e4582fb900d90e873d14e2 (INFRAUTILS-51)

This is about to be replaced by
https://github.com/vorburger/opendaylight-simple/pull/19 anyway,
beecause that is not ready, because
https://git.opendaylight.org/gerrit/#/c/76532 is taking forever to go
in, let's do this for the short term.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agodeploy using releases instead of pages provider after all (#42)
Michael Vorburger [Wed, 10 Oct 2018 15:48:08 +0000 (17:48 +0200)]
deploy using releases instead of pages provider after all (#42)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoRevert "move TAR to target/deploy"
Michael Vorburger [Wed, 10 Oct 2018 15:48:42 +0000 (17:48 +0200)]
Revert "move TAR to target/deploy"

This reverts commit 4aa336d3e0f1cc99bc79a1e2916693b13e5c8fb5.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd /diagstatus web support
Michael Vorburger [Tue, 9 Oct 2018 22:16:31 +0000 (00:16 +0200)]
add /diagstatus web support

This foundation will also be useful when adding REST web wiring.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix hanging JVM in case of Guice wiring problems
Michael Vorburger [Tue, 9 Oct 2018 21:14:40 +0000 (23:14 +0200)]
fix hanging JVM in case of Guice wiring problems

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agotweak Travis YAML to see if this and/or new token help
Michael Vorburger [Tue, 9 Oct 2018 23:23:47 +0000 (01:23 +0200)]
tweak Travis YAML to see if this and/or new token help

Couldn't push the build to github.com/vorburger/opendaylight-simple-binaries.git:gh-pages

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd things to TODO
Michael Vorburger [Tue, 9 Oct 2018 21:21:54 +0000 (23:21 +0200)]
add things to TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoenable verbose logging for deploy pages provider
Michael Vorburger [Tue, 9 Oct 2018 20:25:47 +0000 (22:25 +0200)]
enable verbose logging for deploy pages provider

to figure out why it fails with:
Couldn't push the build to github.com/vorburger/opendaylight-simple-binaries.git:gh-pages

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agodeploy using pages provider
Michael Vorburger [Tue, 9 Oct 2018 19:24:05 +0000 (21:24 +0200)]
deploy using pages provider

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomove TAR to target/deploy
Michael Vorburger [Tue, 9 Oct 2018 19:16:32 +0000 (21:16 +0200)]
move TAR to target/deploy

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agodeploy using releases provider (#27)
Sam Hague [Tue, 9 Oct 2018 18:51:51 +0000 (20:51 +0200)]
deploy using releases provider (#27)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix POC version to 1.0.0-SNAPSHOT instead of inheriting infrautils'
Michael Vorburger [Tue, 9 Oct 2018 18:21:40 +0000 (20:21 +0200)]
fix POC version to 1.0.0-SNAPSHOT instead of inheriting infrautils'

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoUpdate TODO.md
Michael Vorburger [Mon, 8 Oct 2018 15:08:31 +0000 (17:08 +0200)]
Update TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoUpdate TODO.md
Michael Vorburger [Sun, 7 Oct 2018 00:58:00 +0000 (02:58 +0200)]
Update TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoUpdate README.md
Michael Vorburger [Thu, 4 Oct 2018 19:07:14 +0000 (21:07 +0200)]
Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoAdd travis builds
Sam Hague [Thu, 4 Oct 2018 18:24:17 +0000 (14:24 -0400)]
Add travis builds

Signed-off-by: Sam Hague <shague@redhat.com>
4 years agoUpdate README.md
Michael Vorburger [Thu, 4 Oct 2018 18:11:33 +0000 (20:11 +0200)]
Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoFix System.exit() handling
Stephen Kitt [Thu, 4 Oct 2018 09:46:51 +0000 (11:46 +0200)]
Fix System.exit() handling

Directly invoking System.exit() from Main.close() causes two problems:
* FindBugs doesn’t like it ;-)
* MainTest fails because the JVM exits from under Surefire’s feet

This patch adds an override for FindBugs, and separates closing the
injector from exiting the JVM for test purposes.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
4 years agoadd TODO re. ClassPathScanner using ClassGraph
Michael Vorburger [Thu, 4 Oct 2018 01:59:10 +0000 (03:59 +0200)]
add TODO re. ClassPathScanner using ClassGraph

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agomake ClassPathScanner log "declared multiple times" debug instead warn
Michael Vorburger [Tue, 2 Oct 2018 23:47:59 +0000 (01:47 +0200)]
make ClassPathScanner log "declared multiple times" debug instead warn

This avoids seeing this, which is confusing and doesn't add much value:

2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.ServiceRecoveryInterface is declared multiple times, ignoring it
2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface java.lang.AutoCloseable is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.RecoverableListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.mdsal.eos.binding.api.EntityOwnershipListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.netvirt.fibmanager.IVrfEntryHandler is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.infrautils.diagstatus.ServiceStatusProvider is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.alivenessmonitor.rev160411.AlivenessMonitorListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.arputil.rev160406.OdlArputilListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface java.lang.Runnable is declared multiple times, ignoring it
Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd TODO re. DataStoreAppConfigDefaultXMLReader
Michael Vorburger [Wed, 3 Oct 2018 01:11:10 +0000 (03:11 +0200)]
add TODO re. DataStoreAppConfigDefaultXMLReader

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoCtrl-D in Console now works
Michael Vorburger [Wed, 3 Oct 2018 00:02:52 +0000 (02:02 +0200)]
Ctrl-D in Console now works

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoexclude controller:blueprint
Michael Vorburger [Tue, 2 Oct 2018 23:30:48 +0000 (01:30 +0200)]
exclude controller:blueprint

This avoids:

2018-10-03T01:07:15,706 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata from any
class loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,717 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.container.BlueprintListener from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.container.BlueprintListener
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.container.BlueprintListener
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,850 | WARN  | main             | Reflections
| could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agooptimize distribution build time via tar instead xz archive
Michael Vorburger [Tue, 2 Oct 2018 23:20:10 +0000 (01:20 +0200)]
optimize distribution build time via tar instead xz archive

While the poc-1.5.0-SNAPSHOT-simple.tar.xz was only 99M, it took about
1:30 min (!) to build (not total, just to XZ). That's a steep price to
pay, when a simple tar is just 122M (because the JAR are already
compressed) is quasi instant.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agoadd (working, wow!) distribution assembly
Michael Vorburger [Tue, 2 Oct 2018 23:14:16 +0000 (01:14 +0200)]
add (working, wow!) distribution assembly

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix broken build
Michael Vorburger [Tue, 2 Oct 2018 21:09:17 +0000 (23:09 +0200)]
fix broken build

Signed-off-by: Michael Vorburger <mike@vorburger.ch>
4 years agofix Checkstyle problem in ClassPathScanner JavaDoc
Michael Vorburger [Tue, 2 Oct 2018 21:00:59 +0000 (23:00 +0200)]
fix Checkstyle problem in ClassPathScanner JavaDoc

and @SuppressWarnings for Class

Signed-off-by: Michael Vorburger <mike@vorburger.ch>