Bug-2226: RFC5886 - New objects parsers/seriazers

-Implementation of parsers and serializers for
new objects defined in RFC5886

-ref.: https://tools.ietf.org/html/rfc5886

Change-Id: I8c9c6038058f3dbdf19253c6284cd29619237359
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2226: RFC5886 yang model

reference: https://tools.ietf.org/html/rfc5886
   https://tools.ietf.org/html/draft-many-pce-pcep-bcp-00

- new objects:
- MONITORING
- PCC-REQ-ID
- PCE-ID
- PROC-TIME
- OVERLOAD
-extended messages
        -PCRep
        -PCReq
-new messages:
-PCMonRep
-PCMonReq (extended PCReq can be reused)

Change-Id: I7d340c4d05d6e8635a5539649ce5c9213ea6b4f8
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2508: Switch PCEP topology provider to use pingpong-binding-data-broker

-changed initial config file, pingpong-binding-data-broker instance is now injected as data-broker
-the change increases performance

Change-Id: Ib06b0d5e68926d648110e004960e46d5ee5dd707
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2423: LSP Identifiers TLV in PCEP-SR PCRpt messsage

-LSP Identifier TLV is not included in LSP object of PCRpt
message for PCEP segment routing

-since building of PCEP topology depends on LSP Identifier,
lets put fake LSP Identifier (use PLSP ID value)

Change-Id: Idb0ec249a11f343c6071e6bf286fa2cb6f91940f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 06dd46a992e834d73e526f4a600a8aae4f88a0e0)

BUG-1953 : adjust ISO system identifier

Change-Id: Ia71d4f2e07f21e1cb30c87cf7d4c3802b4d970f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2255 : adjusted BGP configuration to use pingpong data broker."

Merge "BUG-2448 : added more defensive lookup to node & link attributes"

More warnings down:
- remove empty statement
- add private constructor where needed
- log exception
- order modifiers
- duplicate string literals

Change-Id: I9456437fd66421dbb040f08f469b2a99851cce66
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Switch statements should end with a default case.

Change-Id: I04b67c4c8a0109a00867970a122a30bc26228b90
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Constant names should comply with a naming convention.

Change-Id: Ia52c00bcb2c4aa8ffab978046fedf2ebd0234408
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2448 : added more defensive lookup to node & link attributes

Change-Id: I2feb75c1a178df0eeffe8e234072eafa3628bd6a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Bug-2436: PCEP segment-routing - take F and S flag into account"

Bug-2436: PCEP segment-routing - take F and S flag into account

-if F flag is set, NAI value is ommited
-if S flag is set, SID value is ommited

Change-Id: Ia92680c77af0a6f8b1406de4723e9e9174479a4c
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-2418 PCEP session statistics RuntimeBean was not closed properly

-RuntimeBean was not unregistered, when session was closed - causing NPE in netconf-state

Change-Id: I85cab707e4626fa0c22d02080eb90cc3be01ef7f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2255 : adjusted BGP configuration to use pingpong data broker.

Change-Id: I455b9ed3d655675585c6eee48e4fa934bea289a1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-1953: Fix bgpcep tests

-ipv4/6 prefixes must contain mask

Change-Id: I93c4ce30e98f5a0cd5fa8ba86a39129ee837d800
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-865: modified BGPCEP config tests

-edited config tests to reflect changes in binding-broker config module
https://git.opendaylight.org/gerrit/#/c/13018/

Change-Id: Ibdf28b9df4908500e178453b727f35c7e9b93243
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Wipe operational state

Clustered data store may end up persisting our data, which means that if
an instance comes up after a crash, we may have stale data. Rather than
failing to come up, lets just wipe whatever was there.

Change-Id: I3b43d9bf692f083142e44fe8b588d1a92f81e7a2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Use TCPMD5-supplied artifacts"

Use TCPMD5-supplied artifacts

Rather than declaring the versions by hand we just import whatever is
exported.

Change-Id: I2c08b7dc7ef7350f25ab26821d207570be6d013b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded model declarations

the yangtools artifacts import already handles these, so no need to be
repetetive.

Change-Id: Ie9a2c9630e6c1ea41535679860946028b130e95b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2157: Fix missing programming models

This fixes the hanging tests, since the RPC registration process
requires the models to be present.

Change-Id: I2f986821a610e2664305c0f49f5ce19e7ba660b8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Synchronize close methods in RIB and topology provider to avoid closing conflicts."

Synchronize close methods in RIB and topology provider to avoid closing conflicts.

Change-Id: I758e55c932500189aead22dd858af140a93d3667
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383: lower default candidate allocation"

Merge "BUG-2283 : workaround in programming-impl"

BUG-2383: lower default candidate allocation

Rather than allocating the default of 16 entries, we force the HashMap
to allocate a lower number of entries. While this is not a complete
solution, it lowers the memory overhead significantly.

Change-Id: Ic3afe36381930d567ee7523856b3d3959c013459
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 547bd6ec0a7d0147572dc355ab186571bf42e8b7)

BUG-2283 : workaround in programming-impl

Change-Id: Ibff71c25a5106e1cff96feb8a1429caa54735825
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2398: AbstractTopologyBuilder() to put() with createParents.

Change-Id: I96bd59ce75a09ddcde6460327a131b46b61744d9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-2385: introduce a shorter version of identifierForKey()

This takes advantage of the fact that the basePath is passed down to the
constructor -- so the subclasses can actually do a better job at
finiding the true base path.

Change-Id: I965e27ca6599bc606d8447acf7e6f2ddc1370ac4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Read-only transactions were not being closed"

Read-only transactions were not being closed

We have failed to close read-only transactions, which can lead to resource
starvation.

Change-Id: I62dbf6b6409a65f279b01c3bb5b2238ffa6febc8
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 16cdb27ad01eb27950aba2c6fd5e4b03881a623a)

Use config-artifacts for dependencies

Rather than manually pulling configuration dependencies, use the
artifacts provided.

Change-Id: Ie992c7fd771d9d5051ace3319607285d9be93729
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use yangtools-artifacts for dependencies.

Rather than relying on manual dependencies, let's just import the
artifacts published by yangtools.

Change-Id: I9289d3982aca2a8eb6c5265cf2999bec133a653f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fixed ordering of configuration files in features.xml

Change-Id: I4d09667dad74a31c26fe52c24d85939bf400e440
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-731: last warnings fixed"

BUG-731: last warnings fixed

Change-Id: I649141d1c6209a2774a3dda2f3d6b3ab27217888
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Added forgotten MAX_MSG_PER_READ option to BGP."

Added forgotten MAX_MSG_PER_READ option to BGP.

Change-Id: I690f2043a4c8a4d4ee9c48bf64c8841b1a704b16
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2299: allow PCEP extensions to be reconfigured

The trigger here is a change in the extensions cause the corresponding
context to be re-created from scratch, which leads to the topology
manager to being re-created. This patch implements instance reuse by
adding proper activator hooks.

Change-Id: I5f114b81ceeb26a3943afc4bd2f0c34b678ff029
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2109 : clear BGP session after it was already initialized"

BUG-731 : more warnings down

Change-Id: I83598fdb04d4357d3efc6ed26c1d5beac70686c1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Split Error identifiers to separate classes.

Change-Id: I1b74e56c3fb79d4eb375a0da7e1e81fc00b52797
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2109 : clear BGP session after it was already initialized

Change-Id: Ib70a725b948892a2a887a941bdcb4e8dcfdb80eb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fix for NPE in OSPF, when forwarding address is not set.

Change-Id: Iff310eee0a5c4c9a34971b6cf5d958d8ed5004e2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Removed obsolete methods from Ipv4/Ipv6Util."

Removed obsolete methods from Ipv4/Ipv6Util.

Change-Id: I79a7d82840a989418dc9216b522b8d3fdc4d77cd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-731: Fixed issue in NodeChangedListener

Change-Id: I5f4aec033d4bfd260ae0a3c30cf48e321226b2d3
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-731 : removed more warnings"

Removed obsolete methods from ByteArray.

- by switching to ByteBuf, many of the methods in ByteArray became obsolete,
they were removed, fixing a few sonar warnings along the way

Change-Id: I6eb30c2b8f62c18b911555ec3c6ae13a6e7ac4e7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : removed more warnings

Change-Id: I82b253f3e11e8155ea7dae61ecd47906565cfcb7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Moved config files to modules where they belong."

Moved config files to modules where they belong.

Change-Id: I8396f4ce6daac8a4d6eb6c79283b94757f366368
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731: reduced complexity

Change-Id: I9573e625ab6eb050b7ad33325cfd7a165944105a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Added documentation to serializeObject method."

Memory optimizations for AS-Path and Origin attributes

- AS-Path: minimized empty lists
- Origin: reusing Origin container

Change-Id: I424169873ad1bfae0e3cd928bf285f59c70141ec
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added documentation to serializeObject method.

- to be more clear that there is a check for non-null Object argument

Change-Id: I71c1f723281f7ae02501b40dbcf8c533af090063
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2064: Implementation of RFC5492 Error handling.

-Unsupported Capability - subcode 7 for Open message error.
-Unsupported Capability MAY be used by BGP speaker to complain that peer does not support required capability.
The NOTIFICATION message MUST contain list of such capabilities in Data field.
-Unsupported Capability MUST NOT be used when a BGP speaker receives unrecognized or unsupported capability.
Such capabilities MUST be ignored.

The BGP speaker is prepared to receive
an OPEN message that contains one or multiple Capabilities Optional
Parameters, each of which contains one or more capabilities TLVs.

Change-Id: I09f12011d90dc77a6a4cc4b3049ff7eba71dc443
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-2182 : included data-change-counter in feature file"

Updated dependencies in pom.

Change-Id: I7070ba395f5738df9bcf80a21ac6a36a776688b6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : more sonar warnings fixed

Change-Id: I0fa0936081a3ab371aedc1da9cb645c48ca8e269
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2182 : included data-change-counter in feature file

- rework feature file

Change-Id: Ic99fc9982834d0c4cd5543d9d85f02991a336bd4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2234: Propagate PCEP errors via RPC

-errors are added also in case the error was detected before request was sent

-add-lsp:
-"SYMBOLIC-PATH-NAME in use" if such LSP already exists
-"Capability not supported" if PCE does not have initiate capability
-update-lsp:
-"unknown PLSP-ID" if such LSP does not exist
-remove-lsp:
-"unknown PLSP-ID" if such LSP does not exist

Change-Id: Icb7096ef4bcfc5383751993fcc588168895a1ca6
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Merge "BUG-731 : fixed pcep sonar warnings"

Merge "BUG-2109 : remove also sessionId when bgp session is closed"

Forbid user to sent add-lsp if the instantiation capability is missing

Change-Id: I91eeb6793fcfeabd6731d6dd9d59c36d4843f9be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : fixed pcep sonar warnings

Change-Id: I2cb38fb5b6546d55c0c08b01cd428eb35646747e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2116: Added CEASE error code subcodes as defined in RFC4486.

Change-Id: I3eb2c6c88629581cdab16e829f9387b3aebef503
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2109 : remove also sessionId when bgp session is closed

Change-Id: I8f086b35ac3f75d9da04de37c0d88e465822077b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : removed more sonar warnings

Change-Id: I74bd1da4ea9739d1c661cc13901c1bbf6b153b8d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2080: BGP statistics.

-per BGP peer statistics, related with bgp-peer config module

-peer and speaker preferences
-proposed holdtimer-value, BGP ID, AS number, Ip address, port, 4-byte AS capa., advertized routing tables
-session's holdtimer value and keep-alive
-received/sent BGP messages statistics (last timestamp, count)
-all msgs, keep-alive msgs, update msgs, notification msgs (error code and subcode)
-number of time the session was established
-routes count per routing table
-op. reset statistics
-op. reset session

-statistics reachable via Netconf, Restconf - as operational data and JMX (JConsole, VisulaVM, Jolokia) - as Runtime Bean.

Change-Id: I797535744176eea61d538dfa00d23cc6bfdd3da2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 2204: pcc-mock now allows zero LSPs per PCC.

Also, 127.0.0.1 is new default remote address,
and condition on number of command line arguments is removed.

Change-Id: I78491a52d60df954b35a2689a5746bcb59eb2ebd
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit b9cf0a787e53767d7093e03250c652df3228ade2)

Bug-2171: pcc-mock - logging level configuration

+ Default logging level is INFO
+ New optional command line parametter --log-level <LEVEL>
+ Varied level of log statement

-other minor fixes:
+ SymbolicPathName contains ingress IP address too.
     + Fixed issue with ByteBuffer sometimes exceeding String size.

Change-Id: Id1ded1c75d2dfc173d88c8372d7ce7e621a19aab
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 3498eac61c0ce5792631be804de6cf238c07585c)

Bug-2167: Enable pcc-mock to be bindable to differnet source addresses.

Change-Id: I72fdb8af053dc9bd6b6cb2d2c4a97173266b3916
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 132ccacc1dbe0cfaeb83de78f1db18e6dc42dee0)

BUG-2201 : fixed Ipv4/Ipv6 AdjRibsIn to use correct class

Change-Id: Ic7b274857ee55aa7b46db0e2e114d271e33225d0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug-2081: PCEP statistics

-PCEP session statistics:
-received/sent messages count
-received/sent error msgs count
-last sent msg timestamp
-last received/sent error type/value
-unknown msgs received count
-local and remote peer preferences
-keepalive, deadtimer, ip address, session-id
-PCEP session listener statistics
-remote peer stateful preferences
-session duration
-delegated lsps count
-synchronization status
-last received report msg timestamp
-received report msg count
-sent init/update msg count
-request time measurement
-tear down session op.
-reset statistics op.

-statistics are related to pcep-topology-provider config module
-reachable via JMX, NETCONF, Restconf as operational data

Change-Id: I40fd658028e386040fd6c90d805a5724aff6bddd
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-731 : removed magic numbers by refactoring Extended Communities.

Change-Id: I4907cec86eed1151f2aa61e120cf78a9a4e55091
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-731 : refactored stateful listeners"

Merge "BUG-2109 : cleaned BGP sessions on session closed."

Merge "BUG-731 : removed critical sonar warnings"

Replaced reference from deprecated junit.framework.Assert to org.junit.Assert

Change-Id: I9ffe4b258ccd5200d3c3a27456fb5bf2a61d7972
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : refactored stateful listeners

- moved nullchecks for input LSP to separate method (should fix most complexity warnings)
- moved MBB procedure to separate method

Change-Id: Icf791b41dedb408340fe4cbe2e439bceab1c1b30
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-731 : removed critical sonar warnings

Change-Id: Ic213c01c1c2ecbab3e4cd7cb7a6167713fe94a8c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2109 : cleaned BGP sessions on session closed.

Added proper close from BGP peer. Negotiation failed method now called from both sub and superclass.

Change-Id: I83e922df826c7fbb9130ca637d2dfe99d3e93a27
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Incrementing versions by 0.1.0 for post-helium master branch

Change-Id: Iac3f18084019eb0607f80a3fd60f3f985c77762a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2115 : added zero subcode to BGP CEASE Notify message to avoid NPE"

BUG-2115 : added zero subcode to BGP CEASE Notify message to avoid NPE

Change-Id: I6102d73e9bd3ff86f2238f1af249cee3094711b2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit 8be8ae9818e58e91581926646b05f70b7d070661)

BUG-2082: fix TCPMD5 dependency

This installs proper reference to TPCMD5 feature, as provided by
companion patch (*https://git.opendaylight.org/gerrit/#/c/11575/).

Change-Id: I9c475fa2fb5ab58f1e69fdf000866fe345ff4e35
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 1a4390f2fad7c349f4416421ef3cf1feb6fcff66)

BUG-1931: do not override junit version

Change-Id: I400f6172d2ff561ef8d1db96dfb2c8fe92e74b8a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bug 1924: harmonize commons-codec versions in features.xml"

Merge "Bug 1921: Remove override of guava version in features/"

Bug 1924: harmonize commons-codec versions in features.xml

Change-Id: I033fc658973491317401fd17ed4d684af1f7c2ed
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bug 1921: Remove override of guava version in features/

Change-Id: I424334140f43c5020f37f1c42004c4f312ad12b4
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Bump versions for Lithium release cycle

New version is 0.4.0, the 0.3.x is reserved for Helium release train.

Change-Id: I102f04ee12c7f6dc32046ce61861a141af13ed73
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bug-730: Add PCEPDispatcher test."

Merge "Bug-730: Add GracefulCapabilityHandler test."

Merge "Bug-1809: Fix GracefulCapabilityHandler."

Bug-730: Add PCEPDispatcher test.

Change-Id: I182c25e8c958a143014d00d7e80b2d7267550884
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-730: Add GracefulCapabilityHandler test.

Change-Id: I8f6aedf08f2e13d37a2de2738efdf9f87190151b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-730 : added null checks to tests to increase branch coverage

Change-Id: I2dc01d2c3cedc8af32f85cfc482c4466bdc6f597
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>