Merge "Simplified some pcep classes to avoid sonar warnings."

Simplified some pcep classes to avoid sonar warnings.

Change-Id: I4a8f1a87349d42aa831cc6d982970972e1295f8e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : wired cluster id with effective RIB

- added some logging along happy path

Change-Id: I4918aa9e107d143b2a09138294c5109aad827f98
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2794 : implemented comments for this class."

Merge "Revert "Add odlparent relativepath relative to autorelease""

Merge "Revert "Add odlparent relativepath relative to autorelease""

Revert "Add odlparent relativepath relative to autorelease"

This reverts commit f5ebb0f1b031002110bc6da992e7a0572d8663f9.

That commit makes assumptions about the layout outside of this
repostory, making builds unpredictable.

Change-Id: I5e2ca21f12480bf97107b348b88007b015b330b1
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 2383: Fixed minor issues and missing javadocs in RibSupportContext.

Spaces and similar.

Change-Id: I0f580ce7407398a3dbcf4b9db3e6023b85d9e9c9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Add odlparent relativepath relative to autorelease"

Per discussion on mailing list thread we have decided to revert this
change and achieve relative path updating via scripting in autorelease.

https://lists.opendaylight.org/pipermail/release/2015-March/001754.html

This reverts commit f5ebb0f1b031002110bc6da992e7a0572d8663f9.

Change-Id: I7f1bc5e7da0772b8a287023ac004698e09465997
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2383 : wire LocRibWriter

Change-Id: I327722a249c9f4aff66085428bcb70c73c575ed3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : started effective RIB writer in RIBImpl

- created a getYangRibId method in RIB to ease access
to YangInstanceIdentifier of the RIB

Change-Id: I623f0b5f904c3d0fb6d7205846da0569902447fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383: Added wiring of Attributes codecs to RibSupportContext

Provided code which adds resolution of Attributes codec
to RibSupportContext, which is shared context between
tables of same type for one instance of BGPRibImpl.

Change-Id: I43ee02c7cbab1cc9c20d659bf83454e04cf07cf6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2893 : make cluster Id non mandatory even in code

Change-Id: I8238834323f4f3d3a83a51127d2afd04154c2d88
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2794 : implemented comments for this class.

Change-Id: I98464a7a1074cffc4de22649c2b5c3b62839ddbe
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2893 - Make ClusterIdentifier configurable

Change-Id: I4c47517087ae632a9f174f5334df486a1ad69ae2
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-2383 : RIBSupport exposes Route classes rather than QNAME

Change-Id: Ia81041e8298d4f70bcea71aaac41375ac336e969
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383 : switched to ImmutableCollection

Change-Id: Ic82cf7375dc5e6d726df8ea286ab9f1923e72775
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Always activate document generation

Change-Id: I8f4c58ea3401d27e31a9f216b4c1349a32832374
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix Java8 javadoc incompatibility

Change-Id: I1e321c2d2a33808952e1b0062713aa82e5021269
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Bug 2803 - Update SR

- updated API to confirm with
  https://tools.ietf.org/html/draft-ietf-pce-segment-routing-01

- added new error type

- added abstract class with parsing and serializing SrSubobject

Change-Id: Ic3b9d5a4b0f6bd8332211bfc670c2ff2c2dc9c95
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Removed some sonar warnings.

Change-Id: I3b3966505e14ba6ff7445211ac8edd8a04884f17
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : wired codec tree factory to RIB

Change-Id: I4c928c15a9f0902453096bf8db2e1ff571209c36
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed NPE in BGPPeer.

Change-Id: Icf4f9ab08f95ff9a878634d9f00033efca0534b0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2571 : flowspec-routes model"

Bug 2824 - Fill in unrecognized attributes

- added support for parsing unrecognized path attributes
- added test for parsing unrecognized path attributes

Change-Id: Ibca8feb9c10a6f22ee6ebb4c6bf43e03af319849
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "BUG-2383 : BGPPeer now sends routes to AdjRibWriter"

Migrate AbstractConfigTest subclasses from CodecRegistry

Codec registry is being replaced by BindingRuntimeContext

Change-Id: I548a256f1814d2f94d478035baa4a6ea6a74db83
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

BUG-2383 : BGPPeer now sends routes to AdjRibWriter

Change-Id: I633c70781242b5a128a6c9982af3146dc8c4581d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : fixed creating peer list

- added some logs to AdjRibInWriter too

Change-Id: I7ebd1414d71da09a302bb5833b545c49524fc22b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Improve compatibility with Java 8 javadoc

This fixes various javadoc inconsistencies reported by JDK8.

Change-Id: Ic41c2d16e8191885266b6b8f440fe17eb5ec159c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "Moved tests out of config test directory."

Merge "BUG-2383 : added tests & documentation for AbstractRIBSupport"

BUG-2383 : added tests & documentation for AbstractRIBSupport

Change-Id: I518d355370161ce07de3f4440e6a20d23d8a4de5
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2867: Make IANA assigned Linkstate attribute type as default (29)."

BUG-2867: Make IANA assigned Linkstate attribute type as default (29).

Change-Id: Ie1e3d4393298a51dda846df2ea1a8f6aef22d3b8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Moved tests out of config test directory.

Change-Id: I24556612c59bb8704f7607236b1e9a8b58a7af68
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383 : fixed missing configuration file

Change-Id: I51c447b8b52deb790dc40bbab8f61127ed938698
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383: wire up AdjRibInWriter

Modify AdjRibInWriter lifecycle to fit with BGPPeer actions. Also make
sure we pick up the transaction chain from RIB.

Change-Id: Ide7b7bf3073d5a106608d555577535a079ed2b37
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383: wire DOMDataBroker into RIBImpl

We will need DOMDataBroker, so let's be sure to wire it in.

Change-Id: I04dafd0e394291c9146c19a0bb88e9cf6410efdc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Renamed OffsetMap tests

Change-Id: I37d7b3a9bb6b95bd391148842c4a516e0dea315d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383: RibReference should expose the key"

Merge "BUG-2383: split out policies into separate files"

BUG-2383 : fixed Destination container

Change-Id: I38ddd1834ba31de60221b08ad43be14a8ed457f1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383 : split ipv4/6 to separate model"

BUG-2383: RibReference should expose the key

RibKey will be needed to simply convert the reference into a
YangInstanceIdentifier.

Change-Id: Id5d2c79cad02b85648a359764d70e2c9eecb59ef
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: split out policies into separate files

Static policies kwill not work, as some of them require additional
arguments to perform their role. Split them out, so they can be evolved
independently.

Change-Id: I33decf294c53391d4d705014adfd62b6d5ffa34d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add odlparent relativepath relative to autorelease

Change-Id: Iafdafcb1afdd7e14443a827327c9993c9456837d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-2383 : split ipv4/6 to separate model

- changed models: bgp-rib and bgp-multiprotocol
- created new artefact bgp-inet, that holds this model
- code rewritten to use this new artefact

Change-Id: I069f2c42a7e22c624a5549b09da8d07bd0d1acaf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2383 : moved AbstractRIBSupport class"

BUG-2383 : moved AbstractRIBSupport class

- this class is probably by mistake in config package,
move it to bgpcep

Change-Id: I0e6dd856b3fab5f7fe8aba0987f92b29b99195bf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Test for OffsetMap

Change-Id: I2696bb79d5bd30f6697abd407c898f0872d3a163
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Test for BestPathSelector

Change-Id: I62dd07b1dd4062fe6c5d70fc3d9ee29506f6d609
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "Remove bundle tests"

Remove bundle tests

Bundles are already tested in features, so we do not need these
hard-to-maintain tests.

Change-Id: I9c03b841892aa8d8f28417c910de15d4cd407d2a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Removed some sonar warnings in the new RIB code.

- mostly attribute ordering, annotations are first
- final in method declaration is rarely necessary
- added default case to switch statements

Change-Id: I44abf4512fe64eb59504e0081d3dc88f23381960
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed MD-SAL configuration mock.

Change-Id: I6da602da465f6481c9e3a1ebadc6ef54aa7329e0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "Bug 2795 - Internal PCEP features hierarchy does not reflect config files"

Pushed missing .project files.

Change-Id: I0ee592cbb52ce89ed186ac5edb08a15dc8e6514d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Bug 2795 - Internal PCEP features hierarchy does not reflect config files

- added odl-bgpcep-programming-impl feature as depedency of
  odl-bgpcep-pcep-topology-provider feature

Change-Id: I5b306d6caa9a05bd14924da9daaeb50a853a900e
Signed-off-by: Ladislav Borak <lborak@cisco.com>

BUG-2383: document AbstractRIBSupport abstract methods

Add javadoc and rename for consistency.

Change-Id: I153f7f0ecfccd45084b95779a514a23008d30296
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2383: construct route entry properly"

Merge "BUG-2383: implement EffectiveRibInWriter"

Merge "BUG-2383 : synchronize message/route linkstate core in model"

BUG-2383: construct route entry properly

This adds the code to add attributes onto the route object.

Change-Id: Ibeee10d21114ae2344fbacb3d92ab6aa03da9354
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: implement EffectiveRibInWriter

This completes the basic structure of EffectiveRibInWriter, such that
its flows are stable API-wise.

Change-Id: Idebad5a1d05667cdd767d16dc9278574dba1d3f6
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383 : synchronize message/route linkstate core in model

- there is no need to have the data in linkstate described in
two ways (for parser and for RIB). This commit eliminates the
parser data representation and uses RIB data represenation.
- the code and tests needed to be adjusted
- NlriType is eliminated from the data

Change-Id: I364b7f2d26dc44e0d22d0f7358c3e0d6991322bf
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-2383: Make TableContext.clearTable() reusable

An input table context is bound to a table. Refactor clearTable() to be
usable from other contexts, too.

Change-Id: Ic91326bf9f931f8dc1298ba67439253dece50e4c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: introduce ExportPolicyPeerTracker

This splits out the policy tracker and implemnts proper policy tracking.
We optimize for lookup speeds, expecting the peers not to change much.

Change-Id: I92b27d54abb77ce10864d9ec8709a57aab7b87c7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: split out AbstractPeerRoleTracker and IdentifierUtils

Functionality of these two classes is shared between multiple listeners,
so move them out to be shared. Also make sure EffectiveRibInWriter
instantiates its policy tracker.

Change-Id: If885ea283ed223cdffe8c14f777192d02cabffde
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Do not replicate Sonar config"

Merge "Support proper route redistribution"

Merge "BUG-2383: fix a warning"

Merge "BUG-2383: refactor RIBSupportRegistry"

Merge "BUG-2383: rename BGPSessionImpl.sendMessage()"

Merge "BUG-2383: add a non-flushing message write method"

Merge "BUG-2383: introduce AdjRibOutListener"

Merge "BUG-2283: introduce OutputLimiter"

Merge "BUG-2383: rework RIB inbound"

BUG-2383: fix a warning

The cast is valid, but let's use one which does not trigger a warning.

Change-Id: I577efc001f7b06fce0806fc1149f79116a03bdd5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: refactor RIBSupportRegistry

Migrate registration and lookup into RIBExtensionContexts.

Change-Id: Ia1cdfb1052abc923c79ecada0ca62c99d3ed731a
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: rename BGPSessionImpl.sendMessage()

The method performs a write-and-flush, so let's call it writeAndFlush().

Change-Id: I20bc4db103f2a671bed0f33919ae3978c892af11
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: add a non-flushing message write method

When performing route dissemination, we may need to enqueue multiple
messages before flushing. This patch adds and API to perform that and
add the corresponding capability to ChannelOutputLimiter.

Change-Id: I048c6f6a84ced775ce1890cc1369ee8fff97cd1f
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: introduce AdjRibOutListener

The listener forwards a specific table towards the session with a peer.

Change-Id: I9b1241df2f0d8e8e06d3af62f206232f20d27465
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2283: introduce OutputLimiter

This is a simple utility class to perform backpressure based on channel
writability.

Change-Id: I2b4018722eee9dfa88ff92d49d17b969134a7de3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not replicate Sonar config

These declarations are already in odlparent, no need to repeat them.

Change-Id: I866a1fa991e251582b8baf78f119bc4282e9227e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix an checkstyle not being recognized by eclipse

Since we override mappings, we need to make sure we carry checkstyle
declaration, otherwise eclipse reports an error.

Change-Id: I6fe6ea161ea963883284f68ed6faffe06f7d8f58
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure we execute the maven plugin

This will make it easier on the developers, as eclipse will
automatically generate bindings.

Change-Id: I55df6997361195b3da8c506a68527349edb6201a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not override maven-dependency-plugin version

odlparent already defines it to 2.10, we were reverting it to 2.8.

Change-Id: I489264ffa8805f24cc9db355e224c35fcb8cab3d
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: rework RIB inbound

Each Peer (like BGPPeer) performs updates the adj-rib-in via a dedicated
AdjRibInWriter instance. That class, along with RIBSupport and TableContext,
is responsible for translating the Binding-Aware messages coming from
the message parser into Binding-Independent form within the datastore.

Changes are then propagated via DataChangeNotifications into
InboundPolicyEnforcer, which performs any munging of attributes required
and checks if the route is eligible for inclusion in the local RIB. If
it is, the route is output into the effective-rib-in hosted in the
datastore.

From there it is picked up by BestPathSelection, which compares the
effective routes from multiple peers and installs the best one into the
local RIB.

Change-Id: Ie23746b2fc44499f42d346595562b498c19fd112
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "BUG-2383: add BestPathSelector and related classes"

Merge "BUG-2383: introduce OffsetMap"

Merge "BUG-2383: fix the RIB model"

BUG-2383: add BestPathSelector and related classes

Introduce a utility BestPath class along with a builder-style selector.
The selector can be run incrementally by initiating the state from
previous selection run, then feeding all candidates and finally
extracting the best-matching path.

Change-Id: I34aab7f0c2ab4b917597a77d54508f5d93e6a8c9
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: introduce OffsetMap

For the sectionprocess we will need a compact way of tracing
peer/attribute mappings. Storing things in array is the most compact
form, but we need to manage a lookup table. This is the role of
OffsetMap, which maps an UnsignedInteger (e.g. a BGP Identifier) to an
offset. We then need to only allocate a single array for each entry to
hold the actual values.

Change-Id: I7c4c8b841cca0330f9646e5e629a824fd929f181
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2383: fix the RIB model

The overall goal is to store adjacency ribs in the datastore. In order
to do that, we need to fix the (defunct) model, so each peer has a
unique subtree. This patch fixes the model and introduces a peer ID
type, which we will use throughout to identify peers.

Change-Id: I45a4493d0aabb29828e6e935017939a5b09e7b60
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2749 : deprecate unused methods

- cannot be removed, they are used in stateful02

Change-Id: I08d149b7fc9dbf376942104d3eb4f35fa1a02a93
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "BUG-2794 : refactored code to use BitArray"

Fixed IT breakage after migration of NSF from controller.

PcepServices test declared uncessary dependencies on
model-inventory, which was transitive compile dependency.

Transitive dependency relationship via sal-binding-it
was removed during removal of NSF from controller,
which prevented pax-exam starting these pcep test.

Removed offending declaration, since is not needed
for test to be run.

Change-Id: Ib505bbd0f91407ec6c7f89995b19fe61b1437d94
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-2794 : refactored code to use BitArray

Change-Id: I8906ec2b9671cd71916f0e3c4225199cf5963bdc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Ladislav Borak <lborak@cisco.com>

Merge "BUG-2794 : created BitArray class"