summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
Stephen Kitt [Mon, 15 May 2017 13:15:08 +0000 (15:15 +0200)]
StringBuffer cleanup
This patch cleans up StringBuffer use, mostly replacing StringBuffer
with StringBuilder or plain String concatenation for short sequences
(or constants).
* HexEncode: additionally, avoid using a separate return variable,
drop the useless ":" handling in bytesToHexString(), and add the
test class from l2switch.
* HardcodedModuleFactoriesResolver: rework the conflicting module
handling.
Change-Id: Id76e91bba9ce40bd8ed5947c2d40e3a7baf0a949
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 11 May 2017 16:54:05 +0000 (18:54 +0200)]
liblldp: final parameters
This automatically-generated patch flags all appropriate parameters as
final (including caught exceptions).
Change-Id: If4e0f5e379b1c4f00970e862a775db372cc191fe
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Belur [Tue, 11 Apr 2017 01:45:30 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ife090ef2c9bb25e515b2fb06e2766c56d8174d76
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Michael Vorburger [Tue, 31 Jan 2017 13:15:52 +0000 (14:15 +0100)]
Remove bad manifestLocation from maven-bundle-plugin
Change-Id: I7741c11a21393510af4dcb452e721abd236a9c2c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Thu, 24 Nov 2016 22:56:18 +0000 (23:56 +0100)]
Fix javadocs and enable doclint
This eliminates the doclint suppression and fixes up javadoc, so they
work with Java 8 out of the box.
Change-Id: I7294f0dcd570e3e3c445e54cc8989078175d05d7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Alexis de Talhouët [Thu, 27 Oct 2016 03:13:26 +0000 (23:13 -0400)]
Do not use opendaylight/commons/opendaylight as parent
Change-Id: I9a858c90274c7c82bac75fc7931a10c1ff707ef8
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Mon, 24 Oct 2016 23:48:05 +0000 (19:48 -0400)]
Revert "Clean-up pom.xml layout"
Since this got merged, I'm facing issue building the project correctly, it's
failing in samples/toaster-it and runtime is broken because of mess-up classpath.
If others are facing the same issue, this should be merged.
I'll rework the overall patch later.
This reverts commit
8a637013c102c11323230dae08fa4407863945d6.
Change-Id: I61aae87439736d0163e6b4c49d8753052b28bac0
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Fri, 7 Oct 2016 21:26:17 +0000 (17:26 -0400)]
Clean-up pom.xml layout
Do not depend on opendaylight/commons/opendaylight/pom.xml
Change-Id: Ic7313dc6b703739a6c14b1f0cd1a37ba3b7827af
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Stephen Kitt [Thu, 22 Sep 2016 15:08:38 +0000 (17:08 +0200)]
Mechanical code cleanup (commons)
* Remove unnecessary type specifiers (use Java 7 <>)
* Remove unnecessary "extends Object" declarations
* Remove unnecessary semi-colons
* Merge identical catch blocks
* Remove redundant modifiers:
- enum constructors are private by default
- interface properties are public static final by default
- interface methods are public abstract by default
- interfaces are abstract by default
- inner interfaces are static by default
- inner classes in interfaces are public static by default
Change-Id: If1805b63e52c1ab0c68983e7856e7ccf184cb2a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Thanh Ha [Mon, 8 Aug 2016 21:50:13 +0000 (17:50 -0400)]
Bump versions by 0.1.0 for next dev cycle
Change-Id: I9c4a4b1e6d0e101392fb19dc68f814e30de4fa5c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Wed, 6 Apr 2016 20:29:27 +0000 (16:29 -0400)]
Disable Java 8 linter on projects that fail
The new Java 8 linter is more strict and causes docs failures on several
projects. Disable it for projects that currently does not pass the
linter.
Change-Id: I0d29bad0a797aceeb9076eea8f80bcc071432b4c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Fri, 15 Jan 2016 01:14:41 +0000 (20:14 -0500)]
Bumping versions by 0.1.0 for next dev cycle
Change-Id: I2155a23eb208cc34d29b3e5ee0c8f6a3f551cacf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Gary Wu [Mon, 4 Jan 2016 19:48:18 +0000 (11:48 -0800)]
Remove unnecessary casts
Change-Id: Ib20f8d15529293ee9037c7213ed5eb388ba532ac
Signed-off-by: Gary Wu <gary.wu1@huawei.com>
Vratko Polak [Wed, 23 Sep 2015 17:33:28 +0000 (19:33 +0200)]
Bug 4202: Migrate also toaster to use mdsal project
This only changes dependency feature omitted from Change 26079,
perhaps Java edits are also needed to keep toaster working.
Also, git has somehow enforced change of line endings everywhere.
Change-Id: I810fba0ae7a55e123dd6f78ba23a7e77a7118b57
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Thanh Ha [Sun, 9 Aug 2015 05:44:50 +0000 (01:44 -0400)]
Fix license header violations in liblldp
Change-Id: Id95bd1cef35d256e79a3303c6559405364ae4ced
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Jan-Simon Möller [Wed, 3 Jun 2015 13:41:22 +0000 (15:41 +0200)]
[RFC][Fix] Fix for connection in pom.xml.
The connection value was wrong.
Apply values proposed by zxiiro.
Also fix sal-dom-xsql (wrong developerConnection).
This allows me to run mvn site
w/o failing due to the wrong entry.
Change-Id: I15d953647a40dde4b37246a78bae120552efb15b
Signed-off-by: Jan-Simon Möller <jsmoeller@linuxfoundation.org>
Jozef Gloncak [Thu, 28 May 2015 07:24:04 +0000 (09:24 +0200)]
BUG 2820: Fix breakage from Import-Package
Change-Id: I41401d4745c2126ccdc7ed9dffee3299aae9ed0c
Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
6759779bebf8d724f35518c45a114cca2a0da60c)
Jozef Gloncak [Thu, 28 May 2015 09:20:40 +0000 (11:20 +0200)]
Minor changes in LibLLDP
- change modifier of emptyTLV field to final
- added cisco header to CustomTLVKey class
- formatting CustomTlvKey and LLDPTest classes
Change-Id: Ic347f549fb3ba3a97e9b6f02883445c852cd3eb8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
(cherry picked from commit
1bdead40997cbe805630fced64c93e328a354275)
Tony Tkacik [Tue, 5 May 2015 08:23:31 +0000 (08:23 +0000)]
Merge "BUG 2820 - LLDP refactor"
Tony Tkacik [Tue, 5 May 2015 08:23:19 +0000 (08:23 +0000)]
Merge "Bug 2820 - LLDP TLV support and testing"
Tony Tkacik [Tue, 5 May 2015 08:23:12 +0000 (08:23 +0000)]
Merge "Bug 2820 - problem to add second TLV with type 127."
Tony Tkacik [Thu, 23 Apr 2015 14:19:33 +0000 (14:19 +0000)]
Bumped controller version by minor for next release cycle.
Change-Id: I80ea0aecf42e5ee96dcebc68af1e872b1f10e7b5
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Jozef Gloncak [Tue, 17 Mar 2015 12:35:51 +0000 (13:35 +0100)]
BUG 2820 - LLDP refactor
LLDP class field changed from tlvList to mandatoryTLVs, optionalTLVs, customTLVs
Added new create custom TLV value in order to hold security hint for LLDP topology discovery.
Fixed guava bundle import
Fixed apache-lang3 bundle import
Change-Id: I5d0c6b9a9e29213d3f25aa99ff7edd5b30e6c7a8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
26dfd63f953982f661e4e72f306c6a6b8e02cfd4)
Jozef Gloncak [Tue, 17 Mar 2015 11:50:15 +0000 (12:50 +0100)]
Bug 2820 - LLDP TLV support and testing
- enhancement: deserialization now supports custom TLV
- tests:
- LLDP.deserialize
- LLDPTLV.createCustomValue
- LLDPTLV.getCustomString
- beautified (checkstyle)
Change-Id: I56c807b46d889266fc43cdc9b35d00bf17bb4d09
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
91a47340196d4a5bbf9beaaed9a202bf4a8836d9)
Jozef Gloncak [Tue, 17 Mar 2015 10:34:03 +0000 (11:34 +0100)]
Bug 2820 - problem to add second TLV with type 127.
Custom TLVs aren't saved to map with key type but are stored in
standalone array.
- fixed list copy (for custom TLV list)
- extended test
- involved custom TLV list items into packet length counting
- published
Change-Id: Ifa1cab17206e1be37022bc8b49f7990649cbd356
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit
254ab138bab0132a9afafe6227bc998e9dfa7a44)
Thanh Ha [Wed, 10 Dec 2014 00:19:16 +0000 (19:19 -0500)]
Fix checkstyle if-statements must use braces liblldp
Change-Id: I2e36139dbeea5890a7eec7003da186af162e8998
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Robert Varga [Fri, 7 Nov 2014 12:42:30 +0000 (13:42 +0100)]
Update junit Assert imports
JUnit 4.11 has moved Assert to org.junit, and deprecated
junit.framework.Assert. This adjust the imports to fix the warnings.
Change-Id: Iecbf2a1b4ae097989e840ad6f6d5bf759c521639
Signed-off-by: Robert Varga <rovarga@cisco.com>
Colin Dixon [Fri, 3 Oct 2014 22:55:46 +0000 (17:55 -0500)]
Incrementing versions by 0.1.0 for post-Helium master branch
* The only version not incrmented is aaa.version, which is left at
0.1.0-SNAPSHOT since they depend on controller and can't update yet.
* To break the cyclic dependency, this patch temporarily stops running
the netconf-connector and restconf feature tests.
* Also fixing a bug causing Errors like "Choice has two nodes case with
same qnames".
A second patch (to be run after AAA increments their versions to
0.2.0-SNAPSHOT) wiil update aaa.version and re-enable these tests.
Change-Id: I70a3987d32504e798c5ed05a67a0a1174338844b
Signed-off-by: Colin Dixon <colin@colindixon.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Mon, 11 Aug 2014 04:19:06 +0000 (23:19 -0500)]
Fix to topology-lldp-discovery to allow for clean karaf feature
Change-Id: Ife3388610a2d816f7bb8e5214cc98d123c4b604b
Signed-off-by: Ed Warnicke <eaw@cisco.com>