lispflowmapping.git
8 years agoReorganize mappingservice.implementation 57/25457/9
Florin Coras [Wed, 19 Aug 2015 00:54:24 +0000 (02:54 +0200)]
Reorganize mappingservice.implementation

This consists of a number of incremental changes ultimately meant to
ensure the clear separation between the components implementing the LISP
control plane logic (MapServer/MapResolver) and the logic used to
manipulate the database that stores mapping state. This should give us
better isolation (i.e, should help testing) but also opens the
possibility to better optimize DAO/map-cache implementation for specific
use-cases, if needed.

Noteworthy changes:
- Move out code concerning logic behind CRUD operations on DAO from
  MapServer and MapResolver to DAOMappingUtil. In future patches the
  latter will be converted to a MapCache class instead of a helper
  class.
- Move serializer and LISP protocol utility functions from
  mappingservice.implementation to yangmodel.
- Remove bundle dependencies on mappingservice.implementation. Bundles
  should be importing mappingservice.api.
- Cleanup pom files

Change-Id: I199b8d2162cd2ab2b54cd3340eb24811fd6cd5be
Signed-off-by: Florin Coras <fcoras@cisco.com>
8 years agoMove integration tests to mdsal-it-parent 88/25388/6
Lorand Jakab [Fri, 21 Aug 2015 11:00:25 +0000 (14:00 +0300)]
Move integration tests to mdsal-it-parent

Change-Id: I233e61d53988036db34cdc78b48e94b9db004fae
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoMove features to features-parent 90/25290/1
Lorand Jakab [Fri, 14 Aug 2015 13:57:17 +0000 (16:57 +0300)]
Move features to features-parent

Because:
  1) It's sort of needed for karaf based IT
  2) Less maintenance burden
  3) It's the RightThing(tm)

Change-Id: I5b527daea160e1bcc0509bda9c12f96816e1a8b9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoRemoving mappingservice.netconf and its dependencies from build 67/25267/3
Florin Coras [Thu, 13 Aug 2015 21:17:40 +0000 (23:17 +0200)]
Removing mappingservice.netconf and its dependencies from build

Change-Id: I2e16ff038fbe5e3fbfc25c41968384a20cdb329d
Signed-off-by: Florin Coras <fcoras@cisco.com>
8 years agoFix breakage caused by config/netconf decoupling 53/25253/1
Lorand Jakab [Thu, 13 Aug 2015 16:41:29 +0000 (19:41 +0300)]
Fix breakage caused by config/netconf decoupling

Gerrit https://git.opendaylight.org/gerrit/#/c/23413 broke the build,
this commit fixes it.

Change-Id: I87c9b738d31a94f51d0f99f79cce89119627ff56
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoAdd basic Site-ID support to mappings 31/25231/1
Lorand Jakab [Wed, 12 Aug 2015 14:13:33 +0000 (17:13 +0300)]
Add basic Site-ID support to mappings

This patch adds basic support for storing a list of Site-IDs with a
mapping in the MD-SAL config datastore, both from the southbound via
Map-Register messages and from the RESTCONF interface. Using RPCs is not
supported yet. This is useful for grouping EIDs belonging to the same
site in the topology view of the LISP UI.

Change-Id: Ie2ffc2dfb5f922ca5be3e3282ef63af0f0054f43
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoUnclutter DEBUG log output 25/25225/1
Lorand Jakab [Thu, 13 Aug 2015 09:47:18 +0000 (12:47 +0300)]
Unclutter DEBUG log output

Move log messages that print out entire data structures to TRACE level,
so that users can switch between full detail (TRACE) and somewhat easy
to follow (DEBUG) output.

Change-Id: I41750e9e044bfcb2177a17a091e9c8648d8ba69a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoMerge "added suport for lisp southbound to act also as a mapping service client."
Lori Jakab [Wed, 12 Aug 2015 12:35:49 +0000 (12:35 +0000)]
Merge "added suport for lisp southbound to act also as a mapping service client."

8 years agoBug 4079: Fix regression introduced by Change-Id I3e9f92dcbb2d6bd82384d7229320e979b68... 42/25142/1
Lorand Jakab [Tue, 11 Aug 2015 10:32:56 +0000 (13:32 +0300)]
Bug 4079: Fix regression introduced by Change-Id I3e9f92dcbb2d6bd82384d7229320e979b68461d5

Change-Id: Id08dabdd577b2bb6575a205fb89e8e3f2d08b488
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoBug 4057: Make subscriber HashMap concurrent 21/24921/1
Lorand Jakab [Fri, 7 Aug 2015 12:35:51 +0000 (15:35 +0300)]
Bug 4057: Make subscriber HashMap concurrent

Change-Id: Ic3a70ccca9202584dcd293f2ca2a5459d7324ab2
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 7c370deff1cb8d0ecce845eb0d3bd874174d40b7)

8 years agoBug 4097: Don't add subscribers with no Source-EID 04/24904/1
Lorand Jakab [Thu, 6 Aug 2015 00:01:57 +0000 (03:01 +0300)]
Bug 4097: Don't add subscribers with no Source-EID

Change-Id: I3e9f92dcbb2d6bd82384d7229320e979b68461d5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 0d464b04187c2456e57ac5d758ccfac686f48618)

8 years agoadded suport for lisp southbound to act also as a mapping service client. 84/24884/1
David Goldberg [Mon, 19 Jan 2015 12:50:12 +0000 (14:50 +0200)]
added suport for lisp southbound to act also as a mapping service client.

Change-Id: Ic82bc85fd4254903ab39499b9f53348ede3c22b9
Signed-off-by: David Goldberg <david.goldberg@contextream.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit d1f12050a011dd8b08e10e23638bb3b1e2e53c3f)

8 years agoBug 4077: Send SMR when deleting a Src/Dst mapping 24/24824/1
Lorand Jakab [Wed, 5 Aug 2015 22:28:57 +0000 (01:28 +0300)]
Bug 4077: Send SMR when deleting a Src/Dst mapping

When we had a general mapping and within that a src/dst mapping,
deleting the src/dst mapping was not generating an SMR to the
subscribers of said  mapping. This commit fixes that.

Change-Id: I199af9f8558a8ebbf4a100f224c570893f548c20
Reported-by: Vina Ermagan <vermagan@cisco.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 551b102f4ae329dca674509120acbecfd035b716)

8 years agoBug 4046: Fix EID Record in SMRs 51/24451/1
Lorand Jakab [Thu, 23 Jul 2015 00:04:56 +0000 (17:04 -0700)]
Bug 4046: Fix EID Record in SMRs

Change-Id: I6712d47c7b3f877d01143b77203afffd47aaf812
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 65e3afef3b1362821dd4c54b3f9b18ab91069dac)

8 years agoBug 3995: Store empty mappings in DAO 62/24362/1
Lorand Jakab [Tue, 21 Jul 2015 04:52:11 +0000 (21:52 -0700)]
Bug 3995: Store empty mappings in DAO

Since empty mappings (mappings without a locator set) are not stored in
the DAO, we have an inconsistency between MD-SAL (which does store such
mappings) and the DAO. Additionally, it makes it impossible to set a
specific action for a specific EID, when no locators are present, for
example a simple "drop" policy. This commit makes it possible to store
and retrieve empty mappings from the DAO.

Change-Id: I9a380d3e7a1d4281b512854cffdc2f6eda6a277c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit dd034830cd0cb464d6bd2527a92f51bd14891008)

8 years agoBug 4005: Fix SMRs 27/24327/1
Florin Coras [Fri, 17 Jul 2015 01:55:10 +0000 (03:55 +0200)]
Bug 4005: Fix SMRs

Change-Id: I58bbbe77a219f2c65fd3dee9e830fc2da8a0f8a7
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from e5a682941b8a0b8d020e9b406220e2cf47fd8148)

8 years agoBug 4005: Set the correct Source-EID in SMRs 26/24326/1
Lorand Jakab [Thu, 16 Jul 2015 09:57:25 +0000 (12:57 +0300)]
Bug 4005: Set the correct Source-EID in SMRs

Change-Id: Ifdf0812db44f0e2eb6ce880a7ad23b67b29632f3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit cb225f62c71a5b42d35afc366c719d7518675912)

8 years agoBug 4012: Fix NPEs due to insertion/removal of negative mappings 23/24223/1
Florin Coras [Fri, 17 Jul 2015 01:26:06 +0000 (03:26 +0200)]
Bug 4012: Fix NPEs due to insertion/removal of negative mappings

Change-Id: I3b475a6c0e99cec6652e308daaba1552cfe9f241
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit c8f77f83890002aa135d7b8ebb2502e9c68e267f)

8 years agoBug 4011: Fix LocatorRecord routed flag in Map-Replies 22/24222/1
Florin Coras [Fri, 17 Jul 2015 00:49:47 +0000 (02:49 +0200)]
Bug 4011: Fix LocatorRecord routed flag in Map-Replies

Change-Id: I1393f9f15601734e341b3f01463052d30661319e
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 6b82aa0cf29f30b9ff16f3e993fd8ab1ef50150b)

8 years agoImprove exception code 96/24096/2
Lorand Jakab [Tue, 14 Jul 2015 12:07:19 +0000 (15:07 +0300)]
Improve exception code

Change-Id: If86fe497c1b8f89a50a919088638a14ce8117c5c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoBug 3877: Fix sending SMR to IPv6 subscribers 63/24063/2
Lorand Jakab [Mon, 13 Jul 2015 16:32:14 +0000 (19:32 +0300)]
Bug 3877: Fix sending SMR to IPv6 subscribers

Additionally, make the exception for failed SMRs more helpful, since it
only showed a pointer address of the stack trace, not the actual trace.

Change-Id: Ic7861c14c6d87bd9cc93eb69b3158532a229a15e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 8b3bcab42d6ab687c9307d57fb67c01cfe37d577)

8 years agoMove HashMapDb to its own bundle 64/24064/2
Florin Coras [Mon, 13 Jul 2015 00:20:28 +0000 (02:20 +0200)]
Move HashMapDb to its own bundle

HashMapDb is a simple, in memory implementation of ILispDAO, the
interface that defines the API for the interaction with the Map-Server's
mappings database. Until now, HashMapDb was part of
mappingservice.implementation but with this commit it is moved to its
own mappingservice.inmemorydb bundle.

An important feature is that a ILispDAO implementation is now injected
into mappingservice.implementation at runtime through config-subsystem.
As a result, InMemoryDb can be easily swapped with other implementations.

Change-Id: I29af97b831414eecbbf3c29e6fbec086a627a770
Signed-off-by: Florin Coras <fcoras@cisco.com>
8 years agoBug 3979: Fix NPE for get-mapping RPC when mapping contains ELP 88/23988/1
Florin Coras [Fri, 10 Jul 2015 11:43:18 +0000 (13:43 +0200)]
Bug 3979: Fix NPE for get-mapping RPC when mapping contains ELP

Change-Id: Ie6ec638c0c10e62f7eb8b0aee2b875dc1b10d815
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit e9ce10cd33e357c6070598b5a4e2daca45cb0c33)

8 years agoBug 3951: Send SMRs to both SrcDst and Dst subscribers 81/23881/1
Florin Coras [Tue, 7 Jul 2015 15:20:01 +0000 (17:20 +0200)]
Bug 3951: Send SMRs to both SrcDst and Dst subscribers

Change-Id: I6754d02e67005b74be033dbbea2395910b8c479c
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 5d2c9ca667c38dd83d072d8487e7e6c477694991)

8 years agoBug 3951: For Src/Dst update, SMR Dst EID 51/23851/2
Lorand Jakab [Tue, 7 Jul 2015 12:25:38 +0000 (15:25 +0300)]
Bug 3951: For Src/Dst update, SMR Dst EID

Change-Id: I00c8b22a8a3c8c99e6d8d6fe6d5c6fd4fed626d5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit d27bd6bdb61db7d0385dc5c616ce43928b6eee19)

8 years agoMerge "Bug 3950: SMR parent subscribers on Src/Dst mapping change"
Lorand Jakab [Tue, 7 Jul 2015 19:11:21 +0000 (19:11 +0000)]
Merge "Bug 3950: SMR parent subscribers on Src/Dst mapping change"

8 years agoBug 3950: SMR parent subscribers on Src/Dst mapping change 32/23832/2
Lorand Jakab [Tue, 7 Jul 2015 12:16:25 +0000 (15:16 +0300)]
Bug 3950: SMR parent subscribers on Src/Dst mapping change

Change-Id: Iaf0dc0a62c04e4c67913d67d7b9bb18bba343ce6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit f4246f57e06d62b2617a405d8351da5a53207fa8)

8 years agoBug 3946: Fix 'lisp:mappings' output for SrcDst 34/23834/1
Lorand Jakab [Tue, 7 Jul 2015 11:14:15 +0000 (14:14 +0300)]
Bug 3946: Fix 'lisp:mappings' output for SrcDst

Change-Id: Iea973d6af98e3446885b844385c15fabcbff3820
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 348aaae0421edb85de3958736f3cee925425c05c)

8 years agoBug 3781: Fix locator list name hack 06/23806/1
Lorand Jakab [Tue, 7 Jul 2015 07:35:57 +0000 (10:35 +0300)]
Bug 3781: Fix locator list name hack

There is an inconsistency in the mapping stored and the mapping
retrieved from the DAO, since the list key called 'name' for
LocatorRecord is autogenerated when replying. It looks like now a
getName() method is available, so we can retrieve the original key.

Change-Id: I28263028b1907720e4433b0336989a358abcf1c4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit adcd2d69ec06c36bda88380151d2f6d4725e49b0)

8 years agoClean neutron POM file 29/23129/1
Florin Coras [Sat, 20 Jun 2015 02:07:02 +0000 (19:07 -0700)]
Clean neutron POM file

Change-Id: I939aeaa20922ed4feb221409a550b0734d3c298a
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 7fd15a56c31c23f95ca5e7629ac1413a26161db2)

8 years agoBug 3819: Fixing the inconsistency by using RPC to register 24/23024/1
Vina Ermagan [Thu, 18 Jun 2015 20:18:04 +0000 (13:18 -0700)]
Bug 3819: Fixing the inconsistency by using RPC to register

Change-Id: Ib390645f507ff011d7596e72d8b85ac17eb3038c
Signed-off-by: Vina Ermagan <vermagan@cisco.com>
(cherry picked from commit 277df59662c96e76b0ffddeac3526f5b26e808c4)

8 years agoMerge "Bug 3809: Fix pitr bit processing in MapResolver"
Vina Ermagan [Fri, 19 Jun 2015 00:39:33 +0000 (00:39 +0000)]
Merge "Bug 3809: Fix pitr bit processing in MapResolver"

8 years agoBug 3813: Fix elp handling in map-replies 43/22943/1
Florin Coras [Thu, 18 Jun 2015 22:44:57 +0000 (15:44 -0700)]
Bug 3813: Fix elp handling in map-replies

Change-Id: I2233b23e8c67cde3e5a9085fbd9c9130e379bfa7
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit cdbed83af5d3ec129eaf734e6d1a683320841904)

8 years agoBug 3809: Fix pitr bit processing in MapResolver 42/22942/1
Florin Coras [Thu, 18 Jun 2015 21:34:17 +0000 (14:34 -0700)]
Bug 3809: Fix pitr bit processing in MapResolver

Change-Id: I10fac0c722b1ae662f627f3197349ded0d6f9ab9
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 79031421451059e97e399f99e5798e9c3515723d)

8 years agoBug 3807: Fix SMR not being sent on mapping change 22/22922/2
Lorand Jakab [Thu, 18 Jun 2015 19:59:44 +0000 (22:59 +0300)]
Bug 3807: Fix SMR not being sent on mapping change

Change-Id: I42d52bb813c936643162328fb49a9c81d3ad5968
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 4abb7ea3a56be83ed4ff27462a5fa03a23b15a3f)

8 years agoBug 3798: Fix NPE when restoring dao from an empty mdsal datastore 65/22865/1
Florin Coras [Thu, 18 Jun 2015 08:55:49 +0000 (01:55 -0700)]
Bug 3798: Fix NPE when restoring dao from an empty mdsal datastore

Change-Id: I14b53e1455fc653ced92906247f2d84232148135
Signed-off-by: Florin Coras <fcoras@cisco.com>
(cherry picked from commit 0456793ff120dc7a643053efbf83dad240493697)

8 years agoBug 3781: Return all locators on the RPC interface 52/22852/1
Lorand Jakab [Wed, 17 Jun 2015 20:34:33 +0000 (23:34 +0300)]
Bug 3781: Return all locators on the RPC interface

When using the RPC interface to retrieve mappings, the DAO backend is
queried for the data.  Howver, the DAO doesn't store the 'name' list key
for a mapping, and so far the string "Autogenerated" was returned for
each locator.  It looks like the ODL RPC implementation doesn't allow
list entries with duplicate keys, so only one locator was returned to
the user (even though the LISP code handled all).

This commit changes to "Autogenerated" string to be the textual
representation of the locator.  This does not fully solve the bug,
since it is theoretically possible to list the same locator more than
once in a mapping.  That is not the case for normal operation however,
so at least we can lower the severity of the bug from 'critical' to
'minor'.

The proper fix is to store the user supplied key for the locator in the
DAO.

Change-Id: Icdfeb4a7ce9a79c16e854e8e92ebd6d1f7d30ed5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit a547901fc0f71feb4216bda5d69a73c82947e679)

8 years agoMerge "Bug 3765: Restore dao from mdsal config datastore at startup"
Lori Jakab [Wed, 17 Jun 2015 19:56:00 +0000 (19:56 +0000)]
Merge "Bug 3765: Restore dao from mdsal config datastore at startup"

8 years agoBug 3765: Restore dao from mdsal config datastore at startup 15/22815/1
Florin Coras [Wed, 17 Jun 2015 02:30:18 +0000 (19:30 -0700)]
Bug 3765: Restore dao from mdsal config datastore at startup

Change-Id: Iedbe7973aec8955f4573eca2c3d26bee69075b19
Signed-off-by: Florin Coras <fcoras@cisco.com>
8 years agoBug 3657: Fix IPv6 transport in southbound plugin 82/22782/1
Lorand Jakab [Tue, 16 Jun 2015 09:09:16 +0000 (12:09 +0300)]
Bug 3657: Fix IPv6 transport in southbound plugin

Change-Id: I265b6aa5ccd8d5c12db31aebfe683861b00dc4ea
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoBug 3590: Fix LCAF 12 mapping removal 79/22779/1
Lorand Jakab [Mon, 15 Jun 2015 17:30:26 +0000 (20:30 +0300)]
Bug 3590: Fix LCAF 12 mapping removal

Change-Id: If06a730304c1b2834ced2605cf729c8ff66eb78a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoAdd code coverage for bundles under mappingservice/ 75/22775/1
Lorand Jakab [Thu, 11 Jun 2015 21:24:26 +0000 (00:24 +0300)]
Add code coverage for bundles under mappingservice/

Change-Id: Id3ae7c0943001a238678237dcb05fc8d301a9c7c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoMove config-parent to aggregator POM 74/22774/1
Lorand Jakab [Wed, 17 Jun 2015 10:11:25 +0000 (13:11 +0300)]
Move config-parent to aggregator POM

More then one project in the mappingservice/ directory is hanging off
config-parent.  This commit defines it as a parent in the aggregator POM
mappingservice/pom.xml, so that common configration for all projects,
like checkstyle and coverage can live in a single place.

Change-Id: I9e04b707ca0dbdac756bdd212ebc55bc869ee802
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoBug 3661: Avoid storing mappings in config datastore when authentication 44/22744/1
Florin Coras [Tue, 16 Jun 2015 18:23:26 +0000 (11:23 -0700)]
Bug 3661: Avoid storing mappings in config datastore when authentication
fails

Change-Id: Ia1a30e75514ecdcb96ee123a22fa22cbd1ef61e0
Signed-off-by: Florin Coras <fcoras@cisco.com>
8 years agoBug 3757: Temporarily remove IT from the build 17/22717/1
Lorand Jakab [Tue, 16 Jun 2015 18:18:13 +0000 (21:18 +0300)]
Bug 3757: Temporarily remove IT from the build

Change-Id: I16d48fe514b90ca594040a96726807cefc647699
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoRemove old Hydrogen CLI 19/21719/1
Lorand Jakab [Wed, 3 Jun 2015 06:22:00 +0000 (09:22 +0300)]
Remove old Hydrogen CLI

Change-Id: I99c2abf7468f9c4aaf67ce03b42dde9cdd5fd686
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoExpand RPC API example Postman collection 18/21718/1
Lorand Jakab [Tue, 2 Jun 2015 17:31:50 +0000 (20:31 +0300)]
Expand RPC API example Postman collection

Change-Id: I87f0575f9fc11e15ba0e14f0bcbca0c67afa1cbf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
8 years agoRemove mappingservice.implementation activator 79/21479/2
Florin Coras [Sat, 16 May 2015 00:13:16 +0000 (17:13 -0700)]
Remove mappingservice.implementation activator

Change-Id: I6f5087f62fb129786092639d663a6c41fc2f98f3
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoBug 3380: Fix MD-SAL prefix overwriting 61/21461/1
Lorand Jakab [Thu, 28 May 2015 18:28:45 +0000 (21:28 +0300)]
Bug 3380: Fix MD-SAL prefix overwriting

The root cause of this bug was that the string representation for
maskable EID was just the base address, without the network mask.  This
commit adds the mask to the maskable addresses, and improves string
representation of LISP addresses in general.

Change-Id: I83d43ce41b5b88989c80bb3ac7a7e7fd5e1f225f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 3385: Update Application Data LCAF to latest draft 60/21460/1
Lorand Jakab [Wed, 27 May 2015 22:04:48 +0000 (01:04 +0300)]
Bug 3385: Update Application Data LCAF to latest draft

Change-Id: Ifa7c1fcd98058a3ca43927833034d43a0bdcfca7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 3150: Fix some serializers to add name 59/21459/1
Lorand Jakab [Tue, 26 May 2015 07:18:14 +0000 (10:18 +0300)]
Bug 3150: Fix some serializers to add name

Current YANG models include a key for most list elements, but the
serializers were not updated to fill that in.  This commit fixes that.

Change-Id: I728f40b8621b0d9eb4db08ce131d4997017c713b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 3355: Type 10 LCAF hops stored in user provided order 58/21458/1
Florin Coras [Mon, 25 May 2015 10:34:52 +0000 (03:34 -0700)]
Bug 3355: Type 10 LCAF hops stored in user provided order

Change-Id: I8cad90e632fee6b4ad6b07ac3cec211ee63b0fb7
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoBug 3112: Add SB registrations to MD-SAL datastore 57/21457/1
Lorand Jakab [Fri, 29 May 2015 22:46:43 +0000 (01:46 +0300)]
Bug 3112: Add SB registrations to MD-SAL datastore

Change-Id: I0dc44dd96a43fe5a104908192d7c7022d8889ffd
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoRemoving AD-SAL dependencies 97/21297/5
Florin Coras [Mon, 18 May 2015 23:22:32 +0000 (16:22 -0700)]
Removing AD-SAL dependencies

Change-Id: I8df9f0076d9ed2882f05669c53e6b0ec72b98894
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoModifying yangtools versions to use 0.8.0 92/21392/2
Brady Johnson [Fri, 29 May 2015 09:10:09 +0000 (11:10 +0200)]
Modifying yangtools versions to use 0.8.0

- This change is needed for the downstream SFC project,
  since this is causing SFC's version bump to fail

Change-Id: Ia7e392abd9d3053126b1bb5e3f8bfd15b031189f
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
9 years agoSwitching SB to config subsystem 51/21151/3
Florin Coras [Tue, 12 May 2015 06:59:52 +0000 (23:59 -0700)]
Switching SB to config subsystem

Change-Id: I976057f23d2f032546b9153b4df2160e00c503e0
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoRemove AD-SAL based northbound interface 51/20651/3
Lorand Jakab [Tue, 26 May 2015 07:46:34 +0000 (10:46 +0300)]
Remove AD-SAL based northbound interface

The AD-SAL based Northbound interface was deprecated in Lithium,
removing it with this patch for Beryllium.  There is still some AD-SAL
cruft left, but we'll eventually be able to remove it.

Change-Id: I6d783919f0ed81e43373f268a34b3903caa7eba3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 3223: Fix adding DistinguishedName from RPC 28/21028/1
Lorand Jakab [Tue, 19 May 2015 07:58:30 +0000 (10:58 +0300)]
Bug 3223: Fix adding DistinguishedName from RPC

The bug was caused by no string representation existing for
DistringuishedName, which is necessary for URI construction.  This patch
adds string representation to other all other LCAF types that were
missing it.

Change-Id: I72d49fa3b37e741c4f90baac5aa3bc5969679968
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoRemove dependency on clusterdao 57/20057/5
Florin Coras [Mon, 11 May 2015 21:08:45 +0000 (14:08 -0700)]
Remove dependency on clusterdao

This is part of an effort to remove adsal dependencies. Instead of
clusterdao we use HashMapDb, as an in memory map-server datastore.

Change-Id: Iccf7eccefe83e36fbf98e819b88a6036f7a7d4cf
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoDo not instantiate Shorts 86/19586/2
Robert Varga [Sun, 22 Mar 2015 22:58:34 +0000 (23:58 +0100)]
Do not instantiate Shorts

Speed up comparison by not instantiating an explicit Short instace, but
use autoboxing, which should result in better performance.

Change-Id: I260bf69935c2712162cb42404806e664f41a0cff
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoFix a maven warning 85/19585/2
Robert Varga [Tue, 5 May 2015 09:25:19 +0000 (11:25 +0200)]
Fix a maven warning

We had a duplicate config-api declaration. The effects were bounded,
but removing one of them fixes a maven warning.

Change-Id: I13f04d24ce7c7a735875e9abd5d47a1baf4c8c80
Signed-off-by: Robert Varga <rovarga@cisco.com>
9 years agoMerge "Fix southbound start/stop sequence"
Lorand Jakab [Fri, 15 May 2015 05:48:31 +0000 (05:48 +0000)]
Merge "Fix southbound start/stop sequence"

9 years agoSwitch mappingservice implementation to config subsystem 76/19976/14
Florin Coras [Wed, 13 May 2015 14:09:23 +0000 (17:09 +0300)]
Switch mappingservice implementation to config subsystem

As a first step, the RPCs provided by the mappingservice implementation
are registered through the config subsystem. However, for the time being
we keep the Activator, not to break consumers (e.g., southbound or
northbound) that depend on it. As next steps, we'll switch the
consumers, one by one, to the config subsystem and once the process is
complete, we'll remove the Activator altogether.

Change-Id: Id8ff8549acf9769e22752dafd1aba326578bd0f5
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoFix southbound start/stop sequence 23/20223/1
Lorand Jakab [Tue, 12 May 2015 17:01:11 +0000 (20:01 +0300)]
Fix southbound start/stop sequence

Change-Id: I865b818fa188f174fef9eff6d00b4ea62b4aa4ed
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit b2dfb13a01f7a494c3844b8399fd07848d4051db)

9 years agoBeryllium version bump 13/19413/3
Lorand Jakab [Tue, 12 May 2015 15:35:26 +0000 (18:35 +0300)]
Beryllium version bump

Change-Id: Ic13e9bbee5f14dc50770e4818c7c1f5511d4cbe1
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoFix openjdk8 build 36/20136/2
Lorand Jakab [Tue, 12 May 2015 14:45:52 +0000 (17:45 +0300)]
Fix openjdk8 build

Change-Id: I2a2e6852d6ecd2e3e0f8bd78f450999e6bae3c11
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
(cherry picked from commit 2c75db6f2476d9a71d5bb9021050fb84add221e4)

9 years agoMerge "Support for Neutron Ports"
Lori Jakab [Thu, 30 Apr 2015 20:39:58 +0000 (20:39 +0000)]
Merge "Support for Neutron Ports"

9 years agoSupport for Neutron Ports 06/19406/1
Vina Ermagan [Thu, 30 Apr 2015 20:15:49 +0000 (13:15 -0700)]
Support for Neutron Ports

Signed-off-by: Vina Ermagan <vermagan@cisco.com>
9 years agoProcess RPCs to config data store 85/19385/1
Lorand Jakab [Thu, 30 Apr 2015 14:10:14 +0000 (17:10 +0300)]
Process RPCs to config data store

Change-Id: I156d1c71ae0a5afd670c9ba0a0b4e5bc50fc180b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoActivate enunciate only on JDK 7 67/19367/1
Lorand Jakab [Wed, 29 Apr 2015 12:03:23 +0000 (15:03 +0300)]
Activate enunciate only on JDK 7

Change-Id: Ie5ba98893e806591c07cf878e2ac725019b3e32a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoSupport adding RESTCONF data to DAO 82/19182/6
Lorand Jakab [Wed, 29 Apr 2015 08:55:21 +0000 (11:55 +0300)]
Support adding RESTCONF data to DAO

Change-Id: Ia31994d6d25891dfa7adedb62e785650ee733db8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoRPC implementation for RESTCONF 67/18267/8
Lorand Jakab [Wed, 29 Apr 2015 17:26:17 +0000 (20:26 +0300)]
RPC implementation for RESTCONF

This commit introduces support for RESTCONF RPCs, using the existing
ClusterDAO storage backend with the existing MapServer/MapResolver API.

Change-Id: Ia9cca576e9bf06e90b05a7400aa807a1d6b970d3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoProper checkstyle excludes 39/18739/1
Lorand Jakab [Tue, 21 Apr 2015 11:52:54 +0000 (14:52 +0300)]
Proper checkstyle excludes

Changing the source directory just to match on class names is the wrong
approach and makes the build take more time.  Use part of the class
that's fixed instead.

Change-Id: I0085dcbca48f9fac0b07fa104e593166358883df
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoMerge "Add support for SourceDest LCAF"
Lori Jakab [Tue, 21 Apr 2015 09:00:15 +0000 (09:00 +0000)]
Merge "Add support for SourceDest LCAF"

9 years agoAdd support for SourceDest LCAF 75/18575/3
Florin Coras [Thu, 16 Apr 2015 16:20:09 +0000 (09:20 -0700)]
Add support for SourceDest LCAF

Change-Id: I19a984ef199cf0aa29e32784e32de9693616386e
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoMerge "Enforce basic checkstyle on mappingservice.*"
Lorand Jakab [Mon, 20 Apr 2015 18:59:20 +0000 (18:59 +0000)]
Merge "Enforce basic checkstyle on mappingservice.*"

9 years agoEnforce basic checkstyle on mappingservice.* 18/18618/4
Lorand Jakab [Mon, 20 Apr 2015 13:22:36 +0000 (16:22 +0300)]
Enforce basic checkstyle on mappingservice.*

Odlparent checkstyle rules are too restrictive for us at this time, so
we're ignoring them.  Instead of doing that, this patch overrides the
odlparent checkstyle rules for the mappingservice.* bundles so that we
enforce at least some basic rules.

The commit also fixes some checkstyle issues that were discovered.

Change-Id: Ife358094b206fe1f7b70fef25dfb43c9cea403ca
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 3021: Fix notification handling 03/18603/2
Florin Coras [Sun, 19 Apr 2015 19:09:01 +0000 (12:09 -0700)]
Bug 3021: Fix notification handling

This fixes the return types of LispSouthboundPlugin methods used for
sending LISP messages to avoid NullPointerExceptions in mdsal.

Change-Id: I0d5596da016917eee74bf9776914081464a4c4c3
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoFix SingleFeatureTest issues 16/18416/1
Lorand Jakab [Thu, 16 Apr 2015 12:24:49 +0000 (15:24 +0300)]
Fix SingleFeatureTest issues

Change-Id: Ieee2da67fd8e70443bb8206d531f7399b758e81b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoFix typo in lfm-control-plane.yang 08/18208/1
Lorand Jakab [Mon, 13 Apr 2015 17:07:20 +0000 (20:07 +0300)]
Fix typo in lfm-control-plane.yang

Change-Id: I6ec57501e9b8da574832a5a1f8b90a368d9411e9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoSwitch from junit.framework to org.junit 24/18124/1
Lorand Jakab [Fri, 10 Apr 2015 16:56:30 +0000 (19:56 +0300)]
Switch from junit.framework to org.junit

junit.framework.Assert is depracated in favor of org.junit.Assert, so
stop importing the deprecated classes.

Change-Id: I8719bbfd11d52fa208ac5cf85e4f5f122c985048
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoFix/reenable last failing integration tests 07/17907/1
Lorand Jakab [Wed, 8 Apr 2015 10:35:11 +0000 (13:35 +0300)]
Fix/reenable last failing integration tests

Change-Id: Idbfd1cf4171509fd6920fa4ff0ba71856831049e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBug 2946: Make LcafSegmentAddr maskable 44/17744/1
Florin Coras [Sat, 4 Apr 2015 01:56:43 +0000 (18:56 -0700)]
Bug 2946: Make LcafSegmentAddr maskable

This also enables longest prefix matches with segment addresses.

Change-Id: Iaf2c626786e79482aa1983c5226c012529591542
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoBUG-2944: Parse iid mask length in northbound key registration 87/17687/2
Florin Coras [Fri, 3 Apr 2015 04:31:05 +0000 (21:31 -0700)]
BUG-2944: Parse iid mask length in northbound key registration

Change-Id: I793fd37786c4c837f767f9c2352e33d43aecfeaa
Signed-off-by: Florin Coras <fcoras@cisco.com>
9 years agoPrepare the YANG models for RESTCONF 80/17680/1
Lorand Jakab [Fri, 3 Apr 2015 01:49:43 +0000 (04:49 +0300)]
Prepare the YANG models for RESTCONF

This commit is in preparation of an MD-SAL based mapping database.  The
existing YANG model had to be modified in order to be useble for that
goal, and a new model was added to describe the new API.  The models
have been checked to pass pyang.  The implementation of the MD-SAL based
mapping database will be provided by another commit.

Change-Id: Idb1a31a00fa110f2a1c493672cb508f23cf5fad7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoAdd support for Karaf shell lisp:addkey command 75/17675/1
Lorand Jakab [Thu, 2 Apr 2015 22:23:39 +0000 (01:23 +0300)]
Add support for Karaf shell lisp:addkey command

The plan is to extend the command in the future to accept arguments, but
for now it installs the key "password" for the IPv4 prefix 0.0.0.0/0
(all IPv4 EIDs).

Change-Id: I7f3657b2a9254ddc1ef638b0d9a65293ed191d05
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoRemove subscribers when removing mapping. 87/17587/2
Florin Coras [Wed, 1 Apr 2015 21:51:09 +0000 (14:51 -0700)]
Remove subscribers when removing mapping.

Change-Id: I3c20903cef359bcb2128fe9c39836553f4412ceb
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>
9 years agoMerge "Add support for Karaf shell lisp:* commands"
Lorand Jakab [Wed, 1 Apr 2015 19:20:01 +0000 (19:20 +0000)]
Merge "Add support for Karaf shell lisp:* commands"

9 years agoMerge "BUG-2931: Avoid removing mapping key when deleting mapping"
Lori Jakab [Wed, 1 Apr 2015 14:34:32 +0000 (14:34 +0000)]
Merge "BUG-2931: Avoid removing mapping key when deleting mapping"

9 years agoAdd support for Karaf shell lisp:* commands 43/17543/1
Lorand Jakab [Wed, 1 Apr 2015 14:07:33 +0000 (17:07 +0300)]
Add support for Karaf shell lisp:* commands

This commit adds the necessary infrastructure to add Karaf shell
commands for the lispflowmapping project and adds the first command:
"lisp:mappings", based on the previos OSGi shell command "dumpAll".
The list of implemented commands and a short help can be consulted at
any time with "help lisp".

Change-Id: Iee6f430053c52dc4933ce920859ce03523dd05e2
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoMerge "Bug 2871: Add support for IID mask-len"
Lorand Jakab [Wed, 1 Apr 2015 09:20:21 +0000 (09:20 +0000)]
Merge "Bug 2871: Add support for IID mask-len"

9 years agoBug 2871: Add support for IID mask-len 89/17389/2
Lorand Jakab [Mon, 30 Mar 2015 21:58:57 +0000 (00:58 +0300)]
Bug 2871: Add support for IID mask-len

draft-farinacci-lisp-lcaf-07 introduced a change for LCAF type 2
(segmentation) where the 2nd reserved field in the LCAF header becomes
IID mask-len.  Some LISP implementations set this field to a non-zero
value when registering mappings.  LISPflowmapping needs to be able to
serialize-deserialize this field in order to authenticate such
registrations.

This commit adds support for the above mentioned ser/des, however, it
does not implement support for IID masking.  It doesn't fully fix bug
2871 either.

Change-Id: I777e5bb5bcabc4dc7b558ee6eac89d88e0820d8e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoBUG-2931: Avoid removing mapping key when deleting mapping 16/17516/1
Florin Coras [Wed, 1 Apr 2015 07:04:00 +0000 (00:04 -0700)]
BUG-2931: Avoid removing mapping key when deleting mapping

Change-Id: Ifb8b9f24143d10478bbc27474d3a8b777a54cd68
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>
9 years agoAdd <relativePath/> to ensure Maven pulls artifact from Nexus 66/17466/1
Thanh Ha [Tue, 31 Mar 2015 15:46:30 +0000 (11:46 -0400)]
Add <relativePath/> to ensure Maven pulls artifact from Nexus

Needed by autorelease to be able to find and replace this value
prebuild.

Change-Id: I1381fbc9f0888649e154fc04a705ac50ebff55b5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoBUG-2915: Add support to remove mapping through northbound API 74/17274/3
Florin Coras [Sat, 28 Mar 2015 07:25:53 +0000 (00:25 -0700)]
BUG-2915: Add support to remove mapping through northbound API

This supports removing a mapping from DAO by means of a northbound REST
call. If the mapping had any subscribers SMRs will be sent.

Change-Id: I54a627adb1c9dc19ce4944134761979a308ded2a
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>
9 years agoRevert "Add odlparent relativepath relative to autorelease" 90/17190/1
Thanh Ha [Thu, 26 Mar 2015 19:00:04 +0000 (15:00 -0400)]
Revert "Add odlparent relativepath relative to autorelease"

Per discussion on mailing list thread we have decided to revert this
change and achieve relative path updating via scripting in autorelease.

https://lists.opendaylight.org/pipermail/release/2015-March/001754.html

This reverts commit 2adbccd94292df19094abd1a026b8ea02f9fadfc.

Change-Id: I81bde8f79f24098ad4125f76cd2488182ba4c13e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
9 years agoFix merge failure to out of order patches 35/17135/1
Lorand Jakab [Wed, 25 Mar 2015 22:38:04 +0000 (00:38 +0200)]
Fix merge failure to out of order patches

Change-Id: I2ec031ef19c3da4cefb1413075e049368be5d78c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
9 years agoMerge "Rename static final variable 'logger' to 'LOG'"
Lorand Jakab [Wed, 25 Mar 2015 22:31:46 +0000 (22:31 +0000)]
Merge "Rename static final variable 'logger' to 'LOG'"

9 years agoAvoid Map-Register inconsistencies due to SMR handling exceptions 30/17130/2
Florin Coras [Wed, 25 Mar 2015 21:46:11 +0000 (14:46 -0700)]
Avoid Map-Register inconsistencies due to SMR handling exceptions

Catch exceptions raised by handling/sending of SMRs such that they don't
affect the processing of Map-Register messages.

Change-Id: I2614948a0416d16e47d2ab557a65dba78e98aa10
Signed-off-by: Florin Coras <fcoras@ac.upc.edu>
9 years agoRename static final variable 'logger' to 'LOG' 19/17119/1
Lorand Jakab [Wed, 25 Mar 2015 17:06:38 +0000 (19:06 +0200)]
Rename static final variable 'logger' to 'LOG'

This commit makes Sonar happier.

Change-Id: I9be49fca7eaabe0f6ca876d0bb25773e7daedb20
Signed-off-by: Lorand Jakab <lojakab@cisco.com>