Bump scala to 2.12.5

http://www.scala-lang.org/news/2.12.5

Change-Id: I6a9fddc5ca58822367c146ec2d2cc547e61d7e7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e44d7d01ea051fb3dd51bdccf783c0f3e32ea963)

Bump akka to 2.5.11

https://akka.io/blog/news/2018/02/28/akka-2.5.11-released

Change-Id: Ida5ba9a519ec7336f32521e259d587b8cca3e57d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 9e31a398d1c8a8b3d76bc5596e2599d8ed6bd0eb)

add org.apache.karaf.scr.management to whitelist

to fix spurious SingleFeatureTest (SFT) failures

see ODLPARENT-144; although unclear why this suddenly fails now

Change-Id: Ife9bdf0d94b028048cd6321e8fbdc5ec554a8bdb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Update usage information for odlparent properties

This patch updates the usage information for all active projects in
ODL, and removes some unused properties:
* maven.clean.plugin.version
* compiler.version
* releaseplugin.version
* akka.version
* leveldb.version

This is technically a breaking change, so this is 4.0 material only.

Change-Id: Ia68136adef7c6ab3c40544546908653e81d8ba11
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump jacoco to 0.8.0

https://github.com/jacoco/jacoco/releases/tag/v0.8.0

Change-Id: Ibca747463e8c568bdc48147999f3d6f232ff6599
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-jackson-2.8

This a package containing a pre-configured jackson software package.

Change-Id: I459cfda5fb147b21a1e5339360fac06522307fbc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.10

https://akka.io/blog/news/2018/02/23/akka-2.5.10-released

Change-Id: I10d598a96e4a08078e10551517cee7f3882fc49d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

suppress CRLF_INJECTION_LOGS in TestBundleDiag

https://find-sec-bugs.github.io/bugs.htm#CRLF_INJECTION_LOGS

Change-Id: I1969245de6d4e95e44787311fb61c0cc3adc7a15
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add modernizer.skip to -Pq

I'm adding https://github.com/gaul/modernizer-maven-plugin/
to infrautils in Id85737d789efb7ee07c8c7a34bdac39d8a96e076,
and cannot figure out how to get Maven to merge an additional
property in a profile, so why don't we just have this in
odlparent already?  Some day modernizer-maven-plugin could
be in odlparent.

Change-Id: Id270c4a7f363eb4a0557810526e17043cac326e8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump sevntu-checkstyle to 1.27

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.25.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.26.0
https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.27.0

Change-Id: Ifdc5c6c3d8f499893997af2258dbf0672a42b2b5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle dependency to 8.7

http://checkstyle.sourceforge.net/releasenotes.html#Release_8.5
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.6
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.7

Change-Id: I0008e14482d07309a6c9e41cb9456e0004cfc8c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-checkstyle-plugin to 3.0.0

https://mail-archives.apache.org/mod_mbox/maven-announce/201801.mbox/%3Cop.zchs68akkdkhrr%40desktop-2khsk44.mshome.net%3E

Also removes checkstyle.version property, as noted in its TODO, and
switches from <sourceDirectory/> to <sourceDirectories/>, as
documented on the plugin site on
https://maven.apache.org/plugins/maven-checkstyle-plugin/

Change-Id: I3bffa47a300f314aaefe5181ca92fd0a6c925755
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump BouncyCastle to 1.59

https://www.bouncycastle.org/releasenotes.html, most notably fixes
CVE-2017-13098.

Change-Id: Ifb3c972f5c41722850249168d36b6ab669c7e4d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump git-commit-id-plugin from 2.2.2 to 2.2.4

https://github.com/ktoso/maven-git-commit-id-plugin/releases/tag/v2.2.3
https://github.com/ktoso/maven-git-commit-id-plugin/releases/tag/v2.2.4

Change-Id: I3890a63b83434751e39f1a3bccd9c0727c317715
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Karaf 4.1.4 → 4.1.5

Release notes: http://karaf.apache.org/download.html#container-415

Change-Id: I4af39685f9f5c69a0f5fa5b22f1035dcef0936ba
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Exclude jsr250-api from enunciate-core-annotations

to fix this (correct) complaint from ClasspathHellDuplicatesCheckRule:

file:/.../javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar
overlaps with
file:/.../jre/lib/rt.jar
- total overlapping classes: 6 - different classloaders.

Change-Id: I6306d604d6b105f064e0e8f7f765a9af1ca7c11c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bundle-test-lib should be a bundle

This prevents the jar from being wrapped by users.

Change-Id: Ib2c2198dc2acca072f5c1dede8a85ca4d1b15963
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit afc1ccc1bc2e840855d1478c8e51299d72631e72)

ignore web.xml and BP *.xml in duplicate-finder

This avoids duplicate classpath errors when running the
duplicate-finder-maven-plugin on projects depending on ODL Karaf feature
artifacts (such as odl-netvirt-openstack), which will typically have
dependencies on several web related OSGi bundles that include
WEB-INF/web.xml, and allow any org/opendaylight/blueprint/*.xml,
not just autowire.xml.

Change-Id: Iacfb820d44febdcf20eafd99cf549e023ff47df9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove <scope>test from mycila

This allows odlparent-based projects to use Guice with Mycila more
easily in non-test related Java environments, such as in a pure JSE
opendaylight.simple (POC).

As per the original commit message when Mycila was first added to
odlparent, there is still no intention of using it (or Guice) in our
standard deployment model of running ODL in OSGi.  Therefore, this
contribution does still not include an OSGi MANIFEST.MF for Mycila,
nor a Karaf wrap feature for it, as we still do not need that.

Change-Id: I1f5586bd1dcf8d12756e33f4b74c4326b924058d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

AAA-147: Upgrade Jolokia to 1.5.0

Upgrades Jolokia to 1.5.0.  This version provides the ability to
delegate authentication for Jolokia to AAA, centralizing control
of AAA mechanisms.

Change-Id: Ic545ca2ad966e4ecee030bcaa6cfd3163c6dd606
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Detect slf4j API misuse via FindBugs extension

see http://kengotoda.github.io/findbugs-slf4j/

Change-Id: I60b127526ccc057d37ef900b7502f4ea84517d8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add ThreeTen-Extra

This provides a number of useful date/time classes, on top of the new
features in Java 8. See http://www.threeten.org/threeten-extra/ for
details. (Inspired by I044c092a662f2b38ebc3f53a371c3c801ca0192c.)

Change-Id: Ib73744ec639d80e96b16f013ca8a75a99b1c2e3a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove aggregator-parent

Unfortunately aggregator-parent can’t install or deploy itself, which
means it’s unusable outside odlparent. To avoid creating false hopes,
this patch removes aggregator-parent and adds two properties to
odlparent-lite to make it simpler to disable the corresponding
plugins.

Change-Id: I48705f7de0d8126818a4f16379e7775136b6e76c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add an OWASP profile for vulnerability checking

This builds on the full dependency-check project, adding a -Powasp
option which checks all our published third-party dependencies against
the NVD database. This currently doesn’t fail the build.

Change-Id: I204f2c427c545a636cf2310b5902c8a4e4bcf873
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump findbugs-maven-plugin from 3.0.4 to 3.0.5

even though we're aiming for SpotBugs, it doesn't hurt to do a minor
version bump on the findbugs-maven-plugin, as we'll have to maintain it
for a while anyway until everything is switched to SpotBugs and we can
remove it.

Change-Id: I23a3aa939a30084157de5defcb5b9f09e762dea1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump commons-lang3 3.6 → 3.7

Release notes:
http://www.apache.org/dist/commons/lang/RELEASE-NOTES.txt

Change-Id: Idcc2eccbc22420d578511f4017e2098ace9b9bd0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump antlr to 4.7.1

https://github.com/antlr/antlr4/releases/tag/4.7.1

Change-Id: Ic6139e09043a70c22a72170d1ed4ddba3357ca25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

metainf-services should be scope=provided

Feature generation picks up optional dependencies, leading to this
artifact being included in features, which is wrong, as it is
needed at build time only. Mark it at scope=provided to keep downstreams
from worrying about it.

Change-Id: I70fa32bf08a47c18efefa4d3a10e61558f8f62ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit cfd1cf6c23d21e27f95051dbf8b82c65342e1ea0)

Bug 7891: Place provided features to featuresBoot

Specifically, org.apache.sshd/sshd-core/0.14.0 is excluded,
thus "ssh" feature has to be always installed.

Without this, distribution4-check with odl-netconf-mdsal
in integration fails at installing boot features, because
org.opendaylight.netconf.netty-util depends on sshd-core bundle,
which is only activated by "ssh" feature
(as any ODL feature drops that dependency,
because of exclusions in feature parents).

Change-Id: Ic1d3b19981fccca9c320a5079aaf9e2eadf09397
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit d7cd41b97dc9081f7375af08ef5da07542f9b5c1)

Exclude leveldb-api from odl-akka-leveldb-0.7

to fix this (correct) complaint from ClasspathHellDuplicatesCheckRule:

file:/.../org/iq80/leveldb/leveldb-api/0.7/leveldb-api-0.7.jar overlaps
with
file:/.../leveldbjni/leveldbjni-all/1.8-odl/leveldbjni-all-1.8-odl.jar
- total overlapping classes: 13 - same classloader ! This is an ERROR!

Change-Id: I929fb28606a8f6456747229ac2ceee6a90a9f04e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump H2 database to 1.4.196

http://www.h2database.com/html/changelog.html

Change-Id: Ifb33c7d06c3ec27851276b1c42837c7285a97396
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs-maven-plugin from 3.1.0-RC6 to 3.1.1

https://github.com/spotbugs/spotbugs/blob/3.1.1/CHANGELOG.md

This requires a Maven version 3.5.0+, at the very least in
order to be able to "mvn deploy" without hitting a weird internal
Maven error related to consistency of the resolver pipeline.

Change-Id: I1325e628ce62bd0f8d426d7cc61246003fc06aed
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-138: Require maven-3.5.0 or later

Update maven enforcer to ensure odlparent-4.0.0 users use maven
3.5.0 or later. This is needed for update of spotbugs at the very
least, but will also allow us to use 3.5.0 features.

Change-Id: I13eabefc4e4316b0be204a808c69f09be8e7d59d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.9 and typesafe config to 1.3.2

This is a major feature/preview release, the notes are at:
https://akka.io/blog/news/2017/09/28/akka-2.5.6-released
https://akka.io/blog/news/2017/11/17/akka-2.5.7-released
https://akka.io/blog/news/2017/12/08/akka-2.5.8-released
https://akka.io/blog/news/2018/01/11/akka-2.5.9-released-2.4.x-end-of-life

https://github.com/typesafehub/config/blob/master/NEWS.md

Also align aeron/agrona versions to match:
https://github.com/real-logic/Agrona/releases/tag/0.9.6
https://github.com/real-logic/Agrona/releases/tag/0.9.7
https://github.com/real-logic/Agrona/releases/tag/0.9.8
https://github.com/real-logic/Agrona/releases/tag/0.9.9
https://github.com/real-logic/Agrona/releases/tag/0.9.10
https://github.com/real-logic/Agrona/releases/tag/0.9.11
https://github.com/real-logic/Agrona/releases/tag/0.9.12

https://github.com/real-logic/aeron/releases/tag/1.3.0
https://github.com/real-logic/aeron/releases/tag/1.4.0
https://github.com/real-logic/aeron/releases/tag/1.5.0
https://github.com/real-logic/aeron/releases/tag/1.5.1
https://github.com/real-logic/aeron/releases/tag/1.5.2
https://github.com/real-logic/aeron/releases/tag/1.6.0
https://github.com/real-logic/aeron/releases/tag/1.7.0

Change-Id: I3bb94b6c33004366799f1c85f89fae61e3c6c6ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Guava to 23.6

https://github.com/google/guava/releases/tag/v23.4
https://github.com/google/guava/releases/tag/v23.5
https://github.com/google/guava/releases/tag/v23.6

Change-Id: I4b5e1619326e0d624be5743c5178da3447661f73
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.20

http://netty.io/news/2017/11/08/4-0-53-Final-4-1-17-Final.html
http://netty.io/news/2017/12/11/4-0-54-Final-4-1-18-Final.html
http://netty.io/news/2017/12/18/4-1-19-Final.html
http://netty.io/news/2018/01/22/4-0-55-Final-4-1-20-Final.html

Change-Id: I3b2328993299b2ee86ed643b22184a1ea09bbb35
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop wrap from karaf4-parent

Including wrap in the boot features was a work-around and is no longer
necessary (all features requiring it now include it explicitly).

Change-Id: I061e201d590540d46f30157c6126196ff1add5ac
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump versions to 4.0.0-SNAPSHOT

Prepare master for next incompatible release stream.

Change-Id: I7fc3219f6439c73f39e946123803f225be98dbb9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 3.1.0-SNAPSHOT

In preparation for 3.1.x branch, bump versions on master.

Change-Id: I568e9b5536809d5b90018862fb6c737cc0ead77d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jersey-1.x to 1.19.4 and package it

Rather than relying on downstreams doing their own packaging
of jersey, provide proper package of basic dependencies in a feature.

Change-Id: I576008ca9e9d6673f5f5d3ffc4081d9943b634e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Align jetty version with karaf

karaf is pulling in version 9.3.21, while we are advertizing
9.2.19 -- which leads to odl-karaf-feat-jetty not squashing
dependencies in features.

Change-Id: I914d9a3c2c83426d58e6d4f8f5def9d7d29f6114
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump karaf to 4.1.4

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12341702

of which most notable is jetty version alignment.

Change-Id: I23d74258d40635d78b20c4c3fe9e61f3f1c8ddd2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

find-duplicate-classpath-entries in phase verify

instead of already during validate, because that's too early

https://lists.opendaylight.org/pipermail/odlparent-dev/2018-January/001597.html
https://lists.opendaylight.org/pipermail/odlparent-dev/2018-January/001589.html

Change-Id: I0e3ad52a3b8bc7175a2e98e320667a74001f54ae
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use jackson-bom to declare jackson dependencies

Importing jackson-bom declares all jackson components versions
in a consistent set.

Change-Id: I839db437eb965925b6a4cd3dd572e7e81df7e10f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

add org.osgi.compendium to features-test

fixes SFT bug ODLPARENT-136
java.lang.ClassNotFoundException:
org.osgi.service.resolver.ResolutionException

Change-Id: Ifaa39b35d1975ccd2aec15f6ed56191637f43d73
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Start 3.0.3-SNAPSHOT

Change-Id: Ie676ecbb5c74d7db8654cecb56e25c51d9156f80
Signed-off-by: Stephen Kitt <skitt@redhat.com>

odlparent 3.0.2 release notes

Change-Id: Ic8bc02873149704d7673f2d8d594ffcd32416562
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use default upstream logging configuration

Now that Karaf uses Log4J2, our custom configuration no longer works;
this patch uses the default upstream setup for the time being.

Change-Id: I1786d9f50d60a030dc3b265fdb70dc5130806c1a
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump javadoc plugin to 3.0.0

Proper release is now available, bump to it:
https://mail-archives.apache.org/mod_mbox/maven-announce/201712.mbox/%3Cop.zaufhhzukdkhrr%40desktop-2khsk44.mshome.net%3E

Change-Id: Icbb6bc02496e937320424a1ec8a4edac0ca09478
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove JavaDoc <links> from odlparent

because all of these, and more, are already in odlparent-lite now

see also https://jira.opendaylight.org/browse/ODLPARENT-121

This change does NOT fix that performance problem; only
change I4ca0c9e81985c2827e16654e9d9413c7d93f6068 does that,
whereas this one is just a clean up I stumbled upon.

Change-Id: Ifd66f318dfc3b900ad6fe06fa26e80932783cce8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Disable hiddenField check for abstract methods

There is a valid use case, where we are forwarding a private field
to an abstract method. This clearly does not hide the field, as it
is invisible to subclasses -- hence disable HiddenField on abstract
methods.

Change-Id: I00adfce58eea65660cae06649168a09a560713a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-134: ensure correct startup with BC

In Karaf 4.1, Bouncy Castle no longer starts correctly; or rather,
loading kpix results in prov being refreshed, which restarts sshd and
most of Karaf.

This patch cleans up the startup.properties construction, and enforces
the correct order for Bouncy Castle. It also adds metatype and
blueprint.core.compatibility which must be loaded at boot to avoid
unwanted refreshes.

Change-Id: Ic8e8e0e932b9d9eaea292003118ef1936b67b822
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a javadoc-links profile

... to build with external links (which adds substantial time to the
build).

Change-Id: Iea9adc7ed49ae39609ecd5d6bd012a35fe36fc81
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-enforcer-plugin 1.4.1 => 3.0.0-M1

https://mail-archives.apache.org/mod_mbox/maven-announce/201707.mbox/%3Cop.y37atexzkdkhrr%40desktop-2khsk44%3E

Change-Id: I290370bb6619a6fe7c809646995877f73dd891a7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ODLPARENT-133: process conditional dependencies

Karaf 4.1 uses many more conditional dependencies in its features,
which results in a distribution missing many dependencies which we
actually need. This patch adds conditional bundle processing to
PopulateLocalRepoMojo, resulting in a distribution where all
dependencies are available, regardless of the conditions.

Change-Id: Ic9eb2befbed066a486603f28c38d32a7e951dd9f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Comment out JavaDoc <links> for build perf

see https://jira.opendaylight.org/browse/ODLPARENT-121

Change-Id: I4ca0c9e81985c2827e16654e9d9413c7d93f6068
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use getClass() in equals(), and simplify

Using getClass() enforces the equals() symmetry contract without
having to be careful with subclasses (which is fine since the classes
are final), and is also slightly faster.

Change-Id: I02dcb453c08f1139713b5d72629c2ab98c1ce86f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Avoid unnecessary copies of data structures

In BundleDiagInfosImpl, the constructor is private, and forContext
creates new instances of the collections stored in the resulting
object specifically for that object; there’s no point in making
immutable *copies*.

Change-Id: I453cd97e957248a6f074ce292e685470e2f6973c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BundleDiagInfos with getBundlesStateMap()

Allows infrautils.ready to offer infrautils.diagstatus per bundle infos

see https://jira.opendaylight.org/browse/INFRAUTILS-27

Change-Id: Ib2c529ac0d7d812148b8673c773d439e155c6224
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bundles-test-lib with BundleDiagInfos

instead of BundleDiagInfosImpl (drop the *Impl, where possible)

Change-Id: I65046338016d77409e667a644f19bd3397ce8a0a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

TestBundleDiag with configurable await logging

Allows infrautils.ready to make TestBundleDiag INFO log less verbose

The full list of NOK bundles during boot caused confusion, even if INFO

see https://jira.opendaylight.org/browse/INFRAUTILS-17

Change-Id: Iad1badb29e6a061812640a9182973d7c2b679836
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix SFT for Archetype Self Test

This sets the Pax Exam URL Maven localRepository so that the
SingleFeatureTest of the Archetype in controller works, even if
there is a -Dmaven.repo.local=, such as on Gerrit.

see https://jira.opendaylight.org/browse/CONTROLLER-1799

Change-Id: Idd6126944518bab0fa0b886a7012ea94aba3126e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Start 3.0.2-SNAPSHOT

Change-Id: If127110ae6f0acc181966f748b5768f6461c1405
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 3.0.1

Change-Id: I2df6a518158836bc4e0d67e1e0bac721d8471a42
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Workaround broken upstream features

hibernate-validator-osgi-karaf-features-[5.3.4,5.4.2) is broken
due to invalid maven URL reference. Add hard exception to fix it up.

Change-Id: I6cc28817b721fd7fa6f7dd940c82a4b80acb81c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Pre-compile FeatureUtil replacement patterns

When we are discovering features, we end up converting a lot of URLs,
hence we end up recompiling the same patterns over and over again.

Rather than doing that, keep pre-compiled versions and reuse them.

Change-Id: I6b0b2b9e3c6ba9a13d20b7e16b4284feee222797
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a test distribution to test karaf4-parent

This adds a simple distribution, containing just odl-guava.

Change-Id: I65a9d85238f358072d595e7523a17f2a6eab8fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start 3.0.1-SNAPSHOT

Change-Id: I9be70dcdef4b95a98095df72f7bb5e4eafb7ef59
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 7756 Bind web services to single port

Right now, we mirror web service offerings on ports 8080 and 8181.
There has been much discussion surrounding consolidating on a single
port.  See these email threads:

https://lists.opendaylight.org/pipermail/release/2017-February/009244.html
https://lists.opendaylight.org/pipermail/controller-dev/2016-September/012677.html

Based on community feedback, it would appear that most people utilize
port 8181, and it would take a LOT of work to change that. Thus, this
change removes the port 8080 offering. If downstream consumers still
wish to use web services on port 8080, then can simply re-add the
connector in etc/jetty.xml without recompiling (will require karaf
container restart to reinitialize pax-web).

This is just a change to the default offering, and makes the ODL
platform a bit more consistent OOB.

Change-Id: I62ccf4a8f9719c7923f06204955239ceea8a780f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

ODL Parent 3.0.0 release notes

... and supporting Sphinx framework.

Change-Id: Ifa6a8ec9f159aa855868509de588d30f671d2680
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add missing M2E lifecycle mappings metadata

* Ignore for the duplicate-finder-maven-plugin

Not sure why I have to repeat here what I had done back in January in
https://github.com/vorburger/opendaylight-eclipse-setup/commit/abf867c9a1e58686b79214c9381adcb0e224b3b6
but I can only strongly encourage all ODL developers using Eclipse to
use the opendaylight-eclipse-setup model.

also make bundles-test-lib enable the dupe CP finder (and PMD CPD),
because that actually made the problem appear under Eclipse within
odlparent - after manually locally removing the equivalent in
lifecycle-mapping-metadata.xml by opendaylight-eclipse-setup.

see also I3498cc5f3af7481cd83b4f7f69045d19668fd1da

Change-Id: I2bfbfc05600814df1fa5c866e1db3cbe2576959c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add missing M2E lifecycle mappings metadata

* Ignore for the karaf-maven-plugin

This change does intentionally NOT include a lifecycle mapping for the
(new) spotbugs-maven-plugin, because that's one which we do NOT want to
just IGNORE, but have to configure; re. that one, please watch
https://github.com/m2e-code-quality/m2e-code-quality/issues/110

FTR: Originally I started putting these (only) into
opendaylight-eclipse-setup, because "such Eclipse specifics should not
be in our POM", but today on IRC rovarga opined that "it should 'just
work' even if one doesn't want to use your opendaylight-eclipse-setup"
but why? its great!] so putting there here now - meaning we have a bit
of a mix now, but I guess this isn't the end of the world.

see https://github.com/vorburger/opendaylight-eclipse-setup#how-to-add-additional-m2e-lifecycle-mapping

Change-Id: I3498cc5f3af7481cd83b4f7f69045d19668fd1da
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Dependency check: avoid dependency loops

Exclude all org.opendaylight dependencies to avoid introducing
dependency loops with dependency management on third-party artifacts
re-packaged in ODL projects.

Change-Id: I19a235e395f4b8e89e86a054d4e266cc8e101905
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-9202: update maven-javadoc-plugin

Required to make build work with Java 9, release notes are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201707.mbox/%3Cop.y3p20je4kdkhrr%40desktop-2khsk44%3E

Change-Id: I46d348026a41587a04ebc6508fcc649dd5be9a48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

SFT needs Karaf branding

For some reason SFT now needs our Karaf branding. We should fix this
so that it’s no longer the case — see
https://jira.opendaylight.org/browse/ODLPARENT-130 — but in the
interest of getting odlparent 3.0.0 out, this adds an explicit test
dependency.

Change-Id: I548e421a63073503be47d239cd9536306ab92bd9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a dependency check to validate management

To avoid issues such as the invalid uncommon-maths version bump, add a
module whose sole purpose is to depend on all artifacts specified in
dependency management in odlparent. This ensures that the artifacts
are actually available.

Remove two artifacts which don’t exist (and aren’t used anywhere):
* ssl-config-akka_2.12
* jetty-servlet-tester

Change-Id: Ia18132fb45eb5f87afdc0d63ac3fff4f2caaf04c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Don’t exclude pax-url-commons from pax-url-wrap

Excluding pax-url-commons from pax-url-wrap means that anything
depending on -wrap without -aether fails (including karaf-plugin).

Change-Id: I861f63caac4fdf6405174df4e05e6242d747b2b5
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove io.dropwizard.metrics dependencyManagement

https://lists.opendaylight.org/pipermail/odlparent-dev/2017-November/001460.html

for https://jira.opendaylight.org/browse/INFRAUTILS-19

Change-Id: I0ce0e4b7ad54e171c061e1bb91d568b25e9d1145
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fail build if classpath contains duplicates

duplicate-finder-maven-plugin fails build if duplicate classpath entries
see https://github.com/basepom/duplicate-finder-maven-plugin/

This is currently not enforced, but projects opt-in to this quality via:

  <properties><duplicate-finder.skip>false

FTR: There are a few other tools in this space, incl. e.g.
http://www.mojohaus.org/extra-enforcer-rules/banDuplicateClasses.html
and http://tattletale.jboss.org/ and http://jhades.github.io, but
duplicate-finder-maven-plugin fits best here.

See https://git.opendaylight.org/gerrit/#/c/50851/ for a related util.

Bug: 7662
Change-Id: I79142549ba7c739ce39285d35f179172d7b099a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump jacoco to 0.7.9

https://github.com/jacoco/jacoco/releases/tag/v0.7.8
https://github.com/jacoco/jacoco/releases/tag/v0.7.9

Change-Id: Iced1a38897da53fcf80d2cde4ee76baa93cd8242
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Checkstyle InnerAssignment"

This reverts commit c115daf2f2548b49b505a12fb3ab26c7e096dd8c.

The Checkstyle InnerAssignment check only handles a subset of cases,
which ends up being confusing.
(E.g. while() { }, but not do { } while().)

Change-Id: I813679f18214e8729bc588ae4e0987579b0e3786
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Bump Uncommons Maths 1.2.2a → 1.2.3"

This reverts commit cf236575fa87a2928bb83393bb9e5355b8eedd01.

Version 1.2.3 isn’t available on Maven Central...

Change-Id: If524032a85f17dee7a553e5e27cdeb9816904af6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "Checkstyle TrailingComment, Sonar aligned"

This reverts commit f7680f6a688e26e28515c907328c52d0a35a4515.

This code format convention is actually stupid IMHO after all.
For example, I really do like this a lot more:

  @SuppressFBWarnings("SE_BAD_FIELD") // Runnable is not Serializable
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

than being forced by Checkstyle to have to write this:

  // Runnable is not Serializable
  @SuppressFBWarnings("SE_BAD_FIELD")
  private final TrackingLinkedBlockingQueue<Runnable> backingQueue;

We should change Sonar's configuraiton, not enforce this in odlparent.

Change-Id: Ib3a8708a7a4b43bb72859f69aca33aafb8b6080c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump scala to 2.12.4

https://github.com/scala/scala/releases/tag/v2.12.4

Change-Id: Id179520eb109053dd99197f5f9665d6be6d40bab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add -Xlint:deprecation

We do need to clean up callers of deprecated methods. Make sure
we emit details during build.

Change-Id: I3259edafcf0f54b087b38f5270cf67009a0fd885
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Awaitility 2 → 3

Release notes:
https://github.com/awaitility/awaitility/wiki/ReleaseNotes30

Change-Id: Iee993116d976a6f61104681e055e8d5f60575895
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Felix dependencies

Dependency Manager 4.3.0 → 4.4.1
Dependency Manager Shell 4.0.4 → 4.0.6
Metatype 1.1.2 → 1.1.6

Release notes are few and far between...

Change-Id: Ib13e01ad62ba31d30b8efe20fab10d1564337bd7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

maven-compiler-plugin showWarnings

This won't break anything, just spew a few more logs, which MAYBE *some*
people will start looking it.  I will be enabled with the upcoming
proposed error-prone integration anyway, so we may as well make a start
with it now, even before getting error-prone in.

Change-Id: Ica17b1a250562c0f083ed252d921dc86278abd3b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump webcohesion enunciate 2.6.0 → 2.10.1

Release notes: https://github.com/stoicflame/enunciate/releases

Change-Id: Id60106cd18b822eb84589bc4bf7c2e9e35c577e8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove obsolete dependency management entries

Remove a number of dependencies which are no longer used:
* xml-apis
* Xerces
* txw2
* Eclipse Link
* Gemini Web
* Orbit
* Felix File Install and Web Console
* Equinox HTTP service bridge
* Chameleon MBeans
* Spring Framework

Change-Id: Icbc4368941f109e7b835323b2dfbcef0b335e8bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Checkstyle InnerAssignment

see http://checkstyle.sourceforge.net/config_coding.html#InnerAssignment

Change-Id: Icaaaa3ff3a08843b2ed1bf013edf7110b49b547c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump Uncommons Maths 1.2.2a → 1.2.3

This version adds OSGi bundle information:
https://maths.uncommons.org/changelog.php

Change-Id: I379e8d857f936f4471a1529adb0f3cc363d20d3e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump logback 1.2.2 → 1.2.3

Release notes: https://logback.qos.ch/news.html

Change-Id: If03272caf0a419541d1e4203539a83b85622737b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump gson 2.7 → 2.8.2

Release notes: https://github.com/google/gson/blob/master/CHANGELOG.md

Change-Id: If6c7369442a68ce9d2545010335cb422d2f45238
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump lmax disruptor 3.3.6 → 3.3.7

Release notes: https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.7

Change-Id: I0fd240efa3d24fb524961cfed01ebf091650adb7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-fileupload 1.3.2 → 1.3.3

Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt

Change-Id: Ic18fec72aea51fe33debd160b03d984e512ecbed
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump commons-io 2.5 → 2.6

Release notes: http://www.apache.org/dist/commons/io/RELEASE-NOTES.txt

This version is now a Java 9 module.

Change-Id: Ie5ca856b636347927d4bf9e3d1fd824d79b02a8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump JSONassert 1.3.0 → 1.5.0

Release notes: https://github.com/skyscreamer/JSONassert/releases

Change-Id: I5d066a5168a22d1b56b61e19d9582deacf9f21a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump SLF4J 1.7.21 → 1.7.25

Release notes: https://www.slf4j.org/news.html

Change-Id: I8092ba8f07824c8433774898c24d25d5e3510680
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Karaf 4.1.2 → 4.1.3

Change-Id: Ia3eb52ca11cc3e3e870badf469ef8ead7294d031
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>