Code clean up

Remove redundant cast/type argument

Change-Id: I446cb24bdbcb5156136899798eb6d3d607291e62
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unused test class

Remove unused test class MockPCE

Change-Id: If0afe1e8f78beca02dd397c9e18f3da408a939bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required pcepdump

Remove no longer required pcepdump.py

Change-Id: I662f6971c3b0e210e4c692402a23617d6e473939
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Synchronize ServerSessionManager for PCEP

Add the check so that session manager can only be closed once
and becomes unusable after closing.

A java.util.ConcurrentModificationException is possible to happen
due to the close() method of ServerSessionManager is not synchronized.
The situation mostly likely will happen during a controller reboot.
It may also happen when a PCEP config is updated. The ServerSessionManager
is being restarted while all the PCEP negotiation is still happening.

Change-Id: I0e0d387add046a4fe9ec5ac74a85f8350e238d60
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 7a866eee4dec5dc368ef11c90473b3c2a256f281)

BUG-7550: Implement CSS under Operational State

Implement Cluster singleton service under
Operational State.

Change-Id: Iaea4d97948b8c260fb38172107a155a298fd889e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

replace long literal 'l' by 'L'

Change-Id: I9d8bffb3559887336299e84d77db82fdf7e5f379
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7776 Fix Test

Change-Id: I86bafac12ceada82f18b27bb7adeeaa4ca6783c3
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7706: Fix ServiceUnavailableException

Reconfigure BGP Server durin a session, will produce
ServiceUnavailableException at the moment session is
closed and tries to remove peer from StrictRegistry.
Fix by put aside registry from Peer Acceptor, therefore
when BP container is restarted reference wont be lost.

Change-Id: I4eb018a24e5c5ea2a4b479cba61d94cb3658f583
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Migrate test from junit 3 to junit 4

Change-Id: I88e78739de6acf531154e2238e569ad5abd2f0da
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7512: BMP features migration to karaf 4

BMP features migration to karaf 4

Change-Id: Iee8a60c7831cb8a5af791b297b2052648e21b26e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7510: BGP features migration to karaf 4

BGP features migration to karaf 4

Change-Id: I78156ba3da5a5da396d8b98bc77f79e16ae8d2c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7739: Fix ParserToSalTest/Topology Tests

Fix ParserToSalTest/Topology failing test

Change-Id: I01cec1b9ab83c14cec8674465ed690e77d820adc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7708: Invalid Route Distinguisher error while processing withdraw update containing VPN route

 - RFC 3107 says that label value in withdraw message should be 0x800000
   ref. https://tools.ietf.org/html/rfc3107#section-3
 - Changed code to correctly handle this value in withdraw message received from peer.
   Also ODL will now use this value when sending withdraw message to its peer
 - Updated unit-tests accordingly

Change-Id: Ie9d90779c32e9141f953a18b07a86d0624eaee5c
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 16e0aa31e782252f25860556bd3eb4fd59431789)

Pull in osgi.core explicitly

Inherited scope runtime is not sufficient, as something
in the dependecies is causing us to compile against 4.3,
which does not have generics.

Change-Id: I7a4fda07f10859698892414b43ba64cbb6e5f3fb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

replace asList by singletonList

Change-Id: Ie3235ce8e7c7df527765e69183a52a1d56f30d70
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Switch to using odl-netty-4

odl-netty is deprecated by odlparent, the new name is odl-netty-4
and shares odlparent's version.

Change-Id: Ib07fea42952d9c9a157fb8d3c9fa7f6a2ce7128c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove unnecessary semicolon

Change-Id: I1fae14a786876bdb5da830a31d64987498bd18ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7511: PCEP features migration to karaf 4

PCEP features migration to karaf 4

Change-Id: I490f7504c078cf21642d9fd527d2bd4ac9dd83bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7514: Extras features migration to karaf 4

Extras features migration to karaf 4

Change-Id: Ie5f459a45ab74baa17b3544cba101beaadaabf12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove duplicate code for test utilities

Remove duplicate code for test Utilities

Change-Id: I8d7d2652cd5159af106d439a6b62767a73296e87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7732: Improve BGPDeployer synchronization

Improve BGPDeployer synchronization

Change-Id: I0a4c321ac36efefea473d0e2557588c6d687d5d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7723 Change BGP connection failure log level

Change the BGP connection failure log level from DEBUG to WARN.

Change-Id: I68766d8849a7ce246959534b5fc80aa2eaf8fc3c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7251: Remove pcepy

Remove pcepy folder

Change-Id: I571c9f8f646c0b8207a203a06a49a47649a59c83
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix missing relativePath

odlparent-lite is outside of bgpcep project, hence
it should have an empty relativePath

Change-Id: If40a1eed870c69bb71290cd19139681fafa18e4e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add relativePath to RSVP4-features

Add feature-repo-parent as relativePath

Change-Id: I91167632297b629a023b49a019a4fad99dda4ac2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7364: BGP Peer Acceptor Rework

- Decouple BGP Peer acceptor from BGPAcceptorConfig
- Add missing destroy method close to BP

Change-Id: I3aeaa9923f02466255cf98bc50dca9b06b7959f2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7513: RSVP features migration to karaf 4

RSVP features migration to karaf 4

Change-Id: Ic37f898e73a56ac76526ebd92ef0068a9fc95908
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove deprecated Interfaces/Methods

Remove deprecated Interfaces/Methods

Change-Id: Ia543c2e6afd09c753c0a662d4811cb7a4ce1fcc5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

\BUG-7386 Remove blocking gracefulshutdown

Remove blocking gracefulshutdown for EventLoopGroup

Change-Id: I03fd04cd77d613ce4b8c83f1f48deb3142227bfb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7673: Improve synchonization under BGP/PCEP Session

- Improve synchonization under BGP/PCEP Session
- Code clean up

Change-Id: I93851323232fa9df0c23e1e23751320cdf578031
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7351: Update IRO reference

IRO is compliant of rfc7896 therefore we
update the reference.

Change-Id: Ia31d2e5c59ba68b966a53f92482dad56380c809b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Replace FindBugs :jsr305 by full :annotation (Bug 7663)

Change-Id: Ic036e549569cc5eb02958bc22702266eaaed7ff5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-7673: Fix PCC Mock test failures

Fix PCC Pcep test failures by passing missing executor
Fix annotations
Fix warns for keepAlive size

Change-Id: I0013af17e01d2d8afa136a16d6315719e0aac3fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Implement BGP Operational State test

BGP Operational State test implementation

Change-Id: I88805d83c55b20661619da091c69025af1413f81
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: BGP Openconfig State Impl test

Test implementation for check of BGP Openconfig State Imp

Change-Id: I86d58892a30dc995898b637d903bec2b606d60c1
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7558: BGP SingleFeatureTest Failure

BGP SingleFeatureTest Failure fix by
create an specific feature for all
config-file and added as a dependency
for Config-loader feature.

Change-Id: Ifb79c898ea8cba4e68fdd257c2d8c3498ebb559b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: BGP Operational State

Implement BGP Operational State per
Global and Neighbor.
Operational State per PeerGroup is also
implemented and will need to be plug in
once Peer Group is supported.

Change-Id: Ic1a75348e370bdd06777267c153b924acc3b4c15
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Rework Openconfig State Features dependencies

Openconfig State Features should depend on rib-impl
feature and not the other way around

Change-Id: Id40c99a637b670d6d4591c090321f77ecab39a8f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Prepare upgrade to Netty 4.1

We need to widen the range of allowed versions for odl-netty.

Change-Id: Ib2340ef08a41dcb6508afccbb420b52f94be6051
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-5032: BGP Openconfig State Implementation

Introduce service on charge of store
BGP Operational State as an Openconfig
Operational State format.
Introduce Utilities to convert BGP Operational
State to Openconfig State.

Intruce a cache TableType-AfiSafi under
BGPTableTypeRegistry. Table type will be stored
as they are required.

Change-Id: I3cb546f7f332e7f9eb7bba0a45d366fca0c4d0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Implement BGP State Collector

BGP State Collector act as a provider of
all BGP Rib States.

Change-Id: I4d4919d10d168561c087b742fcd76dfbe9b6912b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5032: Introduce BGP Operational State

Introduce interfaces for expose BGP Operational State for:
-RIB
-PeerGroup
-Neighbor
-BGPState Collector

Change-Id: Ib6b053f4e7e734eb3f4525f7de4643c9b89c9a31
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Replace UnsignedInt32Counter by LongAdder

Replace UnsignedInt32Counter, which is not
efficient and only provides of logs which are of
not use for a more suitable counter(LongAdder).

Change-Id: Iaad4879c9c3a783ac45f21d47f3379b22f22e3e4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix invalid YANG 1.0 leafrefs

Two YANG 1.0 models contain leafrefs with require-instance substatements
which is not valid for YANG 1.0 version. Comment out these substatements
for now. In the future, when YANG 1.1 support for such substatements
will be available, they can be uncommented.

Change-Id: I59cc7bd8f3fdcd14d96ee672fbceaf1d48f5836d
Signed-off-by: Igor Foltin <ifoltin@cisco.com>

BUG-7251: Remove pcepy

remove no longer required pcepy code

Change-Id: Ib99682fc221b33b17ef972f1309dab43506cfa08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-7159: eliminate use of CrossSourceStatementReactor

We have YangParserTestUtils which are more convenient, use them
instead.

Change-Id: Ia7810aec6f7a6c66a71a1523993b45d274c57606
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix Sonar complains

Fix naming convention, etc..

Change-Id: I2048e319bcef7bf41c47631413e0e9c9468c499d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7215: Fix App Peer ModifiedNodeDoesNotExistException

If Rib is reconfigured with different Family than the
previous supported one, application peer will be
reconfigured. In the case there are some routes or,
family table configured on Config DS, when restarting
App peer with new configuration will end on
ModifiedNodeDoesNotExistException.

Fix by:
   -Make Application peer more defensiveness by ingore changes
 on config DS for non supported Families.
   - Register Change Listener once AdjRibIn has been
 succesfully initialized.

Change-Id: I25b08b057fad02df365070c0a6d5177b9e0392a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7028: Migrate BGP Benchmark App to BP wiring

Migrate BGP Benchmark App to BP wiring

Change-Id: I5632a5ec3afde41862004e172e451fc358c53eab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7222: Fix clustering BGPPeer NPE

Fix NPE: Any call to rib should be done
during singleton service instantiation or after.
Any call before can cause a NPE since RIB might be
on undefined status yet.

Change-Id: Ia1ebbc334f07362f325ac599f39f9d601e717321
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Pcepy: Address pep8 violations

Newer libraries used in verification are more sensitive to
"E305 expected 2 blank lines after class or function definition".

Change-Id: I3f94115bb70b069f3eb417429bbc457c73048a7a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

BUG-7003: Remove Thread.sleep() calls in tests

Partial improvement under Additional Paths tests.
The time spent has been reduced.

Change-Id: I8ebfd19af9147a10f1d5856b5478501f2ab890ab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Misspelled method name correction

Change-Id: Ic6d803b6853324efa9e7868d142cf184fda47f58
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-7006: Unit-tests sometimes hangs during execution

Fix sporadically hangs during unit-tests execution

Change-Id: Ia339af6d9181a7be8e4b3e6335bba250aaecd822
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7098: Fix Sonar complains

Fix duplicate code
Naming conventions

Change-Id: I2425fc111b5890100cda942913b0d617b4029f2c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7003: Introduce CheckUtil

Introduce CheckUtil for replace Thread.sleep on tests

Change-Id: I6a74b7dc9563594424c8b1a0b03ca39890d3e803
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7088: pcep-pcc-mock fails to start

Fix by exclude the signatures otherwise
we get an SecurityException.

Change-Id: I4eb8a6d945e6c0ff4e5d9612e59d93ea95044d03
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix wrong config version

This break autorelease, fix the version declaration.

Change-Id: I50ac84924ff4eaae47b8891485310df351d6ed56
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove openconfig-impl module

This module's code is no longer used in project.
The modules funtionality has been moved to rib-impl an openconfig-spi.

Change-Id: I25a7d3f7da7326abe8dea915cfb62515e394f8e5
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Do not install openconfig-impl bundle

This bundle is not longer used, remove it from BGP's features.

Change-Id: I4c919468966dc96c8498148eafd3b407649defee
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Use BGPTableTypeRegistryConsumer instead of BGPOpenConfigMappingService

The BGPTableTypeRegistryConsumer is providing access to the map supported AFI/SAFI.

Remove BGPOpenConfigMappingService in a next step.

Change-Id: I837fe90446da983a4bad1f91fed871052ca67ef6
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Register L2VPN EVPN AFI/SAFI

Change-Id: If2f3c18606053df53c9e5c1c69e976c3b8ea16df
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Register IP L3VPN AFI/SAFI

Change-Id: If084f0b653af09d7729c038077ef908621840e2b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Register IP Labeled Unicast AFI/SAFI

Change-Id: I0b17e3bd205122a84b2c7f22adc1e71ac2a7fa3a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Register Link-state AFI/SAFI

Change-Id: I7c5c6ccafa23e555d10a0f8461513200c4173d6d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Register Flowspecs AFI/SAFI

Change-Id: I6394e921688ebcdf163e129ff01ebdc251dfd0df
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-6857: Network topology configuration file loader test

 Network topology configuration file loader
 implementation test

Change-Id: I243aac6f2de35b8f867c766116fa6b0a9d6278bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Register IP Unicast AFI/SAFI in inet extension

Change-Id: I53c4cfeca8cc81c2ebd6b067b287366850f5cbe2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-6857: Protocol config loader tests

Protocol config loader tests

Change-Id: I0dfb4db04b23cab700ee7dd41a59734bfd4ce690
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Define OpenConfig API feature

In order to register AFI/SAFI suppport in BGP-MP extension,
define new OpenConfig API feature carrying API and SPI bundles.

Change-Id: I9f91639bf91b98924cb80fe4f8bbbd4903ff1d5d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Introduce BGPTableType Registry

The registry is holding supported AFI/SAFI in form of BGPTableType and OpenConfig AfiSafiType.
Currenlty, this two AFI/SAFI representations mapping is held in static map, which lacks of extensibility.
The registry provider context is supposed to be activated in BGP-MP extensions.
The registry would be consumed in BGP configuration mapping procedures.

Change-Id: Ib34147f56d85bf418b29924d6d1f805d4ed1a757
Signed-off-by: Milos Fabian <milfabia@cisco.com>

OpenConfig IMPL clean-up

Move all mapping utilities from OpenConfig IMPL to RIB-IMPL.

Next step - get rid of the static map (BgpTableType<->AfiSafiType) - extensibility is essenatial here.

Change-Id: Id88b8564d89138e78803bc7a6cf7d7b1ed5b879f
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-6857: Config file loader test

+ config file loader test implementation

Change-Id: I5035d333d0eb5a57be19cca0ebd2e4a57de5bd40
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6857: Migrate from CSS initial config

Migrate from CSS initial config to Config Loader.

Change-Id: I8b2cb0e1cbcab62b2a50f94c3011ca0b8e70677f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Derive aggregators from odlparent-lite

There is no point in inheriting from parent,
just use odlparent-lite. Should speed up the build
process.

Change-Id: Iecdf1b5d7c44d7f5f1c84a2107bf51c7011b6f23
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6857: Network Topology Config Loader

- Create NetworkTopologyConfigFileProcessors
  Serialize Topology normalized node to BI
  and notifies Deployer, loading new configuration.
- network-topology-config.xml Contains Ipv4 topology,
  Ipv6 topology, Linkstate Topology.

Change-Id: I7f0a607f43586e54952ff623ac1250bb55e33b54
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6857: ConfigLoader rework

ConfigLoader rework. Split Watchservice.

Change-Id: If0a07f03b3f923d940eb0c8dc31acc691870cb0b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6857: ProtocolsConfigFileProcessor fix

sort registration

Change-Id: I852def5a937d55580b4cb9d9c54a2f5938854bc3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug 6622 - ClusterSingletonService registration race condition

This is a hot fix for a race condition issue which can happen during a service lifecycle.
An application which manages services in not aware when the unregistration is finished, hence
service close is followed by immendiate service registration which may fail consequently.
This condition is handled by reatempting service regsiration after 10 ms.

Also fixes RIBImpl - create TX chain in #instantiateServiceInstance and asynchronously clean operatoinal DS.

Change-Id: I110badc8bfb482a5b7cb6545b882cda2d0c661ae
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug-6781: Inbound and outbound connection attempts from controller are not synchronized
- created new peer session listener registry in BGPPeerRegistry for the
  outbound connection establishment logic to get notified when new peer
  session is created or destroyed
- updated outbound connection establishment logic to attempt a connection
  only when no existing session is present
- updated unit-tests

Change-Id: Ie6afb79e290c1a3c98d82af87febd6851ad200c2
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 81050d598744b6d5fab63302f747c70ff03c366f)

Bug-6737: bgp:show-stats Karaf CLI causes NPE

Change-Id: I2006c119d1213b0a69ca11c0cb557dd503d69cc6
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 40a2e9a540863b5bfefdd8d252dadf7e7a1ec741)

Bug-7004: NPE when configuring BGP peer using OpenConfig API twice
- handle scenario where peer not having AFI-SAFI info is
  reconfigured using OpenConfig API
- updated unit-test

Change-Id: Ib9dd4550814fe861ab60efc3276cb91b45692078
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 7309aa7129e23dda57754ce786a2f330ec914331)

Bug-6889: BGPCEP Boron Autorelease Breaking
- if server is not ready when client connects, wait for client reconnection
  before checking for test pass/fail criteria

Change-Id: I172d3e829f70081f0d943458dd43c6139381bf61
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 617ca03430bde5614118d514204a086a9300b1d1)

Do not wrap Guava as a bundle in features' definition

As it will refresh the bundle when the feature is loaded,
because it will certainly be already installed,and hence
will refresh all bundles depending on Guava.

Also, this is not necessary.

This patch is not directly tied to BUG-6956 but it's a result of it

Change-Id: If2fff1c6326fb8b53786d59e94c364cf0f3292c3
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Add missing dependency

see: https://git.opendaylight.org/gerrit/#/c/47166/2/features/bgp/src/main/features/features.xml

Change-Id: I5044b6a084678bd3dfc2128db74a9b06cb8cd177
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

BUG-6857 - Initial configuration file loader for BGP

- Create BGP Config Loader service,
 Takes care of load files under etc/bgp/ and notifies
 ConfigFileProcessors when files matches patter.
 Pattern is created based on schema name
 eg. Procotols Schema requires files protocols-*.xml
- Create ProtocolsConfigFileProcessors
 Serialize Protocols normalized node to BI and notifies
 Deployer, loading new configuration.
- protocols-config.xml
 Contains BGP initial configuration ( Rib + Peer)

Change-Id: Ic350584c84f90653fe970748a6a05e7b30286835
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove reference to sal-inmemory-datastore config system file

It was deprecated here: https://git.opendaylight.org/gerrit/#/c/44882/
thus no need to keep the config file namespace around.

Change-Id: I304e8df8370cc86c253f39f4e40db7760eaa57ae
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

BUG-6980: rename commons.opendaylight.version

Just for coherence, this patch renames commons.opendaylight.version to
odlparent.version.

Change-Id: Ic74f8ec405a3806208f1b517f8ee91e09e581eff
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-6955: Fix BGP TestTool

Register BGP Extensions

Change-Id: I1fd1874d580ad922afa776d45c195118b694286f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6954: Create Application Peer with Route Counter

Create Application Peer with Route Counter

Change-Id: I41faaa0dedebb158139987617a1106ddd9c584a5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6844: Remove BGP Peer Acceptor Module

Remove BGP Peer Acceptor Module and corresponding
yang models, since they are not longer required.

Change-Id: If0ad806c25b040051e299061b28022c0bf4ebc6d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6844: Wire BGP server with blueprint

- Wire BGP server with blueprint
- Support multiple instances of BGP server
- Creation of bgp-peer-acceptor-config
- BGPPeerAcceptor test

Change-Id: I7b1b57d4e7572d021884f55ad96693035cad9d04
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-6257: Implement PMSI tunnel attribute handler

-Fix pmsi tunnel attibute yang model
-Implement PMSI tunnel attribute handler
-Implement test

Change-Id: Iffc1750724c3e97d1694fba8360007741ad08d80
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug-6889: BGPCEP Boron Autorelease Breaking

Increased timeout in BmpMockTest using Mockito#timeout
(it waits till timeout only if needed)

Change-Id: I8151757aa29a46c30b674398efeddc711189ac93
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit bf9d2ba0f80146b8ded3cc61c2472d89ade35f3d)

Bug 6788: peer singleton service closed just after initialization

In case of HA failover scenario, configured peer is not getting initiated on
new singleton group master node, as the neighbor is removed from configuration when
default example-rib-impl is initiated (OpenConfig BGP configuration written to config DS).
To avoid overriding neighbors configuration after failover, minimize scope of rib-impl
representation from "protocol" to "global" node.

Change-Id: If4df2a070e0cbceae1c42cbe0d0c5a2258388092
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 6809: PMSI attribute's mandatory leaves are always enforced

The PMSI Tunnel is an optional BGP path attribute.
Enforce the attribute's leaves presence only if the attribute is present in route's attributes.

Change-Id: Ifadf68ac30791614ed7695b940d3042cdca6aeb7
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 6811: wrong namespace for binding-codec-tree-factory

Set correct type of binding-codec-tree-factory in initial BGP configuration.

Change-Id: Ic35a0089157f02be9d5d45bc08e23f377c2dd649
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 6835: Missing "simple-routing-policy" knob in OpenConfig BGP Neighbor configuration

Enables to configure simple routing policy (learn-none/advertise-none) via OpenConfig BGP API.

Change-Id: I1de260e57e603d5abf09f891a5fc971861217e0d
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 6675: add missing cluster-id configuration knob

Enables global cluster identifier configuration for local RR.

Change-Id: I810ffcd097795ea4296a89a624f762863fea6526
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-6616: BGP synchronization can happen after the session was closed

Fix by handle message only when session is up.
-Handle exception in synchronation mode.
-Sort close of the session, removal of the peer
and send close reason message.

Change-Id: I21328f9a63d5360603f219cd3699b08874da318b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>