openflowplugin.git
10 years agofix for BUG-947 - ErrorHandler classLoader issue 25/6725/4
Michal Rehak [Mon, 5 May 2014 15:05:20 +0000 (17:05 +0200)]
fix for BUG-947 - ErrorHandler classLoader issue

- exception must be logged in the same thread as there is thread classLoader context, which might differ from the previously dedicated thread for exception logging

Change-Id: Ia2f911fdd5845280575fcb6a57c16aafdc0c2b53
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG-709 - connectionCookie generate, use 61/6661/5
Michal Rehak [Fri, 2 May 2014 07:47:24 +0000 (09:47 +0200)]
fix for BUG-709 - connectionCookie generate, use

- session cookie is based on datapathId only (not exposed, based in BigInteger)
- connection cookie is based on auxiliaryId, unique hashed key is exposed

Change-Id: Ifc293f876b3e57be38622141e92f8cdb0e47d056
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMerge "BUG-985 - finisher queue is unbound"
michal rehak [Mon, 12 May 2014 17:57:37 +0000 (17:57 +0000)]
Merge "BUG-985 - finisher queue is unbound"

10 years agoBUG-985 - finisher queue is unbound 85/6885/4
Jan Medved [Mon, 12 May 2014 05:39:50 +0000 (22:39 -0700)]
BUG-985 - finisher queue is unbound

and causes out of memory error under stress

- replaced queue.offer with queue.put (blocking behavior)

Changed the initialization of the TicketFinisher queue to limit the size of the queue to 1,000 elements. Backpressure will be exerted when the max queue size has been reached. This is to fix an out-of-memory condition that occurs under heavy load when the TicketFinisher queue grows w/o bounds.

Change-Id: I619d1c27db98fec95380bef2504add3025195abc
Signed-off-by: Jan Medved <jmedved@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMerge "Added statistics for received packets in and for sent addFlows to the RPC...
michal rehak [Mon, 12 May 2014 17:06:59 +0000 (17:06 +0000)]
Merge "Added statistics for received packets in and for sent addFlows to the RPC and Data Store drop tests. BUG-991 (https://bugs.opendaylight.org/show_bug.cgi?id=991)"

10 years agoAdded statistics for received packets in and for sent addFlows to the RPC and Data... 55/6755/6
Jan Medved [Tue, 6 May 2014 17:57:57 +0000 (10:57 -0700)]
Added statistics for received packets in and for sent addFlows to the RPC and Data Store drop tests. BUG-991 (https://bugs.opendaylight.org/show_bug.cgi?id=991)

Change-Id: I3a99bb81c8eadf87d731715b1f40f36af9734ba9
Signed-off-by: Jan Medved <jmedved@cisco.com>
10 years agoBUG-986 - remove catch Throwable (sonar) 92/6892/2
Michal Rehak [Mon, 12 May 2014 12:05:28 +0000 (14:05 +0200)]
BUG-986 - remove catch Throwable (sonar)

- avoided catch of Throwable
- decreased some debug levels to trace

Change-Id: I26b6a8f260fc6db5596df07f9408010118a72ea1
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoFix for Bug 957. 35/6835/1
Ravikumar Chiguruvada [Fri, 9 May 2014 13:07:36 +0000 (18:37 +0530)]
Fix for Bug 957.

Signed-off-by: Ravikumar Chiguruvada <ravikumar.chiguruvada@ericsson.com>
Change-Id: Ifa471d462f4800f553bb68d3ed7fe1cc71a17fcc

10 years agoMerge "BUG-976: jenkins slowed down by dowload from nexus"
Michal Rehak [Thu, 8 May 2014 10:08:21 +0000 (10:08 +0000)]
Merge "BUG-976: jenkins slowed down by dowload from nexus"

10 years agoBUG-976: jenkins slowed down by dowload from nexus 12/6812/2
Michal Rehak [Thu, 8 May 2014 08:47:59 +0000 (10:47 +0200)]
BUG-976: jenkins slowed down by dowload from nexus

- removed opendaylight.release repository (contained in groups/public)

Change-Id: I190e3ccd9482ab58dd5502567b4d2a7e14b5e68f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoFix for Bug 957 02/6802/1
Ravikumar Chiguruvada [Thu, 8 May 2014 06:17:00 +0000 (11:47 +0530)]
Fix for Bug 957

Change-Id: Ifea346315b62b36d3c9c8bf2a180c7db157f4b79

Signed-off-by: Ravikumar Chiguruvada <ravikumar.chiguruvada@ericsson.com>
10 years agoMerge "additional fix fro BUG-782 unregistering switch providers"
Michal Rehak [Wed, 7 May 2014 22:43:47 +0000 (22:43 +0000)]
Merge "additional fix fro BUG-782 unregistering switch providers"

10 years agofix for BUG-956 - deadlock by rpc invocation 38/6738/3
Tony Tkacik [Tue, 6 May 2014 10:20:37 +0000 (12:20 +0200)]
fix for BUG-956 - deadlock by rpc invocation

- fixed future chaining
- added rpcPool for asynchronous processing

Change-Id: I19c9b94e383f3e3f5bfff179a966b1950a942821
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoadditional fix fro BUG-782 unregistering switch providers 60/6660/3
Michal Rehak [Wed, 30 Apr 2014 07:26:29 +0000 (09:26 +0200)]
additional fix fro BUG-782 unregistering switch providers

- CompositeObjectRegistration is stored into sessionContext upon addSession
- upon removeSession the CompositeObjectRegistration is closed

Change-Id: Ieee90f50645db12c5df198fd4501daa804a135d3
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoIT fix BUG-837 - missing dependencies 95/6795/1
Michal Rehak [Wed, 7 May 2014 15:13:06 +0000 (17:13 +0200)]
IT fix BUG-837 - missing dependencies

- thirdparty stuff
- netconf stuff
- config stuff
- logback config

Change-Id: I5f19bf187af6b29ecf65c3eb287da940d4f75fa0
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG-948 - changing log level for portStatusMessage 08/6708/1
Michal Rehak [Mon, 5 May 2014 12:05:28 +0000 (14:05 +0200)]
fix for BUG-948 - changing log level for portStatusMessage

- in translator the port status message content was logged inappropriately using error level

Change-Id: I3b395b09c39b0c88c6a0d3f452ade412d9c8f68a
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix2 for BUG-837 - bindingAwareBroker waiting 12/6612/1
Michal Rehak [Wed, 30 Apr 2014 07:45:25 +0000 (09:45 +0200)]
fix2 for BUG-837 - bindingAwareBroker waiting

- updated controller.xml - configSubsystem IT changed in sal-binding-it

Change-Id: Ib28900451951b1dd1ab1207f9c9e7bc7c58c577c
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG 782 - NPE in ErrorTranslator during handshake 13/6513/1 topic/threading
Michal Rehak [Mon, 28 Apr 2014 09:38:39 +0000 (11:38 +0200)]
fix for BUG 782 - NPE in ErrorTranslator during handshake

- there is no session available before registration

Signed-off-by: Michal Rehak <mirehak@cisco.com>
Change-Id: Ib0e420a879c6512e5f86003ad9d024aee789c04d

10 years agoflowCookieMask conversion fix (BUG 840) 57/6357/1
Michal Rehak [Thu, 24 Apr 2014 12:13:23 +0000 (14:13 +0200)]
flowCookieMask conversion fix (BUG 840)

Change-Id: I8c601bc1cd5865f2112dbe87176d2bef5f80b608
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoIT unstability fix - BUG 837 43/6343/2
Michal Rehak [Wed, 23 Apr 2014 16:42:25 +0000 (18:42 +0200)]
IT unstability fix - BUG 837

- registration of node by md-sal keeps failing - if closing of connection will wait for 2 secs after handshake, md-sal should succeed in registering

Change-Id: I510defd8bbb7334eaaebc4b066d019b6de2af040
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoBug:701 - Have Typed ErrorNotification for different node errrors 50/6250/2
Kamal Rameshan [Thu, 17 Apr 2014 03:02:41 +0000 (20:02 -0700)]
Bug:701 - Have Typed ErrorNotification for different node errrors

Change-Id: I77cc6c8b443e6a6598f499043b6e5c242be23a1d
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
10 years agofix for BUG-709 - mixed up flow cookie and connection cookie 60/6260/2
Michal Rehak [Thu, 17 Apr 2014 15:15:59 +0000 (17:15 +0200)]
fix for BUG-709 - mixed up flow cookie and connection cookie

- flow cookie [64b] is present at receivedPacket (to distinguish responsible flow)
- connection cookie [32b] is present at receivedPacket and is expected
  to be copied into corresponding transmitPacketInput (to distinguish auxiliary connection)
- offtopic: felix generated META-INF moved to target (drop-test, test-provider)
- hotfix - InstanceIdentifier API changes adaptation

requires controller change: https://git.opendaylight.org/gerrit/#/c/6259/

Change-Id: I76d30ba6ba16bf6ac57977288ee30ab059c12659
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG 766 - failing IT because of new dependency 51/6251/1
Michal Rehak [Thu, 17 Apr 2014 09:23:24 +0000 (11:23 +0200)]
fix for BUG 766 - failing IT because of new dependency

- added org.opendaylight.controller.thirdparty:nagasena dependency for pax
- cleaned deps already included in TestHelper

Change-Id: Ie36bc3b0055b9db7b2b5617fad51801917d28aaf
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoadditional config disribution (BUG 541) 32/6232/1
Michal Rehak [Wed, 16 Apr 2014 07:28:30 +0000 (09:28 +0200)]
additional config disribution (BUG 541)

- added subproject in order to distribute configSubsystem xml

Change-Id: Ida89544a9ed1b7d53de797357730ead0a11130dc
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoconfig subsystem integration - BUG 541 84/5884/2
Basheeruddin Ahmed [Thu, 3 Apr 2014 00:55:01 +0000 (17:55 -0700)]
config subsystem integration - BUG 541

added configuration xml for configSubsystem
added sal code generator
changed reference to swichConnectionProvider (now there is collection)
changed startup in order to use configSubsystem wiring
preserved the osgi BunndleContext access for cli stuff
fixed IT (configSubsystem related stuff)
enabled documentation generator
upated Future obtained from OFJava to ListenableFuture
changed wiring to OFJava (1switchConnectionProvider = 1 switchConnectionHandler)

Change-Id: I9b7ca8a173e4a36381411cec08772d8440180a03
Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoBug 651 - cleanup eclipse errors in openflowplugin 08/6008/4
jameshall03885 [Wed, 9 Apr 2014 17:16:05 +0000 (13:16 -0400)]
Bug 651 - cleanup eclipse errors in openflowplugin

- To avoid devs from having to run the IDE profile so eclipse can see the yang
generated source files, the yang source files are now generated under src/main/yang-gen-sals
or src/main/yang-gen-config instead of target/target-ide.

- The maven-clean-plugin was moved to the ofp parent pom and removed from
all child poms where it was specified. Thus, it will be automatically run for all
projects. The plugin's execution will clean all xtend and yang generated source dirs.

- The build-helper-maven-plugin was also moved to the parent pom and removed from
all child poms. It will automatically run for all projects and no longer needs to be
specified in child poms. The plugin's execution will created eclipse source folders
for all xtend and yang generated source.

I also removed two occurances of "&gt;" which seemed extraneous ... but perhaps I'm unaware of some pom.xml magic?

Change-Id: Ie99e141e55e03a3a3ebce3743624e7bea6e42e7b
Signed-off-by: jameshall03885 <ghall@brocade.com>
10 years agoBug:679 - eliminate the use of xtend in openflowplugin 33/6033/2
Kamal Rameshan [Thu, 10 Apr 2014 18:43:42 +0000 (11:43 -0700)]
Bug:679 - eliminate the use of xtend in openflowplugin

- replaced xtend classes with pure java classes
- removed xtend dependency and plugin from pom

Change-Id: Ia0fdf0b7162b04143a5e654971536481f28c3b2a
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG 661 01/5901/1
Michal Rehak [Fri, 4 Apr 2014 07:32:34 +0000 (09:32 +0200)]
fix for BUG 661

- lowered version of commons-codec (to 1.7 - specified in dependencyManagement of parent)

Change-Id: I7f262318deeaac2aaf7abfc7f1221874d725ed0c
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMerge "Added missing keys. This allows to reuse DTOs for operational/configuration...
michal rehak [Thu, 3 Apr 2014 11:48:16 +0000 (11:48 +0000)]
Merge "Added missing keys. This allows to reuse DTOs for operational/configuration data."

10 years agoAdded missing keys. This allows to reuse DTOs for operational/configuration data. 35/5835/1
Tony Tkacik [Tue, 1 Apr 2014 14:56:01 +0000 (16:56 +0200)]
Added missing keys. This allows to reuse DTOs for operational/configuration data.

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agofix BUG 596 (part2) 21/5821/1
Michal Rehak [Mon, 31 Mar 2014 13:14:45 +0000 (15:14 +0200)]
fix BUG 596 (part2)

- reenabled fixed SalPortService interface (providing portUpdate)

Change-Id: I5adbf8e1868abf55f319b1d03d5d44deca88b378
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agovlan ID fix 09/5809/2
Prasanna Huddar [Sat, 29 Mar 2014 11:47:43 +0000 (17:17 +0530)]
vlan ID fix
Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
10 years agofix for BUG 609 07/5807/1
Michal Rehak [Fri, 28 Mar 2014 23:06:35 +0000 (16:06 -0700)]
fix for BUG 609

- extra hello message is being disregarded

Change-Id: Idfe6009c5791d2441c1e5fe5311b75b6927d5f5f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoReenabled integration tests - part2 06/5806/1
Michal Rehak [Fri, 28 Mar 2014 21:38:10 +0000 (14:38 -0700)]
Reenabled integration tests - part2

- adding dirty sleep to have the controller part up and running

Change-Id: I1f6e9b617d10df162631af34598206b7b5d81bf5
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoReenabled integration tests 75/5475/3
Michal Rehak [Tue, 11 Feb 2014 10:30:05 +0000 (11:30 +0100)]
Reenabled integration tests

- added osgi console and debug support for IT
- pulled dependencies to parent pom (including IT dependencies)
- fixed dependencies (pax, config-manager, commons-codec, junit)
- fixed pax bundles
- tidied up plugin activator + OpenflowPluginProvider
- changing reactor strategy to perClass (speedup testing)
- added AutoCloseable interface to ErrorHandler
- moved errorHandler setup up to MDController
- enabling of SalIntegrationTest
- added check whether the SimpleClient succeeded to connect to controller

- updated versions of sal-api, netconf-connector, config-manager
- added 5s wait on startup - dirty temprary solution untill configSubsysten

- rebased

Change-Id: I21ff052ff6d90ff95f5b8b2a51fb8d736e697034
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix for BUG 596 81/5781/2
Michal Rehak [Wed, 26 Mar 2014 19:21:11 +0000 (12:21 -0700)]
fix for BUG 596

- SalPortService wont be supported for now

Change-Id: Ia9f140d969e324630fbe7d64bd03ff8d198bc0c5
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoBUG-592: prepare for API change 88/5788/2
Robert Varga [Thu, 27 Mar 2014 00:35:03 +0000 (01:35 +0100)]
BUG-592: prepare for API change

getPathArguments() was added by mistake with its current return type. It
will be fixed in a follow-up patch, so fall back to getPath(), which does
the same thing, such that it won't break when things change.

Change-Id: Iae3661aa8942e050c0ac638cce0bec6dae9fa290
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
10 years agoquickfix - added missing org.osgi.core provided dependency 69/5769/1
Michal Rehak [Wed, 26 Mar 2014 02:59:53 +0000 (03:59 +0100)]
quickfix - added missing org.osgi.core provided dependency

- sample-consumer
- learning-switch

Change-Id: Ibb4f5fa3abcfa88103097e95a147712ddf06d2ff
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMerge "Added required keys to items in DropTestCommiter."
michal rehak [Tue, 25 Mar 2014 02:23:25 +0000 (02:23 +0000)]
Merge "Added required keys to items in DropTestCommiter."

10 years agoAdded required keys to items in DropTestCommiter. 42/5742/1
Tony Tkacik [Tue, 25 Mar 2014 02:02:32 +0000 (03:02 +0100)]
Added required keys to items in DropTestCommiter.

Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoAdjust permissions: datafiles should not be executable 40/5740/1
Robert Varga [Tue, 28 Jan 2014 00:19:22 +0000 (01:19 +0100)]
Adjust permissions: datafiles should not be executable

Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
10 years agoFix a typo 39/5739/1
Robert Varga [Sat, 15 Feb 2014 06:28:00 +0000 (07:28 +0100)]
Fix a typo

Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
10 years agoBug 572 - Removing the duplicate translate method call. Tested on the mininet with... 34/5734/1
Lakshman Mukkamalla [Mon, 24 Mar 2014 19:54:42 +0000 (12:54 -0700)]
Bug 572 - Removing the duplicate translate method call. Tested on the mininet with linear,2 switch.

Change-Id: I8386b31e68742c844495da96463330fee61cd5b1
Signed-off-by: lmukkama@cisco.com
10 years agoRefactor and fix another reference bug in PortConvertor 12/5712/1
Moiz Raja [Fri, 21 Mar 2014 23:38:58 +0000 (16:38 -0700)]
Refactor and fix another reference bug in PortConvertor

Another place where an out-parameter was used has been fixed. Also refactored some code to make it a little cleaner.

Change-Id: I3ef970cc09007e84d43ff8f5bbce5cde241ab525
Signed-off-by: Moiz Raja <moraja@cisco.com>
10 years agoPass the appropriate PortModInput to portMod 06/5706/3
Moiz Raja [Fri, 21 Mar 2014 07:15:06 +0000 (00:15 -0700)]
Pass the appropriate PortModInput to portMod

In ModelDrivenSwitchImpl we were building an input but the built input was not passed to portMod. This had issues like missing Xid on the PortModInput
which caused NPE's downstream in the open flow java code

Also we were not correctly population ConfigV10, MaskV10 and FeaturesV10 on the PortModInput which caused NPE in the open flow java code when using
open flow 10

This commit fixes both of those problems. After this updatePort actually works.

Change-Id: Ie2548a36b2ba06f1d1ce0ccf833627bc7cbaf785
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoFix bug in PortConvertor#maskPortConfigFields 05/5705/2
Moiz Raja [Fri, 21 Mar 2014 00:22:53 +0000 (17:22 -0700)]
Fix bug in PortConvertor#maskPortConfigFields

This method was trying to set a passed reference to a different value and expecting to see it set in the caller
This won't work in java because java passes object references also as a value

See http://www.javaworld.com/article/2077424/learn-java/does-java-pass-by-reference-or-pass-by-value.html

Change-Id: I809f0887fb435b5ae2dd2b91304b8c20fa2adb17
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoRegister for SalPortService 04/5704/2
Moiz Raja [Fri, 21 Mar 2014 00:21:53 +0000 (17:21 -0700)]
Register for SalPortService

This is required so that someone can use the SalPortService as a consumer
- rebased onto merged change

Change-Id: I14069f04420285a783c16926543cf30ec85308b8
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix of BUG 512 61/5661/1
Michal Rehak [Tue, 18 Mar 2014 14:45:05 +0000 (15:45 +0100)]
fix of BUG 512

- FlowEventListener copied implementation has been pulled out, defined in one place for all tests
- transactionUri NPE fix

Change-Id: Iab7223050e7012c4c29f310922008fc54b14b14e
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix of BUG 480 50/5650/1
Michal Rehak [Fri, 14 Mar 2014 13:51:19 +0000 (14:51 +0100)]
fix of BUG 480

- lowered priority of flow-54 added programmatically via osgi cmd
- cleaning bound to OFLibrary upon bundle stop

Change-Id: Ibe24e730b032621a97f6dd36af8c29d4607a27ea
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix of BUG 434 33/5633/1
Michal Rehak [Thu, 13 Mar 2014 16:50:12 +0000 (17:50 +0100)]
fix of BUG 434

- added AutoCloseable interface to MDController, MessageCountCommandProvider, SalRegistrationManager, SessionManager
- added init/start and close/destroy logging
- added closing/destroying upon bundle stop

Change-Id: I5fe94bbcfa37225790b68d2e1ef01ffb1f6ab675
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofix of BUG 512 02/5602/2
Michal Rehak [Tue, 11 Mar 2014 15:34:00 +0000 (16:34 +0100)]
fix of BUG 512

- sanitized NPE if no data in error message present
- added error type support for OF-1.0 error messages
- removed commented code in ActionConvertor

Change-Id: I915ad8f2645d9e641b53a5a237906a3a44aade2b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agofixed the recconect issue "Timeout waiting for task" 01/5601/1
Prasanna Huddar [Tue, 11 Mar 2014 15:15:01 +0000 (20:45 +0530)]
fixed the recconect issue "Timeout waiting for task"
Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com>
10 years agofix of BUG 482 52/5552/3
Michal Rehak [Thu, 6 Mar 2014 11:54:55 +0000 (12:54 +0100)]
fix of BUG 482

packetIn translation is split into OF-1.0 and OF-1.3
- OF-1.0 does not provide table and match, ingress port is directly assigned to message
- OF-1.3 provides tableId, match, ingress port is extracted from match

Change-Id: I083359041de038eca971b5453c152cad3a8fb51b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoAdding FlowRef,MeterRef and GroupRef for the Error message 87/4587/18
P Govinda Rajulu [Fri, 7 Mar 2014 12:33:40 +0000 (18:03 +0530)]
Adding FlowRef,MeterRef and GroupRef for the Error message

Signed-off-by: P Govinda Rajulu <p.govinda.rajulu@ericsson.com>
Change-Id: Ief43d18b2e45dac2bf8f38c226407247d1e3fb4b

10 years agofix BUG 391 19/5519/2
Michal Rehak [Mon, 3 Mar 2014 19:11:46 +0000 (20:11 +0100)]
fix BUG 391

added version and address based mapping of adderess reading and injecting
(ovs and cpqd do require appropriate eth-type in match in order for instructions to work)

Change-Id: I3422095f508923663736c23756390588d519fe87
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoPass additional fields to applications from plugin 38/4338/2
Srikar Rajamani [Fri, 17 Jan 2014 07:15:17 +0000 (12:45 +0530)]
Pass additional fields to applications from plugin

blocked IT tests
rebase

Signed-off-by: Srikar Rajamani <srikar.rajamani@ericsson.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Change-Id: Ibffe135690b5340b9d7744b3e871c6c071aa44c5

10 years agoMinor refactoring due to change in the library model 13/5113/2
Michal Polkorab [Tue, 4 Feb 2014 01:33:44 +0000 (17:33 -0800)]
Minor refactoring due to change in the library model
CORRESPONDING LIBRARY CHANGE: https://git.opendaylight.org/gerrit/#/c/5112

Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Change-Id: Ic08bbc22cf93c574f3ca029619e1b3b9d217c69e

10 years agoAdded cookie into flows created during learning 62/5262/1
Michal Rehak [Tue, 11 Feb 2014 16:50:31 +0000 (17:50 +0100)]
Added cookie into flows created during learning

- cookie is unique per switch

Change-Id: I7aacc889a35c2bd4a785e96ba562d8fe3f6194ff
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoClear actions instruction does not support actions. 55/5255/1
Deepthi V V [Tue, 11 Feb 2014 12:31:09 +0000 (18:01 +0530)]
Clear actions instruction does not support actions.

Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>
10 years agoMerge "-refactored utility code to separate modules and classes -upgraded stress...
michal rehak [Tue, 11 Feb 2014 09:49:14 +0000 (09:49 +0000)]
Merge "-refactored utility code to separate modules and classes -upgraded stress test to include cleanup after test -added test for operation data store"

10 years agoPlugin changes:handling List<actions> to PacketOut 72/5072/5
Gaurav Bhagwani [Fri, 31 Jan 2014 16:31:15 +0000 (22:01 +0530)]
Plugin changes:handling List<actions> to PacketOut
-Done Plugin Changes to handle List<Action> added to PacketOut Controller Yang
-Added TestCase for configuring actions through PacketOut Message from Controller
- Dependent on Controller Code review : https://git.opendaylight.org/gerrit/#/c/5071/

Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Change-Id: Ie3d1d3ac432af464b9d0096cc732896ae3036dae

10 years agoPick the updated jars from the controller,Library 31/5031/8
Gaurav Bhagwani [Wed, 5 Feb 2014 06:47:09 +0000 (12:17 +0530)]
Pick the updated jars from the controller,Library

Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Change-Id: I36bfb5afa910ae7caa8eaefabb4285e6d3cb5d60

10 years agoAdding multipart learning switch 69/5069/6
Tony Tkacik [Tue, 4 Feb 2014 00:54:47 +0000 (01:54 +0100)]
Adding multipart learning switch

- improved logging
- wrapped simple implementation
- tidying up names
- fixed stop
- limited to IPv4 traffic
- fixed expire times (=0) for flow forwarding packets to controller
- Introduced InstanceIdentifier utility class.
- Separated utility functions to thematic classes.

Change-Id: I20bfb99797294767fbb0e290089cb2c701876ff4
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoinitial: learning switch example 05/5005/9
Tony Tkacik [Tue, 4 Feb 2014 02:30:21 +0000 (03:30 +0100)]
initial: learning switch example

example code for learning switch / hub
added as module into parent pom
added into distribution/base pom
handler + listener divided to atomic methods
initial flow written + sent to switch
bridge flows written to switch
storing covered mac-paths

Change-Id: I016055ed0920fb08c1923fa337c3e5b8880aba56
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
10 years agoTest XMLs for flow-instructions, set-field, apply-actions 95/5095/1
mcsl [Mon, 3 Feb 2014 07:39:12 +0000 (13:09 +0530)]
Test XMLs for flow-instructions, set-field, apply-actions

Signed-off-by: mcsl <mcsl@cisco.com>
10 years ago-refactored utility code to separate modules and classes 67/5067/1
Juraj Sebin [Fri, 31 Jan 2014 09:08:10 +0000 (10:08 +0100)]
-refactored utility code to separate modules and classes
-upgraded stress test to include cleanup after test
-added test for operation data store

Change-Id: Ifc7329cefb02a544025d2c547ad2806b6f875c0d
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoOF1.3 action unit testing XML's using REST 24/5024/1
Praveen Darshanam [Tue, 28 Jan 2014 20:01:48 +0000 (01:31 +0530)]
OF1.3 action unit testing XML's using REST
Signed-off-by: Praveen Darshanam <praveen_recker@sify.com>
10 years agoAdding actions testing XML files in test-scripts/xml 94/4994/1
Krishnan [Wed, 29 Jan 2014 10:46:01 +0000 (02:46 -0800)]
Adding actions testing XML files in test-scripts/xml
Signed-off-by: Krishnan <krishnan.k.iyer@gmail.com>
10 years agoREST Actions testing 30/4430/3
Krishnan Iyer [Tue, 28 Jan 2014 09:23:57 +0000 (14:53 +0530)]
REST Actions testing
Signed-off-by: Krishnan Iyer <krishnan.k.iyer@gmail.com>
Change-Id: I3b9cad70460a00b51801c246fffcd99ac415f811

10 years ago[maven-release-plugin] prepare for next development iteration
jenkins-openflowplugin [Tue, 28 Jan 2014 00:48:53 +0000 (00:48 +0000)]
[maven-release-plugin] prepare for next development iteration

10 years ago[maven-release-plugin] prepare release openflowplugin-parent-0.0.2 openflowplugin-parent-0.0.2
jenkins-openflowplugin [Tue, 28 Jan 2014 00:48:52 +0000 (00:48 +0000)]
[maven-release-plugin] prepare release openflowplugin-parent-0.0.2

10 years ago[maven-release-plugin] prepare for next development iteration
jenkins-openflowplugin [Tue, 28 Jan 2014 00:39:54 +0000 (00:39 +0000)]
[maven-release-plugin] prepare for next development iteration

10 years ago[maven-release-plugin] prepare release master-tagforprepareonly-openflowplugin-bulk... master-tagforprepareonly-openflowplugin-bulk-release-prepare-only-8
jenkins-openflowplugin [Tue, 28 Jan 2014 00:39:53 +0000 (00:39 +0000)]
[maven-release-plugin] prepare release master-tagforprepareonly-openflowplugin-bulk-release-prepare-only-8

10 years agoupdated to release versions 60/4960/1
Michal Rehak [Mon, 27 Jan 2014 21:53:56 +0000 (22:53 +0100)]
updated to release versions
 - yangtools-0.6.1
 - controller
 - openflowjava-0.4

Change-Id: Ia17f6c5e35781ba3ebd34009114a62be0de6c77b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoupdated yangtools to 0.6.1-SNAPSHOT 13/4913/1
Michal Rehak [Mon, 27 Jan 2014 17:51:19 +0000 (18:51 +0100)]
updated yangtools to 0.6.1-SNAPSHOT

Change-Id: I95a8ef5226e0c95eda7cf5d7f0a3c10505b99dbc
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoFix for bug 290/291 72/4872/1 openflowplugin-bulk-release-prepare-only-7 jenkins-openflowplugin-bulk-release-prepare-only-6 jenkins-openflowplugin-bulk-release-prepare-only-7
Anilkumar Vishnoi [Mon, 27 Jan 2014 12:50:44 +0000 (18:20 +0530)]
Fix for bug 290/291

Change-Id: I6cb31435031868757ac2dc8dce42abc9b8120f94
Signed-off-by: Anilkumar Vishnoi <avishnoi@in.ibm.com>
10 years agoTest scripts modified for Meter and Group 58/4858/1
etusgoy [Mon, 27 Jan 2014 11:48:37 +0000 (17:18 +0530)]
Test scripts modified for Meter and Group

Signed-off-by: etusgoy <goyaltushar7@gmail.com>
10 years agoTurned down logging in ErrorTranslator from ERROR to DEBUG 39/4739/2
Ed Warnicke [Sun, 26 Jan 2014 03:33:22 +0000 (21:33 -0600)]
Turned down logging in ErrorTranslator from ERROR to DEBUG

Change-Id: I296451951e41320def91234b67671211948f5908
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agofix for BUG 365 69/4769/1
Michal Rehak [Sat, 25 Jan 2014 18:50:57 +0000 (19:50 +0100)]
fix for BUG 365
 - by adding and removing all context of datastore were touched
 - now we use only the config context and by remove we do not clean flow itself

Change-Id: Id7131c5073cfe1a6f89d24afc02158f849f4318b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMinor fix in Ip address decoding from flow stats. 65/4765/2
Anilkumar Vishnoi [Sat, 25 Jan 2014 12:12:55 +0000 (17:42 +0530)]
Minor fix in Ip address decoding from flow stats.
If user specify 32 as a mask, as per specs switch ignores it. And when you fetch the flow stats switch, it returns
null as a mask value. I added a check for it and now I am explicitly adding 32 as a mask if ip mask value in flow
statistics is null"
Added code to send group/meter statistics request only to openflow 1.3+ switches.

Change-Id: I10b23f058f42d60338d51319c0f5545501e22838
Signed-off-by: Anilkumar Vishnoi <avishnoi@in.ibm.com>
10 years agoFix for Bug 269 36/4736/2
Gaurav Bhagwani [Fri, 24 Jan 2014 19:54:31 +0000 (01:24 +0530)]
Fix for Bug 269

Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
10 years agoMinor fix in instruction building -Explicitely setting instruction key 46/4746/1
Anilkumar Vishnoi [Fri, 24 Jan 2014 23:11:24 +0000 (04:41 +0530)]
Minor fix in instruction building -Explicitely setting instruction key

Change-Id: I9409b7c847655425743fe111a5572f25fef6bc98
Signed-off-by: Anilkumar Vishnoi <avishnoi@in.ibm.com>
10 years agofix for BUG 346, BUG 347 23/4723/4
Michal Rehak [Fri, 24 Jan 2014 13:16:45 +0000 (14:16 +0100)]
fix for BUG 346, BUG 347

- added more descriptive exception text
- fixed NPE for tableId for flows added by dropTest
- removed binary dump of payload hooked to errorMessage (appearing in log)

Change-Id: I49dc4aeb3b7b8444b2cc198c08e7ea393cd2febe
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoMapping OF1.0 Actions to OF1.3 SetField Action 97/4697/3
Gaurav Bhagwani [Fri, 24 Jan 2014 12:01:09 +0000 (17:31 +0530)]
Mapping OF1.0 Actions to OF1.3 SetField Action
- Fix for Bug - 268
- Actions: StripVlan, SetNwTos were not mapped to any oxm-field of setFieldAction of OF1.3
-Actions: SetTpSrc, SetTpDst : Not able to differentiate to tcp/udp ports in OF1.3, as 1.0 do not differentiate for the ports being tcp or udp
Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
10 years agoFix for bug #357- Set log levels on all log statements to appropriate level 93/4693/2
goyal [Fri, 24 Jan 2014 10:36:08 +0000 (16:06 +0530)]
Fix for bug #357- Set log levels on all log statements to appropriate level

Change-Id: I53390b29e42c66082c239da4cc80422aeaccb2f1
Signed-off-by: goyal <sheena.goyal@tcs.com>
10 years agoadded stress test script 21/4721/1
Juraj Sebin [Fri, 24 Jan 2014 15:35:22 +0000 (16:35 +0100)]
added stress test script

Change-Id: I951d776dece9757c2d52a42f166b9df4fd3587ae
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoMerge "updated version of switch restart test" jenkins-openflowplugin-bulk-release-prepare-only-5
michal rehak [Fri, 24 Jan 2014 08:31:06 +0000 (08:31 +0000)]
Merge "updated version of switch restart test"

10 years agoFixed minor issue in decoding instruction from flow statistics response 73/4673/1
Anilkumar Vishnoi [Fri, 24 Jan 2014 06:12:09 +0000 (11:42 +0530)]
Fixed minor issue in decoding instruction from flow statistics response

Change-Id: I6db047b8a04afcff90ba859c63420e9471502d05
Signed-off-by: Anilkumar Vishnoi <avishnoi@in.ibm.com>
10 years agoOpenflow plugin code changes due to match yang model change: https://git.opendaylight... 38/4638/2
Ed Warnicke [Thu, 23 Jan 2014 12:45:41 +0000 (18:15 +0530)]
Openflow plugin code changes due to match yang model change: https://git.opendaylight.org/gerrit/#/c/4635/1

Change-Id: I193be03b8aea075939bada818ba4983de2a5a365
Signed-off-by: Deepthi V V <deepthi.v.v@ericsson.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agostress test related improvement 28/4628/2 jenkins-openflowplugin-bulk-release-prepare-only-4
Michal Rehak [Thu, 23 Jan 2014 08:20:48 +0000 (09:20 +0100)]
stress test related improvement

- propagate close upon bundle stop
- enriched logging upon echo timeout disconnect
- increased echo timeout from 5 to 15 sec
- fix memory leak in OpenflowpluginTestCommandProvider.FlowEventListener

Change-Id: I13c9bd319438f883271bd3ddc71e5952f45a351f
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoupdated version of switch restart test 56/4656/1
Juraj Sebin [Thu, 23 Jan 2014 15:57:43 +0000 (16:57 +0100)]
updated version of switch restart test

Change-Id: Ieb957079d7f9a15f5847e026d2da5d270a393e90
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoadded new script for testing switch restart 54/4654/1
Juraj Sebin [Thu, 23 Jan 2014 12:18:08 +0000 (13:18 +0100)]
added new script for testing switch restart
added new test xml files

Change-Id: Iece37149cbf7561c486ea38cb0c22c94bf47b106
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoadded new validation for ipv6 addresses 53/4653/1
Juraj Sebin [Thu, 23 Jan 2014 15:17:19 +0000 (16:17 +0100)]
added new validation for ipv6 addresses
refactored validation for ipv6 addresses

Change-Id: I53dcc76821744fcc2fa958627b2aa888801acb8e
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoTests: fix ip mask 32/4632/3
Vaclav Demcak [Thu, 23 Jan 2014 10:40:37 +0000 (11:40 +0100)]
Tests: fix ip mask

Change-Id: I3be6d7d3b63f400ddda1804b956ee4657c344561
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
10 years agoadded dropAllPackets provider bypassing datastore 68/4568/2
Michal Rehak [Wed, 22 Jan 2014 09:15:38 +0000 (10:15 +0100)]
added dropAllPackets provider bypassing datastore

required for cbench load tests:
  time consuming operations (datastore + transaction) are bypassed
  and flow is added by calling flow service rpc (directly routed back to plugin)
  so flow created this way is not visible though rest

Change-Id: I40608e6321517494f8eef2dd8d2637bb503b010b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
10 years agoAdding testcase for Output Port 64/4564/2
Gaurav Bhagwani [Wed, 22 Jan 2014 10:51:14 +0000 (16:21 +0530)]
Adding testcase for Output Port
-f82 is the test-case for outputport, written for port=1
Signed-off-by: Gaurav Bhagwani <gaurav.bhagwani@ericsson.com>
10 years agoupdates in test scripts 04/4504/1
Juraj Sebin [Tue, 21 Jan 2014 14:28:19 +0000 (15:28 +0100)]
updates in test scripts
-tests scripts are running in sequence
-new validation method
-structure of xml is validated before test

Change-Id: I6931f6449370f65df9a081e3089f9f8d0c0e20e8
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
10 years agoFlowStats for a particular flow using RPC service 71/4471/2
etusgoy [Tue, 21 Jan 2014 06:05:35 +0000 (11:35 +0530)]
FlowStats for a particular flow using RPC service

Signed-off-by: etusgoy <goyaltushar7@gmail.com>
10 years agoGroup and Meter desc statistics testing 73/4473/2
etusgoy [Tue, 21 Jan 2014 07:25:48 +0000 (12:55 +0530)]
Group and Meter desc statistics testing

Signed-off-by: etusgoy <goyaltushar7@gmail.com>
Change-Id: I06e0fe1af27ba32e1a2bee2a5beab525b0fe73d2

10 years agoMerge "copyright header added"
Abhijit Kumbhare [Mon, 20 Jan 2014 22:27:57 +0000 (22:27 +0000)]
Merge "copyright header added"