netconf.git
10 years agoMerge "Correct encoding"
Tony Tkacik [Tue, 18 Feb 2014 10:58:25 +0000 (10:58 +0000)]
Merge "Correct encoding"

10 years agoMerge "Cleanup framing mechanisms"
Tony Tkacik [Tue, 18 Feb 2014 10:57:13 +0000 (10:57 +0000)]
Merge "Cleanup framing mechanisms"

10 years agoFix a few more warnings
Robert Varga [Tue, 18 Feb 2014 08:53:30 +0000 (09:53 +0100)]
Fix a few more warnings

- Remove unused string constants
- Add type arguments
- Removed unused field

Change-Id: I8fbbd238a805d9445eecc4d7c65176ce4ff36b6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUntangle the XML/Hello message decoders
Robert Varga [Sun, 16 Feb 2014 05:46:06 +0000 (06:46 +0100)]
Untangle the XML/Hello message decoders

The tie between these classes was completely unnecessary -- we had this
complicated contract just for the sake of reusing couple of lines of
code. Untangle and optimize.

Change-Id: I6fd29ba0ff5d87a5fb2362e87e4fb1361544429f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDo not instantiate multiple DocumentBuilderFactories
Robert Varga [Sun, 16 Feb 2014 05:44:49 +0000 (06:44 +0100)]
Do not instantiate multiple DocumentBuilderFactories

We're instantiating builders themsenves, so we can safely reuse a single
factory. No sense in initiating it more than once.

Change-Id: I70dfa2d5cc51a09722bb7ad41ce4d61f8691ac3d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoSplit message aggregators
Robert Varga [Sun, 16 Feb 2014 04:29:51 +0000 (05:29 +0100)]
Split message aggregators

This splits the EOM aggregator and the chunked encoding aggregator. The
chunked encoding can be much more efficient and hardened as it allows
for proper stream processing.

We do not go the entire way here, just tighten the chunk header parsing
by keeping an explicit state machine. We still need to gather the entire
message before shifting it, as our downstream expects to see the message
in its entirety.

Change-Id: I60947b6d018b73581a56adda5212d3482dda61ea
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCorrect encoding
Robert Varga [Sun, 16 Feb 2014 03:31:16 +0000 (04:31 +0100)]
Correct encoding

NETCONF chunked encoding is transferred in US_ASCII, not UTF-8.

Change-Id: I33d45b0d2806c91aaf5c22fcaf3731fdad6cf7f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCleanup framing mechanisms
Robert Varga [Sat, 15 Feb 2014 22:21:51 +0000 (23:21 +0100)]
Cleanup framing mechanisms

This gets rid of pre-instantiated NetconfMessageHeader in favor of
creating a static constructor method.

Furthermore allow our output chunking to be variable and bump the
default from 1K to 8K. The upper limit on chunk size is 16M.

Change-Id: I0ab4405fc7d750cca5875049f03b053aa80037ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge changes I393151af,I0a302cde
Tony Tkacik [Mon, 17 Feb 2014 16:30:03 +0000 (16:30 +0000)]
Merge changes I393151af,I0a302cde

* changes:
  Fix unused field warnings
  Fix warnings about overriden versions

10 years agoMerge "Fix namespaces for netconf monitoring extensions."
Tony Tkacik [Mon, 17 Feb 2014 16:19:09 +0000 (16:19 +0000)]
Merge "Fix namespaces for netconf monitoring extensions."

10 years agoFix unused field warnings
Robert Varga [Sun, 16 Feb 2014 11:22:03 +0000 (12:22 +0100)]
Fix unused field warnings

Removes affected fields, add @Override annotations and make constant
fields final.

Change-Id: I393151af1459e31eeded0786cf32223068635172
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix warnings about overriden versions
Robert Varga [Sun, 16 Feb 2014 11:03:08 +0000 (12:03 +0100)]
Fix warnings about overriden versions

With proper parent structure, version overrides should not be present.

Change-Id: I0a302cde1c619af76f9290f7e5ca5080ff4fe251
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix namespaces for netconf monitoring extensions.
Maros Marsalek [Tue, 11 Feb 2014 10:13:02 +0000 (11:13 +0100)]
Fix namespaces for netconf monitoring extensions.

Change-Id: Ib191dbcb121ead95db65263b4b478b8eac64c004
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoCleanup warnings
Robert Varga [Sun, 16 Feb 2014 10:22:45 +0000 (11:22 +0100)]
Cleanup warnings

Change-Id: I26d45b3f3856ddd893b54089521b5366deb34db3
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Do not access static methods through object instances"
Tony Tkacik [Mon, 17 Feb 2014 09:56:36 +0000 (09:56 +0000)]
Merge "Do not access static methods through object instances"

10 years agoDo not access static methods through object instances
Robert Varga [Sun, 16 Feb 2014 09:48:01 +0000 (10:48 +0100)]
Do not access static methods through object instances

Stops eclipse from complaining.

Change-Id: I153b651068cceb8263f2f4a8ea65b8de45a1ba50
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoremoved obsolete config yang and RuntimeGeneratedMappingService
Martin Bobak [Thu, 13 Feb 2014 14:48:42 +0000 (15:48 +0100)]
removed obsolete config yang and RuntimeGeneratedMappingService

Change-Id: I86c721ecce6132bd545778fe9a7380684c53c8f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
10 years agoMerge "Refactor Additional header for netconf hello message."
Ed Warnicke [Thu, 13 Feb 2014 11:44:11 +0000 (11:44 +0000)]
Merge "Refactor Additional header for netconf hello message."

10 years agoMerge "sal-restconf-broker initial implementation needs https://git.opendaylight...
Ed Warnicke [Thu, 13 Feb 2014 11:31:25 +0000 (11:31 +0000)]
Merge "sal-restconf-broker initial implementation  needs https://git.opendaylight.org/gerrit/#/c/5259/  and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for  successful build"

10 years agoRefactor Additional header for netconf hello message.
Maros Marsalek [Tue, 11 Feb 2014 17:19:42 +0000 (18:19 +0100)]
Refactor Additional header for netconf hello message.

Allow additional header only for hello messages.
Introduce customized (en|decoders) for hello message to parse/serialize additional header.
These handlers are replaced after successful negotiation.

Change-Id: I54c441bc166e7141f503888f0eb1934882971045
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoMerge "Rework NETCONF interfaces"
Ed Warnicke [Wed, 12 Feb 2014 15:32:33 +0000 (15:32 +0000)]
Merge "Rework NETCONF interfaces"

10 years agoMerge "Fix thread safety issues in netconf client"
Ed Warnicke [Wed, 12 Feb 2014 15:32:00 +0000 (15:32 +0000)]
Merge "Fix thread safety issues in netconf client"

10 years agoMerge "Cache sessionID to increase readability"
Ed Warnicke [Wed, 12 Feb 2014 15:31:42 +0000 (15:31 +0000)]
Merge "Cache sessionID to increase readability"

10 years agoMerge "Remove unused DefaultNetconfOperation marker"
Ed Warnicke [Wed, 12 Feb 2014 15:29:27 +0000 (15:29 +0000)]
Merge "Remove unused DefaultNetconfOperation marker"

10 years agosal-restconf-broker initial implementation
Martin Bobak [Mon, 20 Jan 2014 13:27:44 +0000 (14:27 +0100)]
sal-restconf-broker initial implementation
 needs https://git.opendaylight.org/gerrit/#/c/5259/
 and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for
 successful build

Change-Id: Ic665eaf25c908ed7633cfeee7629354d647ef09f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
10 years agoRework NETCONF interfaces
Robert Varga [Sun, 9 Feb 2014 22:41:45 +0000 (23:41 +0100)]
Rework NETCONF interfaces

NetconfSession and NetconfClientSessionListener are supposed to be
interfaces, not classes. Convert them to such and introduce utility
classes which retain their current functionality. Remove an unused
method and fix type safety warnings while we're at it.

Change-Id: Id7d78c831e3c3d46abb4379efe4a5ca353cd55ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix thread safety issues in netconf client
Robert Varga [Sun, 9 Feb 2014 19:32:33 +0000 (20:32 +0100)]
Fix thread safety issues in netconf client

This patch introduces a proper asynchronous interface and reworks
internals such that thread safety is maintained.

Change-Id: I6eb1c56518b0b3cc6f64c1df8bc0c857298f79b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoCache sessionID to increase readability
Robert Varga [Sun, 9 Feb 2014 17:04:16 +0000 (18:04 +0100)]
Cache sessionID to increase readability

Change-Id: Ia4440f8a30cdc9b987139879f471be67ffe1dc3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove unused DefaultNetconfOperation marker
Robert Varga [Sun, 9 Feb 2014 15:48:01 +0000 (16:48 +0100)]
Remove unused DefaultNetconfOperation marker

DefaultCloseSession and DefaultGetSchema do not need the netconf
session. so drop their use of DefaultNetconfOperation.

Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix yangtools API incompatibility
Robert Varga [Tue, 11 Feb 2014 14:42:42 +0000 (15:42 +0100)]
Fix yangtools API incompatibility

Change-Id: Ia6883492a49765f1ffcd38128fcd6084636bc470
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Fix a warning"
Ed Warnicke [Tue, 11 Feb 2014 01:51:11 +0000 (01:51 +0000)]
Merge "Fix a warning"

10 years agoFix a warning
Robert Varga [Sun, 9 Feb 2014 15:16:06 +0000 (16:16 +0100)]
Fix a warning

Change-Id: I8605ada63c471d9446ebf7fe31fb518138422cd4
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRewrite POSSIBLE_ENDS and POSSIBLE_STARTS
Robert Varga [Sat, 8 Feb 2014 02:45:52 +0000 (03:45 +0100)]
Rewrite POSSIBLE_ENDS and POSSIBLE_STARTS

These two are really simple byte arrays, initialized them as such
withouth going through strings/UTF8.

Change-Id: Id80151d9ff57df4b7a5595f76f30a379d89af3dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Some methods should be final"
Ed Warnicke [Tue, 11 Feb 2014 00:08:29 +0000 (00:08 +0000)]
Merge "Some methods should be final"

10 years agoMerge "Expose ChannelFuture from sendMessage()"
Ed Warnicke [Mon, 10 Feb 2014 23:50:32 +0000 (23:50 +0000)]
Merge "Expose ChannelFuture from sendMessage()"

10 years agoMerge "Getter methods should be final"
Ed Warnicke [Mon, 10 Feb 2014 23:49:36 +0000 (23:49 +0000)]
Merge "Getter methods should be final"

10 years agoMerge "Fix a warning and make field final"
Ed Warnicke [Mon, 10 Feb 2014 23:44:58 +0000 (23:44 +0000)]
Merge "Fix a warning and make field final"

10 years agoMerge "Remove use of deprecated Exceptions"
Ed Warnicke [Mon, 10 Feb 2014 23:44:08 +0000 (23:44 +0000)]
Merge "Remove use of deprecated Exceptions"

10 years agoSome methods should be final
Robert Varga [Sat, 8 Feb 2014 04:18:06 +0000 (05:18 +0100)]
Some methods should be final

Change-Id: I8969a8d099222f8360c07e621b9157c4bb5fb8f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Fix a few eclipse-reported warnings"
Ed Warnicke [Mon, 10 Feb 2014 23:36:04 +0000 (23:36 +0000)]
Merge "Fix a few eclipse-reported warnings"

10 years agoExpose ChannelFuture from sendMessage()
Robert Varga [Sat, 8 Feb 2014 04:17:00 +0000 (05:17 +0100)]
Expose ChannelFuture from sendMessage()

Change-Id: If76f0c3ab7ce290d50ed7177c08af78cb9f7a354
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGetter methods should be final
Robert Varga [Fri, 7 Feb 2014 23:40:38 +0000 (00:40 +0100)]
Getter methods should be final

Change-Id: I24eafd9b1319e9296de5680220802820944fe333
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Get rid of NetconfMessageFactory"
Ed Warnicke [Mon, 10 Feb 2014 19:44:20 +0000 (19:44 +0000)]
Merge "Get rid of NetconfMessageFactory"

10 years agoMerge "Get rid of DeserializerException"
Ed Warnicke [Mon, 10 Feb 2014 19:44:01 +0000 (19:44 +0000)]
Merge "Get rid of DeserializerException"

10 years agoMerge "Get rid of using ProtocolHandlerFactory, part 2"
Ed Warnicke [Mon, 10 Feb 2014 19:43:32 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 2"

10 years agoMerge "Get rid of using ProtocolHandlerFactory, part 1"
Ed Warnicke [Mon, 10 Feb 2014 19:43:22 +0000 (19:43 +0000)]
Merge "Get rid of using ProtocolHandlerFactory, part 1"

10 years agoFix a warning and make field final
Robert Varga [Fri, 7 Feb 2014 22:20:04 +0000 (23:20 +0100)]
Fix a warning and make field final

Drive-by fix
- additionalHeader should be final,
- the class is not serializable, no uuid is needed

Change-Id: I484b07e64942179d153e7c42ca32d753fb2a5b23
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove use of deprecated Exceptions
Robert Varga [Fri, 7 Feb 2014 22:19:04 +0000 (23:19 +0100)]
Remove use of deprecated Exceptions

DocumentedException and DeserializerException are deprecated and were
only used by deprecated interfaces which we no longer use. Stop using
them.

Change-Id: I899beb6d08be2c4a0b17ecbe6e1ca2be334e12a9
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of NetconfMessageFactory
Robert Varga [Fri, 7 Feb 2014 22:15:56 +0000 (23:15 +0100)]
Get rid of NetconfMessageFactory

This removes the use of deprecated ProtocolMessageFactory and
ProtocolHandlerFactory. Just instantiate appropriate Netty handlers
instead.

Change-Id: I98b6424af0256483be21c92dfdbe4c0ddbac7a9d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of DeserializerException
Robert Varga [Fri, 7 Feb 2014 21:19:43 +0000 (22:19 +0100)]
Get rid of DeserializerException

We can throw anything, so use NetconfDeserializerException instead.

Change-Id: Ibf2b7f2778217b19e7b4aaf22571f19fdf3f610f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of using ProtocolHandlerFactory, part 2
Robert Varga [Fri, 7 Feb 2014 21:08:39 +0000 (22:08 +0100)]
Get rid of using ProtocolHandlerFactory, part 2

Now that we do not rely on passing it around, we can safely keep
NetconfHandlerFactory wired directly to the
ProtocolMessageEncoder/Decoder.

Change-Id: I47a9b76f8d9bbb98304e06960e5a85d2730994f7
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of using ProtocolHandlerFactory, part 1
Robert Varga [Fri, 7 Feb 2014 20:57:07 +0000 (21:57 +0100)]
Get rid of using ProtocolHandlerFactory, part 1

This gets rid of completely dead code in NetconfSshClientDispatcher. It
already talks directly to the initializer.

Change-Id: Ieaac37a3335e87032730cfa65e94bb59f26dd3c1
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Cleanup imports/whitespace in MD-SAL"
Ed Warnicke [Mon, 10 Feb 2014 12:20:21 +0000 (12:20 +0000)]
Merge "Cleanup imports/whitespace in MD-SAL"

10 years agoCleanup imports/whitespace in MD-SAL
Robert Varga [Fri, 7 Feb 2014 20:01:21 +0000 (21:01 +0100)]
Cleanup imports/whitespace in MD-SAL

Change-Id: I0f18ffe229ed213308a0cd5cf343fd64ff79a17c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix a few eclipse-reported warnings
Robert Varga [Fri, 7 Feb 2014 23:01:27 +0000 (00:01 +0100)]
Fix a few eclipse-reported warnings

- unused suppresswarnings
- missing serialVersionUuid
- missing generic arguments

Change-Id: Ie741e88bfe161a9e4613b4076892cbcabdd0375c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Improve netconf negotiator messages"
Ed Warnicke [Fri, 7 Feb 2014 06:14:16 +0000 (06:14 +0000)]
Merge "Improve netconf negotiator messages"

10 years agoMerge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout...
Ed Warnicke [Fri, 7 Feb 2014 06:13:46 +0000 (06:13 +0000)]
Merge "Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector."

10 years agoMerge "Fix of bug in Notificator class"
Ed Warnicke [Fri, 7 Feb 2014 06:11:23 +0000 (06:11 +0000)]
Merge "Fix of bug in Notificator class"

10 years agoImprove netconf negotiator messages
Robert Varga [Wed, 5 Feb 2014 07:36:23 +0000 (08:36 +0100)]
Improve netconf negotiator messages

Change-Id: I8b36f2fa6173055e5fc34783873a55cdf240589d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix of bug in Notificator class
Jozef Gloncak [Mon, 3 Feb 2014 14:58:26 +0000 (15:58 +0100)]
Fix of bug in Notificator class

Deleting of listner from listenersByStreamName map was corrected
try, finally block was added for locking, unlocking of access to map

Change-Id: I60ecb9c247af18436f348d4f4827c7f75fdfaeaa
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
10 years agoImprove logging in NetconfClient, logging-bridge. Increase connection timeout in...
Tomas Olvecky [Wed, 5 Feb 2014 10:55:39 +0000 (11:55 +0100)]
Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector.

Stop polluting log file with unnecessary 'Exception' messages by logging-bridge, print stack trace with exceptions using slf4j.
Increase connection timeout in sal-netconf-client from 5s to 20s.
Include label in NetconfClient exceptions.

Change-Id: If6819029fb79ea6ebead6b6745adf2c439d107da
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoMerge "Added resource /streams/stream/<streamName>"
Ed Warnicke [Wed, 5 Feb 2014 06:37:28 +0000 (06:37 +0000)]
Merge "Added resource /streams/stream/<streamName>"

10 years agoMerge "Added support for /modules, /modules/module, /operations resources"
Ed Warnicke [Wed, 5 Feb 2014 06:36:47 +0000 (06:36 +0000)]
Merge "Added support for /modules, /modules/module, /operations resources"

10 years agoAdded resource /streams/stream/<streamName>
Martin Sunal [Sun, 2 Feb 2014 23:26:58 +0000 (00:26 +0100)]
Added resource /streams/stream/<streamName>

- added netty web socket server - port 8181

Subscriber can be registered for notifications in this flow:
1. Subscriber invokes RPC create-data-change-event-subscription with input element regarding to module sal-remote revision "2014-01-14"
2. Subscriber gets sream name as a response from server
3. Subscriber calls GET operation on /streams/stream/<streamName>
4. Subscriber gets response with status code 200 OK and header field Location contains URI of web socket server
5. Subscriber creates web socket http connection to obtained URI in step 4.
6. Subscriber can be unregistered from receiving notifications by sending CloseWebSocketFrame with reasonText containing stream name

Change-Id: I92925f5a50b2ceadf2cc8f0eaee2c99dd6a63d8d
Signed-off-by: Martin Sunal <msunal@cisco.com>
10 years agoAdded support for /modules, /modules/module, /operations resources
Jozef Gloncak [Mon, 3 Feb 2014 12:56:13 +0000 (13:56 +0100)]
Added support for /modules, /modules/module, /operations resources

support for:
/restconf/modules
/restconf/modules/pathToMountPoint/yang-ext:mount
/restconf/modules/module/moduleName/revision
/restconf/modules/module/pathToMountPoint/yang-ext:mount/moduleName/revision
/restconf/operations
/restconf/operations/pathToMountPoint/yang-ext:mount

revision must be in format "yyyy-MM-dd"

test for URIs:
- /modules
- /modules/module/<module_name>/<module_revision>
- /operations
- /modules/......./yang-ext:mount
- /modules/module/........../yang-ext:mount/<module_name>/<module_revision>
- /operations/........../yang-ext:mount

Change-Id: I7169a25024598dd3b49d7960d1ef90bc40c5d1d5
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
10 years agoMerge "Removed unused code from md-sal."
Ed Warnicke [Mon, 3 Feb 2014 22:49:16 +0000 (22:49 +0000)]
Merge "Removed unused code from md-sal."

10 years agoMerge changes I805ec065,Idc9995b1
Ed Warnicke [Sat, 1 Feb 2014 16:09:03 +0000 (16:09 +0000)]
Merge changes I805ec065,Idc9995b1

* changes:
  Change unprotected netconf address from 0.0.0.0 to 127.0.0.1 .
  Refactor config-persister: clean up exception handling and netconf client.

10 years agoMerge changes Iae4ee2f2,I148c22c4,I1dab84ae
Ed Warnicke [Sat, 1 Feb 2014 16:07:41 +0000 (16:07 +0000)]
Merge changes Iae4ee2f2,I148c22c4,I1dab84ae

* changes:
  Additional test for instance-identifier
  BUG 388: corrected media type in /operations resource
  BUG 312: Removed legacy RESTCONF draft 01 syntax

10 years agoMerge "minor test fix"
Ed Warnicke [Sat, 1 Feb 2014 16:00:23 +0000 (16:00 +0000)]
Merge "minor test fix"

10 years agoMerge "Add configurable connection timeout to netconf client."
Ed Warnicke [Sat, 1 Feb 2014 15:59:14 +0000 (15:59 +0000)]
Merge "Add configurable connection timeout to netconf client."

10 years agoAdditional test for instance-identifier
Jozef Gloncak [Mon, 27 Jan 2014 14:19:35 +0000 (15:19 +0100)]
Additional test for instance-identifier

- test for instance identifier
- correction of ignored test (adding revisions to wrong tests)
- instance identifier with leaflist predicate:
-- serialize codec
-- XML output
-- JSON output

Change-Id: Iae4ee2f2ff3c1b3445958f1d69673df9f56b0e2a
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
10 years agoBUG 388: corrected media type in /operations resource
Martin Sunal [Thu, 30 Jan 2014 15:50:05 +0000 (16:50 +0100)]
BUG 388: corrected media type in /operations resource

There were added these media types for /operations resource:
application/yang.operation+json
application/yang.operation+xml
Corrected handling of requests which have empty body and Content-Type has some value or is missing

Change-Id: I148c22c4c6c28d0d13f2b717fe629b42d5c73f70
Signed-off-by: Martin Sunal <msunal@cisco.com>
10 years agoChange unprotected netconf address from 0.0.0.0 to 127.0.0.1 .
Tomas Olvecky [Fri, 31 Jan 2014 14:13:40 +0000 (15:13 +0100)]
Change unprotected netconf address from 0.0.0.0 to 127.0.0.1 .

Plaintext netconf server was bound to any local interface. This is a security risk
because there is no authentication. The ssh server should be used as public endpoint instead.

Change-Id: I805ec065548e017dd2244d37e3275d379761e490
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoRefactor config-persister: clean up exception handling and netconf client.
Tomas Olvecky [Fri, 31 Jan 2014 13:51:08 +0000 (14:51 +0100)]
Refactor config-persister: clean up exception handling and netconf client.

Split ConfigPersisterNotificationHandler into registrator and listener, remove unnecessary
reference to NetconfClient.
Refactor ConfigPusher: each method now returns computational results instead of void. Avoid
unnecessary NetconfClient reference leak - close it after every use. Rename generic 'timeout'
to 'maxWaitForCapabilitiesMillis'. Avoid throwing and catching SAXException and IOException
as there is no recovery from them; keep only ConflictingVersionException.
ConfigPersisterActivator now actually uses the configurable timeout, the property is renamed
from 'pushTimeout' to 'maxWaitForCapabilitiesMillis'.

Change-Id: Idc9995b11dd2f19a90598c88eb7337d39d63fc27
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agominor test fix
Martin Bobak [Fri, 31 Jan 2014 09:26:36 +0000 (10:26 +0100)]
minor test fix

Change-Id: I3dce2b98d5d7452a9363150b91827eb3dcc03e60
Signed-off-by: Martin Bobak <mbobak@cisco.com>
10 years agoRemoved unused code from md-sal.
Martin Vitez [Thu, 30 Jan 2014 14:15:45 +0000 (15:15 +0100)]
Removed unused code from md-sal.

Change-Id: Ia64a118ec7c75d0abf5800f7eee98ae708b8e50a
Signed-off-by: Martin Vitez <mvitez@cisco.com>
10 years agoAdd configurable connection timeout to netconf client.
Tomas Olvecky [Thu, 23 Jan 2014 16:03:17 +0000 (17:03 +0100)]
Add configurable connection timeout to netconf client.

Make connection timeout configurable. Previous behavior was having hardcoded connection timeout set to 1 minute.
Make NetconfConnectorModule more configurable, allow (and this is new default) to retry on connection failures forever.

Change-Id: Ia9280cff1b751a4e7318e1e0331175c960823dad
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoBUG 312: Removed legacy RESTCONF draft 01 syntax
Martin Sunal [Thu, 30 Jan 2014 14:26:54 +0000 (15:26 +0100)]
BUG 312: Removed legacy RESTCONF draft 01 syntax

Change-Id: I1dab84ae70ef39964ead1b14efd58ae2e3eee087
Signed-off-by: Martin Sunal <msunal@cisco.com>
10 years agoMerge "Add javadoc generation for yang modules in netconf subsystem"
Ed Warnicke [Thu, 30 Jan 2014 11:02:43 +0000 (11:02 +0000)]
Merge "Add javadoc generation for yang modules in netconf subsystem"

10 years agoMerge "BUG 340: Resolved instance-identifier translation in JSON"
Ed Warnicke [Thu, 30 Jan 2014 10:28:04 +0000 (10:28 +0000)]
Merge "BUG 340: Resolved instance-identifier translation in JSON"

10 years agoMerge "BUG 392: Resolved translation to JSON behind mount point"
Ed Warnicke [Thu, 30 Jan 2014 10:23:52 +0000 (10:23 +0000)]
Merge "BUG 392: Resolved translation to JSON behind mount point"

10 years agoBUG 340: Resolved instance-identifier translation in JSON
Martin Sunal [Mon, 27 Jan 2014 15:15:30 +0000 (16:15 +0100)]
BUG 340: Resolved instance-identifier translation in JSON

Change-Id: Ia8853c00798674251b39941a675e9c359aa68a00
Signed-off-by: Martin Sunal <msunal@cisco.com>
10 years agoBUG 392: Resolved translation to JSON behind mount point
Martin Sunal [Mon, 27 Jan 2014 14:49:44 +0000 (15:49 +0100)]
BUG 392: Resolved translation to JSON behind mount point

Change-Id: Icee18d06679dcfa935b4c832b0b6673936d60a10
Signed-off-by: Martin Sunal <msunal@cisco.com>
10 years agoAdd javadoc generation for yang modules in netconf subsystem
Maros Marsalek [Wed, 29 Jan 2014 11:48:39 +0000 (12:48 +0100)]
Add javadoc generation for yang modules in netconf subsystem

Added org.opendaylight.yangtools.yang.unified.doc.generator.maven.DocumentationGeneratorImpl generator
to yang-maven-plugin configuration in order to generate informational html page about yang modules.

Affected yang modules: ietf-netconf-monitoring, ietf-netconf-monitoring-extension.

Change-Id: I83d3089256a21515cc4fb3320a81956af590e1ce
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years ago[maven-release-plugin] prepare for next development iteration
jenkins-controller [Mon, 27 Jan 2014 20:51:03 +0000 (20:51 +0000)]
[maven-release-plugin] prepare for next development iteration

10 years ago[maven-release-plugin] prepare release master-tagforprepareonly-controller-bulk-relea...
jenkins-controller [Mon, 27 Jan 2014 20:50:53 +0000 (20:50 +0000)]
[maven-release-plugin] prepare release master-tagforprepareonly-controller-bulk-release-2-1

10 years agoMerge "Prevent ConfigPusher from killing its thread"
Ed Warnicke [Mon, 27 Jan 2014 14:43:33 +0000 (14:43 +0000)]
Merge "Prevent ConfigPusher from killing its thread"

10 years agoMerge changes I8c23739a,Ia0e70828
Ed Warnicke [Mon, 27 Jan 2014 14:11:06 +0000 (14:11 +0000)]
Merge changes I8c23739a,Ia0e70828

* changes:
  Bulk-add copyright headers to java files
  Bulk-add copyright headers to .xtend files

10 years agoPrevent ConfigPusher from killing its thread
Robert Varga [Mon, 27 Jan 2014 13:51:10 +0000 (14:51 +0100)]
Prevent ConfigPusher from killing its thread

The original code promoted pretty much every error to an unhandled
RuntimeException. Use the exceptions already in place to handle erros
occuring. Also handle IO error as a retriable operation.

Change-Id: I666d66e89993f0f9d18afb6ec680e64a50cefec1
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix for dry run
Ed Warnicke [Mon, 27 Jan 2014 03:18:34 +0000 (03:18 +0000)]
Fix for dry run

Removed unneeded variables from commons/opendaylight/pom.xml
Expanded dependencyManagement in commons/opendaylight/pom.xml
Added explicte dependency on sanitytest to distribution pom.xml
Fixed dependencies in two integration tests
Removed module archetypes from pom.xml
Moved third-party/ganymed build from netconf to root pom.xml

Change-Id: Id4d1586bd86f375fa2bd4b64faf28682d402e4e9
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoBulk-add copyright headers to java files
Robert Varga [Sun, 26 Jan 2014 23:00:09 +0000 (00:00 +0100)]
Bulk-add copyright headers to java files

Change-Id: I8c23739a21f3f6cecb138f62a54efbabf03b9c55
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBulk-add copyright headers to .xtend files
Robert Varga [Sun, 26 Jan 2014 23:00:50 +0000 (00:00 +0100)]
Bulk-add copyright headers to .xtend files

Change-Id: Ia0e70828399607e3e5b4193e01200420f85c0a8a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Improve logging to indicate when configuration has been pushed"
Ed Warnicke [Sun, 26 Jan 2014 22:46:43 +0000 (22:46 +0000)]
Merge "Improve logging to indicate when configuration has been pushed"

10 years agoMerge "Instance identifier support"
Ed Warnicke [Sun, 26 Jan 2014 20:56:12 +0000 (20:56 +0000)]
Merge "Instance identifier support"

10 years agoImprove logging to indicate when configuration has been pushed
Robert Varga [Sun, 26 Jan 2014 20:42:27 +0000 (21:42 +0100)]
Improve logging to indicate when configuration has been pushed

Change-Id: I1abe5cfc6704300fba12785edda94a2f24aad562
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Improve client logging"
Ed Warnicke [Sun, 26 Jan 2014 18:41:43 +0000 (18:41 +0000)]
Merge "Improve client logging"

10 years agoInstance identifier support
Martin Sunal [Sat, 25 Jan 2014 14:03:11 +0000 (15:03 +0100)]
Instance identifier support

- codec for instance identifier (deserializer, serializer) was added
- instance identifier from XML and JSON files to simple node
- instance identifier from simple node to XML and JSON
- corrected augments with the same names

Change-Id: Iff49aedd209e61fb15e4a7bee61a2c9611c25355
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
10 years agoMerge "Add support for identity-ref config attributes to config/netconf subsystem"
Ed Warnicke [Sun, 26 Jan 2014 03:41:08 +0000 (03:41 +0000)]
Merge "Add support for identity-ref config attributes to config/netconf subsystem"

10 years agoAdd support for identity-ref config attributes to config/netconf subsystem
Robert Varga [Fri, 24 Jan 2014 10:53:13 +0000 (11:53 +0100)]
Add support for identity-ref config attributes to config/netconf subsystem

Change-Id: I79d5147f1d6bb1acd6b5a374bb76f48b6a3aaf55
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoExtract dom-serializer-api|impl from binding-broker-impl
Tony Tkacik [Sat, 25 Jan 2014 17:29:57 +0000 (18:29 +0100)]
Extract dom-serializer-api|impl from binding-broker-impl

Change-Id: I1b2844bfac5062fd15c1f011c3104b3dddb33b51
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>