lispflowmapping.git
6 years agoFully remove Maven Sites 47/60247/1
Lorand Jakab [Wed, 12 Jul 2017 12:04:59 +0000 (15:04 +0300)]
Fully remove Maven Sites

Change-Id: I8c6ba1fe18e0fff43d0aa47b19c9f11df05ead20
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoRemove outdated src/site documentation 42/60242/1
Lorand Jakab [Wed, 12 Jul 2017 10:53:18 +0000 (13:53 +0300)]
Remove outdated src/site documentation

https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001218.html

Content moved to the wiki:
https://wiki.opendaylight.org/view/Southbound_Performance_Cache

Change-Id: I9867417f6f0a9f30cb3166371f4cfe4c5f3cbe14
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Make negative mapping TTL configurable"
Lori Jakab [Tue, 11 Jul 2017 11:09:46 +0000 (11:09 +0000)]
Merge "Make negative mapping TTL configurable"

6 years agoUpgrade to odlparent 2.0.2 45/60145/1
Lorand Jakab [Mon, 10 Jul 2017 13:07:36 +0000 (16:07 +0300)]
Upgrade to odlparent 2.0.2

Build is broken without this upgrade.

Change-Id: Ib9e24eb78d4af103ad8e30febd233ef2ec175963
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMake negative mapping TTL configurable 60/59560/4
Lorand Jakab [Tue, 27 Jun 2017 11:34:24 +0000 (14:34 +0300)]
Make negative mapping TTL configurable

Change-Id: I08c6ad1517f4cc34747a4762dc604b0de87b2bea
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoFix build 49/59549/1
Lorand Jakab [Tue, 27 Jun 2017 08:21:47 +0000 (11:21 +0300)]
Fix build

Change-Id: I5bfc3c58fef1fcb1c20387d840f1307f09fd7990
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBug 8679: Fix widest negative prefix calculation 06/59206/4
Lorand Jakab [Tue, 20 Jun 2017 08:53:15 +0000 (11:53 +0300)]
Bug 8679: Fix widest negative prefix calculation

And add integration tests to avoid regressions.

Change-Id: I6cadaca03d360f475c7c88fd3cb58dd39814d23f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade to odlparent 2.0.0 81/59281/1
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Upgrade to odlparent 2.0.0

Change-Id: I10061eda3522ded1d55adc1ac365ab9d4b22763b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoDo not build Karaf 3 features and distro 92/58392/8
Lorand Jakab [Wed, 7 Jun 2017 09:36:55 +0000 (12:36 +0300)]
Do not build Karaf 3 features and distro

Disable building the Karaf 3 features and local distribution, since
that's a prerequisite for getting back into autorelease in Nitrogen [0],
apart from the build breaking right now.

For now, just comment them out in the build, we fully remove source code
just before code freeze (in case we need to contrast behaviors between a
Karaf 3 and 4 container).

[0] https://lists.opendaylight.org/pipermail/odlparent-dev/2017-June/001036.html

Change-Id: Id7f9a82e4b9868ad57141d3ef7e5a0cc2ef74946
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoUpgrade V3PO model version 35/59135/1
Lorand Jakab [Mon, 19 Jun 2017 06:57:04 +0000 (09:57 +0300)]
Upgrade V3PO model version

Else build fails

Change-Id: I57439066304d70c633dd565873d9401870238b13
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoMerge "Bug 8503: Remove empty structures in DAO"
Vina Ermagan [Thu, 15 Jun 2017 01:08:27 +0000 (01:08 +0000)]
Merge "Bug 8503: Remove empty structures in DAO"

6 years agoMigrate to odlparent 1.9.0 65/58865/1
Thanh Ha [Tue, 13 Jun 2017 20:20:20 +0000 (16:20 -0400)]
Migrate to odlparent 1.9.0

Change-Id: I9de99604521440580045e6bedcff4606389561a2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBug 8503: Remove empty structures in DAO 99/57799/6
Lorand Jakab [Thu, 25 May 2017 06:29:15 +0000 (09:29 +0300)]
Bug 8503: Remove empty structures in DAO

Change-Id: I52bb47edbb2e34c0b72d874b1ceab33125156f42
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
6 years agoBUG-6709: migrate karaf-empty 75/58375/2
Robert Varga [Tue, 6 Jun 2017 20:41:58 +0000 (22:41 +0200)]
BUG-6709: migrate karaf-empty

No longer provided by controller.

Change-Id: I11fa1db7b9aaf2a15be3c8979c744d23d5c77d62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoMigrate to odlparent 1.8.0-Carbon 61/58661/1
Thanh Ha [Sat, 10 Jun 2017 05:31:21 +0000 (01:31 -0400)]
Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Change-Id: I38f3b068e85b2e9aa81fb6fc8a48e862c249bf95
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoFix configuration file parsing 90/58190/1
Lorand Jakab [Fri, 2 Jun 2017 22:19:24 +0000 (15:19 -0700)]
Fix configuration file parsing

Change-Id: Ifd747d1b5d5b39da80920bc088c7c9c0e5cb7111
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd knob to disable authentication 48/58148/2
Lorand Jakab [Thu, 1 Jun 2017 22:20:49 +0000 (15:20 -0700)]
Add knob to disable authentication

Change-Id: I87a2311be0d6b3821fa276feb84cd208d8e8dd30
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoCancel ongoing SMR futures on new event 98/57798/2
Lorand Jakab [Thu, 25 May 2017 05:32:39 +0000 (08:32 +0300)]
Cancel ongoing SMR futures on new event

The SMR scheduler keeps retrying the sending of SMRs a few (configurable
number) of times with a given spacing between the retries until an
SMR-invoked Map-Request is received for the particular EID. When that
happens, the retrying is cancelled for the subscriber that sent it.

However, up until now, when a new set of SMRs was scheduled for a given
EID, the old set, if still retrying, was left untouched. This patch
fixes that, and starts with a clean slate for the given EID.

Change-Id: Ic64ce0980b39d780433ac2c4e96608af12302392
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoReverse SmrScheduler Map order Subscriber <--> Eid 86/57786/3
Lorand Jakab [Wed, 24 May 2017 17:19:57 +0000 (20:19 +0300)]
Reverse SmrScheduler Map order Subscriber <--> Eid

Change-Id: Ic4b5614c2825f0e03b637896fae5b93f21bdbe32
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoReplace Rloc with Subscriber for SMR key 51/57651/2
Lorand Jakab [Mon, 22 May 2017 22:38:37 +0000 (01:38 +0300)]
Replace Rloc with Subscriber for SMR key

Change-Id: I362c6037707efc091d58c6d1aa4e4e16351523d3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd cluster testing Postman collection 80/57380/1
Lorand Jakab [Thu, 18 May 2017 16:19:02 +0000 (19:19 +0300)]
Add cluster testing Postman collection

Change-Id: I190b9d0e952c361db0fe3f204ff8dd7fe43c81fc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Add CSR1Kv configs"
Vina Ermagan [Tue, 16 May 2017 18:29:04 +0000 (18:29 +0000)]
Merge "Add CSR1Kv configs"

7 years agoMore detailed subscriber event logging 37/56837/7
Lorand Jakab [Thu, 11 May 2017 08:37:48 +0000 (11:37 +0300)]
More detailed subscriber event logging

Change-Id: I21de8a93d0c4973a29b210dcf857f36ba08a84db
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 8429: Fix SMR handling concurrency issue 42/56842/6
Lorand Jakab [Thu, 11 May 2017 10:21:24 +0000 (13:21 +0300)]
Bug 8429: Fix SMR handling concurrency issue

Change-Id: I1944a82600a3956c053edd9134541a6eab776e0a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd CSR1Kv configs 21/57121/1
Lorand Jakab [Tue, 16 May 2017 08:07:06 +0000 (11:07 +0300)]
Add CSR1Kv configs

Add CSR1Kv example configs from the tutorial, so they can be linked to.

Change-Id: I28d65d9bb65a769770b3d446634b77a6ec01a4fb
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoTrace-level improved IT logging 17/56617/1
Lorand Jakab [Fri, 5 May 2017 19:02:53 +0000 (22:02 +0300)]
Trace-level improved IT logging

Change-Id: I29bc887ff4efd81d11629c0028a95beaf4cf2d68
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd IPv6 default key for addkeys CLI command 86/56486/1
Lorand Jakab [Wed, 3 May 2017 11:37:49 +0000 (14:37 +0300)]
Add IPv6 default key for addkeys CLI command

The addkeys Karaf CLI command adds a default authentication key
"password" of type one for the whole IPv4 EID space to ease southbound
testing. This patch extends the command to add a default authentication
key for the whole IPv6 EID space as well.

Change-Id: I93b84ab03699592cd5722f42ca63fe66437eb6d5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 8248: Don't access DSBE from different threads 29/55929/3
Lorand Jakab [Mon, 24 Apr 2017 18:55:50 +0000 (21:55 +0300)]
Bug 8248: Don't access DSBE from different threads

With Epoll we may have more than one LispSouthboundHandler thread, and
they may access the same DataStoreBackEnd (DSBE) instance concurrently.
This patch moves DSBE access to the single threaded
LispSouthboundPlugin. Additionally, it implements some suggestions from
the following thread:

https://lists.opendaylight.org/pipermail/release/2017-April/010273.html

Change-Id: I32f48b6dcb58b241a4a679f7145bd36b5f410861
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoIT: Before each checkSMR(), print map-caches to log 64/54964/2
Lorand Jakab [Thu, 13 Apr 2017 12:43:02 +0000 (15:43 +0300)]
IT: Before each checkSMR(), print map-caches to log

Change-Id: I64ff1f3a10ec0b0ddcc1605703fbd5ce95325aa6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMake 'mappings' CLI output user friendly 66/54766/4
Lorand Jakab [Thu, 22 Dec 2016 16:54:38 +0000 (18:54 +0200)]
Make 'mappings' CLI output user friendly

Before this patch, the mappings CLI command would print out the full
Java objects contained in a map-cache. That's great for in-depth
debugging, but for a quick look it very hard to read. This patch
implements a user friendly CLI output for mappings, to improve
readability.

The old full output is still available in Karaf, but is by adding the
'-d' or '--debug' switch to the CLI command.

Example output:

---8<--------------------------------------------------------------------
opendaylight-user@root>mappings
Policy map-cache
----------------
Instance ID 1
  [1] 192.0.2.1/32|192.0.2.2/32, TTL: 1440
    -> Locator                                         State     Pri/Wgt
       10.10.10.10                                     no-route  1/1

Southbound map-cache
--------------------
Instance ID 0
  192.0.2.1/32, TTL: 1440
    -> Locator                                         State     Pri/Wgt
       192.168.16.21                                   up        1/1
       fdab:cc19:b80e::21                              up        1/1
       -----------------------------------------------------------------
    -> Subscriber RLOC                                 Subscriber EID
       192.168.16.21                                   No Address Present
       127.0.0.2                                       No Address Present
-------------------------------------------------------------------->8---

Change-Id: Id3c304ac9eda77a0cc36bff1cdeb18d61608a796
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoPrepare for checkstyle version upgrade 65/55265/1
Lorand Jakab [Wed, 19 Apr 2017 18:20:13 +0000 (21:20 +0300)]
Prepare for checkstyle version upgrade

See https://git.opendaylight.org/gerrit/#/c/54981/

Change-Id: I451e9016a2545b0455d31e057191cb9df1990aaf
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBump versions by x.(y+1).z for next dev cycle 04/54704/1
Anil Belur [Tue, 11 Apr 2017 01:45:41 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: Ibf7642de95c0c4bd04d683ba2de53549ecd7c8f4
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoBug 7272: Fully remove mappings 12/52112/14
Lorand Jakab [Tue, 21 Feb 2017 12:58:59 +0000 (14:58 +0200)]
Bug 7272: Fully remove mappings

When removing a mapping, remove all subkeys, and the radix trie entry,
to avoid false lookup results.

Also, instead of sending a notification w/o a subscriber list, expecting
the listeners to look up the subscribers from the mapping system,
include the subscriber list with the notification. That way all subkeys
can be deleted when the change is a mapping removal.

Change-Id: Ic922b82fab42f533f9fa8ec828e4d21f6fa35198
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMigrate IT to use the Karaf 4 distribution 17/52217/6
Lorand Jakab [Wed, 22 Feb 2017 21:07:31 +0000 (23:07 +0200)]
Migrate IT to use the Karaf 4 distribution

Change-Id: Iecef5c6745bcee3853810303815199c12b6957a5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Use Optional to avoid null return value"
Vina Ermagan [Wed, 22 Mar 2017 23:04:16 +0000 (23:04 +0000)]
Merge "Use Optional to avoid null return value"

7 years agoUse Optional to avoid null return value 17/53617/2
Lorand Jakab [Tue, 21 Mar 2017 14:34:29 +0000 (16:34 +0200)]
Use Optional to avoid null return value

Change-Id: I390f182341fffa36da989fb0e9daaa72473ec466
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoUpdate port tests with proper implementation 38/53638/1
Shakib Ahmed [Tue, 21 Mar 2017 23:18:19 +0000 (16:18 -0700)]
Update port tests with proper implementation

New implementation of Neutron PortDataProcessor left the old unit tests
useless. Those tests are being updated with validated ones.

Change-Id: I6b419aa06cd03721606c2e3cf7a6cac31b8cea4d
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoCreate mapping record with proper VNI 42/52042/6
Shakib Ahmed [Sat, 18 Feb 2017 00:12:56 +0000 (16:12 -0800)]
Create mapping record with proper VNI

Change-Id: I63f94bb9b87b7256d8c12375bfbd10defd937280
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoUpdate mapping records with port data update 88/51588/7
Shakib Ahmed [Wed, 8 Feb 2017 22:20:11 +0000 (14:20 -0800)]
Update mapping records with port data update

Neutron port update can provide a new set of fixed ips. With new fixed
ips, we need to removed old set of mapping recordss in case there were
already old fixed ips and we have mapping records in mapcaches related
to those fixed ips. And then we need to add the new mapping records
in the mapcache.

Change-Id: Id2eca598fcb073169e6d63b72dd14830a35a4f5b
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd mapping record with port data add with fixed ip 93/51493/9
Shakib Ahmed [Mon, 6 Feb 2017 00:14:17 +0000 (16:14 -0800)]
Add mapping record with port data add with fixed ip

When a neutron port create comes with a fixed ip, we consider the fixed
ip as EID. We need to save this EIDs specific to host id, so that when
we have host id to locator mapping available we can create a mapping
record.

This patch adds hostid to all eid mappings keyed by port uuid. And also
attempts to create a mapping record if hostid to locator mapping is
available.

Change-Id: Ia6ae4643e1ecf5d16c592bcd9a52170b28f38777
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd Neutron host-id to RLOC mapping 92/50392/17
Shakib Ahmed [Tue, 10 Jan 2017 22:17:54 +0000 (14:17 -0800)]
Add Neutron host-id to RLOC mapping

Neutron port create call provides us informations like port uuid, host-
id, sometimes fixed-ips but we don't know the interface VPP is going to
use for sending traffic from one host to another. That interface is
going to be the locator for the mapping record we will be putting in
the map-cache. For that, we need to know the locator interface of a
host. Just to clarify, for OpenStack environment is going to be the
tenant network interface.

This patch adds the functionality of listening to VbridgeTopology for
topology updates in Virtual Bridge Domain and pre-populate host to
locator information base.

Change-Id: Ic4c0844ccfcb972e46122df875b628c789f8c837
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoMerge "Add timeout to subscriber data"
Vina Ermagan [Thu, 16 Mar 2017 22:41:14 +0000 (22:41 +0000)]
Merge "Add timeout to subscriber data"

7 years agoMerge "Provide Karaf 4 features"
Vina Ermagan [Thu, 16 Mar 2017 18:22:18 +0000 (18:22 +0000)]
Merge "Provide Karaf 4 features"

7 years agoAdd timeout to subscriber data 88/52088/11
Lorand Jakab [Mon, 20 Feb 2017 22:10:29 +0000 (00:10 +0200)]
Add timeout to subscriber data

The timeout of a subscriber is immutable too, and needs to be
transmitted in a MappingChanged notification using the YANG modeled
subscriber data.

Change-Id: Id62485c79b92ba35c6cd682c78a888ed14234059
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoSMR parent prefix continued 77/48977/33
Lorand Jakab [Mon, 5 Dec 2016 12:15:51 +0000 (14:15 +0200)]
SMR parent prefix continued

This patch completes work started in
https://git.opendaylight.org/gerrit/#/c/47120/

First, it handles the insertion of a positive mapping that overlaps
a negative one, by removing the negative mapping and generating SMRs for
its subscribers. This leads to pushing the positive mapping to the right
subscribers and generating only the needed negative mappings.

Second, it merges negative mappings when a positive mapping is removed
(reversing what was done in the first point above).

Additionally, it creates a variable for the action considered the
default for negative mappings, and uses it in the right places instead
of harcoding Action.NativelyForward.

Change-Id: I6a8799d3af23c20a9797840b3e64f632a3e2ee91
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoProvide Karaf 4 features 94/50094/21
Lorand Jakab [Fri, 6 Jan 2017 19:06:55 +0000 (21:06 +0200)]
Provide Karaf 4 features

This patch provides Karaf 4 features for lispflowmapping. The neutron
upstream doesn't have its Karaf 4 patch finalized and merged yet, so our
odl-lispflowmapping-neutron feature for Karaf 4 is not enabled yet (but
it is migrated and ready to be enabled).

Bug: 7628
Change-Id: Icf8d404f4d46c71557b1f6f088626c2fb75200c8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoGUI - Add default redirect on app start 34/53134/1
Daniel Malachovsky [Fri, 10 Mar 2017 11:52:47 +0000 (12:52 +0100)]
GUI - Add default redirect on app start

Due Dlux split we removed Topology app from odl-dlux-core feature.
There were also default redirect to that app, so it was landing page, when
DLUX was started.
This patch adds default route to GUI in this project.

More info:
https://wiki.opendaylight.org/view/Weather#Rename_some_odl-dlux-.2A_features_to_odl-dluxapps-.2A

Also fixed errors caused by refactor in YangUI and Yangutils

Change-Id: I125ebc851b749a244b834627326833a71e8079ea
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>
7 years agoBug 7818: xTR-ID timestamp updated only when merging 68/52868/1
Lorand Jakab [Mon, 6 Mar 2017 10:10:18 +0000 (12:10 +0200)]
Bug 7818: xTR-ID timestamp updated only when merging

A warning was shown on the Map-Register fast path with default setting,
saying somthing "Could not update timestamp for EID 192.0.2.0/24 xTR-ID
E073DF027BF20605DC9B9518BA753345, no mapping found". Default settings
mean that mapping merge is not on and xTR-ID mappings are not stored, so
the warning is not warranted. And it's not just the warning, the extra
lookup at EVERY fast path Map-Register timestamp upadte has a
performance cost, so make sure it only happens when merge is on.

Change-Id: Id7a66ff8c3309bbcb4ef0bf014f2987149f02fe7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix radix trie last byte prefix comparison 40/52740/4
Florin Coras [Fri, 3 Mar 2017 09:40:21 +0000 (01:40 -0800)]
Fix radix trie last byte prefix comparison

Change-Id: Id360576c7a6e59fc556d484d9f869985e8f1714a
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAllow Address for getString() 93/52293/3
Lorand Jakab [Mon, 27 Feb 2017 11:21:44 +0000 (13:21 +0200)]
Allow Address for getString()

For now getString only takes LispAddress arguments (and XtrId). Some
times we only have access to the Address inside LispAddress, and we want
to be able to print that too in a user friendly way.

Change-Id: I9568ec9b08dba5c78572140b467d982e32f592ab
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix NPE related to mapping record in IT 59/52759/1
Shakib Ahmed [Fri, 3 Mar 2017 12:28:34 +0000 (04:28 -0800)]
Fix NPE related to mapping record in IT

Change-Id: Ica7dbdf7e054729f1586c7867d5a40a80ad2eab5
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd missing <name> fields for pom.xml files 43/52743/1
Anil Belur [Fri, 3 Mar 2017 10:02:25 +0000 (20:02 +1000)]
Add missing <name> fields for pom.xml files

This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:

    ODL :: <groupId> :: <artifactId>

This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522

Change-Id: I9c822509f8cb035cd656f5b2ff8c427c85cf7176
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoFix a NPE in SmrScheduler 96/52296/2
Lorand Jakab [Mon, 27 Feb 2017 11:29:00 +0000 (13:29 +0200)]
Fix a NPE in SmrScheduler

Change-Id: Iae5bd84361d19b5a6f30f881b2fd5eced26eb171
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 7182 related: Remove M2E lifecycle mapping 29/52429/1
Michael Vorburger [Tue, 28 Feb 2017 22:54:59 +0000 (23:54 +0100)]
Bug 7182 related: Remove M2E lifecycle mapping

These should never be in individual projects anymore now, we handle this
centrally, either in odlparent, or
https://github.com/vorburger/opendaylight-eclipse-setup, or by
appropriate lifecycle-mapping-metadata.xml in a Maven plugin (that's
what Bug 7182 does for the yang-maven-plugin; this removes what makes
that not work for these projects).

Change-Id: Ic3e7f81560e54882a8c17bece500148637aa1087
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoImprove OOR server config in tutorial resources 39/52239/1
Lorand Jakab [Fri, 24 Feb 2017 09:46:26 +0000 (11:46 +0200)]
Improve OOR server config in tutorial resources

Change-Id: Ic39d735a78d5b07e83ce71546f9c96f6ba5b2f64
Reported-by: Rashmi Pujar <rashmi.c.pujar@gmail.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Time Bucket DS for handeling SB mapping timeout"
Vina Ermagan [Tue, 21 Feb 2017 06:44:03 +0000 (06:44 +0000)]
Merge "Time Bucket DS for handeling SB mapping timeout"

7 years agoBug 6071: Fix fast path Map-Notify auth data 16/52016/1
Lorand Jakab [Fri, 17 Feb 2017 21:33:55 +0000 (23:33 +0200)]
Bug 6071: Fix fast path Map-Notify auth data

Change-Id: I40884696576be4b311930312e8e09148f15810bb
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoTime Bucket DS for handeling SB mapping timeout 13/46013/19
Shakib Ahmed [Thu, 1 Dec 2016 19:19:28 +0000 (11:19 -0800)]
Time Bucket DS for handeling SB mapping timeout

Mapping records in map caches have expiration time. When
mapping records surpass their expiration time, they are
supposed to be expired, meaning, removed from the map cache.

Right now the mapping records are expired in a lazy manner,
meaning, we query and handle the validity of the mapping only
when the mapping are beign asked for which introduces the
possibility of mapping records being in map cache indefinitly
if they are not requested for.

Time Bucket data structure maintains mapping records and
delete them upon expiration in a non-lazy manner.

Change-Id: I664249cc5c5d14cb54759369c6f982aef89a0ca3
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoSimplify and centralize sb mapping removal 47/51747/5
Shakib Ahmed [Sat, 11 Feb 2017 00:17:16 +0000 (16:17 -0800)]
Simplify and centralize sb mapping removal

Whenever we remove a mapping from smc, we also need to remove the
necessary data from data store. Now all the mapping removal are in
seperate places in mapping system making it hard to track whether all
the mapping removal call removing all the data properly.

The goal of the patch is to simplify mapping removal and centralize
all the mapping removal calls in few methods which will remove the
mapping properly from everywhere.

Change-Id: Ia279c019a186e3cdc349eb912abd499bde3e3802
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoBug 7789: Don't break DLUX when loading LISP UI 55/51855/1
Lorand Jakab [Tue, 14 Feb 2017 11:27:24 +0000 (13:27 +0200)]
Bug 7789: Don't break DLUX when loading LISP UI

This simple patch just fixes the breakage caused by loading the LISP UI,
which results in an empty page, and the inability to access any of the
already loaded DLUX apps. However, making the LISP UI functional again
will require more work.

Change-Id: I8b2a08c93eeb1a77acc5496cc26a67f99f5aa825
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix default mapping data for MappingSystemTest 25/51825/1
Shakib Ahmed [Mon, 13 Feb 2017 22:41:40 +0000 (14:41 -0800)]
Fix default mapping data for MappingSystemTest

Change-Id: I3193fc66474f78dedad7a3034326168d3520265c
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoCheckstyle: fix ParenPad violations 00/51700/1
Lorand Jakab [Fri, 10 Feb 2017 16:38:32 +0000 (18:38 +0200)]
Checkstyle: fix ParenPad violations

Enforcing no space(s) after a left parenthesis and before a right
parenthesis is a proposed change [0] which can only be merged when all
violations are fixed in projects enforcing checkstyle. This patch fixes
those violations.

[0] https://git.opendaylight.org/gerrit/#/c/51316/

Change-Id: Ib4c793428f67e465a3caa6ccbf49364c3ca3c905
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Make part of the Subscribers object modeled"
Vina Ermagan [Fri, 10 Feb 2017 03:41:39 +0000 (03:41 +0000)]
Merge "Make part of the Subscribers object modeled"

7 years agoUse org.osgi:org.osgi.core instead of org.eclipse.tycho's osgi (Equinox) 92/51592/1
Michael Vorburger [Thu, 9 Feb 2017 00:07:52 +0000 (01:07 +0100)]
Use org.osgi:org.osgi.core instead of org.eclipse.tycho's osgi (Equinox)

see https://git.opendaylight.org/gerrit/#/c/51520/

I'll like to block use of dependency tycho ASAP.

Change-Id: Iacb6b5efe337eed156a44dc32528445eda99fd06
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMake part of the Subscribers object modeled 68/51268/4
Lorand Jakab [Tue, 31 Jan 2017 16:33:03 +0000 (18:33 +0200)]
Make part of the Subscribers object modeled

This is a first step in solving bug 7272 and propagating subscriber data
to slave nodes in a cluster. This patch makes the YANG additions,
renames the SubscriberRLOC class to Subscriber, which makes more sense
(originally the SubscriberRLOC object only held the RLOC, now it holds
the source EID too), and uses the modeled SubscriberAddresses inside
Subscriber to store the source RLOC and EID.

Change-Id: I2e3ae71e7c9948d962921553b00cfecd76f445f1
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Remove xtr id mappings on mapping overwrite"
Vina Ermagan [Tue, 31 Jan 2017 02:04:53 +0000 (02:04 +0000)]
Merge "Remove xtr id mappings on mapping overwrite"

7 years agoSMR parent prefix 20/47120/32
Miroslav Toth [Wed, 19 Oct 2016 11:22:00 +0000 (13:22 +0200)]
SMR parent prefix

Change-Id: I54ee2460012a0ac08a2cc0333e2ce0d9ae98953b
Signed-off-by: Miroslav Toth <mirtoth@cisco.com>
7 years agoRemove xtr id mappings on mapping overwrite 09/50909/5
Shakib Ahmed [Mon, 23 Jan 2017 21:43:29 +0000 (13:43 -0800)]
Remove xtr id mappings on mapping overwrite

If there are 2 xtrs with different merge mapping configuration
registers same eid, we may or may not have merged mapping for
the eid in Map Cache but we will have xtr id specific mapping
in XTRID_RECORDS all the time. When we have xtr id specific
mapping from the xtr with merge configuration, but overwritten
mapping record in RECORD, then the xtr id specific mappings
may become untracked and hence not removed ever.

This patch removes previous xtrid specific mappings too when
mapping records are being overwritten.

Change-Id: Iaf8686367fb881b5794a3bf232e6c2e12d5ec6f8
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd virtual parent sibling prefix lookup methods 32/50732/2
Lorand Jakab [Fri, 20 Jan 2017 14:56:17 +0000 (16:56 +0200)]
Add virtual parent sibling prefix lookup methods

Change-Id: I6fa317cbb7cdd0bcef2531b761e1c2dc19d1ce6d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 7586: Make Extended SingleFeatureTest pass 36/50736/1
Lorand Jakab [Fri, 20 Jan 2017 18:13:03 +0000 (20:13 +0200)]
Bug 7586: Make Extended SingleFeatureTest pass

We missed the fact that southbound is a dependency for mappingservice,
because of the RPCs to send reply packets. This patch corrects the
feature dependency and allows the new extended SingleFeatureTest to
pass, so we can be removed from the feature blacklist.

Change-Id: I5aadb06cdb2c9ce1bd9c1c3b4efdade53e4a1bcc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Fix removal of expired mappings when merge on"
Vina Ermagan [Fri, 20 Jan 2017 01:42:00 +0000 (01:42 +0000)]
Merge "Fix removal of expired mappings when merge on"

7 years agoMerge "Remove SimpleMapCache#getXtrIdTable()"
Vina Ermagan [Fri, 20 Jan 2017 01:40:57 +0000 (01:40 +0000)]
Merge "Remove SimpleMapCache#getXtrIdTable()"

7 years agoCleaning operational should clean map-cache too 96/49696/7
Lorand Jakab [Wed, 21 Dec 2016 11:11:13 +0000 (13:11 +0200)]
Cleaning operational should clean map-cache too

The recently added remove-all-operational-content RPC removes the
operational datastore content, but the in-memory southbound map-cache is
not cleaned on master nodes, since southbound operations go to the cache
first. This patch explicitly clears the southbound map-cache on master
nodes when the RPC is called.

Change-Id: I3c1b899de592f5499779c55fb880481a60f9a64a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix removal of expired mappings when merge on 79/50579/1
Lorand Jakab [Tue, 17 Jan 2017 21:12:14 +0000 (23:12 +0200)]
Fix removal of expired mappings when merge on

Change-Id: Ie1f1752471f72400788d28e81fd7f41ede6273f7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoRemove SimpleMapCache#getXtrIdTable() 43/50443/5
Lorand Jakab [Tue, 17 Jan 2017 19:43:09 +0000 (21:43 +0200)]
Remove SimpleMapCache#getXtrIdTable()

Change-Id: I53394480d41a5f0eb6356dfed24e293fbc5dfc19
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoSeparate authentication key in-memory storage 15/49715/5
Lorand Jakab [Wed, 21 Dec 2016 15:50:09 +0000 (17:50 +0200)]
Separate authentication key in-memory storage

Authentication key operations (add/get/remove) are part of the IMapCache
interface, so all map-caches implement them, even though we only really
use them in SimpleMapCache. This makes map-caches less "general", in the
sense that they need to be aware of the AuthenticationKey type, and we
have unused code.

This patch creates a new IAuthKeyDb interface and the AuthKeyDb class
implementing it, which contains only the authentication key operations.
The MappingSystem and the LispSouthBoundPlugin are switched to the new
implementation.

This is a prerequisite for a full solution to bug 7272, by making it
possible to remove all sub-keys when removing a mapping, leaving the
RadixTrie in a consistent state. It also makes a proper implementation
for the newly introduced remove-all-operational-content RPC, since
deleting all operational content should delete all southbound mappings,
but not authentication keys, which are now in the same in-memory
structures.

Checked system tests, all passing.

Change-Id: I9536dbccb06d486e205f8a15e9e8ac3fa1c53fcc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoRemove the last remnants of the CSS 40/50540/1
Lorand Jakab [Tue, 17 Jan 2017 11:13:53 +0000 (13:13 +0200)]
Remove the last remnants of the CSS

We don't use the config sub-system (CSS) anywhere in our project, so
remove the dependecy completely.

Change-Id: Ic2d0de34907ef4273339d50796aca594c77d8b05
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Account for merging on mapping removal"
Vina Ermagan [Mon, 16 Jan 2017 23:40:05 +0000 (23:40 +0000)]
Merge "Account for merging on mapping removal"

7 years agoFix NPE in SimpleMapCache 34/50034/2
Lorand Jakab [Wed, 4 Jan 2017 21:34:10 +0000 (23:34 +0200)]
Fix NPE in SimpleMapCache

This was causing a serious performance regression too, introduced with
Gerrit c/46778, "Make SimpleMapCache simple again".

Change-Id: I531a5f103322f5389b20197895a381aceef79fa5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd sibling prefix lookup methods to RadixTrie and HashMapDb 21/50121/2
Lorand Jakab [Sat, 7 Jan 2017 11:26:55 +0000 (13:26 +0200)]
Add sibling prefix lookup methods to RadixTrie and HashMapDb

Change-Id: Ib639113b120ce63444a164e857e78f3f41830243
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAccount for merging on mapping removal 44/49744/2
Lorand Jakab [Thu, 22 Dec 2016 14:50:10 +0000 (16:50 +0200)]
Account for merging on mapping removal

When removing an xTR-ID mapping, if merge is on, the main mapping needs
to be re-calculated.

Change-Id: Ib49869b18de83ffb62f3cf311a87568b242425f8
Reported-by: Shakib Ahmed <sheikahm@cisco.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd toString() to MappingData 46/49746/1
Lorand Jakab [Thu, 22 Dec 2016 16:54:38 +0000 (18:54 +0200)]
Add toString() to MappingData

When running the `mappings` command on the Karaf console to view current
in-memory data structures, the address field of mapping shows the memory
reference of the MappingData object, since it doesn't override the
toString() method. This happens since the SimpleMapCache class was
simplified in https://git.opendaylight.org/gerrit/#/c/46778/ and the
MappingRecord was wrapped into a container class.

This patch implements the toString() method for the MappingData class.

Change-Id: Ib39ddb2c6330c28734f948d854ed42925cb1aa3a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAdd RPC to delete operational content 70/49670/2
Lorand Jakab [Tue, 20 Dec 2016 19:34:34 +0000 (21:34 +0200)]
Add RPC to delete operational content

This is useful when debugging all kinds of issues, as the RESTCONF
interface only allows removing all config datastore content, but not the
operational datastore content.

Change-Id: I6a1d1c2c86b63d825cd4994ffe8e98ccee6aa82d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoIT: Add constant for sleep time 34/49634/1
Lorand Jakab [Tue, 20 Dec 2016 09:40:28 +0000 (11:40 +0200)]
IT: Add constant for sleep time

In addition, decrease sleep time for the multi-site tests from 2 seconds
to 1 second, to avoid the following type intermittent errors:

Failed tests:
  MappingServiceIntegrationTest.testMultiSite:414->testMultiSiteScenarioA:687
SMR contained Eid [_address=Ipv4PrefixBinary
[_ipv4AddressBinary=Ipv4AddressBinary [_value=[-64, 0, 1, 1]],
_ipv4MaskLength=32, augmentation=[]], _addressType=class
org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.binary.address.types.rev160504.Ipv4PrefixBinaryAfi,
_virtualNetworkId=InstanceIdType [_value=2], augmentation=[]] which
wasn't expected.

AND

Failed tests:
  MappingServiceIntegrationTest.testMultiSite:415->testMultiSiteScenarioB:802
SMR contained Eid [_address=Ipv4PrefixBinary
[_ipv4AddressBinary=Ipv4AddressBinary [_value=[-64, 0, 2, 5]],
_ipv4MaskLength=32, augmentation=[]], _addressType=class
org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.binary.address.types.rev160504.Ipv4PrefixBinaryAfi,
_virtualNetworkId=InstanceIdType [_value=2], augmentation=[]] which
wasn't expected.

Change-Id: I551e1f6ba60fc54ab259a419cd8c5ce97eaa1ba9
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoComment about config option modification dependencies 65/49465/2
Lorand Jakab [Fri, 16 Dec 2016 09:56:32 +0000 (11:56 +0200)]
Comment about config option modification dependencies

When we add/remove/modify a configuration option in ConfigIni.java, some
external modifications are required in the odlparent and docs projects.
Make this clear in a comment.

Change-Id: Id5ceb334cdf1075a1090b229672b1a3c5c575e24
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Remove overwrite configuration and convert it to mapping merge configuration"
Lori Jakab [Fri, 16 Dec 2016 08:36:09 +0000 (08:36 +0000)]
Merge "Remove overwrite configuration and convert it to mapping merge configuration"

7 years agoRemove overwrite configuration and convert it to mapping merge configuration 55/49455/1
Shakib Ahmed [Thu, 15 Dec 2016 21:35:18 +0000 (13:35 -0800)]
Remove overwrite configuration and convert it to mapping merge configuration

Change-Id: I511ec249ff2f5e3c6fef2336bfc4455728a08535
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoAdd parent prefix lookup methods to RadixTrie and HashMapDb 35/49335/4
Lorand Jakab [Wed, 14 Dec 2016 10:00:27 +0000 (12:00 +0200)]
Add parent prefix lookup methods to RadixTrie and HashMapDb

Change-Id: I30342f6ac146d78ed3708430cec684a4d603910f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMake SimpleMapCache simple again 78/46778/20
Lorand Jakab [Mon, 10 Oct 2016 19:22:08 +0000 (22:22 +0300)]
Make SimpleMapCache simple again

A lot of logic in SimpleMapCache is intelligence to handle LISP specific
features, like merging mappings from several different xTRs and handling
expiration of mapping state from UDP xTR registrations. This logic does
not belong there architecturally, and should be moved out.

SimpleMapCache still needs to handle some LISP specific functionality,
but methods implementing that functionality should not be part of the
general IMapCache contract, which is implemented by all map caches. This
commit introduces a new interface, ILispMapCache, which is only
implemented by SimpleMapCache, to provide access to xTR-ID specific
mappings.

Since FlatMapCache was not really maitained and tested, this patch
causes the map caches not be built when `iterateMask` is false. It's
better to fail than give undefined behavior to the user.

The patch also updates the mapping system and mapping service interfaces
to use MappingData instead of the immutable MappingRecord (contained
within) so that mapping context can be easily carried in both directions
between layers.

Change-Id: I49dbc68615a360d1b9d1c32b4af23726f173259f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoFix radix trie lookup exact 59/49059/4
Florin Coras [Wed, 7 Dec 2016 01:43:01 +0000 (17:43 -0800)]
Fix radix trie lookup exact

Change-Id: I6d29db3f0d5d576e83006a3f051ae97d9dfcf510
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoAdd postman collection in FD.io tutorial 19/49119/1
Shakib Ahmed [Wed, 7 Dec 2016 23:20:15 +0000 (15:20 -0800)]
Add postman collection in FD.io tutorial

Change-Id: I36a68b6699c14d98eb528f2226fac54d46728174
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>
7 years agoMerge "WIP: Update Tutorial for FD.io and OOR"
Vina Ermagan [Wed, 7 Dec 2016 02:05:45 +0000 (02:05 +0000)]
Merge "WIP: Update Tutorial for FD.io and OOR"

7 years agoBug 7272: Fix prefix removal in MultiTableMapCache 50/49050/2
Lorand Jakab [Tue, 6 Dec 2016 18:22:13 +0000 (20:22 +0200)]
Bug 7272: Fix prefix removal in MultiTableMapCache

This fix is a bit of a brute-force, since it removes authentication keys
and all data, when removing a mapping, but for the MultiTableMapCache in
lispflowmapping as-is currently it is OK, since authentication keys are
stored in SimpleMapCache. So this is just a band-aid for the particular
use case reported in the bug, but a proper fix will require more
changes, which need to be discussed.

Change-Id: I295d2921f6b81505271887fbde2078ec38dbca0d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoBug 7293: Fix radix trie removals that update the root (2) 20/49020/1
Florin Coras [Tue, 6 Dec 2016 10:25:37 +0000 (02:25 -0800)]
Bug 7293: Fix radix trie removals that update the root (2)

Change-Id: I08e202ba0557d1dfb013680c7f3720f4fb470f72
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoBug 7293: Fix radix trie node removals that update the root 66/48966/2
Florin Coras [Mon, 5 Dec 2016 07:36:20 +0000 (23:36 -0800)]
Bug 7293: Fix radix trie node removals that update the root

Set the isRoot flag if when removing intermediaries the root is
updated.

Change-Id: I1650798c333262ad79bc92240210f90f665131b7
Signed-off-by: Florin Coras <fcoras@cisco.com>
7 years agoSonar: Reorder modifiers ... 52/48652/1
Lorand Jakab [Thu, 24 Nov 2016 09:04:27 +0000 (11:04 +0200)]
Sonar: Reorder modifiers ...

... to comply with the Java Language Specification.

Change-Id: I670b63d32ce0e8d4f9d0814a5fdbefa989064319
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoSonar: Move trailing comment on previous empty line 24/48624/2
Lorand Jakab [Wed, 23 Nov 2016 12:53:11 +0000 (14:53 +0200)]
Sonar: Move trailing comment on previous empty line

Change-Id: I300972c7be4d89ffdc73a58475fa4a533ab5fc4b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoIT - timed out mappings 16/46816/2
Miroslav Toth [Mon, 19 Sep 2016 11:06:43 +0000 (13:06 +0200)]
IT - timed out mappings

Change-Id: I5b4c26821058c21584d028daff26698443d26bab
Signed-off-by: Miroslav Toth <mirtoth@cisco.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoAllow setting SB registration validity value 08/45808/3
Miroslav Toth [Mon, 19 Sep 2016 12:26:46 +0000 (14:26 +0200)]
Allow setting SB registration validity value

For integration testing it helps speed things up if we don't have to
wait the full 200 seconds to elapse before a southbound entry expires
(which is minimum allowed value to be set). This patch allows setting
values lower than 200 s as the southbound timeout, and logs a warning
when that happens.

Change-Id: I9532d74d85c5f519e09480e92c1f8f542fefcc93
Signed-off-by: Miroslav Toth <mirtoth@cisco.com>
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoWIP: Update Tutorial for FD.io and OOR 51/48451/2
Shakib Ahmed [Thu, 17 Nov 2016 18:16:23 +0000 (10:16 -0800)]
WIP: Update Tutorial for FD.io and OOR

Change-Id: I986b6e5873c74ed486fb07c9dda1e6ac5405b1ac
Signed-off-by: Shakib Ahmed <sheikahm@cisco.com>