Jozef Bacigal [Thu, 1 Jun 2017 11:16:32 +0000 (11:16 +0000)]
Merge "Improve flow collection"
Tomas Slusny [Thu, 1 Jun 2017 08:10:28 +0000 (08:10 +0000)]
Merge "Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation"
Jozef Bacigal [Thu, 1 Jun 2017 08:08:31 +0000 (08:08 +0000)]
Merge "Make create-parents in bulk-o-matic not required"
Jozef Bacigal [Thu, 1 Jun 2017 08:05:50 +0000 (08:05 +0000)]
Merge "Add missing convertors for OF1.0 actions"
Anil Vishnoi [Wed, 17 May 2017 21:46:19 +0000 (14:46 -0700)]
Bug 8497 - Provide config knob to disable the Forwarding Rule Manager reconciliation
Resolves: Bug 8497, Bug 7957
Change-Id: Ib798d9282f019e0c8dd520c15d8794678ee9af3d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Tomas Slusny [Tue, 30 May 2017 07:40:54 +0000 (09:40 +0200)]
Make create-parents in bulk-o-matic not required
To make bulk-o-matic input working like before, make create-parents
to default to true to use original functionality with same input
as it was before patch that introduced this new flag.
Change-Id: I89ee7d299f0ade62bd6859209c537528e5728aa7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 15 Mar 2017 17:23:22 +0000 (18:23 +0100)]
Improve flow collection
- Delete all known flows synchronously
- Add boolean isTransactionsEnabled to TxFacade to determine if it was
initialized and initial submit was called
- Improve deletion of flows during on the fly statistics gathering (now,
each gathering have 3 states, INITIALIZATION, WORKING and TERMINATION
and behaves according to that)
- Fix possibility of statistics collection freeze when error occurs
during OF Java to OF Plugin model translation while gathering
statistics on the fly
Resolves: bug 7501
Change-Id: I74843d4536215c192ac43964634502430da1aa9a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 26 May 2017 07:22:40 +0000 (07:22 +0000)]
Merge "Bug 8253: Set-Field can not accept vendor extension fields."
Li Guosheng [Mon, 8 May 2017 02:58:31 +0000 (10:58 +0800)]
Bug 8253: Set-Field can not accept vendor extension fields.
The various Set-Field actions are identified by their field type
which defined in OpenFlow Specification. It will be failed if we
pass a vendor extension field to Set-Field, that means Set-Field
can not accept those vendor extension fields. There are products
that hope Set-Field can accept those vendor extension fields, so
it will make sense to make Set-Field extensible.
Change-Id: Id25456d2b9008ec260ce81d3a459bdc471a69e49
Signed-off-by: Li guosheng <li.guosheng6@zte.com.cn>
Anil Vishnoi [Thu, 25 May 2017 18:17:25 +0000 (18:17 +0000)]
Merge "Bug 8535: Fix IPv6 OXMHeader Mask issue"
Anil Vishnoi [Thu, 25 May 2017 18:16:40 +0000 (18:16 +0000)]
Merge "Add Nicira extension support for matching IPv6 Src/Dst"
Tomas Slusny [Tue, 23 May 2017 12:05:43 +0000 (14:05 +0200)]
Add missing convertors for OF1.0 actions
- SetDlSrc
- SetDlDst
- SetNwSrc
- SetNwDst
- SetNwTos
- SetTpSrc
- SetTpDst
- SetVlanId
- SetVlanPcp
Resolves: bug 8527
Change-Id: I9c7c97804d077e1089fe92b3465c826a43da6a33
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Wed, 24 May 2017 01:04:26 +0000 (01:04 +0000)]
Merge "Adding Reason Attribute to FlowCapableNodeConnector"
Sridhar Gaddam [Tue, 23 May 2017 12:57:09 +0000 (18:27 +0530)]
Bug 8535: Fix IPv6 OXMHeader Mask issue
When programming an OVS flow to set an ipv6_src/dest as
an action field (i.e., set_field:2001::1->ipv6_src), the
current implementation is not checking the Mask and is
including the Mask (even for a full ipv6 address) in the
OXM header. Because of this, switch is rejecting the flow
with the following error.
"decode error: OFPBAC_BAD_SET_MASK. OXM header 0:32768:26:1:32
includes mask but masked OXMs are not allowed here"
This patch addresses this issue by checking the prefix and
including the prefix only if applicable.
Change-Id: Ieffdc7f0e74e9418156171d85a28c24dd336527c
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Michael Vorburger [Tue, 23 May 2017 12:00:03 +0000 (14:00 +0200)]
Replace target/ by ${project.build.directory}/ for target-ide/
This makes openflowjava work e.g. in Eclipse IDE out-of-the-box (using
https://github.com/vorburger/opendaylight-eclipse-setup configuration),
without any red (after a "mvn -Pide clean generate-sources").
This is how all other projects do it; I just copy/pasted from elsewhere.
Change-Id: I908357974a930d249f3c37d3cb9591dbffb8f5bb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Wed, 10 May 2017 22:48:27 +0000 (00:48 +0200)]
Remove <prerequisites> from pom.xml to avoid WARNING
[WARNING] The project ... uses prerequisites which is only intended for
maven-plugin projects but not for non maven-plugin projects. For such
purposes you should use the maven-enforcer-plugin. See
https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
This is already done in odlparent.
Change-Id: Iaefcd3729d5600aef49f3c3c653676ad962d9838
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Jozef Bacigal [Thu, 18 May 2017 11:43:10 +0000 (11:43 +0000)]
Merge "Fix logging of exception in HandshakeListenerImpl"
GauravBhagwani [Tue, 7 Feb 2017 08:29:25 +0000 (13:59 +0530)]
Adding Reason Attribute to FlowCapableNodeConnector
-The reason attribute is added to the FlowCapableNodeConnector Yang
Modelling.
-The PortStatus contains reason when notification comes from Switch such
as ADD, UPDATE, DELETE.
-This reason flied will help in distinguishing between different
PortStatusMessages
-Also changed TestCase File to include Reason for test cases
Change-Id: If61fc1ba0afbe56cbf5382ab3997c67166989819
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
Jozef Bacigal [Wed, 17 May 2017 07:51:46 +0000 (09:51 +0200)]
Remove lifecycle service from tx chain manager
Change-Id: I6e9f1d7dbdfbdcca5cd52c368985ba7d37310a74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 16 May 2017 15:09:29 +0000 (17:09 +0200)]
Fix logging of exception in HandshakeListenerImpl
Exception was not logged, so in case initial processing failed and
thrown exception, there was no exception actually shown in log. To
properly log exception, it needs to be either passed as second parameter
or inserted into message via logger string interpolation ({}).
Change-Id: Ic76f6d20588e34837994b50509603d994009b705
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 24 Apr 2017 07:15:36 +0000 (09:15 +0200)]
Write port statistics when needed
When we receive port statistics reply, sometimes in OF 1.0 we do not
have parent node written to datastore, so now when OpenFlow version is
1.0 then write those port statistics with parents if needed.
Replace gathering missing port statuses with PORT_DESC with registry
that will collect missed port statuses when on MASTER.
Resolves: bug 8239, bug 6908
Change-Id: I47468cb37fa59a68cfa89efeb7e5c4191e07039d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Mon, 15 May 2017 22:56:51 +0000 (22:56 +0000)]
Merge "Remove device without master from DS."
Anil Vishnoi [Mon, 15 May 2017 22:52:59 +0000 (22:52 +0000)]
Merge "Add timeout for device initialization"
Tomas Slusny [Mon, 15 May 2017 13:22:57 +0000 (13:22 +0000)]
Merge "Bug 8408 - Deserialization exception in logs when NAT flows are added."
Aswin Suryanarayanan [Tue, 9 May 2017 14:41:42 +0000 (20:11 +0530)]
Bug 8408 - Deserialization exception in logs when NAT flows are added.
The code is modified to fix the issues with multiple CT actions.
The logic skip padded bit is added during Deserialization
Change-Id: Ic5574f0a877228d966ca92eacfa22c751fa14b3c
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Tomas Slusny [Thu, 11 May 2017 08:57:09 +0000 (10:57 +0200)]
Add timeout for device initialization
Sometimes during device initialization, switch starts ignoring all
messages from plugin, and so we ended up with Future that waited
indefinitely for switch response until Karaf was restarted.
Add timeout that will prevent happening of above issue.
See also: bug 8401
Change-Id: I90c6c8b53f6a6e879b6d9f93c259a2cbf09f71d3
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Sun, 14 May 2017 08:51:48 +0000 (08:51 +0000)]
Merge "Though shall not use org.eclipse.tycho's osgi.. you don't even need it!"
Michael Vorburger [Thu, 9 Feb 2017 00:24:41 +0000 (01:24 +0100)]
Though shall not use org.eclipse.tycho's osgi.. you don't even need it!
see https://git.opendaylight.org/gerrit/#/c/51592/
see https://git.opendaylight.org/gerrit/#/c/51520/
There are 2 remaining use of org.eclipse.tycho in openflowplugin's
drop-test and test-provider, something related to console commands...
could we ask you if you would mind to change that to use
the Karaf Console API instead? Or delete those? ;)
I'll like to block use of dependency tycho in odlparent ASAP.
Change-Id: Ifccbd7f6ec463487e83aa546701cdffd1c7accb4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sridhar Gaddam [Fri, 12 May 2017 15:29:07 +0000 (20:59 +0530)]
Add Nicira extension support for matching IPv6 Src/Dst
This patch implements the necessary support for programming a reg_move action
(i.e., move:NXM_NX_IPV6_SRC[]->NXM_NX_IPV6_DST[]) with IPv6 source/destination
headers. It will be used while constructing OVS flows that auto-respond to ping6
requests addressed to a router-interface.
Change-Id: I64757f55ed1d30a12217c4a5aadaa3f56572ab0e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Jozef Bacigal [Fri, 12 May 2017 08:41:37 +0000 (10:41 +0200)]
Fix queue and xid issue
Change-Id: Idef52a9243d9b2b9ac7028386422f0acc580c07d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 11 May 2017 11:10:25 +0000 (13:10 +0200)]
Fix no reserved xid
Change-Id: I153df3f1d3df895e2780a77dd6ed04e43bbc9599
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Thu, 11 May 2017 13:46:30 +0000 (13:46 +0000)]
Merge "Remove unused method"
Jozef Bacigal [Thu, 11 May 2017 11:32:19 +0000 (13:32 +0200)]
Remove unused method
Change-Id: I02e3d48f2ccca528995b18cb159700ab08449862
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Vishnoi [Wed, 10 May 2017 18:24:46 +0000 (18:24 +0000)]
Merge "Bug 8293: Add table writer to bulk-o-matic"
Tomas Slusny [Wed, 10 May 2017 14:12:48 +0000 (16:12 +0200)]
Handle missing converters for match extensions
Prevent throwing NullPointerException when converter for match
entry extension is missing, instead throw warning and allow process
to continue (like it was before single-layer-serialization).
See also: bug 8401
Change-Id: If006eef401da4b9bf61911c183e76876fac0dfcf
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 5 May 2017 15:05:36 +0000 (15:05 +0000)]
Merge "Remove unnecessary method from abstract class."
Jozef Bacigal [Fri, 5 May 2017 12:55:39 +0000 (14:55 +0200)]
Remove unnecessary method from abstract class.
Change-Id: I23de0d1973418854c6fce039f6e694ed13c1d04b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Fri, 10 Feb 2017 13:23:43 +0000 (14:23 +0100)]
Change sal bundle yang model
- Put messages to message container
Change-Id: Ie86d70bf070ca16659f02ba536655c6e6f1682af
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
miroslav.macko [Wed, 8 Feb 2017 17:01:20 +0000 (18:01 +0100)]
Update BundleAddMessageConverter
- Update serialization
- Set Xid and Node
Change-Id: Ie7f9a0d99dc348c71212a9cc0a53893f29ff971e
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 7 Feb 2017 08:21:20 +0000 (09:21 +0100)]
Change yang models due to errors
- Added container for cases where was duplicate declaration of fields.
- Renamed cases to not to have duplicate name of interfaces.
- Renamed wrong spelled "Convertor" to "Converter".
- Fixed tests. (Ignored, fixed in following patches)
- Added nbactions.xml to gitignore (netbeans help file)
Change-Id: Ie268f9d8a697097e3892196e26442c917026b993
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Faiz Ilahi Kothari [Thu, 9 Feb 2017 05:57:43 +0000 (11:27 +0530)]
Bug 8293: Add table writer to bulk-o-matic
* Table writer is introduced for Pre-Leader Role test in which
table is added first and flows next. We want the ability to
create tables separately and not to be created automatically
on addition of flows.
* Modify flow-test rpc to accomodate a boolean: create-parents.
This allows us to prevent addition of flows in case the tables
are missing.
* Fix import ordering
Change-Id: Ic3fe4764631d9cbc7550ad3d7d926debb3ca6977
Signed-off-by: Faiz Ilahi Kothari <faiz.ilahi.k.kothari@ericsson.com>
Jozef Bacigal [Tue, 24 Jan 2017 14:32:41 +0000 (15:32 +0100)]
Add BundleControl converter from OFJ
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I57709f7d089e651525ddc65a4a51a68f39f38772
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 14:09:45 +0000 (15:09 +0100)]
Update bundle extension tests
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If4b197b8ecf334286d4bb01748b8b622c2112182
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:47:09 +0000 (13:47 +0100)]
Add BundleAddMessageConvertor
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: If6bc0a657c04e95454a3576a5707ddd00a16b38e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 12:42:10 +0000 (13:42 +0100)]
Add BundleControl converter
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I850e5119bd4ee7d73222dd90bf1e28e4a19916a8
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:45:36 +0000 (10:45 +0100)]
Add simple SalBundleService
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I1457d7988b68a8eb74928088e253fc5f523d29c4
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 09:35:46 +0000 (10:35 +0100)]
Add Bundle and Error (ONF-extension) deserializers
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I583e15333df3811adf47ba174b4f593946be7d39
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:56:34 +0000 (08:56 +0100)]
Add Bundle messages serialzers
- moved from openflowjava
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I36e7600f15d1a5d345e62cd4f42c0f0f999ae588
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 24 Jan 2017 07:54:35 +0000 (08:54 +0100)]
Add model for ONF bundle extension
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I17e22dadb910ed76ba6ccfae711a81fd0856762f
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 23 Jan 2017 13:30:48 +0000 (14:30 +0100)]
Add ONF extension provider and wire via blueprint w/OFP
Reference: ONF approved extension #230
Resolves: Bug 6806
Change-Id: I49d08c82d4b973b888939aff2a4cd110289c9fe3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 28 Apr 2017 07:42:15 +0000 (09:42 +0200)]
Remove device without master from DS.
See also: Bug-6459
Change-Id: I6d27681b60a75df173a49742885c75c16d691b26
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 11 Apr 2017 15:52:16 +0000 (17:52 +0200)]
Fix no match serialization
This patch ensures that even when match in flow is null, at least empty
match is sent to device.
Change-Id: If77c59b889e45698da4b96f098088cdbdf4698ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Tue, 25 Apr 2017 08:26:50 +0000 (08:26 +0000)]
Merge "Bug 8217: Set error information into direct statistics RPC result."
Tomas Slusny [Tue, 25 Apr 2017 07:47:20 +0000 (07:47 +0000)]
Merge "Bug 8223: Fixed incorrect enable-flow-removed-notification check."
Tomas Slusny [Mon, 24 Apr 2017 10:23:59 +0000 (12:23 +0200)]
Prevent changing single-layer-serialization on fly
Prevent changing use-single-layer-serialization config
parameter on the fly, allow it only during initialization.
Resolves: bug 8278
Change-Id: Idfd2f7aa99fdf330bc32615431b4378209c83fda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 24 Apr 2017 07:07:30 +0000 (07:07 +0000)]
Merge "Improve property-based configuration"
Tomas Slusny [Tue, 21 Mar 2017 18:17:22 +0000 (19:17 +0100)]
Improve property-based configuration
- Add OpenFlowPluginConfigurationService. This service can control
updating of OpenFlowPlugin configuration (skip-table-features etc.)
in initialization phase and also on the fly.
- Comment out default settings in org.opendaylight.openflowplugin.cfg
because with all default values set in that file, we are ignoring
values specified in openflow-provider-config.yang.
- Add support for missing configuration values from
openflow-provider-config.yang to OpenFlowPluginConfigurationService
- Remove changeable configuration values that was passed to some
OpenFlowPlugin class implementations to both constructors and setters
from constructors to prevent code duplicity and to simplify code a bit
Now, when feature is installed,
default values are taken from openflow-provider-config.yang, then we
check if we have org.opendaylight.openflowplugin.cfg file in karaf/etc/
(blueprint will do this for us) and try to read it as map. Then we will
pass this map to update method, that will iterate over this map and
parse it's keys and values and calls appropriate update methods in
OpenflowPluginProviderImpl based on key
(f.e skip-table-features will call
OpenflowPluginProviderImpl#updateSkipTableFeatures).
When org.opendaylight.openflowplugin.cfg file is changed, we receive
notification about it in form of
OpenFlowPluginConfigurationService#update method call, and we will
repeat same procedure as during initialization (parse map passed as
argument to this method and update configuration).
Resolves: bug 7218
Change-Id: Ida986f7dfffe55a90ddb6f354f0addf56c3c4b90
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Thu, 13 Apr 2017 11:12:19 +0000 (20:12 +0900)]
Bug 8223: Fixed incorrect enable-flow-removed-notification check.
flow-removed notification needs to be published if
DeviceManager.isFlowRemovedNotificationOn() returns true.
Change-Id: I10c025f11e14670303b70bf31d3a9cefa5a676ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit
644f1bbd99d4fd949800fb3167d11d4ce968c950)
Tomas Slusny [Mon, 27 Mar 2017 14:59:24 +0000 (16:59 +0200)]
Ignore early port status msg and process it later
When port status message arrives before we got MASTER role,
ignore it. Then, after receiving mastership collect PORT_DESC statistics
again to make sure we do not missed any port status messages in process
Resolves: bug 6908
Change-Id: I01285ed4880533f48bf90fa7c6a4ca2c7d3a210f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Shigeru Yasuda [Wed, 12 Apr 2017 14:01:23 +0000 (23:01 +0900)]
Bug 8217: Set error information into direct statistics RPC result.
Change-Id: I3fdf51b94bf95afefa47dddea37a82b8f139af95
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Anil Belur [Tue, 11 Apr 2017 01:45:52 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I69b8fcbaf59487fae8564634aebfb52c6951101a
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Tomas Slusny [Mon, 13 Mar 2017 13:27:55 +0000 (14:27 +0100)]
Update multipart request services for single layer
Update all single layer services that was sending OpenFlowJava
multipart requests to send OpenFlowPlugin multipart requests
instead to avoid translations.
Remove failing tests from NodeConnectorRefToPortTranslatorTest. These
tests are not needed anymore, since now JUnit auto-handles @NonNull
annotations.
See also: bug 6915
Change-Id: I427a6148e67d61080a85de5c304f478df0e26682
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Wed, 1 Mar 2017 15:38:29 +0000 (16:38 +0100)]
Add multipart request message serializers
- Add serializers for multipart request and it's subtypes
- Add YANG models for multipart request and it's subtypes
See also: bug 6915
Change-Id: I465c23a6fc3bea0cf944bbe8e6f75e17833d4449
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Tue, 4 Apr 2017 12:00:23 +0000 (14:00 +0200)]
Add timer and auxiliary connection
- added time to check if all devices are master or slave.
- auxiliary connection is no more dropped but stored.
Change-Id: I720f90f70631de0fddea8eaeaa39c2186c90db20
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 3 Apr 2017 09:56:43 +0000 (11:56 +0200)]
Fix startup.
Change-Id: Ia3488423f70b045c766692205c947e078af9a8f7
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 31 Mar 2017 09:33:57 +0000 (11:33 +0200)]
Clean up
- removed yang configuration
- moved yang enum to java enum
- changes in txChain for initial gathering
Change-Id: I8b37bb40374cd1c861252a320b1ff83ab86d2d74
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 24 Mar 2017 11:20:40 +0000 (12:20 +0100)]
Fix after FRM changes.
Change-Id: I3ed9764d1b7d65f6e70b9d87a38125da30d2ffb6
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 20 Mar 2017 10:33:23 +0000 (11:33 +0100)]
Remove unneccessary code
Change-Id: I4fa5afa56ab17cff88b81ef57c8ed05fed650aee
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 14 Mar 2017 13:11:32 +0000 (14:11 +0100)]
Remove to set all devices slave.
- wait 5 seconds for obtaining master
- if not set as slave
- clean up
Change-Id: Ie4be0290f76714ff749145ffd31e11ea5a98aa0c
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 8 Mar 2017 14:55:00 +0000 (15:55 +0100)]
Add EOS listener.
Change-Id: I93d7364e097c100f1677b392726019a4058bcc9d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 10 Feb 2017 08:28:29 +0000 (09:28 +0100)]
Change dropping mastership.
Change-Id: I6bd5f67e72dea7415e08a0de557cc5900d16a308
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 7 Feb 2017 09:00:15 +0000 (10:00 +0100)]
Update ttl timers for 1s.
Change-Id: I17ab28c99fcdf743e1c19d580451e90cc4890b00
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 26 Jan 2017 13:45:34 +0000 (14:45 +0100)]
Fix bug when device does not get role after reconnect.
Change-Id: I6a00c803c34de5d9452d1eb18e9dae617d46e2e4
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 18 Jan 2017 08:14:17 +0000 (09:14 +0100)]
Add tests.
- part 1, changes need to be made to properly test it.
Change-Id: I13b6f9773406c4fc04c3863994d3c01e67a27531
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 16 Jan 2017 08:17:47 +0000 (09:17 +0100)]
Add posibillity to never drop context chains.
Change-Id: Id4c7814899a9403304a4ed230750f1595b45f9cc
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 11 Jan 2017 14:47:32 +0000 (15:47 +0100)]
Fix problem with unregistering from cluster services.
Change-Id: If1b7f5118c1834204c6676b9130bf23d2cb95328
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 10 Jan 2017 15:04:05 +0000 (16:04 +0100)]
Fix several issues with disconecting device
Change-Id: I29a0b08643fce88599a1d3e76d0f382369127780
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 9 Jan 2017 14:43:53 +0000 (15:43 +0100)]
Add disconect login after time to live is up.
Change-Id: Icf90cd0154b2f1afbec8c5956f30595d4a948d29
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Tue, 20 Dec 2016 14:40:14 +0000 (15:40 +0100)]
Repair style check for new classes.
Change-Id: I02f6d0ec3a122e41ad750520a65eaee7e9a7c64e
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Wed, 14 Dec 2016 16:15:24 +0000 (17:15 +0100)]
Disconnection improvements.
Change-Id: I547bf7fab3604e8b7dad8ce8964528b3cbc05998
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Mon, 12 Dec 2016 12:44:28 +0000 (13:44 +0100)]
Add mastership listener to Initialization callbacks.
Change-Id: I743feb5429578ffe571bc366786d317efa0cacfa
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 1 Dec 2016 13:51:12 +0000 (14:51 +0100)]
Implement connection core layer basic behavior
Change-Id: Ibc4882ce67d0db2ad4ccf6ce070f25126e3fb1a0
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Tomas Slusny [Tue, 28 Mar 2017 11:06:04 +0000 (13:06 +0200)]
Fix DeviceFlowRegistry performance regression
- Remove use of marks and modify DeviceFlowRegistry immediately
- Synchronize only access to DeviceFlowRegistry BiMap and not
entire class
- Replace custom match comparison with match normalization (should be a
lot faster on big amount of flows)
- When logging to console, compute FlowRegistryKey hashes only when needed
See also: bug 6917
Change-Id: I25e12a8254b75063e4fdc840eddd70386e3b0f26
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 3 Apr 2017 08:06:05 +0000 (08:06 +0000)]
Merge "Add missing karaf 4 features to artifacts"
Jozef Bacigal [Mon, 3 Apr 2017 07:26:49 +0000 (07:26 +0000)]
Merge "BUG-7622: Karaf 4 Migration"
miroslav.macko [Fri, 31 Mar 2017 09:40:35 +0000 (11:40 +0200)]
Add missing karaf 4 features to artifacts
See also: BUG-7622
Change-Id: I8afab9271a50469073168827db68e9b296cead15
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Fri, 31 Mar 2017 07:53:18 +0000 (07:53 +0000)]
Merge "Fix table miss flow push"
Claudio D. Gasparini [Wed, 29 Mar 2017 11:03:49 +0000 (13:03 +0200)]
BUG-7622: Karaf 4 Migration
Add missing karaf 4 features to artifacts.
Change-Id: I907afa3a31b44412ae3ffa6ba3cca9ab81695b07
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Jozef Bacigal [Thu, 30 Mar 2017 14:52:34 +0000 (14:52 +0000)]
Merge "Replace project-specific checkstyle by odlparent's"
Jozef Bacigal [Thu, 30 Mar 2017 14:52:10 +0000 (14:52 +0000)]
Merge "Fix minor issues regarding checkstyle"
Jozef Bacigal [Thu, 30 Mar 2017 14:51:21 +0000 (14:51 +0000)]
Merge "Fix modifiers order to comply with Java coding guidelines"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:24 +0000 (14:49 +0000)]
Merge "Fix checkstyle .api.openflow.protocol"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:19 +0000 (14:49 +0000)]
Merge "Fix checkstyle api.openflow.md.util"
Jozef Bacigal [Thu, 30 Mar 2017 14:49:08 +0000 (14:49 +0000)]
Merge "Fix checkstyle - api.openflow.md.queue"
Jozef Bacigal [Thu, 30 Mar 2017 14:48:57 +0000 (14:48 +0000)]
Merge "Fix checkstyle warnings."
Jozef Bacigal [Thu, 30 Mar 2017 14:48:52 +0000 (14:48 +0000)]
Merge "Fix checkstyle warnings"
Jozef Bacigal [Thu, 30 Mar 2017 14:03:32 +0000 (14:03 +0000)]
Merge "BUG-7901: fix unsynchronized transaction access"
Robert Varga [Tue, 28 Mar 2017 15:29:16 +0000 (17:29 +0200)]
BUG-7901: fix unsynchronized transaction access
The evidence in the issue indicates that we have a race condition
where a batch of modifications is being submitted (triggered by
a write/delete and exceeded batch count) and we are observing a
concurrent modification. After auditing the CDS side of this, while
we can improve safety a bit, the scenario has to involve multi-threaded
access by the client.
Looking at TransactionChainManager, it seems to be heavily synchronized,
but there is a hole in the paths which are using getTransactionSafely().
While the access to the TransactionChain, it returns the transaction
(which really is an alias to the wTx field). That throws of static
analysis, as we end up the object pointed to by wTx without holding
the lock -- hence concurrent threads will end up touching the transaction
without any guards, leading to a violation of Transaction contract (which
requires external synchronization).
This patch reworks getTransactionSafely() so it only ensures the field
is initialized as appropriate and makes its callers access the wTx field
with the proper lock held.
Bug: 7500
Bug: 7901
Bug: 8060
Change-Id: I058feb55f91a40ccda6d69ee87cd1a20f792afba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tali [Mon, 27 Mar 2017 10:19:32 +0000 (13:19 +0300)]
Fix masked NXM reg length
Change-Id: I0ed5fe6a2db52521b13d0943d8b25911d5ac5fe9
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Jozef Bacigal [Mon, 27 Mar 2017 07:36:52 +0000 (09:36 +0200)]
Fix checkstyle .api.openflow.protocol
Change-Id: Ib7a3b2eebe4aae5a2662574817b41642486f662b
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>