Robert Varga [Thu, 7 Dec 2023 11:55:48 +0000 (12:55 +0100)]
Rename DOMDataBrokerExtension to DOMDataBroker.Extension
Move the extension marker to its base service.
JIRA: MDSAL-841
Change-Id: I39efe057322b2bed8a2704c0666ce16d1c457d38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Dec 2023 11:47:55 +0000 (12:47 +0100)]
Rename DOMSchemaServiceExtension to DOMSchemaService.Extension
Move the extension marker to its base service.
JIRA: MDSAL-841
Change-Id: I59c204d6663714daffa3059da3ebb9b9e498c49f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 24 Nov 2023 19:56:45 +0000 (20:56 +0100)]
Merge DOMExtensibleService into DOMService
yangtools.concepts.ExtensibleObject provides a generalized view on what
we are trying to achieve here.
This patch adopts it into DOMService, forcing all DOMServices to define
their type-safe Extension point.
This has a side-effect that multiple DOMServices cannot be implemented
by the same object, forcing DOMNotificationRouter to split out its
component services.
JIRA: MDSAL-841
Change-Id: I355fbe82cf913af7682432611b5f25773832a9ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Dec 2023 09:10:38 +0000 (10:10 +0100)]
Remove DOMRpcRouterServices
Expose DOMRpcRouter as the endpoint without an intermediate interface.
This allows us to neatly increase the scope of OSGiDOM*Service classes
so they work with other dependency injection mechanisms.
JIRA: MDSAL-842
Change-Id: I88d86b23c78defb37f476389002d850a995e9a90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Dec 2023 02:38:45 +0000 (03:38 +0100)]
Make sure listeners are immutable
We guarantee DOMNotificationRouter.listeners to be immutable. Make sure
the field has the correct type to prevent confusion.
Change-Id: Ia4b86c00bdd0517182d4ec0ad63b7f903d3c4ee7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 18:28:21 +0000 (19:28 +0100)]
Bump Xtend to 2.33.0
https://eclipse.dev/Xtext/releasenotes.html#/releasenotes/2023/11/21/version-2-33-0
Change-Id: I926f2981d05af6f3cc7da5825377312dfe574c83
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:43:25 +0000 (17:43 +0100)]
Clean up DOMNotificationRouterEvent
Use Empty instead of Void to reduce proliferation of nulls.
Change-Id: I39753a0deccf588578a2875b8bac40d02bd34129
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:39:24 +0000 (17:39 +0100)]
Clean up DOMNotificationRouter.NO_LISTENERS
Use Futures.immediateFuture() with Empty.value() to reduce reliance on
FluentFuture and null values.
Change-Id: I8233a4227e38753531994c13feb9e580c03f66d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:38:23 +0000 (17:38 +0100)]
Clean up DOMNotificationPublishService.REJECTED
Reduce qualifier from <Object> to <?>, so that the value remains
completely opaque. Also add a @NonNull annotation.
Change-Id: I99d0e04327bcf9b67ec6b1f760e2dec24fc70ffa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:30:55 +0000 (17:30 +0100)]
Clean up DOMNotificationRouter
Remove create() method, as it has been deprecated long time ago.
Also use local variable type inference to reduce verbosity and adjust
tests to use try-with-resources.
Change-Id: Ibccaeeabb19d7f2e3440246dac62c2175817c030
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:17:30 +0000 (17:17 +0100)]
Remove Naming.NOTIFICATION_LISTENER_SUFFIX
This constant was used only by aggregate NotificationListeners, remove
it.
JIRA: MDSAL-497
Change-Id: I2be5a92934e5bccb7816ee2d95acc8044e7066a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:15:36 +0000 (17:15 +0100)]
Remove Naming.RPC_SERVICE_SUFFIX
This constant was only used for ynag.binding.RpcService implementations,
remove it.
JIRA: MDSAL-772
Change-Id: I0b222743c8466e55cdfedd9974046dcfaaf37673
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:13:55 +0000 (17:13 +0100)]
Clean up BindingDOMNotificationPublishServiceAdapter
Remove deprecated method and address the two FIXMEs which are long
overdue.
Change-Id: I27354cd2d530268473236ba823afec162bfd2cc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 16:11:28 +0000 (17:11 +0100)]
Remove deprecate DOMRpcResult methods
getErrors() and getResult() were deprecated in previous major release,
remove them now.
Change-Id: I234c649dcd45e9b4ac38c7d5415de64249e95db9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 6 Dec 2023 13:50:55 +0000 (14:50 +0100)]
Remove deprecated constructor
We require only a simple Executor, simplify things accordingly.
Change-Id: I94b89d2b7bf4d7cee65a30cf4635a01923b6db61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 24 Nov 2023 15:00:17 +0000 (16:00 +0100)]
Remove SuppressFBWarnings from InstanceIdentifier
Define readObject()/writeObject() methods that enforce Serializable
Proxy pattern, which in turn silences SpotBugs.
Change-Id: Ic7c5f523adc5e0df7e9a2767f93fcadd3bc77c8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 15 Nov 2023 14:19:18 +0000 (15:19 +0100)]
Remove two spotbugs suppressions
Let's not use @NonNullByDefault and instread sprinkle @NonNull --
allowing us to ditch two suppression.
Change-Id: I779fe4925da8ef3c9eccbdc8e61381162e576ba8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 15 Nov 2023 14:16:02 +0000 (15:16 +0100)]
Move PingPongTransctionChain.LOG
Remove @SuppressFBWarnings by moving the logger (and changing its
identity).
Change-Id: I2865e2dc59e59081c0fb07b1b24d8148740ee94f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 14 Nov 2023 14:17:12 +0000 (15:17 +0100)]
Move StatementNamespace to yang.binding.contract
This enumeration forms a part of the binding naming contract, move it to
yang-binding.
Change-Id: I8fe170d5791ff36c5c1728b0ea7112b178e3d808
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 14 Nov 2023 11:53:58 +0000 (12:53 +0100)]
Remove support for composite NotificationListener
We have a much more flexible mechanism for dealing with notifications
via the Notification interface, which is a proper FunctionalInterface.
Remove support for aggregated moduled-level FooListener interfaces.
JIRA: MDSAL-497
Change-Id: I7dd82c477de6ca836cce84354c016d5ebd21022d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 14 Nov 2023 10:59:35 +0000 (11:59 +0100)]
Rename RpcConsumerRegistry to RpcService
Now that we have removed yang.binding.RpcService, we can reuse that name
in mdsal-binding-api.
JIRA: MDSAL-779
Change-Id: I59e23a7e31825407b6b7fc9431f0e960e2b87864
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 26 Oct 2023 22:35:19 +0000 (00:35 +0200)]
Remove yang.binding.RpcService
RpcService is a base marker for generated interfaces representing
the collection of 'rpc' statements in a module.
This interface and its uses have been deprecated, as their design
assumptions are based on Java 7, that is do not consider lambdas.
Since we have yang.binding.Rpc and related interfaces to cleanly
represent RPCs in lambda-cognizant world, remove RpcService and all its
related codegen/runtime support.
JIRA: MDSAL-772
Change-Id: I41b3c6513869a43b6373ad588336ebed2dc873d4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 21 Oct 2023 04:59:08 +0000 (06:59 +0200)]
Seal LeafReference
We only want to access this interface through specializations, express
that through sealing it.
Change-Id: I2586005b482e4b25427c93ae9bca11bf772ae613
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 13 Nov 2023 15:47:23 +0000 (16:47 +0100)]
Bump versions to 13.0.0-SNAPSHOT
This starts the next major development version.
Change-Id: I4f549a7b19adea7ab284fea0278db79468ef20c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 30 Oct 2023 21:21:28 +0000 (22:21 +0100)]
Bump versions to 12.0.4-SNAPSHOT
This starts the next development iteration.
Change-Id: I22fefd3c8ae76998cd879391b322adeb61a0c9b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 30 Oct 2023 16:12:11 +0000 (17:12 +0100)]
Bump upstreams
Adopt:
- odlparent-13.0.7
- yangtools-11.0.4
Change-Id: Iaa314dfdca3513a67d9a1b8cb895554172071441
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 21 Oct 2023 03:43:30 +0000 (05:43 +0200)]
Make LambdaTarget a record
We have a FIXME for efficiency improvement, address it.
Change-Id: If09bdb15b83b5e83114435456f4e4d1df4344e0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Oct 2023 16:08:52 +0000 (18:08 +0200)]
Migrate rfc6991-ietf-yang-types to JUnit5
We have a single test here, which is trivial to migrate.
Change-Id: I871dc1813c59159300c9561a539cce299d7e8700
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Oct 2023 16:04:42 +0000 (18:04 +0200)]
Migrate rfc6991-ietf-inet-types to JUnit5
This is a trivial migration, except we also migrate hamcrest assertions
to assertInstanceOf().
Change-Id: I812ec1c4a885c9912afea41135ed767ce6436c0c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Oct 2023 15:57:41 +0000 (17:57 +0200)]
Migrate ietf-type-util to JUnit5
This is a straightforward automated conversion.
Change-Id: I307c021985090c59e8d41fc833427c0da9e7842f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
matus.matok [Thu, 20 Jul 2023 07:26:31 +0000 (09:26 +0200)]
Fix links in README
Fixed the links in README.md to use the correct markdown syntax.
JIRA: MDSAL-832
Change-Id: Iba195c6ee9191480b8cfb4c888fb82904ba3f37a
Signed-off-by: matus.matok <matus.matok@pantheon.tech>
Robert Varga [Tue, 17 Oct 2023 12:18:08 +0000 (14:18 +0200)]
Bump byte-buddy to 1.14.9
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.9
Change-Id: I254907a6467e8d3d76d165bd4f3c22a379545eb7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Šimon Ukuš [Wed, 22 Mar 2023 14:43:40 +0000 (15:43 +0100)]
Add docs for model registration with OSGi
JIRA: MDSAL-9
Change-Id: Id0c6c2071c14977caad31743253bbae8b6436755
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>
Robert Varga [Sun, 1 Oct 2023 23:29:00 +0000 (01:29 +0200)]
Bump upstreams
Adopt:
- odlparent-13.0.5
- yangtools-11.0.3
Change-Id: Ic5ae3e0bfa2359087ad4c8818794746489ab2e20
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 29 Sep 2023 16:03:18 +0000 (18:03 +0200)]
Fix NotificationListenerInvokerTest on Java 19+
We cannot mock MethodHandle, as it is a sealed class on Java 19+. Adjust
the test to use String.toString() as the source of the MH.
Change-Id: Ieab28fdec5c703c2fcad8b14cd95ea3f49bd2a21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 17 Sep 2023 11:53:18 +0000 (13:53 +0200)]
Bump versions to 12.0.3-SNAPSHOT
This starts the next development iteration.
Change-Id: Id25ee91d56adadb4dda0b0dbb57555a5f0a31b7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Sun, 17 Sep 2023 09:11:11 +0000 (09:11 +0000)]
Release mdsal
Robert Varga [Sat, 16 Sep 2023 11:11:17 +0000 (13:11 +0200)]
Bump byte-buddy to 1.14.8
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.8
Change-Id: Ica0c4632f81b6d11303409303ebe30245b63cc22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 16 Sep 2023 11:10:35 +0000 (13:10 +0200)]
Bump yangtools to 11.0.2
Pick up fixes and improvements from upstream.
Change-Id: I25d4724ac546438db4470925bb73e30c7f9cccea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 3 Sep 2023 19:59:41 +0000 (21:59 +0200)]
Make AbstractPingPongTransactionChain.close() idempotent
Expend one byte of state to track close() method, making sure it is
idempotent.
JIRA: MDSAL-838
Change-Id: Ie7bccb2c12ad9eadd948fc15244cc2b2b150a256
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 3 Sep 2023 20:13:23 +0000 (22:13 +0200)]
Migrate callers of deprecated DataTreeCandidateNode methods
DataTreeCandidateNode has deprecated a number of methods, migrate its
callers.
Change-Id: Ie190e4bfa6c4e37c3f242d9b6220a5dcc9e3d20d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 17:52:31 +0000 (19:52 +0200)]
Migrate mdsal-dom-api to JUnit5
Migrate and clean up tests.
Change-Id: Id437ae4ca4e93ca2b8ec38ed46a760fe2db4d157
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 19:19:39 +0000 (21:19 +0200)]
Migrate mdsal-common-api to JUnit5
This is mostly a trivial conversion, but we also expand the test suite
to increase coverage and assertions.
Change-Id: I6ad81c99cc153e2fee3cd937dba42371a98ea047
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 17:35:26 +0000 (19:35 +0200)]
Migrate mdsal-binding-api to JUnit5
Remove DataObjectModificationTest and migrate other tests to use JUnit5.
Change-Id: Ie341ae97344066a0627225e7ee56162bc27927ac
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 19:26:19 +0000 (21:26 +0200)]
Bump versions to 12.0.2-SNAPSHOT
This starts the next developement iteration.
Change-Id: I1cab2e06404eb6de3fb589fb07ba34f1695f98b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Wed, 30 Aug 2023 14:41:47 +0000 (14:41 +0000)]
Release mdsal
Robert Varga [Wed, 30 Aug 2023 12:07:25 +0000 (14:07 +0200)]
Bump upstreams
Adopt:
- odlparent-13.0.4
- yangtools-11.0.1
Change-Id: I292e6adbf213017d4dc9316e32ba60111ad7e60b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 13:06:45 +0000 (15:06 +0200)]
Fix mdsal-binding-dom-adapter checkstyle
Upgraded checkstyle is finding a few issues, fix them up.
Change-Id: Ifdafb339f112749b891ef288420e28af124b306e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 08:35:26 +0000 (10:35 +0200)]
Fix mergeParentStructure{Merge,Put} with augmentations
We need to pay attention to the result of normalization, as
AugmentationResult points to the parent YangInstanceIdentifier --
and hence we should just use it instead of peeling its last component.
JIRA: MDSAL-837
Change-Id: I7f108a6dff96a010f029b38b2cbba5548551b56e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 30 Aug 2023 09:47:20 +0000 (11:47 +0200)]
Clean up dependencies
We have quite a few warnings about used undeclared dependencies, clean
them up.
Change-Id: I768629694f426f99aaa32a53d19b18642b88a0bd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 29 Aug 2023 19:11:37 +0000 (21:11 +0200)]
Split out OperationInvocation
This should be a top-level class, even when it is a utility. Changes the
logger identity, but fixes a Sonar warning.
Change-Id: Id7777ac73b8e765df86349384f5f911f48562c00
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 29 Aug 2023 18:59:56 +0000 (20:59 +0200)]
Qualify nested interfaces
Fix Sonar warnings stemming from differing import policies:
Eclipse requires these references to be imported, whereas Sonar flags
them.
Use qualified refernces to eliminate the ambiguity.
Change-Id: Iac509fdd28b7520220a9f171b0d5fff0df306663
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 29 Aug 2023 18:58:51 +0000 (20:58 +0200)]
Merge if() statements
There is no point in having nested if() statements, merge them,
eliminating a Sonar warning.
Change-Id: I9a1e325c6366446858fe47fd4956d0754f9b9f19
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 29 Aug 2023 18:57:32 +0000 (20:57 +0200)]
Bind to org.eclipse.jdt.annotation
We are using these annotations with scope=compile, hence we can safely
binding to the classes at runtime. Fixes a few Sonar warnings.
Change-Id: I793b847d9d25086e32158f333d8c5c155e554568
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 29 Aug 2023 07:06:32 +0000 (09:06 +0200)]
Bump xtend to 2.32.0
https://eclipse.dev/Xtext/xtend/releasenotes.html#/releasenotes/2023/08/27/version-2-32-0
Change-Id: I1179a8129e379fe833a6e6487d22d6c7abad5362
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 28 Aug 2023 11:43:11 +0000 (13:43 +0200)]
Bump byte-buddy to 1.14.7
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.6
https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.14.7
Change-Id: Ia547a6bc735f5efa6d0420dc0261442f077e815d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 12:14:27 +0000 (14:14 +0200)]
Remove CommonDataObjectCodecContext.namespace()
This method is not used anywhere, remove it. This cascades to
CommonDataObjectCodecPrototype.getNamespace(), which is also unused and
removed -- trimming down the overall memory cost and the need to make up
a namespace.
Change-Id: Iefe432de785d0c7400dd5be87797c849e56c2f9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 11:42:31 +0000 (13:42 +0200)]
Unify yangPathArgumentChild()
We have two implementations which are doing essentially the same thing
-- except ChoiceCodecContext performs lookup twice. Reduce the amount of
codec duplication.
JIRA: MDSAL-805
Change-Id: I834bf66d92f8bf3ad8621be28ba3fbb39f52f9fc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 11:27:33 +0000 (13:27 +0200)]
Unify streamChild() implementations
The two implementations we have perform essentially the same thing, tie
them together.
JIRA: MDSAL-805
Change-Id: I303ae152987b4d478862874b4d9ee3fc8db4f7db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 08:03:04 +0000 (10:03 +0200)]
Revert "Convert model.ietf.rfc8040 to JPMS"
This reverts commit
f22f321bc45e37db18af4d3b1056d6fb24f29943. We are not
ready for this just now.
Change-Id: If9f58fb27747aef2c02bd9e291322d15b7be1ac7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 10:00:28 +0000 (12:00 +0200)]
Unify getStreamChild() implementations
We have two implementations, which essentially do the same thing. Unify
them in DataContainerCodecContext.
JIRA: MDSAL-805
Change-Id: I97db0a356c51472a30b206151426921f5ad550cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 11:12:15 +0000 (13:12 +0200)]
Fix mdsal-binding-dom-codec dependencies
We are using JDT annotations, declare that.
Change-Id: I1c4a6d112da9015fb3885e40c33bf27cd31246ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Jul 2023 09:43:40 +0000 (11:43 +0200)]
Remove superfluous documentation
DataContainerCodecContext implements contracts, there is no need to
re-state the same contract.
Change-Id: Ie1694ff61c61933df8811dcc39b23eca41cf6319
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 6 Jul 2023 00:51:22 +0000 (02:51 +0200)]
Convert model.ietf.rfc8040 to JPMS
Rather than being an automatic module, make this an explicit module.
Change-Id: Ifa58df2d9a3279252a1fb453fc7a3b7b49f1c620
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 6 Jul 2023 00:13:32 +0000 (02:13 +0200)]
Remove PMD/CPD configuration
We do not have PMD/CPD plugins configured, there is no need to disable
them.
Change-Id: I05a7ed5978eb54440b6d6009a9ea26af9b29926e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 4 Jul 2023 19:32:17 +0000 (21:32 +0200)]
Do not require ListeningExecutorService
SerializedDOMDataBroker can easily operate on any Executor with the
help of Futures.submit(). Drop the requirement to have a
ListeningExecutorService and operate on plain Executor.
Change-Id: I5e5bc1f0c7bfa93f443bc18755d48beafc22f7f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 21:31:58 +0000 (23:31 +0200)]
Sharpen DataContainerCodecContext generics
Now that RootCodecContext is gone, we can sharpen T to require
CompositeRuntimeType, eliminating a bit of weirdness.
Change-Id: I9f430ceeaa59baedcb7ea2b0e69ad279964eb6ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 20:51:28 +0000 (22:51 +0200)]
Fold RootCodecContext into BindingCodecContext
RootCodecContext exists only for two purposes:
- return for an empty YangInstanceIdentifier lookup
- ease of InstanceIdentifier lookup
In order to fulfill these two roles, it ends up twisting the
BindingDataObjectCodecTreeNode contract in rather nonsensical ways,
preventing a number of further evolutions of the API.
Fold its functionality into BindingCodecContext, eliminating it from the
class hierarchy.
Change-Id: I44a49b78ed9ae418c5c85e48e9441fa1ec1e9862
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 30 Jun 2023 08:11:01 +0000 (10:11 +0200)]
Bump versions to 12.0.1-SNAPSHOT
This starts the next development iteration.
Change-Id: I7a73013e69e31b3bea46a44afa9e5e7a05b4a711
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
jenkins-releng [Thu, 29 Jun 2023 22:25:23 +0000 (22:25 +0000)]
Release mdsal
Robert Varga [Thu, 29 Jun 2023 19:01:03 +0000 (21:01 +0200)]
Add interfaces for (Normalized)YangData codec
We are lacking the ability to transcode yang.binding.YangData to
NormalizedYangData. This patch adds the baseline interfaces required
along with disabled tests.
JIRA: MDSAL-805
Change-Id: I026240e553ffe3415466f94cb1e3f206eb5a3a0c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 14:47:16 +0000 (16:47 +0200)]
Split up CodecDataObjectAnalysis
CodecDataObjectAnalysis contains two things: the indexing of children
and then the generated class. We need to split these up, so we can
actually plugin in YangData (which needs to former) into the mix.
JIRA: MDSAL-805
Change-Id: Ic38cbf1be4b4011ae5dd983d1826e020a67620c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 14:39:19 +0000 (16:39 +0200)]
Reduce unchecked warnings
We do not need DataObject specialization, which solves a few warnings
around casting.
JIRA: MDSAL-805
Change-Id: I1d4ef9938ae75bff182e4f1bfad8d7caaae4a313
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 16:23:02 +0000 (18:23 +0200)]
Split out BindingDataContainerCodecTreeNode
DataContainer contract is well-known and used all over the place. Split
it out so it can be implemented separately. This also reworks codec's
internal type hierarchy to make place for
BindingDataContainerCodecTreeNodes which are not DataObjects.
JIRA: MDSAL-805
Change-Id: I225bb02f2c2a1d9caa6e435a4c2ef8f8f62574bd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 12:07:41 +0000 (14:07 +0200)]
Reuse cached factory
We can take advantage of local factory to get the loader. This
simplifies things a bit.
Change-Id: Ic1b71c553bc2640697163a544809e1f5de873979
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 29 Jun 2023 11:18:03 +0000 (13:18 +0200)]
Fix YangDataRuntimeTypes not being available
CompositeRuntimeType children are always indexed only through
SchemaTree, which means we need to make another pass to get at
YangDataRuntimeTypes.
JIRA: MDSAL-805
Change-Id: I68cfc7fad2c1a7cb3333e48e9b435bc681992641
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 28 Jun 2023 09:47:28 +0000 (11:47 +0200)]
Do not require DataObject for streaming
DataContainer is completely sufficient, require just that.
JIRA: MDSAL-805
Change-Id: Iff55143f2c3bcc8a4b678649285f170f0353db5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 28 Jun 2023 09:20:20 +0000 (11:20 +0200)]
Reduce explicit casts in DataObjectStreamerGenerator
Use instanceof patterns to reduce casts.
Change-Id: I3d1e0f8ea5d4b14135e1604b6f902d9e5193941c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 28 Jun 2023 07:23:49 +0000 (09:23 +0200)]
Fixup dom-codec a bit
With all the moves we can tighten formatting a bit. Also remove a site
with raw types.
Change-Id: Id3b13500598a595517dbbfe9f98893517cd77aa2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 22:06:41 +0000 (00:06 +0200)]
Rename CaseNodeCodecContext
'CaseCodecContext' is a better name, matching the CaseCodecPrototype we
already have.
Change-Id: I5b3f8501e92f65824d63da282b54b10751424208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 19:20:37 +0000 (21:20 +0200)]
Split up DataObjectCodecPrototype
Having a type-based dispatch during createInstance() is not exactly
nice. This patch splits up DataObjectCodecPrototype.createInstance()
into individual prototypes, so that we have a prototype for pretty-much
each CodecContext type.
This also improves type safety, as CodecContexts now can be directly
instantiated (and create a prototype internally).
Change-Id: If740949bc15890f0ce4bfa5b59cda030b33e66a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 19:04:40 +0000 (21:04 +0200)]
Rename ContainerNodeCodecContext
A better name is 'ContainerLikeCodecContext', mirroring binding to
ContainerLikeRuntimeType.
Change-Id: Ie2579010a4b7da15df8192c0bd8690b84d769ccd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 19:02:53 +0000 (21:02 +0200)]
Rename NonPresenceContainerNodeCodecContext
'StructuralContainerCodecContext' is a better name overall.
Change-Id: I8cec640b209b96929f1a9bc33bbfa6af3dde81e1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 27 Jun 2023 15:38:01 +0000 (17:38 +0200)]
Split up OpaqueNodeCodecContext
We have two specializations, make promote them to top-level classes and
rename OpaqueNodeCodecContext to AbstractOpaqueCodecContext.
Change-Id: Ibe18324a5e5a408cfcf8bbbe6b77065f19a3bfa5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 21:48:01 +0000 (23:48 +0200)]
Promote RuntimeType interface hierarchy
Basic types have stood the test of time so far, drop @Beta annotations.
Change-Id: Icd8e8957706eb78678715a17653615de4b09d948
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 20:25:29 +0000 (22:25 +0200)]
Promote BindingIdentityCodec
There is nothing @Beta about this interface anymore, remove the
annotation.
Change-Id: I6e8bedbc73b704566fce5ce06a9fb9316573cf5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 20:11:40 +0000 (22:11 +0200)]
Add CodecWithPath documentation
Document the two parts of this record.
Change-Id: Ia665ccda22f53944f760e1b3f22816e96b40faf1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 20:09:15 +0000 (22:09 +0200)]
Drop @Beta from BindingCodecTree methods
These methods are well-established, they are no longer @Beta.
Change-Id: I83770212cc6de6adf3d9f9c4d7880d923d5da00f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 18:33:35 +0000 (20:33 +0200)]
Do not use BindingReflections in mdsal-binding-dom-codec-api
The exact mechanics of now an Action's QNameModule is resolved should
not be dependent on reflection. Eliminate this assumption from API and
shift it down to implementation.
JIRA: MDSAL-781
Change-Id: I6c3a18c41ee8189c315be3cc2888c092f06bb6ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 18:16:25 +0000 (20:16 +0200)]
Reduce use of BindingReflections in BindingNormalizedNodeSerializer
BindingNormalizedNodeSerializer's codec implementation can easily
process some of these methods and we therefore do not have to use
BindingReflections to acquire their NodeIdentifiers.
JIRA: MDSAL-781
Change-Id: If928d896e785fe8782ddbde7fb898464c40adb17
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 18:03:02 +0000 (20:03 +0200)]
Remove BindingReflections.getQName(BaseIdentity)
All users (including downstreams) have been eliminated, remove this
method.
JIRA: MDSAL-781
Change-Id: I66a7dc55d86be4e863cff675f4feb230c5e4c531
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 18:36:32 +0000 (20:36 +0200)]
Fix output's NodeIdentifier
We are mis-representing the output as input, fix that.
Change-Id: Ic5eee44575e42b30ad60d75c3dd3256426ca9137
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 13:03:02 +0000 (15:03 +0200)]
Clean up dependencies
Clean up dependencies of mdsal-trace-impl, mdsal-eos-binding-api,
mdsal-dom-spi and mdsal-rfc8294-netty.
Change-Id: Ic3be075e80a2700207abe3628d4d3f972818e64c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 12:42:24 +0000 (14:42 +0200)]
Improve binding-parent
Require basic things for generated code and make sure
maven-dependency-plugin does not trip over optional parts.
Change-Id: I98d11bd165f5f85d324d27039e4c1b75974ee3ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 11:48:45 +0000 (13:48 +0200)]
Do not require spotbugs transitively
Clean up dependencies, eliminating unused declared dependencies on
spotbugs-annotations. Also clean up dependency confusion between
mdsal-binding-dom-adapter and mdsal-binding-test-utils.
Change-Id: Iaa6681c3e53ca8b9bd9e63abecf199b316fa9b4d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 12:12:25 +0000 (14:12 +0200)]
Update documentation links
Used HTTPS and point to correct relase of Guava.
Change-Id: I578a1dd4d3ed0b957f0aeba3425f974fe2a2cc2d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 26 Jun 2023 08:36:01 +0000 (10:36 +0200)]
Bump upstreams
Adopt
- odlparent-13.0.3
- yangtools-11.0.0
Change-Id: Ie3277c61866d649a8c8c8bbde9320a0375cd65ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 22 Jun 2023 15:53:32 +0000 (17:53 +0200)]
Do not use BindingReflections in ModuleInfoSnapshotBuilder
We have YangModuleInfos, which expose both the root package and the
corresponding namespace. Use that information to resolve QNameModule
for a particular root without relying on reflective access.
JIRA: MDSAL-783
Change-Id: If8b14cb49118f5d97c65783f29f1aa77bcc4eada
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 22 Jun 2023 12:14:22 +0000 (14:14 +0200)]
Do not use BindingReflections in IdentityCodec
Instantiate a dedicated cache for holding object->QName mapping and use
that to service translation requests.
JIRA: MDSAL-783
Change-Id: I414a12f5f2a2e602a904d5dff0360ab0773dd26d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 22 Jun 2023 12:53:29 +0000 (14:53 +0200)]
Remove BindingReflections.getQName(Rpc)
This method is not used anywhere, remove it.
JIRA: MDSAL-783
Change-Id: I2b76a8fd91bc99382933311cc0eb6aa3c2c72dd4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>