ovsdb.git
10 years agoFix build error, due to changes in FlowId: https://git.opendaylight.org/gerrit/#... 55/4155/1
Flavio Fernandes [Mon, 13 Jan 2014 03:08:45 +0000 (22:08 -0500)]
Fix build error, due to changes in FlowId: https://git.opendaylight.org/gerrit/#/c/4058/

Changes to fix build were based on changes done in commit 45b75a6ba76bf8b453b5f0de11ceb0c3bba1e842, file:
.../opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsUpdateCommiter.java

Change-Id: I635c7530cd9897d7c0ee8f1cb5209869c90f24b5
Signed-off-by: Flavio Fernandes <ff@member.org>
10 years agoMerge "Fixing the ColumnSchema as per RFC7047 for a enum variable."
Brent Salisbury [Fri, 10 Jan 2014 05:16:41 +0000 (05:16 +0000)]
Merge "Fixing the ColumnSchema as per RFC7047 for a enum variable."

10 years agoFixing the ColumnSchema as per RFC7047 for a enum variable. 26/4126/1
Madhu Venugopal [Fri, 10 Jan 2014 05:06:34 +0000 (21:06 -0800)]
Fixing the ColumnSchema as per RFC7047 for a enum variable.

Enums are defined as a 1 or more atomic-type and hence the current Object[] is incorrect
and is causing deser issues with vtep schema. Fixing it with a more generic Object.
This will be properly accomodated when we have schema driven OVSDB approach is in place.

Change-Id: I0c1d2896ea34bbc3c358ca0d0818860908e0b1b1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMove the java 1.7 config to the parent pom into pluginManagement so it is enforced... 11/4011/4
Madhu Venugopal [Thu, 9 Jan 2014 02:29:33 +0000 (18:29 -0800)]
Move the java 1.7 config to the parent pom into pluginManagement so it is enforced for neutron and northbound as well.
Merge failed due to conflicts and hence manually applying Hugo's changes on his behalf.

Change-Id: Ia704984f29c5f6a3371d27ad78001f904c54bb3a
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoUpdating the commons parent pom to 1.4.1-SNAPSHOT and checkstyle fixes 41/4041/2
Madhu Venugopal [Thu, 9 Jan 2014 21:36:00 +0000 (13:36 -0800)]
Updating the commons parent pom to 1.4.1-SNAPSHOT and checkstyle fixes

ovsdb project depends on the controller project's 1.4.0-SNAPSHOT version of commons pom.xml.
Since the latest changes (including the jackson upgrade) is done on 1.4.1-SNAPSHOT, we have
to update to the latest.
While doing so, it caught quite a few checkstyle errors, which am fixing it along.

Change-Id: Id650ffbae93f47121a7d259d0b39c6b537c2a992
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Added Mockito and PowerMock to the neutron pom.xml Unit test coverage for...
Madhu Venugopal [Thu, 9 Jan 2014 02:39:36 +0000 (02:39 +0000)]
Merge "Added Mockito and PowerMock to the neutron pom.xml Unit test coverage for AdminConfigManager Unit test coverage for NetworkHandler"

10 years agoMerge "Prevent NPE when an interface is already present on the switch, but no related...
Madhu Venugopal [Thu, 9 Jan 2014 02:17:24 +0000 (02:17 +0000)]
Merge "Prevent NPE when an interface is already present on the switch, but no related port is configured."

10 years agoMerge "Small Java related improvements."
Madhu Venugopal [Thu, 9 Jan 2014 02:02:11 +0000 (02:02 +0000)]
Merge "Small Java related improvements."

10 years agoPrevent NPE when an interface is already present on the switch, but no related port... 10/4010/1
Hugo Trippaers [Fri, 3 Jan 2014 12:30:26 +0000 (13:30 +0100)]
Prevent NPE when an interface is already present on the switch, but no related port is configured.

Change-Id: I966b412d06450f75ea8940dc413b9973ec1fc1d1
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoAligning Jackson to the Controller's l latest upgrade (2.3.0). Also updated the north... 03/4003/1
Madhu Venugopal [Thu, 2 Jan 2014 22:25:14 +0000 (14:25 -0800)]
Aligning Jackson to the Controller's l latest upgrade (2.3.0). Also updated the northbound bundle to use the latest Jackson.

Due to this change, the ovsdb.northbound bundle will start to accept and respond OVSDB JSON messages in the same format as
expected by the ovsdb-server. (i.e) a set will be represented as ["set",[]] instead of the common sense [].
This is due to the ovsdb requirement as specified in the RFC / Draft.

Change-Id: I3a1a2548f1b8c87d1d4b63f5952d6fabaa6f3d33
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSmall Java related improvements. 78/3978/1
Alissa Bonas [Mon, 30 Dec 2013 15:59:26 +0000 (17:59 +0200)]
Small Java related improvements.

Remove redundant return statement from void method,
remove redundant boxing of numeric variables,
remove statements that check a condition that is always 'true',
add braces to 'if else' statements.

Signed-off-by: Alissa Bonas <abonas@redhat.com>
10 years agoAdded Mockito and PowerMock to the neutron pom.xml 51/3951/3
Dave Tucker [Sat, 28 Dec 2013 20:19:37 +0000 (20:19 +0000)]
Added Mockito and PowerMock to the neutron pom.xml
Unit test coverage for AdminConfigManager
Unit test coverage for NetworkHandler

Change-Id: Ice7582e2a9f4dd5a4b7c9fdac01e86196f48ccf4
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
10 years agoOVSDB project's OpenFlow 1.3 ProtocolPlugin integration via Controller's MD-SAL infra... 89/3889/1
Madhu Venugopal [Sat, 21 Dec 2013 21:57:39 +0000 (13:57 -0800)]
OVSDB project's OpenFlow 1.3 ProtocolPlugin integration via Controller's MD-SAL infrastructure

This checkin brings in the basic infrastructure changes needed to integrate the ovsdb.neutron bundle
with OpenFlow1.3 via the Controller's MDSAL infrastructure. The actual work of mapping the multi-table
and various Flow programming can be done now over this infra.

Change-Id: Ia3b73e4be243fe597c8996a676cd648c6a960d62
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoUpdating netty to 4.0.10 version (same as the controller project). 82/3882/1
Madhu Venugopal [Fri, 20 Dec 2013 22:31:09 +0000 (14:31 -0800)]
Updating netty to 4.0.10 version (same as the controller project).

Change-Id: I8732aa5439fc250b070c0e26e008fdb65928d4ad
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHO...
Brent Salisbury [Fri, 20 Dec 2013 04:48:50 +0000 (04:48 +0000)]
Merge "Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version."

10 years agoMerge "Modified a few fields from OVSDB ambiguity"
Madhu Venugopal [Fri, 20 Dec 2013 04:44:55 +0000 (04:44 +0000)]
Merge "Modified a few fields from OVSDB ambiguity"

10 years agoModified a few fields from OVSDB ambiguity 29/2629/4
Brent Salisbury [Wed, 18 Dec 2013 00:13:23 +0000 (19:13 -0500)]
Modified a few fields from OVSDB ambiguity

Change-Id: Id86437e91ea77e76e2685c9209cb92b3f3b1e5c3
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoUpdating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version. 60/3860/2
Madhu Venugopal [Fri, 20 Dec 2013 01:10:13 +0000 (17:10 -0800)]
Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version.

As discussed in the TSC meeting, with this change, the OVSDB project is upto-date with the Controller bundle SNAPSHOT version as of today.

Change-Id: I8456aea40161912b8f40f1737e7440920ce7ef77
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Added folder for ovsdb.neutron tests. Created unit tests for BaseHandler."
Madhu Venugopal [Wed, 18 Dec 2013 20:44:05 +0000 (20:44 +0000)]
Merge "Added folder for ovsdb.neutron tests. Created unit tests for BaseHandler."

10 years agoAdded folder for ovsdb.neutron tests. 79/3779/3
Dave Tucker [Tue, 17 Dec 2013 01:43:19 +0000 (01:43 +0000)]
Added folder for ovsdb.neutron tests.
Created unit tests for BaseHandler.

Change-Id: Icde417fdd969a86a633da960ca36dbc713ddb76a
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
10 years agoMerge "Removed the floodEntries cache and relying on FRM's flow cache directly for...
Brent Salisbury [Tue, 17 Dec 2013 18:39:42 +0000 (18:39 +0000)]
Merge "Removed the floodEntries cache and relying on FRM's flow cache directly for updating the flood entries with new tunnels."

10 years agoMerge "Moved all Openflow 1.0 specific flow programming away from InternalNetworkMana...
Brent Salisbury [Tue, 17 Dec 2013 18:38:04 +0000 (18:38 +0000)]
Merge "Moved all Openflow 1.0 specific flow programming away from InternalNetworkManager to OF10ProviderManager class."

10 years agoRemoved the floodEntries cache and relying on FRM's flow cache directly for updating... 98/3798/1
Madhu Venugopal [Tue, 17 Dec 2013 17:30:21 +0000 (09:30 -0800)]
Removed the floodEntries cache and relying on FRM's flow cache directly for updating the flood entries with new tunnels.

With many caches/databases that we rely upon, we are taking a concious decision to avaoid caching data in our bundles
but rely on existing and tested dbs in the system. With that philosophy, it is good to have 1 less cache :-).

Change-Id: Ibc3273d86c34e58bd14b1f1e8869ceebcedc6c60
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMoved all Openflow 1.0 specific flow programming away from InternalNetworkManager... 86/3786/1
Madhu Venugopal [Tue, 17 Dec 2013 10:32:23 +0000 (02:32 -0800)]
Moved all Openflow 1.0 specific flow programming away from InternalNetworkManager to OF10ProviderManager class.

Also, handled Switchmanager Node coming up event to take care of initializing the default flows.
This is needed to handle timing issues in which the ForwardingRulesManager rejects request to program
default flows from ovsdb.neutron if the request is too soon (before the OF node gets registered with other
OSGi bundles).

Change-Id: Id299c75146e504df63a45b77cc0f6be962c3abb6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Changed lookup of Controller IP to the following: - Start with OVSDB config...
Madhu Venugopal [Tue, 17 Dec 2013 00:03:29 +0000 (00:03 +0000)]
Merge "Changed lookup of Controller IP to the following:   -  Start with OVSDB config/property override   -  If not there, consult clustering services   -  If not there, consult Controller config/property override   -  If not found there, use the same IP that we connected on"

10 years agoMerge "Added the missing Copyright headers to most of the java files."
Brent Salisbury [Mon, 16 Dec 2013 23:06:56 +0000 (23:06 +0000)]
Merge "Added the missing Copyright headers to most of the java files."

10 years agoChanged lookup of Controller IP to the following: 45/3745/2
Thomas Bachman [Sat, 14 Dec 2013 12:20:48 +0000 (04:20 -0800)]
Changed lookup of Controller IP to the following:
  -  Start with OVSDB config/property override
  -  If not there, consult clustering services
  -  If not there, consult Controller config/property override
  -  If not found there, use the same IP that we connected on

Change-Id: Ia036740b57775ede5d5963a414baa611b8baa16c
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
10 years agoAdded the missing Copyright headers to most of the java files. 41/3641/2
Madhu Venugopal [Wed, 11 Dec 2013 14:19:24 +0000 (06:19 -0800)]
Added the missing Copyright headers to most of the java files.

Did my best in identyfing the appropriate Copyright owners and added Authors based
on the git history and authorship based on significant contributions.
For those files where the Copyright headers are not clear, the Authors mentioned
in the files will take care of filling them in.

Change-Id: I5243191c0753d42dccdfcdffd7c8bee53c9086ef
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoEnabled the ODL configuration on the Compute local.conf as well so that the ML2 auto... 52/3652/1
Madhu Venugopal [Wed, 11 Dec 2013 17:29:16 +0000 (09:29 -0800)]
Enabled the ODL configuration on the Compute local.conf as well so that the ML2 auto-config script can auto-configure manager.

Change-Id: Iead74f83b879fdfc9b4aeedbcb673390657898d9
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years ago- Added insertMirrorRow 21/3621/2
Keith Burns [Tue, 10 Dec 2013 17:55:08 +0000 (09:55 -0800)]
- Added insertMirrorRow
- Fixed bug in _insertTableRow for trIndex=0
- Added "mirrors" to Bridge Table
- removed println debugging

Change-Id: I6fa0917d67ed69bfe18ac46003295dac0db5f0ab
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoMerge "Added resources/ folder to track all the associated scripts and config files."
Brent Salisbury [Sun, 8 Dec 2013 05:11:57 +0000 (05:11 +0000)]
Merge "Added resources/ folder to track all the associated scripts and config files."

10 years agoMerge "Installing NORMAL rules on all the default neutron bridges."
Brent Salisbury [Sun, 8 Dec 2013 05:11:28 +0000 (05:11 +0000)]
Merge "Installing NORMAL rules on all the default neutron bridges."

10 years agoAdded resources/ folder to track all the associated scripts and config files. 49/3549/1
Madhu Venugopal [Sat, 7 Dec 2013 13:57:01 +0000 (05:57 -0800)]
Added resources/ folder to track all the associated scripts and config files.

Currently it is sub-divided into 2 directories : openstack and commons.
commons/ contains all the common script/config files such as POSTMAN scripts.
openstack/ contains all the openstack/devstack related config and scripts.
Each of these directories contain README.

We can expand this resources/ directory with more scripts as we see fit.

Change-Id: I86e7f82bfe0916b29fc069d62fb99a4a265156d8
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoInstalling NORMAL rules on all the default neutron bridges. 37/3537/2
Madhu Venugopal [Fri, 6 Dec 2013 21:27:30 +0000 (13:27 -0800)]
Installing NORMAL rules on all the default neutron bridges.

Opendaylight controller's OF1.0 plugin deletes all the OF rules upon initial connection.
This could be a valid scenario on regular scenario, but it breaks some basic assumptions
in a Openstack/devstack deployment. Hence this fix will override that behaviour by installing
a NORMAL rule as the default rule to avoid data traffic to be punted to the controller.
This is a temporary measure to solves some major issues seen on couple of deployment scenarios.
We will address it more elagantly once we integrate with the new OF plugin.

Change-Id: Ie53c85c3e1549d07392d6c8129adb05806ed32cd
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "- Addressed Queue/QoS special parent column type dependency - New files found...
Madhu Venugopal [Fri, 6 Dec 2013 07:02:42 +0000 (07:02 +0000)]
Merge "- Addressed Queue/QoS special parent column type dependency - New files found, and added to branch - Saving changes before trying SSL (0|1) check. - Complete insert sFlow insert/delete. - Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables - Added Queue table insert/delete operations (ROOT TABLE) - Netflow table insert/delete plus changes to Bridge and Netflow table definitions. - Fixed NetFlow table (wrong tablename) - Complete insert/delete Manager row - Capability row unable to be tested."

10 years ago- Addressed Queue/QoS special parent column type dependency 84/3284/5
Keith Burns [Fri, 29 Nov 2013 23:05:03 +0000 (15:05 -0800)]
- Addressed Queue/QoS special parent column type dependency
- New files found, and added to branch
- Saving changes before trying SSL (0|1) check.
- Complete insert sFlow insert/delete.
- Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables
- Added Queue table insert/delete operations (ROOT TABLE)
- Netflow table insert/delete plus changes to Bridge and Netflow table definitions.
- Fixed NetFlow table (wrong tablename)
- Complete insert/delete Manager row
- Capability row unable to be tested.

Change-Id: Iaedad50f0c15a87179904b7ca01983cd7febc4ce
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoMade changes in Internal Network creation to also takes care of creating br-int ... 90/3490/1
Madhu Venugopal [Thu, 5 Dec 2013 08:24:34 +0000 (00:24 -0800)]
Made changes in Internal Network creation to also takes care of creating br-int & its patch-ports if they are missing.

Please note that the current implementation creates br-int, br-tun and the patch ports upon detecting a new Node.
This can be improved by creating these bridges just when the Neutron events begin. Since this functionality is now
boxed into a single method call, it can be taken care as a future fix.

Change-Id: I71f52348d042a8ef1653fcd8e094a7a1d87d78d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMake the eventHandler more robust. Set broad exception handlers on the process functi... 17/3417/2
Hugo Trippaers [Tue, 3 Dec 2013 21:55:22 +0000 (22:55 +0100)]
Make the eventHandler more robust. Set broad exception handlers on the process functions to catch exceptions that would otherwise cause the thread to break.

Change-Id: I7f21daba508b32e556af5215d8a3d5f4426a35ae
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoMerge "Identifying and ignoring uninterested SouthBound updates."
Brent Salisbury [Wed, 4 Dec 2013 16:14:14 +0000 (16:14 +0000)]
Merge "Identifying and ignoring uninterested SouthBound updates."

10 years agoMerge "Fixed JSON Deserializer to retain empty objects as empty rather than NULL...
Brent Salisbury [Wed, 4 Dec 2013 16:11:17 +0000 (16:11 +0000)]
Merge "Fixed JSON Deserializer to retain empty objects as empty rather than NULL. During Update operations, ovsdb-server sends NULL values for the columns that are not changed. If there is a change from an empty map to valid value, then that change goes undetected. Hence we need to retain the emptiness of the map and array intact in order to differentiate the behaviour."

10 years agoIdentifying and ignoring uninterested SouthBound updates. 38/3438/1
Madhu Venugopal [Wed, 4 Dec 2013 12:23:43 +0000 (04:23 -0800)]
Identifying and ignoring uninterested SouthBound updates.

Neutron bundle relies heavily on the Southbound events, especially the updates for its basic operations.
Many updates, especially the Packet statistics updates from Interface table are fast and furious and we
end up processing a lot of it unneccessarily. Due to the current implementation philosophy of maintaining
absolutely minimum cache in the neutron bundle, it relies heavily on the existing network states. Hence
such updates ends up reaching various layers. Hence identifying those updates and ignoring them becomes
critical for the stability of the system.

Change-Id: I10eb492e6e16be7931ec094bfcff54cc6b8696d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoFixed JSON Deserializer to retain empty objects as empty rather than NULL. 37/3437/1
Madhu Venugopal [Wed, 4 Dec 2013 00:41:21 +0000 (16:41 -0800)]
Fixed JSON Deserializer to retain empty objects as empty rather than NULL.
During Update operations, ovsdb-server sends NULL values for the columns that are not changed.
If there is a change from an empty map to valid value, then that change goes undetected.
Hence we need to retain the emptiness of the map and array intact in order to differentiate the
behaviour.

Change-Id: I9ff356c0f390aeaf0cb5d43bd2ba756206f3e345
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoGet rid of all e.printStackTrace() statements and cleanup some exception handling. 97/3397/2
Hugo Trippaers [Tue, 3 Dec 2013 13:49:07 +0000 (14:49 +0100)]
Get rid of all e.printStackTrace() statements and cleanup some exception handling.

Change-Id: I6bb8c4fc8c3315dcd909ab4b35a1bd5b8ebf1f13
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoWhen the controller already exists, the caller still expects to get its uuid. 49/3249/2
Hugo Trippaers [Fri, 29 Nov 2013 13:47:50 +0000 (14:47 +0100)]
When the controller already exists, the caller still expects to get its uuid.

Change-Id: I7f2aac02ae2d6b678abb4cd0866dcd6ee287604a
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoIntroduce a root pom in the top of the project. 29/3229/4
Hugo Trippaers [Thu, 28 Nov 2013 22:43:13 +0000 (23:43 +0100)]
Introduce a root pom in the top of the project.

Change-Id: I487312165dd5223d04b1d6bc91111a61c61b7713
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoFixup the pom files to add neutron to the main build profile and add both neutron... 28/3228/3
Hugo Trippaers [Thu, 28 Nov 2013 21:05:14 +0000 (22:05 +0100)]
Fixup the pom files to add neutron to the main build profile and add both neutron and northbound to the distribution pom

Change-Id: I5d4f1d6e826b6d17e6e325d67d03facc011dbf02
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoModified the insertRow methods to return StatusWithUuid instead of Status 20/3220/5
Madhu Venugopal [Fri, 29 Nov 2013 17:27:38 +0000 (09:27 -0800)]
Modified the insertRow methods to return StatusWithUuid instead of Status

This is in addition to Hugo's existing fixes.

Change-Id: I9671ee4afbd5e29c29e2b762f2dca91019db1e02
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSimple Null check missing in setOFControllers when there are no existing bridges. 62/3262/1
Madhu Venugopal [Fri, 29 Nov 2013 16:45:51 +0000 (08:45 -0800)]
Simple Null check missing in setOFControllers when there are no existing bridges.

Change-Id: Icf8ffc49d0c3ebbe9ea9ead3a04a7fd0e5be8754
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Enabling LLDP programming again. Upon debugging, it was found that the timeout...
Madhu Venugopal [Thu, 28 Nov 2013 19:27:47 +0000 (19:27 +0000)]
Merge "Enabling LLDP programming again. Upon debugging, it was found that the timeouts and instability observed on the controller were due to permgen issues (caused by multi-node devstack consuming up most of the laptop memory)."

10 years agoMerge "Minor Logging issues and removing an annoying error false positive message"
Madhu Venugopal [Thu, 28 Nov 2013 19:27:17 +0000 (19:27 +0000)]
Merge "Minor Logging issues and removing an annoying error false positive message"

10 years agoEnabling LLDP programming again. 17/3217/1
Madhu Venugopal [Thu, 28 Nov 2013 18:28:03 +0000 (10:28 -0800)]
Enabling LLDP programming again.
Upon debugging, it was found that the timeouts and instability observed on the controller were due to
permgen issues (caused by multi-node devstack consuming up most of the laptop memory).

Change-Id: Ic401615d67bd59f79369d3ff69429a2b366e817f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMinor Logging issues and removing an annoying error false positive message 16/3216/1
Madhu Venugopal [Thu, 28 Nov 2013 18:17:41 +0000 (10:17 -0800)]
Minor Logging issues and removing an annoying error false positive message

Change-Id: I0439972846bd69e96555e6e8cc97c4dc226bc3d1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Disabling the installation of LLDP Punt rules to Controller."
Brent Salisbury [Thu, 28 Nov 2013 09:28:35 +0000 (09:28 +0000)]
Merge "Disabling the installation of LLDP Punt rules to Controller."

10 years agoDisabling the installation of LLDP Punt rules to Controller. 77/3177/1
Madhu Venugopal [Thu, 28 Nov 2013 09:25:02 +0000 (01:25 -0800)]
Disabling the installation of LLDP Punt rules to Controller.

In a multi-node devstack setup, LLDP installation seems to cause issues with the Controller
(CPU spike and some OF message timeouts). It is better to debug that and once we have an idea,
we can enable it again. There is NO functional impact to the Neutron integration with OVSDB
by disabling LLDP flow installation.

Change-Id: I51e64253e09b6e863e2eea89f2570e436d3cc93f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Made changes to exception throwing."
Madhu Venugopal [Thu, 28 Nov 2013 08:57:37 +0000 (08:57 +0000)]
Merge "Made changes to exception throwing."

10 years agoBroadcast/Unknown unicast support. Also added LLDP punt to Controller. 74/3174/1
Madhu Venugopal [Thu, 28 Nov 2013 08:14:26 +0000 (00:14 -0800)]
Broadcast/Unknown unicast support. Also added LLDP punt to Controller.

Change-Id: Ia36ddd7f8cbdcb9f9ed164ffbc7332b5763fc931
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMade changes to exception throwing. 15/3115/2
Keith Burns [Tue, 26 Nov 2013 23:37:37 +0000 (15:37 -0800)]
Made changes to exception throwing.

Change-Id: I8615f44e8dd98302d5ddc54b548640a1f969ef0b
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoOF Flow programming on br-int (NORMAL) and bidirectional br-tun (based on tenant... 11/3111/1
Madhu Venugopal [Tue, 26 Nov 2013 19:35:46 +0000 (11:35 -0800)]
OF Flow programming on br-int (NORMAL) and bidirectional br-tun (based on tenant mac/vlan)

Change-Id: I611e8fed23996b3b03a77640853fadb38b8c9513
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoConsolidated Container logic in 1 place and is configurable. Also fixed OF controller... 10/3110/1
Madhu Venugopal [Tue, 26 Nov 2013 10:34:19 +0000 (02:34 -0800)]
Consolidated Container logic in 1 place and is configurable. Also fixed OF controller connection for br-tun.

Change-Id: I33f4986317f386b5707e95cb90f7db532812159c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoRefactored delete{Table}Row to use generic _deleteTableRow() 83/3083/1
Keith Burns [Tue, 26 Nov 2013 01:14:12 +0000 (17:14 -0800)]
Refactored delete{Table}Row to use generic _deleteTableRow()
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoVM location aware of Full-mesh Tenant-specific GRE Tunnel support over OF1.0 datapath. 41/3041/2
Madhu Venugopal [Sun, 24 Nov 2013 13:30:46 +0000 (05:30 -0800)]
VM location aware of Full-mesh Tenant-specific GRE Tunnel support over OF1.0 datapath.

This push also includes the following major changes :
1. OVSDB Port tagging on the internal integration bridge (br-int) on Tenant VM connected ports
2. Proper Container support with Flow Spec (internal Vlan) and Openflow ports as Container NodeConnectors
3. Moved most of the logic away from the Neutron Northbound Handlers to the Southbound Handler
4. More fixes to make the OVSDB bundles restartable without the need to force restart the Openstack components.
5. Moved the Southbound events to be handled in its own event thread.

Change-Id: Icb9ffc3a18f1dc15ca0b459ab690d98ce5d91b8f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded br-tun bridge installation code via InternalNetworkManager in cases when the... 27/3027/2
Madhu Venugopal [Sat, 23 Nov 2013 01:06:18 +0000 (17:06 -0800)]
Added br-tun bridge installation code via InternalNetworkManager in cases when the Node is not ready for overlay.

In DevStack environement, the Controller node is also used as compute. But the OVS is not populated with the
appropriate internal networks (such as br-tun and the corresponding patch-ports).
Witht his commit, this condition is identified and appropriate installation is done on the br-tun and br-int.

Change-Id: I8f1f65da864bd8a016912b46dbed3ed9a926ef2e
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSkeleton code for the NetworkManagers : Provider, Internal and Tenant. 26/3026/2
Madhu Venugopal [Fri, 22 Nov 2013 21:01:27 +0000 (13:01 -0800)]
Skeleton code for the NetworkManagers : Provider, Internal and Tenant.

Also added a ConfigManager for the Tunnel-End point configuration that is currently proposed to be configured as :
ovs-vsctl set Open_vSwitch <uuid> other_config={"local-ip"="192.168.56.101"}.

Change-Id: I7b14fed5fdc5a1c4f6714faf41679c2f1cb9d0f5
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Skeleton Event handlers for the Neutron integration with OVSDB. As per the...
Brent Salisbury [Sun, 24 Nov 2013 19:19:51 +0000 (19:19 +0000)]
Merge "Skeleton Event handlers for the Neutron integration with OVSDB. As per the design, the ovsdb.neutron plugin will be a bunch of event handlers which converts the events into corresponding OVSDB/OF programming. The 5 events of interests are 1. NeutronNetwork events 2. NeutronPort events 3. NeutronSubnet events 4. Southbound Node Connectivity events 5. Southbound Port table update events This push just brings in the barebones of these event handlers."

10 years agoAdded delete[Port|Interface|Controller]Row methods 35/3035/1
Keith Burns [Sat, 23 Nov 2013 05:56:02 +0000 (21:56 -0800)]
Added delete[Port|Interface|Controller]Row methods

Change-Id: I740180d2f8a533e2c264c850aa7d1e6e0ae13f6a
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoSkeleton Event handlers for the Neutron integration with OVSDB. 25/3025/1
Madhu Venugopal [Fri, 22 Nov 2013 06:34:45 +0000 (22:34 -0800)]
Skeleton Event handlers for the Neutron integration with OVSDB.
As per the design, the ovsdb.neutron plugin will be a bunch of event handlers which
converts the events into corresponding OVSDB/OF programming. The 5 events of interests are
1. NeutronNetwork events
2. NeutronPort events
3. NeutronSubnet events
4. Southbound Node Connectivity events
5. Southbound Port table update events
This push just brings in the barebones of these event handlers.

Change-Id: Ic94429672303bee29de0c245558669e9462c0a01
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMoved OF-Controller helper routines to ConnectionService and starting to use the... 25/2925/2
Madhu Venugopal [Wed, 20 Nov 2013 22:41:20 +0000 (14:41 -0800)]
Moved OF-Controller helper routines to ConnectionService and starting to use the insert*Row due to the service requirements.
Also moved some verbose debugs to traces.

Change-Id: I7c68dc599bb193af3905d3cd709381f2fae72b31
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded insertControllerRow and fixed getSerializedRow. getRows still need to return... 93/2893/1
Madhu Venugopal [Wed, 20 Nov 2013 09:33:22 +0000 (01:33 -0800)]
Added insertControllerRow and fixed getSerializedRow. getRows still need to return unserialized form
which will be used by the neutron integration piece. Also the insertControllerRow is used for that
cause.

Change-Id: I0a8b03b24a22dcb31b67d1ee5f606bd0220c34dc
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded insertInterfaceRow() method to ConfigurationService.java. 79/2879/3
Keith Burns [Tue, 19 Nov 2013 16:55:46 +0000 (08:55 -0800)]
Added insertInterfaceRow() method to ConfigurationService.java.

Change-Id: I08c41351e1a8f03c48fd0f416cbab89feeb34793
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoMerge "Update, Delete and Read support for base tables."
Brent Salisbury [Thu, 14 Nov 2013 15:45:11 +0000 (15:45 +0000)]
Merge "Update, Delete and Read support for base tables."

10 years agoUpdate, Delete and Read support for base tables. 30/2730/1
Madhu Venugopal [Thu, 14 Nov 2013 02:30:47 +0000 (18:30 -0800)]
Update, Delete and Read support for base tables.

Change-Id: I1c5f6fb8d2d6f0dee952542ad9d41866cf0d3077
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Northbound support for inserting table rows"
Brent Salisbury [Thu, 14 Nov 2013 00:14:34 +0000 (00:14 +0000)]
Merge "Northbound support for inserting table rows"

10 years agoNorthbound support for inserting table rows 81/2681/2
Madhu Venugopal [Mon, 11 Nov 2013 00:23:23 +0000 (16:23 -0800)]
Northbound support for inserting table rows

Change-Id: Ifc006389046028c814ebb4d2090d4b5882745bed
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Controller IP-Address filtered using the "of.address" controller configuration...
Brent Salisbury [Mon, 11 Nov 2013 18:25:38 +0000 (18:25 +0000)]
Merge "Controller IP-Address filtered using the "of.address" controller configuration from a list of all the exposed ip-addresses of the system."

10 years agoRemove eclipse project files from the source repository 94/2594/1
Hugo Trippaers [Mon, 11 Nov 2013 08:11:40 +0000 (09:11 +0100)]
Remove eclipse project files from the source repository

Change-Id: Ie101a06e780c790c8b61207342799034cd2c6a12
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoUpdating OpenFlow Node Description that is learnt from the OVSDB bridge table. 87/2587/1
Madhu Venugopal [Sun, 10 Nov 2013 17:19:11 +0000 (09:19 -0800)]
Updating OpenFlow Node Description that is learnt from the OVSDB bridge table.
In order to compensate for a bug in the way Openflow plugin overrides a null value on the switchmanage node description,
this fix also adds a scheduled reexecution of the description update message after a few seconds to make sure the updates
are not lost.

Change-Id: I605a2ff237d13cb72cdeb60ecf55ad19295c3133
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoController IP-Address filtered using the "of.address" controller configuration from... 79/2579/1
Madhu Venugopal [Sun, 10 Nov 2013 11:59:03 +0000 (03:59 -0800)]
Controller IP-Address filtered using the "of.address" controller configuration from a list of all the exposed ip-addresses of the system.

As per the current implementation, when a new bridge is added, the Configuration Service automatically sets up the OF Controller field
of the bridge to point back at the OpenDaylight Openflow plugin. This is done by scanning all the open interfaces with valid IP-Addresses
and sets it in the Bridge table's controller column.
This can be better handled by filtering it further by using just the Admin prefered ip-address of the controller.
This configuration item is called "of.address" in configuration/config.ini.

Change-Id: Icdfeb0dfc4e68e61e926f09b49461fe0c1dd3060
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoFixed OVSDB Passive Connection interaction bugs with Connection Manager. 74/2574/1
Madhu Venugopal [Sun, 10 Nov 2013 02:18:43 +0000 (18:18 -0800)]
Fixed OVSDB Passive Connection interaction bugs with Connection Manager.
Luis (from the integration project) identified the SAL Connection service interaction issues
during OVSDB Passive connection to the controller.
Also introduced the disconnect handling, including cleaning up the tableCache for that node.

Change-Id: Ieb7ed88e164574c3f27413d8ccae38222e82d89f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Allow to change the controller ip and port for the integration test from the...
Madhu Venugopal [Sat, 9 Nov 2013 07:54:15 +0000 (07:54 +0000)]
Merge "Allow to change the controller ip and port for the integration test from the maven command line (or the pom.xml)"

10 years agoMerge "Change all the tests that need an ovsdb controller to integration tests and...
Madhu Venugopal [Sat, 9 Nov 2013 07:52:33 +0000 (07:52 +0000)]
Merge "Change all the tests that need an ovsdb controller to integration tests and centrallize the connection routine."

10 years agoMerge "Split unit and integration tests and add a profile to active integration tests."
Madhu Venugopal [Sat, 9 Nov 2013 07:41:19 +0000 (07:41 +0000)]
Merge "Split unit and integration tests and add a profile to active integration tests."

10 years agoMerge "Implemented the deleteBridgeDomain method in ConfigurationService"
Madhu Venugopal [Sat, 9 Nov 2013 07:36:39 +0000 (07:36 +0000)]
Merge "Implemented the deleteBridgeDomain method in ConfigurationService"

10 years agoImplemented the deleteBridgeDomain method in ConfigurationService 41/2541/4
Brent Salisbury [Fri, 8 Nov 2013 08:59:31 +0000 (03:59 -0500)]
Implemented the deleteBridgeDomain method in ConfigurationService

I missed the last comment from Madhu in p2. I verfied all
methods modified. Thanks very much for the assist.
Change-Id: I628f31ed8af66d4c18ac2b61b6200043a8b779d8
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoAllow to change the controller ip and port for the integration test from the maven... 60/2560/1
Hugo Trippaers [Fri, 8 Nov 2013 15:48:50 +0000 (16:48 +0100)]
Allow to change the controller ip and port for the integration test from the maven command line (or the pom.xml)

To execute the integration tests use mvn -Pintegrationtest -Dovsdbserver.ipaddress=x.x.x.x -Dovsdbserver.port=x verify

Change-Id: Ie2df5528f650301c992c3712715df49b0c24227e
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoChange all the tests that need an ovsdb controller to integration tests and centralli... 58/2558/1
Hugo Trippaers [Fri, 8 Nov 2013 15:24:03 +0000 (16:24 +0100)]
Change all the tests that need an ovsdb controller to integration tests and centrallize the connection routine.

Change-Id: I62bcab3cec789c0b1a6a4d85aebbae8d3e3212a5
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoSplit unit and integration tests and add a profile to active integration tests. 49/2549/1
Hugo Trippaers [Fri, 8 Nov 2013 12:29:22 +0000 (13:29 +0100)]
Split unit and integration tests and add a profile to active integration tests.

Add properties file to configure the integration test

Make the integration test die if the remote is not reachable

Change-Id: I2029c6ff14362bae72ce8d4f562361e181604c01
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoMerge "We are using JDK 1.7 specific functions in our code, so we should enforce...
Madhu Venugopal [Fri, 8 Nov 2013 10:11:43 +0000 (10:11 +0000)]
Merge "We are using JDK 1.7 specific functions in our code, so we should enforce source level 1.7"

10 years agoMerge "Fix potential NPE when the ovsdb-server returns null responses on parts of...
Madhu Venugopal [Fri, 8 Nov 2013 09:59:48 +0000 (09:59 +0000)]
Merge "Fix potential NPE when the ovsdb-server returns null responses on parts of a transact return object"

10 years agoWe are using JDK 1.7 specific functions in our code, so we should enforce source... 19/2519/2
Hugo Trippaers [Thu, 7 Nov 2013 17:43:40 +0000 (18:43 +0100)]
We are using JDK 1.7 specific functions in our code, so we should enforce source level 1.7

See ConfigurationService.java:631 function getLoopbackAddress

Change-Id: I3f83bfe84dca05819aa7e04decfa3b01763af0eb
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoFix potential NPE when the ovsdb-server returns null responses on parts of a transact... 21/2521/1
Hugo Trippaers [Thu, 7 Nov 2013 17:53:11 +0000 (18:53 +0100)]
Fix potential NPE when the ovsdb-server returns null responses on parts of a transact return object

Change-Id: I7acc2dd51821e7dabb8dd80ae593d1f779a4267d
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoUpdate the config version of teh ovsdb when adding a bridge 20/2520/1
Hugo Trippaers [Thu, 7 Nov 2013 17:50:46 +0000 (18:50 +0100)]
Update the config version of teh ovsdb when adding a bridge

Change-Id: I459ad71f4ed75e39f71b0cd970190780b1411ec4
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoMerge branch 'topic/netty' 68/2468/1
Madhu Venugopal [Wed, 6 Nov 2013 22:58:28 +0000 (14:58 -0800)]
Merge branch 'topic/netty'
Collapsing the branch to master

Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Conflicts:
ovsdb/.classpath
ovsdb/src/main/java/org/opendaylight/ovsdb/internal/ConfigurationService.java

Change-Id: I4bc7cd4b921b5eb8b14cfe4d1c2811214f03e78c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoBumping up the version to 0.5.0-SNAPSHOT prior to the collapse 63/2463/2
Madhu Venugopal [Wed, 6 Nov 2013 21:48:09 +0000 (13:48 -0800)]
Bumping up the version to 0.5.0-SNAPSHOT prior to the collapse

Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdjusted null check to cache rather then connection. 61/2461/1
Brent Salisbury [Wed, 6 Nov 2013 19:24:46 +0000 (14:24 -0500)]
Adjusted null check to cache rather then connection.

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoSupport for Port Types = patch, Vlan and Tunnel. 56/2456/2
Madhu Venugopal [Wed, 6 Nov 2013 18:05:14 +0000 (10:05 -0800)]
Support for Port Types = patch, Vlan and Tunnel.

Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMinor fix to make Junit happy. 08/2408/2
Madhu Venugopal [Tue, 5 Nov 2013 18:08:02 +0000 (10:08 -0800)]
Minor fix to make Junit happy.

Due to the introduction of the passive connection support, the Monitor and Schema was pushed to a
separate thread. Also the connection was deemed successful only if the monitor was successful.
That doesnt work well with the current (buggy) implemenation of JUnit. But since the JUnit is very
handy in testing out the functionality, reversing the ovsdbConnection management.

Change-Id: Ifa833014c587e94baa63a5925959c87d9e27c6fc
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded add/del-port and hooked into OSGI CLI 50/2450/1
Brent Salisbury [Wed, 6 Nov 2013 16:53:21 +0000 (11:53 -0500)]
Added add/del-port and hooked into OSGI CLI

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoAdded set-controller functionality. 19/2419/1
Brent Salisbury [Wed, 6 Nov 2013 01:06:35 +0000 (20:06 -0500)]
Added set-controller functionality.

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoAdd Utility methods to get a list of controller-ip-addresses and OF Port 82/2382/1
Madhu Venugopal [Tue, 5 Nov 2013 11:06:09 +0000 (03:06 -0800)]
Add Utility methods to get a list of controller-ip-addresses and OF Port

Change-Id: Id73a705903c2f465a1c697e9935b8bdbd27df3be
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoOVSDB Manager Passive listen support 32/2332/1
Madhu Venugopal [Sun, 3 Nov 2013 10:53:39 +0000 (05:53 -0500)]
OVSDB Manager Passive listen support
This change brings in the following :
1. ovsdb manager passive listen on port 6640. With this change, the OVSDB-server can connect to the controller via set-manager configuration.
2. Default listening and connecting port is changed to 6640 (as per the IANA port assignment)
3. Reorganized ConnectionManager a bit to share the exact same Channel handling code for both Active and Passive ovsdb connections.

Change-Id: I76836aa53b519af08aaf3399ba104351d94ddd4c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>