netvirt.git
8 years agoupdate NetvirtSfc postman collection
Sam Hague [Mon, 19 Oct 2015 15:48:06 +0000 (11:48 -0400)]
update NetvirtSfc postman collection

Change-Id: I33c0e104d54ae75b5e90520bdbce122f2c0000d9
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoFirst pass changes for Netvirt classifier rule installation. Writing to INGRES_ACL...
Arun Yerra [Tue, 13 Oct 2015 11:31:17 +0000 (04:31 -0700)]
First pass changes for Netvirt classifier rule installation. Writing to INGRES_ACL table withing netvirt pipeline.

Conflicts:
openstack/net-virt-sfc/features/production/src/main/features/features.xml
openstack/net-virt-sfc/impl/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/sfc/NetvirtSfcProvider.java

Change-Id: Ie1f76ceb301aed90acad49dceacbd8bbfac2dd49
Signed-off-by: Arun S Yerra <arunsarat@yahoo.com>
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Neuter NetvirtSfcIT"
Flavio Fernandes [Fri, 16 Oct 2015 19:57:28 +0000 (19:57 +0000)]
Merge "Neuter NetvirtSfcIT"

8 years agoMerge branch 'topic/master/neutron-yang-migration' to branch 'master'
Anil Vishnoi [Fri, 16 Oct 2015 17:24:09 +0000 (22:54 +0530)]
Merge branch 'topic/master/neutron-yang-migration' to branch 'master'
Squashed commit of the following:

commit 89fc149dd21a3fb9fab3833b8a0e4775c38f62ad
Merge: 709dd55 7d09c56
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Oct 16 20:32:10 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/SecurityServicesManager.java

    Change-Id: Ib0be9f59f9801babb9892d42bf536a924068138c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 709dd55139632d097c2003076bd16fd26164fb03
Author: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Date:   Sat Oct 17 02:21:07 2015 +0530

    Code refactored for security group update.

    Change-Id: Iaa838588197567e28d5e97ca4cbc526663453491
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
commit eac410a5c3a66fd6f9455efabf6c3b213b813acc
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Oct 16 14:37:30 2015 +0530

    Merge branch 'master' to branch 'topic/master/neutron-yang-migration'
    Squashed commit of the following:

    commit 833ea0aba76e3e3317ca6b7e2a0d6fc99a53d9db
    Merge: 91de317 423e4d8
    Author: Flavio Fernandes <ffernand@redhat.com>
    Date:   Thu Oct 15 17:17:06 2015 +0000

        Merge "Adding copyright header to ovsdb/southbound UT"

    commit 91de31748b01a61b80796d121753ac0dff154910
    Author: Sam Hague <shague@redhat.com>
    Date:   Thu Oct 15 12:08:13 2015 -0400

        Add postman collection for NetvirtSfc

        Change-Id: Ibe16df4c9d789311b185a9f7cb0193b7a81f5aba
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 2989548e8b4191e2b050390f565789dddd6702f5
    Author: Sam Hague <shague@redhat.com>
    Date:   Thu Oct 15 09:50:46 2015 -0400

        Remove unused BundleContext from NetvirtSfc

        Change-Id: I7d9d185710f82546472d733796ebc2cba2e3a671
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 423e4d84a8e2cf602222a9bfbefba9f20b79e382
    Author: Rashmi Pujar <rpujar@inocybe.com>
    Date:   Thu Oct 15 09:39:33 2015 -0400

        Adding copyright header to ovsdb/southbound UT

        Change-Id: I92d1f02491f04177b97a1ece879da9278220801b
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
    commit ea352fced510fa638358b43a818adec60bfac0b3
    Merge: 249630d f7f42fb
    Author: Flavio Fernandes <ffernand@redhat.com>
    Date:   Thu Oct 15 11:59:38 2015 +0000

        Merge "All TCP & UDP SG Rules : Implementation and Unit tests added."

    commit 249630df31cdab5087fc44e32d44a4e082a12e40
    Merge: 26b0027 26ed356
    Author: Flavio Fernandes <ffernand@redhat.com>
    Date:   Thu Oct 15 11:56:48 2015 +0000

        Merge "UT for southbound/transactions/md - set 5"

    commit 26b0027005bbeb06bfe228e9dceecded20ad4724
    Merge: cb2fb88 959688e
    Author: Flavio Fernandes <ffernand@redhat.com>
    Date:   Thu Oct 15 11:51:55 2015 +0000

        Merge "Bug 4472 - netvirt: IlligalArgumentException in NAT provider"

    commit cb2fb8864b794f1a792d2614522ab36c27bd5c4d
    Merge: 241ccfe e211414
    Author: Sam Hague <shague@redhat.com>
    Date:   Thu Oct 15 01:37:31 2015 +0000

        Merge "cleanup NetvirtSfcIT"

    commit e211414c068a2f6ba80f1398ca0b38acbc67db42
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 21:12:16 2015 -0400

        cleanup NetvirtSfcIT

        Change-Id: I1cc224a7ab4f65825feefe6de28fb787ca7e2f1c
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 959688edc325bd4adec9e760da771aeedbb2712f
    Author: Isaku Yamahata <isaku.yamahata@intel.com>
    Date:   Wed Oct 14 15:06:19 2015 -0700

        Bug 4472 - netvirt: IlligalArgumentException in NAT provider

        This patch adds work around code for ipv6 cidr notation is given.
        Otherwise following exception occurs.

        > 2015-10-14 13:38:55,125 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramRouterInterface failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1/64 node:ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int srcTunId:external destTunId:1083 action:ADD status:Not Implemented: Not Implemented (0)
        > 2015-10-14 13:38:55,126 | DEBUG | ntDispatcherImpl | ArpResponderService              | 393 - org.opendaylight.ovsdb.openstack.net-virt-providers - 1.2.1.SNAPSHOT | ipv6 address case is not implemented yet. dpid 209308480409166 segmentationId 1083 macAddressStr, ipAddress FA:16:3E:E0:A8:B5 action /fd14:5ac7:ba3:0:0:0:0:1
        > 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramStaticArp failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1 dpid:209308480409166 segOrOfPort:1083 action:ADD status:Not Implemented: Not Implemented (0)
        > 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | EventDispatcher                  | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event NorthboundEvent [handler=NEUTRON_PORT, action=ADD, port=NeutronPort [portUUID=4b19acf4-d644-4fe7-8643-852c25cbf604, networkUUID=821f7a2b-b991-48b0-a39c-b0ef264bd321, name=, adminStateUp=true, status=ACTIVE, macAddress=FA:16:3E:E0:A8:B5, fixedIPs=[Neutron_IPs{ipAddress='fd14:5ac7:ba3::1', subnetUUID='54a7f233-1fdb-4d40-bd44-275f180e9a64'}], deviceID=738d6a7c-43bd-469d-bfed-6bcc6ffe5dca, deviceOwner=network:router_interface, tenantID=dc27e3a1cff64a1cb85c7f24899c3eee, securityGroups=[], bindinghostID=, bindingvnicType=normal, bindingvnicType=normal], subnet=null, router=null, routerInterface=null, floatingIP=null, network=null, loadBalancer=null, loadBalancerPool=null, loadBalancerPoolMember=null]
        > java.lang.IllegalArgumentException: Supplied value "fd14:5ac7:ba3::/64" does not match required pattern "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/(([0-9])|([1-2][0-9])|(3[0-2]))$"
        >         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[64:com.google.guava:18.0.0]
        >         at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Prefix.<init>(Ipv4Prefix.java:49)[216:org.opendaylight.mdsal.model.ietf-inet-types:2010.9.24.8-SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.OutboundNatService.programIpRewriteExclusion(OutboundNatService.java:167)[393:org.opendaylight.ovsdb.openstack.net-virt-providers:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage2(NeutronL3Adapter.java:1143)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage1(NeutronL3Adapter.java:1128)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programFlowsForNeutronRouterInterface(NeutronL3Adapter.java:807)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronRouterInterfaceEvent(NeutronL3Adapter.java:298)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:245)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.doNeutronPortCreated(PortHandler.java:66)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.processEvent(PortHandler.java:161)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:95)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:28)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:57)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
        >         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_60]
        >         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
        >         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
        >         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
        >         at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]

        Change-Id: I1559667adde1c14b5627df3b7212e404998ce897
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
    commit 241ccfe97218b053f1ae09a1d7568df551b85551
    Author: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
    Date:   Wed Jul 22 11:53:30 2015 -0400

        First pass for ovsdb-ui

        Revamp of the work already done. Adding a draft of a
        logical topology viewer. The old code is still in this
        commit because the works done before will be reuse.

        Change-Id: Ia3a86cb0370cfad2ef3c2a156b412b9e029c3bf9
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
    commit 26ed35648c8fcea96674a1f6e310f9d7930c09c8
    Author: Rashmi Pujar <rpujar@inocybe.com>
    Date:   Wed Oct 14 15:03:17 2015 -0400

        UT for southbound/transactions/md - set 5

        11. OvsdbPortRemoveCommand.java
        12. TransactionInvokerImpl.java
        13. OvsdbPortUpdateCommand.java

        Change-Id: Icd9ad76e482de5408650916f6bbf5bc73dc297c8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
    commit 5c63f9ab23bd98686a93e7f745689cf95b152a0c
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 13:29:47 2015 -0400

        neuter NetvirtSfcIT

        Change-Id: Iaca49229b1c594a9e2b5659048319880643887ec
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 1b7724f1fe1bae26cc0ffe8f86f83f3ea10fd626
    Merge: 29eeb86 09a89ea
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 15:32:29 2015 +0000

        Merge "add ovsdb-sfc feature to test feature"

    commit 09a89eaa4496580769faf0564a0b174040682c5d
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 10:49:05 2015 -0400

        add ovsdb-sfc feature to test feature

        Change-Id: I55c2df5791983998f696054b7728b7d1be696e33
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 29eeb865eab297a9d9642d8816dc6ffdbcd42f1f
    Merge: 378e785 864ac9f
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 13:19:56 2015 +0000

        Merge "Add capability on southbound to NetvirtSfc"

    commit 864ac9f57ab4f369e8237d1e55c3121784e86915
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 09:02:51 2015 -0400

        Add capability on southbound to NetvirtSfc

        Change-Id: Iffd6b7b27e701fdfa3bf663421ba72945562d0f1
Signed-off-by: Sam Hague <shague@redhat.com>
    commit 378e78556b82bc756069145194c3cf606aa4aba0
    Merge: a8c8f4a ff01d7b
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 04:55:31 2015 +0000

        Merge "Workaround to fix net-virt-it"

    commit ff01d7b11f98e0d5cabd5bd77a8f0dfcfe12675a
    Author: Sam Hague <shague@redhat.com>
    Date:   Wed Oct 14 00:23:59 2015 -0400

        Workaround to fix net-virt-it

        Change-Id: I10838b993f60b5e3859780d7d9f7b4c3630e312a
Signed-off-by: Sam Hague <shague@redhat.com>
    commit a8c8f4a5010d6a2b565ca411c3541f9698f3ad49
    Merge: cfb6abf ffa3c96
    Author: Sam Hague <shague@redhat.com>
    Date:   Tue Oct 13 13:10:11 2015 +0000

        Merge "UT for southbound/transactions/md - set 4"

    commit cfb6abf8d000ebca1f7585e1cda58cd82e21f329
    Author: Anil Vishnoi <vishnoianil@gmail.com>
    Date:   Tue Oct 13 13:34:24 2015 +0530

        Fix issue that was causing integration test failure.

        In case of controller initiated connection, iid stamping
        was not happening. Before clustering code merge, iid stamping
        was done in updateData(), but after clustering code merge,
        it does not allow to make any changes to the device till
        owner of the device is selected by EntityOnwershipService,
        so updateData() was not stamping the iid to swtich. With this
        fix, once owner of the device is selected, it explictly stamp
        iid to the switch.

        NOTE: we should revert following patch before merging this patch
        https://git.opendaylight.org/gerrit/#/c/28309/1

        I ran the integration suit locally and it passes all the tests

        [main] INFO org.ops4j.pax.exam.spi.reactors.ReactorManager - suite finished
        Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 288.094 sec - in org.opendaylight.ovsdb.southbound.it.SouthboundIT

        Results :

        Tests run: 22, Failures: 0, Errors: 0, Skipped: 0

        Change-Id: I35d6e0a4fa94eef019420e9b9603873d5088a934
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
    commit 91c15602a6323fb4dec0dc2605c853689844aec6
    Author: Flavio Fernandes <ffernand@redhat.com>
    Date:   Tue Oct 13 11:04:46 2015 +0000

        Revert "Temp workaround to debug southbound IT"

        This reverts commit 149c5bfb602e91f07c2b98f9509d317be8fcaa3c.

        Change-Id: I78aa7b506f32e37b65cae1bfb24bbb360c5359ad
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
    commit 149c5bfb602e91f07c2b98f9509d317be8fcaa3c
    Author: Sam Hague <shague@redhat.com>
    Date:   Mon Oct 12 20:50:25 2015 -0400

        Temp workaround to debug southbound IT

        It is a timing change from the clustering code not taking into account some crazy existing code.

        This patch has a workaround that works in my local tests. I will merge it temporarily to see if the jenkins builds are good.

        Will work with Anil and Flavio on a long term solution.

        Old code:

        write ovsdb node to config ->
        -> dcl ->
        -> connect -> connect -> connectedButCallbacksNotRegistered -> putConnectionInstance
        -> updateData -> OvsdbNodeUpdateCommand - > ovsdb node - set Open_vSwitch external_ids
        *** key here is that the putConnectionInstance happened earlier in connect so now the OvsdbNodeUpdateCommand gets a chance to run and write the externalIds to the Open_vSwitch table
        ...
        OvsdbMonitorCallback -> OpenVSwitchUpdateCommand - > writes node to operational
        *** key here is that the iid (nodePath) is found by looking for the externalIds. If found, since it was written earlier, then it is used, if not the backup of using the uuid of the node is used. The IT expects the externalIds value to be there and that is the one with the form ip:port.

        In the new code:
        - putConnectionInstance() does not happen until the handleOwnership completes - too late since the updateData is processed before that
        - updateData doesn't do anything, complains about not finding client since the connectionInstance was not written earlier, therefore the externalIds are not written
        - OpenVSwitchUpdateCommand ends up using the wrong iid of the form using the uuid since the externalIds were not written.

        Change-Id: Iafbb8c4fa3dd5708f4c4bd3242e27ec72a4b4c6e
Signed-off-by: Sam Hague <shague@redhat.com>
    commit a536890a609e1b28cce86a616c11447b839c1348
    Author: Andre Fredette <afredette@redhat.com>
    Date:   Tue Oct 6 17:33:15 2015 -0400

        Bug 4144 - Periodic ARP resolver should use unicast MAC destination
        address whenever possible; instead of broadcast

        Modified ArpResolver and GatewayMacResolverService to use the unicast DA
        when known.  The code treats the DA as known for a new ARP request if
        one of the last N=2 ARP request was answered.

        Change-Id: I2bd7791b74d41e2838edf59d6edc510b63f3c40b
Signed-off-by: Andre Fredette <afredette@redhat.com>
    commit 1c4bfda9a0f94a2a97c58a918f945f4e1e3d4688
    Author: Vishal Thapar <vishal.thapar@ericsson.com>
    Date:   Mon Oct 12 14:22:57 2015 +0530

        hwvtep: version bump to 1.2.1

        Update hwvtep poms as per this:
        https://git.opendaylight.org/gerrit/#/c/25574/

        Change-Id: I651a4e475e9bf243497ce07386e7418141f2fc3c
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
    commit 685f586c67dc369259fc53a001f3d8297c6d8351
    Author: Sam Hague <shague@redhat.com>
    Date:   Fri Oct 9 16:22:56 2015 -0400

        Add setting controller for sfc it

        This patch adds setting the controller so that flows can be pushed to the switches.

        Use the following to initate the tests:

        start an ovsdb node and set it to be in passive mode: sudo ovs-vsctl set-manager ptcp:6640
        cd .../net-virt-sfc/it
        mvn -Dit.test=NetvirtSfcIT#testDoIt verify -Pintegrationtest -Dovsdbserver.ipaddress=192.168.120.31

        The above will connect to the node and set's it controller to ODL.

        Change-Id: Ibf307b668535e47fe80ba0a8b7403e53d7a40ccb
Signed-off-by: Sam Hague <shague@redhat.com>
    commit ffa3c96aab514cfaba4e0eb543fe6956d3dfdb13
    Author: Rashmi Pujar <rpujar@inocybe.com>
    Date:   Fri Oct 9 12:37:06 2015 -0400

        UT for southbound/transactions/md - set 4

        8. OvsdbManagersUpdateCommand.java
        9. OvsdbNodeRemoveCommand.java
        10. OvsdbOperationalCommandAggregator.java

        Change-Id: I4597340cb871fb6b8558f2632ad71423a3cb8176
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
    commit f7f42fbacd178a843009a07bb21816afa83707b3
    Author: sangeeta.maurya <sangeeta.maurya@hp.com>
    Date:   Fri Oct 9 04:58:00 2015 +0545

        All TCP & UDP SG Rules : Implementation and Unit tests added.

        Change-Id: I4a00740fed78ab416fe22214fa7542ae7036f6fc
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
    Change-Id: I95183dca8f6a8f628c5937e94ae7a098c536d14f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 6380f7393d6974de911a1ee31589fae5aa6b9395
Author: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Date:   Fri Oct 9 00:54:24 2015 +0530

    Support added for modifying a security group associated with a port.

    Change-Id: I7bc5d4d790676eea380803af8af7591a19e9e00a
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
commit d4b6c92bb6e10d84783d5ca1037018ec1c0be12f
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Fri Oct 9 16:42:53 2015 -0400

    Rev up on neutron mdsal

    Change-Id: I3a5d579455a8dcc6c5f67f420a879d78b7160be5
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 71ca5bff6921d7e1bc8e0ae70df94f34677d4f65
Merge: b172da3 5c20432
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Fri Oct 9 16:15:40 2015 -0400

    Merge branch 'master' into topic/master/neutron-yang-migration.wip

    Change-Id: I80eaa18b7e09acda944310fe2d6fd8bf7864aae0
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit b172da376fc5090347f1592786fcac62bb6c1879
Merge: 203fe0e 0cbdadc
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu Oct 8 20:17:59 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     openstack/net-virt-providers/src/test/java/org/opendaylight/ovsdb/openstack/netvirt/providers/openflow13/services/EgressAclServiceTest.java

    Change-Id: I170b630be63898fb2386377a65e297334ea70119
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 203fe0e97e86753f200fbbba3217e1e24330392b
Merge: 74b4518 f6b2a1e
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed Oct 7 00:57:16 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Change-Id: I496a2b2aade88bc318763a77d4e878e5e11e97f8
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 74b45187dc5f4c1982ae2a9554434c1546604b82
Merge: d2853aa 83cfd5b
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Oct 2 19:59:13 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/ConfigActivator.java

    Change-Id: Ic7d248e43b7f41fa7a17b8a2c371647e5c54e302
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit d2853aa6b7ef1aea8b93a6ed5ccbc81c1df2dc13
Merge: bdbce26 7848a77
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu Oct 1 14:44:12 2015 -0400

    Merge branch 'master' into topic/master/neutron-yang-migration

    Change-Id: I9c76cf1adf765b351c45fe93260ca89f596383c1
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit bdbce26b1905fe7d349cc65966046253e38aceb9
Merge: 0ecfc12 0179232
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu Oct 1 03:48:35 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     integrationtest/src/test/java/org/opendaylight/ovsdb/integrationtest/ovsdbclient/OvsdbTestBase.java
     northbound/src/test/java/org/opendaylight/ovsdb/northbound/NodeResourceTest.java
     northbound/src/test/java/org/opendaylight/ovsdb/northbound/OvsdbNorthboundV3Test.java

    Change-Id: Ie64d7e8d21250859b583a5f6b1b5b112a4b70c84
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 0ecfc1294aa2e1047162215cb9d1bb38d0bc70fb
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat Sep 26 04:50:05 2015 +0530

    Fix minor changese in NeutronSecurityRule attributes values

    Change-Id: Ib2fb0b195dd9e671627acfcd8741246c035fc237
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 98290241988633a61aa36bd0de6756c2f27f8817
Merge: 387c461 708c8c3
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Sep 25 08:13:48 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Change-Id: I4d2d1cda0138e4647580b790ce9131c077e09f81
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 387c4618bf4d52acf2cfa5e3ea1772975c6541ac
Merge: 8d6fd60 b398044
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu Sep 24 02:39:11 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     integrationtest/src/test/java/org/opendaylight/ovsdb/integrationtest/ConfigurationBundles.java
     ovsdb-plugin-compatibility-layer/src/test/java/org/opendaylight/ovsdb/compatibility/plugin/impl/ConnectionServiceImplTest.java
     plugin-shell/src/test/java/org/opendaylight/ovsdb/plugin/shell/PrintCacheTest.java
     plugin/src/test/java/org/opendaylight/ovsdb/plugin/impl/ConnectionServiceImplTest.java

    Change-Id: Ic5c81688c9cf8cf7fccdbe8c90eb90d8cbd66c94
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 8d6fd60eec27d9373fb8687b1418436f1e94eb9f
Merge: fed891b 5bc4327
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Sep 18 22:16:41 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit fed891b235315b840c70bced882c7972d1bf49f7
Merge: 985d450 b388ea4
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu Sep 17 14:13:28 2015 +0000

    Merge "Misc Fix: Handle neutron port that is not associated with a tenant id" into topic/master/neutron-yang-migration

commit 985d45084a55be99873992d75400d52210d81de0
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu Sep 17 01:13:45 2015 -0400

    SecGroup: Handle cases when security group has empty rules

    Change-Id: I54ef43f6a4afd9fc571c8dcf9bf843007452c968
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit b388ea424d6a072bdec66cc792598415744e06d0
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu Sep 17 01:01:56 2015 -0400

    Misc Fix: Handle neutron port that is not associated with a tenant id

    (e.g. external gw port)

    Change-Id: I2e3496303d78767b691d9129bc14c86572ce8acf
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 99081a0ab8dbed12ec76c4230256a5f918989cdc
Author: Stephen Kitt <skitt@redhat.com>
Date:   Wed Sep 16 11:14:03 2015 +0200

    Document how to use Docker Compose

    Fig has been obsoleted by Docker Compose. Some distributions have now
    replaced Fig entirely (e.g. Fedora 22); this patch documents Docker
    Compose as an alternative to Fig.

    Change-Id: Ia33bb8633e7c2f039857b98ba96e9b8b343d0394
Signed-off-by: Stephen Kitt <skitt@redhat.com>
commit 9bb0f33598e40c6a5829b8be56597f90b534162b
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Wed Sep 16 02:19:35 2015 -0400

    A few cleanups

    * use plain String concatenation instead of StringBuilder where appropriate
    * simplify single-use return variables
    * <> operator
    * avoid calling new String()

    Change-Id: I56e99426daeda620a37059417588e5ee4fb99c76
Also-By: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit a2fdb4a16358da8c2bc565c3b84589290f5de9d8
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 15 22:58:34 2015 +0000

    Revert "Use single-argument form of firstKeyOf()"

    This reverts commit e19e4e3f10f65054aba16a94c082180f24b9beb6.

    This is breaking the net-virt code. Bridges are not getting created when OVSDB server connects to the controller. Probably happening because of single argument firstKeyOf() method.

    Change-Id: I76ab5f86f7329f741e30fd21eaed436391f793b8
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 64d86b6ad9b7fd54eaf708cb7654177fea344ef4
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed Sep 16 01:59:24 2015 +0530

    Added Security Group and Security Rule data change listeners

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 218b94228d407a5cc8d9c52550eabc2ef96e0a29
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed Sep 16 01:23:46 2015 +0530

    Fixed the instanceof checks

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 4167a9762eb08930c86209028a21c618f167bb29
Merge: 1188baa b085ce8
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 15 21:43:34 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 1188baa0e84249e202aab52d82dbb435552801aa
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 15 04:41:56 2015 +0530

    Fixed classcast exceptions while processing the events

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 79e5a3a8271e4021cb79d6a83177866bd1acc771
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 15 01:17:25 2015 +0530

    Fix single feature test failures

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit d1d6e81d0cf0dc21aa64c8e94ab993622c8f574d
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Sep 14 17:52:24 2015 +0530

    Fixed local lbaas code to accomodate the model changes done in neutron yang models

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 1393eb861d1011c2285e065e28dc971dc52eae76
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat Sep 12 04:01:33 2015 +0530

    Added dummy provider as a dependency

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 09354754ab1fdf042327667f467f88483f24ab38
Merge: 272a6c1 53770e6
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Sep 11 17:01:33 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

    Conflicts:
     openstack/net-virt/pom.xml
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 272a6c15978aabae127a112f18f27d537828e931
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Wed Sep 2 18:11:28 2015 -0400

    Add NeutronLoadBalancerPoolMemberChangeListener

    Plus other minor fixes.

    Patch set 2: resolve fixmes.

    Change-Id: I75e6106f1cf5bb72370983bebe9568704dcef36a
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 5c815ff07f95721790a1dab87210bd19b82f3a15
Merge: 4029f04 55ff806
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed Sep 2 20:24:08 2015 +0000

    Merge "Add NeutronLoadBalancerPoolChangeListener" into topic/master/neutron-yang-migration

commit 55ff80613eb153260007d3d2006cbe6354819db6
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Wed Sep 2 16:09:49 2015 -0400

    Add NeutronLoadBalancerPoolChangeListener

    Change-Id: Icb570f780c3f67e3ee67dc3366fc059e981ff176
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 4029f04004d7db4e1f4562f26b98b3966c1092db
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Wed Sep 2 11:37:25 2015 -0400

    Cosmetics: Fix Copyright (try 2)

Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit d8169714e9fe8880f3a10c680851ff500e4b1696
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Aug 31 04:08:06 2015 +0530

    Fixed unit tests

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 6f4f4005cf28367b5d2e10d50246189abaa8f600
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Aug 31 03:20:03 2015 +0530

    Implemented INeutronFloatingIPAware notification provider.
    This implementation subscribe for data change notification from /neutorn/floatingips/floatingip path
    and call the *iaware methods according to the changes (create, update, delete) it receives
    from data store.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 60445afc56d355a593223221d2182a6f3c53a307
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Aug 31 02:31:20 2015 +0530

    Implemented INeutronRouterAware notification provider.
    This implementation subscribe for data change notification from /neutorn/routers/router path
    and call the *iaware methods according to the changes (create, update, delete) it receives
    from data store.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit fda2cd8556790bacff1e55efc1276f899cdb8b9c
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Aug 31 02:06:13 2015 +0530

    Implemented INeutronPortAware notification provider.
    This implementation subscribe for data change notification from /neutorn/ports/port path
    and call the *iaware methods according to the changes (create, update, delete) it receives
    from data store.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 8a67f0db43b6c07d2560916b21cfb9c46f57bf7f
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Mon Aug 31 01:32:01 2015 +0530

    Implemented INeutronSubnetAware notification provider.
    This implementation subscribe for data change notification from /neutorn/subnets/subnet path
    and call the *iaware methods according to the changes (create, update, delete) it receives
    from data store.

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit cdcc657f2e684c8595f7ff76553c3ea3255ba395
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Aug 28 23:49:14 2015 +0530

    Implement Neutron Network data change listener
    This patch listens on the /Neutron/Networks/Network path of Neutron network yang model and
    convert it to NeutronNetwork pojo (existing pojo's that's in use by net-virt) and call the
    respective method of implementor of INeutronNetworkAware interface

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit fb7c9891641b1b4822a8dbade472da55779d1300
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat Aug 29 03:10:44 2015 +0530

    Add CRUD interface implementation to ovsdb net-virt.
    This code is borrowed from the neutron northbound project. I cleaned up few of the CRUD implementation file that is not required
    for the net-virt. Few of the existing CRUD interface implementation is still based on the ConcurrentHashMap, which we need to migrate
    to the data store based implementation. This patch hooks these services locally so that only ovsdb net-virt can consume these services

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit a2c8738b0b703eaa6c04f6f49694e1fe035216ad
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Aug 28 20:35:46 2015 +0530

    Code refactoring: moved CRUD interface and IAware interface to their own packages

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 76d01ae3060835cbcd9bd469058033e7bcd5dc48
Merge: cb5f2d9 ff7ddc7
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat Aug 29 03:39:18 2015 +0530

    Merge branch 'master' into topic/master/neutron-yang-migration

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit cb5f2d9d3ebc9952030aecd83e7a71c770fe41ea
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu Aug 27 17:51:23 2015 +0530

    Neutron-Yang-Migration: Intial code for translator layer

Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Id18f4fc26f018673f08ef10ddd86850922b7265b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoNeuter NetvirtSfcIT
Sam Hague [Thu, 15 Oct 2015 19:43:49 +0000 (15:43 -0400)]
Neuter NetvirtSfcIT

Change-Id: I8e7f7cf652d87ed5e64d1b7aae525c9da1947a81
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBUG 4208 - Unstack and restack existing compute
ravi_sabapathy [Mon, 28 Sep 2015 15:15:11 +0000 (08:15 -0700)]
BUG 4208 - Unstack and restack existing compute

Loop through all the ports in the same network
and add the VM's unicast mac rule of the destination
node in the source node.
Change-Id: I73c0056e1a8386ffbab71a7a5732e81791eb6c88
Signed-off-by: ravi_sabapathy <ravi_sabapathy@dell.com>
(cherry picked from commit ad0cb7e3855721477e5d98a8e7988492ab16771f)

8 years agoMerge "Adding copyright header to ovsdb/southbound UT"
Flavio Fernandes [Thu, 15 Oct 2015 17:17:06 +0000 (17:17 +0000)]
Merge "Adding copyright header to ovsdb/southbound UT"

8 years agoAdd postman collection for NetvirtSfc
Sam Hague [Thu, 15 Oct 2015 16:08:13 +0000 (12:08 -0400)]
Add postman collection for NetvirtSfc

Change-Id: Ibe16df4c9d789311b185a9f7cb0193b7a81f5aba
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoRemove unused BundleContext from NetvirtSfc
Sam Hague [Thu, 15 Oct 2015 13:50:46 +0000 (09:50 -0400)]
Remove unused BundleContext from NetvirtSfc

Change-Id: I7d9d185710f82546472d733796ebc2cba2e3a671
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdding copyright header to ovsdb/southbound UT
Rashmi Pujar [Thu, 15 Oct 2015 13:39:33 +0000 (09:39 -0400)]
Adding copyright header to ovsdb/southbound UT

Change-Id: I92d1f02491f04177b97a1ece879da9278220801b
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoMerge "All TCP & UDP SG Rules : Implementation and Unit tests added."
Flavio Fernandes [Thu, 15 Oct 2015 11:59:38 +0000 (11:59 +0000)]
Merge "All TCP & UDP SG Rules : Implementation and Unit tests added."

8 years agoMerge "UT for southbound/transactions/md - set 5"
Flavio Fernandes [Thu, 15 Oct 2015 11:56:48 +0000 (11:56 +0000)]
Merge "UT for southbound/transactions/md - set 5"

8 years agoMerge "Bug 4472 - netvirt: IlligalArgumentException in NAT provider"
Flavio Fernandes [Thu, 15 Oct 2015 11:51:55 +0000 (11:51 +0000)]
Merge "Bug 4472 - netvirt: IlligalArgumentException in NAT provider"

8 years agoMerge "cleanup NetvirtSfcIT"
Sam Hague [Thu, 15 Oct 2015 01:37:31 +0000 (01:37 +0000)]
Merge "cleanup NetvirtSfcIT"

8 years agocleanup NetvirtSfcIT
Sam Hague [Thu, 15 Oct 2015 01:12:16 +0000 (21:12 -0400)]
cleanup NetvirtSfcIT

Change-Id: I1cc224a7ab4f65825feefe6de28fb787ca7e2f1c
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBug 4472 - netvirt: IlligalArgumentException in NAT provider
Isaku Yamahata [Wed, 14 Oct 2015 22:06:19 +0000 (15:06 -0700)]
Bug 4472 - netvirt: IlligalArgumentException in NAT provider

This patch adds work around code for ipv6 cidr notation is given.
Otherwise following exception occurs.

> 2015-10-14 13:38:55,125 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramRouterInterface failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1/64 node:ovsdb://uuid/8f75c49c-52b9-4303-8633-a80f0361429b/bridge/br-int srcTunId:external destTunId:1083 action:ADD status:Not Implemented: Not Implemented (0)
> 2015-10-14 13:38:55,126 | DEBUG | ntDispatcherImpl | ArpResponderService              | 393 - org.opendaylight.ovsdb.openstack.net-virt-providers - 1.2.1.SNAPSHOT | ipv6 address case is not implemented yet. dpid 209308480409166 segmentationId 1083 macAddressStr, ipAddress FA:16:3E:E0:A8:B5 action /fd14:5ac7:ba3:0:0:0:0:1
> 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | NeutronL3Adapter                 | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | ProgramStaticArp failed for mac:FA:16:3E:E0:A8:B5 addr:fd14:5ac7:ba3::1 dpid:209308480409166 segOrOfPort:1083 action:ADD status:Not Implemented: Not Implemented (0)
> 2015-10-14 13:38:55,126 | ERROR | ntDispatcherImpl | EventDispatcher                  | 392 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event NorthboundEvent [handler=NEUTRON_PORT, action=ADD, port=NeutronPort [portUUID=4b19acf4-d644-4fe7-8643-852c25cbf604, networkUUID=821f7a2b-b991-48b0-a39c-b0ef264bd321, name=, adminStateUp=true, status=ACTIVE, macAddress=FA:16:3E:E0:A8:B5, fixedIPs=[Neutron_IPs{ipAddress='fd14:5ac7:ba3::1', subnetUUID='54a7f233-1fdb-4d40-bd44-275f180e9a64'}], deviceID=738d6a7c-43bd-469d-bfed-6bcc6ffe5dca, deviceOwner=network:router_interface, tenantID=dc27e3a1cff64a1cb85c7f24899c3eee, securityGroups=[], bindinghostID=, bindingvnicType=normal, bindingvnicType=normal], subnet=null, router=null, routerInterface=null, floatingIP=null, network=null, loadBalancer=null, loadBalancerPool=null, loadBalancerPoolMember=null]
> java.lang.IllegalArgumentException: Supplied value "fd14:5ac7:ba3::/64" does not match required pattern "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/(([0-9])|([1-2][0-9])|(3[0-2]))$"
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[64:com.google.guava:18.0.0]
>         at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Prefix.<init>(Ipv4Prefix.java:49)[216:org.opendaylight.mdsal.model.ietf-inet-types:2010.9.24.8-SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.providers.openflow13.services.OutboundNatService.programIpRewriteExclusion(OutboundNatService.java:167)[393:org.opendaylight.ovsdb.openstack.net-virt-providers:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage2(NeutronL3Adapter.java:1143)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programIpRewriteExclusionStage1(NeutronL3Adapter.java:1128)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.programFlowsForNeutronRouterInterface(NeutronL3Adapter.java:807)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronRouterInterfaceEvent(NeutronL3Adapter.java:298)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:245)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.doNeutronPortCreated(PortHandler.java:66)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.processEvent(PortHandler.java:161)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:95)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:28)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:57)[392:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_60]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_60]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]

Change-Id: I1559667adde1c14b5627df3b7212e404998ce897
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
8 years agoFirst pass for ovsdb-ui
Maxime Millette-Coulombe [Wed, 22 Jul 2015 15:53:30 +0000 (11:53 -0400)]
First pass for ovsdb-ui

Revamp of the work already done. Adding a draft of a
logical topology viewer. The old code is still in this
commit because the works done before will be reuse.

Change-Id: Ia3a86cb0370cfad2ef3c2a156b412b9e029c3bf9
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
8 years agoUT for southbound/transactions/md - set 5
Rashmi Pujar [Wed, 14 Oct 2015 19:03:17 +0000 (15:03 -0400)]
UT for southbound/transactions/md - set 5

11. OvsdbPortRemoveCommand.java
12. TransactionInvokerImpl.java
13. OvsdbPortUpdateCommand.java

Change-Id: Icd9ad76e482de5408650916f6bbf5bc73dc297c8
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoneuter NetvirtSfcIT
Sam Hague [Wed, 14 Oct 2015 17:29:47 +0000 (13:29 -0400)]
neuter NetvirtSfcIT

Change-Id: Iaca49229b1c594a9e2b5659048319880643887ec
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "add ovsdb-sfc feature to test feature"
Sam Hague [Wed, 14 Oct 2015 15:32:29 +0000 (15:32 +0000)]
Merge "add ovsdb-sfc feature to test feature"

8 years agoadd ovsdb-sfc feature to test feature
Sam Hague [Wed, 14 Oct 2015 14:49:05 +0000 (10:49 -0400)]
add ovsdb-sfc feature to test feature

Change-Id: I55c2df5791983998f696054b7728b7d1be696e33
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Add capability on southbound to NetvirtSfc"
Sam Hague [Wed, 14 Oct 2015 13:19:56 +0000 (13:19 +0000)]
Merge "Add capability on southbound to NetvirtSfc"

8 years agoAdd capability on southbound to NetvirtSfc
Sam Hague [Wed, 14 Oct 2015 13:02:51 +0000 (09:02 -0400)]
Add capability on southbound to NetvirtSfc

Change-Id: Iffd6b7b27e701fdfa3bf663421ba72945562d0f1
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Workaround to fix net-virt-it"
Sam Hague [Wed, 14 Oct 2015 04:55:31 +0000 (04:55 +0000)]
Merge "Workaround to fix net-virt-it"

8 years agoWorkaround to fix net-virt-it
Sam Hague [Wed, 14 Oct 2015 04:23:59 +0000 (00:23 -0400)]
Workaround to fix net-virt-it

Change-Id: I10838b993f60b5e3859780d7d9f7b4c3630e312a
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "UT for southbound/transactions/md - set 4"
Sam Hague [Tue, 13 Oct 2015 13:10:11 +0000 (13:10 +0000)]
Merge "UT for southbound/transactions/md - set 4"

8 years agoFix issue that was causing integration test failure.
Anil Vishnoi [Tue, 13 Oct 2015 08:04:24 +0000 (13:34 +0530)]
Fix issue that was causing integration test failure.

In case of controller initiated connection, iid stamping
was not happening. Before clustering code merge, iid stamping
was done in updateData(), but after clustering code merge,
it does not allow to make any changes to the device till
owner of the device is selected by EntityOnwershipService,
so updateData() was not stamping the iid to swtich. With this
fix, once owner of the device is selected, it explictly stamp
iid to the switch.

NOTE: we should revert following patch before merging this patch
https://git.opendaylight.org/gerrit/#/c/28309/1

I ran the integration suit locally and it passes all the tests

[main] INFO org.ops4j.pax.exam.spi.reactors.ReactorManager - suite finished
Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 288.094 sec - in org.opendaylight.ovsdb.southbound.it.SouthboundIT

Results :

Tests run: 22, Failures: 0, Errors: 0, Skipped: 0

Change-Id: I35d6e0a4fa94eef019420e9b9603873d5088a934
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoRevert "Temp workaround to debug southbound IT"
Flavio Fernandes [Tue, 13 Oct 2015 11:04:46 +0000 (11:04 +0000)]
Revert "Temp workaround to debug southbound IT"

This reverts commit 149c5bfb602e91f07c2b98f9509d317be8fcaa3c.

Change-Id: I78aa7b506f32e37b65cae1bfb24bbb360c5359ad
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoTemp workaround to debug southbound IT
Sam Hague [Tue, 13 Oct 2015 00:50:25 +0000 (20:50 -0400)]
Temp workaround to debug southbound IT

It is a timing change from the clustering code not taking into account some crazy existing code.

This patch has a workaround that works in my local tests. I will merge it temporarily to see if the jenkins builds are good.

Will work with Anil and Flavio on a long term solution.

Old code:

write ovsdb node to config ->
-> dcl ->
-> connect -> connect -> connectedButCallbacksNotRegistered -> putConnectionInstance
-> updateData -> OvsdbNodeUpdateCommand - > ovsdb node - set Open_vSwitch external_ids
*** key here is that the putConnectionInstance happened earlier in connect so now the OvsdbNodeUpdateCommand gets a chance to run and write the externalIds to the Open_vSwitch table
...
OvsdbMonitorCallback -> OpenVSwitchUpdateCommand - > writes node to operational
*** key here is that the iid (nodePath) is found by looking for the externalIds. If found, since it was written earlier, then it is used, if not the backup of using the uuid of the node is used. The IT expects the externalIds value to be there and that is the one with the form ip:port.

In the new code:
- putConnectionInstance() does not happen until the handleOwnership completes - too late since the updateData is processed before that
- updateData doesn't do anything, complains about not finding client since the connectionInstance was not written earlier, therefore the externalIds are not written
- OpenVSwitchUpdateCommand ends up using the wrong iid of the form using the uuid since the externalIds were not written.

Change-Id: Iafbb8c4fa3dd5708f4c4bd3242e27ec72a4b4c6e
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBug 4144 - Periodic ARP resolver should use unicast MAC destination
Andre Fredette [Tue, 6 Oct 2015 21:33:15 +0000 (17:33 -0400)]
Bug 4144 - Periodic ARP resolver should use unicast MAC destination
address whenever possible; instead of broadcast

Modified ArpResolver and GatewayMacResolverService to use the unicast DA
when known.  The code treats the DA as known for a new ARP request if
one of the last N=2 ARP request was answered.

Change-Id: I2bd7791b74d41e2838edf59d6edc510b63f3c40b
Signed-off-by: Andre Fredette <afredette@redhat.com>
8 years agohwvtep: version bump to 1.2.1
Vishal Thapar [Mon, 12 Oct 2015 08:52:57 +0000 (14:22 +0530)]
hwvtep: version bump to 1.2.1

Update hwvtep poms as per this:
https://git.opendaylight.org/gerrit/#/c/25574/

Change-Id: I651a4e475e9bf243497ce07386e7418141f2fc3c
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
8 years agoAdd setting controller for sfc it
Sam Hague [Fri, 9 Oct 2015 20:22:56 +0000 (16:22 -0400)]
Add setting controller for sfc it

This patch adds setting the controller so that flows can be pushed to the switches.

Use the following to initate the tests:

start an ovsdb node and set it to be in passive mode: sudo ovs-vsctl set-manager ptcp:6640
cd .../net-virt-sfc/it
mvn -Dit.test=NetvirtSfcIT#testDoIt verify -Pintegrationtest -Dovsdbserver.ipaddress=192.168.120.31

The above will connect to the node and set's it controller to ODL.

Change-Id: Ibf307b668535e47fe80ba0a8b7403e53d7a40ccb
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdd southbound to sfc it
Sam Hague [Fri, 9 Oct 2015 19:25:47 +0000 (15:25 -0400)]
Add southbound to sfc it

Change-Id: I1627b92af8a919063d9214d57117741809525134
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdd southbound utils.
Sam Hague [Fri, 9 Oct 2015 18:57:28 +0000 (14:57 -0400)]
Add southbound utils.

This commit is copying the duplicated integration test code
for manipulating the southbound into a utils bundle. This
code is duplicated in the netvirt-it, setvirtsfc-it and southbound-it.
We will slowly migrate them to use this new utils bundle.

Change-Id: If3197fe3bcf50c12faff70cd01426b695686dd83
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoUT for southbound/transactions/md - set 4
Rashmi Pujar [Fri, 9 Oct 2015 16:37:06 +0000 (12:37 -0400)]
UT for southbound/transactions/md - set 4

8. OvsdbManagersUpdateCommand.java
9. OvsdbNodeRemoveCommand.java
10. OvsdbOperationalCommandAggregator.java

Change-Id: I4597340cb871fb6b8558f2632ad71423a3cb8176
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoMerge "UT for southbound/transactions/md - set 3"
Flavio Fernandes [Fri, 9 Oct 2015 12:07:45 +0000 (12:07 +0000)]
Merge "UT for southbound/transactions/md - set 3"

8 years agoMerge "Remove unused code"
Flavio Fernandes [Fri, 9 Oct 2015 12:06:41 +0000 (12:06 +0000)]
Merge "Remove unused code"

8 years agoAdd IT for netvirtsfc mdsal read/write/delete
Sam Hague [Thu, 8 Oct 2015 20:34:14 +0000 (16:34 -0400)]
Add IT for netvirtsfc mdsal read/write/delete

To run the integration tests:
- cd ../ovsdb/openstack/net-virt-sfc
- mvn clean install -Pintegrationtest

Change-Id: I191ace9c510a63bca59d99009eca8e970566f3f9
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAll TCP & UDP SG Rules : Implementation and Unit tests added.
sangeeta.maurya [Thu, 8 Oct 2015 23:13:00 +0000 (04:58 +0545)]
All TCP & UDP SG Rules : Implementation and Unit tests added.

Change-Id: I4a00740fed78ab416fe22214fa7542ae7036f6fc
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
8 years agoUT for southbound/transactions/md - set 3
Rashmi Pujar [Thu, 8 Oct 2015 18:24:54 +0000 (14:24 -0400)]
UT for southbound/transactions/md - set 3

6. OvsdbControllerUpdateCommand.java
7. OvsdbManagersRemovedCommand.java

Change-Id: Idcb7ff1ad8f414cb243ae766e69d6437d0bee93f
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoRemove unused code
Anil Vishnoi [Thu, 8 Oct 2015 16:22:57 +0000 (21:52 +0530)]
Remove unused code

Conflicts:
openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/api/UuidUtils.java

Change-Id: I09b2e4eee6e88d68c63fdbea8e7e42da790576e9
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoMerge "UT for southbound/transactions/md - set 2"
Sam Hague [Wed, 7 Oct 2015 22:42:02 +0000 (22:42 +0000)]
Merge "UT for southbound/transactions/md - set 2"

8 years agoMerge "If controller joins the cluster late, and the owner of the device is already...
Flavio Fernandes [Wed, 7 Oct 2015 21:23:35 +0000 (21:23 +0000)]
Merge "If controller joins the cluster late, and the owner of the device is already decided, EntityOwnershipService won't notify new candidate that register for ownership. Adding a proactive check on the ownership state of the device, so if it's already owned, adding the connection instances in the connection cache."

8 years agoUT for southbound/transactions/md - set 2
rpujar [Wed, 7 Oct 2015 20:29:28 +0000 (16:29 -0400)]
UT for southbound/transactions/md - set 2

4. OvsdbBridgeUpdateCommand.java
5. OvsdbControllerRemovedCommand.java

Change-Id: Idc469c08351b1e98129dd9e798c07a660d782709
Signed-off-by: rpujar <rpujar@inocybe.com>
8 years agoCleanup netvirtsfc poms
Sam Hague [Wed, 7 Oct 2015 17:22:54 +0000 (13:22 -0400)]
Cleanup netvirtsfc poms

Change-Id: I6c1a3aa44c75f98d226dcf23dd514a31f5df5d2a
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoBump mdsal-utils version to match other bundles
Sam Hague [Wed, 7 Oct 2015 17:22:13 +0000 (13:22 -0400)]
Bump mdsal-utils version to match other bundles

Change-Id: I6c5166ae27fd2f055217be95630cbc482261bb61
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "UT for southbound/transactions/md"
Sam Hague [Wed, 7 Oct 2015 13:38:27 +0000 (13:38 +0000)]
Merge "UT for southbound/transactions/md"

8 years agoMerge "Fix checkstyle issues in netvirtsfc"
Sam Hague [Wed, 7 Oct 2015 00:36:02 +0000 (00:36 +0000)]
Merge "Fix checkstyle issues in netvirtsfc"

8 years agoIf controller joins the cluster late, and the owner of the device
Anil Vishnoi [Tue, 6 Oct 2015 20:41:25 +0000 (02:11 +0530)]
If controller joins the cluster late, and the owner of the device
is already decided, EntityOwnershipService won't notify new candidate that register
for ownership. Adding a proactive check on the ownership state of the device,
so if it's already owned, adding the connection instances in the connection cache.

Change-Id: I7e87b55599f0ebd408814d72789c86f231b7907c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoUT for southbound/transactions/md
rpujar [Tue, 6 Oct 2015 19:56:23 +0000 (15:56 -0400)]
UT for southbound/transactions/md

1. AbstractTransactionCommand.java
2. OpenVSwitchUpdateCommand.java
3. OvsdbBridgeRemovedCommand.java

Change-Id: I7655dec526bc06b770c533dd082eb403bc89a2c7
Signed-off-by: rpujar <rpujar@inocybe.com>
8 years agoMerge "Send a canonical IPv4 prefix in table 60 routing rules"
Sam Hague [Tue, 6 Oct 2015 19:48:18 +0000 (19:48 +0000)]
Merge "Send a canonical IPv4 prefix in table 60 routing rules"

8 years agoFix checkstyle issues in netvirtsfc
Sam Hague [Tue, 6 Oct 2015 19:45:13 +0000 (15:45 -0400)]
Fix checkstyle issues in netvirtsfc

Change-Id: I7db518959449958849a74c49a83bde1135ee325f
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoSend a canonical IPv4 prefix in table 60 routing rules
Eric Multanen [Fri, 2 Oct 2015 13:43:04 +0000 (06:43 -0700)]
Send a canonical IPv4 prefix in table 60 routing rules

Testing with userspace OVS with DPDK uncovered that the routing
rules that go into table 60 were getting rejected.

Messages from ovs-vswitchd.log:

... |nx_match|WARN|Rejecting NXM/OXM entry
    0:32768:12:1:8 with 1-bits in value for bits wildcarded by the mask.

... |connmgr|INFO|br-int<->tcp:10.11.21.7:6653:
    sending OFPBMC_BAD_WILDCARDS error reply to OFPT_FLOW_MOD message

Clearing the non-prefix bits resolved the problem and the flows were
successfully added.

v2 - split up long line into two more readable lines

Change-Id: I42a0c63e6e837197d29bb8333f12e822a5f15d91
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
8 years agoCustom ICMP SG Rule:
sangeeta.maurya [Tue, 6 Oct 2015 17:11:55 +0000 (22:56 +0545)]
Custom ICMP SG Rule:
1)Modification in ICMP matcher
2)Unit Test Improvement (Check added to validate if some values are set
properly).

Change-Id: I31fad80f6dd278372abe2b1a6aac95935aef5f17
Signed-off-by: sangeeta.maurya <sangeeta.maurya@hp.com>
8 years agoMerge "Southbound UT: Fix SouthboundMapper stackoverflow issue"
Sam Hague [Tue, 6 Oct 2015 18:43:20 +0000 (18:43 +0000)]
Merge "Southbound UT: Fix SouthboundMapper stackoverflow issue"

8 years agoMerge "Mechanical cleanup to SouthboundIT"
Sam Hague [Tue, 6 Oct 2015 18:15:31 +0000 (18:15 +0000)]
Merge "Mechanical cleanup to SouthboundIT"

8 years agoSouthbound UT: Fix SouthboundMapper stackoverflow issue
adetalhouet [Sat, 3 Oct 2015 22:24:30 +0000 (18:24 -0400)]
Southbound UT: Fix SouthboundMapper stackoverflow issue

Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
8 years agoMerge "Fix build issues for UT for updated SouthboundProvider.class"
Sam Hague [Tue, 6 Oct 2015 15:54:09 +0000 (15:54 +0000)]
Merge "Fix build issues for UT for updated SouthboundProvider.class"

8 years agoMerge "Net-virt-sfc Data Change Listener code first pass."
Sam Hague [Tue, 6 Oct 2015 15:32:08 +0000 (15:32 +0000)]
Merge "Net-virt-sfc Data Change Listener code first pass."

8 years agoNet-virt-sfc Data Change Listener code first pass.
arunsarat [Mon, 5 Oct 2015 20:32:20 +0000 (13:32 -0700)]
Net-virt-sfc Data Change Listener code first pass.

Change-Id: Ie1e8e4471b2bddf476b8a55a1d022d4ace517868
Signed-off-by: arunsarat <arunsarat@yahoo.com>
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoFix build issues for UT for updated SouthboundProvider.class
rpujar [Tue, 6 Oct 2015 13:46:31 +0000 (09:46 -0400)]
Fix build issues for UT for updated SouthboundProvider.class

Change-Id: If806d385d9399e514ea977a33fd9ab8008a8850b
Signed-off-by: rpujar <rpujar@inocybe.com>
8 years agoMerge "Add UT for SouthboundMapper and SouthboundProvider"
Flavio Fernandes [Mon, 5 Oct 2015 21:14:36 +0000 (21:14 +0000)]
Merge "Add UT for SouthboundMapper and SouthboundProvider"

8 years agoAdd UT for SouthboundMapper and SouthboundProvider
rpujar [Thu, 1 Oct 2015 15:43:34 +0000 (11:43 -0400)]
Add UT for SouthboundMapper and SouthboundProvider

Change-Id: I38776516b120cc16d123d37dcafb8d19c6fd7e21
Signed-off-by: rpujar <rpujar@inocybe.com>
8 years agoUse odlparent checkstyle
Sam Hague [Mon, 28 Sep 2015 21:21:34 +0000 (17:21 -0400)]
Use odlparent checkstyle

Patch set 2: Remove ovsdb_checks.xml from parent pom
Patch set 3: Remove ovsdb_checks.xml from directory
Patch set 4: Add hwvtepsouthbound

Change-Id: Iccc680728e19967f9977453bb75c9c64b1a53e0c
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Fix sonar integration test reporting"
Sam Hague [Sat, 3 Oct 2015 23:09:00 +0000 (23:09 +0000)]
Merge "Fix sonar integration test reporting"

8 years agoFix sonar integration test reporting
Sam Hague [Sat, 3 Oct 2015 01:20:10 +0000 (21:20 -0400)]
Fix sonar integration test reporting

Change-Id: Icb238c6442a8d15ae144d6e9abbaabf9fd011570
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdded postman collection and postman environment
Anil Vishnoi [Sat, 3 Oct 2015 01:33:33 +0000 (07:03 +0530)]
Added postman collection and postman environment
files for Southbound plugin to test in Single and 3 Node cluster environment

Change-Id: I144801f0200d607013b3fa839cabf1de7c3bf1d0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoMerge topic/master/clustering to master branch
Anil Vishnoi [Fri, 2 Oct 2015 17:08:10 +0000 (22:38 +0530)]
Merge topic/master/clustering to master branch
Squashed commit of the following:

commit e9e3a762ee75844b930d8251f44d2718a3358445
Merge: 2adbc25 83cfd5b
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Oct 2 19:54:23 2015 +0530

    Merge branch 'master' into topic/master/clustering

    Change-Id: I3c26c3f4095b78d869cae271b01fa1ab2609cf89
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 2adbc25b474d46f394e8f956c818383425570600
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Oct 2 07:22:44 2015 +0530

    Addressed following issuses:
    1) Fixed entity unregisteration
    2) Implemented logic for southbound provider to participate
    in entityOwnership service, Southbound plugin instance as an entity
    This will avoid all the instances to do initiatize the operational
    and config topology, only master instance (who got ownership) will do that.
    3) Properly closing listener registration for OvsdbConnectionManager listerner.

    Change-Id: I73693b4faa8a6409c81c33647836516002b4b2fd
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 193f145796924c051b36c61974df4253e68efb7e
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Thu Oct 1 16:54:41 2015 +0530

    Addressed following issues:
    1) Handled ownership change notifications for the device that is not registered by the instance.
    2) If there is no owner of the device hasOwner=false, then clean up the operational data store,
    3) For switch initiated connections, generate iid by fetching the openvswtich table row from the device.

    Change-Id: I03158a616e7c020ce8f851b8251e4162f38ba622
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit c26d79561555c23f4aec894418537cf059a1f85a
Merge: 740d21a 7848a77
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Thu Oct 1 14:42:00 2015 -0400

    Merge branch 'master' into topic/master/clustering

    Change-Id: I191e71030d6523a3d7a11765010cc1b81b9405f3
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 740d21afacb5a652a3a1d78ceff2c0d998492add
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Wed Sep 30 02:15:26 2015 +0530

    Fixed iid issue for switch initiated connections
    and refactored the code a bit

    Patch 2:Fixed unit tests.
    Conflicts:
     southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionInstance.java
     southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/OvsdbConnectionManager.java

    Change-Id: I9f8adfba4a4f866d423503b24f400c40bd43131b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 9079eb260e123c00625dc13e63a6f55d9bc42aea
Merge: b203967 0179232
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Tue Sep 29 12:58:54 2015 -0400

    Merge branch 'master' into topic/master/clustering

    Change-Id: I02c771238cd7447dbaa326516467259516868aa6
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit b203967504c1de8814c32e7c7c8015ebb749e154
Author: Sharad Mishra <sharad.d.mishra@intel.com>
Date:   Mon Sep 28 06:19:38 2015 -0700

    OVSDB cluster device ownership

    Only allow device owner to update device.
    Patch 2: Fixed unit test

    Change-Id: Id942a2ba16a83b19807e135a9b67f8a7eb7da003
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 218785ea03b74287de86395d1e57471ce02fe5e4
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Wed Sep 23 09:55:06 2015 -0400

    Use EntityOwnershipService to get ownership on the device.
    If ownership is granted then *this* instance of southbound
    plugin can perform actions to configure the device, rest
    two southbound plugin instanceses in the cluster will just
    hole the connection with them and won't do any operation
    of configuring the device or reading from the device.
    For controller initiated connections, all the southbound
    plugin instance will attempt to connect to the device and
    contest for ownership of the device and selected owner of
    the device will do CRUD operations. For switch initiated
    connection, only instance of southbound plugin that received
    connection from switch will contest for ownership.

    Change-Id: I349699ae0630e12bdbe18b6bd2588a651edd1f81
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit da209a4aad67400a3c938329fb393ec6f7e2439e
Merge: ec7827c 11c0865
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 29 00:44:50 2015 +0530

    Merge branch 'master' into topic/master/clustering

    Change-Id: I44ac4d66f731c0c0f56d746c563c6210eeceb978
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit ec7827c688340fa85c42942ba6559201da07286a
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Mon Sep 21 17:57:02 2015 -0400

    Add hasDeviceOwnership flag to OvsdbConnectionInstance

    Patch set 4: fix ut

    Change-Id: Id7da9071374938c16b086b0d67059aec0a7cc3a0
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 3cc32fd3d007b4c91dfbadee3920b9ae61a9283c
Author: Flavio Fernandes <ffernand@redhat.com>
Date:   Fri Sep 25 17:02:13 2015 -0400

    Set bridge controller(s) based on ovsdb node manager(s)

    Change-Id: I10bcc04aed78f874cbb8a7d9a82e59cf1b80ec82
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
commit 628749e43002c4aa9fc8bfdf7c827cba0532eb6b
Merge: 3d7ce06 360d519
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Sat Sep 26 01:27:28 2015 +0530

    Merge branch 'master' into topic/master/clustering

    Change-Id: I20e84a6971466357c6819c7dba5d51809f9b2878
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 3d7ce0660d25080dd1a5e3927eda6d071e085d12
Merge: 8a90856 708c8c3
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Fri Sep 25 06:07:23 2015 +0530

    Merge branch 'master' into topic/master/clustering

    Change-Id: I35038c6d7b2150d2efc9692a02d5e94bd97a8dba
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 8a908569f4e8e19e7f03f08f97d0704f9ca46cc9
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 22 01:52:42 2015 +0530

    Enable remote notification for southbound plugin

    (cherry picked from commit 01f0737be6abacaf56721731f6a19dcb13e291f0)

    Change-Id: Ida036244f3861e4d07437b49179bbf2851a212a5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
commit 7747c272e6ad5f52ebcae97fd14e05762bc8f790
Author: Anil Vishnoi <vishnoianil@gmail.com>
Date:   Tue Sep 22 00:05:49 2015 +0530

    Wire entity ownership service to OVSDB southbound plugin

    Change-Id: I8baa3b31f9762c4b5656b399a1a7f705c1aed9c1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: Iec7a1c3055dac748c81b470a3d2286b42e32397e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoMechanical cleanup to SouthboundIT
Stephen Kitt [Fri, 2 Oct 2015 14:36:32 +0000 (16:36 +0200)]
Mechanical cleanup to SouthboundIT

* dataBroker can be turned into a local variable
* "frmo" -> "from"
* drop a couple of variables used only for return
* Javadoc corrections
* remove commented Assume calls which have corresponding Assert calls
* reduce the scope of variables where appropriate
* fix an impossible equals assert (dpTypeStr -> dpType compared to a
  DatapathTypeBase class)
* Java 7 <> operator
* remove unnecessary casts and boxing
* correct a format string ("%s_%s_d" -> "%s_%s_%d")

Change-Id: I9a7da21a9252c3f256a0230521402ced3fffb774
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoMerge "Use the memorized service reference"
Sam Hague [Fri, 2 Oct 2015 13:10:04 +0000 (13:10 +0000)]
Merge "Use the memorized service reference"

8 years agoMerge "UT for SouthboundUtil.java"
Sam Hague [Fri, 2 Oct 2015 13:08:23 +0000 (13:08 +0000)]
Merge "UT for SouthboundUtil.java"

8 years agoMerge "Bug 4277 - Deleted Network flow entries retained in br-int, if network associa...
Sam Hague [Fri, 2 Oct 2015 13:07:05 +0000 (13:07 +0000)]
Merge "Bug 4277 - Deleted Network flow entries retained in br-int, if network associated and disassociated from virutalrouter interface"

8 years agoFuture-proof OvsdbTypesIdResolver
Stephen Kitt [Fri, 2 Oct 2015 09:37:39 +0000 (11:37 +0200)]
Future-proof OvsdbTypesIdResolver

Instead of implementing TypeIdResolver directly, the recommended
approach is to extend TypeIdResolverBase; this ensures that upgrading
Jackson won't cause sudden build failures because of methods added to
TypeIdResolver (TypeIdResolverBase provides an appropriate default
implementation).

Change-Id: I6be57cc22a54e46e9e07ff835f7ccf9feec14c8f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoBug 4277 - Deleted Network flow entries retained in br-int, if network associated...
ravi_sabapathy [Mon, 28 Sep 2015 07:31:48 +0000 (00:31 -0700)]
Bug 4277 - Deleted Network flow entries retained in br-int, if network associated and disassociated from virutalrouter interface

        Remove the mac cache after deleting the DHCP neutron port l3 flows

Patch set 2: Move all other caches updated in delete into cleanupRouterCache()

Change-Id: I0c29ba4976ddfd484415d851ad5a2df97d61b19a
Signed-off-by: ravi_sabapathy <ravi_sabapathy@dell.com>
8 years agoUT for SouthboundUtil.java
rpujar [Tue, 29 Sep 2015 20:40:56 +0000 (16:40 -0400)]
UT for SouthboundUtil.java

Change-Id: I87e3577ab2f262ec7f50b6c185a41f49b1e607ed
Signed-off-by: rpujar <rpujar@inocybe.com>
8 years agoMerge "Speed up SouthboundIT through multi-threading test cases"
Sam Hague [Thu, 1 Oct 2015 12:20:42 +0000 (12:20 +0000)]
Merge "Speed up SouthboundIT through multi-threading test cases"

8 years agoMerge "Add yang for hwvtep"
Sam Hague [Thu, 1 Oct 2015 12:15:35 +0000 (12:15 +0000)]
Merge "Add yang for hwvtep"

8 years agoUse the memorized service reference
Stephen Kitt [Mon, 28 Sep 2015 16:06:54 +0000 (18:06 +0200)]
Use the memorized service reference

Currently when dispatching "event handler added" events we retrieve
the appropriate service reference from the bundle context, but this
seems to cause problems when multiple services are registered for the
same interfaces. Since we know the service reference we got when
registering the service involved, we can just pass that.

As a result, ConfigInterface::setDependencies() doesn't need a
BundleContext at all, and since we're no longer supposed to pass that
around, we can just remove it altogether.

Some more debugging information should help track down other issues of
this type.

Change-Id: Iac54595aed388165711a7c4a3d86577646c59d4f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoLess restriction on shared networks: it can be allowed on externals
Flavio Fernandes [Tue, 29 Sep 2015 14:57:03 +0000 (10:57 -0400)]
Less restriction on shared networks: it can be allowed on externals

Change-Id: I0a66758731eb35a73623c6f663792b9dffbfec08
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
8 years agoMerge "Added model for QoS and Queue."
Sam Hague [Tue, 29 Sep 2015 10:56:19 +0000 (10:56 +0000)]
Merge "Added model for QoS and Queue."

8 years agoUse common profiles among ovsdb it bundles
Sam Hague [Fri, 25 Sep 2015 20:40:20 +0000 (16:40 -0400)]
Use common profiles among ovsdb it bundles

Change-Id: I2636a15eb821e1be7edbebcdeef9d94cb0d783be
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Remove unused integrationtest"
Sam Hague [Mon, 28 Sep 2015 14:30:05 +0000 (14:30 +0000)]
Merge "Remove unused integrationtest"

8 years agoRemove unused integrationtest
Sam Hague [Fri, 25 Sep 2015 19:41:15 +0000 (15:41 -0400)]
Remove unused integrationtest

Also add missing dependencies in library

Change-Id: I120a20ffb76f8d18bb54b1b72a69e752922974e4
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdded model for QoS and Queue.
Gabriel Robitaille-Montpetit [Mon, 3 Aug 2015 23:11:04 +0000 (19:11 -0400)]
Added model for QoS and Queue.

Change-Id: I0d254ea9648dee2298a62523d6a10b64dcc88297
Signed-off-by: Gabriel Robitaille-Montpetit <grmontpetit@inocybe.com>
8 years agoMerge "Added Security Rule for Custom ICMP"
Sam Hague [Mon, 28 Sep 2015 12:51:01 +0000 (12:51 +0000)]
Merge "Added Security Rule for Custom ICMP"

8 years agoMerge "Remove unused northbound"
Flavio Fernandes [Fri, 25 Sep 2015 19:49:08 +0000 (19:49 +0000)]
Merge "Remove unused northbound"

8 years agoMerge "Controller initiated connections always connect to one manager listening in...
Sam Hague [Fri, 25 Sep 2015 19:48:28 +0000 (19:48 +0000)]
Merge "Controller initiated connections always connect to one manager listening in ptcp: mode. In clustered mode, all the three controller will connect to the device, and in case any of the connection will flip that instance will remove OvsdbNode from operational data store because it will see only one manager in manager list. But because switch is listening in passive mode, there can be multiple connection to same manager. To handle this scenario, this patch adds number_of_connection attribute to OvsdbNodeAugmentation to maintain the number of active connection to specific manager. In case of switch initiated connection this value is going to be 1 for each manager, but in case switch listening in passive mode, this value will represent active connections (extraced from Manager tables status column n_connections attributes)."

8 years agoMerge "Bug 3989 -- Fix the original patch. Original patch can break the functioning...
Flavio Fernandes [Fri, 25 Sep 2015 19:45:20 +0000 (19:45 +0000)]
Merge "Bug 3989 -- Fix the original patch. Original patch can break the functioning if there are more then one data change and the first data change is OvsdbNodeAugmentation for which connection already exist. It will return out of OnDataChanged() when it see that connection already exist, without processing rest of the data"

8 years agoMerge "Move OvsdbClient it under library-it"
Flavio Fernandes [Fri, 25 Sep 2015 19:31:30 +0000 (19:31 +0000)]
Merge "Move OvsdbClient it under library-it"

8 years agoBug 3989 -- Fix the original patch. Original patch can break
Anil Vishnoi [Fri, 25 Sep 2015 17:34:02 +0000 (23:04 +0530)]
Bug 3989 -- Fix the original patch. Original patch can break
the functioning if there are more then one data change and
the first data change is OvsdbNodeAugmentation for which connection
already exist. It will return out of OnDataChanged() when it see
that connection already exist, without processing rest of the
data

Change-Id: Icec9fdcc241fb9f1b823d73cbe2dfdd1f5c3def7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoMove OvsdbClient it under library-it
Sam Hague [Fri, 25 Sep 2015 18:46:59 +0000 (14:46 -0400)]
Move OvsdbClient it under library-it

A following commit will remove the integrationtest dir. With this commit here there
are no longer any tests in integrationtest. They have all been moved into the respective
bundles.

Change-Id: I40e7dccd6e5ee7ea362d75a422610fbdfe5e55cc
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoController initiated connections always connect to one manager
Anil Vishnoi [Fri, 25 Sep 2015 04:19:01 +0000 (09:49 +0530)]
Controller initiated connections always connect to one manager
listening in ptcp: mode. In clustered mode, all the three controller
will connect to the device, and in case any of the connection will flip
that instance will remove OvsdbNode from operational data store because
it will see only one manager in manager list. But because switch is
listening in passive mode, there can be multiple connection to same manager.
To handle this scenario, this patch adds number_of_connection attribute
to OvsdbNodeAugmentation to maintain the number of active connection to
specific manager. In case of switch initiated connection this value is
going to be 1 for each manager, but in case switch listening in passive
mode, this value will represent active connections (extraced from
Manager tables status column n_connections attributes).

Change-Id: I910104a5109b5bed6af7786a7692c617bd4305b7
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoRemove unused northbound
Sam Hague [Fri, 25 Sep 2015 15:27:44 +0000 (11:27 -0400)]
Remove unused northbound

Change-Id: I8ac5ae92315d2558a7563a35bdd67c0d816ccc68
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoFix ovsdb node update in clustered environment
Anil Vishnoi [Wed, 23 Sep 2015 18:08:06 +0000 (23:38 +0530)]
Fix ovsdb node update in clustered environment
In cluster environment same switch can be connected to multiple
controller instance running southbound plugin. In the existing implementation
if device disconnect from any of the controller instances OVSDB-SB remove
OvsdbNode from operational data store. In cluster environment that will
break contract with customer, given that device is still connected to
atleast one of the two controller instances running. This patch modifying the
behavior where controller will see if its the only connected controller,
then it will delete the data from operational data store, else it will skip
any clean up from operational data store, because other instances will anyway
update about the disconnected controller manager entry in the managers list.

Change-Id: Iaa043f6632eb2de660b623604e8f8e0938dbc4d5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit 6051e15c6f929c08f152417b1f19373b10e93647)

8 years agoMerge "Remove unused mdsal-plugin-adapter code"
Anil Vishnoi [Fri, 25 Sep 2015 15:06:17 +0000 (15:06 +0000)]
Merge "Remove unused mdsal-plugin-adapter code"

8 years agoSpeed up SouthboundIT through multi-threading test cases
Ryan Goulding [Wed, 26 Aug 2015 18:25:37 +0000 (14:25 -0400)]
Speed up SouthboundIT through multi-threading test cases

This speeds up SouthboundIT without losing coverage through the use of parallel
test cases.  On my VM,ExecutorSer this reduced test time from ~12 to ~4.5 minutes.

Aggregates the testing work for certain test cases into corresponding
Runnables.  For each set of test input data, a Runnable is spawned and
submitted to a fixed thread pool.  The thread pool size may be altered
through the NUM_THREADS constant.  The default is 4 since raising this
number causes issues with MD-SAL.

These test cases can be multi-threaded because they each utilize a distinct
bridge.  In other words, each thread is manipulating a different bridge in the
operating system.

Change-Id: Icd8ca69171e996fbf4000ef632c9446bb6c89ed6
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
8 years agoRemove unused mdsal-plugin-adapter code
Sam Hague [Fri, 25 Sep 2015 14:08:18 +0000 (10:08 -0400)]
Remove unused mdsal-plugin-adapter code

Change-Id: I161b63c1c5b4cff39388d8342052920e245e3796
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Mdsal utils bundle"
Flavio Fernandes [Fri, 25 Sep 2015 00:36:38 +0000 (00:36 +0000)]
Merge "Mdsal utils bundle"

8 years agoMerge "Initial pass at netvirt model"
Anil Vishnoi [Thu, 24 Sep 2015 16:32:26 +0000 (16:32 +0000)]
Merge "Initial pass at netvirt model"

8 years agoMdsal utils bundle
Sam Hague [Mon, 21 Sep 2015 01:45:11 +0000 (21:45 -0400)]
Mdsal utils bundle

Patch set 2: Renamed to MdsalUtils and matched the strucure of
the other bundles in the utils dir.

This commit adds a Mdsal utils bundle that has all the mdsal methods to read,
write, delete and merge to the datastore. This is so that other bundles can
reuse the same methods.

Change-Id: Ida83ed957f74155224b007b54e3e80bfb1e29a71
Signed-off-by: Sam Hague <shague@redhat.com>