replace hard-coded OpenflowProviderConfig with XML configuration file

Note how the test proves that the default from the YANG is used!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

very minor clean ups

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

inject OpenFlowPlugin via classpath scanning auto wiring

incl. @PingPong

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

exclude odl-karaf-feat-jdbc so that we don't drag friggin' Hibernate in

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Bump classgraph from 4.4.12 to 4.6.8

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.4.12 to 4.6.8.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

handle the impacts of netconf using the mdsal instead of controller APIs

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

comment out & disable DiagStatusCommand wiring

because that was broken in
https://github.com/opendaylight/infrautils/commit/c88543dd8823585bbfd1d3cc72c56b922896df9c

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix broken OpenFlowPluginWiring, due to ongoing WIP work on OFP master

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Bump classgraph from 4.4.3 to 4.4.12

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.4.3 to 4.4.12.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

comment out AAA cert & crypt services that are not needed

because they are currently broken, following AAA changing from the
controller to the mdsal APIs.  That could (easily) be fixed, of course,
but may be we can just get rid of AAA here in simple all together...

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

introduce an AutoWiringModule

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

intro. new bindAllSingletons()

and use it in AlivenessMonitorWiring

This now also wires the HwVtepTunnelsStateHandler, which we forgot! ;)

That (to not forget to manually wire in any @Singleton) is the point.

PS: PacketProcessingListener didn't get wired, just like it should be.
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

copy configuration files to etc/ directory on start up

and (by documented convention) have that etc/ dir on the CP

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

read UpgradeConfig from XML configuration file

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add UpgradeWiring & ServiceUtilsModuleTest

openflowplugin actually uses the UpgradeState service

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

remove long un-used test web.xml

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

intro RESTCONF Version DRAFT_02 vs DRAFT_18

use DRAFT_02 by default (instead of previous DRAFT_18)

un-comment the test which now passes!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add restconf

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

use Truth instead of JUnit assertion in ClassPathScannerTest

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deal with ODL Neon MRI base platform upgrade impacts

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Bump classgraph from 4.2.12 to 4.4.3

Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.2.12 to 4.4.3.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add Neutron (fully working & tested)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Simplify ClassPathScanner tests

By isolating the Guice-specific aspects of ClassPathScanner, and
making the latter more generic, we can greatly simplify the
ClassPathScanner UT and isolate it from Guice dependencies.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

Temporarily add -U to mvn to force fetch just merged infrautils change

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add "showSvcStatus" CLI command (#29)

requires https://git.opendaylight.org/gerrit/#/c/76810/

which requires https://github.com/vorburger/opendaylight-simple/pull/19

TODO This is only a first cheap, and while it will provide "ready"
status, it does not yet register real ServiceStatusProvider
(but we don't have any real ones anyway).

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

"Gotta catch'em all - Pokémon!"

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add more shit to <mirror> in settings.xml (#37)

Like Pokémon, I'm gone "go get'em all" !

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

un-comment ConfigurationServiceFactoryImpl

requires https://git.opendaylight.org/gerrit/#/c/76588/ for
https://jira.opendaylight.org/browse/OPNFLWPLUG-1037

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

adapt to renamed package in infrautils

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

replace our SystemReadyBaseImpl with infrautils' SystemReadyImpl

see https://git.opendaylight.org/gerrit/#/c/76532/

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

more refining :( <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

re-re-refine :( <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

re-refine ;) <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

refine <mirror> in settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

bump Classgraph from 4.2.7 to 4.2.12

https://github.com/classgraph/classgraph/releases
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Switch to ClassGraph

Closes: #38
Signed-off-by: Stephen Kitt <skitt@redhat.com>

introduce TestHttpClient

used in DiagStatusServletTest, also upcoming restconf support

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Add ClassPathScanner tests

Signed-off-by: Stephen Kitt <skitt@redhat.com>

add <mirror> for ODL Nexus to settings.xml (#37)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

catch and log Exception from SystemReadyListener

due to today's I4f16674ba65f499944e4582fb900d90e873d14e2 (INFRAUTILS-51)

This is about to be replaced by
https://github.com/vorburger/opendaylight-simple/pull/19 anyway,
beecause that is not ready, because
https://git.opendaylight.org/gerrit/#/c/76532 is taking forever to go
in, let's do this for the short term.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deploy using releases instead of pages provider after all (#42)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Revert "move TAR to target/deploy"

This reverts commit 4aa336d3e0f1cc99bc79a1e2916693b13e5c8fb5.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add /diagstatus web support

This foundation will also be useful when adding REST web wiring.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix hanging JVM in case of Guice wiring problems

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

tweak Travis YAML to see if this and/or new token help

Couldn't push the build to github.com/vorburger/opendaylight-simple-binaries.git:gh-pages

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add things to TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

enable verbose logging for deploy pages provider

to figure out why it fails with:
Couldn't push the build to github.com/vorburger/opendaylight-simple-binaries.git:gh-pages

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deploy using pages provider

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

move TAR to target/deploy

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deploy using releases provider (#27)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix POC version to 1.0.0-SNAPSHOT instead of inheriting infrautils'

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Add travis builds

Signed-off-by: Sam Hague <shague@redhat.com>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Fix System.exit() handling

Directly invoking System.exit() from Main.close() causes two problems:
* FindBugs doesn’t like it ;-)
* MainTest fails because the JVM exits from under Surefire’s feet

This patch adds an override for FindBugs, and separates closing the
injector from exiting the JVM for test purposes.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

add TODO re. ClassPathScanner using ClassGraph

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

make ClassPathScanner log "declared multiple times" debug instead warn

This avoids seeing this, which is confusing and doesn't add much value:

2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.ServiceRecoveryInterface is declared multiple times, ignoring it
2018-10-03T01:37:19,363 | WARN  | main             | ClassPathScanner                 | interface java.lang.AutoCloseable is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.serviceutils.srm.RecoverableListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.controller.md.sal.binding.api.ClusteredDataTreeChangeListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.flow.service.rev130819.SalFlowListener is declared multiple times, ignoring it
2018-10-03T01:37:19,364 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.mdsal.eos.binding.api.EntityOwnershipListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.netvirt.fibmanager.IVrfEntryHandler is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.infrautils.diagstatus.ServiceStatusProvider is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.alivenessmonitor.rev160411.AlivenessMonitorListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface org.opendaylight.yang.gen.v1.urn.opendaylight.genius.arputil.rev160406.OdlArputilListener is declared multiple times, ignoring it
2018-10-03T01:37:19,365 | WARN  | main             | ClassPathScanner                 | interface java.lang.Runnable is declared multiple times, ignoring it
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add TODO re. DataStoreAppConfigDefaultXMLReader

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Ctrl-D in Console now works

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

exclude controller:blueprint

This avoids:

2018-10-03T01:07:15,706 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata from any
class loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.reflect.ServiceReferenceMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,717 | WARN  | main             | Reflections
| could not get type for name
org.osgi.service.blueprint.container.BlueprintListener from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.osgi.service.blueprint.container.BlueprintListener
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.osgi.service.blueprint.container.BlueprintListener
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

and:

2018-10-03T01:07:15,850 | WARN  | main             | Reflections
| could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata from any class
loader
org.reflections.ReflectionsException: could not get type for name
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:390)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.expandSuperTypes(Reflections.java:381)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:126)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:168)
[org.reflections.reflections-0.9.11.jar:?]
at org.reflections.Reflections.<init>(Reflections.java:141)
[org.reflections.reflections-0.9.11.jar:?]
at org.opendaylight.infrautils.inject.ClassPathScanner.<init>(ClassPathScanner.java:44)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
at org.opendaylight.genius.simple.GeniusMain.main(GeniusMain.java:18)
[ch.vorburger.opendaylight.simple.poc-1.5.0-SNAPSHOT.jar:?]
Caused by: java.lang.ClassNotFoundException:
org.apache.aries.blueprint.ext.ComponentFactoryMetadata
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_181]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
~[?:1.8.0_181]
at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_181]
at org.reflections.ReflectionUtils.forName(ReflectionUtils.java:388)
~[org.reflections.reflections-0.9.11.jar:?]
... 6 more

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

optimize distribution build time via tar instead xz archive

While the poc-1.5.0-SNAPSHOT-simple.tar.xz was only 99M, it took about
1:30 min (!) to build (not total, just to XZ). That's a steep price to
pay, when a simple tar is just 122M (because the JAR are already
compressed) is quasi instant.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add (working, wow!) distribution assembly

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix broken build

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix Checkstyle problem in ClassPathScanner JavaDoc

and @SuppressWarnings for Class

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Update README.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add .apt_generated_tests/ (from Eclipse) to .gitignore

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Implement a classpath scanner

The approach used here is to allow modules to request bindings for
interfaces to implementations found by scanning the class path, as
long as only one such implementation is found. This allows modules to
bind by requesting bindings for the main interface(s) they want to
provide, and re-use the annotation-based information contained in
their implementations and their dependencies.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

update TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Bump log4j-slf4j-impl from 2.11.0 to 2.11.1

Bumps log4j-slf4j-impl from 2.11.0 to 2.11.1.

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add link to https://jira.opendaylight.org/browse/OPNFLWPLUG-1037

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

also upgrade parent POM to Fluorine

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

Encapsulate infrautils wiring

Using the same model as other project representations, encapsulate all
of infrautils’ wiring in a InfraUtilsWiring class.

Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade to Fluorine (#16)

This involves disabling the OpenFlowPlugin wiring for the time being
(it needs BundleContext).

Signed-off-by: Stephen Kitt <skitt@redhat.com>

update README with project goal clarification

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add link to CONTROLLER-1831 to TODO

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

order TODO.md to prioritize next steps

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add console appender and print WARN & ERROR logs to it and file

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

change log file name from karaf.log to opendaylight.log

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add real log4j (V2) logging (to data/karaf.log)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix Error Prone's & FindBugs errors

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

commands now dynamically registered, instead of hard-coded TepShowState

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add ShellTestWiring to find missing @Service and broken @Reference

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

use slf4j-simple even for non-test initial demo, for now

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

working "tep:show-state" CLI command (but still hard-coded)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

adjust to RPC method signature update (TSC-99)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add ItmWiring (still missing ITM CLI commands like tep:show-state)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

prepare Karaf CLI shell command integration (just basis; no actual cmds)

see https://github.com/vorburger/ch.vorburger.karaf.simple

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix very minor typos in Main

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

install MdsalWiring in GeniusWiring instead of passing it to GuiceRule2

this fixes the currently broken GeniusMain

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add CachesWiring to get GeniusSimpleDistributionTest to pass again

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add README link to https://github.com/vorburger/ch.vorburger.karaf.simple

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

add TODO.md

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

remove all of my Web API stuff here which is now upstream (in AAA)

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

make GeniusSimpleDistributionTest pass!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

fix DiagStatusWiringTest, now requires ReadyWiring

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

temporarily deactivate Neutron test and comment out to pass build

remove NeutronE2ETest, because that has now been
moved into Neutron next to the existing ITNeutronE2E!

Signed-off-by: Michael Vorburger <mike@vorburger.ch>

deactivate AAA related test and comment out code to pass build

I've now lost interest in AAA.  We don't need it, for now, for this.

Signed-off-by: Michael Vorburger <mike@vorburger.ch>