Merge "Added Conntrack Support in Nicira Extenstion."

Added Conntrack Support in Nicira Extenstion.

1)Added Support for Conntrack action
2)Addded support for conntrack state and conntrack zone match.

Change-Id: I3472a95b9fe46b102bee846c369e00535a24f0a0
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Merge "BUG-4062: Flows,Groups,Meters not getting deleted during switch flap"

Merge "Added support for TCP and UDP port mask in Nicira extention"

BUG-4762 Sal-port-service registered as rpc service

Change-Id: Id16f060d24052e1dde34323238bf63aeeb89f5a9
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Add missing license headers

Change-Id: I75c9ba56119f99c3d1d5f75e4091a6fd27a900ff
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "BUG-4118: Li:backward compatibility - rpcs - final wiring"

Merge "BUG-4118: Li:backward compatibility - rpcs - stats services"

Merge changes If902096e,I5a639b30

* changes:
  BUG-4118: Li:backward compatibility - rpcs - transformers
  BUG-4118: Li:backward compatibility - rpcs - initial proposal

Merge "Statistics collection fix"

Merge "BUG-2188: To populate the port_number of switches - yang model"

Merge "BUG-4236: resolve TODOs - part 2"

Merge "BUG-4236: resolve TODOs - part 1"

Merge "BUG-4715: SalEchoService return value fix"

BUG-4715: SalEchoService return value fix

Change-Id: I6e288652efcadfd0a21b47372039aed5a55cc207
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

BUG-4763 Green unit tests with exceptions

Change-Id: I92e6ebb2ffcdcabcecfabe5ab9b341e68739a373
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug-4757:Li: TransactionManager does not get closed and future connections are rejected.

Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Statistics collection fix

 - cleaning up flow registry
 - keep stats scheduler alive even if connection is not in state WORKING

Change-Id: If1f03b224f497653769fc2cca815afdc9029df95
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Added support for TCP and UDP port mask in Nicira extention

Change-Id: I4c89c8ee57860e6439c66f74606b62076b0bfae6
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Cbench DropTest performance improvement

* PacketIn in cbench test always contains Drop Action instructions
  so we'r prepared the DropActionInstructions for every PacketIn
  like static value.

Note: This approach are not reflecting a real world when
      we make new Instructions for every PacketIn normally.

Change-Id: I86f84768c65e1564f39d5b4ac18df937a66cfa01
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
(cherry picked from commit 18623d984cbaa67e83bb5929118c5dd1bd656f78)

Merge "Use odlparent-lite as artifacts parent"

BUG-4236: resolve TODOs - part 2

 - MessageHandler removal

Change-Id: Ief7a46898c81f1f0c309dd2a2c609230bedd7929
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4236: resolve TODOs - part 1

 - SystemNotificationsListenerImplTest#testOnDisconnectEvent4
 - OpenFlowPluginProviderImpl#close
 - RpcContextImpl-members
 - NodeStaticReplyTranslatorUtil#nodeGroupFeatureTranslator
 - DeviceManagerImpl#initializeDeviceContext
 - DeviceContextImpl#processPacketInMessage
 - OpenflowProtocolListenerFullImpl#onHelloMessage
 - AbstractService#handleServiceCall
 - ConnectionManagerImpl#onSwitchConnected
 - OpenflowProtocolListenerInitialImpl#*
 - SinglePurposeMultipartReplyTranslator#getGroupActionsSupportBitmap
 - StatisticsGatheringUtils#gatherStatistics
 - StatisticsManagerImpl#calculateTimerDelay
 - MessageIntelligenceAgencyImpl#getCounters
 - MatchingFlowsInTableService#buildRequest

Change-Id: Ic7dd5caf3d2e7e3b61c823731101040887f6249c
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Bug 4646: Parser accepts invalid models

minor fix of invalid yang files

Change-Id: Iaafef327a1376b37595cdcfc58f2183574ec9e2b
Signed-off-by: Filip.Gregor <fgregor@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: I1f27a982c9ac3b28d71a7bdaccad0d032122a4ae
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-4118: Li:backward compatibility - rpcs - final wiring

 - wired backward compatible services depending on configuration
   parameter

Change-Id: I4b439857c62d8e9dd81a3668476f67d7ffcc949b
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4118: Li:backward compatibility - rpcs - stats services

 - added flow statistics services with notification emitting feature
 - added group statistics services with notification emitting feature
 - added meter statistics services with notification emitting feature
 - added port statistics services with notification emitting feature
 - added queue statistics services with notification emitting feature
 - added tests

Change-Id: Iffc6637e6f1a81be11cb9ef9479557837195c678
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4118: Li:backward compatibility - rpcs - transformers

 - added general stats to notificatin transformers
 - added abstract service providing transaction aware result
   and async notification

Change-Id: If902096e1bd1041aa9ae1d5e23cd45fcc5eef5ea
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4118: Li:backward compatibility - rpcs - initial proposal

 - added config subsystem parameter for stats rpc control
 - API changes for delegating of new parameter, service lookup

Change-Id: I5a639b30a83fd9b025da5c7e1faffdc63eb1315b
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "Remove antlr4-runtime-osgi-nohead"

Remove antlr4-runtime-osgi-nohead

This bundle was removed from yangtools so no longer exists. See:
https://git.opendaylight.org/gerrit/28272/

Change-Id: Iaea7f5022ac1e4706cddcface7726bbdf67ac8ed
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Adding the unit tests for StatListenCommitFlow.java for Bug#3957

Change-Id: Iba725bc4bdd0063a72c5800673c5c58c8e31b5e5
Signed-off-by: MonikaVerma <monika.verma1@tcs.com>

Merge "BUG-4565: queue stats error"

BUG-4283 experimenter msg support - service expose part

 - added sal-experimenter-service exposing experimenter message
   sending and listening to experimenter notification

Change-Id: I24e0917f5e33f98dd1c11a32b37db47709483873
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4283 experimenter msg support - exceptions part

 - added conversion related exceptions for experimenter message converters

Change-Id: I593f8896d138619b93de68f07be9b86b2ae899b3
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4283 experimenter msg support - provider part

 - added provider infrastructure for experimenter message converters

Change-Id: I12e393ddbf1a4439763bc6922958005cec8a7bf4
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "BUG-4283 experimenter msg support - registration part"

Bug-4433:OF Version 10 does not get ommitted for clustering

Change-Id: I928be12d3dd1b28f6cf110f6a6f99f14d993b35c
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Handle cancel txn exception for slaves and device disconnect exception

During the device initialization process, if its encountered that the role for this node is slave
we cancel the txn which is built during the process.
Now since ping-pong txn does not have a cancel, we drop the txn and recreate it. This throws an exception
Since this is an expected exception, it would be advisable to catch and log it in debug.

Also when a node gets disconected from device, the EntityOwnershipService does send a notification. Which trigers a role change.
A check is made to check if the device is connected before moving ahead with the role change.

Change-Id: I76572f27274f5c5f08117fcfd1590d1042049735
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Inventory Cleanup fails as txn could not be created

Cleanup of the inventory is done post closure of txn manager.

Hence if the status of the txn manager is shutting-down, get the WriteTx directly
to perform a datastore cleanup

Change-Id: If9dc9449f7e54e54ea4159376217297f6998e289
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

BUG-2188: To populate the port_number of switches - yang model

Change-Id: I222fdae39986794c020ddc3a0ff1cab33b67be90
Signed-off-by: Michal Rehak <mirehak@cisco.com>

RPC Registration changes for clustering

1. Unregisters rpcs for master/equal to slave scenario as well.
2. Made RpcManager as the device-context-closed-handler , instead of the RpcContext
3. If Role Change fails after several attempts on a switch, the device context is closed. This is to avoid rpcs getting registered in wrong nodes.
4. Removed debug exception for device close in RoleManagerImpl
5. Addition of Logs

Change-Id: Ie5af7466b1422698d3c3287195d237fe1407b023
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

Getting latest state from Ownership RPC

Takes care of two scenarios
1. Switch connects to a second controller, after first controller is master.
   In this case it wont get an Ownership Changed notification

2. Controller which is slave restarts and registers a candidate. Still it wont get a notification.

Notification is only sent when there is a change in the ownership in the OwnershipService

Change-Id: Ifdc5023a711bb66eb36f4d03e294456776810c50
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

RoleManager,SalRoleService Impl and Test

1. Created a Role manager and RoleContext which would get invoked as part of the device init phase
2. Introduced dependency to EntityOwnership service , to get the ownership (implemented in controller)
4. RoleManager requests ownership from EntityOwnership and on notification makes a role change call SalRoleService
5. SalRoleService makes a role change to the device
6. Tests

Change-Id: Ie443d519be985b867d5c6f9ce8473fbd6cdf4dca
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>

moving "context not found" log message to INFO level

Change-Id: I1673074575edd013c3032b8a02268c944a39e141
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

BUG-4565: queue stats error

 - queues do not have any other inspect message but statistics query,
   here 1 parent was missing when writing queue stats into DS/operational
   - addapted data assembly in order to create queue node
   - added TODO: we need to clean existing queues before writing fresh ones
 - fixed test

Change-Id: Icfcb692100b2a0aa666c2e578b09cd903e59fd80
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit b706170bb88018010bde3d8bd84ef1bbf4662943)

BUG-4062: Flows,Groups,Meters not getting deleted during switch flap

Change-Id: Ie06d8a61763b64143106f3d924e856934b9d7b26
Signed-off-by: Muthukumaran Kothandaraman <muthukumaran.k@ericsson.com>

Fixed mising ; in presence statements.

Change-Id: Ica105d65f3d49ca6f03c7b326d8338888a3ea937
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

BUG-4283 experimenter msg support - registration part

 - added registration point for experimenter message converters
 - depends on OFJava https://git.opendaylight.org/gerrit/#/c/28813/
 - checkstyle fix

Change-Id: Ibb8294c522335a0f5df783fbf92b617e45f29930
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG-4551: impact of YT BUG 2399 - action model fixing

 - added presence element to empty action containers
 - added sleep in order to follow port openings with some time reserve

Change-Id: Ia96c0f821455600a412df56c3d353b76184f26ef
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Merge "Add missing information from table features"

Merge "Fix a few spelling mistakes in log output"

Merge "Bug-4442 : PacketOut action headers are not implemented or ignored"

Add missing information from table features

Some information from table features were missing on MD-SAL Operational
DataStore:

  1) Instructions on <instructions> and <instructions-miss>

  2) Actions on <apply-actions>, <apply-actions-miss>, <write-actions>
     and <write-actions-miss>

Change-Id: I31d6a84c821ae4671ae2ee079935ffc959c61ef0
Signed-off-by: Renato Aguiar <renato.aguiar@hp.com>

Openflowjava-util rename reflecting change

 - openflowjava change: https://git.opendaylight.org/gerrit/#/c/28333/

Change-Id: I1a5fcae9e16c7d9bdd187ce588a509442816d6c1
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

Merge "sal role service and role injection"

Merge "Deleted unnecessary file."

Bug-4442 : PacketOut action headers are not implemented or ignored

Change-Id: I5a31898035e857ef677fc163dc3670cb977e8b4e
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>

sal role service and role injection

role cannot be assigned to the whole of openflowplugin.
Since we are scaling switches across a cluster, the role would be assigned per device.

Added a new sal-role yang, rpc and service.

This would be the first of subsequent commits.

Made changes to merge to master - header and testchanges

Change-Id: I0a681485c5ccb8bc839b3b18f3efb648b88bd86b
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
(cherry picked from commit f6d2398e08b0a9b2d7bb5c533e9ca17a5041a74f)

Bug:4343-Ipaddress not set in FlowCapableNode

Change-Id: Ic48b2ba2494f1765a50b52309662d2bee228d741
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>
(cherry picked from commit c48b2ba2494f1765a50b52309662d2bee228d741)

Deleted unnecessary file.

Change-Id: I050014dd6cfe9022de8374a80a918d8efa54ee67
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Fix a few spelling mistakes in log output

Change-Id: I7743ad87943602aff1d2ddada9fc3ea26fecb676
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

[Bug:4069]Ordering chained-groups during reconc

Change-Id: I4988d3b8b616a6bab60805cc00c9b04c8f1fea32
Signed-off-by: Shuva Jyoti Kar <shuva.jyoti.kar@ericsson.com>

BUG-2664 - Buckets in groups are not ordered

Change-Id: I4e199e859656a76842937c6734b821a89ec3bd7c
Signed-off-by: dimgi <dimgi@intracom-telecom.com>

BUG-4340: raise test coverage to 80% - StatisticsManager related

 - added mocked response from device

Change-Id: I942883377b94430a2ac073ae2488e63b62dd1bcc
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - DeviceManager related

 - added close()
 - added OF-1.0 codepath - phyPort

Change-Id: Ic9da1c69a78ab7700c3718abd2d49ca8dea005b5
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - multipart callback related

 - covered on success - most code paths:
   - MultipartRequestOnTheFlyCallback
   - MultipartRequestCallback

Change-Id: Ia462410587a7650ff69a932a8454c26736104ca9
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG-4326: Eliminate dependency to org.apache.mina"

BUG-4328: TransactionChainManager state

 - txChainManager actually never goes back from SHUTTING_DOWN state
 - added more unit tests in order to exersize the tear down mechanism

Change-Id: I6ef95d6b8e7d8211c81ce7f6e286756a040c535e
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4326: Eliminate dependency to org.apache.mina

 - replaced ConcurrentHashSet with Collections.newSetFromMap()

Change-Id: I88821f76d1e5a7e0a9e9a15ef3c9d36cb7b7aad3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - statistics related

 - statisticsGathering services related test

Change-Id: I631224e084cdb10541bbd75632984878a47af3d1
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - connection related

 - ofpListenerInitialImpl related test
 - connection context related tests

Change-Id: I8f93f9739dbcaabaa7ee87f065216d3278b3af30
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - services related

 - salFlowService related tests
 - flowCapableTransaction + packetProcessing related tests
 - salTableService related test

Change-Id: I8215494765c78bb2f3197f3420a41ca76ed23cfc
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - transaction related

 - transactionChainManager related tests

Change-Id: If3aa1910b88a11c4b8e0d82eece0aebfe6595e7c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - device related

 - packetInLimiter related tests
 - deviceContextImpl related tests
 - deviceManager related test

Change-Id: Ie306aa8a500598241eb16f285a845da18f4bd5fe
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - int.registry related

 - internal flow/group/meter registry related tests

Change-Id: Id31a0fa1f3dac287cccc3151fa609ec2223e4b09
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

BUG-4340: raise test coverage to 80% - clean disabled tests

 - removed ignored/disabled tests

Change-Id: I971639ec7a1ba195cfa5d6b635d39285c6c1a6db
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "Use odlparent configuration for jacoco"

Merge "Refactoring of 'extractIpv4Mask' method"

Merge "Removed useless method"

Merge "Removed useless variable"

Merge "Refactoring: shortening of match methods"

Merge "Convert features to features-parent"

Ignored .checkstyle files

Change-Id: Ifcfb778139d61f87cf505082672a74327be77001
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>

Extracted constant

Change-Id: If26302b301ed581ae9e5f5df768ca9a37f3f2b35
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>

Merge "Removed unused fields"

Convert features to features-parent

Switches from hand-written features.xml, to a processed template,
lowering the need for magic properties.

Additional changes:
 - migrated application and extensions features
 - fixed legacy
 - removed duplicate specified dependency version
 - cleaned properties
 - removed outdated version for xml-apis dependency
 - included new extensions/feature-li (pom+features)

(based on commit b4a79dbdfdc7dc00d3c1a477ad57d7c4192839fe)

Change-Id: I7089c1ee27eca228d05ec8942812a0466f71c153
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

BUG 4270 - Add missing versions, dependencies

Change-Id: I01a5fe9cec90c7009fd0dd8f7507513ab4a4acd4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "BUG 4270 - adding reference to Li bundle to Li Nicira extension."

Merge "Migration to use MD-SAL Project"

BUG 4270 - adding reference to Li bundle to Li Nicira extension.

Change-Id: I14b1abf3b63c92e20bb65da2587f8e0260ad234b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Migration to use MD-SAL Project

Change-Id: I8be5de8f8ea89d7e03f925d8a0da5a15e0a11adf
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Removed legacy AD-SAL compatibility

AD-SAL is not part of beryllium, so dependencies
used by AD-SAL adapter are not available in
controller, autorelease and offline mode.

Since this code is not supported, lets remove it
to decrease technical debt.

Change-Id: Ifb4b9e7ec04b00566d421d0089e1dd629ee755d8
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Migrate restconf dependencies

Change-Id: I4ca3d812e80172c9398cbd6043fa6b710cae57cd
Signed-off-by: Tomas Cere <tcere@cisco.com>

Removed unused fields

Change-Id: Ia020ef62e922d047c5540f3f6a01d9b70167a21b
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>

Use odlparent configuration for jacoco

Change-Id: I9724253d6a7a51e844b7833f36124722358a338d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "BUG-4123: Li:flow statistics are not passed into DS/operational"

Merge "update nagasena dependencies for IT"

Merge "BUG-4085: Li: support flowRemoved notifications when SM is off"

Merge "BUG-4085: Li: provisioning translators"