Remove ByteBufUtils.macAddressToBytes()

With all callers migrated, remove the now-unused method.

Change-Id: I65412717a28c393d3e31d2cda19d8becb3278dd7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate ByteBufUtils.macAddressToBytes()

This method operates on any string, whereas all its users are faced
with an ietf-yang-types' MacAddress. IetfYangUtil.macAddressBytes()
provides a superior alternative to this open-coded utility.

Change-Id: Id4f7448a0894a4cec5e76ec801cfde47b03e3be7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use Short.BYTES

We have a few places where we a using Short.SIZE / Byte.SIZE. This
is already a constant known as Short.BYTES.

Change-Id: I51bbc7028131948d615ef2f21e9301ba1cff0fc6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix switch serial number type

This is a day-0 bug in the definition: X509Certificate's serial
number can be any unbounded number, not just uint64.

Change the definition to be string-based so we do not get errors
if the serial number is negative or quite large.

Change-Id: I41292cc329c4eac81a7c671821e29b6851030056
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix openflow-protocol-impl deprecation warnings

Convert all use of widened types to proper uint types.

JIRA: OPNFLWPLUG-1099
Change-Id: Iabdcf752965851b29be0162c70f463206d07abaa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do no subclass HashMap

Eclipse is correctly pointing out we are creating a serializable
subclass without assigning a version to it. Rather than doing that,
use a simple initializer through an intermediate map.

Change-Id: I83d5a05c138bf7ee664612daf81f721fe30435f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate test-extension to use uint types

This is a straightforward replacement with Uint64.

JIRA: OPNFLWPLUG-1099
Change-Id: I2cc7607ec96c31566d2fbadb4bbab7cb54ed32e7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate frm-sync to use uint types

This is a simple matter of encapsulating values, make sure we do
that.

JIRA: OPNFLWPLUG-1099
Change-Id: I12f5c63b9a9935a993b52a7ce90f5ae91a55edc4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make methods static

Eclipse is pointing out a number of methods which can be made static,
fix those warnings.

Change-Id: I4691094f1e5ee098cca5d377a92a3417d667de7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate southbound-cli to use uint types

We have some technical debt here, fix it up.

JIRA: OPNFLWPLUG-1099
Change-Id: I7c777dec680234b9c3a9978175e007b2d39c6d59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use deprecated Mockito constructs

Mockito has moved some functionality around, adjust to that.

Change-Id: I965d6ba5fd29e95060e9bfd6286fdad40d3a99df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Finish test code migration to uint

Fix up the few remaining users of widened types, preparing the floor
for migration of production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I6a2ed96d2859244debd63aa41a16db5c8dc7f7f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugim-impl tests to uint types

This migrates the entire openflowplugin-impl test suite to use
Uint types.

We borrow EncodeConstants to get at Uint8-specified
protocol numbers, which is probably not what we want, but then
there seems to be variance of opinion whether to use that or
OFConstants. This is fine for this migration, we will address
the OFConstants/EncodeConstants duplicity when we migrate
production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I088597573037b8a662840aff62b0593a058a10b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflow-protocol-impl tests to Uint types

There are plenty of warnings in the test suite, address all of them
without touching production code.

JIRA: OPNFLWPLUG-1099
Change-Id: I8ec19c008ef51dfdabeded610bef4bda4e11d8f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ByteBufUtils.padBuffer()

This method has been deprecated for at least three years and is not
used anywhere, remove it.

Change-Id: Ied94f803d3a2025542a07ef1e6e9320fd9a7af4a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix migration warnings in openflowjava-util

We have some use of legacy widened types, fix them up.

JIRA: OPNFLWPLUG-1099
Change-Id: I1266a79d5957f4ae1009258593447f0cadfff40c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated ActionSerializerKey constructor

Legacy widened-type constructor is not used anywhere, remove it.

Change-Id: Ib1b4225657c5bba3455e2b7edbf53a659b02ce40
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove deprecated ExperimenterActionSerializerKey constructor

This constructor is using widened Long argument and is not used
anywhere, remove it.

Change-Id: I41ef92b1957657c50d1bb5be7a0ca985851b5bf0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Refactor AbstractOxmMatchEntryDeserializer"

Merge "AbstractOxmMatchEntryDeserializer should be an OFDeserializer"

Bump MRI projects

This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4

Change-Id: I56ec950e030e1cb67bb697df85703c8d76dfa95a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractOxmMatchEntryDeserializer

All subclassses of AbstractOxmMatchEntryDeserializer follow the same
deserializer pattern. Make sure we eliminate useless getters and
streamline the implementation accordingly.

JIRA: OPNFLWPLUG-1102
Change-Id: I2417ce9f58f7f97acfab91a93d4c346ece3b1208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AbstractOxmMatchEntryDeserializer should be an OFDeserializer

All subclasses already also implement OFDeserializer, centralize
that connection.

JIRA: OPNFLWPLUG-1102
Change-Id: I4105e6b71937f43bd649c26aaf4d2cb7f476590e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make VersionAssignableFactory implement OFDeserializer

All subclasses are implementing OFSerializer, hence it makes sense
to encode this in the base class. This ends up sharing the offset
of the implementation.

JIRA: OPNFLWPLUG-1102
Change-Id: I53342f0f0ec5ffe37440ee29f6e06c20be5add5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix warnings around SimpleRpcListener

SimpleRpcListener has generic arguments, fix warnings pointing out
unparameterized use.

Change-Id: Ia0a4bd398eddb81bfac1e6459249be685e95d931
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove an unneeded cast

We have a superfluous cast, remove it.

Change-Id: Id325d5b4c1593241a156e6f4560c10ae0bfc6501
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate AbstractEmptyActionDeserializer subclasses

Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.

Change AbstractEmptyActionDeserializer to a final
EmptyActionDeserializer and use its instances to perform duties
previously held by its subclasses.

JIRA: OPNFLWPLUG-1102
Change-Id: I3e1e03a498a15808cf2538fcca651c6c258e07f5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ActionContstants in ActionDeserializerInitializer

Rather than using a plain constants, use symbolic names so that we
can neatly cross-reference users.

JIRA: OPNFLWPLUG-1102
Change-Id: I106798adbf77f7e9a9e917b72707ae76b49bae94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Eliminate AbstractEmptyActionSerializer subclasses"

Merge "Add AbstractEmptyActionSerializer"

Merge "Make AbstractActionSerializer.serialize() final"

Merge "Refactor AbstractActionSerializer"

Merge "Refactor AbstractInstructionSerializer"

Eliminate AbstractEmptyActionSerializer subclasses

Method dispatch works on particular class implementation and
individual per-type subclasses are not bringing anything to the
table.

Change AbstractEmptyActionSerializer to a final
EmptyActionSerializer and use its instances to perform duties
previously held by its subclasses.

In order to aid debugging, we customize its toString() to list
the code being handled.

JIRA: OPNFLWPLUG-1102
Change-Id: Icf7176a62bde41d036c9251ed6e347a85aaa35ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add AbstractEmptyActionSerializer

Similar to AbstractEmptyActionDeserializer, we can centralize
common body reads in a single class, eliminating duplicate code.

JIRA: OPNFLWPLUG-1102
Change-Id: I91e02ac81d7f631bc7237e4ea770fad40ca5eb0d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make AbstractActionSerializer.serialize() final

We want to reduce the number of megamorphic calls in the serialization
path. Rather than overriding the serialize() method in abstract base
class and call into it, make sure the base class calls out to subclasses
to serialize the body.

This reduces the number of serialize() implementations, peeling common
code into the caller. It also makes it clear there are opportunities
to further reduction.

JIRA: OPNFLWPLUG-1102
Change-Id: I0cb421be9f84fd278039a07107254bfac9ddd9a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractActionSerializer

Current structure is causing multiple megamorphic invocations in
the serialization paths. This first step eliminates
getType()/getLength() methods, storing their values in the object
instead.

JIRA: OPNFLWPLUG-1102
Change-Id: Ie806a6a4a011b9235c9b47005927cfc5704f018b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractInstructionSerializer

AbstractInstructionSerializer can be made more efficient with
inlining types -- which means we will issue a simple read/load
instead of having to go through virtual dispatch.

JIRA: OPNFLWPLUG-1102
Change-Id: I8c325718715a928a1b24fc75a6de11a6b80eada1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ic81fabcf98bf798b92dc08f5d77dc72486f2c549

OPNFLWPLUG-1105 : Fix for get-active bundle DOMRpcImplementationNotAvailableException

description: GetActive Bundles failed  with "No implementation of RPC AbsoluteSchemaPath" exception even after the path registered successfully.
              Issue Observered when multiple Switches connected to controller, and some of them were restarted.
  During restart previous bundle rpc registrations are overwritten.
  Fix done as registrations are stored and retrieved using map.

Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>
Change-Id: I4de90445db2f5b29e4fefb2d5bd296cdcd73af8a
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>

Merge "Refactor AbstractActionDeserializer"

OPNFLWPLUG-1089 : Enable matching of a range of tcp/udp-source/destination-ports per flow

Signed-off-by: Somashekhar Javalagi <somashekhar.manohara.javalagi@ericsson.com>
Change-Id: I047fd49aa60f0a9e951eef9f55b0104931a15679
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>

Refactor AbstractActionDeserializer

Looking at AbstractActionDeserializer, we can increase performance
of parseHeader() by eagerly instantiating choice/header objects.

JIRA: OPNFLWPLUG-1102
Change-Id: Ia71bb2d865eaf83627945b1a7039a0978b76be80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove EncodeConstants.SIZE_OF_{BYTE,SHORT,INT,LONG}_IN_BYTES

These constants are exposed since Java 8 as
{Byte,Short,Integer,Long}.BYTES use them from there instead of
brewing our own.

Change-Id: I3a47659f136165d54f3f97315b0911cc7feaec6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Remove OFConstants.SIZE_OF_LONG_IN_BYTES"

Merge "Change OFConstants.OFPCML_NO_BUFFER to Uint16"

Merge "Fix a modernizer warning"

Merge "Migrate most of openflowplugin to use Uint types"

Merge "Migrate openflowplugin tests to use Uint types"

Merge "Fix a raw type warning"

Merge "Fix javadoc reference"

Merge "openflow devices are getting disconnected from Controller, sending OFPBFC_BAD_ID error reply"

Merge "Fix uint warnings in sample-bundles"

Merge "Fix for openflow devices not connecting to controller"

Merge "Fix deprecation warnings in learning-switch"

Merge "Do not parse string multiple times"

Merge "Remove unneeded boxing"

Merge "Mark static methods"

Fix for openflow devices not connecting to controller

Signed-off-by: dheenadayalan b <dhinua@gmail.com>
Change-Id: I641997a74f5b5081366fcaa1fe9a56b6d1c67f5d
Signed-off-by: Dheenadayalan.b <dhinua@gmail.com>

Merge "GetFlowNodeCache cli"

Merge "Inventory status check"

openflow devices are getting disconnected from Controller,
sending OFPBFC_BAD_ID error reply

Change-Id: I0a13ef1ab35057d9306532f5c0f8c06a1d0db572
Signed-off-by: dheenadayalan b <dhinua@gmail.com>

Merge "Update active committers info"

Inventory status check

Change-Id: I68698582247dbd9d9ad38c24c555fb8512e1dcb8
Signed-off-by: dheenadayalan b <dhinua@gmail.com>

GetFlowNodeCache cli

Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>
Change-Id: I81c5f411a50a91dba08b8e6d46555faf36c6aa7a

Increase flow and group dtcn listener changes

Change-Id: Ibfac8b245f1a1b39a6ee58a7fa6e391386fdb0d2
Signed-off-by: Shweta Chaturvedi <shweta.chaturvedi@ericsson.com>

Update active committers info

Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Change-Id: I0bfec2355d23fde4b9ffd824cd97348746a82115

Remove OFConstants.SIZE_OF_LONG_IN_BYTES

This is simple value which matches Long.BYTES, remove it.

Change-Id: I1a32cb7c05e81c9fd3ed0b09634232e8fe0aa758
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change OFConstants.OFPCML_NO_BUFFER to Uint16

We are using this constant only for builders, change it to Uint16
so that we skip any conversion.

JIRA: OPNFLWPLUG-1099
Change-Id: Ie59302d05b8ce3d2cad91f30c84038a05cd1e651
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate most of openflowplugin to use Uint types

Migrate production code to use non-widened values. There are a few
methods left out, as they seem to be performing lossy conversion,
which needs to be investigated separately.

JIRA: OPNFLWPLUG-1099
Change-Id: I7bd10498557396f96a6ec0baf9dccc7b8186b28f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugin tests to use Uint types

Migrate test code to use non-widened values. Production code will
be migrated separately.

JIRA: OPNFLWPLUG-1099
Change-Id: I6723d1f1660a18cd6bc634dac0d91a9cd9199dd9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a raw type warning

Add a simple wildcard to suppress a warning around raw type.

Change-Id: I7469b88fc4371cf2954cf9dd2688dfedb70fcf23
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix javadoc reference

This is simple copy&paste error, fix it up.

Change-Id: If6266671ebca0e94331bd00d4643971d984bd5ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix uint warnings in sample-bundles

There are a few users here, migrate them to fix warnings.

JIRA: OPNFLWPLUG-1099
Change-Id: I7228b0d0f33ad2e2fb0a72d398ffd1499bf8957b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix deprecation warnings in learning-switch

Convert use of both legacy lists as well as widened types,
eliminating deprecation warnings.

JIRA: OPNFLWPLUG-1099
Change-Id: I6a5d994a96f37a7342517e4adc133d4f8579cc30
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not parse string multiple times

This code block is a simple switch, really, if not even something
simpler.

Change-Id: Ibc4614c6e5f48691e2f8fdfaa1ebc312b7500c94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded boxing

Use of Integer creates a box-and-unbox operation when coupled
with parseInt() and switch(), just use a plain int.

Change-Id: I62b9d925edf44a22422d14b00b0f413e83ccaf6b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Mark static methods

A number of methods can be made static, make sure they are marked
as such.

Change-Id: Ie8c90c693fea0d873cec8412e6014b8ab56b7b7a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate test-provider to Uint types

There is a multitude of use of legacy compatibility methods, migrate
them in one go.

JIRA: OPNFLWPLUG-1099
Change-Id: Ibbf23fe87bd1e078921619d944f1b4729b5d593d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup warnings in openflowplugin-extension-onf

There are a few warnings about raw types and static methods. Fix
them up, improving BundleAddMessageConverter implementation.

Change-Id: If55353cacc4653e01428aad64aaf5a7cce947606
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate test-common user of deprecated methods

We are using some deprecated Uint- and List-related methods, migrate
to their replacements.

JIRA: OPNFLWPLUG-1099
Change-Id: If4c960c795b49f191ad1644f21fd61464b706135
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugin-extension-onf to use Uint types

There are a few references to old methods in the tests, migrate
them. We do not migrate production code yet, so we have
cross-testing.

JIRA: OPNFLWPLUG-1099
Change-Id: If2a98ede1f661896be80ef43b815910817c59d16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate test-extension to use Uint types

There are a few users of legacy methods, migrate them.

JIRA: OPNFLWPLUG-1099
Change-Id: I5e5e41549095e5208fada718202b7a12f4dcc6b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Mark ConntrackConvertor methods static

There are two utility methods which can be static, mark them as
such to improve clarity.

Change-Id: I54620d97a22b69d8808e1f60d32641b87aa6195f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugin-extension-nicira to use Uint types

There are a few references to old methods in the tests, migrate
them. We do not migrate production code yet, so we have
cross-testing.

JIRA: OPNFLWPLUG-1099
Change-Id: Ib43111cbb3ab8cb8941c76068fb5c23021f1dd0b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowplugin-extension-eric to use Uint types

There are a few references to old methods in the tests, migrate
them. Since we are in the area, also clean up Mockito/Assert
references.

JIRA: OPNFLWPLUG-1099
Change-Id: I6649244c2366f993e9672f0ce423eade8372d428
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused Joiner/Splitter

MatchUtil is no longer using these fields, remove them.

Change-Id: I699d09b5e89969e5615fa9f981bdf8f3615d4459
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate openflowjava-extension-nicira tests to Uint types

This migrates tests to use Uint types, fixing warnings there while
keeping production code unmodified.

JIRA: OPNFLWPLUG-1099
Change-Id: I3c834253abe207d815528bacd6a5cae7499cfe67
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix raw types in openflowjava-extension-nicira test

We have a few warnings here, fix them up.

Change-Id: Ie0aa8ae6f73a8c282e85cf24acd126052dab05cf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Clean up EricExtensionsRegistratorTest"

Merge "Use Uint types in openflowjava-extension-eric"

Merge "Fix raw type warnings in openflowjava-extension-eric test"

Merge "Remove LLDPDiscoveryUtils.macToString()"

Merge "Migrate topology-lldp-discovery to use Uint types"

Merge "Migrate table-miss-enforcer to use Uint types"

Merge "Cleanup ReconciliationServiceImpl"

Merge "Migrate notification-supplier to use Uint types"

Merge "Fix various warnings"

Merge "Use Assert.assertThrows()"

Merge "Migrate Mockito methods"