neutron.git
7 years agoNeutron Model update 34/51534/10
Ritu Sood [Tue, 7 Feb 2017 02:09:04 +0000 (18:09 -0800)]
Neutron Model update

This patch includes Neutron API/model changes being
introduced.
1) Status field to be moved to operational datastore
Breaking out the status field from this patch
for ease of review and merge process.
Link to status field patch
https://git.opendaylight.org/gerrit/#/c/51981/
2) Project id field is going to depreciate tenant id
https://lists.opendaylight.org/pipermail/neutron-dev/2016-December/001083.html
This fix addresses top level tenant-id used my most models.
Some models internally also use tenant-id in sub-fields. Those
cases will be addressed in Nitrogen.
3) revision number field to be added. This is a monotonic
counter that will be updated whenever an object is updated
on the neutron server.

Change-Id: I8a76fe5ff1147a9e4456c0713913377f266cec24
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoupdating neutron-qos yang file for Qos Rule Types to change the model from Config... 30/52930/2
Chandra Mohan [Tue, 7 Mar 2017 09:18:30 +0000 (14:48 +0530)]
updating neutron-qos yang file for Qos Rule Types to change the model from Config to Operational and incorporating the review comments.

Change-Id: Ib195c222f5009b190e4307c904517ad96ff27e22
Signed-off-by: chandrag <chandramohan.grandhi@tcs.com>
7 years agoMerge "Add missing <name> fields for pom.xml files"
Isaku Yamahata [Mon, 6 Mar 2017 22:15:11 +0000 (22:15 +0000)]
Merge "Add missing <name> fields for pom.xml files"

7 years agoMerge "Bug 7848: Allow neutron port create with security disabled."
Isaku Yamahata [Sat, 4 Mar 2017 00:17:32 +0000 (00:17 +0000)]
Merge "Bug 7848: Allow neutron port create with security disabled."

7 years agoMerge "Add missing <name> fields for pom.xml files"
Isaku Yamahata [Sat, 4 Mar 2017 00:10:59 +0000 (00:10 +0000)]
Merge "Add missing <name> fields for pom.xml files"

7 years agoAdd missing <name> fields for pom.xml files 12/52812/1
Isaku Yamahata [Sat, 4 Mar 2017 00:05:06 +0000 (16:05 -0800)]
Add missing <name> fields for pom.xml files

The patchset of b184367fef0217aa0466f86d6614cf821d74cf60
added name fields to pom.xml. Due to patch merge order,
neutron-hostconfig/vpp/pom.xml isn't updated.
This patch fixes it up by adding <name> fields to it.

Change-Id: I256390812a40fa2727fc2d33592aec047cafe8c5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoHostconfig for VPP 42/50742/12
Tomas Cechvala [Mon, 13 Feb 2017 17:19:30 +0000 (18:19 +0100)]
Hostconfig for VPP

L2 configuration is currently supported for VPP devices.
Vhostuser vif-type is used for VMs (endpoints).
Configurable fields:
 - socket directory
 - socket prefix
 - vhostuser-mode (client, server)

 ODL connects to VPP nodes via NETCONF. When a node is
 recognized as VPP node based on its capabilitites
 host configration is written to datastore.

Change-Id: I78b6ad2eeb3d1b11b09317f4c9be0e6878e71df8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
7 years agoAdd missing <name> fields for pom.xml files 27/52727/1
Anil Belur [Fri, 3 Mar 2017 07:37:04 +0000 (17:37 +1000)]
Add missing <name> fields for pom.xml files

This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:

    ODL :: <groupId> :: <artifactId>

This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522

Change-Id: I08fff282973944e135b981f98fcebcde156c7e60
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
7 years agoMerge "Adding checkstyle checks to hostconfig"
Isaku Yamahata [Fri, 3 Mar 2017 05:53:15 +0000 (05:53 +0000)]
Merge "Adding checkstyle checks to hostconfig"

7 years agoMerge "yang model: add service provider feature model"
Isaku Yamahata [Fri, 3 Mar 2017 03:40:34 +0000 (03:40 +0000)]
Merge "yang model: add service provider feature model"

7 years agoBug 7848: Allow neutron port create with security disabled. 67/52267/8
Isaku Yamahata [Mon, 27 Feb 2017 23:04:24 +0000 (15:04 -0800)]
Bug 7848: Allow neutron port create with security disabled.

Add default parameters in test validation.

Change-Id: Id5fcf5701763d72274a96f1a0af29a7546bc24f8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
7 years agoAbstractNeutronNorthbound: remove unused local variable 46/52446/1
Isaku Yamahata [Wed, 1 Mar 2017 04:47:16 +0000 (20:47 -0800)]
AbstractNeutronNorthbound: remove unused local variable

remove unused local variable, parameterizedType, in
AbstractNeutronNorthbound.

Change-Id: I7b77750abb3455b39ff3eeb636f1b9cc255ca2a6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoyang model: add service provider feature model 81/52081/2
Isaku Yamahata [Mon, 20 Feb 2017 16:24:38 +0000 (11:24 -0500)]
yang model: add service provider feature model

As ODL is starting to add more functionalities like port status update
for networking-odl, the negotiation between networking-odl and ODL
openstack service provider to keep compatibility.
networking-odl is supposed to work with multiple versions of ODL,
multiple instances of openstack service providers. So networking-odl
needs to know what neutron extensions/features is supported by
given ODL version/openstack service provider.
This patch defines a yang model for it so that networking-odl can
retrieve from ODL at start up and configure itself.

Change-Id: I90b6bbc3079559209fb444ab79cc88af6a2dc58a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoAdding checkstyle checks to hostconfig 82/51982/1
Ritu Sood [Thu, 16 Feb 2017 02:26:46 +0000 (18:26 -0800)]
Adding checkstyle checks to hostconfig

Hostconfig directory is missing checkstyle checks.
Updated pom file to add checkstyle and also fixed
checkstyle issues.

Change-Id: Id0ff1226e3b23ebac521959de15da0331af7118a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agomodel/neutron extension: add configuration string 17/51817/1
Isaku Yamahata [Mon, 13 Feb 2017 20:20:23 +0000 (12:20 -0800)]
model/neutron extension: add configuration string

Add configuration string to neutron-extension-attribute.
So that ODL openstack service provide can negotiate with networking-odl
about more details on each extension.
For example, neutron QoS API needs supported QoS rules.
key" "neutron:qos"
configuration: {"supported_rules_types": ["bandwidth-limit"...] }
Also neutron-extension can be used for general negotiation between
ODL and networking-odl. e.g. port::status update is supported etc.
key: "ODL:status-update"
configuration: ["network", "port", "router", ...]

TODO: coordinate/document key/configuration in central places.

Change-Id: I7ba7dc21ac0fda7fb40c5f44b99c3b3753c79b9d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMove hostconfig functionality to Neutron Northbound 85/49785/5
Ritu Sood [Fri, 23 Dec 2016 03:34:08 +0000 (19:34 -0800)]
Move hostconfig functionality to Neutron Northbound

This patch moves hostconfig functionality from Netvirt
to NN project. The code is organized to support multiple
southbound implementations. This patch includes
support for hostconfig for OVS.

Change-Id: If428cd3e0c1c466342888f46f17a1916176f0fc6
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agogitignore: remove MANIFEST.MF 13/51313/1
Isaku Yamahata [Wed, 1 Feb 2017 17:54:40 +0000 (10:54 -0700)]
gitignore: remove MANIFEST.MF

Now MANIFEST.MF is created under target directory.
There is no need to ignore MANIFEST.MF and MANIFEST that is not under
target/ directory should not be ignored.

Change-Id: If87003eb0fa38e78164df6ee36a9ed4471c35fcf
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "deploy-site.xml: update version"
Isaku Yamahata [Wed, 1 Feb 2017 15:03:06 +0000 (15:03 +0000)]
Merge "deploy-site.xml: update version"

7 years agopom: create MANIFEST.MF under target directory 99/51099/2
Isaku Yamahata [Fri, 27 Jan 2017 00:03:28 +0000 (16:03 -0800)]
pom: create MANIFEST.MF under target directory

Somehow MANIFEST.MF is generated as src/main/resources/META-INF/MANIFEST.MF.
This causes that mvn clean doesn't remove it.
It's not usually expected. make manifestLocation property default to
be created under target directory.

Change-Id: Id5610e1c824805446fbff0e8cafa5c9a484f05d3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agodeploy-site.xml: update version 98/51098/1
Isaku Yamahata [Wed, 25 Jan 2017 23:48:54 +0000 (15:48 -0800)]
deploy-site.xml: update version

Change-Id: I07991a89890e27d39e5304ad98277f27bbdf8ed3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoAdd support for Openstack Neutron Trunkport APIs 15/50615/7
Vishal Thapar [Sat, 14 Jan 2017 13:20:42 +0000 (18:50 +0530)]
Add support for Openstack Neutron Trunkport APIs

This adds the following:
1. Yang model for TrunkPort Openstack Neuton v2 extension
2. Implementation of API (spi, api and transcriber)
3. UTs for testing spi
4. ITs for E2E testing of API

External References:
https://blueprints.launchpad.net/neutron/+spec/vlan-aware-vms
http://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html
https://wiki.openstack.org/wiki/Neutron/TrunkPort

ODL Driver: https://review.openstack.org/#/c/421895/

Change-Id: I1428e44f93a5bc4507ad5b39c1f2f9f92540fab8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoMerge "neutorn-spi: more remove neutron prefix of field"
Isaku Yamahata [Wed, 11 Jan 2017 15:48:38 +0000 (15:48 +0000)]
Merge "neutorn-spi: more remove neutron prefix of field"

7 years agoneutorn-spi: more remove neutron prefix of field 47/50247/1
Isaku Yamahata [Tue, 10 Jan 2017 23:09:25 +0000 (15:09 -0800)]
neutorn-spi: more remove neutron prefix of field

The changeset of a2f1a28cb8b6c226f49716434cd8ccc34c43eaa4
the change id of I81984a294b4601bfb18b24140d03d615dba1424a was
imcomplete somehow.This patch removes remaining neutron prefix in spi.

Change-Id: I935e2028fc436cd01e8eb930eb5811f4dca26575
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoNeutronLogger: minor code clean up 14/50214/1
Isaku Yamahata [Tue, 10 Jan 2017 17:40:00 +0000 (09:40 -0800)]
NeutronLogger: minor code clean up

remove unnecessary methods in NeutronLogger

Change-Id: I72cd2ebc6093cd48d714ed4d11abb6a47405c65e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoapiece unchecked cast warning 57/49457/2
Isaku Yamahata [Wed, 14 Dec 2016 22:35:30 +0000 (14:35 -0800)]
apiece unchecked cast warning

Eliminate unchecked cast warnings.
In some places we have to use @SuppressWarnings("unchecked")
unfortunately.

Change-Id: Ibaaeebabe86ec645bc61d68389c611b0a0bdc399
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoneutorn-spi: remove neutron prefix of field 19/49519/3
Isaku Yamahata [Sat, 17 Dec 2016 10:16:06 +0000 (02:16 -0800)]
neutorn-spi: remove neutron prefix of field

field name of neutron spi doesn't prefix neutron.
The following three classes have the fields with neutorn prefix.
NeutronL2gateway, NeutronL2gatewayDevice, NeutronLoadBalancerListener
remove prefix of the fields of those classes For consistency.

Change-Id: I81984a294b4601bfb18b24140d03d615dba1424a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: remove suppression 17/49517/4
Isaku Yamahata [Sat, 17 Dec 2016 09:19:12 +0000 (01:19 -0800)]
checkstyle: remove suppression

Now there is no need of suppression for checkstyle.
remove checkstyle-suppressions.xml.

Change-Id: I1fe08a85542f52fcd94bf76f369b66bd0d02def6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: AbbreviationAsWordInName 16/49516/4
Isaku Yamahata [Sat, 17 Dec 2016 09:04:13 +0000 (01:04 -0800)]
checkstyle: AbbreviationAsWordInName

fix AbbreviationAsWordInName and enable AbbreviationAsWordInName.

Change-Id: I6d0756598b7d2a000325b4986e2752aacfd30eb3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: TypeName 15/49515/3
Isaku Yamahata [Sat, 17 Dec 2016 06:49:06 +0000 (22:49 -0800)]
checkstyle: TypeName

eliminate TypeName violation and enable it.

Change-Id: I97af3891eafc965176fa34f17176b62d897122a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: JavadocStyleCheck 14/49514/3
Isaku Yamahata [Sat, 17 Dec 2016 05:05:58 +0000 (21:05 -0800)]
checkstyle: JavadocStyleCheck

fix JavadocStyleCheck and enable it.

Change-Id: I1689aebded15605474c3ef388e433a87577d190a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: enable SummaryJavadoc 13/49513/3
Isaku Yamahata [Sat, 17 Dec 2016 04:57:57 +0000 (20:57 -0800)]
checkstyle: enable SummaryJavadoc

fix SummaryJavadoc and enable it.

Change-Id: I68a464c78aacbb54d54b198b267d616d228e7403
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: enable JavadocTagContinuationIndentation 11/49511/3
Isaku Yamahata [Sat, 17 Dec 2016 02:16:43 +0000 (18:16 -0800)]
checkstyle: enable JavadocTagContinuationIndentation

Eliminate the violation of JavadocTagContinuationIndentation and enable
it.

Change-Id: If854fa71db3115200f57faa8c06c0dd1e8995c0c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: enable JavadocParagraph 10/49510/3
Isaku Yamahata [Sat, 17 Dec 2016 02:08:10 +0000 (18:08 -0800)]
checkstyle: enable JavadocParagraph

Eliminate the violation of JavadocParagraph and enable it.

Change-Id: I1f114f516d96bf0d3f5530d92e876b788cd73af6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: eliminate ConstantName violation 09/49509/3
Isaku Yamahata [Sat, 17 Dec 2016 01:56:50 +0000 (17:56 -0800)]
checkstyle: eliminate ConstantName violation

Eliminate ConstantName violation of checkstyle and enable it.

Change-Id: If124294de812c3b6f022edbe0d1540c78eeae2d8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: enable LocalVariableName 08/49508/2
Isaku Yamahata [Sat, 17 Dec 2016 00:48:58 +0000 (16:48 -0800)]
checkstyle: enable LocalVariableName

fix LocalVariableName violation of checkstyle and enable it.

Change-Id: I6945ac54f3851772cc848093c56111c142d0723d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: ParameterName 07/49507/1
Isaku Yamahata [Fri, 16 Dec 2016 23:43:06 +0000 (15:43 -0800)]
checkstyle: ParameterName

Fix PrameterName checkstyle violation and enable it.

Change-Id: I7f06123fcd1fb5a6db1f47672c788aeb521814ec
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: suppression to ignore files under target 03/49503/1
Isaku Yamahata [Fri, 16 Dec 2016 20:31:56 +0000 (12:31 -0800)]
checkstyle: suppression to ignore files under target

the changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a
in odlparent introduced new supression to ignore sources under
target. This patch catches up it.

Change-Id: I7f35dffea41dbfc939238db0014632a2cd44fa18
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agocheckstyle: use our own checkstyle-suppressions.xml 02/49502/1
Isaku Yamahata [Fri, 16 Dec 2016 23:06:18 +0000 (15:06 -0800)]
checkstyle: use our own checkstyle-suppressions.xml

The changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a in odlparent
defines its own checktyle-suppressions.xml. so that neutron northbound
fails to build because unintented suppression rule is used.
Make it sure that intended supressions are used.

Change-Id: Ifb14d25e5b7b374515274ef9644e35fe64dde5a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoBUG-7259: pool-attributes have wrong description 61/48761/1
wangqianyu [Tue, 29 Nov 2016 01:32:06 +0000 (09:32 +0800)]
BUG-7259: pool-attributes have wrong description

n neutron-lbaasv2.yang, the description of healthmonitor-id in
pool-attributes is as follow:
    leaf healthmonitor-id {
 type yang:uuid;
 description "List of healthmonitors
 associated with this pool.";
    }
here, healthmonitor-id is not a list, so the description need to be modified

Change-Id: I69709af3585bf66c8a4e25a239bc3e071e9bc809
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
7 years agoBUG-7185 NeutronLoadBalancerListener has wrong xmlElement name 49/48349/3
wangqianyu [Tue, 15 Nov 2016 08:20:19 +0000 (16:20 +0800)]
BUG-7185 NeutronLoadBalancerListener has wrong xmlElement name

Fixes bug 7185
    lb listener from openstack uses loadbalancers as xml key value,
    so the XmlElement name of load_balancers in
    NeutronLoadBalancerListener need to be changed to loadbalancers

Change-Id: Id05e4fedc9e516aca45f4c2fac4b3763ee9a1ed8
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>
7 years agoNeutornLogger: print data when node is deleted 95/48295/2
Isaku Yamahata [Sat, 12 Nov 2016 23:07:14 +0000 (15:07 -0800)]
NeutornLogger: print data when node is deleted

Log data of deleted node.

Change-Id: I84ae522cb49453f3d5d2b7812aecfe00628fa9dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "Bug 6938 - Handle unknown protocol name as bad request"
Isaku Yamahata [Wed, 19 Oct 2016 23:10:38 +0000 (23:10 +0000)]
Merge "Bug 6938 - Handle unknown protocol name as bad request"

7 years agoBug 6278: Switch to use odlparent's karaf-parent 53/47153/1
Ryan Goulding [Wed, 19 Oct 2016 17:38:43 +0000 (13:38 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I36e42dac7ccc13f0f796bb95a28a6f30f141b05c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
7 years agoBug 6938 - Handle unknown protocol name as bad request 96/47096/1
Ritu Sood [Tue, 18 Oct 2016 01:32:54 +0000 (18:32 -0700)]
Bug 6938 - Handle unknown protocol name as bad request

Fwaas, security group rule handled unknown protocol
name as internal server error. Changed that to respond
with bad request. lbaas ignored the wrong protocol field.
Also chaged that to respond with bad request.

Change-Id: I681d67b8704015b392ee811b0f4b1556a63b5809
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoBug 6865 - Transcriber skips the uppercase protocol field 91/46791/3
Anil Vishnoi [Thu, 6 Oct 2016 02:22:17 +0000 (19:22 -0700)]
Bug 6865 - Transcriber skips the uppercase protocol field

Networking-sfc sends protocol string in lowercase
(e.g tcp and not TCP), but neutron spi try to find
it using the uppercase and don't find it and
eventually ignore this field. To be consistent with
other API's, flow classifier will only accept lowercase
protocol name and return 400 (Bad Request) for any other
protocol string.

Change-Id: I204f58c9cf1cf13446122c8f818ce498866a2caf
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoFix checkstyle issues related to exception handling 01/46101/3
Ritu Sood [Thu, 22 Sep 2016 02:20:01 +0000 (19:20 -0700)]
Fix checkstyle issues related to exception handling

This is based on the Guidelines given here
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch

Change-Id: I70f9841f706c8d5c38b0834dba04b79ad8fbfa71
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoMerge "sonar: Move this trailing comment on the previous empty line."
Isaku Yamahata [Thu, 6 Oct 2016 23:16:53 +0000 (23:16 +0000)]
Merge "sonar: Move this trailing comment on the previous empty line."

7 years agoMerge "sonar: use dedicated exception instead of RuntimeException"
Isaku Yamahata [Thu, 6 Oct 2016 23:16:46 +0000 (23:16 +0000)]
Merge "sonar: use dedicated exception instead of RuntimeException"

7 years agoBug 6796 - Fixes Priority bugs in integration-test 56/46156/4
pramod [Sat, 24 Sep 2016 08:39:23 +0000 (01:39 -0700)]
Bug 6796 - Fixes Priority bugs in integration-test

1.NeutronL2gatewayConnectionNorthbound.java:118,
EC_UNRELATED_TYPES, Priority: High

This method calls equals(Object) on two references of different class
types and analysis suggests they will be to objects of different
classes at runtime

2.NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE
This method calls equals(Object) on two references, one of which is a
class and the other an interface,where neither the class nor any of
its non-abstract subclasses implement the interface.

3.NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES - Same as 1st
Bug

Change-Id: I23cda778f807ba02179c7d9d4e682b9561a378d4
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
7 years agosonar: Move this trailing comment on the previous empty line. 32/46632/1
Isaku Yamahata [Thu, 6 Oct 2016 18:00:27 +0000 (11:00 -0700)]
sonar: Move this trailing comment on the previous empty line.

remove trailing comment by moving it on the previous empty line.

Change-Id: I72d7e93dd4d60c4773b437c36368d3297e8154d4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agosonar: use dedicated exception instead of RuntimeException 31/46631/1
Isaku Yamahata [Thu, 6 Oct 2016 17:56:54 +0000 (10:56 -0700)]
sonar: use dedicated exception instead of RuntimeException

use IllegalArgumentException instead of RuntimeException

Change-Id: I32c17078499ff3cfd17f2d3b445a3e1bdac99574
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoremove unused inUse method 37/46437/2
Isaku Yamahata [Tue, 4 Oct 2016 02:30:48 +0000 (19:30 -0700)]
remove unused inUse method

Change-Id: I10053b258e899324c30fff836c9ebd88c2ef216c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agotransscriber: consolidate createInstanceIdentifier(T item) 35/46435/6
Isaku Yamahata [Tue, 4 Oct 2016 00:15:03 +0000 (17:15 -0700)]
transscriber: consolidate createInstanceIdentifier(T item)

Consolidate InstanceIdentifier<T> createInstanceIdentifier(T item)
into AbstractNeutronInterface.

Change-Id: If6aedc24d9cc4a15cefa7c21ce3d00c51610c0f0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agotranscriber: consolidate createInstanceIdentifier() 34/46434/6
Isaku Yamahata [Fri, 30 Sep 2016 07:46:05 +0000 (00:46 -0700)]
transcriber: consolidate createInstanceIdentifier()

This patch consolidate createInstanceIdentifier() into parent class.

Change-Id: I6acf69e2ac328bf71cff3efbd846a72db02df6a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agotranscriber: refactor fromMd/toMd logic 33/46433/5
Isaku Yamahata [Fri, 30 Sep 2016 06:17:28 +0000 (23:17 -0700)]
transcriber: refactor fromMd/toMd logic

Since there are several common fields like id, tenant_id, name,
admin_state_up status, factor out those common logic.

Change-Id: If5b11321769890d075eb6a331f1f013de4b5295a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agospi: consolidate common member 32/46432/4
Isaku Yamahata [Fri, 30 Sep 2016 06:10:59 +0000 (23:10 -0700)]
spi: consolidate common member

Since some fields are common to neutron resource, name, status, admin_state_up,
introduce common parent interfaces/classes to consolidate them.

Change-Id: Ie8b654010f0cf780eaa958b49d38b1ed72847961
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoAbstractNeutronNorthbound: make cast more accurate 31/46431/1
Isaku Yamahata [Tue, 4 Oct 2016 00:12:25 +0000 (17:12 -0700)]
AbstractNeutronNorthbound: make cast more accurate

Change-Id: I5cd28faedcbe037ae976e038f3f70ecae644f857
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agospi: consolidate extractFields logic 05/46205/1
Isaku Yamahata [Tue, 27 Sep 2016 04:37:26 +0000 (21:37 -0700)]
spi: consolidate extractFields logic

NeutronObject is common class to have id and tenant_id.
So consolidate extractFields logic to extract them into NeutronObject.

Change-Id: I1e79da6fca9824dbd0563fc09c2dd34843dd99ac
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agosonar: hide NeutronCRUDInterfaces construtor 99/46099/1
Isaku Yamahata [Thu, 22 Sep 2016 18:52:10 +0000 (11:52 -0700)]
sonar: hide NeutronCRUDInterfaces construtor

The class is utility class to have only static method.
Hide public construct not to instantiate it.

Change-Id: Ib78e179c7ec540e0604f2be8c8be65400c1e6f82
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "Adds SFC Integration test cases"
Isaku Yamahata [Thu, 22 Sep 2016 00:32:21 +0000 (00:32 +0000)]
Merge "Adds SFC Integration test cases"

7 years agoAdds SFC Integration test cases 44/45844/2
pramod [Tue, 20 Sep 2016 03:00:06 +0000 (20:00 -0700)]
Adds SFC Integration test cases

Change-Id: Ie6844549f939123687226c3cbde0cd6239a85926
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>
7 years agoCheckstyle exception handling fix (Neutron-spi) 06/46006/1
Ritu Sood [Wed, 21 Sep 2016 02:03:38 +0000 (19:03 -0700)]
Checkstyle exception handling fix (Neutron-spi)

Fixing checkstyle violations in the neutron-spi
integration tests

Change-Id: Ic7a1ed9ea6b4c9362fa73df550825da9e34e00e8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoBug 6736: Fix incorrect destination ip prefix value 68/45768/1
Ritu Sood [Sat, 17 Sep 2016 04:43:39 +0000 (21:43 -0700)]
Bug 6736: Fix incorrect destination ip prefix value

Value of destination ip prefix read from mdsal
is not correct

Change-Id: I712097aed98bf1d5db581de8d3a8b254065adbef
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agospi: NeutronCRUDInterfaces remove unused mothos 20/45620/1
Isaku Yamahata [Thu, 15 Sep 2016 09:17:22 +0000 (02:17 -0700)]
spi: NeutronCRUDInterfaces remove unused mothos

remove unused methods in NeutronCRUDInterfaces

Change-Id: I236ad8e294dc40a0fb7055faf56379f00b800d76
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agonorthbound: simplify neutron interface loading 43/45543/1
Isaku Yamahata [Tue, 13 Sep 2016 15:50:29 +0000 (08:50 -0700)]
northbound: simplify neutron interface loading

Now subnets/ports/routers northbound doesn't need dependent
interface. So getNeutronInterface() can be removed.

Change-Id: I7a78ec35a0b7f2efa79840672e257cc7e5724457
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "Bug 6641: Fix ip_address in allowed_address_pairs info"
Isaku Yamahata [Fri, 9 Sep 2016 22:27:21 +0000 (22:27 +0000)]
Merge "Bug 6641: Fix ip_address in allowed_address_pairs info"

7 years agoBug 6641: Fix ip_address in allowed_address_pairs info 16/45216/2
Sridhar Gaddam [Tue, 6 Sep 2016 10:46:02 +0000 (16:16 +0530)]
Bug 6641: Fix ip_address in allowed_address_pairs info

Change-Id: Id612243cbdc6ab8db8d66ce46ca2973a0effc0ee
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
7 years agoMerge "Neutron-Logger: add final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:52 +0000 (15:10 +0000)]
Merge "Neutron-Logger: add final to public class"

7 years agoMerge "transcriber: sprinkle final to public class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:48 +0000 (15:10 +0000)]
Merge "transcriber: sprinkle final to public class"

7 years agoMerge "northbound: code clean up"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:43 +0000 (15:10 +0000)]
Merge "northbound: code clean up"

7 years agoMerge "neutron-spi: sprinkle final to concrete class"
Isaku Yamahata [Wed, 7 Sep 2016 15:10:35 +0000 (15:10 +0000)]
Merge "neutron-spi: sprinkle final to concrete class"

7 years agoMerge "simplify NeutronTranscriberProvider"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:52 +0000 (15:03 +0000)]
Merge "simplify NeutronTranscriberProvider"

7 years agoMerge "Add NeutronSubnetJAXBTest unit test"
Isaku Yamahata [Wed, 7 Sep 2016 15:03:46 +0000 (15:03 +0000)]
Merge "Add NeutronSubnetJAXBTest unit test"

7 years agoNeutron-Logger: add final to public class 92/45292/1
Isaku Yamahata [Wed, 7 Sep 2016 08:16:18 +0000 (01:16 -0700)]
Neutron-Logger: add final to public class

Change-Id: I44806c78dc34e8fe2575441f28a774889ac0beda
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agotranscriber: sprinkle final to public class 91/45291/1
Isaku Yamahata [Wed, 7 Sep 2016 08:14:58 +0000 (01:14 -0700)]
transcriber: sprinkle final to public class

Change-Id: I48d6961a7e774957da1a4120c2ecb36045fee2d1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agonorthbound: code clean up 90/45290/1
Isaku Yamahata [Wed, 7 Sep 2016 08:04:06 +0000 (01:04 -0700)]
northbound: code clean up

- sprinkle final to public class
- remove unused variable, uriinfo
- misc improvements

Change-Id: Ied5692ef500a768949e7a010266953b097790d7f
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoneutron-spi: sprinkle final to concrete class 89/45289/1
Isaku Yamahata [Wed, 7 Sep 2016 07:43:10 +0000 (00:43 -0700)]
neutron-spi: sprinkle final to concrete class

Change-Id: I73453299f8ce890309fc7df7c1147f39742d2659
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agosimplify NeutronTranscriberProvider 19/45119/1
Isaku Yamahata [Sat, 3 Sep 2016 00:19:31 +0000 (17:19 -0700)]
simplify NeutronTranscriberProvider

remove unused variables to simplify NeutronTranscriberProvider.

Change-Id: I1d8e7ac5e9506d752ed725920282662d0d73e8d2
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoconsolidate NeturonCRUDInterface.fetchNeturonCRUD logic 18/45118/1
Isaku Yamahata [Sat, 3 Sep 2016 00:02:55 +0000 (17:02 -0700)]
consolidate NeturonCRUDInterface.fetchNeturonCRUD logic

The logic are mostly same, consolidate them by generics.

Change-Id: I4a38de02b2a11f355581702a711fe9244d835701
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agonorthbound: make newNeutronRequest concrete method 17/45117/2
Isaku Yamahata [Fri, 2 Sep 2016 22:40:48 +0000 (15:40 -0700)]
northbound: make newNeutronRequest concrete method

By this change, about 120 lines are reduced.

Change-Id: Id4838b4e5109d92f01e18e611e869c27b56371e9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoMerge "sort out signature of extraceField method"
Isaku Yamahata [Fri, 2 Sep 2016 15:35:41 +0000 (15:35 +0000)]
Merge "sort out signature of extraceField method"

7 years agoAdd NeutronSubnetJAXBTest unit test 42/45042/1
Isaku Yamahata [Thu, 1 Sep 2016 21:54:23 +0000 (14:54 -0700)]
Add NeutronSubnetJAXBTest unit test

Change-Id: I62ddd9e0e4ae83866e50e170695871e6891105f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agosort out signature of extraceField method 18/45018/1
Isaku Yamahata [Thu, 1 Sep 2016 16:21:33 +0000 (09:21 -0700)]
sort out signature of extraceField method

So far, the signature of extractField was not defined cleanly.
Define it clean and simplify convoluted code due to it.

Change-Id: I48387b8df50bd019a735e6272a3850adfd10b0d5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoremove unused variable/method 09/45009/1
Isaku Yamahata [Thu, 1 Sep 2016 14:08:09 +0000 (07:08 -0700)]
remove unused variable/method

Change-Id: Ide5eaee4ddef280cc2737f2d196691a805ee01f7
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agonorthbound: simplify Neutron*Request 04/44704/2
Isaku Yamahata [Fri, 26 Aug 2016 06:46:20 +0000 (23:46 -0700)]
northbound: simplify Neutron*Request

Consolidate Neutron*Request logic and make them consistent a bit.

Change-Id: I5b4a62ea14813b1656bc30de944f862e4e0ccec5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
7 years agoEnable checkstyle enforcement for the project 10/44110/3
Ritu Sood [Tue, 16 Aug 2016 03:50:16 +0000 (20:50 -0700)]
Enable checkstyle enforcement for the project

This patch enables checkstyle enforcements.
Also some checkstyle issues are not yet addressed
and those are added to the suppress file for now.
As some of those issues are addressed those will
be removed for the suppress file. The checkstyle
issues suppressed show as warnings during
compile.

Change-Id: I1c64aa426de7d29002e66c50367bbe84f23d885c
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle misc issues fix(Integration) 08/44108/4
Ritu Sood [Tue, 16 Aug 2016 03:20:07 +0000 (20:20 -0700)]
Checkstyle misc issues fix(Integration)

Patch fixes EmptyStatement, ModifierOrder, MethodName,
LineLength, RegexpSinglelineJava checkstyle issues for
integration tests files.

Change-Id: Ia81cb6ad86831b66d6e08ecfd37a68c3bf31a624
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoMerge "Checkstyle indentation issues fix(Logger)"
Isaku Yamahata [Tue, 16 Aug 2016 19:18:26 +0000 (19:18 +0000)]
Merge "Checkstyle indentation issues fix(Logger)"

7 years agoCheckstyle indentation issues fix(Logger) 95/44095/1
Ritu Sood [Mon, 15 Aug 2016 23:49:58 +0000 (16:49 -0700)]
Checkstyle indentation issues fix(Logger)

Patch fixes indentation checkstyle
issues for logger file

Change-Id: I8f81976cbea06c3275430f07f5b4e040ef6a4735
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle imisc issues fix(Transcriber) 93/44093/1
Ritu Sood [Mon, 15 Aug 2016 23:27:12 +0000 (16:27 -0700)]
Checkstyle imisc issues fix(Transcriber)

Patch fixes OverloadMethodsDeclarationOrder, MemberName and
LineLength checkstyle issues for transcriber files

Change-Id: Id19b977735448a309c9c49c3674f62c4efb5ac4b
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle formatting issues fix (Integration) 98/43898/3
Ritu Sood [Fri, 12 Aug 2016 04:54:04 +0000 (21:54 -0700)]
Checkstyle formatting issues fix (Integration)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
integration files.

Change-Id: Icd348dd86813c7682428361db90190b84a6958ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle formatting issues fix (Logger) 99/43899/2
Ritu Sood [Fri, 12 Aug 2016 05:15:11 +0000 (22:15 -0700)]
Checkstyle formatting issues fix (Logger)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
logger files.

Change-Id: I7e763dc1b097e70d4b2c5af231709d0861d33654
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle formatting issues fix (Transcriber) 95/43895/2
Ritu Sood [Fri, 12 Aug 2016 04:07:43 +0000 (21:07 -0700)]
Checkstyle formatting issues fix (Transcriber)

Patch fixes WhitespaceAround,  OperatorWrap,
LineLength and other formatting checkstyle issues for
transcriber files.

Change-Id: I71fa7937648fb07dd8a8eb53c7683a47953c87ff
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle misc issues fix(Northbound API) 93/43893/2
Ritu Sood [Fri, 12 Aug 2016 03:48:59 +0000 (20:48 -0700)]
Checkstyle misc issues fix(Northbound API)

Patch fixes VariableDeclarationUsageDistance, RedundantModifier,
OverloadMethodsDeclarationOrder checkstyle issues for
northbound api files.

Change-Id: If6f91851648e5a10094f0c6c03e07983ebca08f0
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle formatting issues fix (Northbound API) 92/43892/2
Ritu Sood [Fri, 12 Aug 2016 01:30:28 +0000 (18:30 -0700)]
Checkstyle formatting issues fix (Northbound API)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
northbound api files.

Change-Id: I11123566ee4d96f3310c74834e9d0977af80f8f8
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle formatting issues fix (SPI) 83/43883/2
Ritu Sood [Fri, 12 Aug 2016 01:03:57 +0000 (18:03 -0700)]
Checkstyle formatting issues fix (SPI)

Patch fixes WhitespaceAround, ArrayTypeStyle, OperatorWrap,
LineLength and other formatting checkstyle issues for
neutron-spi files.

Change-Id: Iafb65de2f544212e655d497d5e39a4bcb7f32b76
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle Import issues fix (Transcriber) 76/43876/2
Ritu Sood [Thu, 11 Aug 2016 22:40:16 +0000 (15:40 -0700)]
Checkstyle Import issues fix (Transcriber)

Patch fixes Import order issues and also removes
the unused imports. Patch is for transcriber.

Change-Id: Ib247eebb771ec66bd60f67cf457cf248f2dbf565
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle Import issues fix (SPI tests,Northbound API) 73/43873/3
Ritu Sood [Thu, 11 Aug 2016 22:32:47 +0000 (15:32 -0700)]
Checkstyle Import issues fix (SPI tests,Northbound API)

Patch fixes Import order issues and also removes
the unused imports. Patch is for spi tests,
northbound api.

Change-Id: I005975da29580140e28a4667b54729710857d362
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoCheckstyle Import issues fix (SPI, Model) 72/43872/2
Ritu Sood [Thu, 11 Aug 2016 22:22:44 +0000 (15:22 -0700)]
Checkstyle Import issues fix (SPI, Model)

Patch fixes Import order issues and also removes
the unused imports. Patch is for Integration tests,
spi and model

Change-Id: I5565cf9f83ba9bc3092ebaa8c40c8d3056821e72
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
7 years agoBump ietf versions to ...10-SNAPSHOT 16/43516/1
Thanh Ha [Tue, 9 Aug 2016 14:03:08 +0000 (10:03 -0400)]
Bump ietf versions to ...10-SNAPSHOT

Bump versions according to:
https://lists.opendaylight.org/pipermail/release/2016-August/007731.html

Change-Id: Iced0c6aa67afea7022dcef70ab4dbb098dbf098a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>