netconf.git
7 years agoAdd blueprint wiring for netconf-ssh 74/45774/13
Alexis de Talhouët [Wed, 12 Oct 2016 02:10:27 +0000 (22:10 -0400)]
Add blueprint wiring for netconf-ssh

- create mdsal-netconf-ssh bundle containing the blueprint xml
file to start-up the md-sal netconf server ssh.

Change-Id: I20d3d22f8c58b8b28a113f3969c9da0e7d84b028
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for aaa-authn-odl-plugin 99/45599/17
Alexis de Talhouët [Wed, 5 Oct 2016 20:00:11 +0000 (16:00 -0400)]
Add blueprint wiring for aaa-authn-odl-plugin

Change-Id: Ice0fcaf58aae9b9402e9b6e515e57b2157a1be69
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMerge "Bug 6931 - Fix unsupported specific type of leaf"
Tomas Cere [Thu, 27 Oct 2016 15:58:34 +0000 (15:58 +0000)]
Merge "Bug 6931 - Fix unsupported specific type of leaf"

7 years agoMerge "Use UTF-8 as the standard output"
Tomas Cere [Thu, 27 Oct 2016 15:56:00 +0000 (15:56 +0000)]
Merge "Use UTF-8 as the standard output"

7 years agoUse UTF-8 as the standard output 65/47665/2
Robert Varga [Thu, 27 Oct 2016 11:37:17 +0000 (13:37 +0200)]
Use UTF-8 as the standard output

Do not rely on environment-specific encoding, but always
use UTF-8 as the target encoding.

Change-Id: I540fed7611ec66ae2aaeec3b86e21af7376208b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoMerge "InstanceIdentifierCodecImpl JUnit test"
Tomas Cere [Thu, 27 Oct 2016 11:54:44 +0000 (11:54 +0000)]
Merge "InstanceIdentifierCodecImpl JUnit test"

7 years agoBug 6931 - Fix unsupported specific type of leaf 45/46845/12
Jakub Toth [Wed, 12 Oct 2016 16:59:33 +0000 (18:59 +0200)]
Bug 6931 - Fix unsupported specific type of leaf

  * add value to YangInstanceIdentifier as type of leaf
  * converting of value of leaf to String in
    YangInstanceIdentifierSerializer
  * fix tests according to parsing value of leaf by type

Change-Id: I4796b0b116b46d57b9c302bb828beab692f40ed3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 7032 netconf-console support schemaless mount point"
Tomas Cere [Thu, 27 Oct 2016 10:21:44 +0000 (10:21 +0000)]
Merge "Bug 7032  netconf-console support schemaless mount point"

7 years agoUse SerializationUtils from sal-clustering-commons 48/47648/1
Tom Pantelis [Thu, 27 Oct 2016 01:39:48 +0000 (21:39 -0400)]
Use SerializationUtils from sal-clustering-commons

THe SerializationUtils class has been moved from sal-distributed-datastore to
sal-clustering-commons by https://git.opendaylight.org/gerrit/#/c/47637/ so
change usages.

Change-Id: Id279d5c805a400b650cbe2fc8f714c0d1a0794a6
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
7 years agoInstanceIdentifierCodecImpl JUnit test 27/47027/4
matus.kubica [Mon, 17 Oct 2016 15:10:08 +0000 (17:10 +0200)]
InstanceIdentifierCodecImpl JUnit test

Test serialize and deserialize methods of InstanceIdentifierCodecImpl class

Change-Id: Id40a25e2ed5828cc78368f4baa9dfdd205f078d3
Signed-off-by: matus.kubica <Matus.Kubica@pantheon.tech>
7 years agoBug 7032 netconf-console support schemaless mount point 70/47570/1
Geng Xingyuan [Wed, 26 Oct 2016 02:45:36 +0000 (10:45 +0800)]
Bug 7032  netconf-console support schemaless mount point

Change-Id: Id7ed42f87f72a5162ecb6bfdc798062307a3dad0
Signed-off-by: Geng Xingyuan <geng.xingyuan@zte.com.cn>
7 years agoAdd mdsal-singleton-common-api to singleton pom 31/47431/1
Tomas Cere [Mon, 24 Oct 2016 13:58:20 +0000 (15:58 +0200)]
Add mdsal-singleton-common-api to singleton pom

Change-Id: I4159b4ef312f5d924426af82e1bf02f07ee8a5bc
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoMerge "Clean-up netconf-client"
Tomas Cere [Mon, 24 Oct 2016 13:01:42 +0000 (13:01 +0000)]
Merge "Clean-up netconf-client"

7 years agoMerge "Add unit tests for sal-netconf-connector"
Tomas Cere [Mon, 24 Oct 2016 10:18:14 +0000 (10:18 +0000)]
Merge "Add unit tests for sal-netconf-connector"

7 years agoMerge "Add sal-netconf-connector unit tests"
Tomas Cere [Mon, 24 Oct 2016 10:17:44 +0000 (10:17 +0000)]
Merge "Add sal-netconf-connector unit tests"

7 years agoMerge "Add unit tests for sal-netconf-connector transactions"
Tomas Cere [Mon, 24 Oct 2016 10:02:58 +0000 (10:02 +0000)]
Merge "Add unit tests for sal-netconf-connector transactions"

7 years agoMerge "Remove old clustered netconf topology implementation"
Tomas Cere [Mon, 24 Oct 2016 07:35:34 +0000 (07:35 +0000)]
Merge "Remove old clustered netconf topology implementation"

7 years agoAdd logging in tx facade along with the RemoteDeviceId 68/47368/1
Alexis de Talhouët [Fri, 21 Oct 2016 21:22:53 +0000 (17:22 -0400)]
Add logging in tx facade along with the RemoteDeviceId

Change-Id: I0e30376d65ff734ff3dc34809554b961a013a15b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd the RemoteDeviceId at the begining of the log 67/47367/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:37:48 +0000 (16:37 -0400)]
Add the RemoteDeviceId at the begining of the log

So it's easier to grep and find things related to one netconf
connector, and also, to keep things consistent with how it's
already done in sal-netconf-connector

Change-Id: I29ee41c699de8287fd6e00f3a04cacb3d17c5fd1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMove SubmitFailedReply in the appropriate package 64/47364/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:39 +0000 (16:28 -0400)]
Move SubmitFailedReply in the appropriate package

SubmitFailedReply is a transaction related message, hence
should resides under the .transactions package

Change-Id: I7b95f664c88ce2525a742d5543ab562cae709d2b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove unused imports 63/47363/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:28:11 +0000 (16:28 -0400)]
Remove unused imports

Change-Id: I8079b664133e88a3b35f21a3c41e84e890a8ff46
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoUse SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier 62/47362/1
Alexis de Talhouët [Fri, 21 Oct 2016 20:26:02 +0000 (16:26 -0400)]
Use SerializationUtils to (de)serialize NormalizedNode and YangInstanceIdentifier

Controller CDS implementation provide utility method for this,
we can re-use them, as it appears it's keeping a ThreadLocal
holding NormalizedNodeDataOutput instance

Change-Id: Ia106f33d04f937ac8dacf89cb6837a157eee8ae1
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd serialVersionUID to all java.io.Serializable messages 61/47361/1
Alexis de Talhouët [Fri, 21 Oct 2016 19:46:13 +0000 (15:46 -0400)]
Add serialVersionUID to all java.io.Serializable messages

Change-Id: I4928273c0d65e782162d099ddbae36a0c9fe1c63
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoUpdate netconf-topology-singleton.xml file formatting 60/47360/1
Alexis de Talhouët [Fri, 21 Oct 2016 19:21:54 +0000 (15:21 -0400)]
Update netconf-topology-singleton.xml file formatting

- Inline the closing statement
- Rename to bean to be more accurate

Change-Id: I2e2052b7b86b12139b2573c0e3828730cc8d606d
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove old clustered netconf topology implementation 29/47329/5
Jakub Morvay [Fri, 21 Oct 2016 11:22:39 +0000 (13:22 +0200)]
Remove old clustered netconf topology implementation

Since new netconf clustering implementation resides in
netconf-topology-singleton module, old implementation is not needed
anymore. This patch gets rid of it.

Change-Id: I99ba7baced099bd5431a4014378d4ab3b22d93ba
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
7 years agoBug 6714 - Use singleton service in clustered netconf topology 60/46660/18
Rudolf Brisuda [Fri, 7 Oct 2016 09:44:23 +0000 (11:44 +0200)]
Bug 6714 - Use singleton service in clustered netconf topology

Implemented clustered netconf topology with using clustered
singleton service.

Change-Id: I0e71a9934a70c6bce8eeab0644a5bd05c5548a8c
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agoFix tests after merging Change 47121 to Yangtools 46/47346/1
Ivan Hrasko [Fri, 21 Oct 2016 13:38:38 +0000 (15:38 +0200)]
Fix tests after merging Change 47121 to Yangtools

Change-Id: I4bafce0972da4e83fe4575517b5e95808bb21caf
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoAdd xml config dependency to features pom 10/47210/3
Vratko Polak [Thu, 20 Oct 2016 15:25:00 +0000 (17:25 +0200)]
Add xml config dependency to features pom

Configfile added here [0] also needs to be listed as pom dependency,
otherwise distribution-check would fail.
Also added to netconf-artifacts.

[0] https://git.opendaylight.org/gerrit/#/c/44243/10/features/netconf/src/main/features/features.xml

Change-Id: If016aadb03154d83ddd0afa680e8d1d8acd88217
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
7 years agoMerge "Add more unit tests for sal-netconf-connector"
Tomas Cere [Thu, 20 Oct 2016 13:02:06 +0000 (13:02 +0000)]
Merge "Add more unit tests for sal-netconf-connector"

7 years agoMerge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable"
Tomas Cere [Thu, 20 Oct 2016 13:01:27 +0000 (13:01 +0000)]
Merge "Bug 6023 - Adress for config subsystem netconf endpoint is not configurable"

7 years agoAdd more unit tests for sal-netconf-connector 90/47190/1
Andrej Mak [Thu, 20 Oct 2016 07:19:39 +0000 (09:19 +0200)]
Add more unit tests for sal-netconf-connector

Change-Id: I76df3726b4c99c93c3ab98edcf0e7aca94d99b79
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoBug 6023 - Adress for config subsystem netconf endpoint is not configurable 43/44243/10
Rudolf Brisuda [Wed, 17 Aug 2016 12:03:04 +0000 (14:03 +0200)]
Bug 6023 - Adress for config subsystem netconf endpoint is not configurable

- added NetconfConfigurationActivator for loading ManagedService
- updating configuration from karaf netconf.cfg file
- edited NetconfTCPActivator, NetconfSSHActivator for run with
  cfg values

Change-Id: I5069a9f307a9a9b7c2d79723dc6c1cca0b2cc201
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoAdd unit tests for sal-netconf-connector transactions 15/47115/1
Andrej Mak [Wed, 19 Oct 2016 08:24:36 +0000 (10:24 +0200)]
Add unit tests for sal-netconf-connector transactions

Change-Id: I49cbfacd1c41cb531f6fb003110721ae9cbccf0f
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoClean-up netconf-client 62/45862/6
Alexis de Talhouët [Tue, 20 Sep 2016 02:53:34 +0000 (22:53 -0400)]
Clean-up netconf-client

- Use lambda or method ref

Change-Id: I02c6b7a13d90119de061cca0f552c565f18e4862
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd sal-netconf-connector unit tests 80/46880/2
Andrej Mak [Thu, 13 Oct 2016 11:18:58 +0000 (13:18 +0200)]
Add sal-netconf-connector unit tests

Change-Id: I6fa10f4a84da2d61cdea57d700195c0eca017f3c
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd unit tests for sal-netconf-connector 48/47048/2
Andrej Mak [Mon, 17 Oct 2016 06:58:50 +0000 (08:58 +0200)]
Add unit tests for sal-netconf-connector

Change-Id: I1a6131a38048ef8bd426a8e756ba5ec89e8026cb
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Bug 4868 - Extend netconf-node-topology model to distinguish user overriden...
Tomas Cere [Tue, 18 Oct 2016 10:53:24 +0000 (10:53 +0000)]
Merge "Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities"

7 years agoMerge "Bug 6936 - Fix post request"
Tomas Cere [Tue, 18 Oct 2016 08:53:43 +0000 (08:53 +0000)]
Merge "Bug 6936 - Fix post request"

7 years agoBug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilit... 72/43972/8
Rudolf Brisuda [Mon, 15 Aug 2016 12:46:14 +0000 (14:46 +0200)]
Bug 4868 - Extend netconf-node-topology model to distinguish user overriden capabilities from device reported capabilities

 - changed model and corresponding data bindings and imports, updated tests

Change-Id: I0c9dd78c0bf2c4485f27c0049909a04c6155e718
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agonetconf-notifications-api unit tests added 25/45725/6
Rudolf Brisuda [Fri, 16 Sep 2016 11:05:24 +0000 (13:05 +0200)]
netconf-notifications-api unit tests added

Change-Id: I02d2bbabb6e5fabb8f45a89c9233a0e763636596
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoBug 6936 - Fix post request 64/46864/7
miroslav.kovac [Thu, 13 Oct 2016 06:26:51 +0000 (08:26 +0200)]
Bug 6936 - Fix post request

When post request sends data which already exist, it response with
data already exist.

Change-Id: I2ea60dfe4b8aa4236fbec0fd73b64a6f146146ee
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agonetconf-console unit tests added 36/45836/7
Rudolf Brisuda [Mon, 19 Sep 2016 15:51:23 +0000 (17:51 +0200)]
netconf-console unit tests added

Change-Id: I3975e0740935dbbe6bc65f6e3ea3febf56507f39
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoMerge "Bug 6679 - api explorer creates false examples"
Tomas Cere [Thu, 13 Oct 2016 08:38:28 +0000 (08:38 +0000)]
Merge "Bug 6679 - api explorer creates false examples"

7 years agoMerge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes"
Tomas Cere [Thu, 13 Oct 2016 08:36:31 +0000 (08:36 +0000)]
Merge "Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes"

7 years agoMerge "Bug 6746 - Restconf: Not working GET operation on mount points"
Tomas Cere [Thu, 13 Oct 2016 08:35:55 +0000 (08:35 +0000)]
Merge "Bug 6746 - Restconf: Not working GET operation on mount points"

7 years agoMerge "Implement TesttoolParams.toString() via reflection"
Tomas Cere [Thu, 13 Oct 2016 08:34:24 +0000 (08:34 +0000)]
Merge "Implement TesttoolParams.toString() via reflection"

7 years agoBug 6272 - support RESTCONF PATCH for mounted NETCONF nodes 23/46123/23
Ivan Hrasko [Fri, 23 Sep 2016 11:33:13 +0000 (13:33 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes

- solution for Restconf draft17
- make mount point service available when identifier is parsed
- added unit tests

Change-Id: Ie3c5cdc9cbcb10360ac9d0a082eab52efba75674
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6679 - api explorer creates false examples 51/46751/3
miroslav.kovac [Mon, 10 Oct 2016 16:53:01 +0000 (18:53 +0200)]
Bug 6679 - api explorer creates false examples

Api explorer created false examples when yang has two data nodes with
same name in different containers or lists. It compared name of data
nodes rather than whole path to the data node which result to creting
examples of same types even if they should be different.

Fix examples by comparing the path to data node rather than just name
of the node.

Change-Id: I6f73fb37985fc78ad67ecc466ebfdfe569d7cd8d
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 6746 - Restconf: Not working GET operation on mount points 17/45817/30
Ivan Hrasko [Mon, 19 Sep 2016 14:22:53 +0000 (16:22 +0200)]
Bug 6746 - Restconf: Not working GET operation on mount points

- support for reading data on mount points
- improved merge for config and state data:
when identifiers for data in config and state are the same
then merge must by done at one level down, otherwise state
overrides config or vice versa
- identiers are parsed to identifiers context with reference
to mount points when data are behind mount point
- adapted and added unit tests

Change-Id: Iacc45946cc284ae8936f600f5af522926d39c216
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6848 - update url pattern of restconf from 16 to 17 50/46550/8
Jakub Toth [Wed, 5 Oct 2016 13:33:07 +0000 (15:33 +0200)]
Bug 6848 - update url pattern of restconf from 16 to 17

Change-Id: I41882d048a3aede5f4c47c3e160537f7a31a1fab
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - repackage providers for jersey+create xml 49/46549/12
Jakub Toth [Wed, 5 Oct 2016 12:56:08 +0000 (14:56 +0200)]
Bug 6848 - repackage providers for jersey+create xml
and json reader for restconf draft17

  *fix tests
  *rename tests part from draft11 to draft17

Change-Id: I1315bb693eccc34c78f07ea0acbf45f6ff972455
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoImplement TesttoolParams.toString() via reflection 52/46452/5
Andrej Mak [Tue, 4 Oct 2016 09:08:58 +0000 (11:08 +0200)]
Implement TesttoolParams.toString() via reflection

Change-Id: I2222fcf8b5d95a343f107ed3acd557fbfdf40f42
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoFix compilation failure caused by DocumentedException refactoring 48/46748/1
Andrej Mak [Tue, 11 Oct 2016 06:20:17 +0000 (08:20 +0200)]
Fix compilation failure caused by DocumentedException refactoring

Change-Id: I4742760b4afba103af577efc5ffe5905a8255127
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoAdd unit test for NetconfConnectorModule 78/46478/3
Andrej Mak [Tue, 4 Oct 2016 13:54:18 +0000 (15:54 +0200)]
Add unit test for NetconfConnectorModule

Change-Id: I865ab9edd5e056579c92aa1436cda8da032dc1e7
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Add missing Netconf node fields"
Tomas Cere [Fri, 7 Oct 2016 13:46:32 +0000 (13:46 +0000)]
Merge "Add missing Netconf node fields"

7 years agoMerge changes from topic 'Upgrade ietf-restconf draft16 to draft17'
Tomas Cere [Fri, 7 Oct 2016 13:39:34 +0000 (13:39 +0000)]
Merge changes from topic 'Upgrade ietf-restconf draft16 to draft17'

* changes:
  Bug 6848 - upgrade XML media type
  Bug 6848 - upgrade namespace of notification container
  Bug 6848 - Renaming to draft17

7 years agoMerge "Use BDD style mocking everywhere if used once."
Tomas Cere [Fri, 7 Oct 2016 11:50:31 +0000 (11:50 +0000)]
Merge "Use BDD style mocking everywhere if used once."

7 years agoDo a proper disconnect when deleting a connector. 64/46664/1
Tomas Cere [Fri, 7 Oct 2016 10:21:43 +0000 (12:21 +0200)]
Do a proper disconnect when deleting a connector.

Change-Id: I1abba51e331eb1f019e5f2fe741f3836f840aae1
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoBug 6848 - upgrade XML media type 45/46445/6
Jakub Toth [Tue, 4 Oct 2016 06:54:46 +0000 (08:54 +0200)]
Bug 6848 - upgrade XML media type

Change-Id: I16b959a4f325468836477c60d094a1e7473de9e1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - upgrade namespace of notification container 44/46444/6
Jakub Toth [Tue, 4 Oct 2016 06:48:07 +0000 (08:48 +0200)]
Bug 6848 - upgrade namespace of notification container

Change-Id: I6f50832bc94d809d5ba354ceb17dfdecc0b181bd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6848 - Renaming to draft17 77/46377/7
Jakub Toth [Mon, 3 Oct 2016 13:48:08 +0000 (15:48 +0200)]
Bug 6848 - Renaming to draft17

Change-Id: Ib76f9f0ed4e86a4e9cc15d82fd4ede5040964969
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoAdd missing Netconf node fields 41/46541/1
Andrej Mak [Wed, 5 Oct 2016 11:24:11 +0000 (13:24 +0200)]
Add missing Netconf node fields

Change-Id: I2128f4ddfc19fabb07ddae9f30e7bfceef3b7c56
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoFix close() in provider 70/46470/2
Jakub Toth [Tue, 4 Oct 2016 12:02:06 +0000 (14:02 +0200)]
Fix close() in provider

 *added condition on get() from handler

Change-Id: I45c89c44585dc1e5e3ae685eba8d6033ea2e171f
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoMerge "Bug 6635: Correct WriteRunningTx behavior"
Tomas Cere [Tue, 4 Oct 2016 11:58:28 +0000 (11:58 +0000)]
Merge "Bug 6635: Correct WriteRunningTx behavior"

7 years agoUse BDD style mocking everywhere if used once. 60/46460/1
Tomas Cere [Tue, 4 Oct 2016 11:08:32 +0000 (13:08 +0200)]
Use BDD style mocking everywhere if used once.

Change-Id: Ie8a67f7ef8b07037d37e4813e0afe2908707c1d5
Signed-off-by: Tomas Cere <tcere@cisco.com>
7 years agoRemove duplicated code 17/46217/5
Andrej Mak [Tue, 27 Sep 2016 07:18:19 +0000 (09:18 +0200)]
Remove duplicated code

Spawning network connector via config subsystem now
only creates Netconf node from provided values
and writes it to the topology. Topology handles
the rest of mountpoint creation.

Change-Id: I443ca5c6668bf56d8e79cfe83aaa9d76af3b9d50
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoMerge "Check Testool YANG filenames for revision"
Tomas Cere [Tue, 4 Oct 2016 08:41:05 +0000 (08:41 +0000)]
Merge "Check Testool YANG filenames for revision"

7 years agoMerge "Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived...
Tomas Cere [Tue, 4 Oct 2016 08:40:43 +0000 (08:40 +0000)]
Merge "Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived type from instance-identifier"

7 years agoMerge "PATCH transaction JUnit test"
Tomas Cere [Tue, 4 Oct 2016 08:39:27 +0000 (08:39 +0000)]
Merge "PATCH transaction JUnit test"

7 years agoPATCH transaction JUnit test 98/45298/12
matus.kubica [Wed, 7 Sep 2016 12:22:44 +0000 (14:22 +0200)]
PATCH transaction JUnit test

Test patch operations with JUnit and Mockito
Merge some tests to one testing method
Rename tests
Add negative test
Check if MERGE makes put transaction on nonexistent data

Change-Id: I2d3529cd649a81a34017f3a9f5014e0f62c9773b
Signed-off-by: matus.kubica <Matus.Kubica@pantheon.tech>
7 years agoBug 6099 - ControllerContext#addKeyValue ignores key type when key is derived 86/45486/13
Jakub Toth [Mon, 12 Sep 2016 13:30:06 +0000 (15:30 +0200)]
Bug 6099 - ControllerContext#addKeyValue ignores key type when key is derived
type from instance-identifier

 * added instance identifier support as value
 * JUnit test added

Change-Id: I4f6a070b5814ef2a33b68534d887745a099712c8
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBug 6635: Correct WriteRunningTx behavior 33/45733/7
Andrej Mak [Fri, 16 Sep 2016 12:27:49 +0000 (14:27 +0200)]
Bug 6635: Correct WriteRunningTx behavior

WriteRunningTx sends edit-config rpcs only after submit,
not after every put or merge as it was before.

Change-Id: I88268fa812b13a0718114d74ec1c44ce4d3d26b3
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agoBug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF 24/46224/3
Ivan Hrasko [Tue, 27 Sep 2016 12:32:33 +0000 (14:32 +0200)]
Bug 6256 - OpenDaylight RESTCONF XML selects wrong YANG model for southbound NETCONF

- dataSchemaNode can contains multiple childs with the same name,
thus when looking for child also namespace has to be compared
- added unit tests

Change-Id: I922e96fd2aea686c27ad4683ef7366c6718486c3
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6272 - support RESTCONF PATCH for mounted NETCONF nodes 73/45073/21
Ivan Hrasko [Fri, 2 Sep 2016 14:01:32 +0000 (16:01 +0200)]
Bug 6272 - support RESTCONF PATCH for mounted NETCONF nodes

- distinguish between operation on server or on mount point
- when operates on server then use global schema context and
data broker
- when operates on mount point then use schema context and
broker from mount point
- if broker on mount point is missing then PATCH operation fails
with global error
- contains unit tests

Change-Id: I97135a467209fcb4a5782d1c2677f482b842ff8a
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
7 years agoBug 6797 - Fix deadlock on cached schema-changed notifications 18/46318/1
ykq [Thu, 29 Sep 2016 03:36:54 +0000 (11:36 +0800)]
Bug 6797 - Fix deadlock on cached schema-changed notifications

Add an atomic state in NetconfDeviceCommunicator to improve the state
transition of close operation, to avoid deadlock while multiple threads
are doing the close.

Change-Id: I2f2c41b86b724eba78a74bfb96c0b499dc7f79a3
Signed-off-by: ykq <yin.kangqian@zte.com.cn>
7 years agoMerge "Move sal-remote to sal-rest-connector"
Tomas Cere [Thu, 29 Sep 2016 15:24:05 +0000 (15:24 +0000)]
Merge "Move sal-remote to sal-rest-connector"

7 years agoMerge "netconf-api simple unit test added"
Tomas Cere [Thu, 29 Sep 2016 11:51:09 +0000 (11:51 +0000)]
Merge "netconf-api simple unit test added"

7 years agoMerge "mdsal-notification simple unit test added"
Tomas Cere [Thu, 29 Sep 2016 11:47:16 +0000 (11:47 +0000)]
Merge "mdsal-notification simple unit test added"

7 years agoMerge "sal-netconf-connector unit tests added"
Tomas Cere [Thu, 29 Sep 2016 11:46:48 +0000 (11:46 +0000)]
Merge "sal-netconf-connector unit tests added"

7 years agoMerge "Bug 6681: Fix md-sal netconf edit-config behavior"
Tomas Cere [Thu, 29 Sep 2016 11:17:02 +0000 (11:17 +0000)]
Merge "Bug 6681: Fix md-sal netconf edit-config behavior"

7 years agoMerge "Remove use of controller/checkstyle.xml (use odl-parent's new Checkstyle)"
Tomas Cere [Wed, 28 Sep 2016 14:19:18 +0000 (14:19 +0000)]
Merge "Remove use of controller/checkstyle.xml (use odl-parent's new Checkstyle)"

7 years agoBug 6681: Fix md-sal netconf edit-config behavior 67/45967/5
Andrej Mak [Wed, 21 Sep 2016 10:11:00 +0000 (12:11 +0200)]
Bug 6681: Fix md-sal netconf edit-config behavior

Check for existence of mixin map node. If it doesn't exist,
create it. Only then write map entry.

Before this patch if user tried to create map entry,
but parent mixin map node didn't exist, edit config failed.

Change-Id: I4004a66100eb4e0d0918005c54b06fdebc8ea6dd
Signed-off-by: Andrej Mak <andrej.mak@pantheon.tech>
7 years agosal-netconf-connector unit tests added 99/44399/10
Rudolf Brisuda [Fri, 19 Aug 2016 13:38:24 +0000 (15:38 +0200)]
sal-netconf-connector unit tests added

Change-Id: If01df83d92eb38106a634ea6c246fc76b6999d2d
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoMerge "yanglib unit tests added"
Tomas Cere [Fri, 23 Sep 2016 11:55:53 +0000 (11:55 +0000)]
Merge "yanglib unit tests added"

7 years agoMove sal-remote to sal-rest-connector 75/44575/7
Alexis de Talhouët [Tue, 23 Aug 2016 22:24:07 +0000 (18:24 -0400)]
Move sal-remote to sal-rest-connector

This module is only used by sal-rest-connnector bundle,
moreover, it is intended to create notification stream
and/or register a data change event which is done using
RESTCONF, thus it make sense to move it to the appropriate
project.
I beleive this is a leftover of the migration that happened
when controller was splitted out..

Change-Id: Ie23fa2fa48cffe3bc395b814b86e70befd4a684a
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoMerge "netconf-notifications-impl unit tests added"
Tomas Cere [Fri, 23 Sep 2016 11:48:09 +0000 (11:48 +0000)]
Merge "netconf-notifications-impl unit tests added"

7 years agoconfig-netconf-connector unit test added 17/46117/1
Rudolf Brisuda [Fri, 23 Sep 2016 11:13:54 +0000 (13:13 +0200)]
config-netconf-connector unit test added

Change-Id: I871d24097801f2bbaff9c984710ea8636d80f609
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agonetconf-notifications-impl unit tests added 34/45734/3
Rudolf Brisuda [Fri, 16 Sep 2016 12:54:21 +0000 (14:54 +0200)]
netconf-notifications-impl unit tests added

Change-Id: I2a73ca3962cfa663d4dfa7dd2035a878f090d54f
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoyanglib unit tests added 76/45876/5
Rudolf Brisuda [Tue, 20 Sep 2016 09:06:51 +0000 (11:06 +0200)]
yanglib unit tests added

Change-Id: I27054db37b52c1ef5a0fc8e79777e78b84932aae
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agomdsal-notification simple unit test added 14/46114/2
Rudolf Brisuda [Fri, 23 Sep 2016 09:04:54 +0000 (11:04 +0200)]
mdsal-notification simple unit test added

Change-Id: Iabf4f59f80ab28871c2fa340a24eb0954dc8fa99
Signed-off-by: Rudolf Brisuda <rbrisuda@cisco.com>
7 years agoCheck Testool YANG filenames for revision 95/45995/3
Matus.Kubica [Wed, 21 Sep 2016 16:11:26 +0000 (18:11 +0200)]
Check Testool YANG filenames for revision

Check Yang files, if its name contains revision date
Replace original name without revision with name in format xxx-yyy@2000-01-01

Change-Id: Icb123cc0f173295fe98c7913ce376e805ddbb9b1
Signed-off-by: Matus.Kubica <Matus.Kubica@pantheon.tech>
7 years agoMerge "Address TODOs: use NetconfRpcFutureCallback for RPC callback"
Tomas Cere [Thu, 22 Sep 2016 13:05:17 +0000 (13:05 +0000)]
Merge "Address TODOs: use NetconfRpcFutureCallback for RPC callback"

7 years agoAdd Unit test for bug fix 5998 and 5997 75/45875/5
miroslav.kovac [Tue, 20 Sep 2016 09:00:19 +0000 (11:00 +0200)]
Add Unit test for bug fix 5998 and 5997

Change-Id: I0e3ea4d2da47327473d0f74e1945b9c19103a141
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agoBug 5997 - Fix put and post body examples 38/45838/7
miroslav.kovac [Wed, 14 Sep 2016 09:34:46 +0000 (11:34 +0200)]
Bug 5997 - Fix put and post body examples

Change-Id: I1b13bc2128b9dd3924a69c0cb29ad09b0ec132dc
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
7 years agonetconf-api simple unit test added 87/45887/3
Rudolf Brisuda [Tue, 20 Sep 2016 13:09:46 +0000 (15:09 +0200)]
netconf-api simple unit test added

Change-Id: I2bd0e90a1590b65a88bdb3629c1737066fb8bdb8
Signed-off-by: Rudolf Brisuda <rudolf.brisuda@pantheon.tech>
7 years agoMerge "Bug 5998 - fix operations request example body"
Tomas Cere [Thu, 22 Sep 2016 08:31:42 +0000 (08:31 +0000)]
Merge "Bug 5998 - fix operations request example body"

7 years agoMerge "Add final where needed"
Tomas Cere [Thu, 22 Sep 2016 08:30:50 +0000 (08:30 +0000)]
Merge "Add final where needed"

7 years agoMerge "Clean-up mdsal-netconf-connector"
Tomas Cere [Thu, 22 Sep 2016 08:28:01 +0000 (08:28 +0000)]
Merge "Clean-up mdsal-netconf-connector"

7 years agoMerge "Clean-up config-netconf-connector"
Tomas Cere [Thu, 22 Sep 2016 08:19:25 +0000 (08:19 +0000)]
Merge "Clean-up config-netconf-connector"

7 years agoAddress TODOs: use NetconfRpcFutureCallback for RPC callback 49/45549/4
Alexis de Talhouët [Tue, 13 Sep 2016 19:46:33 +0000 (15:46 -0400)]
Address TODOs: use NetconfRpcFutureCallback for RPC callback

Change-Id: I89645c47a97ef808101c683d2f78a5dd7c5c421b
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>