Support building without zip archives

The build can be configured to skip zip or tar.gz archives (or even
both). Currently if zip archives are disabled, the build fails since
features-test expects a zip archive; this patch allows either a zip or
a tar.gz to be used, depending on what's built.

If both are disabled the build will fail unless it can retrieve a
matching archive from a repository. The nominal configuration is still
to build both.

JIRA: ODLPARENT-174
Change-Id: I858810767bcca452eebf52107ee76be129f85192
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-bundle-plugin from 4.0.0 to 4.1.0

There are no release notes e.g. on
https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.1.0/changelog.txt
or elsewhere that I can find.

and straight from 3.5.0 to 4.1.0 in
karaf/karaf-branding/pom.xml, where we seem
to have forgotten to bump back in
https://git.opendaylight.org/gerrit/#/c/75675/

Change-Id: Icc1b01f43bedea29f037ff8a079fc5ccd96c186a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump spotbugs-maven-plugin to 3.1.8

The plugin doesn’t seem to have release notes;
https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.7...spotbugs-maven-plugin-3.1.8
shows the changes.

Change-Id: I988f6118161b2ffa89d5c8f8184706d26c868974
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-pmd-plugin from 3.10.0 to 3.11.0

Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.10.0 to 3.11.0.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-pmd-plugin-3)
- [Commits](https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.10.0...maven-pmd-plugin-3.11.0)

Change-Id: I749801b38c09fa588099d6573874c4259f0776b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-failsafe-plugin from 2.22.0 to 2.22.1

Bumps [maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 2.22.0 to 2.22.1.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-surefire-plugin-version1)
- [Commits](https://github.com/apache/maven-surefire/compare/surefire-2.22.0...surefire-2.22.1)

Change-Id: Ib03e878f07c868c251ca92da5809dfa4cc584b49
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-surefire-plugin from 2.22.0 to 2.22.1

Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 2.22.0 to 2.22.1.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-surefire-plugin-version1)
- [Commits](https://github.com/apache/maven-surefire/compare/surefire-2.22.0...surefire-2.22.1)

Change-Id: I8d6afcc1ab1c44b26586e048105d3a1704c08c40
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump wagon-http from 3.1.0 to 3.2.0

Change-Id: I0479b92bab5d35d45244e28198ed65b40cd3724f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump org.eclipse.jdt.annotation 2.2.0 to 2.2.100

Change-Id: Ie95f9c3c092085619b1b21adc6e09a098be9ec17
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump dependency-check-maven from 3.3.2 to 3.3.4

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 3.3.2 to 3.3.4.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v3.3.2...v3.3.4)

Change-Id: I9251ed406fc97848a64f30589661be474a7f9f0f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump spotbugs-maven-plugin from 3.1.6 to 3.1.7

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-3.1.6...spotbugs-maven-plugin-3.1.7)

Change-Id: I02eb35a8d0eee42ccbe2eb3c3cf15f199b3b1605
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Upgrade netty to 4.1.31

https://netty.io/news/2018/10/30/4-1-31-Final.html

Change-Id: I747867eb6bb3b64ee7725328064119a8af9665ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump asciidoctor-maven-plugin 1.5.7 to 1.5.7.1

Bumps [asciidoctor-maven-plugin](https://github.com/asciidoctor/asciidoctor-maven-plugin) from 1.5.7 to 1.5.7.1.
- [Release notes](https://github.com/asciidoctor/asciidoctor-maven-plugin/releases)
- [Commits](https://github.com/asciidoctor/asciidoctor-maven-plugin/compare/asciidoctor-maven-plugin-1.5.7...asciidoctor-maven-plugin-1.5.7.1)

Change-Id: Idcc70001a1fc1efcb77f3663c5975289b4e92a1e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add javax.activation:activation to exclusions

Karaf provides version 1.1.1 of this from its boot classpath,
hence we should never emit references to it.

Change-Id: I3585e9aa56afcc7f22c6139ba6404221d3142f88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text 1.5 → 1.6

Release notes:
http://www.apache.org/dist/commons/text/RELEASE-NOTES.txt

Change-Id: I36ead59ee9578223224d69efa0bab84baec73eaa
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add odl-jersey-2 feature

This adds an upgraded version of jersey, so we do not end up
packaging it multiple times by downstreams.

Change-Id: I64323615b9dbd289b2d9ae3296525397b5bd6391
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-servlet-api feature

javax.servlet:javax.servlet-api is being packaged by multiple
downstream features: infrautils, controller, aaa. Provide a common
packaging of this bundle.

Change-Id: I16da5a398bb926adf4cb78c1c675a2c99c904542
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-ws-rs-api feature

javax.ws.rs/javax.ws.rs-api is being used by jackson-2.9, jersey2
as well as aaa APIs. Package it as a separate feature, so it can
be reused.

Change-Id: If8dd354e99d32165b5c7554a79007634bcd78809
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-stax2-api feature

stax2-api.jar is used by both odl-jackson-2.9 and yangtools (without
an implementation). Package it in a common feature so it gets reused.

Change-Id: I45cc31fe102bfa1726613ce24eaccaf817562190
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-gson feature

At least yangtools and infrautils are installing the gson bundle
separately. Introduce a common feature to host it.

Change-Id: Ic69b86c4869cb5b7052283486b9253bbd94bce74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odl-antlr4 feature

We have multiple downstream features packaging antlr4-runtime,
add is a feature so we can reuse a single source of it.

Change-Id: I1cf38630f289c76f4e2fcee2c6c84699fe6d1c6f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odl-jackson artifact declaration

We are providing odl-jackson-2.9 now. Also update features-odlparent
to reference features without their version, so as to check
odlparent-artifacts.

Change-Id: Ic228131c7b5243c31666b0c8a2728d3562bd99a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add JAXB handling for Java 11

JAXB modules have been removed from Java 11, hence applications
using them need to declare a dependency on them. These modules
are provided on Karaf's boot classpath, hence we should be filtering
them from features.

Change-Id: I92a2b349c50caaa61d390ed0860901597a6b32f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make annotations optional

JSR-305 annotations are strictly optional to resolve, as they do not
affection production funcionality. Make sure we mark them as such,
which prevents downstreams failing with newer JDK.

Change-Id: I869e0c84f9762e2abfb10b994890fe98cdb850ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text 1.4 → 1.5

Release notes:
http://www.apache.org/dist/commons/text/RELEASE-NOTES.txt

Change-Id: I2e025705124c658e635ea4403ae2985f0d7f5181
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Skip spotbugs in quick profile

This adds the knob to disable spotbugs on quick builds.

Change-Id: I021907289c853b5d322095149e97ffc312c4cb01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add powermock-api-mockito2

To support downstreams still using powermock, add mockito2-compatible
api declaration.

Change-Id: I1ce1d4d65bdc7dd20b53157518b5be53fabf8265
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup findbugs+JDK9 profile

Adding findbugs configuration in build invokes the plugin even
when the project is not using it. Instead of doing that, simply
define findbugs.skip property.

Change-Id: I6c979a12af77a1f17f6ef525a96befe5d016f4d6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Netty 4.1.29 → 4.1.30

Release notes: https://netty.io/news/2018/09/28/4-1-30-Final.html

Change-Id: Idf372327a62f811262bf0eb6415dd5dbd6be8f8e
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.7

https://github.com/scala/scala/releases/tag/v2.12.7

Change-Id: Ida44a1b4da509efebea36ec1fd218dcc865af9c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump LMAX Disruptor 3.4.1 → 3.4.2

Release notes:
https://github.com/LMAX-Exchange/disruptor/releases/tag/3.4.2

Change-Id: Ia523061ddf31f1c82f7293a4da5566e904d40803
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Asciidoctor

Maven plugin 1.5.7:
https://github.com/asciidoctor/asciidoctor-maven-plugin/releases/tag/asciidoctor-maven-plugin-1.5.7
Asciidoctor 1.5.7:
https://github.com/asciidoctor/asciidoctorj/releases/tag/v1.5.7
Version 1.5.9 of the diagram plugin is required for the above.

Change-Id: If43220ff9b917ae2cc9fa6b9388cfbe8068453de
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "bump Xtend from 2.14.0 to 2.15.0"

This reverts commit 3128f7692c116d9562ffa66457c53aa1d6f61328.

Xtend 2.15.0 continues the recent tradition of breaking builds thanks to EMF & co.

Change-Id: I70d5647e1642875774e60806d9024b0bc409e2b9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump Xtend from 2.14.0 to 2.15.0

- [Release notes](https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2018/09/04/version-2-15-0)
- [7 issues in Bugzilla](https://bugs.eclipse.org/bugs/buglist.cgi?bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&classification=Modeling&classification=Tools&columnlist=product%2Ccomponent%2Cassigned_to%2Cbug_status%2Cresolution%2Cshort_desc%2Cchangeddate%2Ckeywords&f0=OP&f1=OP&f3=CP&f4=CP&known_name=Xtext%202.15&list_id=17920364&product=TMF&product=Xtend&query_based_on=Xtext%202.15&query_format=advanced&status_whiteboard=v2.15&status_whiteboard_type=allwordssubstr)
- [111 fixed GitHub issues in xtext-core](https://github.com/search?utf8=%E2%9C%93&q=is%3Aissue+milestone%3ARelease_2.15+is%3Aclosed+repo%3Aeclipse%2Fxtext+repo%3Aeclipse%2Fxtext-core+repo%3Aeclipse%2Fxtext-lib+repo%3Aeclipse%2Fxtext-extras+repo%3Aeclipse%2Fxtext-eclipse+repo%3Aeclipse%2Fxtext-idea+repo%3Aeclipse%2Fxtext-web+repo%3Aeclipse%2Fxtext-maven+repo%3Aeclipse%2Fxtext-xtend&type=Issues&ref=searchresults)
- [313 fixed GitHub issues in xtext](https://github.com/search?utf8=%E2%9C%93&q=is%3Apr+milestone%3ARelease_2.15+is%3Aclosed+repo%3Aeclipse%2Fxtext+repo%3Aeclipse%2Fxtext-core+repo%3Aeclipse%2Fxtext-lib+repo%3Aeclipse%2Fxtext-extras+repo%3Aeclipse%2Fxtext-eclipse+repo%3Aeclipse%2Fxtext-idea+repo%3Aeclipse%2Fxtext-web+repo%3Aeclipse%2Fxtext-maven+repo%3Aeclipse%2Fxtext-xtend&type=Issues&ref=searchresults)

Change-Id: I1bf5cf35bfd07473051b68048cdc9706744c4744
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump versions to 4.0.3-SNAPSHOT

With 4.0.2 released, this starts the next development cycle.

Change-Id: Ibab619c1a28583ae167c412b5033c1e32842f702
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release notes for 4.0.2

Change-Id: I682f8e8f49c272963ce039dcb0b28f7d5affcbe7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Upgrade from 2.8 / 2.22.2 to Jersey 2.25.1

and ensure coherent deps, including
org.glassfish:javax.json from 1.0.4 to 1.1.2

Release notes: https://jersey.github.io/release-notes/2.25.html

We’re not upgrading to Jersey 2.26 or later right now; that’s a
breaking upgrade with significant changes to the injection framework.

Change-Id: Iab2920993f159b8993f7e8fb519a5de8a16b230b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add missing mockito-inline dependency check

Change-Id: I88b42513ff4c04c9ccef426d7067ef01ecbcf507
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump netty to 4.1.29

http://netty.io/news/2018/08/24/4-1-29-Final.html

Change-Id: I823b1e779761702a3098c09ba690644dcf6fe0de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump commons-lang3 from 3.8 to 3.8.1

Release notes:
http://www.apache.org/dist/commons/lang/RELEASE-NOTES.txt

This is a bug-fix release addressing https://issues.apache.org/jira/browse/LANG-1419

Change-Id: Id6e01b020e3adccf4e8f3af162ac6a0529599cc7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove jre.properties

We should not be overriding this file and consume upstream. We
can get the exports via extra packages.

JIRA: ODLPARENT-168
Change-Id: I04c5f2862afe38215ce4e9787c6c0c4a15874adc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump maven-plugin-plugin from 3.5 to 3.5.2

Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.5 to 3.5.2.
- [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.5...maven-plugin-tools-3.5.2)

The official [Release notes](https://maven.apache.org/plugin-tools/maven-plugin-plugin/jira-report.html)
page is empty, but this blog bost seems to be the [3.5.1 Release Notes](https://blog.soebes.de/blog/2018/01/22/apache-maven-plugin-tools-version-3-dot-5-1-released/)
and this [the 3.5.2 Release Notes](https://blog.soebes.de/blog/2018/05/26/apache-mave-plugin-tools-version-3-dot-5-2-released/).

Change-Id: I76d05f9c7650b93251f9807394680ee226e329b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump maven-javadoc-plugin from 3.0.0 to 3.0.1

Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.0.0 to 3.0.1.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-javadoc-plugin-version)
- [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.0.0...maven-javadoc-plugin-3.0.1)

Change-Id: I83d55e064a37731f454654cb02a8514e0c642ec4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump maven-resources-plugin from 3.0.1 to 3.1.0

Bumps [maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from 3.0.1 to 3.1.0.
- [Release notes](https://blogs.apache.org/maven/entry/apache-maven-resources-plugin-version)
- [Commits](https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.0.1...maven-resources-plugin-3.1.0)

Thanks https://github.com/dependabot/dependabot-core/issues/671

Change-Id: Id4110d32cd90e541026dc1bfb2277b40a8eddef2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump maven-jar-plugin from 3.0.2 to 3.1.0

Bumps [maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.0.2 to 3.1.0.
- [Release notes](https://blog.soebes.de/blog/2018/04/10/apache-maven-jar-plugin-version-3-dot-1-dot-0-released/)
- [Commits](https://github.com/apache/maven-jar-plugin/compare/maven-jar-plugin-3.0.2...maven-jar-plugin-3.1.0)

Thanks https://github.com/dependabot/dependabot-core/issues/671

Change-Id: Ia0406844764c1630f6b2631c080ce06f957358e2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump jackson-bom from 2.9.6 to 2.9.7

Bumps [jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.9.6 to 2.9.7.
- [Release notes](https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.7)
- [Commits](https://github.com/FasterXML/jackson-bom/compare/jackson-bom-2.9.6...jackson-bom-2.9.7)

Change-Id: I7c70366e4a4ba98b016a39714c20e70504c194ab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Start the 4.0.2 development series

Change-Id: I74795e3feb78cb0ba97f33254387bd95e71d7ee0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop karaf-plugin it

It doesn’t work and wouldn’t do anything interesting anyway even if it
did.

Change-Id: Ifefab87bfb17de61e91b88a5b58b51cd60814b9b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Release notes for 4.0.1

Change-Id: I259e092e8889137e2d6340e2319c251536cfa12c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump maven-failsafe-plugin to 3.22.0

https://blog.soebes.de/blog/2018/03/06/apache-maven-surefire-plugin-version-2-dot-21-released/
https://blog.soebes.de/blog/2018/06/16/apache-maven-surefire-plugin-version-2-dot-22-released/

Change-Id: I334b5c71c62ef40dd2ac613b0041b97a148a30a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-surefire-plugin to 2.22.0

https://blog.soebes.de/blog/2015/10/19/apache-maven-surefire-plugin-version-2-dot-19-released/
https://blog.soebes.de/blog/2016/01/03/apache-maven-surefire-plugin-version-2-dot-19-dot-1-released/
https://blog.soebes.de/blog/2017/04/12/apache-maven-surefire-plugin-version-2-dot-20-released/
https://blog.soebes.de/blog/2018/03/06/apache-maven-surefire-plugin-version-2-dot-21-released/
https://blog.soebes.de/blog/2018/06/16/apache-maven-surefire-plugin-version-2-dot-22-released/

Change-Id: I7060d68a7a6cff762fb4d5cba01896ae918fe677
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-invoker-plugin to 3.1.0

https://blog.soebes.de/blog/2017/05/24/apache-maven-invoker-plugin-version-3-dot-0-0-released/
https://blog.soebes.de/blog/2018/05/31/apache-maven-invoker-plugin-version-3-dot-1-0-released/

Change-Id: I7192e3163f65cad655041a0153a01650a4f2a9b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

bump dependency-check-maven from 3.3.1 to 3.3.2

Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/jeremylong/DependencyCheck/releases)
- [Changelog](https://github.com/jeremylong/DependencyCheck/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/jeremylong/DependencyCheck/compare/v3.3.1...v3.3.2)

Change-Id: I349d0637f9b7ee4c5f4ee2128afd555319c56678
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Do not exclude o.o.controller.config.yang.config

This package was used by the JMX generator, which has been removed
in Fluorine, hence this is no longer needed.

Change-Id: I10de8dc1c7a0a98e10503780c2fe0c56a4305357
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-site-plugin to 3.7.1

https://blog.soebes.de/blog/2018/04/29/apache-maven-site-plugin-version-3-dot-7-1-released/

Change-Id: Id282d18d44c7c8b0c0f0a9eb2707e02163b953f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-project-info-reports-plugin to 3.0.0

https://blog.soebes.de/blog/2018/06/27/apache-maven-project-info-reports-plugin-3-dot-0-0-released/

Change-Id: I1042ed7caca9d55dda2d38ae9f74fa1615eaaad2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-dependency-plugin to 3.1.1

https://blog.soebes.de/blog/2018/04/06/apache-maven-dependency-plugin-version-3-dot-1-0-released/
https://blog.soebes.de/blog/2018/05/24/apache-maven-dependency-plugin-version-3-dot-1-1-released/

Change-Id: I5d4fb438157bcfe5bad73ac7a35356f9181a08aa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-help-plugin to 3.1.0

https://blog.soebes.de/blog/2018/03/18/apache-maven-help-plugin-version-3-dot-0-0-released/
https://blog.soebes.de/blog/2018/03/28/apache-maven-help-plugin-version-3-dot-0-1-released/
https://blog.soebes.de/blog/2018/06/09/apache-maven-help-plugin-version-3-dot-1-0-released/

Change-Id: I5d84ef58793452075568aae4529aacd966879f62
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.1.0

https://blog.soebes.de/blog/2018/04/10/apache-maven-jar-plugin-version-3-dot-1-dot-0-released/

Change-Id: I01db9f61b736fd40462e92181697de2bce9b83b1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-resources-plugin to 3.1.0

https://blog.soebes.de/blog/2018/05/01/apache-maven-resources-plugin-version-3-dot-1-0-released/

Change-Id: If579d533e64328c0a697d69f82f555e00b45bf55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-clean-plugin to 3.1.0

https://blog.soebes.de/blog/2018/04/14/apache-maven-clean-plugin-version-3-dot-1-0-released/

Change-Id: I4a1a9e4f09c259b27c8d8dfe4a2c6281d8dd74eb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-compiler-plugin to 3.8.0

https://blog.soebes.de/blog/2018/07/30/apache-maven-compiler-plugin-version-3-dot-8-0-released/

Change-Id: I447b19080d22974e411e9bfafc71849795ffcab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven shade plugin to 3.2.0

https://blog.soebes.de/blog/2018/09/13/apache-maven-shade-plugin-version-3-dot-2-0-released/

Change-Id: I3f29e9955824ae3fdc2375664ed4cdce72ecb467
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump enforcer-maven-plugin to 3.0.0-M2

https://mail-archives.apache.org/mod_mbox/maven-announce/201806.mbox/%3Cop.zko9b2vhkdkhrr%40desktop-2khsk44.dynamic.ziggo.nl%3E

Change-Id: I7b1633cdfe21d1f771c25bc15c230421240a4032
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add mockito-inline

Adding the mockito-inline artifact as a dependency allows mocking final
classes, which is one of the reasons people use PowerMockito. Providing
the version in odlparent allows project to use it without specifying the
version explicitly, avoiding potential headaches when we upgrade the
mockito-core version.

Change-Id: Ic18f0b24e92b7afed5ca45618df69755ddc33594
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

blueprint-maven-plugin with xbean-finder 4.9

JIRA: ODLPARENT-167
Change-Id: Id648042c59bd584c645f61bb85d38b8fe6f329b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump spotbugs from 3.1.6 to 3.1.7

Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 3.1.6 to 3.1.7.
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/release-3.1/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/3.1.6...3.1.7)

Change-Id: I095cfd7ff786828704b4552d077e5878a651a9a3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix jacoco execution profile reference

When we removed default report, the dataFile property went away,
which broke sonar. Fix that by referencing to jacoco.destFile.

Change-Id: Ibc5062d31827e08fe18894abe4cbc536f6d59e0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Start odlparent 4.0.1

Change-Id: Ie5efb567b8181bea93aa558f5e13f8ee914cf115
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Adjust the release notes given SpotBugs exclusions

Change-Id: I1d6898feaa11b094d6cd22a9a9f537fb0df060cf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Replicate FindBugs disabled checks in SpotBugs

This re-synchronizes the two files, so downstreams can switch from
findbugs to spotbugs without a regression. Upsteam issue is still
tracked at https://github.com/spotbugs/spotbugs/issues/743.

Change-Id: Iaf1b240bfed2892726b062b91890a2083705438b
JIRA: ODLPARENT-161
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable EQ_DOESNT_OVERRIDE_EQUALS

As noted in https://github.com/spotbugs/spotbugs/issues/511, this
rule runs contrary to Java requirements on .equals() method. Disable
it in favor of pulliting perfectly-compliant code
with @SuppressFBWarnings.

Change-Id: I7d597887771165d9132a680396bcb670540f0f76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clarify @OsgiService replacement rules

Change-Id: I733b6aa79cb5bcf33c5d002f491c707c5b40a80f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Decouple sonar and jacoco

Our current configuration forces Sonar to consider coverage only
if it occurs within the same module, with downstreams having no easy
way to provide aggregated execution view for sonar.

This patch decouples jacoco and sonar configuration, so that UTs report
their execution profile as usual, but the individual profiles are merged
by the aggregator pom -- and when sonar runs we point it to the
aggregated report.

It also moves the pluginManagement for jacoco-maven-plugin into
odlparent-lite, as aggregators need to invoke it.

Change-Id: Ie590dd98da003c1070c9db06fff90ffed8c065a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

link NEWS to steps on wiki

Change-Id: I49b0ccc23d8747e51fe7ae5c57c750a5ab5d876c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Release notes for 4.0.0

Change-Id: Iaedbdecd1b2340ac23b40a4f31b8b2744e72ef75
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Update dependency checks

Change-Id: I1685c78204e5d9b2ed01978e72b93e240de249dd
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove jacoco reporting post unit test

Since we are not building maven sites, there is no point in
running jacoco reports after units tests.

Change-Id: I3db3f28c1a1eabc487a96a0e139473e6e5dec148
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Correct 3.1.3 version number in release notes

Change-Id: I16cdd8fe389c9518d918c48ec924cac61a262405
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 2e7624408546cbc94d511394ecf56150ab0e8a37)

Release notes for 3.1.3

Change-Id: Ia01ec710339b81a0a0a3427316573272999d249f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 8f81b030bf51e0fa6d326479dd3c1cb93a2111cd)

ODL Parent 3.1.2 release notes

Change-Id: Ic7738e0980f5966079801060cd842b29bd14d019
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 4a0a529a78cd12b2f3484c2ad78641e29d635f3f)

Allow disabling test output redirection

Currently, Surefire test output is redirected unconditionally. This
patch adds a property (maven.test.redirectTestOutputToFile, matching
the upstream documentation) which defaults to true, so that this
behaviour can be overridden (e.g. for Travis builds).

See
http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#redirectTestOutputToFile

Change-Id: Ief1239bcf03a79650e0acc50a2aa1a104cd27ff3
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop pax-cdi-api

Using Pax CDI API in ODL is a hack, we’re much better off using the
Blueprint annotations which match our Blueprint usage exactly.

Change-Id: If9367346fc24fe1f719fa24211779a72dc7affa7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump maven-bundle-plugin from 3.5.0 to 4.0.0

There are no release notes e.g. on
https://svn.apache.org/repos/asf/felix/releases/maven-bundle-plugin-4.0.0/changelog.txt
or elsewhere.

see also thread "maven-bundle-plugin 4.0.0" on odlparent-dev list.

Change-Id: I8f1b5fb92d4b7624d387922229791c95b9d1315c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add Blueprint annotations to dependency management

This allows Blueprint descriptors to be written using annotations,
without relying on interpretation of CDI annotations (which don’t
quite match Blueprint concepts).

Change-Id: I13c7b062dbcfe37ef88ccf40824144c3080598b8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump pax-cdi-api from 1.0.0.RC2 to 1.0.0

This reverts commit 1dc8e4b9fe256da57b6b626539440a4b808189db. My
analysis that pax-cdi-api 1.0.0 requires OSGi 6 was too hasty; in fact
the main issue is that pax-cdi-api doesn’t sit well with Blueprint,
and Blueprint-managed beans should use
blueprint-maven-plugin-annotation instead.

Change-Id: Icffae459fb88dda8caadde2972b43ad953755ce2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump git-commit-id-plugin from 2.2.4 to 2.2.5

Bumps git-commit-id-plugin [git-commit-id-plugin](https://github.com/ktoso/maven-git-commit-id-plugin)
from 2.2.4 to 2.2.5.
- [Release notes](https://github.com/ktoso/maven-git-commit-id-plugin/releases)
- [Commits](https://github.com/ktoso/maven-git-commit-id-plugin/compare/v2.2.4...v2.2.5)

Noteworthy:
* Full support for Java 7, Java 8, Java 9, Java 10 and Java 11
  (potentially also working for any higher version)
* add build number support (git.build.number and
  git.build.number.unique) for Bamboo, Hudson, Jenkins, TeamCity,
  Travis, Gitlab CI
* various dependency updates including support for java 10 (I think
  that should have worked before, but its now also tested with that
  version)
* ...

Change-Id: I3f800ca75e8c869167be4792f0bc3badb1c62bfc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add log4j2 dependencyManagement section

This adds a coordinated dependency on log4j2-2.11.1, which allows
downstreams to bridge slf4j-to-log4j2 as is being done in Karaf.

Change-Id: I55873a591384a70d997d9e9de8c86eddc53f88ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

remove protobuf-java

instead of upgrading the very old version we use
via I7fe606af3a089570e6b6232cfd751344417a7e55, let's
just remove it?  If any ODL projects use protobuf, they can
choose and deal with upgrading their dependency, not odlparent.

Change-Id: I20e99812c885e9b36659f6165627396e6904be7a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump xmlunit from 2.6.1 to 2.6.2

Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/xmlunit/xmlunit/releases)
- [Changelog](https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/xmlunit/xmlunit/compare/v2.6.1...v2.6.2)

Change-Id: I8018cb4d22024cff42ff86f76758e25fc33bad9c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Revert "bump pax-cdi-api from 1.0.0.RC2 to 1.0.0"

This reverts commit 7ceaa7b75ee488881664c10404287eae099ae7fe, because
pax-cdi-api drops @OsgiService and @OsgiServiceProvider,
which we need in a number of ODL projects.

Change-Id: I5ccee67ae8a0637afc23106f80acc24efec44eca
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove blueprint plugin generatedDir

This customization was needed for planned extended behavior
in controller's blueprint extension, which never materialized.

Controller can reintroduce this configuration with the new plugin,
if the need arises again -- remove it to reduce our clutter.

We also remove Import-Service and Export-Service headers from
the manifest, as they are deprecated and we have not used them
anywhere.

Change-Id: I61560793c4631f24d9ba353c7d9242ae5837e821
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump EclipseLink Moxy JAXB impl 2.7.1 → 2.7.3

see https://www.eclipse.org/eclipselink/releases/2.7.php

Change-Id: Ifb0f869f59ef3acdbb6eb9fcc5185b7ffa949f04
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump immutables.org from 2.6.3 to 2.7.1

https://github.com/immutables/immutables/blob/master/README.md#changelog

Change-Id: I8094e076c09b531bc8ea720d82346d3f7670b006
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable unchecked warnings

Change-Id: I6b9574dc6118b2b494c95bf8871656dfbaac2ea9
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Disable findbugs on JDK9+

Findbugs cannot run on JDK9, disable it.

Change-Id: Ic565e6a4ab44ca5902d06a47ef38220bbb3d4f90
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 23b862ed3f9c4e0df79e8ac37cdc6e1811f3bfba)

Drop obsolete odl-guava-25 dependency tweak

We no longer depend on odl-guava-25 directly, adjusting its
configuration in the Karaf Maven plugin serves no purpose.

Change-Id: I7cb3ce9019aaa515b9f09a87c29d460ea09633fe
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Drop Maven site configuration

Change-Id: I92a72b2dd77cc425b635ac86f3cdcfa963c9ae3b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

bump pax-cdi-api from 1.0.0.RC2 to 1.0.0

Change-Id: Ie89e9b7b16557fd01f3dc79bbf44ada6583a4fa3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump jacoco-maven-plugin from 0.8.1 to 0.8.2

Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.1 to 0.8.2.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](https://github.com/jacoco/jacoco/compare/v0.8.1...v0.8.2)

Change-Id: I8eb810a3482504116595a4b84616b9df52ab8dd9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

bump xmlunit-legacy from 2.6.0 to 2.6.1

Bumps [xmlunit-legacy](https://github.com/xmlunit/xmlunit) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/xmlunit/xmlunit/releases)
- [Changelog](https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md)
- [Commits](https://github.com/xmlunit/xmlunit/compare/v2.6.0...v2.6.1)

Change-Id: I0c0e5a9d5af21d753d81e7b99ca2539fb2ac0d1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>