Claudio D. Gasparini [Tue, 5 Apr 2016 09:24:28 +0000 (11:24 +0200)]
BUG-4826: BGP Evpn Nlri's handlers
Evpn Nlri cases handlers
https://tools.ietf.org/html/rfc7432#section-7
Change-Id: I385e20a0e510328761c1f341a8c7744182dc5850
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:27:35 +0000 (11:27 +0200)]
BUG-4826: BGP Evpn Nlri's registry
Implementation of registry for handle Nlri's.
Change-Id: If71959b5c37f5c3b62268c25c1c10469010a4c08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 19 Apr 2016 11:27:40 +0000 (13:27 +0200)]
BUG-4827: Create grouping for Path-id and make it by default 0
+ Create grouping for Path Id
+ Make Path Id default value 0
Change-Id: I85ad9df929da144ff4b16e9042b21d83202c03c9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Mon, 18 Apr 2016 20:47:01 +0000 (13:47 -0700)]
Remove unused java test file
Change-Id: Ia49c16d9d6628d8e15425d24b5fc01b7bec1f45d
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Wed, 6 Apr 2016 09:52:48 +0000 (11:52 +0200)]
BGP-4826: Evpn Extended Communities Handlers Tests
Evpn Extended Communities Handlers Tests
Change-Id: I158374c44b0a842d8e68b90175880acc6e468d15
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:22:59 +0000 (11:22 +0200)]
BUG-4826: Evpn Extended communities handlers
Evpn Extended communities handlers
https://tools.ietf.org/html/rfc7432#section-7.5
Change-Id: I20328e15b60a885b64a9ffbf4ac34eb6fe7a23f8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 15 Mar 2016 11:28:07 +0000 (12:28 +0100)]
BMP: Sent/Received Open Message is not visible in DS
Instantiate codecs before initiating peer.
Enhance integration unit test to check presence of
sent and received Open message in DS.
Change-Id: Iad45750393bea9b68a1ad1f40def95f92d9e8fbd
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:57:10 +0000 (11:57 +0200)]
BUG-4826: Evpn ESI Registry
Evpn ESI Registry Implementation
Change-Id: I50ee6ddf717fe1553c7b57197ee91e43ad91f349
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 14 Apr 2016 12:50:03 +0000 (14:50 +0200)]
BUG-4827: BGP Add Path update odl-bgp-rib-impl-cfg
Update path-selection-mode list name to rib-path-selection-mode
beacuse of confilct with path-selection-mode container
Change-Id: Ic7fb67f25227968a8091301d0e6e0509e52aa2c2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Thu, 14 Apr 2016 13:05:17 +0000 (15:05 +0200)]
Fix failing config tests
Add missing bundle service mock.
Change-Id: If9fa9346b36f7b716be74dd7dd3eac1289ee65f5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Wed, 13 Apr 2016 12:15:57 +0000 (14:15 +0200)]
BUG-4826: Update BGP Evpn yang model
-Update BGP Evpn yang model by inserting a container over
each Evpn Case.
-Make Esi Choice and Evpn Choice manatory.
-Update of EsiModelUtil with new Qnames
-Update of test required by Evpn yang model update.
Change-Id: Ie55365d9694cec0c1be9a6b2b97420a0d0038632
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin [Tue, 12 Apr 2016 22:36:23 +0000 (15:36 -0700)]
Bug-5688: Fix NullPointer Exception for args in Stateful07TopologySessionListener
Change-Id: Iefd180597619d6a934529859c8fefcc003888686
Signed-off-by: Kevin <kevixw@gmail.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 12:57:16 +0000 (14:57 +0200)]
BUG-4826: Evpn ESI type Handlers test
Evpn ESI Handlers test implementation
Change-Id: I311e23b4b024c28f008d8b1142d2e73129c9d393
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:21:16 +0000 (11:21 +0200)]
BUG-4826: Evpn ESI Handlers
Evpn ESI Handlers
https://tools.ietf.org/html/rfc7432#section-5
Change-Id: I10fce0720ed60e7f37f416e7af741c61950afa85
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Mon, 11 Apr 2016 20:55:49 +0000 (20:55 +0000)]
Bug-5703: New file gets created under benchmark-app resources dir after build
Change-Id: Id98a3809ce2c7109993d5aab1f670fe3f4db244a
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Ajay L [Sat, 9 Apr 2016 01:49:17 +0000 (18:49 -0700)]
Bug-5691: Replace usage of deprecated DCL with DTCL
Change-Id: Id92514c2d07cc694be58578ad0e53ac73383d27b
Signed-off-by: Ajay L <ajayl.bro@gmail.com>
Iveta Halanova [Tue, 22 Mar 2016 14:35:31 +0000 (15:35 +0100)]
BUG-5511: Support Route Refresh operation from BGP
Created module for peer-rpc request.
Implemented class for handling input.
Updated unit tests
Change-Id: I1e0f24acc9eb713c9c60f4ab977e7efd892f563a
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Tue, 12 Apr 2016 08:48:27 +0000 (10:48 +0200)]
Bug 5704 - BGP session unit tests failing after Netty version bump
Fixed BGPSessionImpl unit test. Used mocked channel instead of
spying embded channel.
Change-Id: Iefaa41ecb80a510554b814a58cc6fdeb08422b57
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 4 Apr 2016 07:31:02 +0000 (09:31 +0200)]
BUG 4826: Create BGP-EVPN module
Create modules and BGP Evpn yang model
ref.: https://tools.ietf.org/html/rfc7432
Change-Id: I7c257cf8d89aba0732bbd3237b0844657b7a36b3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Thanh Ha [Thu, 7 Apr 2016 03:24:44 +0000 (23:24 -0400)]
Add Java apidocs link to Maven Site menu
Change-Id: Ib3668789d532b2d0f2d88973975473933117ec17
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Claudio D. Gasparini [Fri, 1 Apr 2016 08:41:35 +0000 (10:41 +0200)]
BUG-4827: N/All Paths Selection Mode test implementation
Implementation test for All/N Paths Selection Mode.
Change-Id: Ia4b263ebe23c7d470685b0452e7098b21b25f0f6
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Thu, 31 Mar 2016 00:23:29 +0000 (00:23 +0000)]
Bug-5023: Simplify client re-connection strategies
- removed dependency on protocol-framework from all projects
- use of netty capabilities for reconnection instead of using protocol-framework reconnection strategies
- added new per-peer "retry-timer" attribute for reconnection interval (default value 10)
- updated cfg yang model and initial config files
- updated unit-tests for above changes
Change-Id: I32946598d791a8264e73133a2bf4a4ed35598a39
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Fri, 1 Apr 2016 08:40:26 +0000 (10:40 +0200)]
BUG-4827: Fix minor bugs on Add Path Selection Mode
Fix minor bugs on Add Path Selection Mode.
PathId should increment only if route didn't exist previously.
Change-Id: I3c06eade75d1d87f5d0808e0b210975ae61b6490
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Wed, 16 Mar 2016 22:47:47 +0000 (15:47 -0700)]
Disable the original TestHelper and use the new MDSAL-it-base classes
Change-Id: Ic2e626a2bc56b2cda0e776fc42d1b8bbbe88b6ed
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Milos Fabian [Thu, 31 Mar 2016 10:56:01 +0000 (12:56 +0200)]
Bug 5623 - BGP-LS Topology provider is not able to handle MPLS TE LSP NLRI Type
BGP-LS topology provider was throwing exception in a case of
unsupported NLRI types processing.
Soften a behaviour to debug message logging, as new BGP-LS
NLRI types are expected not to be exposed to the
topology (at least not now).
Change-Id: If2b6c2d5344fe39d78992a93ed969e1e1219f7ec
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
c3d74674d4c5e2098680ba54c018a9a08eeba400)
Milos Fabian [Wed, 30 Mar 2016 12:19:02 +0000 (14:19 +0200)]
Bug 5564: BGP-LS: Bad handling of unknown NLRI type cause NPE
Fixed destination extractor for TE LSP NLRI Type.
Change-Id: Ie1a26e78d71d289ae2b63bd3c7a5d7167c50ee99
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 21 Mar 2016 09:53:38 +0000 (10:53 +0100)]
BUG-4827: Base Path Selection mode test implementation
Implementation of test for base path selection mode
Change-Id: I49a29e10a4b01f63e06aea0cb175a6eec6fb5487
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 8 Mar 2016 13:15:38 +0000 (14:15 +0100)]
BUG-4827: Introduce Avertise All Paths Selecetion Mode
Introduce Avertise All Paths Selecetion Mode
Change-Id: I744cf2722828234203fe3830a753ec1e0259c9ee
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sat, 5 Mar 2016 21:38:16 +0000 (22:38 +0100)]
BUG-4827: Introduce Advertise N Paths Selection Mode
Introduce Advertise N Paths Selection Mode
Change-Id: Ia92570fe60e73a0a34d20668aea21322c1746d76
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Mon, 28 Mar 2016 18:11:42 +0000 (18:11 +0000)]
Bug-5500: Check Application Peer's bgp-rib-id config attribute against BGP Peer's host attribute for conflicts
- inject BGPPeerRegistry into BGPApplicationPeerModule as optional dependency
- insert ApplicationPeer into BGPPeerRegistry during BGPApplicationPeerModule to check for address conflict with existing BGP peers
- update BGPApplicationPeerModule unit-test
Change-Id: I8f612cf9eed02cf2a6b5e4832d2c8f9940d415a8
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Thanh Ha [Wed, 30 Mar 2016 14:41:51 +0000 (10:41 -0400)]
Enable Maven Site generation
Forgot to add the deploy-site.xml file in the last patch
which activates the site generation.
Change-Id: I39b17ce21dae3901e68217b260d04800cfb35820
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Wed, 30 Mar 2016 15:20:13 +0000 (11:20 -0400)]
Fix missing javadoc strings
Change-Id: I07b022b681c343ef38e8ec14a5e655dabd5306ca
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 29 Mar 2016 20:00:13 +0000 (16:00 -0400)]
Remove redundant javadoc/sources configuration
javadoc and sources are inherited from odlparent.
Change-Id: Ib6fc2100e29994ecf3017c5305d372b251043997
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 29 Mar 2016 18:36:10 +0000 (14:36 -0400)]
Enable Maven Site generation
Change-Id: I75fb39ed1e8c653a9debc9c0dab0b9ca32ddb0bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Wed, 16 Mar 2016 23:20:13 +0000 (19:20 -0400)]
Do not install or deploy the karaf artifact
The karaf artifact is only used for testing. It does not need to be
released to the world.
Change-Id: I11aef8e696b1df41550f6e574a8e042d81cf5582
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Fri, 18 Mar 2016 11:09:47 +0000 (12:09 +0100)]
Bug 5457 - BGP-LU update from app peer to exabgp peer: Labels missing
Make sure all labels are added into label entry, not only the last one.
Change-Id: I54a28185a46d7757e729be1384485fb610fd8f52
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 16 Mar 2016 17:50:48 +0000 (18:50 +0100)]
Bug 4731: Routes from BGP application peer not populated to example-ipv4-topology in case of zero routes initial POST request
Write routes into the eff-rib-in only in a case when
there are some routes in data change, so do not
overwrite empty routes table created before.
Change-Id: Ib3718b4bdee2d738514a0248eee11f0e9c8afbe0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
c1d773731c031a1775fbda56a5551ecdca3a8e55)
Milos Fabian [Fri, 18 Mar 2016 09:18:43 +0000 (10:18 +0100)]
Bug 5467 - BGP-LS topology provider NPE
Added missing null check - in a case a node attributes
are not present (so IS-IS area is missing), the NET address is not set.
Change-Id: If3a8106abb2035b1dbf28e3760f74dab5e09fca0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
c536a6cea582a90af3644a8f21886a2d0ee508be)
Milos Fabian [Fri, 18 Mar 2016 13:19:49 +0000 (14:19 +0100)]
Bug 5030: BGP Benchmark app - unit tests
Added unit tests for implementation.
Change-Id: I69f76aee8c1d1b2364796cc47501230f65d94ac2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 14 Mar 2016 11:35:10 +0000 (12:35 +0100)]
Add MP capabilities extension to Open message
Extend Open messages model used in BMP Peer Up notification
with multi protocol extensions capabilities.
Change-Id: I0cdc8d7b812db4ecee6e766b9d6cbd95477c3197
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 9 Mar 2016 17:53:32 +0000 (18:53 +0100)]
Bug 5030: BGP Application Peer beanchmark app
Created benchmark ODL application for performance
testing of BGP application peer.
The application offers two types of RPC operations:
*add-prefix - for injection of IPv4 prefix routes
*delete-prefix - for IPv4 prefix routes removal
Change-Id: Ia3e3e930b01d59e0ab21dcf777801716e6f13769
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 14 Mar 2016 10:04:25 +0000 (11:04 +0100)]
Make MP capabilities reusable
Move MP capabilities model from augmentation to
grouping so the model can be reused.
We need it in BMP.
Change-Id: I3f458bed807a34d7ca73a1fe238b379ed42f62ae
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Omair [Mon, 14 Mar 2016 20:12:55 +0000 (13:12 -0700)]
BUG 5031:
Bring order into the BGP-LS encoders/decoders by introducing simple codecs
and their registers for BGP-LS's NLRI types, to make it more extensible.
Change-Id: Idd0740db3d3dc1828b5d5459a75bf0799b70d6ef
Signed-off-by: Omair <of8826@att.com>
Iveta Halanova [Tue, 22 Mar 2016 06:22:22 +0000 (07:22 +0100)]
BUG-5548: NH serializer removal
Correction of removing the NH serializers
Change-Id: Ica72b9ac71a7f412d528950f7afda68e1ec03fc5
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 21 Mar 2016 08:21:04 +0000 (09:21 +0100)]
BUG-5548: Wrong NH handler picked up
Adjusted NH handlers map to hold also afi/safi information
so IPv4 NH handler is not overwritten by VPN IPv4 NH handler.
Change-Id: If076355d5200bc161d23b261cbf6e2049453ccb1
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Fri, 18 Mar 2016 15:18:58 +0000 (16:18 +0100)]
Add missing check of present on optional variable
Check whether optional best path is present before proceed
to write the route
Change-Id: I531c73a6c3c4e8425e0620ac17e5aff90bd2981e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 11 Mar 2016 10:28:36 +0000 (11:28 +0100)]
BUG-4827: Modify ipv4-routes list model, to include path-id as part of the key
Add path Id as a part of the key for ipv4-routes. This will force us to use
path-Id when writing on Loc-Rib even when add-path selection mode are not
used. Therefore we need to adapt the code on base selection mode
to take in consideration wheter model can support Add-path or not
and proced accordingly.
Change-Id: I94bc6523ff788c236008df892569d3ea04cadb65
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 17 Mar 2016 13:33:50 +0000 (14:33 +0100)]
PeerTest update, unsupported Afi/Safi RR request
Change-Id: Icb77127ad8a8c72bb8924a38222c7a51eee5f853
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 17 Mar 2016 12:37:44 +0000 (13:37 +0100)]
BGPSessionImpl unhandled msg
Loging unhandled msg and avoiding class cast exception.
Change-Id: I4f917cc783918bb7cc00cdbc29393a2b09cceb07
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Sat, 5 Mar 2016 21:18:27 +0000 (22:18 +0100)]
BUG-4827: Introduce add path tables support and Path Id to rib support
On session up peer will advertise supported add path tables,
we store them on data store and introduce them to ribsupport
for future filtering of route advertise.
Also we introduce a method for extract Path Id from prefix received routes,
which will be used by Add Path selection modes.
Change-Id: I118e40913086aef71f1f72600c9b66de65b858b5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sat, 5 Mar 2016 21:13:42 +0000 (22:13 +0100)]
BUG-4827: Path Selection mode Config Subsystem integration
Create new module for path selection mode allowing us to
integrate add paths selections mode in a close future.
Change-Id: I36ec3e8267137505f76d6ee7230d9ce9aeea2714
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Wed, 16 Mar 2016 20:03:29 +0000 (20:03 +0000)]
Bug: 5287
Added support for multiple instances of data-change-counter
- Changed counter type to list in data-change-counter yang model
- Added counter-id field to module config yang model
- Removed singleton behavior for the module
- Updated TopologyDataChangeCounter to update count using corresponding counter-id
- Updated unit-tests
Change-Id: I15f43faa622c502dfa3837da1a3bed7f4e9c4c1b
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Tue, 15 Mar 2016 10:51:16 +0000 (11:51 +0100)]
Create two new interfaces for Export policies
Create two new interfaces for Export policies to separate
from implementation, and be used on different module without
suffer cyclic dependency.
Also we move another classes that will be required by other
modules.
Change-Id: I17265d3434e7302892ea0b5e5b06c88e54b39014
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 15 Mar 2016 10:01:37 +0000 (11:01 +0100)]
BGPPeerModule type change
AfiSafiKey -> BgpTableType
Change-Id: I341dcdf01fc3e4919207844e93fcb7b679947f0a
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 14 Mar 2016 06:48:43 +0000 (07:48 +0100)]
BUG-4592: RR message operation impl
Added handling when RR msg is received.
Updated session statistics and unit tests.
Change-Id: I213f27c38244cf6c5fee11074f4cad4ba7012b90
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Tue, 8 Mar 2016 11:37:38 +0000 (12:37 +0100)]
BUG-4592: Route Refresh message implementation
Updated yang model and added new notification.
Implemented parser and registered.
Updated MultiprotocolCapabilitiesUtil class.
Updated and added unit tests.
Change-Id: If389ff6e793bbbae49e8d2fb16071397e121518a
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 7 Mar 2016 13:39:48 +0000 (14:39 +0100)]
BUG-4592: Route Refresh Capability Config subystem
Added possibility to advertize RR Capability in open messge
and to configure this capability in ODL for peer.
Created Util class for common afi, safi handling with MP and with CParameters constant.
Updated and added tests.
Change-Id: Iabe3d96d49368be6870d4fffd207ca15021dcfd0
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Mon, 29 Feb 2016 15:23:32 +0000 (16:23 +0100)]
Rework BGPSessionImpl test
Use Embedded Channel instead of mocking it.
Added simple channel handler for written message
collection.
Change-Id: I90e9906be61d02c8dd3636f8d881d6e9b7a3bd3d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 2 Mar 2016 20:31:32 +0000 (21:31 +0100)]
Fix BGP-FS NPE
Fixed destination port serialization (BI->BA).
Change-Id: Ideff7dfc53e1860d78346afa1f813e013f81f9be
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 3 Mar 2016 11:32:33 +0000 (12:32 +0100)]
Bug 5453 - PCEP-SR capability is not send in Open Message
The PCEP-SR has to extend latest stateful Open Message handler,
which has changed since Lithium.
An appraoch of overriding parsers seems to be fragile, think about
something more flexible for Boron release (at leat for
capabilities - Open Message TLVs).
Change-Id: I42795a796e163722cf00066b64b83551051ab28b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Thu, 3 Mar 2016 13:08:51 +0000 (14:08 +0100)]
BUG-4825: OpenConfig integration
added afi/safi into OpenConfifUtil provider
Change-Id: I0787a9bcfe78eb4422b9dc24649dff3df30159a0
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Mon, 29 Feb 2016 15:21:45 +0000 (16:21 +0100)]
Fix BGP session statistics preferences colletion
Change-Id: Ic34762ec2462bedea9789d704ed399e495e91fef
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 29 Feb 2016 12:12:32 +0000 (13:12 +0100)]
Clean up Extended Messages Capability
The BGP extended message capability is represented
by empty container. Define constatnt for the capability.
Use it in a parser and unit tests.
Clean-up extended message capability unit tests.
Change-Id: I8a4a5785e6cb994f45cfd7c9efee68b5a24b97ac
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 29 Feb 2016 11:07:32 +0000 (12:07 +0100)]
Remove unused class in bgp-rib
The BGPSessionProposalImpl is not really used in
BGP implementation. Romove related unit test too.
Change-Id: I6f8f542fa962079a8c83f21c2a20e5aae065692c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Mon, 22 Feb 2016 14:11:27 +0000 (15:11 +0100)]
BUG-4825: BGP L3VPN configuration
Added and enabled configuration.
Tested with odl, app peer and exabgp peer.
Corrected RD and labels extraction in RIB Support.
Change-Id: Iefb45ba3aad13428bda11e52222877d51cec6a7a
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Mon, 29 Feb 2016 09:57:26 +0000 (10:57 +0100)]
RouteDistinguisher missing builder
created 2 new types and used in route distinguisher union.
implemented builder and updated util and test classes.
Change-Id: Iddc151f25ca5614ccdb0c18de2eeed65d7b50c2a
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Robert Varga [Thu, 25 Feb 2016 21:33:58 +0000 (22:33 +0100)]
BUG-2825: optimize NLRI ipv4/ipv6 prefix parsing
Instead of copying arrays around, use offset-based parsers from
IetfInetUtil.
Change-Id: I2d5f8f799ae61e1d6d247827b9d0d1cee6e8b9ef
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Robert Varga [Thu, 25 Feb 2016 20:02:33 +0000 (21:02 +0100)]
BUg-2825: optimize prefixForBytes/prefixForByteBuf
Instead of always performing a copy, copy the array only on size
mismatch.
In prefixForByteBuf, allocate a bytearray which has correct size and
read into it -- the rest of it will be zero-initialized, just as it
should be.
Change-Id: I1e71e98e3efba2d731bb8be2c6cfb8062dec00e2
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Robert Varga [Thu, 18 Feb 2016 16:31:59 +0000 (17:31 +0100)]
BUG-2825: use IetfInetUtil to instantiate addresses
Rather than brewing our own strings from bytes, use the utility methods
provided with the model. Also use a single instance for empty prefix.
Change-Id: Idfbfc7f2374b8d0205f1d0e3407e3e347242dbc9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 25 Feb 2016 21:00:42 +0000 (22:00 +0100)]
Do not use Lists.newArrayList()
We have diamond notation, which renders this unneeded.
Change-Id: I530718c00020a82f3af20d98b17d7a6e3bb3854f
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Robert Varga [Fri, 26 Feb 2016 10:29:42 +0000 (11:29 +0100)]
BUG-4831: container should be presence
If we do not make it a presence container, datastore will remove it
because it is empty.
Change-Id: I2b5e3fe2aac4f3c4a72af209e091ed40f910ed96
Signed-off-by: Robert Varga <rovarga@cisco.com>
Claudio D. Gasparini [Mon, 8 Feb 2016 11:40:54 +0000 (12:40 +0100)]
Update clearTable method name to createEmptyTableStructure
Update clearTable method name to createEmptyTableStructure which
is more appropiate
Change-Id: I5992773e169edb538bac655a833149dda1220c3c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Thu, 25 Feb 2016 20:57:54 +0000 (21:57 +0100)]
Pre-size NLRI lists
We have an input list, hence we know how big the output will be. Use
that to make sure we do not resize the list.
Change-Id: I6b8c9ec771416b98578820fd8b0b0d5104231c19
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Robert Varga [Thu, 25 Feb 2016 19:47:31 +0000 (20:47 +0100)]
Do not use string concat in precondition
Change-Id: Id25e4baab39ba13ad71748f4835732357fc11104
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Om Prakash [Sat, 20 Feb 2016 19:45:30 +0000 (14:45 -0500)]
BUG: 4831
The BGP specification mandates a maximum BGP message size of 4096 octets. As BGP is extended to support newer AFI/SAFIs,
there is a need to extend the maximum message size beyond 4096 octets. This code fix will update the BGP specification by providing an
extension to BGP to extend its current message size from 4096 octets to 65535 octets.
The major Design/code change for this fix is to modify Bgp-Message yang to add bgp-extended-message-capability in BGP Message.
BgpExtendedMessageUtil class is written to looks for Bgp Extended Message Capability in capabilities.odl-bgp-rib-impl-cfg.yang
is modifed to add extended message capability preference for Speaker and Peer.BGPSessionImpl class has been enhanced
to inject extended message capability of maximun frame size 65535.
BUG: 4831
Change-Id: Icb8731395106bc8164b830e57ea316e31702a4a7
Signed-off-by: Om Prakash <op317q@att.com>
Robert Varga [Wed, 24 Feb 2016 19:32:46 +0000 (20:32 +0100)]
Do not instantiate byte[] needlessly
Creating a single-byte array is not needed here.
Change-Id: I518419438d6eae6146616fba0725245fc348fee7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 24 Feb 2016 19:41:03 +0000 (20:41 +0100)]
ByteArray: do not instantiate arrays if not needed
Move array instantiation into the block where it is used, skipping it
completely in the case we have properly-sized array.
Change-Id: Ie5027f429830a39bfd2835cc5751cb3d6c27dd1e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 24 Feb 2016 18:31:13 +0000 (19:31 +0100)]
Remove reference to JUnitMatchers
constainsString() is deprecated, use the version n CoreMatchers.
Change-Id: Icff4e1fd24a3901899216962b4caf127f11f77b3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Thu, 18 Feb 2016 12:29:02 +0000 (13:29 +0100)]
Bug 5380 - NPE in BGP-LS MPLS-TE LSP serializer
Fix NLRI transformation from BI to BA - cases are
not a part of the BI data representation.
Fix typo in LSP TE NLRI type enumeration encoding -
missing hypen.
Change-Id: I0ee2470bc287b438a3d96189ea524145784ff95c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 22 Feb 2016 10:58:44 +0000 (11:58 +0100)]
BUG-4827: BGP Add Yang model design for Advertisement of Multiple Paths
Extend ipv4-prefix with new leaf path-id
representing an unic identifier for a single path.
Change-Id: Iec9c1ab8a57226f3b08e7fec3893f8655c45cadc
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 22 Feb 2016 06:40:19 +0000 (07:40 +0100)]
distribution-karaf restconf dependency
Change-Id: I08b0c44942f9890f67447bda71c37153650532da
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Fri, 19 Feb 2016 11:36:50 +0000 (12:36 +0100)]
BUG-4825: BGP L3VPN Yang update and correction
namespace change
added cfg yang module
updated imports
implemented generated module
Change-Id: I854fc5124164dbf1b47117bcd9897ba295d5d998
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Thu, 18 Feb 2016 14:31:19 +0000 (15:31 +0100)]
BUG-4825: BGP L3VPN RIB Support
Implemented and registered RIB support.
Used some implementation in LU RIB support.
Change-Id: Ie5ecd5e129d8db3238e76f87de719feb99a009ae
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Mon, 15 Feb 2016 09:46:40 +0000 (10:46 +0100)]
Fix minor sonar issues
Change-Id: I78639c0175e2bc62daa3cb333326674967103cd8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 11 Feb 2016 12:46:43 +0000 (13:46 +0100)]
BUG-4825: BGP L3VPN handlers
implemented VPN IPv4 Nlri and NextHop handler.
created BGPActivater and registered handlers.
Implemented unit tests.
ref.: https://tools.ietf.org/html/rfc4364#section-4.3
Change-Id: I6e8943ec78e7010792e37ad4c39e911025e13416
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Wed, 10 Feb 2016 14:23:13 +0000 (15:23 +0100)]
BUG-4825: BGP L3VPN yang data module
Created new subproject l3vpn under BGP.
Created module and defined NLRI grouping.
Augmented update message and RIBs.
ref.: https://tools.ietf.org/html/rfc4364#section-4.3.4
Change-Id: I30d9b6bc974e5762eae76476db7a28d00a88cfc3
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Tue, 9 Feb 2016 14:28:35 +0000 (15:28 +0100)]
BUG-5285: Transaction chain broken
Transaction chain broken when peer is connected after
application peer has been configuted.
Issue is caused when it tries to update app-peer adj-rib-out,
which doesn't exist.
Change-Id: I6c765cc0fb03100bc6564466f93eb65fb72cfe48
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 8 Feb 2016 09:42:21 +0000 (10:42 +0100)]
Bug 5265: Failed to deploy multiple instances of BMP monitoring station
Avoid overriding of previously created instance.
Create common parent node using merge operation.
Change-Id: I860be2d8cf44826e2d3c4975276664ef3f852313
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
3b0b23bb6920c94796341ee14c859b0622e8be71)
Jeff Liu [Tue, 17 Nov 2015 00:16:04 +0000 (16:16 -0800)]
BUG-4175 component registry in BGP FS
Add flowspec registry that allows registration of component and its handlers
Change-Id: I9098f809dd9d7add2323415b9673ca2bec16182c
Signed-off-by: Jeff Liu <bigdataops@gmail.com>
Iveta Halanova [Tue, 9 Feb 2016 14:02:00 +0000 (15:02 +0100)]
Sonar minor warnings fix
Change-Id: I392ab8d616c20451001e8fa52bfb9cc08ba642f7
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Wed, 10 Feb 2016 07:58:58 +0000 (08:58 +0100)]
Added missing headers
Change-Id: I4f49b2342e8cffd325be178c64aee57be504e7f0
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Tue, 9 Feb 2016 10:26:57 +0000 (11:26 +0100)]
ADD-PATH filter the same afi/safi-s with multiple different send-receive modes
Change-Id: I370fb6573a390f33c090ad398d9776c25aa2319d
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Mon, 8 Feb 2016 11:05:53 +0000 (12:05 +0100)]
BUG-5266: Perform role change in one step
Two steps role change was done when peer was removed,
after code on LocRibWriter has been reworked for previous
fixes this is not required any more and can be done in
only one step.
Change-Id: I9d885f9b99cffc21f93d18dcf8e953885a44ef38
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 27 Jan 2016 18:51:13 +0000 (19:51 +0100)]
BUG-5097: Error trying to update EffectiveRibIn from a removed Peer
When more than one peer are removed at same time, cause a race
condition between remove Peer from DS and update removed routes.
Fix by creating a shared Singleton cache with removed peers between
listeners.
Change-Id: Ic4b2ab8283e07695203f9e4d9ceb245985104766
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 8 Feb 2016 10:17:47 +0000 (11:17 +0100)]
AddPathImplModule unit test
Change-Id: I8632385f6407706bebbc4e0c694841f7ac76bc7b
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Fri, 5 Feb 2016 13:40:24 +0000 (14:40 +0100)]
BUG-4827: ADD-PATH capability BGP Peer config
Created new indentity add-path and its implementation for bgp-peer.
Added capability in BGPPeerModule.
Added to preferences in BGPSessionStats.
Change-Id: Ibf61a7885826fda892353eb350fb5bca754a50e4
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Fri, 5 Feb 2016 09:20:36 +0000 (10:20 +0100)]
BUG-5243: Failed to send message Notify
Don't try to send Notify message if the session
has been closed externally
Change-Id: Idd57bd5bf60e4f758ed0187bd12149854740cd36
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
14cad280a7d1ba51f72d683e689eb3b2eca96909)
Iveta Halanova [Fri, 5 Feb 2016 13:38:11 +0000 (14:38 +0100)]
ADD-PATH capability bug fix
Created typedef for send-receive enumeration.
Empty add path capability is not serialized.
Change-Id: I6d57918118237118e693c2eb348c32062d99d2d3
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Wed, 3 Feb 2016 14:21:34 +0000 (15:21 +0100)]
BUG-5166: Configuration of iBGP peer failed after previous BGP peers deconfiguration
De/Re-configuration was not treated well in the OpenConfig provider.
The Neighbor comaparator was outputting false-negative results,
because of some default values, which are not in our BGP configuration
interest.
Change Neighbor comparator to compare values realted to our BGP
peer configuration only.
Change-Id: I5e406e23bde8b183decf915e786f0fc29423ec7a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
2f29cb2252c8dffa091770fe3aa22eaaaa815036)
Robert Varga [Sun, 31 May 2015 12:09:06 +0000 (14:09 +0200)]
Use pingpong data broker for BI datastore
This mirrors the use of BA use of pingpong broker.
Change-Id: I4db39f6cd24c9512fbbc1806a49b1318ae15cd55
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit
e26553db70190697773174d2002f79a2fbdf2e29)