Isaku Yamahata [Wed, 3 Feb 2016 16:02:52 +0000 (08:02 -0800)]
Bug 4550 - always rebuild security group rule in security group
The change set of
906836c289a7e4c3d33669d90515d77e75cfb6d in
neutron northbound repository, the effort transparent neutron
northbound api, caused not to update security group rule in
security group.
So always rebuild rules in NeutronSecurityGroup and keep
security group rule in security group of yang model empty list.
openstack service provider that uses MD-SAL should not use
security group rules in security rule. But it should listen to
data change notification on security group rules.
Change-Id: Ic975e028c01462a2c7267f65c16b3bd857496c73
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit
a18e3f5a3744392c4475c82e4937af2a27d729fa)
Anil Vishnoi [Wed, 10 Feb 2016 22:15:40 +0000 (14:15 -0800)]
Bug-5040 : LLDP Spoofing attack warning when using Openstack with ODL Cluster
Change-Id: Ife9fa1bd8fcd02ca4af67c71d2d3429f6477310f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Eric Multanen [Thu, 4 Feb 2016 01:00:56 +0000 (17:00 -0800)]
OVSDB Qos and Queue - Postman examples
Adds a Postman collection of RESTCONF commands for doing
CRUD operations with Qos and Queue entries.
v2 - remove tabs
v3 - remove tabs in right file
Change-Id: I8e98b2f9b5c6e517a5a60516fe21fce063e169e2
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Sam Hague [Thu, 4 Feb 2016 23:17:28 +0000 (18:17 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
e0bf1166f4ad2515859ab43080a28115975a2cf5)
Change-Id: I0874c752f8777d8a3f6a7f8f60db22c605c986a3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 4 Feb 2016 02:26:56 +0000 (21:26 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
498fe4df2997839fdf12555eb5961008ce9eab1a)
Change-Id: Ibf950ae9b56317441014497ffd4260580326d802
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 4 Feb 2016 14:13:12 +0000 (14:13 +0000)]
Merge "Fix for changes to neutron-l3.yang"
Sam Hague [Thu, 4 Feb 2016 02:42:46 +0000 (02:42 +0000)]
Merge "BUG-5006: rework tests using AbstractDataBrokerTest"
Sam Hague [Thu, 4 Feb 2016 02:42:27 +0000 (02:42 +0000)]
Merge "Use constants for NeutronSecurityRule"
Vishal Thapar [Tue, 2 Feb 2016 18:53:25 +0000 (00:23 +0530)]
Fix for changes to neutron-l3.yang
Fix for BUG5137 in neutron breaks any code using routes option of
NeutronRouter. This fix is to change type of routes from String to Routes
as per yang changes.
Change-Id: I89866b31003a8b384c45ef9b451c5d189961df60
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit
61b1b633dfcd9fc1080286ef32d5683e41dff5a5)
Aswin Suryanarayanan [Tue, 2 Feb 2016 21:36:44 +0000 (03:06 +0530)]
Fixes Bug 5187
remote security group will continue the addition/deletion of rules after
logging if not found in cache.
Change-Id: Ic6129b0e8884a185e0907789de66a5df3eee39c0
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Stephen Kitt [Tue, 2 Feb 2016 13:33:23 +0000 (14:33 +0100)]
BUG-5006: rework tests using AbstractDataBrokerTest
Change-Id: I5d7acd00cfc71291e622bd79dc850a24be63f084
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Rashmi Pujar [Mon, 1 Feb 2016 18:05:41 +0000 (13:05 -0500)]
BUG 5172: Handle SchemaVersionMismatchException for lldp column
Change-Id: I3014048642b298bdb347660c3ac0704c23996e22
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Stephen Kitt [Mon, 1 Feb 2016 16:39:43 +0000 (17:39 +0100)]
Use constants for NeutronSecurityRule
This patch introduces constants for the directions, protocols and
ethertypes in NeutronSecurityRule.
There's also a bunch of small clean-ups in the affected classes.
Change-Id: Ia07efa48eb431f560d9f1f947170e1fb68e24ddb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
hari.pr [Tue, 26 Jan 2016 05:56:45 +0000 (11:26 +0530)]
BUG-4892:fixed Not getting Arp flows if there is no Router
*Moved the ARP handling part to a new file, This way the
ARP Entries are not restricted to l3 operations only.
*Tested L2 and L3 operations.
From our understanding
In router scenario whenever router created using openstack, netvirt
south bound handler will receive interface update event. ARP responder
will program the arp rules for the router interface event through
distributed arp service class.
(openstack àrouter create àsouthbound handleràprocess event àprocess interface updateàARP handleinterface eventàprogram ARP)
In normal L2 scenario whenever tenant network created using openstack,
netvirt will receive neutron port add event distributed arp service
class use this neutron port details to program arp rules for the DHCP IP.
Whenever VM instance created using openstack, netvirt will receive
neutron port event distributed arp service class use this neutron port
details to program arp rules for particular VM IP.
(openstackàVM instance à port handleràprocess eventà do neutronport(ADD/UPDATE/DELETE) à handle port àprogram ARP)
Change-Id: Ie56bd5d407f501b8a82f9fe3ad0672e57448eeef
Signed-off-by: hari.pr <hari.pr@hcl.com>
Sam Hague [Mon, 1 Feb 2016 15:48:42 +0000 (15:48 +0000)]
Merge "BUG-5110 Enable pinging any router"
Sam Hague [Sun, 31 Jan 2016 22:08:37 +0000 (22:08 +0000)]
Merge "Bug 5149: Support LLDP on ovsdb interface"
Rashmi Pujar [Fri, 29 Jan 2016 22:22:50 +0000 (17:22 -0500)]
Bug 5149: Support LLDP on ovsdb interface
Change-Id: I9b61d2e149479ae95f6978ae04e4f4e3e2a6df53
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Josh [Wed, 27 Jan 2016 16:08:12 +0000 (18:08 +0200)]
BUG-5110 Enable pinging any router
Works like this:
In table 60, routed packets have their src MACs
saved to reg4 and reg5
In table 70:
ICMP echos are responded to, for routed packets
and for pings to routers on the same LAN
Change-Id: I23e3a6ef5397aa687e14745841efeccc3f7a5301
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Sun, 31 Jan 2016 01:43:56 +0000 (01:43 +0000)]
Merge "Add IPv6 SecurityGroup tests."
Sridhar Gaddam [Wed, 27 Jan 2016 12:57:40 +0000 (18:27 +0530)]
Add IPv6 SecurityGroup tests.
This patch also includes fix for Bug-5134: Address exceptions when SG
remote_group_id has both IPv4 and IPv6 addresses.
Change-Id: I25855fa0bd5fe1938efb68a459982d790f4bdb27
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sam Hague [Sat, 30 Jan 2016 16:55:36 +0000 (11:55 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
d0a7d318ebf445da858aee508b477d0584977fa6)
Change-Id: I6c54b206cd9653868d16f1799ff21891af6333da
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 29 Jan 2016 20:20:52 +0000 (15:20 -0500)]
Bug 5147 - Wrong logging level for ConfigProperties not found with defaults
Change-Id: Ib53ef62942c4248fc258d752aea5f570447312c3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 28 Jan 2016 21:51:51 +0000 (16:51 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
f00b01e77a14b1ad53b6553296499c9d30365808)
Change-Id: I25fd28e89f78fb101c1e187d0ce06eba02567dfb
Signed-off-by: Sam Hague <shague@redhat.com>
stack [Tue, 19 Jan 2016 22:41:29 +0000 (14:41 -0800)]
Unit tests for OVSDB clustering
Added some unit tests to OVSDB Clustering work done
during 'Be'.
V2: Removed unit test for deleteNode as this method was unused.
Change-Id: Icd18b87cd472d06317a5a7368acfc19c66f1cef4
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>
Sam Hague [Thu, 28 Jan 2016 15:37:08 +0000 (15:37 +0000)]
Merge "[Bug 5131]- Hard-coded base url in Ovsdb-ui"
Sam Hague [Thu, 28 Jan 2016 15:36:33 +0000 (15:36 +0000)]
Merge "BUG-4794: use the transaction invoker for hwvtep"
Sam Hague [Thu, 28 Jan 2016 15:35:26 +0000 (15:35 +0000)]
Merge "BUG-2625: remove unneeded equinox dependencies"
Sam Hague [Thu, 28 Jan 2016 15:34:40 +0000 (15:34 +0000)]
Merge "Remove SouthboundUtil::deleteNode()"
Maxime Millette-Coulombe [Thu, 28 Jan 2016 14:34:37 +0000 (09:34 -0500)]
[Bug 5131]- Hard-coded base url in Ovsdb-ui
- Localhost is hard-coded in Northbond handler, so make it dynamic.
- Use a empty gif has logo so you won't see a broken image and 404 error
log
Change-Id: Ie30c15b8e818ccec2038908af5ffb02a2b595a7a
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>
Stephen Kitt [Thu, 28 Jan 2016 09:51:38 +0000 (10:51 +0100)]
BUG-4794: use the transaction invoker for hwvtep
HwvtepConnectionManager can delete a connection without going through
the transaction invoker. This patch fixes this and removes the
now-obsolete deleteNode method from HwvtepSouthboundUtil.
Change-Id: I623016599a7de2cc7e6edf72865e10af452f3a8b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Wed, 27 Jan 2016 21:27:04 +0000 (22:27 +0100)]
BUG-2625: remove unneeded equinox dependencies
These dependecies are not needed, remove them.
Change-Id: I4dccd9c3e080047b8d958e201ddf0cc84c78f2a6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Stephen Kitt [Wed, 27 Jan 2016 13:49:24 +0000 (14:49 +0100)]
Fix generics for JDK 8
Change-Id: I473fcee5429f9b7736b175ed4633cc9d7dafded2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 27 Jan 2016 12:41:53 +0000 (13:41 +0100)]
Remove SouthboundUtil::deleteNode()
This method is unused and, since it doesn't use the transaction
invoker, potentially dangerous.
Change-Id: Ibbc674a5983d8e52094888a58eb6c7382daac467
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Flavio Fernandes [Tue, 26 Jan 2016 20:44:06 +0000 (15:44 -0500)]
Bug-5069 Disable ovs in-band mode: cosmetics remove redundant line
Change-Id: Ibdf949f1aeff25fe4f69d5fe7f04bcabb7392c68
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Tue, 26 Jan 2016 18:53:04 +0000 (13:53 -0500)]
Boron: remove dependencies for neutron::dummyprovider
Now that neutron northbound project is no longer
requiring a neutron provider to exist [1], there is no
need to depend on that dummy feature. :)
[1]: https://git.opendaylight.org/gerrit/#/c/27291
Change-Id: Iedbb7253183f1830b64a2aa6ff0c5c5f498135f8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Stephen Kitt [Tue, 26 Jan 2016 14:28:38 +0000 (15:28 +0100)]
BUG-4794: use the transaction invoker to queue the clean-up
When a manager disconnection comes in, an OvsdbRemoveNodeCommand is
queued in the transaction invoker to remove the corresponding nodes.
If an ownership change is detected, an "emergency" clean-up is
executed, but without going through the transaction invoker; it's
executed using the MD-SAL data broker directly. Both of these
operations try to protect themselves by checking the presence of
appropriate nodes before running; but in some cases we see
manager-node-entry list item deletions being attempted on a deleted
manager-node-entry list, which causes a crash.
To avoid the race which leads to these crashes, this patch queues the
emergency clean-up with the transaction invoker, ensuring that the
operations will be serialised with any other clean-ups. In this way
the protection checks will be effective and avoid deleting items from
no-longer-existent lists.
Change-Id: Ia4ff31677e61d897720ce3209d6da7eed5e5ee8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Mon, 25 Jan 2016 15:00:04 +0000 (15:00 +0000)]
Merge "Bug 5008 - QoS and Queue fixes for ovsdb southbound"
Aswin Suryanarayanan [Mon, 25 Jan 2016 16:40:17 +0000 (22:10 +0530)]
Fixes Bug 4643
The fix for the bug 4205 is extented to instances where neutron
port cache is used.
Change-Id: I5e3e90f2e3335e65dca29112a551ccd053823f53
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Aswin Suryanarayanan [Mon, 25 Jan 2016 16:22:20 +0000 (21:52 +0530)]
Fixes Bug 4769
The fix for the bug 4205 is extented to other instances where neutron
port cache is used.
Change-Id: Ic69142c1804a37725a9dc9c611d583302284d18c
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Sam Hague [Sat, 23 Jan 2016 22:35:07 +0000 (17:35 -0500)]
Bug 5066 - ConflictingModificationAppliedException: Node was created by other transaction.
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
ef9d4d8fdd25d26d8d13b9d69e269a2e4becbbd6)
Change-Id: I175b007213908abd41f7a1168ad160fc86d337e9
Signed-off-by: Sam Hague <shague@redhat.com>
Eric Multanen [Mon, 14 Dec 2015 15:10:10 +0000 (07:10 -0800)]
Bug 5008 - QoS and Queue fixes for ovsdb southbound
Update the operational MD-SAL for Queue and Qos updates from the OVS
host.
Support configuration of QoS and Queue via configuration MD-SAL.
- Support for adding and deleting QoS entries. A qos-id is used
as a handle for qos entries in the MD-SAL. This is added to
the 'external-ids' of the qos entry. Qos entries originating
from the OVS host are assigned a qos-id of "qos://<uuid>".
- Qos entries can be assigned to a Port (termination point)
which is present in the MD-SAL by setting the port qos
attribute to the UUID of the relevant Qos entry.
- Qos entries are cleared from a port by updating the
port configuration with the qos attribute removed.
- Support for adding and deleting Queue entries. a queue-id
is used as a handle for queue entries in the MD-SAL. This
is added to the 'external-ids' of the queue entry. Queue
entries originating from the OVS host are assign a qos-id
of "queue://<uuid>".
- Queue entries can be added or deleted to the queue list
of a Qos entry present in the config by filling out (or
removing from) the queue-list attribute of the qos entry.
v2 - added setting of exising qos uuid to an existing port
- added clearing of a qos setting for a port
v3 - ovsdb.yang whitespace fixes
- fixes for failed tests
v4 - fixed model - queue list in Qos entries needed
a queuenumber key value
- fixed up comments on whitespace and log messages
v5 - finished set/clear of queues list in a qos entry
- added more description about the functionality in
the patch set.
v6 - fixed up more whitespace, and copyright comments.
v7 - address review comments:
- white space
- remove unnecessary code
- remove commented out code
- adjust some LOG levels
- remove unused imports
Change-Id: Idec02aaa82e1ffa66e58862ecfc5edff05050444
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Sam Hague [Sat, 23 Jan 2016 22:48:37 +0000 (22:48 +0000)]
Merge "SouthboundIT: make "value mandatory" a builder property"
Sam Hague [Sat, 23 Jan 2016 21:32:02 +0000 (21:32 +0000)]
Merge "IPv6 support in Security Groups."
Sam Hague [Sat, 23 Jan 2016 21:30:14 +0000 (21:30 +0000)]
Merge "Fixed UT and cleaned up code. 1. Fixed the UT issues in IngressAclServiceTest and EgressAclServiceTest. 2. Cleaned up unused method and UT in IngressAclService and EgressAclService."
Stephen Kitt [Fri, 22 Jan 2016 09:57:05 +0000 (10:57 +0100)]
SouthboundIT: make "value mandatory" a builder property
Instead of coding explicit instanceof tests, turn the mandatory nature
of the value into a builder property.
Reset the builders immediately after use.
Change-Id: I5fc20a17ff903cb01a0b8c091300c099c84ab3e4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Thanh Ha [Fri, 22 Jan 2016 05:50:27 +0000 (00:50 -0500)]
Re-enable net-virt-sfc
Change-Id: Id54c96b226b832db5d91987fce8d549a35ad228a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 21 Jan 2016 20:51:40 +0000 (15:51 -0500)]
Bump yangtools to 1.0.0-SNAPSHOT
Change-Id: I1c28f5240c202bc8d79e0c0ecd3ae84e7582c00b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Aswin Suryanarayanan [Thu, 21 Jan 2016 21:22:48 +0000 (02:52 +0530)]
Fixed UT and cleaned up code.
1. Fixed the UT issues in IngressAclServiceTest and
EgressAclServiceTest.
2. Cleaned up unused method and UT in IngressAclService and
EgressAclService.
Change-Id: I8632eb28ae292ea7a50968291cf9f6bdfc92fdaf
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
sridhargaddam [Mon, 11 Jan 2016 16:10:49 +0000 (21:40 +0530)]
IPv6 support in Security Groups.
This patch implements IPv6 support for Security Groups in OVSDB
Net-virt.
Pending: Test cases will be added in a subsequent patch.
Change-Id: If692c9b205af87517d69cbcc9f8c1be4decc917e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Josh [Tue, 19 Jan 2016 16:02:43 +0000 (18:02 +0200)]
BUG-5013 Fix check logic in MatchUtils.createICMPv4Match
The original logic checked that *either* of the
input params was non-null instead of checking
each.
Change-Id: I941133c00b09335eb0cf4a48b9abf35d8b305438
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Tue, 19 Jan 2016 13:14:49 +0000 (13:14 +0000)]
Merge "Bug 5007 - Reenable SG IT"
Sam Hague [Tue, 19 Jan 2016 11:25:01 +0000 (11:25 +0000)]
Merge "BUG-5006: Rework testEnqueueEvent to avoid private methods"
Sam Hague [Tue, 19 Jan 2016 11:24:40 +0000 (11:24 +0000)]
Merge "BUG-5006: Reduce usage of PowerMock"
raveek [Tue, 19 Jan 2016 10:49:58 +0000 (16:19 +0530)]
Bug 5007 - Reenable SG IT
Change-Id: I5526fcc356b58484613d9dfcbfa453d66c0e354a
Signed-off-by: raveek <raveek@hp.com>
Stephen Kitt [Mon, 18 Jan 2016 17:00:55 +0000 (18:00 +0100)]
BUG-5006: Rework testEnqueueEvent to avoid private methods
Instead of checking calls to dispatchEvent(), provision an event
handler and use that to make sure the queue is processed. Stop the
event processing thread to avoid races in the assertions.
Change-Id: Ic385314e15dead0c1f796c25863136a3a60099ac
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 14 Jan 2016 15:56:26 +0000 (16:56 +0100)]
BUG-5006: Reduce usage of PowerMock
Make ServiceHelper and ConfigProperties overridable; this allows most
of the tests using PowerMock to switch to plain Mockito.
Change-Id: I50c5c64f687fb0b0aa73194fb3d6266951eedb23
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Sam Hague [Tue, 19 Jan 2016 00:40:04 +0000 (00:40 +0000)]
Merge "Bug 4996 - Wrong flows when using SFC coexistence"
Sam Hague [Mon, 18 Jan 2016 21:59:59 +0000 (16:59 -0500)]
Bug 4997 - Fix for ConnectionInfo parsing in showMdsal tool
Change-Id: If3fee23373829c520fcc532ba70b1a45061aa2b3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 18 Jan 2016 21:58:42 +0000 (16:58 -0500)]
Bug 4996 - Wrong flows when using SFC coexistence
Change-Id: Icb9cab27b271f0e5462ecb87ead7a10f0f083bd1
Signed-off-by: Sam Hague <shague@redhat.com>
Flavio Fernandes [Fri, 15 Jan 2016 14:58:48 +0000 (14:58 +0000)]
Merge "BUG-4205 : VM delete doesnot remove all related flows"
Sam Hague [Fri, 15 Jan 2016 14:46:52 +0000 (14:46 +0000)]
Merge "Fixes an issue in induvidual security rule update, when remote SG is selected."
bviswa [Thu, 22 Oct 2015 03:08:01 +0000 (08:38 +0530)]
BUG-4205 : VM delete doesnot remove all related flows
Patch set 3: Rebase and add ref to bug 4971
Patch set 5: Rebase again and move processSecurityGroupUpdate()
Change-Id: Ia3cbba3087232cb56eee6e5424cdd011a01ce266
Signed-off-by: bviswa <badrinath_viswanatha@dell.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Thanh Ha [Fri, 15 Jan 2016 06:33:11 +0000 (01:33 -0500)]
Bump versions by 0.1.0 for next dev cycle
Change-Id: I647f1e840b4d4bc587f6cbce4018ed187922a7a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Aswin Suryanarayanan [Thu, 14 Jan 2016 19:44:01 +0000 (01:14 +0530)]
Fixes an issue in induvidual security rule update, when remote SG is
selected.
Change-Id: Id8d5ea6c6235c31f9147556244f619a15a279382
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
Sam Hague [Thu, 14 Jan 2016 11:10:30 +0000 (11:10 +0000)]
Merge "Add support for bfd-status for monitoring"
Sam Hague [Thu, 14 Jan 2016 03:19:22 +0000 (03:19 +0000)]
Merge "Workaround for failing Netvirt SG IT"
Sam Hague [Thu, 14 Jan 2016 02:01:23 +0000 (21:01 -0500)]
Workaround for failing Netvirt SG IT
Change-Id: I2e9ed58680ebefb6ceed912af5518b5eb543da7d
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Mon, 11 Jan 2016 18:46:42 +0000 (10:46 -0800)]
Added cluster aware mdsal utils class to net-virt (redo)
Looks like while code cleanup we removed the MdsalUtils.java from the master branch
and while merging master branch to net-virt-clustering, it got removed as well.
Net-virt-clustering had a modified version of MdsalUtils.java, where put/merge/delete
transactions are only done by the master instances of net-virt. ClusterAwareMdsalUtils
class bring those changes back.
Patch set 2: Explicitly callback into OvsdbInventoryService when netVirt becomes owner.
Patch set 3: Undo patch set 2; make ProviderEntityListener to happen earlier
Change-Id: I42ab5f2969bcff7737d90f2651d2762897e74c9a
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Thu, 14 Jan 2016 01:11:29 +0000 (01:11 +0000)]
Merge "Revert "Added cluster aware mdsal utils class to net-virt.""
Flavio Fernandes [Wed, 13 Jan 2016 21:34:43 +0000 (21:34 +0000)]
Revert "Added cluster aware mdsal utils class to net-virt."
This reverts commit
e9ec56b353a2d9098e77d623b7c756069bb58cb9.
This causes a regression in that netvirt:1 is never written to mdsal. to be re-visited.
Change-Id: I683dcac86c23445762d460183fa3e651a600f2c2
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Flavio Fernandes [Wed, 13 Jan 2016 12:24:12 +0000 (12:24 +0000)]
Merge "Drop testRegisterNewInterface() entirely"
Vishal Thapar [Wed, 13 Jan 2016 11:40:29 +0000 (12:40 +0100)]
Add support for bfd-status for monitoring
bfd-status gives information about current state of tunnels. This required
to monitor tunnels and know when they go up/down.
Change-Id: I5d864d46adf1444b00382acef58e298df5dc155e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Wed, 13 Jan 2016 09:55:54 +0000 (10:55 +0100)]
Drop testRegisterNewInterface() entirely
This test requires a bundle context to work properly, so it's not
really doable in a unit test.
Change-Id: I29a5a74597146dc3342c6fe7906a28fe89d6d22a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Josh [Sun, 10 Jan 2016 11:13:01 +0000 (13:13 +0200)]
Bug 4132 config ovs to respond to pings to router
Relies on https://git.opendaylight.org/gerrit/#/c/32135/
N.B. I added a unit test, IcmpEchoResponderServiceTest,
however it's currently skipped along with all the other
unit tests under services.
Patch set 8: Fix imports
Change-Id: If5d212c29acaf49d3cdd16cb9a02a63073202a88
Signed-off-by: Josh <jhershbe@redhat.com>
Sam Hague [Wed, 13 Jan 2016 00:23:23 +0000 (00:23 +0000)]
Merge "Use ClusteredDataTreeListener in hwvtepsb"
Sam Hague [Tue, 12 Jan 2016 23:04:58 +0000 (23:04 +0000)]
Merge "Adding changes to use and support connecting tracking. By default SG will push flows with out conntrack match and action, but user can modify default-config.xml to enable conntrack."
Sam Hague [Tue, 12 Jan 2016 21:46:33 +0000 (16:46 -0500)]
Disable broken unit test: NeutronFloatingIPInterfaceTest
The test fails with:
Running org.opendaylight.ovsdb.openstack.netvirt.translator.crud.impl.NeutronFloatingIPInterfaceTest
Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.908 sec <<< FAILURE! - in org.opendaylight.ovsdb.openstack.netvirt.translator.crud.impl.NeutronFloatingIPInterfaceTest
testRegisterNewInterface(org.opendaylight.ovsdb.openstack.netvirt.translator.crud.impl.NeutronFloatingIPInterfaceTest) Time elapsed: 0.054 sec <<< ERROR!
java.lang.NullPointerException: null
at org.opendaylight.ovsdb.openstack.netvirt.translator.crud.impl.NeutronFloatingIPInterface.<init>(NeutronFloatingIPInterface.java:35)
at org.opendaylight.ovsdb.openstack.netvirt.translator.crud.impl.NeutronFloatingIPInterfaceTest.testRegisterNewInterface(NeutronFloatingIPInterfaceTest.java:329)
There are other exceptions listed earlier which look to be a conflict between the mockito and jacoco:
https://gist.github.com/
02f3a56db00ce9b15eb2
Change-Id: I519e63c4a8825d49189dbc4b241998b940c6f4f2
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Tue, 12 Jan 2016 20:06:22 +0000 (20:06 +0000)]
Merge "Enable PowerMock instrumentation with JaCoCo"
Sam Hague [Tue, 12 Jan 2016 20:05:54 +0000 (20:05 +0000)]
Merge "Added cluster aware mdsal utils class to net-virt."
Sam Hague [Tue, 12 Jan 2016 20:05:28 +0000 (20:05 +0000)]
Merge "Explictly cleanup all the bridges managed by the node"
Sam Hague [Tue, 12 Jan 2016 19:53:29 +0000 (19:53 +0000)]
Merge "Unit test file for NeutronFloatingIPInterface."
Sam Hague [Tue, 12 Jan 2016 19:52:53 +0000 (19:52 +0000)]
Merge "Bug 4927 - Rules added by MacResolverServices in br-ex are not removed"
raveek [Thu, 7 Jan 2016 05:03:00 +0000 (10:33 +0530)]
Adding changes to use and support connecting tracking. By default SG
will push flows with out conntrack match and action, but user can modify
default-config.xml to enable conntrack.
Patch 2: after fixing the review comments
Patch 3: Fixed the test failure
Change-Id: I71d8fd23d66caad97e406507889ebba38bd80d27
Signed-off-by: raveek <raveek@hp.com>
Sam Hague [Tue, 12 Jan 2016 19:50:08 +0000 (19:50 +0000)]
Merge " Added new feature *odl-ovsdb-openstack-clusteraware*."
Sam Hague [Tue, 12 Jan 2016 19:49:21 +0000 (19:49 +0000)]
Merge "Add support for table offset"
Vishal Thapar [Tue, 12 Jan 2016 19:30:53 +0000 (20:30 +0100)]
Use ClusteredDataTreeListener in hwvtepsb
Change-Id: I41234fd2ece1c618107041888d75dc9cc7a62e16
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Sam Hague [Tue, 12 Jan 2016 16:35:41 +0000 (11:35 -0500)]
Fix npe from getLocalIp
Change-Id: I68336c2aa284bebb4a09d2fa596de91a1ee2d272
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 11 Jan 2016 19:57:15 +0000 (14:57 -0500)]
Add support for table offset
This commit adds a new config parameter table-offset to
allow setting the openflow table base. The default value is 0.
The user can change the value via the config file
netvirt-providers-impl-default-config.xml or by using the restconf
api show below. The value used must be between 1 and 145 - with 145
coming from 255-110 - 110 is the max table in the netvirt pipeline.
The following curl commands can be used to configure the value:
- Get the current value:
curl -u admin:admin http://localhost:8181/restconf/config/netvirt-providers-config:netvirt-providers-config
- Change the value: In this example the value is changed to 1
curl -u admin:admin http://localhost:8181/restconf/config/netvirt-providers-config:netvirt-providers-config -i -H "Content-Type: application/json" --data '{"netvirt-providers-config": {"table-offset": 1}}' -X PUT
If the table-offset is set, then an extra flow is added to the br-ex and br-int
switches to steer packets from table 0 to the first table in the pipeline.
IT tests were all updated to check for the new table-offsets as well as
adding unti-tests. Some IT tests have a little more due to the Yang
pacth that enforces strictre rules on the Yang files and was failing the tests.
Further patches should add config service in netvirt to be a central point
handling all the config updates. SG is also adding a config value that should
be included.
Change-Id: I44b3a442e8050d8f1ef1c5cd9db5c32af2d5ce19
Signed-off-by: Sam Hague <shague@redhat.com>
Stephen Kitt [Tue, 12 Jan 2016 15:20:19 +0000 (16:20 +0100)]
Enable PowerMock instrumentation with JaCoCo
By default PowerMock is incompatible with JaCoCo, even with the older
version of JaCoCo defined by odlparent: the tests run but their
coverage isn't measured. This patch forces offline instrumentation
which allows both PowerMock and JaCoCo to operate (more or less)
properly. There are a number of "class already instrumented" errors
but they don't affect the test results.
This patch also upgrades PowerMock to 1.6.4 (initially in the hope
that it would work with JaCoCo as-is); this requires an upgrade to
Mockito too. I'll drive these changes properly in odlparent and remove
the local overrides when appropriate!
Change-Id: I2ab704f7a28f325ed3bb5a75a6f34ffb6c3b36b3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Mon, 11 Jan 2016 18:46:42 +0000 (10:46 -0800)]
Added cluster aware mdsal utils class to net-virt.
Looks like while code cleanup we removed the MdsalUtils.java from the master branch
and while merging master branch to net-virt-clustering, it got removed as well.
Net-virt-clustering had a modified version of MdsalUtils.java, where put/merge/delete
transactions are only done by the master instances of net-virt. ClusterAwareMdsalUtils
class bring those changes back.
Change-Id: I1d5353572c408e519d7a3cc75356b73436dae147
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Mon, 11 Jan 2016 18:01:40 +0000 (10:01 -0800)]
Explictly cleanup all the bridges managed by the node
Change-Id: I37d608a7bb1096d7291d12a0d50dd482f257542f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Flavio Fernandes [Tue, 12 Jan 2016 01:58:58 +0000 (20:58 -0500)]
Bug 4927 - Rules added by MacResolverServices in br-ex are not removed
This bug can be reproduced by using an external router address
that is not owned by any system in the external neutron subnet.
Made the flow remove call idem-potent and in a common function.
Added missing flow remove calls in the following 2 missing places:
* Entry removal (non periodic and periodic)
* Time period restart
Change-Id: Idf481d3a13c1728bf400f185de296cbada7d920b
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
(cherry picked from commit
b1cf5de78228b23a4c6aae1613df925acfa798c9)
Flavio Fernandes [Fri, 8 Jan 2016 03:57:33 +0000 (22:57 -0500)]
Bug 4331 - External bridge used for gateway mac resolver needs to be dynamic
With this change the GatewayMacResolverService will become resilient to the cases
where nodes get deleted or lose br-ex connectivity after the resolver is kicked
off to periodically track a given ip address.
Also made some minor clean up in NeutronL3Adapter, so that it needs not to
duplicate work for tracking ip in the very first iteration. That duplication
is not necessary as the GatewayMacResolverService is already implemented
with thread executors for the periodic monitoring.
Lastly, this gerrit augments the GatewayMacResolver service to provide
an extra boolean param called refreshExternalNetworkBridgeDpidIfNeeded.
That can be used to control whether dpid used gets updated when mac is
not getting resolved.
Change-Id: I95b9e5a2d5773a6be82221b71000ace2a662e772
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
Sam Hague [Sun, 10 Jan 2016 21:52:50 +0000 (21:52 +0000)]
Merge "Bug 4913 - populate openflow rules for security group on port creation"
Sam Hague [Sun, 10 Jan 2016 21:50:22 +0000 (21:50 +0000)]
Merge "Bug 4912 - NeutronL3Adapter: missing/reordered enabled check"
Sam Hague [Sun, 10 Jan 2016 15:28:06 +0000 (15:28 +0000)]
Merge "Fix UT: call method under test and verify"
Sam Hague [Sun, 10 Jan 2016 13:08:12 +0000 (13:08 +0000)]
Merge "Bug 4881 - failure in netvirt.AbstractEventTest"
Sam Hague [Sun, 10 Jan 2016 13:06:26 +0000 (13:06 +0000)]
Sam Hague [Sun, 10 Jan 2016 13:00:43 +0000 (13:00 +0000)]
Merge "Add netvirt and hwgw features to main ovsdb/features."
Sam Hague [Sun, 10 Jan 2016 12:59:59 +0000 (12:59 +0000)]
Merge "QoS Schema - fix type of QoS type"