ovsdb.git
7 years agoMerge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Thanh Ha [Wed, 13 Jul 2016 16:49:49 +0000 (16:49 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"

7 years agoFixed check-style error caused by odl parents check-style patch 83/41683/1
Anil Vishnoi [Mon, 11 Jul 2016 22:42:55 +0000 (15:42 -0700)]
Fixed check-style error caused by odl parents check-style patch

Odl parent merged following patch to enable check-style for
generic exception:
https://git.opendaylight.org/gerrit/#/c/41304/

That broke OVSDB because OVSDB project has check-style enabled locally

Change-Id: I2c1a8b162fb79e033b4c833f1f12cb402477cb0e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoUpgrade ietf-{inet,yang}-types to 2013-07-15 20/40820/2
Lorand Jakab [Thu, 23 Jun 2016 23:07:50 +0000 (18:07 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15

Change-Id: I2a8143ec58e9c2b174fe532d7d65e8f198f3ea78
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
7 years agoMerge "Fix potential future problems re. hidden fields"
Anil Vishnoi [Fri, 8 Jul 2016 03:55:22 +0000 (03:55 +0000)]
Merge "Fix potential future problems re. hidden fields"

7 years agoFix potential future problems re. hidden fields 11/41311/2
Michael Vorburger [Mon, 4 Jul 2016 22:49:50 +0000 (00:49 +0200)]
Fix potential future problems re. hidden fields

None of these changes actually really change code semantics, it does
what it does today, but is hopefully clearer.

Found by Checkstyle.

Change-Id: Ie8a231a9d203ed911c0ea3d9f41eec225af6f270
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoCheckstyle clean-up src/test/java of southbound-impl 66/40966/5
Michael Vorburger [Tue, 28 Jun 2016 20:58:30 +0000 (22:58 +0200)]
Checkstyle clean-up src/test/java of southbound-impl

Change-Id: I4646877449a09d85779d35e85ce565a620818435
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "BUG 6130 - process only qos and queue creates and updates"
Anil Vishnoi [Fri, 8 Jul 2016 02:16:40 +0000 (02:16 +0000)]
Merge "BUG 6130 - process only qos and queue creates and updates"

7 years agoBUG 6130 - process only qos and queue creates and updates 91/41091/2
Eric Multanen [Thu, 30 Jun 2016 08:04:51 +0000 (01:04 -0700)]
BUG 6130 - process only qos and queue creates and updates

Fixes issue where all qos or queue entries - including ones
that had not changed - for an ovsdb node were getting ovsdb
transactions sent to the ovs node when a qos or queue was
created or updated.

This patch only creates ovsdb transactions for qos or queue
entries that have been created or updated.

Change-Id: Ie9eef13deae768dbdc16d6ab2a35e353c1aba6bf
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoFix Sonar (soon Checkstyle) constant name 98/41298/2
Michael Vorburger [Mon, 4 Jul 2016 18:31:30 +0000 (20:31 +0200)]
Fix Sonar (soon Checkstyle) constant name

Change-Id: Ida7d2484956e88883f9da4cc59154d527e637bfd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Fix Sonar (soon Checkstyle) TrailingComment"
Anil Vishnoi [Wed, 6 Jul 2016 08:20:24 +0000 (08:20 +0000)]
Merge "Fix Sonar (soon Checkstyle) TrailingComment"

7 years agoFix Checkstyle "Utility classes should not have (visible) constructor" 10/41310/1
Michael Vorburger [Mon, 4 Jul 2016 22:45:15 +0000 (00:45 +0200)]
Fix Checkstyle "Utility classes should not have (visible) constructor"

Change-Id: Ide9e8ee132cf2c6124dba049966a77a3a385a080
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoFix Sonar (soon Checkstyle) TrailingComment 96/41296/1
Michael Vorburger [Mon, 4 Jul 2016 17:32:29 +0000 (19:32 +0200)]
Fix Sonar (soon Checkstyle) TrailingComment

Change-Id: Ic961c8ae27060cb7ba034ca7a4ffff668d982e58
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Fix ALOTOF Checkstyle violation, and switch over to enforcement."
Sam Hague [Sat, 2 Jul 2016 20:14:22 +0000 (20:14 +0000)]
Merge "Fix ALOTOF Checkstyle violation, and switch over to enforcement."

7 years agoMerge "Schema changes for 1.7.0 support"
Sam Hague [Sat, 2 Jul 2016 19:54:10 +0000 (19:54 +0000)]
Merge "Schema changes for 1.7.0 support"

7 years agoMerge "hwvtep yang changes for 1.4.1"
Sam Hague [Sat, 2 Jul 2016 19:53:30 +0000 (19:53 +0000)]
Merge "hwvtep yang changes for 1.4.1"

7 years agoMerge "Bug 5938 - Improve the logging."
Sam Hague [Sat, 2 Jul 2016 19:43:36 +0000 (19:43 +0000)]
Merge "Bug 5938 - Improve the logging."

7 years agoFix ALOTOF Checkstyle violation, and switch over to enforcement. 67/40967/5
Michael Vorburger [Tue, 28 Jun 2016 21:25:09 +0000 (23:25 +0200)]
Fix ALOTOF Checkstyle violation, and switch over to enforcement.

They're all minor formatting kind of things.

Change-Id: I91a391c2b4d6fd7562872bf0d8349e0531991a82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Checkstyle clean-up invalid license headers containing Authors."
Sam Hague [Sat, 2 Jul 2016 19:20:48 +0000 (19:20 +0000)]
Merge "Checkstyle clean-up invalid license headers containing Authors."

7 years agoMerge "Bug 5938 - Updated the logging."
Sam Hague [Sat, 2 Jul 2016 19:16:58 +0000 (19:16 +0000)]
Merge "Bug 5938 - Updated the logging."

7 years agoMerge "Bug:5938 Updated Log messages."
Sam Hague [Sat, 2 Jul 2016 19:14:22 +0000 (19:14 +0000)]
Merge "Bug:5938 Updated Log messages."

7 years agoBug 5938 - Improve the logging. 36/41236/2
ananthip [Mon, 27 Jun 2016 12:54:58 +0000 (08:54 -0400)]
Bug 5938 - Improve the logging.

Change-Id: Ic13692f262ec783982c6ae2e259bb44dbe647ffa
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoBug 5938 - Updated the logging. 23/41223/1
ananthip [Wed, 29 Jun 2016 14:10:39 +0000 (10:10 -0400)]
Bug 5938 - Updated the logging.

Change-Id: I933a9f75ce87a4769c22f194eb06d39e1f669477
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoSchema changes for 1.7.0 support 26/40926/3
Vishal Thapar [Tue, 28 Jun 2016 11:21:28 +0000 (16:51 +0530)]
Schema changes for 1.7.0 support

This adds the following:
1. ACL.java for ACL table
2. ACLEntry.java for ACL_entries table
3. Reference to ACL table entry in LogicalRouter
4. Reference to ACL table entry in PhysicalPort
5. Add tunnel-key to PhysicalLocator
6. Add other-config to multiple classes as per 1.5.1 an 1.7.0
7. Add replication_mode to LogicalSwitch

Change-Id: I0af839a9792890d5a6b753b8e26fb3ffcc1678de
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoCheckstyle clean-up invalid license headers containing Authors. 61/40961/5
Michael Vorburger [Tue, 28 Jun 2016 18:56:42 +0000 (20:56 +0200)]
Checkstyle clean-up invalid license headers containing Authors.

incl. some automated clean-up actions which I make Eclipse do autom.

This is part of a set of changes that are required in order to be able
to enable Checkstyle enforcement for src/test/java as well globally, see
https://git.opendaylight.org/gerrit/#/c/40957/

Change-Id: I37d19d5826135006ff94608ce703d5cc054333fb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agohwvtep yang changes for 1.4.1 71/40771/3
Vishal Thapar [Thu, 23 Jun 2016 13:20:14 +0000 (18:50 +0530)]
hwvtep yang changes for 1.4.1

This adds following to yang:

1. Logical_Router
2. Arp_sources local and remote
3. ACL and ACL Entries
4. Logical_Binding_Stats
5. Fault status for switch and port

Change-Id: If5089785aceb035101b630ce009bb6523c37b3b8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoAdd list of contributors 90/40990/1
Stephen Kitt [Wed, 29 Jun 2016 07:47:21 +0000 (09:47 +0200)]
Add list of contributors

This was produced by looking at all the git sign-offs, and matching
where necessary with Gerrit identities.

Change-Id: Ifc3abee21dad9a13415c8902aadffd043603ae00
Signed-off-by: Stephen Kitt <skitt@redhat.com>
7 years agoMerge "Bug 4790 - 'ifindex' column from Interface table on OVS"
Anil Vishnoi [Wed, 29 Jun 2016 06:02:45 +0000 (06:02 +0000)]
Merge "Bug 4790 - 'ifindex' column from Interface table on OVS"

7 years agoUse logger instead of System.out.println (found by Checkstyle) 70/40970/1
Michael Vorburger [Tue, 28 Jun 2016 21:33:46 +0000 (23:33 +0200)]
Use logger instead of System.out.println (found by Checkstyle)

Change-Id: I2aa3f02cea16ba48c51bbeccc4b7de2cae58d461
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBug 4790 - 'ifindex' column from Interface table on OVS 01/39801/10
Rashmi Pujar [Thu, 2 Jun 2016 21:36:56 +0000 (17:36 -0400)]
Bug 4790 - 'ifindex' column from Interface table on OVS

Change-Id: I66f7a15a36a7c877cdeb3ca6accf761b16a7a962
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
7 years agoBug:5938 Updated Log messages. 07/40907/1
ananthip [Wed, 22 Jun 2016 16:14:57 +0000 (12:14 -0400)]
Bug:5938 Updated Log messages.

Change-Id: I58da3c0d26f03faa8facdfebb06eca17d4b37246
Signed-off-by: ananthip <ananthip@hcl.com>
7 years agoBUG 5746 - Ovasb QoS and Queue enhancements part 2 30/40830/1
Eric Multanen [Sat, 25 Jun 2016 05:42:30 +0000 (22:42 -0700)]
BUG 5746 - Ovasb QoS and Queue enhancements part 2

Fixes 3 integration test errors.  2 errors due to bug
in the new Queue code.  The other error was in the integration
test code as a result of the model changes.

Also, added support to set the qos-id and queue-id based
on the presence of the 'opendaylight-qos-id' and
'opendaylight-qeueue-id' external-id values.  These
external-id keys were placed in the qos and queue
tables respectively by the original qos and queue
plugin support. The corresponding value was the
id value for the row entry used by the md-sal.

The updated qos and queue model enhancement code
use the 'opendaylight-iid' key and stores the
corresponding instance identifier for the qos or
queue object.  Support for using the previous
external-id keys provides backward compatiblity
when connecting to OVS hosts which contain qos
and queue entries created using the older plugin.

Change-Id: Ifd97b1f41a497cadd1060365122cae1fd7cbfe84
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
7 years agoMerge "Bug 5721 - br-int not created in clustered setup"
Anil Vishnoi [Thu, 23 Jun 2016 23:23:44 +0000 (23:23 +0000)]
Merge "Bug 5721 - br-int not created in clustered setup"

7 years agoMerge "Fixing sonar bug 1)Add a private constructor to hide the implicit public one...
Anil Vishnoi [Thu, 23 Jun 2016 23:05:06 +0000 (23:05 +0000)]
Merge "Fixing sonar bug 1)Add a private constructor to hide the implicit public one. 2)removing the block of commented-out lines as part of code cleanup"

7 years agoBug 5721 - br-int not created in clustered setup 41/40541/2
vinh.nguyen [Tue, 17 May 2016 17:47:49 +0000 (10:47 -0700)]
Bug 5721 - br-int not created in clustered setup

When the OVS node is hard-reset in PASSIVE mode, it takes
up to 3 minutes for the controler to detect the connection is gone.
During this time, new connection request from the same node arrives.
The latter connection request causes
CandidateAlreadyRegisteredException because the former connection
has not been cleaned up properly.

This patch fixes the issue by making sure that all stale connections
from the same node are properly cleaned up before processing new
connection request. When a new connection request arrives
all connections from same node are pinged. The pings cause
the stale netty connections to close due to IOException.
Those have not been closed after a timeout will be closed
programmatically. New connection request is then processed after
all stale connections are cleaned up in the OvsdbConnectionService

Change-Id: I8bbce8a81b9850704278220b4b75d2ab21cb34c6
Signed-off-by: vinh.nguyen <vinh.nguyen@hcl.com>
7 years agoFixing sonar bug 92/40792/1
Praveen Mala [Thu, 23 Jun 2016 22:10:04 +0000 (18:10 -0400)]
Fixing sonar bug
1)Add a private constructor to hide the implicit public one.
2)removing the block of commented-out lines as part of code cleanup

Change-Id: Ib9d5f550d6168bff5d02c865568821af1be88ffc
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
7 years agoovsdb enable checkstyle on error 68/40768/3
Sam Hague [Wed, 22 Jun 2016 21:18:15 +0000 (17:18 -0400)]
ovsdb enable checkstyle on error

Change-Id: Ie3105f3cac8b0db4762c68df36c650f6cefdca00
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge changes from topic 'blueprint'
Anil Vishnoi [Thu, 23 Jun 2016 06:01:27 +0000 (06:01 +0000)]
Merge changes from topic 'blueprint'

* changes:
  Add blueprint wiring to library
  Add blueprint wiring for southbound
  Add blueprint wiring for hwvtepsouthbound

7 years agoAdd blueprint wiring to library 37/40637/5
Alexis de Talhouët [Tue, 21 Jun 2016 21:46:12 +0000 (17:46 -0400)]
Add blueprint wiring to library

Change-Id: Ieb404cc0ada8fef56f9ce63ec04ffbb40029a47e
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoAdd blueprint wiring for southbound 39/40639/4
Alexis de Talhouët [Tue, 21 Jun 2016 22:39:49 +0000 (18:39 -0400)]
Add blueprint wiring for southbound

Change-Id: I6e5cea49f584cc93a2842533287e950eadfabb40
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoBUG 5945: Tunnel updates through Genius not working 97/40697/1
Vishal Thapar [Wed, 22 Jun 2016 12:37:46 +0000 (18:07 +0530)]
BUG 5945: Tunnel updates through Genius not working

When creating tunnels through Genius, bridge information is present only
in operational and not in config. So any data chages that come in will not
have any augmentation. This was fixed as part of BUG 4644 but changes for
DataTreeListener refactored the code and this scenario was missed.

Change-Id: Ie4982d887e555a40984a5f4ff1211b785fe5ee6d
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
7 years agoMerge "BUG 5746 - Ovsdb QoS and Queue model enhancements"
Anil Vishnoi [Wed, 22 Jun 2016 00:46:58 +0000 (00:46 +0000)]
Merge "BUG 5746 - Ovsdb QoS and Queue model enhancements"

7 years agoAdd blueprint wiring for hwvtepsouthbound 38/40638/2
Alexis de Talhouët [Tue, 21 Jun 2016 22:03:17 +0000 (18:03 -0400)]
Add blueprint wiring for hwvtepsouthbound

Change-Id: I973476d85f890f701b2b668dcebef61372e7aa58
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
7 years agoRemove verbose logging in TransactUtils 57/40557/1
Sam Hague [Mon, 20 Jun 2016 18:24:58 +0000 (14:24 -0400)]
Remove verbose logging in TransactUtils

The two logs removed are repeated constantly for every transaction and don't add much value since this is a utility.

Change-Id: I8d66c9b87e42ad93f3f91da1a5a76e9cb70e12f6
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoMerge "Bug:5938 Added log message for OvsdbDataTreeChangeListener."
Sam Hague [Mon, 20 Jun 2016 10:21:39 +0000 (10:21 +0000)]
Merge "Bug:5938 Added log message for OvsdbDataTreeChangeListener."

7 years agoMerge ".gitignore .factorypath created by m2e-apt"
Anil Vishnoi [Mon, 20 Jun 2016 07:00:58 +0000 (07:00 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"

7 years agoMerge "Patch set 2 ------------ 1. Break this up into 2 patches, as Sam suggested...
Anil Vishnoi [Mon, 20 Jun 2016 06:51:12 +0000 (06:51 +0000)]
Merge "Patch set 2 ------------ 1. Break this up into 2 patches, as Sam suggested. This patch will add new schema dependencies and fix ovsdb code to handle ovsdb node when both schemas are present."

7 years agoBug:5938 Added log message for OvsdbDataTreeChangeListener. 87/40487/2
ananthip [Thu, 16 Jun 2016 17:10:33 +0000 (13:10 -0400)]
Bug:5938 Added log message for OvsdbDataTreeChangeListener.

Change-Id: I4ae256f2564055bac0d79abb275d1f3f371c128f
Signed-off-by: ananthip <ananthip@hcl.com>
7 years ago.gitignore .factorypath created by m2e-apt 22/40522/1
Michael Vorburger [Sun, 19 Jun 2016 15:58:46 +0000 (17:58 +0200)]
.gitignore .factorypath created by m2e-apt

https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.

Change-Id: I34a8edc9a0a4cd65f5e273014a232c0cba106c51
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoMerge "Support for IT Ping feature"
Anil Vishnoi [Fri, 17 Jun 2016 23:05:16 +0000 (23:05 +0000)]
Merge "Support for IT Ping feature"

7 years agoPatch set 2 61/40261/2
Victor Pickard [Mon, 13 Jun 2016 22:51:17 +0000 (18:51 -0400)]
Patch set 2
------------
1. Break this up into 2 patches, as Sam
suggested. This patch will add new schema
dependencies and fix ovsdb code to handle
ovsdb node when both schemas are present.

2. Only create transaction handlers for
Open-vSwitch database.

3. Revert change to hwvtepsouthbound-it/pom.xml,
so that hwvtepIT test are skipped, until
docker image is published that contains
both Open_vSwitch and hardware_vtep schemas.
See TODO itmes below.

4. Next patch will address items in TODO below.

When the ovsdb node has other schemas, such as
hardware_vtep, the code was creating transaction
handlers for hardware_vtep database, which the ovsdb
code cannot handle.

With this change, all IT tests pass when running
docker image loaded with both Open_vSwitch schema
and hardware_vtep schema.

Additionally, all IT tests pass when running docker
image loaded with only Open_vSwitch schema.

TODO
----
1. Publish docker image that has support for both schemas.

2. Replace assumes in hardware vtep IT to asserts if/when
hardware_vtep schema is not present.

3. Enable HwvtepSouthboundIT tests, in hwvtepsouthbound-it/pom.xml.

4. Sam suggested additional testing to ensure that both ovsdb southbound
and hwvtep southbound can connect at same time to ovsdb node running
both schemas.

5. Confirm deployment model when both schemas are present on
ovsdb node.

Patch set 1
-----------
Add hardwarevtep schema to pom and features.xml.

With these changes, and my docker image with both
ovsschema and hardwarevtep schema(to be published),
library/it tests pass, as well as hwvtepsouthbound-it
tests pass.

Change-Id: I94d24d524dcafaa38c69d129190ea29140efd5c9
Signed-off-by: Victor Pickard <vpickard@redhat.com>
7 years agoMake SchemaVersionMismatchException logging consistent 54/40454/2
Sam Hague [Thu, 16 Jun 2016 14:37:23 +0000 (10:37 -0400)]
Make SchemaVersionMismatchException logging consistent

The logging for the exception was not consistent: The log level varied,
the output varied and the logging of the stack trace varied.

Now a single utility method is called for the log. The level is set
to debug, same text, and the exception message rather than the trace
is logged. In all cases these are not errors because it is expected
that different schema versions may not have support for some columns.

Change-Id: I29ef9d30e2044483da1dfd9dc573d13715d222f1
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoSupport for IT Ping feature 59/40359/2
Josh [Wed, 15 Jun 2016 09:10:37 +0000 (11:10 +0200)]
Support for IT Ping feature

Change-Id: I12860f66d0abcd521bd07756232ede9ccdebfc60
Signed-off-by: Josh <jhershbe@redhat.com>
7 years agoBUG 5746 - Ovsdb QoS and Queue model enhancements 72/36772/11
Eric Multanen [Fri, 25 Mar 2016 16:06:29 +0000 (09:06 -0700)]
BUG 5746 - Ovsdb QoS and Queue model enhancements

Update the QoS and Queue model to improve managability
of QoS and Queue tables via MD-SAL config model.

Adds code to update operational md-sal using updated
model.

Adds code to allow creation of queue and qos in same
transaction and assign queue to the qos row via
named-uuid.

QoS and Queue entries can be managed by ODL ID
values instead of needing to know the operational
UUID value.

Adds code to support assignment of QoS to port
by MD-SAL QoS ID.

Adds a QoS entry list to the termination point
model so updates and delete operations can be made
directly on the list instead of updating the
termination point.

Support for ingress policing rate and burst configuration
for interfaces is added.

Includes updated Postman examples.

v2 - clarify some logic based on comment feedback
     add additional qos types: linux-sfq, linux-codel
       linux-fq_codel, egress-policer
v3 - rebase, whitespace
v4 - address review comments
v5 - Changes to address review comments:
     Use a queue-ref (instance identifier instead
       of queue-id in the qos queue list.
     Use a qos-ref (instance identifier instead
       of qos-id in the port qos list.
     Use a key of '1' for the single item port qos list.
     Add instance identifer to the external-ids column
       of the qos and queue tables instead of just id
       value.  Use key of 'opendaylight-iid'.
     Updated the postman collection to account for changes
     Clarified the  comment and code of method
       bytesToHexString in TransactUtils.java.

Still to do:
- update unit tests
- update integration tests

Change-Id: I71ac462afe5a881c621fad9a3c5603e1aab8d021
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
7 years agoremoved unused imports in HwvtepSouthboundUtil.java, 'org.opendaylight.controller... 21/40321/1
Patrick Roanhouse [Tue, 14 Jun 2016 18:43:40 +0000 (14:43 -0400)]
removed unused imports in HwvtepSouthboundUtil.java,  'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' and org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepLogicalSwitchAttributes'.

Change-Id: Ia3afae16031f1d43e5c4ccfc54913d636cf4facb
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
7 years agoMerge "Bug 5976 - Thread leak when connecting/disconnecting ovs nodes"
Sam Hague [Tue, 14 Jun 2016 14:35:32 +0000 (14:35 +0000)]
Merge "Bug 5976 - Thread leak when connecting/disconnecting ovs nodes"

7 years agoMerge "Remove OvsdbDataChangeListener"
Sam Hague [Tue, 14 Jun 2016 12:05:17 +0000 (12:05 +0000)]
Merge "Remove OvsdbDataChangeListener"

7 years agoAdd IT for port del dtcl 73/40273/1
Sam Hague [Mon, 13 Jun 2016 23:30:31 +0000 (19:30 -0400)]
Add IT for port del dtcl

Change-Id: I2db8c5a6f8d56ffe9a6609b79ffe34dcbabba9c1
Signed-off-by: Sam Hague <shague@redhat.com>
7 years agoBug 5992 - GBP + SFC integration is broken 88/39988/3
Anil Vishnoi [Wed, 8 Jun 2016 02:15:29 +0000 (19:15 -0700)]
Bug 5992 - GBP + SFC integration is broken

When Bridge and termination points are created together, it generates two data tree change
notifications. Termination point changes are part of second data change notification,
but that does not contain bridge and node augmentation, because there was no change
in those augmentations, and because of that plugin was not able to find the connection
instance for the ovsdb node. As a last resort plugin tries to find it based on the
rootNode iid from operational data store, but because in this scenario rootNode is
bridge node, and bridge creation request was process just before the second data
change notification, operational data was not updated with the bridge node details
by the time plugin checks in the operational data store. So final attempt to find
the connection instance also fails. To fix this and also optimize it a bit, this
patch added an additional attempt to get the connection instances using the
managed-by ref node of the bridge node and check for that in the operational data
store. That node is the connection node, so it must be there if device is connected
to the controller, otherwise configuration should fail, which is expected outcome.

Change-Id: I743269b5ca2f36f761bbb4a118a2837631e1847d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
7 years agoBug 5976 - Thread leak when connecting/disconnecting ovs nodes 17/39917/5
Dileep [Mon, 6 Jun 2016 16:21:12 +0000 (09:21 -0700)]
Bug 5976 - Thread leak when connecting/disconnecting ovs nodes

ExecutorService in OvsdbClientImpl is not shutdown properly
When the del-manager is called along with closing the channel,
the executor service is shutdown.

Set the threadfactory to distinguish the Ovsdbclient threadpool.

Change-Id: I13473ca40456ba78162591ea23cfd907d2f5b34f
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
7 years agoRemove OvsdbDataChangeListener 23/40223/1
Stephen Kitt [Mon, 13 Jun 2016 10:09:18 +0000 (12:09 +0200)]
Remove OvsdbDataChangeListener

This has been obsoleted by OvsdbDataTreeChangeListener.

Change-Id: I741584d94fb6bae7c6a456cdd812d093c8f9974b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoRemoved unused import 'org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService'."... 66/40066/1
Patrick Roanhouse [Wed, 8 Jun 2016 16:59:00 +0000 (12:59 -0400)]
Removed unused import 'org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService'." from HwvtepSouthboundProvider.java

Change-Id: I0542e44fbc94b9dca691f4aa4e5fc01c9f1dc497
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
8 years agoReplace wildcard imports 66/39966/1
David Suarez [Tue, 7 Jun 2016 10:50:19 +0000 (12:50 +0200)]
Replace wildcard imports

Change-Id: Icb2884d8d3785cbe551dc0fbd8a71b1c3446782e
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
8 years agoMerge "Add ability to create VxLAN-GPE tunnels"
Anil Vishnoi [Fri, 3 Jun 2016 08:06:58 +0000 (08:06 +0000)]
Merge "Add ability to create VxLAN-GPE tunnels"

8 years agoBug 5944 - Looping INFO messages for UNSUPPORTED AutoAttach OVS 70/39770/4
Rashmi Pujar [Thu, 2 Jun 2016 14:26:19 +0000 (10:26 -0400)]
Bug 5944 - Looping INFO messages for UNSUPPORTED AutoAttach OVS

Change-Id: I93704b2a0997da85a3cf2373cbb0d5c77b313db6
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoAdd ability to create VxLAN-GPE tunnels 56/39656/2
David Suarez [Tue, 31 May 2016 15:05:06 +0000 (17:05 +0200)]
Add ability to create VxLAN-GPE tunnels

Change-Id: Ic352bebeed0a7cbfdbdc92b49ac6fcf0db2b615f
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
8 years agoSystem property awareness in DockerOvs 61/39461/5
Josh [Thu, 26 May 2016 09:14:30 +0000 (11:14 +0200)]
System property awareness in DockerOvs

Change-Id: If039cd49c18f9ba55181918c66fce1eaf973df82
Signed-off-by: Josh <jhershbe@redhat.com>
8 years agoMerge "removed unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns...
Anil Vishnoi [Sat, 28 May 2016 22:34:33 +0000 (22:34 +0000)]
Merge "removed unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns.yang.ietf.inet.types.rev100924.Ipv4Address' in HwvtepSouthboundMapper.java"

8 years agoremoved unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns.yang... 49/39549/2
Patrick Roanhouse [Fri, 27 May 2016 22:40:26 +0000 (18:40 -0400)]
removed unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns.yang.ietf.inet.types.rev100924.Ipv4Address' in HwvtepSouthboundMapper.java

Change-Id: I5e8ec077386e0cfc63877f01c218c52f23e73b29
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
8 years agoBUG 5885 - OVSDB plugin failure to update passive ovsdb nodes 48/39548/3
Anil Vishnoi [Fri, 27 May 2016 23:28:07 +0000 (16:28 -0700)]
BUG 5885 - OVSDB plugin failure to update passive ovsdb nodes

Updates the ovsdb southbound so that configuration to ovsdb
nodes which have connected to the plugin passively can be
updated (e.g. such as qos or queue entries) without requiring
connection-info to be supplied in the configuration.
Similar to what already works when adding bridges or
termination points to passively connected ovsdb nodes.

The onDataChanged() method executes the following
sequence of operations on changes to the Ovsdb data tree:
- connect(changes)
- updateConnections(changes)
- updateData(changes)
- disconnect(changes)

When an OVSDB node has connected passively, or more
generally, when the changes to the OVSDB node do not
include 'connection-info', it is not necessary to
attempt to execute connection related operations for
the specified host.  This patch  checks for the absence
of the connection-info and skips trying to connect or
update a connection in the connect() and updateConnections()
methods.

v2 - add in data tree change patch from master branch
     now that data tree change listener is merged.

Change-Id: I8238711076a74cfa06422e5cacb127ba95fd23b7
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoBUG 5506: OVSDB server doesn't close connection after peer is power down 11/39511/3
Vishal Thapar [Thu, 26 May 2016 13:50:22 +0000 (19:20 +0530)]
BUG 5506: OVSDB server doesn't close connection after peer is power down

https://git.opendaylight.org/gerrit/#/c/35436/ added code to detect when a
peer goes down without sending a FIN. However, it only did it for switch
initiated connection. In case of ODL initiated connection we are unable to
detect peer being down and reconciliation is never triggered.

Change-Id: I62d0b2cef75b889fc75b43fe51be5156f921fcfe
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "BUG 5479: HWVtep Southbound doesn't retry connection"
Sam Hague [Fri, 27 May 2016 16:14:55 +0000 (16:14 +0000)]
Merge "BUG 5479: HWVtep Southbound doesn't retry connection"

8 years agoBUG 5479: HWVtep Southbound doesn't retry connection 13/39513/2
Vishal Thapar [Wed, 25 May 2016 04:17:51 +0000 (09:47 +0530)]
BUG 5479: HWVtep Southbound doesn't retry connection

This fix is hwvtep counterpart of
https://git.opendaylight.org/gerrit/#/c/36028/ which fixes BUG 5221.

Wiki:
https://wiki.opendaylight.org/view/OVSDB_Integration:OVSDB_SB_Reconciliation

Change-Id: I497dbfa339de157d12afe94ce5c36b35ffda5dd9
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit 9d80362e33fb2d6a2c0dc4b7994c976e46e8799f)

8 years agoBUG 5769 04/39504/2
Jamo Luhrsen [Thu, 19 May 2016 05:49:54 +0000 (22:49 -0700)]
BUG 5769

bailing on connection if get databases is not returning anything
and then using disconnected() which seems to have the effect of
letting our threadpool service more connections.  The condition
before would block any new (and good) connections if we initiated
just 10 incorrect TCP connections toward port 6640

Change-Id: I5a59762049a0460cc39ebbfce0c93d002ec24d68
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoFix for verification build failures 23/39523/1
Vishal Thapar [Fri, 27 May 2016 11:48:59 +0000 (17:18 +0530)]
Fix for verification build failures

Change-Id: Ib1b6a920042bb977ca952320cf50d53af7288e75
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
8 years agoMerge "Infra for running ovs dockers"
Anil Vishnoi [Mon, 23 May 2016 22:16:20 +0000 (22:16 +0000)]
Merge "Infra for running ovs dockers"

8 years agoMerge "Patch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken .This patch...
Anil Vishnoi [Sun, 22 May 2016 05:07:39 +0000 (05:07 +0000)]
Merge "Patch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken .This patch fixes the breakage"

8 years agoMinor sonar listed bug fixed for coding style in HwvtepConnectionManager.java 92/38692/3
Patrick Roanhouse [Wed, 11 May 2016 21:46:40 +0000 (17:46 -0400)]
Minor sonar listed bug fixed for coding style in HwvtepConnectionManager.java

Change-Id: I28bae105be378010ac109c524977705afb6e4aa0
Signed-off-by: Patrick Roanhouse <patrick.m.roanhouse@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoPatch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken 19/39219/1
Anil Vishnoi [Sun, 22 May 2016 01:15:19 +0000 (18:15 -0700)]
Patch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken
.This patch fixes the breakage

Change-Id: I78034a55facd10f5921000e86bf451a90faa0691
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
8 years agoMerge "Remove logging entire exception to avoid a noisy stack trace"
Sam Hague [Sun, 22 May 2016 00:35:02 +0000 (00:35 +0000)]
Merge "Remove logging entire exception to avoid a noisy stack trace"

8 years agoRemove logging entire exception to avoid a noisy stack trace 60/39060/8
Rashmi Pujar [Wed, 18 May 2016 18:21:52 +0000 (14:21 -0400)]
Remove logging entire exception to avoid a noisy stack trace

Change-Id: I8b8efe61742505b6b89b66684e482b9d4e9e550b
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
8 years agoBUG-5177 - bridge not created if it's configured northbound while ovs node is disconn... 58/37358/5
vinh.nguyen [Fri, 8 Apr 2016 19:14:46 +0000 (12:14 -0700)]
BUG-5177 - bridge not created if it's configured northbound while ovs node is disconnected

Add bridge configuration reconciliation logic to southbound plugin.
When ovsdb southbound plugin receives connection request from an
OVS node, the plugin pushes all existing bridge configurations
for that node in the config data store to the node.
This is the solution for reconciliation scenarios #4 and #6 in:
https://wiki.opendaylight.org/view/OVSDB_Integration:OVSDB_SB_Reconciliation

Change-Id: I436cd15e2ff3231551fec4d4175983cec7bc2186
Signed-off-by: vinh.nguyen <vinh.nguyen@hcl.com>
8 years agoInfra for running ovs dockers 31/38931/6
Josh [Mon, 16 May 2016 13:43:15 +0000 (15:43 +0200)]
Infra for running ovs dockers

Added a class called DockerOvs.
See documentation in the class

Added component:
<groupId>com.esotericsoftware.yamlbeans</groupId>
<artifactId>yamlbeans</artifactId>
this is used to parse the docker-compose files to
extract the port mappings

Change-Id: I978a9a6bc6296f7d8e1246c37c3895b2f36c5a6d
Signed-off-by: Josh <jhershbe@redhat.com>
8 years agoGet bridge details for delete when using dataTree 69/39069/1
Sam Hague [Wed, 18 May 2016 20:57:46 +0000 (16:57 -0400)]
Get bridge details for delete when using dataTree

Change-Id: Id9f74a8cffb058142daa303f70d7fe570d493bef
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoRemove redudnant calls for bridge updates 68/39068/1
Sam Hague [Wed, 18 May 2016 20:57:06 +0000 (16:57 -0400)]
Remove redudnant calls for bridge updates

Change-Id: I34ed01cbdf870351707bb6daf990a5fc88609027
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Bug 5876 - OVSDB library: Retry when SSL handshake doesn't begin yet"
Sam Hague [Mon, 16 May 2016 22:02:42 +0000 (22:02 +0000)]
Merge "Bug 5876 - OVSDB library: Retry when SSL handshake doesn't begin yet"

8 years agoBug 5876 - OVSDB library: Retry when SSL handshake doesn't begin yet 47/38347/9
Hsin-Yi Shen [Wed, 13 Apr 2016 20:11:07 +0000 (13:11 -0700)]
Bug 5876 - OVSDB library: Retry when SSL handshake doesn't begin yet

Sometimes the listener get notified before SSL handshake is done.
The root cause is we don't handle the handshake state "NOT_HANDSHAKING" properly.
"NOT_HANDSHAKING" could mean handshake process is finished or doesn't begin yet.
We should handle latter case(handshake process doesn't begin yet) and retry before
 notifying lsteners.

Change-Id: Ibdd82beb2aa876313113211951a4347cc601331a
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
8 years agoMerge "Add MdsalUtilsAsync to make transactions asyncrhonous"
Sam Hague [Fri, 13 May 2016 21:21:22 +0000 (21:21 +0000)]
Merge "Add MdsalUtilsAsync to make transactions asyncrhonous"

8 years agoRemove missed netvirt files 89/38889/1
Sam Hague [Fri, 13 May 2016 19:22:06 +0000 (15:22 -0400)]
Remove missed netvirt files

Change-Id: I1bc0e9767be9c74aaaa1c7c1f042d185419dd062
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoAdd MdsalUtilsAsync to make transactions asyncrhonous 32/37832/8
Alexis de Talhouët [Tue, 19 Apr 2016 16:52:45 +0000 (12:52 -0400)]
Add MdsalUtilsAsync to make transactions asyncrhonous

Change-Id: I8bb5d82f019ad62beb4b3c944640070227f38632
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
8 years agoRemove the remaining netvirt code from ovsdb 22/38522/1
Sam Hague [Fri, 6 May 2016 17:21:02 +0000 (13:21 -0400)]
Remove the remaining netvirt code from ovsdb

Change-Id: Icaf75e219380c3b17c4479d64c49ee6862c2a9c6
Signed-off-by: Sam Hague <shague@redhat.com>
8 years agoMerge "Use ${project.version} for internal dependencies"
Sam Hague [Fri, 6 May 2016 13:25:43 +0000 (13:25 +0000)]
Merge "Use ${project.version} for internal dependencies"

8 years agoFix Puppet install in OVSDB Vagrantfile 74/38374/2
Daniel Farrell [Wed, 4 May 2016 14:45:25 +0000 (10:45 -0400)]
Fix Puppet install in OVSDB Vagrantfile

The Vagrantfile's initial shell provisioner call attempted to
install Puppet via an old method that now fails. The repos
for installing Puppet on Ubuntu seem to have changed.

http://pastebin.com/6A4eBzM2

Puppet is now included in the default repos, so a simple apt-get
install works as expected.

Change-Id: Id5bb8e4d9d966ac69397fc7ab877bc5495e2dce5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
8 years agoUse ${project.version} for internal dependencies 73/38373/1
Stephen Kitt [Wed, 4 May 2016 14:47:20 +0000 (16:47 +0200)]
Use ${project.version} for internal dependencies

Correct the version on southbound-impl's southbound-utils
dependency...

Change-Id: I12c9aaa94670031a0b3a323facfd1dafecc90317
Signed-off-by: Stephen Kitt <skitt@redhat.com>
8 years agoMove TpId allocation out of loop 67/38367/1
Robert Varga [Wed, 4 May 2016 12:26:02 +0000 (14:26 +0200)]
Move TpId allocation out of loop

The TpId being looked up is loop-invariant, hence it makes
sense to allocate it once rather than in a tight loop.

Change-Id: I8242754c61fa56b0779f164b001705fe252fe60e
Signed-off-by: Robert Varga <rovarga@cisco.com>
8 years agoFix Iid for locator-refs in HwvtepTunnelUpdate 57/38357/1
Vishal Thapar [Wed, 4 May 2016 06:53:12 +0000 (12:23 +0530)]
Fix Iid for locator-refs in HwvtepTunnelUpdate

Local and remote locator ref IIDs are off NodeID, not physical switch IID.
The iid for tunnels was generated correctly but locators stored in data
were using incorrect Iid.

Change-Id: Ida585feeb5c1bf419d1123c5ecbe0dbdf99486af
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
8 years agoMerge "Fixed hard-coded port 12345 in TestClient"
Sam Hague [Wed, 4 May 2016 01:33:29 +0000 (01:33 +0000)]
Merge "Fixed hard-coded port 12345 in TestClient"

8 years agoFixed hard-coded port 12345 in TestClient 51/38351/1
Michael Vorburger [Tue, 3 May 2016 23:36:52 +0000 (01:36 +0200)]
Fixed hard-coded port 12345 in TestClient

This avoids java.net.BindException: Address already in use

Change-Id: I15ca5fe4f5e381c40b4bf5eaddcc3ada4ca4d886
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
8 years agoMerge "Use DataTreeChangeListener instead of DataChangeListener"
Sam Hague [Mon, 2 May 2016 21:33:51 +0000 (21:33 +0000)]
Merge "Use DataTreeChangeListener instead of DataChangeListener"

8 years agoMerge "BUG-5737: enable OVSDB Maven site"
Sam Hague [Mon, 2 May 2016 21:33:36 +0000 (21:33 +0000)]
Merge "BUG-5737: enable OVSDB Maven site"

8 years agoBUG5764: Hwvtep tunnel update/delete not reflected correctly 93/38293/1
Vishal Thapar [Wed, 20 Apr 2016 07:44:21 +0000 (13:14 +0530)]
BUG5764: Hwvtep tunnel update/delete not reflected correctly

1. Adds HwvtepTunnelUpdate/Delete command patterns
2. Removes tunnel handling from PhysicalSwitchUpdate
3. Adds PhysicalSwitch and locator information to HwvtepDeviceInfo
4. Reorders Aggregator to take care of dependencies
5. Renames classes to distinguish from ones in transact. This makes easier
to troubleshoot.

Change-Id: I1269127118c11961f552df286292ed8f5b4ef50d
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>