Tom Pantelis [Tue, 14 Jun 2016 21:57:47 +0000 (17:57 -0400)]
Add blueprint XML for bgp-labeled-unicast
Change-Id: I96f286cea1d2464dbe9aaf6009d8152ae26f6049
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Tom Pantelis [Tue, 14 Jun 2016 21:45:22 +0000 (17:45 -0400)]
Add blueprint XML for bgp-flowspec
Change-Id: I0963553e5d090377883b3269b75c9916aff4c8fd
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Claudio D. Gasparini [Thu, 9 Jun 2016 18:36:00 +0000 (20:36 +0200)]
BUG-6020: Implement Ribsupport for extensions
+Linkstate
+Evpn
+L3VPN
+BGP-LU
+BGP-FS
Change-Id: I966ef06d5e48286e0de03edc74a749c69f4f27b5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sat, 18 Jun 2016 21:24:53 +0000 (23:24 +0200)]
BUG-6038: Fix race condition when Open message...
Fix race condition when Open message was sent by the peer before startNegotiation
Fix by start Negotiation and then handle Open message
Change-Id: If5aa3cb024eb5cdbf8995d27445735318cb17759
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tom Pantelis [Tue, 14 Jun 2016 21:24:44 +0000 (17:24 -0400)]
Add blueprint XML for bgp-linkstate
Change-Id: Ie0e6476f4457cbf146e17cbbab6759a163fad9d9
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Tom Pantelis [Tue, 14 Jun 2016 00:07:53 +0000 (20:07 -0400)]
Convert rsvp bundles to blueprint
Added blueprint XML file, rsvp-spi.xml, to the spi bundle that Utilizes the
new blueprint extension, "specific-reference-list" (added by
https://git.opendaylight.org/gerrit/#/c/40267/), to obtain the
specific list of RSVPExtensionProviderActivator OSGi service instances. The
specific expected services are announced via
META-INF/services/org.opendaylight.protocol.rsvp.parser.spi.RSVPExtensionProviderActivator
resources in the provider bundles which the "specific-reference-list"
extension scan so it knows which services to look for. Once all expected
services are obtained, the RSVPExtensionProviderActivator instance List bean
is created and injected into the SimpleRSVPExtensionProviderContextActivator
bean instance which calls start on each.
The only RSVPExtensionProviderActivator instance wired in 27-rsvp.xml is
the RSVPActivator in rsvp-impl. This instance is now created via the
blueprint XML, rsvp-impl.xml, and the config yang and associated Module class
was removed. rsvp-impl also now correctly provides its
META-INF/services/org.opendaylight.protocol.rsvp.parser.spi.RSVPExtensionProviderActivator
resource.
The SimpleRSVPExtensionProviderContextModule was deprecated but still
remains for now to provide the RSVPExtensionProviderContext instance
created via blueprint to the config system so it can be injected into
other users. Once the other user(s) are converted to blueprint then the
config yang, Module classes, and 27-rsvp.xml can be removed.
Change-Id: I5f031322e8a7d947c1ad7e74963cf9f986b992b1
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Robert Varga [Wed, 22 Jun 2016 12:49:43 +0000 (14:49 +0200)]
BUG-865: remove references to URLSchemaContextResolver
YangTextSchemaContextResolver is the replacement, use that.
Change-Id: Ie8967f9ddba3352815f084926441eeb1e0530aac
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 20 Jun 2016 11:37:38 +0000 (13:37 +0200)]
Remove usage of RpcBrokerImplModule from the config test
The RpcBrokerImplModule was removed in https://git.opendaylight.org/gerrit/#/c/38281
Change-Id: Icf06be63df91896e7c4c4cae4bbbebf5d424ecb8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Giles Heron [Tue, 24 May 2016 12:03:52 +0000 (13:03 +0100)]
removed precondition checks for v4/v6 next-hops for v4/v6 routes
Change-Id: Iddc5d26b3cff48582fb3d0d11c7fe1e0e0888b27
Signed-off-by: Giles Heron <giheron@cisco.com>
(cherry picked from commit
95768ea4354c69ff7ad5a7888cfc6d64de43ec32)
Claudio D. Gasparini [Thu, 16 Jun 2016 10:46:59 +0000 (12:46 +0200)]
BUG-5024: Fix BGP LS EPE model
Fix flags model for Peer-Node-SID, Peer-Adj-SID, Peer-Set-SID based on draft
ref. https://tools.ietf.org/html/draft-ietf-idr-bgpls-segment-routing-epe-05.
Change-Id: Iccb36e8631dc821106aec5a4307213f51366443b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 14 Jun 2016 10:27:18 +0000 (12:27 +0200)]
Update BMP to conform RFC 7854
*Added new Peer-Type - "Local Instance Peer"
*Deprecate current distinguisher representation
and replace it with bgp project wide definition of RD
*Update references in Yang Data Model
Change-Id: I5deef00e942b12ce1e8b3504d6de278aa1f70c41
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 16 Jun 2016 07:14:42 +0000 (09:14 +0200)]
OpenConfig BGP ODL extensions - new revision
Introduces new revision of ODL extension for
OpenConfig BGP:
-renamed AFI/SAFI identities to follow naming convention of
buil-in types.
-added augmentations to support add-path in BGP and Neighbor
AFI/SAFI configuration
Change-Id: I5c074d4e1d671c5982d331d6dffa99f92e64444b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 14 Jun 2016 08:55:08 +0000 (10:55 +0200)]
BUG-5024: Update BGP LS to conform RFC 7752 II
-Implementation of new IPv6 Prefix SID
-apply changes required for new protocol-id ospfV3
Change-Id: Ia55508ec657269e8d2cc981486857a5d3c223103
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 13 Jun 2016 14:42:29 +0000 (16:42 +0200)]
BUG-5024: Update BGP LS to conform RFC 7752
changes introduced
+ Update Igp flag
+ Code point reassignment for RSVP-Te and SR
+ new protcol-id OSPFv3 defined
Change-Id: I34e32564133598e4db95bb976380f250d6816092
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Fri, 27 May 2016 23:30:20 +0000 (16:30 -0700)]
BUG-5876 Enhance BGP Speaker and Peer Stats I
- Refactor existing yang model
- Expose total size (number of routes) for Adj-RIB-In and Effective-RIB-In,
Adj-RIB-Out and a size per AFI/SAFI table for each RIB.
Change-Id: I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Tue, 14 Jun 2016 07:34:40 +0000 (09:34 +0200)]
BUG-5024: Update BGP LS extension for SR latest draft
Update module bgp-segment-routing based on latest draft
https://tools.ietf.org/html/draft-gredler-idr-bgp-ls-segment-routing-ext-02
Change-Id: Ibfc6bb2f8ac53e230d263e0a21b2dc8d828b3882
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 13 Jun 2016 08:02:25 +0000 (10:02 +0200)]
BUG-6047: Check lenght of array containing Arbitrary DTO
Expectected lenght is 9, improve log by adding a precondition to
show more clear message when its incorrect.
Change-Id: I8bc0b0fa1d677a20784c48b6e8fb549392e97529
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Mon, 2 May 2016 23:48:25 +0000 (23:48 +0000)]
BUG-5785 Support for dissemination of L3VPN flow spec III
- Add RIB Support
- Integration
Change-Id: Iecc0908ac55cf64414a472fe1dcc5e78034090c0
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Thu, 9 Jun 2016 18:35:00 +0000 (20:35 +0200)]
BUG-6020: Implement RibSupport tests for extensions
After create AbstractRibSupportTest tool implement RibSupportTest for
+ Ipv4
+ Ipv6
Change-Id: I41965a35cb60237f219c88e607b35c61f4b95ab7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Mon, 13 Jun 2016 08:27:23 +0000 (01:27 -0700)]
BUG-6054 fix typo in bgp config xml file
- Fix 31-bgp.xml
Change-Id: I0cd95e2193120fc410ec116b2355d600236996be
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Kevin Wang [Mon, 6 Jun 2016 08:49:42 +0000 (01:49 -0700)]
BUG-5785 Support for dissemination of L3VPN flow spec II
- New NLRI parser for flowspec L3vpn
Change-Id: I6fe6985a46a2b1c2d9dc91dea6bd10282c0dc351
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 10 Jun 2016 07:32:20 +0000 (09:32 +0200)]
BUG-5434: BGP-LU Ipv6 Initial configuration
Add BGP-LU Ipv6 to initial cofig files
Change-Id: Ie1d08ec901c89044f160f284511e89589410ff96
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 7 Jun 2016 10:03:32 +0000 (12:03 +0200)]
BUG-4989: Introduce RIBSupport test abstraction
Introduce RIBSupport test abstraction to do a wide test over Ribsupport on extension.
Change-Id: I6865a7f04a537c19ba88bfff99725b85f0493cdf
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 3 Jun 2015 11:17:32 +0000 (13:17 +0200)]
Bug-3464: Updated Path Binding TLV according draft version 01
-fixed binding-type length
-binding type BT=0 - MPLS label
-new binding type BT=1 - MPLS stack entry
Deprecated previously used leafs in the TLV yang model, while
preserving backwards compatibility.
Change-Id: I5a0dfaf0cc53a04c355d0adb093c5cad2c70a0d9
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 7 Jun 2016 17:11:16 +0000 (19:11 +0200)]
BUG-5434: IPv6 support for BGP-LU Implementtion
IPv6 support for BGP-LU Implementtion
Change-Id: I264ed8cdd117116cf03089e4748ca48c0f09afdf
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Thu, 9 Jun 2016 07:10:00 +0000 (09:10 +0200)]
Fix unit test regression after netty version bump
Fixed:
java.lang.UnsupportedOperationException: direct buffer
at io.netty.buffer.UnpooledUnsafeDirectByteBuf.array(UnpooledUnsafeDirectByteBuf.java:198)
Direct buffer do not have a backing byte array, use utility function
instead.
Change-Id: I5317255bbbca733181a7dcb477ee30449757f0e7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 3 May 2016 15:44:44 +0000 (17:44 +0200)]
BUG-5790: BGP Test tool
- Simulate multiple neighbours
- Active/Passive session initiation
- Log level
- Send X number of prefixes
- Count routes received
- Fix missing check null
- MpPath Ipv4 support
Change-Id: I5150f8f9348a2e26fe3b07424e1ec9e72672cdf2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 7 Jun 2016 12:17:13 +0000 (14:17 +0200)]
Add missing null nlri check on BGPUpdateMessageParser
Add missing null nlri check on BGPUpdateMessageParse
Change-Id: Icf502654a4d4091480775d3d4b542ca1c8f9a745
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 7 Jun 2016 13:58:30 +0000 (15:58 +0200)]
BUG-5434: IPv6 support for BGP-LU
Extend existing BGP labeled unicast implementation to support IPv6 AFI.
Change-Id: I1a55280c9578fbdf744e8d3e65852eb99b1b46fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Tue, 7 Jun 2016 18:08:06 +0000 (18:08 +0000)]
Bug-6005: PCErr generated while parsing of received PCRpt message is not sent out
- use Channel#writeAndFlush instead of ChannelHandlerContext#write when sending out PCEP error message so that decode handler is invoked
- added listener to ChannelFuture to log result of send operation
Change-Id: I03003577003c2f509b5a7a5ae0d1decdd12555c6
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Tue, 7 Jun 2016 09:58:12 +0000 (11:58 +0200)]
BUG-6019: Wrong path name for route distinguisher
Linkstate Nlri parser was looking for "route-distinguisher"
when it should look for "distinguisher
Change-Id: Ia0577b469bacf4a7f7c748587e8dcd296ab157b3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Sat, 4 Jun 2016 00:10:54 +0000 (00:10 +0000)]
Bug-6001: Injecting route with missing next-hop value causes exception in reachability topology builder
- added check in reachability topology builder to handle scenario when next-hop value is null
- entry will be skipped from topology processing in such cases
Change-Id: I254666e1008f6f65e244e4cd93c3f77c8a7b58d7
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Kevin Wang [Fri, 3 Jun 2016 00:28:17 +0000 (17:28 -0700)]
BUG-5785 Support for dissemination of L3VPN flow speci I
- Change flowspec yang model to support SAFI 134
- Change flowspec provider context to be more flexible
Change-Id: I6bb1a4fa0bc7f77d27da3cced4e9addebdd02941
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Ajay [Wed, 18 May 2016 13:05:18 +0000 (15:05 +0200)]
Bug-5791: Make Next-Hop mandatory BGP path attribute
- added code to check for presence of mandatory path attributes during processing of update message
- checking is done for update messages received from BGP peer as well as routes injected via application peer
- updated unit-tests
Change-Id: I894b1eacb75591f3dd5ceb04b7c44439f7d247e5
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Ajay [Tue, 31 May 2016 19:06:38 +0000 (19:06 +0000)]
Bug-5978: Unrecognized attribute flagged Well Known
- set optional bit when serializing unrecognized attributes
- updated unit-test
Change-Id: I6148596b4fb660835e485473d33cc8e961e49a20
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Thu, 2 Jun 2016 11:59:14 +0000 (13:59 +0200)]
Fix imports for Evpn Extended Communities
Fix imports for Evpn Extended Communities
Change-Id: I1d6dfc6f04e78a49f8e08480e0e4183960155e08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Om Prakash [Wed, 1 Jun 2016 12:48:14 +0000 (08:48 -0400)]
BUG-4692: Migrate TCP-MD5 support in pcc-mock package to netty's native-epoll
The reason for migration is that TCP-MD5 are part of the netty library so There is no need to inject any md5 config modules in pcc-mock package.
This change will include to extended concepts package change , upgrade Netty 4.0.33.Final -> 4.0.36.Final and remove the code of md5 package to use e-poll for this change.
Change-Id: I9bb7ba670e7cd40377edb1f237662ec7949c883f
Signed-off-by: Om Prakash <op317q@att.com>
Claudio D. Gasparini [Wed, 1 Jun 2016 08:35:48 +0000 (10:35 +0200)]
BUG-5983: Fix wrong representation of Ip length
Ip Length representation is in bits for
Ethernet Segment Route, Inclusive Multicast Ethernet Tag Route.
Change-Id: I5c3057acb83ab4881d0889d8684d6ea4c405a385
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 31 May 2016 11:49:39 +0000 (13:49 +0200)]
Bug 5984 - Do not use deprecated Yang parser classes
Stop using deprecated classes from
org.opendaylight.yangtools.yang.parser.impl.* package,
use classes from new Yang parser implementation instead.
Change-Id: If91747d41683e16801e5ccd8691b0a0330daa7e2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Ajay [Wed, 25 May 2016 23:43:04 +0000 (23:43 +0000)]
Bug-5933: Support for draft-ietf-bess-evpn-overlay-02
- defined new encapsulation extended community in bgp-types.yang
- implemented parser/serializer for it and registered the same
- added unit-tests to cover the new code
Change-Id: I63cc95d2b61b7a983981df07b68daf0f63425aba
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Fri, 27 May 2016 14:35:55 +0000 (16:35 +0200)]
Fix wrong import for DestinationEvpnCase
Fix wrong import for DestinationEvpnCase
Change-Id: Id7d218e1d90ef5606de963fdd93939dadc6819ba
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Thu, 26 May 2016 20:00:28 +0000 (13:00 -0700)]
BUG-5904 Support 2-byte AS Route Distinguisher
- Support type 0 RD
- Add universal parse function for RD
Change-Id: I78d6a4b9cb0fac62ba796d6ffe54dfa9e712e628
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Tue, 24 May 2016 13:29:33 +0000 (15:29 +0200)]
BUG-5966: Remove received path Id from routeKey
When we map received routes on locRibwriter is required to remove
received pathId to identify the key value (prefix, key-value)as a key.
Otherwise is identifying the combination of key+path id
as a new route and not as a new path.
This step is only required on extension which support Multiple Path
Change-Id: Ia4d6e86cc187a5db71ecfb66c745b9a2420732da
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sat, 21 May 2016 18:51:37 +0000 (20:51 +0200)]
Rib support refactoring II
-Implement new abstract class for MP Advertisement
-Fix route Key creation for Mp Advetsiment on extension
Flowspec, Labeled.
-Apply naming convention to variables names on L3vpn
-Remove duplicated code
Change-Id: I833e3da81782574eea5e1bbd424126a98cfbd550
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Mon, 23 May 2016 18:28:28 +0000 (18:28 +0000)]
Bug-5588: Missing topology-types in BGP-provided topologies
- set topology types for linkstate and ipv4 & ipv6 reachability topologies
- update unit-tests
Change-Id: I17809fb5e574420d356ec73131b9f56a170102ac
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Om Prakash [Mon, 23 May 2016 17:13:57 +0000 (13:13 -0400)]
BUG-4692: Migrate TCP-MD5 support in concepts package to netty's native-epoll
The reason for migration is that TCP-MD5 are part of the netty library so There is no need to inject any md5 config modules.
This will require upgrade Netty 4.0.33.Final -> 4.0.36.Final and Added new rfc2385.yang and KeyMapping for md5 key as base changes.
this base changes will be extended to other module like pcep,bgp and pcc-mock for the migration.
Change-Id: I13ce392759cadb569ffed37fcee8e7095bbcc2e7
Signed-off-by: Om Prakash <op317q@att.com>
Kevin Wang [Wed, 18 May 2016 19:45:44 +0000 (12:45 -0700)]
BUG-5763 Disallow redelegation for PCC-initiated LSP
Change-Id: I99ddbf57f64dd779618cefc09c67de3834b98935
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 20 May 2016 14:02:25 +0000 (16:02 +0200)]
RibSupport refactoring I
Ipv4/Ipv6 RibSupport refactoring
Fix of key route key creation for Put/Delete routes,
adding path id as part of the key.
Change-Id: I04b6760b61e2043d19fa04f638240293e687c5ac
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Thanh Ha [Thu, 5 May 2016 19:07:47 +0000 (15:07 -0400)]
Remove nexusproxy property as it is inherited via odlparent
Change-Id: I0714d6a9336f72c7c26f8bb677f3a777e503f202
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Tue, 3 May 2016 15:56:11 +0000 (17:56 +0200)]
Bug 5029: Support draft-openconfig-rtgwg-network-instance
To allow configuration of multiple BGP instances with
OpenConfig API, use openconfig-network-instance's top-level node.
The model supports multiple instances of a protocol (i.e. BGP)
to be confugured under one network instance.
Augmented the yang data model with openconfig-bgp top-levle node
as described in
https://tools.ietf.org/html/draft-openconfig-rtgwg-network-instance-01#section-2
Change-Id: I89fbee03317d198b81ce2518047d77bc7d09d137
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 19 May 2016 07:01:20 +0000 (09:01 +0200)]
Remove duplicated code for rib support
Remove ApplyRoute Delete/Put in each
ribsupport for an common one since all of them do the
same in each extension
Change-Id: I1ea02916487beaa71104f294c8a6aafa896a6b31
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 11 May 2016 12:11:59 +0000 (14:11 +0200)]
Refactor ExportPolicyTracker and fix AdjRibOutListener
-Lamdafication of ExportPolicyTracker
-Fix registration of AdjRiboutlisteners
-Filtering Internal role from PeerExportGroup creation.
Change-Id: If40abc38fe9408971eb92b6351fae364ee0f8601
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Tue, 17 May 2016 17:58:02 +0000 (17:58 +0000)]
Bug-5855: Transitive Unrecognized Attribute not transiting
- added missing serializer for BGP unrecognized attributes
- added unit-test to test the unrecognized attributes serializer
Change-Id: I0864d2af84438d047bc656b2a156f692cb6a0a68
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Claudio D. Gasparini [Wed, 18 May 2016 13:05:18 +0000 (15:05 +0200)]
Fix wrong aligment in Openconfig
Fix wrong aligment in some of Openconfig classes and test
Change-Id: Ib0d238080658b8f9ee380766f5157bf096ba7670
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 11 May 2016 08:35:49 +0000 (10:35 +0200)]
BUG-5868: Register Evpn Nlri handlers
Register Evpn Nlri handlers
Change-Id: Ibe787d6935ba4845fbad8239d183c374928604af
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Sat, 7 May 2016 22:01:49 +0000 (00:01 +0200)]
Fix various SonarQube complains
Reorder the modifiers to comply with the Java Language Specification.
Move this trailing comment on the previous empty line
Add a default case to this switch
Rename this interface name to match the regular expression
Missing curly brace.
...
Change-Id: Icb397909f33b5dcccc99d48bc602d4bc9213fd35
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Thu, 14 Apr 2016 12:31:10 +0000 (14:31 +0200)]
Bug-4827: BGP Add-Path OpenConfig Support II
Added mapping from OpenConfig API to BGP RIB and Peer Module
support BGP Add-Path configuration.
In "BGPPeer" configuration per AFI/SAFI Add-Path
capability is configured optionally.
In "BGPRibImpl" configuration per AFI/SAFI path selection
strategy is configured optionally.
Change-Id: Ie88148417037ffae869c39cc067fb4b5373ca25e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 28 Apr 2016 12:47:54 +0000 (14:47 +0200)]
BUG-4931: Simple routing policy
New BGP Peer routing policy
+LearnNone : dont listen any peer from this peer.
+AnnounceNone : dont advertise any route to this peer.
If none of this status is applied, default policy
will be applied.
Change-Id: I1634bb4f19e7bfc78ab78b055610eff727f3b051
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 11 Apr 2016 21:12:56 +0000 (23:12 +0200)]
Bug-4827: BGP Add-Path OpenConfig Support
Added mapping from BGP RIB and Peer Module
to OpenConfig API to support BGP Add-Path configuration.
In "Neighbor" configuration per AFI/SAFI Add-Path
capability is exposed (enabled).
In "Global" configuration per AFI/SAFI path selection
strategy is exposed (enabled+maximum paths).
For the sake of gathering info about path selection modes,
expose "N" value in AddPathBestNPathSelection.
Change-Id: Icedecb0e9d18e6fd3b29bfd28d49172209bfbe37
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 5 May 2016 13:21:43 +0000 (15:21 +0200)]
BUG-5844: Fix ComplexRouteEntry creation
Failed to completely propagate updates into Loc-RIB
because of wrong identifier when Add Path supported
Fix by update identifier on complex route.
RouteEntryUtil created to simplify and avoid repeated
code when creating values for routes entry.
Change-Id: I813b542c5b5bf07dbdb3da1ba9603ec6f76630c9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 4 Mar 2016 09:53:36 +0000 (10:53 +0100)]
Bug 4827: Extend ByteToMessage decoder to support peer constraints
Optionally support MultiPathSupport in ByteToMessageDecoder.
Change-Id: I3296e73900dbe6b292f7cdaa57bcea8f0ca6e3d7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 2 May 2016 09:19:07 +0000 (11:19 +0200)]
BGP EVPN Openconfig
Add missing L2EVPN Family to Openconfig Util
Change-Id: I21c698b06ea344b80d05f0dfbcd26c1d61bd0d5a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Thu, 21 Apr 2016 23:42:12 +0000 (23:42 +0000)]
Add BMP redundant connection detection logic
Change-Id: If0081a64fb9c6b2b0d6aa0dee8bfb927cda43010
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Milos Fabian [Thu, 7 Apr 2016 11:49:53 +0000 (13:49 +0200)]
Bug 4827: PeerSpecificParserConstraint implementation
Implemented PeerSpecificParserConstraint for holding
peer specific contraints used during a process
of BGP PDUs parsing.
Change-Id: I2c82cb8d0f5eb6e08c790d0e071724e53d6fde7c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 3 Mar 2016 19:48:19 +0000 (20:48 +0100)]
Bug 4827: MultiPathSupport implementation
Implemented BGP Add-Path supported tables holder
suitable for holding Add-Path constraitns for a decoder.
Change-Id: Ic6380addddf02b23fd160fa8f363cceeb89af577
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 19 Apr 2016 11:46:21 +0000 (13:46 +0200)]
Bug 5689: Unhandled message is causing failure
A write transaction is created when message is recieved,
however in case the message is not handled
(i.e. PcError Message without SRP), the transaction
is not sumbitted, which casuse a race with the next transaction.
Submitting the empty transaction of the unhandled message is
a safe way to avoid the problem.
Change-Id: Ie191eec2b9517078f39c5f065243c87b04ddc189
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Fri, 11 Mar 2016 12:03:09 +0000 (13:03 +0100)]
Bug 4488: Metadata not available for modification NodeModification
To resovle tis race condition problem, modify EffectiveRibInWriter to
work on per peer basis instead of a global per RIB instance.
The EffectiveRibInWriter is now listening on paricular peer's AdjRibIn tables.
The writer is started when a session goes up and closed when the session goes down.
Peer role is not tracked via data changes rather directly set at creation.
The possitive side effect is better error recovery in a case of failure in
EffectiveRibInWriter.
Disadvantage of this change is tighter coupling between components
(peer, eff-rib-in writer and policy tracker).
Change-Id: I07c6c1e2f864b12c50308c7be75b7faa8cc20c12
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 2 May 2016 08:15:09 +0000 (10:15 +0200)]
Update As4 Extended communities
- Add missing mandatory to local-admistrator leaf.
- Rename as-4-generic-spec-common-ec grouping to
a more proper name, as-4-specific-common.
Change-Id: Idcf56922c33b0084ab286ef493e57dd2010c2792
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 12 Apr 2016 09:06:11 +0000 (11:06 +0200)]
Bug 5706 - Conflicting container node "peer-registry" in bgp-peer and bgp-application-peer modules
Renamed bgp-application-peer's container from "peer-registry"
to "bgp-peer-registry" to avoid conflict.
Change-Id: I8f045b532c4bde1b86e82da15268062350e962ed
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Fri, 22 Apr 2016 13:25:55 +0000 (15:25 +0200)]
BUG-5767: 4-Octet AS Specific BGP Extended Community
new 4-Octet AS Specific BGP Extended Community
ref.:https://tools.ietf.org/html/rfc5668
Change-Id: Icd317952ba43813085d4fd1cec3fc726809bd13f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 27 Apr 2016 14:22:31 +0000 (16:22 +0200)]
Code clean up
Remove deprecated leafs on extended-community
and obsolete choice c-segment
Change-Id: If62d0fede00d15b0c3bfa7da139009eecc8beaff
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay [Tue, 26 Apr 2016 17:52:43 +0000 (17:52 +0000)]
Bug-5612: ODL(PCEP) infinitely waits for the response from peer for addlsp
- added configurable timeout (default 30 secs) while processing RPC requests which need response from PCC
- updated unit-test
Change-Id: I18b508564381e41e4fb1fd7f030cf52e314136ea
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Kevin Wang [Fri, 1 Apr 2016 00:17:13 +0000 (00:17 +0000)]
Add support of IPv6 VPN ext (RFC4659) for BGP-MPLS
Change-Id: Iaebcb20ed461667626f13c44e2011610212f8893
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Claudio D. Gasparini [Fri, 15 Apr 2016 10:51:51 +0000 (12:51 +0200)]
BUG-4827: BGP Add Path Flowspec ribSupport
Implement support for add path on flowspec extension
Change-Id: Id7f94ed1719bfa0326d7c652586d594e94e4141a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 5 Apr 2016 06:21:45 +0000 (08:21 +0200)]
Bug 5558 - Closing session after a large RIB is sent kills BGPCEP
Fixed peer session recovery, in a case of failed transaction chain.
The AdjRibInWriter need working chain when cleaning, also it needs
to be started with fresh transaction chain when session goes up again.
Hence recreate AdjRibInWriter with a new tx chain, when the current
failed.
Fixed duplicated session avoidance. The peer's session should not be
removed from registry if it was not created during this negotiation process.
Otherwise, the active peer's sesion can be removed from registry, which can
later lead to the duplicated session establishment.
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Change-Id: I46ef33d49a11db8465a719af5ba4e1716da14602
(cherry picked from commit
54e12560f5b823a24da39c4f9cbe274fb88f30ca)
Claudio D. Gasparini [Fri, 15 Apr 2016 12:19:40 +0000 (14:19 +0200)]
BUG-4827: BGP Add path Labeled ribSupport
BGP Add path support for labeled extension
Change-Id: I6c94948bc90035078cb04f976457cff0a2591ca9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 15 Apr 2016 10:55:35 +0000 (12:55 +0200)]
BUG-4827: BGP Add path Ipv6 ribSupport
BGP Add path support for Ipv6 extension
Change-Id: I913097608e4f9ea62aca0820b53bbd67dce64dd9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Kevin Wang [Mon, 18 Apr 2016 18:25:54 +0000 (11:25 -0700)]
Remove eclipse project files, add more extensions to gitignore
Change-Id: Iffd99c3baa66ef552768ab901a40e2473ce5e846
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Iveta Halanova [Mon, 18 Apr 2016 08:26:20 +0000 (10:26 +0200)]
BUG-5441: BGP SR prefix SID extension
ref.: https://tools.ietf.org/html/draft-ietf-idr-bgp-prefix-sid-02
Updated and added yang modules in parser, LU and inet projects.
Implemented individual handlers and registered.
Created parser, serialized and registry interfaces.
Updated and add unit tests.
Change-Id: If39bfc6c06bf65687d20caa800e9a891ce11a12e
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Iveta Halanova [Tue, 26 Apr 2016 07:26:11 +0000 (09:26 +0200)]
BUG-5779: RPC for peer non mandatory
Change-Id: I16bfda6b8e2a604f029250a2cc444330f35c6346
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Tue, 19 Apr 2016 16:11:26 +0000 (18:11 +0200)]
BUG-5731: Send Error Message if LSP-IDENTIFIERS TLV is missing
LSP-IDENTIFIERS TLV is mandatory based on
https://tools.ietf.org/html/draft-ietf-pce-stateful-pce-14#section-7.3.1
Send Error Message if missing
Change-Id: I4476951de9669efb13c4ed7973182d465aecb47b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Ajay L [Thu, 21 Apr 2016 20:58:03 +0000 (13:58 -0700)]
Bug-5571: The IRO sub-objects should support loose bit
Change-Id: I4e87553eb019de6c3f2fbcf48b394537d897cce8
Signed-off-by: Ajay L <ajayl.bro@gmail.com>
Claudio D. Gasparini [Tue, 19 Apr 2016 14:33:15 +0000 (16:33 +0200)]
BUG-4826: Remove duplicate Code on Evpn Esi registry
Remove duplicate Code on Evpn Esi registry
Change-Id: I5d47b4133e289516453a3d1e822edd4d7f26bf64
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Tom Pantelis [Sun, 24 Apr 2016 06:13:04 +0000 (02:13 -0400)]
Fix config module unit test failures
The implementations of NettyThreadgroupModule and NettyThreadgroupModule
HashedWheelTimerModule in the controller were recently changed - they
now obtain the service instance via the OSGi service registry. Added
appropriate mocking to the various config module tests to get them
working.
Change-Id: I83736883ee2c933d3529a7d297ef178b74e03a57
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Claudio D. Gasparini [Wed, 20 Apr 2016 13:19:55 +0000 (15:19 +0200)]
BUG-5766: BGP Link Bandwidth Extended Community
Implementation of BGP Link Bandwidth Extended Community
ref.: https://tools.ietf.org/html/draft-ietf-idr-link-bandwidth-06#section-2
Change-Id: I5212a71f304035bff5d8f8d23e5b9701d6105261
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 2 Mar 2016 14:25:37 +0000 (15:25 +0100)]
Bug-4827: IPv4 Unicast codec for add-path
Implements IPv4 Unicast NLRI parser and extended
existing serializer to handle extended NLRI (path-id).
Change-Id: I367b78d33d8ae0b4c064a28cf28ed0aad82027e7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Kevin Wang [Mon, 18 Apr 2016 18:12:26 +0000 (11:12 -0700)]
Replace custom Java error message with standard PCEP error message for LSP object missing error.
Change-Id: I166b57fc0f6ac4cdca64adc6215a74e0043a6c6e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Kinsey Andrea Nietzsche [Fri, 8 Apr 2016 12:08:58 +0000 (14:08 +0200)]
Bug 5503 - remove package cyclic dependency in BGP-FS
Change-Id: Ie99145df5ecc8c846c7552d1129153133250bfb9
Signed-off-by: Kinsey Andrea Nietzsche <kinsey.nietzsche@pantheon.sk>
Milos Fabian [Fri, 8 Apr 2016 08:30:52 +0000 (10:30 +0200)]
Bug 4827: MultiPathSupport utilities
Added MultiPathSupportUtil utlity class
can be useful in when processing Add-Path aware
BGP PDUs.
Change-Id: Iec7779986569ec8b202d01c5009ff837c467c5d3
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 19 Apr 2016 12:44:21 +0000 (14:44 +0200)]
BUG-4827: Replace extractPathId method from RibSupport
Replace extractPathId method from RibSupport
by PathIdUtil.extractPathID
Change-Id: I55d4888c476c11f0bf85b805795043413b280d01
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 2 Mar 2016 13:59:56 +0000 (14:59 +0100)]
Bug 4827: Add PathId utility class
The Utility class provides functions
for optional writing of path-id value
into a ByteBuf.
Change-Id: I65235c7aab9d60df9054ecd475481f21e1c430a8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Wed, 20 Apr 2016 11:28:50 +0000 (13:28 +0200)]
BUG-5440: VWPS EVPN Extension
VWPS EVPN Extension implementation
ref: https://tools.ietf.org/html/draft-ietf-bess-evpn-vpws-02#section-3.1
Change-Id: Idff5cd22853cd94505468280c2d601f6da111e37
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 12 Apr 2016 10:24:47 +0000 (12:24 +0200)]
BUG-5511: Openconfig - registry lookup for new peer
Change-Id: Ib0f2b41e1ce65bfc31a7b96568af406c1e3ac4c2
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Fri, 8 Apr 2016 14:22:01 +0000 (16:22 +0200)]
BUG-4826: BGP Evpn RibSupport test
BGP Evpn RibSupport test implementation
Change-Id: Ib91aa24fa0ed74c72a2d7da36f481a5a615ff98d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:29:54 +0000 (11:29 +0200)]
BUG-4826: BGP Evpn Rib support
Implementation of Rib support, Activators, and registration
of handlers.
Change-Id: I7cfadabb7f267c326e58a4f80e323008638faa01
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 24 Feb 2016 07:49:24 +0000 (08:49 +0100)]
Bug 4827: Consumer specific parsers for BGP add-path
The BGP add-path introduces extended form of NLRI (path-id added)
but new NLRI is not distiguishable from regular NLRI
(i.e. code points are the same).
The add-path capabilities are neighbor specific and information
about supported capabilities is available once the session with
a peer goes up. Also the BGP extension provides read-only
consumption of handlers registers, hence easiest way is to pass
the consumer-specific add-path constrain via input arguments.
Extend parser's registers to handle user defined constraints.
Added new NLRI registrator for add-path NLRI parsers.
Added PeerSpecificParserConstraint which can carry any future
user specific constraint to be used during parsing process.
Added MultiPathSupport interface to carry peer's specific
add-path capabilities.
Change-Id: Ieb361c726bd67f74fc653d3423870659404f1b9d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 7 Apr 2016 10:53:54 +0000 (12:53 +0200)]
BUG-4826: BGP Evpn Nlri's handlers and Registry test
BGP Evpn Nlri's handlers and Registry test implementation
Change-Id: I3e08b51d19c8d141c4f4b4f2877edf3e1cfbb29e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:24:28 +0000 (11:24 +0200)]
BUG-4826: BGP Evpn Nlri's handlers
Evpn Nlri cases handlers
https://tools.ietf.org/html/rfc7432#section-7
Change-Id: I385e20a0e510328761c1f341a8c7744182dc5850
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 5 Apr 2016 09:27:35 +0000 (11:27 +0200)]
BUG-4826: BGP Evpn Nlri's registry
Implementation of registry for handle Nlri's.
Change-Id: If71959b5c37f5c3b62268c25c1c10469010a4c08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 19 Apr 2016 11:27:40 +0000 (13:27 +0200)]
BUG-4827: Create grouping for Path-id and make it by default 0
+ Create grouping for Path Id
+ Make Path Id default value 0
Change-Id: I85ad9df929da144ff4b16e9042b21d83202c03c9
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>