Fix license header violations in manager/api

Change-Id: Ia1de1c97a2f9a62fcf0e452e93ecf876d42f2924
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in manager/api util

Change-Id: I3846a2d13230aae87238916f1f6b3dfd42ce9618
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in manager/api flow

Change-Id: Ib51b5095515a54cc1bc2979c63a70ab00c74d21c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in manager/api flow/filter

Change-Id: I61a58c3e6d73341256fdd2a8e0627c19f673bf40
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in manager/api flow/cond

Change-Id: Id4e71e21809aa208116e88b3c17ca766a91b72ea
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in manager/api flow/action

Change-Id: Ia00fde126d02d7883914557aa7aead37f37fac4a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix license header violations in application/listconfig

Change-Id: I3210626a2aff16188178668a642a45ad2bad2ba0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Explicitly set git-review branch to master

Change-Id: I0e6439869c7d3030dc6748d57ef556b1ec4b14c4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 3716: Remaining Fixes.

Change-Id: I7c5987b676df2c81d98993b2cdc82d7bc285aa32
Signed-off-by: gvrangan <venkatrangang@hcl.com>
(cherry picked from commit 1fef3c16002fdc0f4758cbf36cb9f2cf1a7a5d94)

Bug 3716:Issue when new attributes are created in Flowfilterentries during update

Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
Change-Id: I3aeb6eb7097e96d14b0ca52818845255bcfae3c6
(cherry picked from commit bc0199bfb4d336e85f83745bbd6f5259e996742f)

Bug 3684: Reduce sonar major issues.

  * Missing Static Method In Non Instantiatable Class
  * Unnecessary Local Before Return
  * Expressions should not be too complex
  * Methods should not be too complex
  * Declarations should use Java collection interfaces such as "List"
    rather than specific implementation classes such as "LinkedList"
  * Exception handlers should preserve the original exception

Change-Id: I74ddf9aec632267151f7c3c0e6e8f440390877b6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit d29de92909a6046c578d769949d4be3d703cc521)

Bug 3776:Issue in Fedora 22 while starting VTN Coordinator

Change-Id: I2ac2423263e81c7be2c1e186e413c25050ba852f
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>

Bug 3789: Fixed YANG models defined by choice statement.

  * Use "icmp-" as the prefix for the field names inside
    vtn-icmp-match-fields
  * Define inner container for each vtn-action case.
    YANG container inside vtn-action case is used to embed actual action
    type into XML/JSON serialized data.

Additional changes:
  * Fixed incorrect description about data-flow-action.
    * YANG data model treats an empty list as null.
  * Increase test coverage.
  * Suppress ERROR logs while VTNThreadPoolTest.

Change-Id: I80b5525870a9edcfd32f5acd9e99c57e312585ce
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Bug 3758: Fixed bug that VTNFlowManager.close() slept unnecessarily."

Bug 3758: Fixed bug that VTNFlowManager.close() slept unnecessarily.

  * ClearNodeFlowsTask: Complete the task future on exit.

Change-Id: Icb5b6f3885286eb8d6dc64f69f417559897bf8df
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 3755: Fixed bug in vtn-config initialization.

This patch fixes bug that unwanted MAC address might be persisted
in vtn-config (Config DS).

Other changes:

  * Added unit tests for VTNConfigManager and ConfigListener.

Change-Id: I08858ffc2d20156db761762e967941c25fe46290
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Refined unit test for OperationalListener.

Other changes:

  * Fixed missing javadoc doclet in unit tests.
  * Mark MacTableEntryTest as slow test.

Change-Id: Ib5f22f496340a7e08609bb21bbaab51c5d228756
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 3684: Reduce sonar major issues.

  * Unused private fields should be removed
  * Unused local variables should be removed
  * Avoid Throwing Null Pointer Exception
  * Constructor Calls Overridable Method
  * Try-catch blocks should not be nested
  * Collapsible "if" statements should be merged
  * Utility classes should not have a public constructor
  * Unused formal parameter
  * Unnecessary Local Before Return
  * Nested blocks of code should not be left empty
  * Declarations should use Java collection interfaces such as "List"
    rather than specific implementation classes such as "LinkedList"
  * Generic exceptions Error, RuntimeException, Throwable and Exception
    should never be thrown

Change-Id: Ib007cf8b5f0245a8f6fb3cca8dcec21fff7091dd
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Bug 3684: Fixed sonar critical issues."

Bug 3684: Fixed sonar critical issues.

  * Security - Array is stored directly
  * Methods named "equals" should override Object.equals(Object)
  * Throwable.printStackTrace(...) should never be called
  * "object == null" should be used instead of "object.equals(null)"

Change-Id: I8238355129ff5b1e31334fbc64013f555f52e2da
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 3684: Fixed sonar blocker issues.

  * "equals(Object obj)" and "hashCode()" should be overridden in pairs
  * Throwable and Error classes should not be caught

Change-Id: I9af85f3eb3a0f1da9b1f911d4f865a3d931c1292
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed unstable integration test.

  * Fixed bug in FLOW_MOD.out_port emulation.
  * Some tests need to wait for completion of background tasks triggered
    by port state change events.

Change-Id: I7997d9ed17d51e2b6dc7c3f93b30929402a0a202
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 93f0bc6234353248d7f9fb4ca7ae58f182a45908)

Revert "Avoid UT failure due to yangtools change.".

Yangtools fixed a bug that caused NPE in a setter method for a
length-restricted string.

Change-Id: I8706bf00492f338fd624d24dbbf0da1710536a76
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 1216b6ad846b402d46820364d5000ef983ddd8c5)

Avoid UT failure due to yangtools change.

Change-Id: I57e1ebd50c779d6798dd6b8a49d3952e4d9cf054
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 667ab9141883bb3d911ae841880736d475c6dc5b)

Enable integration tests again.

Other changes:

  * manager/config
    * Describe required YANG models and applications in capabilities.
  * manager/it/option
    * Load inventory-manager and topology-manager.
    * Don't load forwardingrules-manager because it is unnecessary for
      VTN Manager.
  * Fixed several bugs in integration test modules.
    * Don't send any notification after tests.
    * Ensure that node-connector is created before notifying link
      discovery because topology-manager will remove links on newly
      created node-connector.
    * VTNManagerIT.testRoutingTable(): Synchronize packet processing
      before solving path faults.

Change-Id: I947419324932a38adcdf060211f8643a64da82e1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Don't use "RedundantThrows" module in checkstyle.

RedundantThrows was removed with checkstyle 6.2.

Change-Id: I4e1af99613ddfa055de03df2ecdfd4854894aa32
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 3601: Fixed coordinator UT build error on Fedora 22 (x86_64).

Change-Id: I62a2bf8dc6fac903366130afbef9f9c8b092a48f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Add Functional Tests for Flowfilter and Flowlist related Keytypes."

Build SCVMM VSEM Provider using README.txt file

Change-Id: Iea6ee51956d9defb1ecec6cd8bd884d5d8de9fa6
Signed-off-by: bharathi.m <bharathi.m@hcl.com>

Add Functional Tests for Flowfilter and Flowlist related Keytypes.

Change-Id: I93fba32dc84cf63fa7f6cbaea73cf02e4640656c
Signed-off-by: Poornachandrarao <poornachandrarao.b@hcl.com>

Renamed application build directory so as to represent artifact name.

Change-Id: Ice213d4043991e22284f143477b3dda9483007b4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Bug 3531: Remove unnecessary try-catch blocks in VTNRoutingManager."

Merge "README text file to build SCVMM VSEM Provider"

README text file to build SCVMM VSEM Provider

Change-Id: I2abb105f065891348e0cdb6d58b294921769cc55
Signed-off-by: bharathi.m <bharathi.m@hcl.com>

Bug 3531: Remove unnecessary try-catch blocks in VTNRoutingManager.

Other changes:

  * Refined unit tests.
    * VTNInventoryManagerTest
    * VTNRoutingManagerTest

Change-Id: Id721d0e6ebe80e253c43681b7b44e1cfcc67d453
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Enable VSEM Provider Build

 - Mono url issue fixed  in releng/builder

Change-Id: I8728f721fc928d619e717750fb67bb02383536e8
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Incrementing versions by 0.1.0 for post-lithium master branch

  * Use checkstyle 6.5 to avoid incorrect indentation check.
  * Fixed coding styles for annotations which take multiple arguments.

Change-Id: I8d5bda94fc0a7734ae9bba90b2d423f690799ce1
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Bug 3420: Flow API should update statistics if UPDATESTATS is passed."

Bug 3420: Flow API should update statistics if UPDATESTATS is passed.

Other changes:

  * Fixed warnings detected by findbugs.
  * Fixed incorrect javadoc doclets.
  * Refined unit tests.
    * NodeListenerTest
    * NodeConnectorListenerTest

Change-Id: Ia9bb9c33f01857594ff554e9ef967d28a835c0fc
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Refined build environment for ODL_VSEM_PROVIDER.

  * Don't run configure twice on "mvn install".
  * Don't run configure on "mvn clean".
  * Create artifacts under "target" directory.
  * Install artifacts.

Other changes:

  * Eliminate "application" from artifactId for application.
    "application" in artifactId is redundant because it appears in groupId.

Change-Id: Id645f997462e4957c271c08aaed839f02d03abb1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 71fd7bd902b1b98a3552066354304eba08ed6716)

Merge "Fixed deployment failure."

Merge "Bug 3271:Flowfilter redirect-action attribute update issue."

Fixed deployment failure.

All the VTN sub modules need to import distributionManagement from
vtn.common.

Other changes:

  * Use manager.checkstyle for application build and remove needless
    clone.
  * list_vtn_configuration
    * Fixed violation of checkstyle rule for class name.
      * Renamed HTTP_RESPONSE to HttpResponse.
      * Renamed APPLICATION_TYPE to ApplicationType.
    * Fixed invalid javadoc comments that cause so many JDK8 warnings.
  * ODL_VSEM_PROVIDER_SRC
    * configure: Fixed incorrect mono version check.

Change-Id: Id566e3349956aeaade5a0d4eaf860fb3aa7ee96b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 8237d0b1547062ff44b164ff252de53267a7dfa0)

Merge "Enable the build for SCVMM application"

Bug 3271:Flowfilter redirect-action attribute update issue.

Change-Id: Ia76cd641239fcf16107550701bc8d1ba2c7aff1d
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Enable the build for SCVMM application

  Remarks:
     VSEM provider build will be disabled until Jenkins build environment
     issue is solved.

Change-Id: I40cd5d0e5efbd125c0a1653536481dcc38a0b4ef
Signed-off-by: bharathi.m <bharathi.m@hcl.com>
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

commited unit test file for SetPathCostTask.

Change-Id: Ife92bba3a5f54ff89264cae5fd187a016950fb7b
Signed-off-by: hari.pr <hari.pr@hcl.com>

Merge "committed unit test files for NodeListener, NodeConnectorListener and VTNFutureTask."

Merge "Unit test files for OperationalListener and FutureCanceller."

Merge "Unit Test files for VTNInventoryManager, VTNRoutingManager and TxSyncFuture"

Merge "Unittest for SpecificPortFilter in VTN Manager."

Merge "Fixed :Bug 3109 Flowfilter and Flowlist attribute update issue."

Use karaf-parent for creating local karaf distribution.

Change-Id: I85b06248c74f7939b4938cea6f817a28016a86aa
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 0b16c4055c70c9a9c12a3d09aa45e75436aca8fc)

Merge "Bug 3299: Fixed coordinator UT build error on Fedora 21 (x86_64)."

Bug 3299: Fixed coordinator UT build error on Fedora 21 (x86_64).

Change-Id: I9285599eee0aeccd5ae59e275e5760b6a009a79f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 140898072204a909fd0e7486cb23bc52c0e7aae9)

Bug 3227: Fixed bug in MAC mapping cleaner.

Flow entries established by a MAC mapping will be removed when the
mapping is removed.

Change-Id: I70b2a26f7fd839f273774fdf4ab325f79e399506
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 4434707d587c7fc19321a4b70851bf7d6102a5b6)

Disable integration tests temporarily.

VTN Manager's IT is being broken by the data change listener issue
tracked by Bug 3344. We decided to disable IT so that we can merge
patches. IT will be enabled after that issue is fixed.

Change-Id: Ifd20c45cb7dbfd598488d8e3d8353f6c1d20d06b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

committed unit test files for NodeListener, NodeConnectorListener and VTNFutureTask.

Change-Id: I3808385da6b102d6b55877551fda9b076158ad78
Signed-off-by: hari.pr <hari.pr@hcl.com>

Unit test files for OperationalListener and FutureCanceller.

Change-Id: I9fcc34eb59ec3f5bedc049c0746ede8308dba080
Signed-off-by: karthik_j <karthik_j@hcl.com>

Fixed :Bug 3109 Flowfilter and Flowlist attribute update issue.

Change-Id: I93b25a479022674f02fd009bbc67342757628aa9
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Merge "support other content types in VTN Coordinator REST API     *http requests with test/xml as content-type is allowed"

Merge "Support for Microsoft SCVMM"

Migrated flow entry management to MD-SAL.

VTN Manager no longer depends on sal-compatibility.

Change-Id: I13199a6aaf363a684c5166b9f2a42f4975268cfc
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Add Functional Tests for Flowfilter keytypes"

Merge "TestCase for CanceledFuture and TxQueueImpl files"

Support for Microsoft SCVMM

   * Add VTN as Network Service
   * GUI support for configuration REFRESH

Change-Id: I4af8d3421e61947bc921f915c752e18bbfe6035c
Signed-off-by: bharathi.m <bharathi.m@hcl.com>

support other content types in VTN Coordinator REST API

  *http requests with test/xml as content-type is allowed

Change-Id: I7ea6c3c9bfafcd643071f87e5d27d5141d2e2135
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>

Unit Test for FutureErrorCallback.

Change-Id: I3f77b2e73b6f933ae618840bc73d60154d419783
Signed-off-by: karthik <karthikeyen.p@hcl.com>

TestCase for CanceledFuture and TxQueueImpl files

Change-Id: I299c1a606d580378aa9fc39b89a1f065996dab1f
Signed-off-by: priya.ramasubbu <priya.ramasubbu@hcl.com>

Unittest for SpecificPortFilter in VTN Manager.

Change-Id: Ied69c7f9860cc369cf1a7a0b8e43f006a9dff171
Signed-off-by: umaswathi <umaswathi.m@hcl.com>

Improve FutureCallbackTask.

  * Invoke callback when the future is canceled.
  * Enable to specify the number of pollings.

Other changes.

  * Refine unit tests.
    * Use Mockito instead of stub class.
    * Fixed broken javadoc links.
    * Suppress unwanted logs.

Change-Id: Ia7576c70f901945a69e75a6e217a34c06be3a979
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Add Unit Test for routing and internal package.

Change-Id: Ic27e87c9fa3c3673bf0774f9182f601845b36120
Signed-off-by: dhandapani <dhandapani.l@hcl.com>

Merge "Unit Tests for VtnNodeEvent and VtnPortEvent."

Merge "Unit Test files for RemovePathCostTask and RemovePathPolicyTask."

Merge "commited InventoryMaintainer test file."

UT files for VTN Manager

Change-Id: I16be7a4661c439cafb2bf1df6880b4bc5391ce38
Signed-off-by: kavitha.ma <kavitha.ma@hcl.com>

Unit Test files for VTNInventoryManager, VTNRoutingManager and TxSyncFuture

Change-Id: I19560472d37d141ae50fc5c2bf523ae7944b62a6
Signed-off-by: chakalir <chakalir@hcl.com>

Merge "Parsing Inventory information from Vtn inventory REST API"

Unit Tests for VtnNodeEvent and VtnPortEvent.

Signed-off-by: karthik_j <karthik_j@hcl.com>

Use 8288/tcp in northbound IT instead of 8080/tcp.

Change-Id: Ic46ece4e3df4684b086dc159ebfacce65431612d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Removed vtn-manager-all feature."

Removed vtn-manager-all feature.

Change-Id: I6323ff49d9e0b257b171f58667649b932573f119
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Test Case For ReadTxContext.

Change-Id: I8fce89f628431690d3d60a0d9f869eded94d2229
Signed-off-by: manimuthazhagan <manimuthazhagan.r@hcl.com>

Unit Test files for RemovePathCostTask and RemovePathPolicyTask.

Change-Id: I1fef232cd67a68774ff6fbe2393360d867203ffb
Signed-off-by: chakalir <chakalir@hcl.com>

Parsing Inventory information from Vtn inventory REST API

Change-Id: I732dbacf260f09a2c52c910e280623aa413c9361
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

commited InventoryMaintainer test file.

Signed-off-by: hari.pr <hari.pr@hcl.com>

Drop AD-SAL container support.

  * VTN Manager in a non-default container does nothing.
  * VTN Manager REST API is bound to the default container.

Change-Id: Ife1f63b53a6338073d89eefbb1573e51e91fba31
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Updated dependent features of VTN Manager.

This patch made all necessary features for Neutron interface into
dependent features of odl-vtn-manager-neutron feature.

Change-Id: Icea3ee1274682f807ca750c67fd8c2475637a49b
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Fix JDK8 javadoc compatibility

JDK8 is more picky about javadocs, so fix them up so the project can
pass compilation.

Change-Id: I8273b9c339a10c25569abc9af16a8eb4b9cffdb3
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fix JDK8 compatibility"

Fix JDK8 compatibility

Method resolution rules seem to have changed (or JDK8u45 has a bug), so
point directly to the containing class's method to ensure it's resolved
in both JDK7 and JDK8 environment.

Change-Id: I55267bed04ccc7a13c668802a69c89fd834aa418
Signed-off-by: Robert Varga <rovarga@cisco.com>

Changed feature names of the VTN Manager.

According to the feature naming wiki, this patch changed feature names
of VTN Manager.
https://wiki.opendaylight.org/view/CrossProject:Integration_Group:About_User_Facing_Features

Change-Id: I6fa54e91527bbef55280c7904191da337d0b1559
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Fixed IT breakage.

Load openflowplugin-common bundle explicitly on IT. It is required by
topology-manager.

Change-Id: Ib75cd148d92bc2c413bbcdcd8119fafb57298591
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Fixed IT breakage.

  * Load required bundles.
    * neutron.model
    * yangtools.model.ietf-yang-types-20130715
  * Add configuration for FRM.

Change-Id: Ica8931eaf2f0eeda2de11c9eea14669f6b09f9ec
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Changed YANG model for data flow APIs.

  * Renamed container for averaged data flow statistics in order to avoid
    collision with AD-SAL based API.
  * Refined description.

Change-Id: Iea01755c1781f1dbc4e501ac725144ddc6743575
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed IT breakage.

  * ofmock: Notify link explicitly when the port state is changed.
  * ofmock: Ensure that both edge ports of the inter-switch link are
    created.

Change-Id: I80278595c11fc6537dfd91ce0813858c0dc52b43
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Vterminal and Flow filter functionalities added for VTN Application.

Change-Id: Ic52f8cf0f9592ba553c08d624b036e393f8979a8
Signed-off-by: kavitha.ma <kavitha.ma@hcl.com>

Bug 2898 - implemented subnet handler support in VTN Manager.

Change-Id: I1714f9ccdc45cd523bf844b3aab1ea4268d69b30
Signed-off-by: dhandayadhapani-b <dhandayadhapani-b@hcl.com>

Changed data flow API classes for MD-SAL support.

  * Moved AD-SAL flow match/action utilities to manager.implementation.
    * They will be removed when the flow management is migrated to
      MD-SAL.
  * Changed DataFlow instance methods which set packet routing and
    edge flow information.

Change-Id: I87f83fd4917b0e176fa007074a8f198f53409d51
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Add Functional Tests for Flowfilter keytypes

Signed-off-by: Poornachandrarao <poornachandrarao.b@hcl.com>