git.opendaylight Code Review

Updated git submodules

Project: netvirt master cb3b35844d5b736f8c212181f3b164aa65f67a9c

21->nat-group flow is not present on OVS after “upgrade”

table=21, priority=10,ip,metadata=0x30d42/0xfffffe actions=group:225000
(checks the VRF id and forwards to a group
that outputs to the external interface)
The flow is in fact written by ODL but rejected by OVS because
group:225000 is not present at the time the flow is written.
Group:225000 is not written because at the time that is triggered
(twice, actually) there is no /elan-interfaces/elan-interface for the
external network (trunk) port because OVS has not yet connected.

Create a default NAT group(225000) before installing flow the
21->group:225000. If elan-interface(for external-interfaces) are missing
during this group creation, then create this group with an drop action.
Once elan-interfaces are available, this group will be updated with proper
action values.

Steps perfomed
--------------

1) Shutdown ODL (logout)
2) wipe data store (rm -rf $KARAF_HOME/journal/* &
$KARAF_HOME/snapshots/*)
3) disconnect OVS and clear groups/flows
sudo ovs-ofctl del-flows -O Openflow13 br-int
sudo ovs-ofctl del-groups -O Openflow13 br-int
sudo ovs-vsctl del-manager
sudo ovs-vsctl del-controller br-int
4) restart ODL (./karaf)
5) Wait for net-odl full sync from neutron
- waited until DS gets poulatedi
- (ex : GET http://192.168.56.1:8181/restconf/config/neutron:neutron/ports)
6) reconnect OVS
sudo ovs-vsctl set-manager "tcp:192.168.56.1:6640"
sudo ovs-vsctl set-controller br-int "tcp:192.168.56.1:6653"

Change-Id: Iad89b3ff7935846b0bf1a3b9b3a4690ff87fcd9c
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>

Updated git submodules

Project: genius master 711d29484cb90e8642767f662de0395ba0bf372f

Cleanup in idmanager-impl

- Change public Map fields, allocatedIdMap and releaseIdLatchMap, in
IdUtils to private and added methods to access them.

- In ReleasedIdHolder, delayedEntries is expected to be thread-safe and
is initialized to a CopyOnWriteArrayList however it can be set externally
via setDelayedEntries with no knowledge if the passed List is thread-safe.
It turns out the 3 callers do pass in a CopyOnWriteArrayList however it
shouldn't rely on callers doing the right thing so I changed it to create
a new CopyOnWriteArrayList from the past List to guarantee it. This also
ensures delayedEntries is never null.

Change-Id: I792012ecb218609fb40e1f9efb78dc9d077d2d05
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: infrautils master a163cba146827832ee4888af15eb87408b4342f5

SystemReadyImpl catch RuntimeException instead of Throwable

see related discussion on
https://lists.opendaylight.org/pipermail/infrautils-dev/2017-September/000409.html

Change-Id: I31ffadac6648adcdfd7cf5553ef00be21006fbb7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: infrautils master ab99f988feb7e68d2ba1d0048549bace26fbc37c

JobCoordinatorTest methods renamed to clarified what they cover

added new @Test for JobRetriesExceptionThrown

renamed getRetries() to getTries() because that's what it is

Change-Id: I979e5ca156af4c7ca26a97f173625848d313514f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: infrautils master 8147369164587e986ca306f68f1afaeeb7ff3002

JobCoordinatorTest move testAnException() down to similar tests

Change-Id: Id26589827cae77c94a53261267d83ff45bd9ce19
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: releng/builder master 85c39276c55d5c2cc091f286b6034d3fe7bc386e

Use 6m workaround for rabbitmq

Change-Id: Ie5d4a57d78de6eae3281a52a00c5150096a95aa5
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: coe master 3cf3ee38670a3208e5f43f9d7343fb2bec58922e

Updating kubernetes client

Change-Id: I5ec388f6cf1a64e6ee61fb89324939e8f3185ec5
Signed-off-by: Frederick F. Kautz IV <fkautz@redhat.com>

Updated git submodules

Project: odlparent master 7c2c1a3cca2ffeb6cc81e8667e132ca00f968985

BUG-9200: upgrade maven-shade-plugin

Version 3.1.0 is required for Java 9, release notes at:
https://mail-archives.apache.org/mod_mbox/maven-announce/201708.mbox/raw/%3Cop.y5d393zfkdkhrr%40desktop-2khsk44.dynamic.ziggo.nl%3E/

Change-Id: I5892cba22d1f50708b219aaee35be5ed2af2d2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
BUG-9200: update failsafe/surefire plugin version

Version 2.20.1 is required to support Java 9, changelogs are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201709.mbox/%3CCAKuVzBTt6gPWkjDS7AcLBKj7C1i9C7CgjRa3s0mQ0S-P%3D3CiiQ%40mail.gmail.com%3E

Change-Id: I08c48631b3ddcec3d36476e759d16f49a1c0a70f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Updated git submodules

Project: odlparent master 5ccc896bde35fb1902cbb4c3f5fb4b86887edba0

Bump commons-codec 1.10 → 1.11

Release notes: http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: I402e984c90e9f59b65c06244a8bade3e2156db6c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: bgpcep master 12f37f62c1d8366b355ee6c852282c5f541d1680

Use bulk operation

Change-Id: Id8da3f1394551ec6c879bfab847fdd93fda3e0a1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: releng/builder master 3d53d829633ec76e433325e9239d33687aa1e17a

Update cloud image list docs

Change-Id: I7d65e40ed72c2f08715932a611f6b85a7d201f7c
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Updated git submodules

Project: odlparent master 0e66b9cfbf6312b3a49436b6c4dcf0060c7c4d4b

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: If751fe5cf6c4b122063699f4ac234c25fc8daffb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: genius master 9aa7743afa93f058c7493bf7ec2a03540c1d7958

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: I7761c1efaf216cacf87d909f9a38ec2b265fda66
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: odlparent master fcd8afa08d16b11fc8f2650971736d9a2d49e631

Switch bundles4-test from FindBugs to SpotBug

Change-Id: I4d4a92d3800a1b23705f8cac3d24c44dfcc01950
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: bgpcep master f5c695097d15d2603996fdf5911c3f899b2fb6e1

Migrate Jave 5 Stringbuffer

Change-Id: I57a2e07fa111dc6cf87d5920cf388169f4fe41e3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: genius master 288fc272642e25f19bb0b8b0b75b0492511d4dab

FutureRpcResults with StackTraces.getCallersCallerMethodName()

Change-Id: Ibd45d12c75e67de2b54fb1dbfe5e96fdff58859d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: releng/builder master 4f2ad6a760d46ca5e1284c5d6a8c59a754aa9cb9

Merge "Update to use devstack tip of branch"

Update to use devstack tip of branch

The main change to latest devstack is that the computes need
to query the control node. The computes will poll for 60s and if
not found the compute stack fails. This patch does the following
to support the change:

1. Modify the devstack code to increase the 60s timeout to 30m.
In multiple tests the average stack time for a control node is 20m
and the computes 18m so 30m shoudl provide coverage.

2. Update the iptables handling. The previous run.sh iptables config
simply disabled the firewalld and iptables, but devstack restarts
iptables so the query from the computes to the control node would
fail. This change leaves iptables running but updates the rules
to open the OpenStack ports. This better matches a practical
deployment so it is good to have.

3. Add a new local.conf option: CELLSV2_SETUP=singleconductor.
Another change in devstack is that when the nova-compute is started
on the computes, it queries the control node for the cell1. The cell1
access in mysql is not set up until later in the control node bringup.
If the compute queries before that setup an exception is not caught
and the service exits - and therefore there is no hypervisor on that
node. The local.conf change removes that query.

4. The OS_AUTH_URL was updated to only use the identity url.

5. Added some more conf file captures to the collect_logs() function.

The hwvtep and coe yamls were not changed yet and still have the
devstack_hash. These will be cleaned in further patches. Testing was
done to verify the changes in this patch do not affect the hwvtep
or coe yamls.

All combos of ocata, pike and queens were tested.

Change-Id: I8a4c05cce3107f0525022dfe06c46a78cf3b78c9
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: netvirt master 7a345e7898755253a5ebcccd8bf6950bc0515aaf

Convert to JobCoordinator in qosservice-impl

Change-Id: I3462bacddee1ad01803fdacec4f355e7c8a5bb7d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master e9ef15ca5964c6becb1a531a61a7ba1aff90e3a1

Convert bgpmanager-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: Ibb54eafc0561fa4ee1845498b5d17ef9b3b01363
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 49b355e807c47dc294abf86857226e39f3d057a8

Convert to JobCoordinator in neutronvpn-impl

Change-Id: I2f328995de40918bd3031d5754d91ffdf0c728cf
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 00bc5b1467d7f131e5cb0517b8a9075f61692978

Convert to JobCoordinator in dhcpservice-impl

DataStoreJobCoordinator is deprecated so convert to use JobCoordinator.

Change-Id: Idb4057c125e41bf64dcba559caedfe8d046da28f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master b4d2e8de133201c8ab2d64bda15117b2427d546c

Convert to JobCoordinator in cloud-servicechain-impl

DataStoreJobCoordinator is deprecated so convert to use JobCoordinator.

Change-Id: Icce0eb72bf61fbc703e79f246aa7e8dc796e83f9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master d2ca3755bca2366c7cdeb202bdee4ce8eaf408e9

Convert to JobCoordinator in policyservice-impl

DataStoreJobCoordinator is deprecated so convert to use JobCoordinator.

Change-Id: I4e12d77e8626a7638c3cd4ada700061ee5ae81ae
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master fe4822ce731e78d14210c4b6c7a6f87dd742ec4e

Convert to JobCoordinator in fibmanager-impl

DataStoreJobCoordinator is deprecated so convert to use JobCoordinator.

Change-Id: I17094b2da363bd4a96cca06d5c53cc45da001642
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 435c0c58999406b90a33a46dab2a511c022dce77

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: If19cda9d89fd6ad5c0cb1351885c59d501ffe6aa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: netvirt master 5e00e8a3994a3f03cd1dfa6f1e63db64606677c1

Fix ElanServiceTest by adding ElanServiceTest

ElanServiceTest broke on master following
I75a0edccef1b47ecf1c246c9e51e7717916f1da2 ... :-(

Change-Id: Ib63cf571901e23e9d3dc897781c779866c5f052c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: ovsdb master 5f93ebfd669371e7f0478142058da0d714416f4a

OVSDB-432: Add method to restart OVSDB server and limit retry times and timeout

This patch makes following changes:
1. Add restart method to restart OVSDB server. User wiil be able
   to restart OVSDB server with different sets of SSL protocol
   and cipher suites.
2. Limit retry times for certain SSL handshake status. In current
   code, it retry infinite times for some SSL handshake status
   and cause issue. This patch will fix it.
3. Add API in OvsdbClient interface to provide custom timeout value for
   monitor and cancel monitor transactions. This avoids
   blocking thread due to unsuccessful transaction.
4. Fix typo in Function.java

Change-Id: I4f07e2f32889099e65a06a3afc4a263714dd5946
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>

Updated git submodules

Project: releng/builder master fcde59b12756ae8508835608e162536f13ececac

Update default ODL versions in RPM jobs

Change-Id: Ia2bd5360941a5d5d6ae5636946f7c388c1bfe827
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: infrautils master b9ca3b3eec69993bb9bd213635aa6ad8acbbb398

INFRAUTILS-18 Remove dependency from jobcoordinator to counters

Change-Id: Ifeeaa0b36d0bc1ec90eae7132fb6e15c916cbe40
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: ovsdb master 3a72a043751d5135830c8fa0d86a82334fb7084d

Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: I765df2031218eabb07dffac1a0856ef5a45d798f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: bgpcep master 3e0515187720677ae2b4e1208172fc29aa24c0cb

Remove unnecesary boxing

Change-Id: I48a32e366ab320a31b868bb9af8e11014bf1aa12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: sfc master b5fabe57fd6421d587bd43b0b85938f09e948acd

Refactor listeners in sfc-scf-openflow module

- Use Genius Listeners Framework
- Use blueprint annotations so they can be directly handled by BP
instead of the SfcScfProcessor singleton class
- Some minor fixes
- Checkstyle

Change-Id: I0c8029e4c8db2f65c76006e838108deb57d33141
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Merge "ODL Parent Oxygen M1 read-out"

Updated git submodules

Project: odlparent master 1fe85fda59f9bb9dd838c7903ea62a25a878d7bc

Add SpotBugs dependencies

SpotBugs is the maintained replacement for FindBugs, which has been
abandoned. See https://spotbugs.github.io/ for details.

This patch is phase 1 of the (long-term) migration from FindBugs to
SpotBugs: it adds the spotbugs-maven-plugin to plugin management with
the appropriate version specifications and default configuration.

Change-Id: I29a47604bdd25a20dc0fe56f41cd0083ad934e13
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: bgpcep master f4b87f6ab68fbb8be93e6176cc0360e05bcc1bd8

Fix missing version for maven reports

Change-Id: I45f229b90731d22d1099d38c690b2e6bb8ad5763
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: releng/builder master d3c4b28d550eaaeb69cc44744117189cd83ff2f0

Update to global-jjb v0.12.0

Change-Id: I0316072ca2a2a204c3e1da38315b4cb78ed65dc4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: netvirt master a1654d52ef4733dcbb952c24defb72a2d5e18877

Revert "INFRAUTILS-18: @Ignore AclServiceStatefulTest until JobCoordinator fixed"

This reverts commit fbde3eaa72bb40528df7bb482feef8103b812e9b,
because https://jira.opendaylight.org/browse/INFRAUTILS-18 is fixed.

Change-Id: I849d7c6abf5d53cf0d1cba5f8349318f6f45f0e8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master 5cbde4cb077fe5db5e00deeb4d34fbb29b8746aa

Handle logging symmetrically in FutureRpcResults

This patch treats logging and result (or error) processing
independently, in a symmetrical fashion for both success and error
cases.

* LogLevel handles the logging façade in front of Logger.
* A new NONE LogLevel allows logging (by the default handler) to be
disabled.
* The success log level is configurable (including NONE).
* The default consumers do nothing (logging is handled separately).
* The onSuccess/onFailure handlers follow the same pattern, and the
onFailure handler is re-used for external error handling.

Change-Id: Ie4f799d4ba655c438ac1616b04b323a11a913684
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master 0590bce7a1a3a19b854923d6ab7a21aba3321c7b

Refactor FlowBasedIngress/Egress classes to non-static

Change-Id: Idef01d927a79acd2cbad2a9f930de3f8244bacb7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 3e27aae03754437abfa66eec22f9a314a37f170a

Refactor AlivenessMonitorUtils to non-static

Change-Id: I940bfe61b6e18e54db18a5a5145e2d95fa688954
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

ODL Parent Oxygen M1 read-out

Change-Id: I6af301fbbee37195c8f78806f1e3ef820706b49f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Update unimgr docs for Presto NRP support"

Updated git submodules

Project: releng/builder master 797ef45fa024e6aa7bccb89388bd5abc53a22a0d

Add p4plugin jobs to Jenkins

Change-Id: Ic3e4e6d16a88f19c17346e363d8aefd22c6e520e
Signed-off-by: Wsx25289 <10200860@zte.com.cn>

Updated git submodules

Project: genius master 3a4853b5b001d087b1bcda53e8ee7c8c4603b550

Convert to JobCoordinator in interfacemanager

Also cleaned up some statics in the process.

Change-Id: I0f26b145e8d587554e6daff275a00218a65c1932
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: infrautils master f5a8b0183899cc631e6ec5c22bb170d75f4ce2c0

StackTraces getCallerMethodName()

I'd like to use this in org.opendaylight.genius.infra.FutureRpcResults
to offer a variant without the explicit String rpcMethodName, and
instead implicitly get it from this.

This is motivated by seeing first users starting to adopt
FutureRpcResults, e.g. in I04553678580ff53217c7757594cdd836aa8abfae,
getting that rpcMethodName wrong (not once but twice).

Change-Id: Id67f619fabd390485b44420c5d5669f12e5fd82d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netconf master 4788b31c2c898c442309f9323580852e0752eae4

Restore the deprecated credentials name.

Renaming caused downstream breakage so restore the old name.

Change-Id: I835b178d8f62b1c693f81f11316eeb67c146bf8c
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: bgpcep master 048cf910960206bf92a7dbfbc1a02b24a41f6591

Create pcep topology parent aggregator

Change-Id: I3fbf0eb152ba84da138881f1080eb7b65d15469c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
BUG-9079 Make PCEP session recoverable from exception

This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.

Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Updated git submodules

Project: genius master 689c44419ecd07139cb9089380753835ee49b140

Convert to JobCoordinator in idmanager-impl

Change-Id: I75a0edccef1b47ecf1c246c9e51e7717916f1da2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: infrautils master 12ec1270674b8349edb17b80946c5e1697f09f4d

INFRAUTILS-18: JobCoordinatorCounters should not be static

Changed JobCoordinatorCounters to a class wih AtomicLong fields.
Previously, it used OccurenceCounter internally which is essentially
an AtomicLong but has other fields which aren't used anywhere. In
addition, it internally stores each OccurenceCounter instance in a
static Set (ugh - more statics...). We don't need the added overhead
of OccurenceCounter.

Change-Id: I787500aec20215af5a14627af7be75cca03a61fa
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 8e218f546fbeb34b1abe6c903fb80c4dcb2e6968

INFRAUTILS-18: TestableJobCoordinatorEventsWaiter 2 min. instead 30s

and include details of JobCoordinator state when stuck

Requires Iac27dbdd707a599fcb912bb68425e6cbe969d0e3 c/64806 in infrautils
for the new JobCoordinator toString() implementations.

Change-Id: Ibaf06bd75a8f5f5ba48ffc6e0f1c26fbab3d96f5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: infrautils master 1c530a5ec2b12a425b18684348059aa0951b7246

INFRAUTILS-18: JobCoordinator toString()

so that we can get more details about it when it's "stuck"

Requires Ibaf06bd75a8f5f5ba48ffc6e0f1c26fbab3d96f5 (c/64805) in genius

Change-Id: Iac27dbdd707a599fcb912bb68425e6cbe969d0e3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netvirt master e33e94ff7729c54671f18d8eca4d26c451d3844f

Refactor/cleanup BgpConfigurationManager

- converted static fields to instance fields
- changed all instance fields to private
- removed unused fields/variables/code
- fix warnings

Change-Id: Ic6629f39558ec5280718c42d56a6af9c6a194e46
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 886ccecc396ed98f28de7fe6d5f296f921e9600c

Convert dhcpservice to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I2670160dd459b4f3ff64aff2a877b2a6f0683988
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: coe master 6057ca8206275124f03c22e1c761086a4ac8efab

Update the watcher APIs

update the watcher APIs to match changes
that happen in the yang model

Change-Id: Iab9d0295701729adbe14db47ac389e063cd1e0f0
Signed-off-by: Mohamed ElSerngawy <m.elserngawy@gmail.com>

Updated git submodules

Project: integration/test master b0a7b6d8232a197a139412f7bef9a872b743e4f0

Migrate AAA CSIT to use Variables.robot from .py

Also removing unused, empty suite.

Change-Id: I1ad9c2951c73373dda4dc38f4bf77a33eba0822e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: genius master 5bbfa094bb5be1ff03fe9d97d3f279d26985e81f

Fix the listeners closing process

In some cases, dataChangeListenerRegistration might be null, provoking
an NPE. This fixes that problem.

Change-Id: Iaa1a22a54b47b38783eddf15edbf42b14b0bb84a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Merge "Add BGP release session doc"

Merge changes from topic 'milestone-status'

* changes:
Structure M0 status for parsing
Add a script to generate M0 status

Update unimgr docs for Presto NRP support

Change-Id: Ie71e45274a88aa089463780f7583d04c3cc08bd8
Signed-off-by: Bartosz Michalik <Bartosz.Michalik@amartus.com>

Updated git submodules

Project: sfc master dd48656bc2f31601c27c2587b2818e906e6d90a7

Deprecate the abstract listeners included in sfc-provider

The AbstractClusteredDataTreeChangeListener and
AbstractDataTreeChangeListener are replaced by the classes present in
Genius' package org.opendaylight.genius.datastoreutils.listeners.

Change-Id: I2fcb0187e2b3f43b7ea9d872c50de1543e89f384
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: sfc master 737725e4fb38e19e2dbcccccc5f447d8ae2f393e

Migrate the rest of the sfc-provider's listeners

Migrate the rest of the sfc-provider listener to use Genius' listeners

Change-Id: Idafd8020f1f7620ae22e7d894ac0c0a38e7285fb
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Add BGP release session doc

Change-Id: I6b9c81dafc4191c6e608b2200eed71406c4adafc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: netconf master 4653c163772a24ebefdcb21a08315f539678ad4e

Merge "Remove the default loopback mount from the old connector feature"

Remove the default loopback mount from the old connector feature

This is conflicting in sft when two projects pull in the old feature
and the new clustered topology feature. Cfg subsystem should have no
users now so remove it.

Change-Id: I97819282f39af332fa78bf58cbb99321ffa79ae0
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: netvirt master fbde3eaa72bb40528df7bb482feef8103b812e9b

INFRAUTILS-18: @Ignore AclServiceStatefulTest until JobCoordinator fixed

Change-Id: I6f53a51a26442572a001db2cc5f49c062f2de1a5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netconf master 5503d46fd502913e25b978018a1fffa607b35d38

Merge changes from topic 'keyauth-refactor'

* changes:
  BUG-9261: rename pair-id to key-id
  BUG-9262 Add rpc for remove-device
  BUG-9261: Move keystore to use Config datastore.
  Do not return null in RpcHandlerDefault
  BUG-9261: Add basic public key auth to testtool
  BUG-9261: Add credential handler for PublicKey auth
  BUG-9261: introduce netconf keystore service
  BUG-9261: introduce new Credential types

BUG-9261: rename pair-id to key-id

Makes more sense since we are not dealing with pairs.

Change-Id: I3f15304506844a23232541703182c73a7256379d
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9262 Add rpc for remove-device

Change-Id: I0abb373b29e6c3e89b4b2c0b424782c57c70418e
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Move keystore to use Config datastore.

We want the keystore persisted since we want to keep the
configuration valid across restarts so keep this in the persisted ds.

Change-Id: I806271f4fac3b66113253616baeedae42784896c
Signed-off-by: Tomas Cere <tcere@cisco.com>
Do not return null in RpcHandlerDefault

Change-Id: I692a03a65e1bd8dbd471ec2756320d374e397261
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Add basic public key auth to testtool

Adds public key authenticator that accepts every connection to
testtool.

Change-Id: I49e98613cf5fb5dc33c8ccb465cdc16044b33f5e
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Add credential handler for PublicKey auth

Change-Id: I073188bede6fb592147da5891793cf84abced276
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: introduce netconf keystore service

Change-Id: I97e1e65029c339bd28557787841d485392cf9c44
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: introduce new Credential types

Introduces credential types for:
  -encrypted passwords
  -unencrypted passwords
  -key-pair authentication

While keeping backwards compatibility with the old way of storing
credentials as a deprecated case.

Change-Id: Ifb7cfaa5284467639d6c0e1d8bac2b4b5876bedc
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: netvirt master 7a57198d127db52706009dc135180fd910748739

Bug9245: Table=21 related exceptions fixes

https://jira.opendaylight.org/browse/NETVIRT-940

Change-Id: I66ae23bd3fd9ad1e2a80648672f8120ffd3beea3
Signed-off-by: ehvkand <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>

Updated git submodules

Project: infrautils master 1b3c5ee62a7d076833b55ca1fd4057785eb9e23a

Stop JobQueueHandler thread gracefully on destroy

In the JobCoordinatorImpl, we should stop the JobQueueHandler thread
as part of destroy. I've seen unit tests fail due to a
RejectedExecutionException from the fjPool (due to error logged
with the LogCaptureRule) b/c the thread isn't stopped.

Change-Id: Ib7ea6333f06406a77b5410868b9235a54b582033
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 96a31e940c928a6d1db1dc7c3d49bf08e1703149

testutils InterfaceHelper with correct @NonNull read

Change-Id: I0936c2894c7cd153016b51dc5717c104714e1c27
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master fbc84c5c40738f446bb32cd3026bd7334c39c54d

SRM: Add implementation code

This adds the following:
1. RPC Implementation in impl and required util class
2. CLI for SRM as mentioned in spec.
3. Debug CLI to clear out SRM operDS.

These cover Work Items 3 and 4 of SRM Spec.

Change-Id: I04553678580ff53217c7757594cdd836aa8abfae
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Updated git submodules

Project: netvirt master bdce2dc854bdc636961fd684ccedbd83dcea25eb

Use JobCoordinatorTestModule in aclservice component tests

This is required to be merged into netvirt at the same time as the
related change https://git.opendaylight.org/gerrit/#/c/60303/ goes into
genius; that one introduces the JobCoordinatorTestModule as part of
making genius' DJC delegate to infrautils' JC (and by doing so, breaks
the aclservice component tests).

Change-Id: I0f2c5258315f40f9db88806fe0a33619f0f7bb77
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: integration/test master 2366630d84886473298f9441bc3f0abed78f8d9a

IPv6: get IPV6_ADDR_POOL values from Variables

Get values for NET1_IPV6_ADDR_POOL and NET2_IPV6_ADDR_POOL from
netvirt/Variables.robot, instead of declare them at the beginning.

Change-Id: Idac6f6df96e95e7193bb756c3d5f657dd8e74034
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>

Updated git submodules

Project: integration/test master 6c85946682eb1f2af02f495ff523ad2e36becb8e

CSIT: move NET1_IPV6_ADDR_POOL in Variables

Change-Id: If49d1179cdab507c351cbfab39afd4732a1ed75e
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>

Updated git submodules

Project: integration/test master 3368174b1f602df2748aca11cf1e311614b5a42e

Fix VTN Coordinator Oxygen Job Failure

VTN Coordinator Oxygen fails to install VTN Coordinator.
* Path added to the test file to be able to download and install
VTN Coordinator.
* Patch also modifies the image path/name for Nitrogen/Carbon also.

Change-Id: I4882a1d6d7dfd837bf4e507b764802cfe6c54de4
Signed-off-by: ananth <ananth.y@hcl.com>

Structure M0 status for parsing

Change-Id: I5859f89e5f5440aae06b66db8fdfb3ecc6a0f257
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add a script to generate M0 status

New script generates M0 status report from all of the available m0
status documents. This requires that projects submit documents in a well
formed parsable text so we need to be more strict about formatting when
projects submit these documents.

Change-Id: Ib8bc0d18278d607379f6d1940669cf2fef1a0e10
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: genius master e9b4ff57b74356e8ef0b5178924b3731f50e690e

Make @Deprecated DataStoreJobCoordinator delegate to infrautils'

In an ideal world, we would instead now switch all uses of the
@Deprecated DataStoreJobCoordinator everywhere in genius and netvirt to
the new infrautils' JobCoordinator @OsgiService instead of having to do
this, but I would propose to do it in 2 steps and get this in first
(now), and then starting migrating, and then once everyone is off
DataStoreJobCoordinator and there are no usages left, delete it.

At least like this we would have only one version of this code, instead
of maintaining 2 split incarnations in genius and infrautils.

Also, and importantly, this change includes new infrastructure making it
easy to use JobCoordinator in the netvirt aclservice and genius
interfacemanager component tests, as used in IdManagerTest, see also
TestableJobCoordinatorEventsWaiterTest.

This change must be merged into genius at the same time as
I0f2c5258315f40f9db88806fe0a33619f0f7bb77 will go into netvirt.

This change requires I5e423212e8f720fb4b20837f12ad59de6f2a66d4 in
infrautils.

This change includes the fix for bug GENIUS-93.

Change-Id: I2043d32d612fb63990721908ccfff33a3ddf0689
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: integration/test master 8055df6c2033a4216eebd1dc957987d7de2c9451

Remove VPN service and BGP VPN service

VPN service suite is already being run in
netvirt job, so don't run it again in the
l2gw job.

A new job will be created for BGP VPN
test suite.

Change-Id: Ia84de3da41c8e9155b217aeccd032c719bc06d6c
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Updated git submodules

Project: integration/test master 39bdbc25b9d9fe7456d271aa6c7a4c03c6b3d55c

Remove unused BFD suite

this suite is not in use. Email discussion here:
https://lists.opendaylight.org/pipermail/genius-dev/2017-October/001929.html

Change-Id: Ibb121029e19a8ac5333895265217c742db69f613
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: integration/test master 206bf0e24e9980d6293c38c92368f33af334c327

Ignore pep8 E722

Existing code has started to fail on this error and causing
verify jobs to fail that have nothing to do with said existing
code. For now, we can ignore this to let work continue in
the int/test repo.

A jira ticket will be opened for someone to fix those related
erorrs (example below) and then remove this ignore = E722
statement.

Example:
./csit/libraries/AAAJsonUtils.py:208:13: E722 do not use bare except'
except:
^
Change-Id: Iee989ea6f2bcc3149988eb2e430fc7246c2d97e2
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master df471eb655b5343e5ea9359e5200cb2bddc75b01

Add case to capture exception log

Change-Id: I2610be4386c804e2667381b76347398ef4cbf47a
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: genius master 376ea56b13c0ee170566c3dc7d351325735ea509

JavaDoc for AbstractAsyncDataTreeChangeListener

Change-Id: Ie8acafc15f280c9a7e08c13a6dcbcb5d2ee0bdf5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Fix formatting to remove block quotes

Change-Id: I18487a7712a33005d6779eb5ed518f9aedb267cf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: sfc master d5e94d3ee53ce1552e64f2cacee33ead4b27e6bc

Migrate ServiceFunctionChainListener to Genius' Listeners

Change-Id: I26eaa162202c497fd286d1c028216c519997e69b
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: sfc master 2db2da7700557b01238ba2bc17f1e7c52bbe9f1f

Migrate ServiceFunctionForwarderListener to Genius' Listeners

Change-Id: Ie09ee0efe4fde576b366a95a85ff41cd55f87488
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: genius master ab859e6ab07dfbc8b96912c9c5c861f56bd304dc

Remove IdManager from ItmManagerRpcService & ItmUtils as unused there

NB however that it *IS* used in some other ITM classes, incl. e.g.
ItmProvider, TransportZoneListener, ItmTepRemoveWorker, ItmTepAddWorker.

Change-Id: I8fa1f2f21dd9de343ba45c5bfa80e674c880d78e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master fec0073065ffaac5207b22aeaecf7996c6ff63bd

Add component-based removeFlow()

... which will be used in NetVirt to simplify flow removal methods.

Change-Id: Id882570c15f018ce751b3829fac4a446f4aecfc8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master 17d37057bc0d5d0f660db55f28fc9bc9fb3ac452

Interface manager: split makeTunnelIngressFlow

Having separate add/remove methods allows the removal path to be
simplified, and avoids having an obscure “addOrRemove” parameter.

Change-Id: Ie144e64fd8ab6cc84cfb1ed9ebc265df00e8e6b7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master ab2faf37a4795404152f6c867564d5f42bcdb86d

Aliveness monitor: manage transactions

Use the transaction manager to handle all write transactions.

Change-Id: I8d8b4d4fbf1bb03aaee54e19f37d2345dc36bb56
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: netvirt master 78ed7962fdc857d0f06e87e84aac8691132a701f

Convert aclservice-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I8471f5e1734d12ce88d05e1ff9ee120822e591eb
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master a0a50eed57b327df5338fcb61f6d812bed7af76a

Convert neutronvpn-imp to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I9c4fba9147a72ab48ff7bc1bdb38a02a8c38515e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 9af10efe3016eea3de1f203538ac1966d54421e7

Convert elanmanager-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: Ic0b4cbc2fc6b3e11958841d2704407f38edf7504
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master d3ac7e5e5be4fe913d8eb919c4b20b1c0d89a7d4

Convert vpnmanager-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

The ArpMonitoringHandler previously used the EntityOwnerUtils to
register its candidate which has the side effect of registering
a global EntityOwnershipListener that maintains local ownership
state for all entities in a static cache. It also stores change
events in a static (unsycnhronized) EVENTS_HISTORY list which grows
unbounded. It seems this is only used in one place to print the
history via a CLI command. Both these side effects are problematic
and I don't think need/should be propagated forward.

Change-Id: Ied8e3f061c798de9a0e8af97e13fc9dd7e5d51a6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: releng/builder master cc5e42171b07d6abdafc30a79d69b49a6e163500

Merge "Fix for generating log.html in Netvirt CSIT jobs"

Fix for generating log.html in Netvirt CSIT jobs

This patch adds "--flattenkeywords" option to pybot so that
we can avoid the debug from the loops in the test cases.
suggestion based on this url -[0]
[0]- https://github.com/robotframework/robotframework/issues/1833

Change-Id: Iebdf0745666a8c009ddab1292d4c2b8986207418
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Updated git submodules

Project: releng/builder master 0b05846188c0cab8aa0b7f08fa41fd268e1f4221

Merge "Rename l2gw csit trigger for netvirt"

Rename l2gw csit trigger for netvirt

Make the trigger for l2gw csit consistent between ovsdb
and netvirt.

Going forward, to trigger the l2gw csit for netvirt patches:
test-netvirt-l2gw

for ovsdb patches:
test-ovsdb-l2gw

Change-Id: I5f5e2f48dc4aaa9cc2b5b5cc58fd5b49edee8822
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Merge "Make project name consistent between m0 and m1"

Make project name consistent between m0 and m1

Project names are inconsistent between m0 and m1 milestone
readouts.

Change project names in m0 and/or m1 for inconsistent
projects to make them consistent.

Change-Id: I89139d2e4997ce85d91f1ea1bd1e348d5c8862e4
Signed-off-by: klou <klou.external@gmail.com>

Updated git submodules

Project: ovsdb master bf3ddd35cfe8293cc9dfb99b2222c386a0e33ad3

bug 8712 vlan bindings update fix

when global node and physical switch node are updated in same transaction
from application, vlan bindings are missing.

Make vlan bindings participate in dependency workflow.

Do not create/delete port from controller.
Only update the port from controller.
port creation happens from device always.

Added port reconciliation when port is added later.

Change-Id: Ic86a3545428e186f3aeb26c8a36a783f774ecf53
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
bug 7599 avoid unnecessary mdsal reads

avoid the un necessary reads.
skip monitoring version column

Change-Id: I82e50b973a93c57eb65dd34c6dd624c8e47e2344
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>

Updated git submodules

Project: netvirt master b48fb802cbfbb7f5fa39a6a3e39dc50f97897e98

NETVIRT-926 - Maxpath value should be between 1 to 64 in BGP multipath

Adding a check to ensure maxpath value for BGP multipath is in the range 1 to 64

Change-Id: I6797caca05efe35242ed6a44b73ca28827b5edfe
Signed-off-by: Gowri R <gowri.r@ericsson.com>

Updated git submodules

Project: netvirt master 8578c324970e83e30bb10b8bdd85620ffe980599

Bug 9234: CSS programmed wrongly with TOR mac

With these changes following improvement has been done.
1. All cache update are now happening inside DJC job .(DPNInterfaces
cache , ELan L2gwDevices , ELan Devices and Mac addresses)
2. Upon node Disconnect macs are not being withdrawn now from other
devices.
3. Upon node reconnect macs are scanned for stale entries and are
cleared .

LocalUcastMacListener has been added newly with the new childListener
class which listenes to parent node and processes child node if
required.
DPN cache , TOR cache and Mac cache were not synchronized properly
,leading to race conditions which is fixed in this.

Change-Id: I440e17750c86bc132b75222a91a06654126f9b75
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>